Time  Nick             Message
06:19 alex_a           Bonjour
06:19 wahanui          privet, alex_a
06:38 reiveune         hello
07:12 ashimema         morning koha
07:17 magnuse          \o/
07:19 Guest1967        good morning
07:19 cait1            good morning all
07:30 Oak              morning all
07:30 magnuse          Ok
07:30 magnuse          Oak
07:31 Oak              magnuse
07:31 magnuse          \o/
07:31 Oak              \o\
08:40 huginn`          News from kohagit: Bug 27945: Terminology: max daily => open requests limit <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=788afd38c78ecccf87f0fb38a980f5f2c52cb314>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Fix shipped notice <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bebe7a1c10ce4e16a6c42d6fcb370a4a3da11b62>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Make parameters a hashref <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e85290a7032221d61c0473a28138752cba415e1a>
08:40 huginn`          News from kohagit: Bug 27947: DBIC schema changes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2fccde3acdd883a6df4ff0d0f28069fca16124db>
08:40 huginn`          News from kohagit: Bug 27947: DBRev 21.06.00.029 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=924bcc5754e9dd8a601e0b2e58156873ebe260d5>
08:40 huginn`          News from kohagit: Bug 27945: Don't save rule if not defined <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=96b1c3fa00b84093dde728e8d62f1f1db0298677>
08:40 huginn`          News from kohagit: Bug 27945: Fix error handling and translatability <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=82155cdf35fa215e3d7bc600951f7594e4d166c3>
08:40 huginn`          News from kohagit: Bug 27945: Implement limits using circulation rules <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c4fa722df7996b18db1a6dfd9e9c265468b5ecc>
08:40 huginn`          News from kohagit: Bug 27945: Add max_daily_article_requests circulation rule <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=558977ac229f8547c8b1fd190c6209762d0b10a5>
08:40 huginn`          News from kohagit: Bug 27945: Clarify 'same day' behavior <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ed86ec73084937981092c623d548913954ae2214>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Clarify permissions <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9c4a1b19aa86b246ea2528a6f1a33401d1007fae>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Update test to highlight issue <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=77506a474a799928779c14620666bc9b27ffd697>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Remove incorrect permission check <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b3bc8c21b25d31bb7d38f9af5c53740e7ce76a6c>
08:40 huginn`          News from kohagit: Bug 27947: Add regression tests for routes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9b4cee4e9983bdb773729b3fbd39b503010e7a9>
08:40 huginn`          News from kohagit: Bug 27947: (QA follow-up) Refactor routes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dc79aa0f40f50f6c0d26fecf249b0b69fd3dc7ba>
08:40 huginn`          News from kohagit: Bug 27947: (follow-up) Add OPAC cancellation as new reason too <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c53a907c66aab7f932f3bf09924084935aae5962>
08:40 huginn`          News from kohagit: Bug 27947: (follow-up) Improve atomic update <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6c76399c42ef5c6124f5119a63a8c2f86c70b95a>
08:40 huginn`          News from kohagit: Bug 27947: Add cancellation reason to article request <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a10af0620330b80841e67d4563227ef7c9d79a07>
08:40 huginn`          News from kohagit: Bug 27947: Add authorised values list in article requests cancellation <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1b73fac8105aa8968ce87f7a11193820cc767f4c>
08:40 huginn`          News from kohagit: Bug 27945: Add limit article request feature <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1ccfaa0d0335382f8ba66f1d2dea5972e2116ccd>
08:45 koha-jenkins     Project Koha_Master_U_Stable build #262: FAILURE in 3 min 5 sec: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/262/
08:45 koha-jenkins     Project Koha_Master_D12 build #25: FAILURE in 5 min 27 sec: https://jenkins.koha-community.org/job/Koha_Master_D12/25/
09:24 koha-jenkins     Project Koha_Master_U20 build #195: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_U20/195/
09:31 koha             hello
09:32 koha             if anyone know about  FindDuplicate uses 'exact' for searching.
09:49 koha-jenkins     Project Koha_Master build #1761: UNSTABLE in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master/1761/
10:02 koha             Hello
10:05 Joubu            koha: yes, it's using 'ti,ext' and 'au,ext': exact search
11:10 tcohen           good morning
11:28 * cait1          waves
11:28 koha             ok
11:29 tcohen           hi cait1 Joubu ashimema khall oleonard
11:44 * oleonard       waves and disappears into an irl meeting
11:46 marcelr          hi #koha
11:47 marcelr          tcohen: something wrong with creating new article requests on master now? i see fields not filled like created_on
11:48 tcohen           marcelr: looking
11:51 tcohen           yes, this is so weird to read in the code
11:51 Joubu            marcelr: I've pushed a bunch of "article requests" related patches this morning
11:51 marcelr          yeah i am testing / rebasing on top of that
11:51 tcohen           I have a fix, but let me write some regression tests
12:04 tcohen           marcelr: bug 29182
12:04 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29182 normal, P5 - low, ---, tomascohen, NEW , ArticleRequest status changing methods calling SUPER::store
12:06 marcelr          ok tcohen i am on it
12:07 Joubu            tcohen: why isn't created_on not null?
12:08 tcohen           because mysql allows only one CURRENT_DATE trigger (used in updated_on) and the overloaded ->store is in charge of setting it, but, somehow, two methods call SUPER::store
12:09 Joubu            we could set it in ->new then
12:11 tcohen           marcelr: I added a follow-up Joubu will like
12:11 tcohen           Joubu: all this needs to be refactored, I think I even filed a bug for this
12:12 marcelr          i will rebase 29182 on it now
12:12 marcelr          sorry 29093
12:12 tcohen           bug 29093
12:12 marcelr          which already had PQA
12:12 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 enhancement, P5 - low, ---, m.de.rooy, BLOCKED , Article requests: Checkbox for table of contents
12:12 tcohen           let me know if you need testing there
12:12 Joubu            -        return $self->request;
12:13 Joubu            is this correct?
12:13 tcohen           where?
12:13 tcohen           that's the design problem
12:13 marcelr          wait is there another followup too now?
12:14 tcohen           marcelr: yes
12:14 tcohen           Joubu: context?
12:15 tcohen           Joubu: that's the design problem with Koha::ArticleRequest, it is different than the rest of new Koha::* classes in that all methods implicitly call ->store
12:15 tcohen           that's why this needs refactoring
12:15 Joubu            tcohen: I made created_on NULL and there is no failure on ->new
12:15 Joubu            and ->store populate it correctly
12:15 Joubu            *NOT* NULL I mean
12:15 Joubu            I don't understand why it's NULL
12:16 tcohen           the problem is not in ->store
12:16 tcohen           the problem is that we don't do Koha::ArticleRequest->new->store
12:16 tcohen           we do Koha::ArticleRequest->new->request
12:16 tcohen           we will solve this with a refactoring
12:16 marcelr          how dare you :)
12:17 tcohen           haha
12:17 marcelr          just waiting
12:17 tcohen           Joubu: will approve my follow-up
12:17 marcelr          "we will solve this with a refactoring" -- should be in some top 10
12:17 tcohen           I already started
12:18 tcohen           I got stuck because you guys cannot make a decision haha
12:18 marcelr          i will be submitting 29093 in a minute
12:18 Joubu            make it NOT NULL :D
12:19 Joubu            same bug report
12:19 tcohen           nahw, I mean bug 28883
12:19 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 normal, P5 - low, ---, tomascohen, In Discussion , Koha::Objects->_new_from_dbic doesn't work correctly in list context
12:20 tcohen           Joubu: you're implying Koha/Patron.pm:222 is not needed anymore?
12:21 Joubu            no, it is needed
12:22 Joubu            you cannot have 2 DEFAULT current_timestamp() on the same tables, so we keep it for the 'timestamp'/'updated_on'
12:22 tcohen           ok
12:22 Joubu            for the other attributes, the default must be done in ->store (or new)
12:22 Joubu            looks like it's working if it's in store so keep it there
12:22 tcohen           great
12:23 tcohen           I'm looking forward to enhance this module while adding more API routes for this
12:27 marcelr          tcohen: do you seen this warn in opac-error: [WARN] No circulation AR_REQUESTED letter transported by email at /usr/share/koha/C4/Letters.pm line 632.
12:28 marcelr          plack-
12:31 marcelr          you can probably ignore that one; almost all of my notices are gone, maybe a crashed test unit or so :)
12:34 Joubu            yes
12:34 Joubu            t/db_dependent/cronjobs/advance_notices_digest.t
12:34 Joubu            It's a really bad one
12:35 Joubu            see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478#c26
12:35 huginn`          Bug 20478: enhancement, P5 - low, ---, andreas.jonsson, CLOSED FIXED, Advance notices: send separate digest messages per library
12:37 Joubu            marcelr: ^^ that was for you
12:42 marcelr          if we know the cause, the solution is close
12:43 marcelr          bug 24326
12:43 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 normal, P5 - low, ---, chris, NEW , Problem with advance_notices_digest.t
12:43 marcelr          nothing much happened there cait
12:58 huginn`          News from kohagit: Bug 25429: DBRev 21.06.00.030 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ce74ab1330b4eedfa3502c85a4a6b8bdb009bd9>
12:58 huginn`          News from kohagit: Bug 25429: (QA follow-up) Add extra variable for days <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c0f722a3ad944a3811199e67ab88af9cd55328b>
12:58 huginn`          News from kohagit: Bug 27526: Add tests for columns_to_str and host_items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cc1c2cbaaf63a89e76b056781270902a7cd7c475>
12:58 huginn`          News from kohagit: Bug 27526: Add missing POD <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=33d4367cd81ad79f267583644d6b9b694b518bac>
12:58 huginn`          News from kohagit: Bug 27526: Fix cn_source display <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6560049c65d911905090afa3bf261984fa4b35f1>
12:58 huginn`          News from kohagit: Bug 27526: Fix encoding issue on subfield <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9f1d78e8750a5c02e0e6e73f4185a5ffc18bed83>
12:58 huginn`          News from kohagit: Bug 25429: Require command line switch to enable, control DAYS via syspref <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5e4c7ce2129d093fb7a3f6415691814ea2bae36c>
12:58 huginn`          News from kohagit: Bug 25429: Use filter_by_last_update <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f28e817ea57a2dddb0fc803e0caf56170e45c489>
12:58 huginn`          News from kohagit: Bug 28026: Add call_recursive() as a supplement for call() <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fc68d49897900fb365e3016ba38fbc10be77d14f>
12:58 huginn`          News from kohagit: Bug 27032: (follow-up) Pass rather than fetch variables <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=478ffeae6030bc774f8b752b3c19e75879a3bad9>
12:58 huginn`          News from kohagit: Bug 26352: Switch from using call() to call_recursive() <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4f533776c609463a88db560f447874f351e8d131>
12:58 huginn`          News from kohagit: Bug 25429: Script should be able to run with only return claims <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2a8dc21a6a4d557dd09d1f41ed4770657b494d72>
12:58 huginn`          News from kohagit: Bug 26352: (QA follow-up) Add additional tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ec3bce4fa1de3a080db2d38904c0bfc0f71d1b98>
12:58 huginn`          News from kohagit: Bug 26352: Replace call to barcode_generate with call to patron_barcode_transform <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b00aab7052490a2e1acf42295bc6e2772c26d6d3>
12:58 huginn`          News from kohagit: Bug 27032: Move auto renewal code out of CanBookBeRenewed <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c862fd13823633266ac3206bbce4d44cd65715bd>
12:58 huginn`          News from kohagit: Bug 27032: Remove unused variables <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b246015cad44fb2b1cec9ac7dbd3345f19312612>
12:58 huginn`          News from kohagit: Bug 26352: Add unit test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0b2554d5f0d3828d6b558a8f22e9ddfd558aa07>
12:58 huginn`          News from kohagit: Bug 26352: Add plugin hooks to transform patron barcodes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=aea8ce7fccf4b2e09de74d12d2d0e03bfaea65c0>
12:58 huginn`          News from kohagit: Bug 26351: Add plugin hooks to transform item barcodes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b2b1483f4d829512b7d92723b587a7f060de57bb>
12:58 huginn`          News from kohagit: Bug 25429: Cleanup Database - remove resolved claims returned from db after X days <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e18cfe0731941a6aeba841e49b7ad09a5fd04cb2>
12:59 marcelr          push_day++
13:00 marcelr          hi khall, all your patches are pushed right now
13:08 koha-jenkins     Project Koha_Master_D12 build #26: STILL FAILING in 7 min 52 sec: https://jenkins.koha-community.org/job/Koha_Master_D12/26/
13:11 tcohen           magnuse: I'm looking at bug 18984, what about the z3950 servers? don't we still need to support NORMARC for them?
13:11 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Remove support for NORMARC
13:13 pastebot         "tcohen" at 127.0.0.1 pasted "magnuse Joubu" (8 lines) at http://paste.koha-community.org/3412
13:13 caroline_catlady Hello everyone!
13:27 jzairo           Hello!
13:32 magnuse          @quote random
13:32 huginn`          magnuse: Quote #344: "Beware the tyranny of small differences." (added by wizzyrea at 01:55 AM, October 20, 2020)
13:33 magnuse          @quote add marcelr> if we know the cause, the solution is close
13:33 huginn`          magnuse: The operation succeeded.  Quote #354 added.
13:38 oleonard         davidnind++
13:41 tcohen           davidnind++
13:41 tcohen           always
13:42 tcohen           oleonard++ # too
13:46 marcelr          hi magnuse why that quote if any ?
13:46 marcelr          lol
13:46 marcelr          tcohen++
13:48 koha-jenkins     Project Koha_Master_U20 build #196: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U20/196/
14:00 koha-jenkins     Project Koha_Master_U_Stable build #263: NOW UNSTABLE in 58 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/263/
14:01 koha-jenkins     Project Koha_Master build #1762: STILL UNSTABLE in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master/1762/
14:41 koha-jenkins     Project Koha_Master_D12 build #27: STILL FAILING in 7 min 45 sec: https://jenkins.koha-community.org/job/Koha_Master_D12/27/
15:01 pastebot         "tcohen" at 127.0.0.1 pasted "Joubu marcelr" (54 lines) at http://paste.koha-community.org/3416
15:02 tcohen           ^^ ashimema
15:04 ashimema         :-)
15:14 ashimema         Looks good to me tcohen
15:15 ashimema         'tis what I was thinking.
15:24 caroline_catlady does anyone know why expired serial subscriptions still generate issues?
15:24 caroline_catlady Example, I have a serial that expired in october, but I can still generate and receive issues in that subscription
15:25 caroline_catlady The manual says If your serial subscription has expired you won’t be able to receive issues.
15:25 caroline_catlady https://koha-community.org/manual/20.11/en/html/serials.html#renewing-subscriptions
15:25 caroline_catlady was this never true, or is it something that changed?
15:28 koha-jenkins     Project Koha_Master build #1763: STILL UNSTABLE in 58 min: https://jenkins.koha-community.org/job/Koha_Master/1763/
15:32 Joubu            caroline_catlady: the code says if it's not closed you can receive
15:33 caroline_catlady ok thanks for checking Joubu !
15:34 caroline_catlady So "expired" is just a reminder to renew with your vendor, but it doesn't do anything other that that
15:35 caroline_catlady *than that
15:37 Joubu            there is more than that, but the code is too ugly for my brain right now
15:37 caroline_catlady lol!
15:37 Joubu            there is a subroutine HasSubscriptionExpired that passes a flag 'subscriptionexpired' to the template
15:37 Joubu            and some part of the template are hidden
15:37 Joubu            like "add item"
15:38 caroline_catlady oh I haven't tried with a sub that generates items, I will try
15:40 caroline_catlady the subscriptionexpired flag is probably to show the warning
15:40 caroline_catlady https://snipboard.io/KbYOHc.jpg
15:42 Joubu            https://snipboard.io/qgaF9B.jpg
15:42 Joubu            Those "click to add item" links
15:43 Joubu            well, the last one is displayed when it's expired, not the first two (bug or feature?)
15:44 Joubu            see you tomorrow!
16:34 cait1            caroline_catlady: it could make sense for the ones still missing - in case they get delivered late
16:34 cait1            but i remember being scard off by the question of expiration for serials before
16:35 cait1            bye all
16:35 oleonard         caroline_catlady: Each person tosses you a treat and then runs away
17:22 caroline_catlady oleonard: yeah, serials scare a lot of people, even Joubu and cait lol!
17:36 koha-jenkins     Project Koha_Master_D11 build #400: UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D11/400/
18:02 koha-jenkins     Project Koha_Master_D11_CPAN build #440: UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/440/
18:06 koha-jenkins     Project Koha_Master_D10_My8 build #656: UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/656/
18:09 koha-jenkins     Project Koha_Master_D11 build #401: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D11/401/
18:19 koha-jenkins     Project Koha_Master_D9 build #1771: UNSTABLE in 1 hr 15 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1771/
18:56 koha-jenkins     Project Koha_Master_D9 build #1772: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1772/
19:04 oleonard         Your branch and 'origin/master' have diverged, and have 1 and 3507 different commits each, respectively.
19:12 oleonard         I can't remember if I'd found a problem with my patch for bug 26486 or if I'd just started to write a test plan and got tired.
19:12 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26486 enhancement, P5 - low, ---, oleonard, ASSIGNED , Group edit buttons in reports toolbar
19:13 * cait           sends oleonard cookies
19:19 * oleonard       gratefully accepts, saves them for tomorrow when he will get back to it
19:19 cait             you are much stronger than me
19:19 cait             :)
20:39 reiveune         bye
21:22 koha-jenkins     Project Koha_20.11_U_Stable build #42: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/42/
21:31 koha-jenkins     Project Koha_20.11_D11 build #164: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/164/
21:46 koha-jenkins     Project Koha_20.11_D11 build #165: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/165/
22:09 koha-jenkins     Project Koha_20.11_U_Stable build #43: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/43/