Time Nick Message
20:55 koha-jenkins Project Koha_21.05_D9 build #65: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/65/
20:41 koha-jenkins Project Koha_21.05_U16 build #64: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/64/
20:39 koha-jenkins Project Koha_21.05_U16 build #63: FIXED in 41 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/63/
20:39 wahanui Congratulations!
20:39 koha-jenkins Yippee, build fixed!
20:21 koha-jenkins Project Koha_21.05_U20 build #69: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/69/
20:07 koha-jenkins Project Koha_21.05_U18 build #62: SUCCESS in 1 hr 10 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/62/
19:59 koha-jenkins Project Koha_21.05_D11 build #81: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/81/
19:58 koha-jenkins Project Koha_21.05_U_Stable build #62: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/62/
19:28 koha-jenkins Project Koha_Master_D12 build #24: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D12/24/
19:28 wahanui Congratulations!
19:28 koha-jenkins Yippee, build fixed!
19:25 koha-jenkins Project Koha_21.05_U20 build #68: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/68/
19:18 koha-jenkins Project Koha_21.05_U16 build #62: UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/62/
19:03 koha-jenkins Project Koha_21.05_D9 build #64: FIXED in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/64/
19:03 wahanui Congratulations!
19:03 koha-jenkins Yippee, build fixed!
18:57 koha-jenkins Project Koha_21.05_D11 build #80: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/80/
18:37 koha-jenkins Project Koha_21.05_U18 build #61: FIXED in 41 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/61/
18:37 wahanui Congratulations!
18:37 koha-jenkins Yippee, build fixed!
18:28 koha-jenkins Project Koha_21.05_U_Stable build #61: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/61/
18:28 wahanui Congratulations!
18:28 koha-jenkins Yippee, build fixed!
18:11 koha-jenkins Project Koha_21.05_U16 build #61: FIXED in 36 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/61/
18:11 wahanui Congratulations!
18:11 koha-jenkins Yippee, build fixed!
18:08 koha-jenkins Project Koha_21.05_U20 build #67: FIXED in 49 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/67/
18:08 wahanui Congratulations!
18:08 koha-jenkins Yippee, build fixed!
18:00 koha-jenkins Project Koha_20.11_U18 build #129: FIXED in 57 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/129/
18:00 wahanui Congratulations!
18:00 koha-jenkins Yippee, build fixed!
17:55 koha-jenkins Project Koha_21.05_D11 build #79: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/79/
17:55 wahanui Congratulations!
17:55 koha-jenkins Yippee, build fixed!
17:35 koha-jenkins Project Koha_Master_D12 build #23: NOW UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D12/23/
17:31 koha-jenkins Project Koha_Master_U_Stable build #261: FIXED in 58 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/261/
17:31 wahanui Congratulations!
17:31 koha-jenkins Yippee, build fixed!
16:15 koha-jenkins Project Koha_Master_D12 build #22: STILL FAILING in 5 min 27 sec: https://jenkins.koha-community.org/job/Koha_Master_D12/22/
16:05 koha-jenkins Project Koha_Master_D11 build #399: FIXED in 58 min: https://jenkins.koha-community.org/job/Koha_Master_D11/399/
16:05 wahanui Congratulations!
16:05 koha-jenkins Yippee, build fixed!
15:55 koha-jenkins Project Koha_Master_D10_My8 build #655: FIXED in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/655/
15:55 wahanui Congratulations!
15:55 koha-jenkins Yippee, build fixed!
15:51 koha-jenkins Project Koha_Master_D10_MDB_Latest build #698: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/698/
15:41 koha-jenkins Project Koha_Master_D11_CPAN build #439: FIXED in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/439/
15:41 wahanui Congratulations!
15:41 koha-jenkins Yippee, build fixed!
15:36 koha-jenkins Project Koha_Master build #1760: FIXED in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master/1760/
15:36 wahanui Congratulations!
15:36 koha-jenkins Yippee, build fixed!
15:13 koha-jenkins Project Koha_Master_U20 build #194: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U20/194/
15:12 wahanui Congratulations!
15:12 koha-jenkins Yippee, build fixed!
15:10 Joubu Bye #koha, have a great weekend!
15:04 Joubu mtj: looks like there is something wrong with D12 and hirsute. D12 is missing JSON::Validator::OpenAPI::Mojolicious and Ubuntu is failing with "apache2: unrecognized service", hmmm??
14:44 reiveune bye
14:42 koha-jenkins Project Koha_Master_U_Stable build #260: STILL FAILING in 2 min 57 sec: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/260/
14:41 koha-jenkins Project Koha_Master_D12 build #21: FAILURE in 11 min: https://jenkins.koha-community.org/job/Koha_Master_D12/21/
14:38 ashimema and then need to work out what circ rules I need to think about.
14:38 ashimema just tying it into circulation now
14:37 ashimema my booking piece is coming along nicely :)
14:37 ashimema hense my quandry
14:37 ashimema only useful if you know how to get the instance ;)
14:37 ashimema hehe
14:35 koha-jenkins Project Koha_Master_U_Stable build #259: FAILURE in 3 min 10 sec: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/259/
14:34 cait as long as you understand that...
14:34 oleonard "After instantiation, all hooks can be accessed via the instance’s config object. Inside the object, all functions are stored in arrays" Good to know.
14:30 huginn` News from kohagit: Bug 23678: Allow cancel holds in bulk <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=954d2606a86fbd12dfdc7164b73263e000744c6d>
14:30 huginn` News from kohagit: Bug 28352: Only check authorised values mapped to DB fields <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c7eb047126275fe9c38149697ee14c3834acabfe>
14:30 huginn` News from kohagit: Bug 29149: Add the capability to provide more info to the background job detail view <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=987a49406858daff25b33afbbda5e8ae087f930d>
14:30 huginn` News from kohagit: Bug 26080: (QA follow-up) Minor template issues <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c6eadceaa4007ff993180505e7e24a240e643a3>
14:30 huginn` News from kohagit: Bug 26080: (QA follow-up) Add POD <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ccc4be5dc91ba4ddb9a17fcd9b9dc8af60853c6b>
14:30 huginn` News from kohagit: Bug 29121: Add new plugin exceptions <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b937450ce5f39d6cc56c2fc4884b628c117bffb7>
14:30 huginn` News from kohagit: Bug 29121: Regression tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=edc8f4933585cae8986e4a1eae58cabf5ba07918>
14:30 huginn` News from kohagit: Bug 29121: Catch errors in ->install and ->upgrade calls on plugins <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=375a9197b1170b92c9cd27e809bb0dcfce050517>
14:30 huginn` News from kohagit: Bug 29121: Add POD to plugins <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=edfa6b9ffe808075c00761a204c4dbd9d6ca77b8>
14:30 huginn` News from kohagit: Bug 29139: $line->debit_offsets doesn't honor list context <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fc5c91f53f59af9e4f2ff203ebfd6e10196a1b9d>
14:30 huginn` News from kohagit: Bug 29137: Add new syspref to disable AV creation within the cataloguing module <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8ecc6b7007f6d1dde499c4ea32f9f3fcfc718b7>
14:30 huginn` News from kohagit: Bug 29139: Fix incorrect relation call <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88bf99cc08e8302f87a23b3a8549ec56322bab8a>
14:29 huginn` News from kohagit: Bug 29139: Add exceptions to relation accessors <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9c934a0a1c37c6f012f1b6316f8775aecefde74>
14:29 huginn` News from kohagit: Bug 29139: Add regression tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=33092c7f2a7cccbde7b72a5d776d088c1aaa378f>
14:29 huginn` News from kohagit: Bug 29139: Only pass the offsets for lines the credit was applied to <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5d82dc06594486a7f6b4db567d2399d9954daeac>
14:29 huginn` News from kohagit: Bug 23678: Don't display code of the job type <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dfb529215370c592448036c654b79647f7278ace>
14:29 huginn` News from kohagit: Bug 23678: Include file for batch_hold_cancel <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=de798994b2e386b2d197063e03deeace4d111a24>
14:29 huginn` News from kohagit: Bug 29149: (QA follow-up) Reorganize mapping <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=170020d453f3e6fdb57c9ea897da5e6efa75d574>
14:29 huginn` News from kohagit: Revert "Bug 28510: Remove unnecessary conditional" <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=58c765c492c14d7b311eb5102684fd594317a5fd>
14:29 huginn` News from kohagit: Bug 29137: DBRev 21.06.00.027 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fb1c0d483a8d921b528ae24101778e8149ede3b9>
14:28 ashimema anywho.. all sorted now I reckon
14:27 oleonard Yep.
14:27 ashimema remember it's in a modal.. so every time the modal was triggered.. up popped another button
14:27 ashimema the error was basically.. that every time I called 'flatpickr' I'd get another instance and thus another clear button appear next to the existing one
14:26 ashimema the .get(0) on a jQuery selector give's me the dom element which flatpickr sticks it's _flatpicker onto
14:25 ashimema I think I've sorted it anyway
14:25 ashimema but when I do that it claims to be undefined when I call set on it
14:25 ashimema I might be wrong
14:25 ashimema is that not getting a 'new' instance.. not the existing one
14:24 ashimema var instance = $("#myPicker").flatpickr;
14:24 ashimema lol
14:24 oleonard Why can't you define it as a var?
14:23 ashimema how do you get instance ;)
14:23 oleonard I'm not sure if this is what you're thinking of, but some pages use instance.set() to change an option on some event
14:19 ashimema .get(0)._flatpickr appears to do the trick
14:19 ashimema aha
14:18 Joubu lol
14:17 oleonard poor wahanui
14:17 wahanui ashimema: that doesn't look right
14:17 ashimema and change 'disable' to a set of dates returned by an API call
14:16 ashimema and onChange
14:16 ashimema I want to set mode
14:16 ashimema yes
14:16 oleonard ashimema: Is the real issue how to add options to the default flatpickr config?
14:14 oleonard Yeah, see I don't think I've done that before...
14:14 ashimema https://flatpickr.js.org/instance-methods-properties-elements/#retrieving-the-flatpickr-instance
14:14 ashimema because I want to get the existing instance
14:13 oleonard Why the underscore?
14:12 ashimema but it's always undefined
14:12 ashimema I thought `var periodPicker = $("#period")._flatpickr();` should do it..
14:11 ashimema I'm sure i've seen you do this.. but can't for the life of me remember where
14:11 ashimema but how do I grab the instance on modal open so I can dynamically set stuff on it oleonard?
14:10 ashimema but that's silly.. you create a flatpickr with a bunch of half decent defaults on any .flatpickr
14:10 ashimema I have been creating my own instance on the modal open
14:10 ashimema and I want to change some settings for it dynamically
14:09 ashimema I have a flatpickr inside a modal
14:09 ashimema my brain hurts
14:01 * oleonard was just adding some comments to a new JS function and remembered that some folks have rules about that kind of thing
14:01 ashimema which is.. I don't know :)
14:01 ashimema but they'll just be following what the folio community decided
14:01 ashimema the folio side might.
14:00 ashimema well...
14:00 ashimema afraid not
14:00 oleonard I'm curious whether your team uses some kind of JS documentation standard like JSDoc?
13:59 * ashimema is battling with flatpickr
13:59 ashimema yup
13:59 oleonard-away ashimema: still around?
12:55 lmstrand well thanks for the help oleonard, cait, have a nice weekend.
12:42 oleonard Ah, it's all so clear now ;)
12:42 cait mor or less
12:42 cait $order->{tax_value_on_ordering} = $order->{quantity} * get_rounded_price($order->{ecost_tax_excluded}) * $order->{tax_rate_on_ordering}; $order->{tax_value_on_receiving} = $order->{quantity} * get_rounded_price($order->{unitprice_tax_excluded}) * $order->{tax_rate_on_receiving};
12:42 cait for my acq question... i guess I have answered it myself now :)
12:40 cait paxed: i believe the manual is phrased badly and if you file it, we could fix it (or provide a reworded bit yourself as patch :) )
12:38 cait Does someone know which price the tax value is calculated from in tax_value_on_ordering and *_on_receiving?
12:24 oleonard lmstrand: I think it's an error in the description but I'm not familiar with the code.
12:21 lmstrand Not sure if this is a bug or a misguided feature description in the documentation.
12:18 lmstrand so it should have appeared if they indeed would run and refresh the reports cache
12:17 lmstrand it was a really heavy time consuming query we used in the report
12:16 lmstrand we tried to set cache expiry to 10secs and we never saw a mysql process with the report's query
12:15 lmstrand We could find no evidence that setting a report public makes it run on the background.
12:15 lmstrand https://koha-community.org/manual/21.05/en/html/reports.html#report-from-sql
12:14 lmstrand If your system administrator has set up memcache on your server you might see one more option for the Cache expiry. This is related to your public reports. If you make the report public then it’s constantly running and will cause a large load on your system. Setting this value prevents that.
12:14 lmstrand the manual says:
12:12 lmstrand the report didn't show up in mysql processes when you list them with SHOW FULL PROCESSLIST;
12:12 ashimema good luck oleonard
12:12 lmstrand we tried to produce a heavy sql query and set it as public
12:11 lmstrand is this false information?
12:11 lmstrand if you set a report as public in koha, the manual says the report will be run every x seconds defined in the cache_expiry setting
12:11 ashimema :)
12:10 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 enhancement, P5 - low, ---, oleonard, ASSIGNED , Use Flatpickr on calendar page
12:10 * oleonard digs back into Bug 28963
12:10 lmstrand I have a question regarding sql reports and their public status
12:10 lmstrand Howdy all.
12:05 ashimema nok thankyou for raising it :)
12:05 oleonard ashimema++
12:05 oleonard Looks good ashimema, thanks
12:00 ashimema ta
12:00 ashimema done
11:59 ashimema doh
11:55 oleonard "Select user" -> "Select patron"
11:55 oleonard One last request? :)
11:49 ashimema done
11:33 oleonard Nothing more complicated than what you wrote I think... On the checkout page for the "Renew" and "Check in" checkboxes
11:32 ashimema do we have prior art for that then?
11:31 ashimema fair enough.
11:31 oleonard ashimema: I think we should limit the click to the checkbox cell. I think adding it to the whole row is a little too much considering we don't do that anywhere else
11:30 paxed so, the manual is misleading about the public reports?
11:27 ashimema as you say.. we should probably also add a hidden label for accesability.
11:27 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 normal, P3, ---, nick, Signed Off , Checkout search with too many results (single character search) causes poor performance or timeout
11:27 ashimema let me know if that's enough on bug 15812 oleonard ;)
11:26 oleonard True
11:25 paxed the manual makes it sound like it's running all the time, even if no-one is using the system
11:24 paxed shouldn't that be "run when requested if older than cache"?
11:24 oleonard If you make a report public and then, for instance, add AJAX to your OPAC which pulls data from the report on every page load.
11:23 paxed wtf?
11:23 paxed re. saved reports, why does 21.05 manual say "If you make the report public then it’s constantly running and will cause a large load on your system."
11:06 oleonard We could add a hidden label and add the table-cell-click
11:00 ashimema humm
11:00 ashimema accessibility wise i image having a label is better though..
10:59 ashimema anywhere except the actual buttons or links of course
10:59 ashimema that would be an even bigger target..
10:59 ashimema that.. or click anywhere in the row to select
10:59 oleonard I can be convinced to give it up :)
10:59 ashimema I just struggle in my mind to see the link between 'cardnumber' and 'checkbox to the left of it'
10:59 oleonard My change was an easy one to make without adding any scripting, and the card number wasn't doing anything.
10:58 ashimema and then keep the change here for cardnumber being linked to checkout?
10:58 oleonard That's also possible. We've done that in other areas.
10:58 ashimema so you don't have to hit the checkbox.. just anywhere inside the cell that contains it
10:58 ashimema I'm wondering about whether we could just make the whole checkbox cell clickable instead?
10:58 oleonard Yes
10:57 ashimema is it basically that you like having the bigger hit area?
10:57 ashimema what's the win
10:56 oleonard merging the checkbox and cardnumber column might help
10:55 * ashimema is trying to think if there's any way he can have his cake and eat it too
10:55 ashimema to me, I'm not sure how 'click cardnumber to select' is at all intuitive?
10:54 ashimema but I also think the clickable cardnumber for checkout as an alternative made good sense
10:54 ashimema that to me felt weird
10:53 ashimema I didn't like it under the cardnumber
10:53 ashimema I like having the button in the actions field
10:53 oleonard To the button?
10:53 * ashimema prefers the 'checkout' link personally..
10:53 ashimema I'm not against restoring it.. but perhaps it should be more discoverable
10:52 oleonard Well it just went in, so hard to know
10:52 ashimema are people actually using it?
10:52 ashimema yeah
10:52 ashimema though to be honest.. I find that incredibly hidden
10:52 oleonard The label is a completely hidden thing, so I understand
10:51 ashimema sorry about that
10:51 ashimema Just seen your comment about the regression I caused
10:51 oleonard it is!
10:51 ashimema morning :)
10:51 oleonard Hi
10:50 oleonard Yup
10:50 ashimema oleonard around yet?
10:42 tcohen hola #koha
09:57 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Add plugin hooks for authority record changes
09:57 marcelr anyone for a signoff on bug 27173 ?
09:56 huginn` marcelr: The operation succeeded.
09:56 marcelr @later tell kidclamp pls have a look at 28831
09:44 ashimema much easier to understand
09:44 ashimema +1
09:37 Joubu marcelr: in this case, I much more prefer [% IF a && b %] :)
09:34 cait so let's work on that :)
09:34 ashimema sometimes we need a lift
09:33 ashimema yup
09:29 cait so easy to get lost between all the bugs and problem
09:29 marcelr cait++
09:29 cait I guess in general it's good to talk more good news
09:29 marcelr Joubu i told you that I dislike unless ;)
09:28 cait marcelr: it's a nice idea - I'll send me a reminder :)
09:28 ashimema doh!
09:28 ashimema damn it.. I need some SO's again now
09:27 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 normal, P3, ---, nick, Passed QA , Checkout search with too many results (single character search) causes poor performance or timeout
09:27 ashimema fridolin, how awesome is bug 15812 :)
09:27 Joubu want more negation?
09:26 Joubu [% UNLESS !$a || !$b %]
09:24 marcelr cait i would not mind if you put that number in your first qa mail of the month !
09:24 cait just doing my monthly things - next checking versions on the website
09:23 marcelr thats definitely a good direction
09:23 cait we definiteyl need to revisit the "at least 15.000 libraries" narrative :)
09:23 cait hm hea is up again this month: 15867 -> 16443
09:22 marcelr ashimema: today or the last 24 hours, haha
09:21 marcelr it helps you think if you really want to do it
09:12 ashimema that's even slower than normal ;)
09:12 ashimema well.. it just took circa 2 minutes to save my change to the roles page..
09:11 ashimema lol
09:11 Joubu s/today//
09:10 ashimema wow the wiki is slow today
09:07 marcelr yeah that can happen
09:07 * ashimema thinks he's missed something
09:07 marcelr tomas or agustin can deal with it :)
09:06 Joubu entre un jour et aujourd'hui, oui
09:06 marcelr but i wont touch your comments any further
09:06 marcelr Joubu: het verschil tussen een dag en vandaag
09:05 Joubu we don't want to check for 24h, but "one opening day"
09:05 Joubu anyway I don't think it's what the author wanted to do
09:05 Joubu yes, this is correct. But "same day" is not.
09:04 marcelr a day is a period of 24 hours, that sense
09:04 Joubu marcelr: "Read 'same day' here as last 24 hours." in which case this is correct? :D
07:55 marcelr hi #koha
06:25 magnuse \o/
06:18 alex_a Bonjour
06:13 reiveune hello