Time Nick Message 23:31 koha-jenkins Project Koha_Master_D9 build #1750: FIXED in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1750/ 23:31 wahanui Congratulations! 23:31 koha-jenkins Yippee, build fixed! 21:24 koha-jenkins Project Koha_20.11_D11 build #151: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/151/ 20:53 koha-jenkins Project Koha_20.11_U20 build #127: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/127/ 20:50 koha-jenkins Project Koha_20.11_D9 build #133: SUCCESS in 1 hr 16 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/133/ 20:42 koha-jenkins Project Koha_20.11_U18 build #119: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/119/ 20:39 koha-jenkins Project Koha_20.11_D10 build #139: FIXED in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/139/ 20:39 wahanui Congratulations! 20:39 koha-jenkins Yippee, build fixed! 20:36 koha-jenkins Project Koha_20.11_U16 build #112: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/112/ 20:29 koha-jenkins Project Koha_20.11_U_Stable build #30: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/30/ 20:15 koha-jenkins Project Koha_20.11_U20 build #126: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/126/ 20:09 koha-jenkins Project Koha_20.11_U18 build #118: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/118/ 19:32 fridolin super giga 19:13 * oleonard fades out 19:13 oleonard I can give it a test tomorrow if no one gets to it by then 19:12 oleonard fridolin++ 18:45 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 normal, P5 - low, ---, koha-bugs, Needs Signoff , Wording in authentication forms is confusing 18:45 fridolin oleonard: Bug 28914 if our UI expert can have a look please 18:08 oleonard kidclamp: We already have inconsistencies between how we present options for batch operations, this adds a new one. 18:06 oleonard I don't like the fieldset :( 17:58 kidclamp your radios look different, but maybe browser wise 17:57 oleonard The image I posted was what I saw. Is it different than what you saw? 17:56 kidclamp oleonard: that is nicer :-) I wasn't sure if you would like the fieldset 17:56 oleonard Sorry we ran out of coffee 4 hours ago 17:55 fridolin ^^ 17:55 fridolin coffee please 17:55 fridolin oleonard: salutations 17:51 oleonard Hi fridolin 17:50 fridolin hi 17:29 koha-jenkins Project Koha_Master_D11 build #374: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D11/374/ 17:16 koha-jenkins Project Koha_Master_D9 build #1749: NOW UNSTABLE in 59 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1749/ 17:14 koha-jenkins Project Koha_Master_D10_My8 build #641: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/641/ 16:58 tcohen anyone familiar with our move to bcrypt for password? 16:57 koha-jenkins Project Koha_Master_U_Stable build #245: FIXED in 53 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/245/ 16:57 wahanui Congratulations! 16:57 koha-jenkins Yippee, build fixed! 16:37 koha-jenkins Project Koha_Master_D11 build #373: FIXED in 31 min: https://jenkins.koha-community.org/job/Koha_Master_D11/373/ 16:37 wahanui Congratulations! 16:37 koha-jenkins Yippee, build fixed! 16:36 koha-jenkins Project Koha_Master build #1743: STILL UNSTABLE in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master/1743/ 16:19 koha-jenkins Project Koha_Master_D10_CPAN build #419: FIXED in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/419/ 16:19 wahanui Congratulations! 16:19 koha-jenkins Yippee, build fixed! 16:16 koha-jenkins Project Koha_Master_U20 build #179: FIXED in 54 min: https://jenkins.koha-community.org/job/Koha_Master_U20/179/ 16:16 wahanui Congratulations! 16:16 koha-jenkins Yippee, build fixed! 16:05 koha-jenkins Project Koha_Master_D10_My8 build #640: FIXED in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/640/ 16:05 wahanui Congratulations! 16:05 koha-jenkins Yippee, build fixed! 15:47 koha-jenkins Project Koha_Master_D10_MDB_Latest build #678: FIXED in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/678/ 15:47 wahanui Congratulations! 15:47 koha-jenkins Yippee, build fixed! 15:36 ashimema 'Separate main entry and subdivisions with' looks to still be in the cataloguing.pref file and mentioned non-XSLT view only Joubu 15:36 ashimema oooh 15:34 koha-jenkins Project Koha_Master_D10_CPAN build #418: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/418/ 15:30 koha-jenkins Project Koha_Master_D9 build #1748: FAILURE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1748/ 15:26 koha-jenkins Project Koha_Master_D11 build #372: UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D11/372/ 15:07 huginn News from kohagit: Bug 22690: Add koha_object[s]_class to fix TestBuilder.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d2606a1c83a004e5e9b1ea86c8ee96111a0e2da3> 15:04 koha-jenkins Project Koha_Master build #1742: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master/1742/ 15:03 koha-jenkins Project Koha_Master_U_Stable build #244: UNSTABLE in 31 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/244/ 14:32 koha-jenkins Project Koha_Master_D10_CPAN build #417: UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/417/ 14:31 koha-jenkins Project Koha_Master_U20 build #178: UNSTABLE in 52 min: https://jenkins.koha-community.org/job/Koha_Master_U20/178/ 14:23 koha-jenkins Project Koha_Master_D10_My8 build #639: FAILURE in 1 min 57 sec: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/639/ 14:21 koha-jenkins Project Koha_21.05_D9 build #51: ABORTED in 50 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/51/ 14:20 mtj Joubu: yes, should be fixed on master now 14:20 Joubu mtj: is that ^ you? 14:15 koha-jenkins Project Koha_Master_D10_MDB_Latest build #677: UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/677/ 14:03 oleonard kidclamp: https://snipboard.io/btQP1M.jpg ? 14:03 koha-jenkins Project Koha_Master_D9 build #1747: NOW UNSTABLE in 31 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1747/ 13:56 oleonard Sure 13:55 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 enhancement, P5 - low, ---, nick, Signed Off , Allow librarians to add borrowers to patron lists by borrowernumber 13:55 oleonard Bug 16446 13:53 kidclamp oleonard: if you can look at 16446 and let me know how to make the radios less ugly I would appreciate it 13:44 ere \o/ 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=34224b8141e90be099c582be7caccd1bee2265b0> 13:37 huginn News from kohagit: Bug 25619: Add ability to adjust expiration date for waiting holds <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d303e49f092aa5900a567aa1790b3066c031838b> 13:37 huginn News from kohagit: Bug 25619: Unit Tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bcd43bb62f317924a37424522a0c3b2dd1fc20e3> 13:37 huginn News from kohagit: Bug 22690: Remove MoveItemFromBiblio import <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=34597e95ab9b30c51ebd09d5ac765da8cdd0f47c> 13:37 huginn News from kohagit: Bug 22690: Add missing txn_begin in subtest <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c03f7f1ad1ad56e1946d06063095788f12453db2> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders' <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=56b86cf35ab97845dbdaf200f9d36851e44ac787> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Improve negation syntax <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=33dc5da1559d028a2929c9393306cc188f7db5f6> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Move adopt_items_from_biblios to Koha::Items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2ab8f50835acb06a115f00119b88e6f5053472c1> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Clarify uses of DBIC <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e552b366862431f0a601576914b7865600d097d3> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Add relationships to linktracker <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8e19ecd51e047c99075e19366d4c56314049f42d> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Use relationship accessor <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e5bfbc5a7681831faf19d64506a38ce3a597fa7> 13:37 huginn News from kohagit: Bug 25619: (QA follow-up) Fix subtest description <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=70d25adbe71d2476229cb20902a01caab6726c50> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Add TrackedLink classes and use them <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c958dec78527415385dc51b4b43c5774d5b6ed2a> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Correct variable name <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3d5349b914d6915ce7a80a9d1454bfe6b5b51dc8> 13:37 huginn News from kohagit: Bug 22690: (QA follow-up) Fix indexing for Items sets <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=020b93bfc07764c11fe2948b42048828d499c14d> 13:37 huginn News from kohagit: Bug 25619: Adjust POD <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f008b3ebe72b53821902bb60d8681fc0f1d2217e> 13:37 huginn News from kohagit: Bug 25619: Adjust POD and move date check before logging <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9f7846202554611c2c4659b3e7119a0bac10531b> 13:37 huginn News from kohagit: Bug 22690: DBIC schema changes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d21f626e8067b028897c6c0d7e2d9fa99a7a36e0> 13:37 huginn News from kohagit: Bug 22690: Remove uneeded return and add no_triggers <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=46a13422264bf35560d032550c05574879d927fc> 13:37 huginn News from kohagit: Bug 22690: DBRev 21.06.00.018 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2b083cb82ae3af93307e45908bceb3e475209109> 13:30 koha-jenkins Project Koha_Master_D9 build #1746: FAILURE in 3 min 39 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/1746/ 13:26 koha-jenkins Project Koha_Master_D9 build #1745: ABORTED in 25 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1745/ 13:07 tcohen anyway. more than happy to be RFC compliant :-D 13:07 tcohen Joubu: thanks for clarifying, I was sure I read that, and it of course was wrong but felt like there was consensus on keeping the current wrong behavior 12:56 Joubu and IIRC they wanted umlaut in the name part 12:55 Joubu it's invalid 12:55 Joubu no, that's wrong 12:51 tcohen it's because they wanted diacritics in addresses 12:50 tcohen Joubu: I've remebered why I didn't use ->parse 12:30 oleonard It is. 12:21 ashimema okies.. I might have a bit more of a play.. this template is confusing as. 12:21 ashimema mm 12:19 oleonard It's hard for me to picture how it works, but we certainly want to both keep things consistent and show the user relevant information. 12:19 ashimema but some of the other modals on the same page don't adhere to that.. so you could confirm and miss a message 12:19 ashimema that will also get displayed in the modal.. at the bottom 12:19 ashimema if there are other messages present.. like 'the item contains multiple materials' 12:18 ashimema so if there's a hold you get a modal with options to 'Confirm and transfer' and the likes.. 12:18 ashimema like.. the reserved modal does.. at the bottom of the modal.. 12:18 oleonard I don't understand 12:17 ashimema with the modal confirms at checkin.. should they all include the all_checkin_messages block? 12:17 wahanui oleonard is, like, happy for ashimema to write the release script 12:17 ashimema oleonard 12:06 cait oleonard: kind of - it comes from the specific css file of this library - but i don#t see where :) I just overwrote it now with !important as a last resort 12:01 tcohen cait: my patch and Joubu's follow-ups seem reasonably portable. 11:49 ashimema for consistency I'm feeling like it should be a modal confirm 11:49 ashimema then the bundles piece was just adding the confirmation step on the page and not at a modal 11:49 ashimema we have the materials confirm parts one.. which uses a modal for the blocking confirmation dialogue 11:48 ashimema working on the bundles feature again.. 11:48 * ashimema is contemplating if a modal is right for this or not 11:47 ashimema thanks 11:47 ashimema that's 4 11:47 ashimema I was using modal-xl 11:47 ashimema I always forget we're on 3 11:47 oleonard You can use <div class="modal-dialog modal-wide"> to make it wider. 11:47 ashimema I see 11:46 oleonard ashimema: The default Bootstrap 3 modal is 600px wide 11:44 ashimema https://nimb.ws/SYKQVc 11:43 ashimema hmm.. are our modals deliberately narrow ? 11:32 oleonard cait: Did you figure out your "display:block" question? 11:31 cait tcohen: i am glad to see discussion about the email - but please keep backporting in mind 11:31 cait probably going to be something boring again :) 11:27 oleonard Just you wait huginn 11:27 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 could not be retrieved: InvalidBugId 11:27 oleonard Man we are hurtling towards Bug 30000 11:19 ashimema agreed 11:19 tcohen you want it automatic 11:18 tcohen you don't want to check the fallback From in every place we queue an email 11:17 ashimema in which case we build K::E::Address objects (which do validation) and catch errors before throwing those at Koha::Email->create (wrapped in a try/catch that catches invalid params sent.. i.e non Koha::Email::Addresses) ? 11:17 tcohen we do it here 11:17 tcohen so a syspref tells everything shuold be bcc to some address 11:16 tcohen the main purpose of Koha::Email now, is to wrap our business 11:16 tcohen the thing is 11:16 ashimema so.. should Koha::Email->create require that Koha::Email::Address's are passed in.. rather than text.. 11:15 ashimema and yeah.. I think the idea of an email wrapper object is great.. gives us more flexability overall.. 11:15 ashimema i.e. either we should check before calling Koha::Email->create and thus create shouldn't do the check on top.. or we should check inside create and always wrap calls to it in a try/catch block that spots and handles the various exceptions it can throw? 11:14 tcohen in my opinion, we should have a wrapper class for emails, that throws the exception and we move around such objects 11:14 ashimema but I feel like we should be consistent in how/where we throw exceptions for invalid emails.. 11:13 ashimema indeed 11:13 tcohen (sending a cart) 11:13 tcohen t 11:13 tcohen and the ones that come from user inpu 11:13 ashimema indeed 11:13 tcohen those that have been stored on the DB 11:13 tcohen there are two different email addresses 11:13 ashimema and I agree.. replacing Email::Valid with Email::Address seem the right thing to do.. 11:12 ashimema going on memory of writing my bug 11:12 ashimema especially is we validate a bunch of emails in there but only send back an invalid exception without which one is invalid.. I think 11:12 ashimema i.e. I'm not even sure any more where we should be doing the email validation step.. it feels sorta odd doing it inside Koha::Email->create.. 11:11 ashimema I feel like it's a bit weird that Koha::Email->create can throw exceptions which aren't caught 11:11 tcohen so doesn't properly validate addresses 11:11 tcohen Email::Valid doesn't handle UTF-8 chars correctly 11:11 * ashimema is slightly confused by the Koha::Email stuff now 11:11 tcohen otherwise, solid dev from khall 11:10 tcohen the only *big* issue I had found was the UNIQUE constraint 11:10 ashimema yeah 11:10 ashimema hehe 11:10 tcohen he 11:10 tcohen ashimema: it is simpler now I think 11:09 ashimema looks pretty solid on first inspection.. well.. more like 5th inspection.. but it's moved a bit again @:) 11:09 * ashimema is reminding his brain how item groups (formerly Volumes) works so he can QA 11:09 tcohen Joubu: shouldn't we go add Koha::Email::Address instead? 11:09 ashimema :) 11:08 tcohen wb 11:08 tcohen hola ashimema 11:05 ashimema Ping 11:05 tcohen Joubu: pong 11:02 tcohen holaaaa 11:01 wahanui niihau, tcohen 11:01 tcohen hola 10:23 nugged \o/ 10:21 oleonard Hi #koha 09:25 cait1 ...or usercss afaikt 09:25 cait1 it's not done by userjs 09:24 cait1 anyone an idea how that could get there? 09:24 cait1 hm I am seeing a display:block on the element in my code... but it's not in the template 09:16 * ashimema was just wondering about that 09:02 Joubu tcohen: ping me when around please (28870 - 28803) 09:01 magnuse such fun! 08:49 ashimema now onto the next thing.. the email backlog 08:48 cait1 ashimema++ :) 08:44 ashimema done :) 08:42 magnuse ashimema++ 08:04 ashimema it also changes the prototype.. but that's fine.. I just need to make sure I account for that 08:04 ashimema yup.. I'm just being extra vigilent to make sure I don't re-introduce it ;) 08:03 Joubu should be easy then, it only removed code :) 08:02 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Remove non-XSLT views 08:02 ashimema for example.. bug 12561 affects it 08:02 ashimema I was surprised.. clearly I just happen to be touching code that moved 08:02 Joubu I haven't pushed mush for the last couple of months! 08:01 Joubu really? 08:00 ashimema sooo much has changed in a week.. :( 08:00 ashimema indeed 08:00 marcelr ashimema: nothing better than a few rebases to get rid of your vacation mood 07:58 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 enhancement, P5 - low, ---, joonas.kylmala, Signed Off , Show the parent record's component parts in the detailed views 07:58 * ashimema was feeling refreshed after vacation.. but then he looked at rebasing bug 11175 07:57 cait1 hi ashimema 07:40 marcelr hi ashimema 07:39 ashimema morning #koha 07:37 Joubu we need to adapt the code 07:35 mtj agreed, i have not attempted to test/upgrade with v4 yet 07:32 Joubu I think we are not ready for v4 yet, that's why we are still stuck at 3.25 07:31 mtj ..its not urgent, but it should solve some pkging problems 07:26 mtj perhaps try to move to json-validator 4.x, which has less tricky XS deps 07:25 mtj Joubu: now that deb11/bullseye is stable, we may need to move some deb packages about 07:20 mtj Joubu: yeah probably cpan, i can comment :) 07:20 Joubu mtj: will you comment on the bug or do you want me to? 07:19 Joubu weird, maybe they have installed it from cpan them? 06:56 mtj (its a mirror of the kc repo) 06:56 mtj Installed: 3.25+dfsg-1+koha3 06:55 mtj you can see an install log of 21.05.02 on deb9 here.. -> https://gitlab.com/mjames/ktd-test-pkgs/-/jobs/1531984811 06:53 mtj Joubu: correct, the install in bz 28800 is not normal 06:51 mtj generating a cpanfile from debian/control caused some breakage 06:51 Joubu that's not normal our CI does not reflect the problem 06:50 mtj i think we will probably have to update the cpanfile manually, for now,., 06:48 mtj hmm, cpanfile is incorrect then 06:45 Joubu it's what requires the cpanfile :-/ 06:44 mtj Joubu: for 21.05.02 on deb9 - i think 0.97 is too low 06:44 alex_a Bonjour 06:42 Joubu I think it is, but it's too early, and it's Friday 06:42 Joubu Do you know if 097 for stretch is ok? 06:40 mtj probably a mistake by me 06:40 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 normal, P5 - low, ---, koha-bugs, NEW , Library list at /cgi-bin/koha/admin/branches.pl appears empty 06:40 Joubu On bug 28800, they have 0.97 06:39 Joubu it's stretch on ktd 06:39 Joubu mtj[m]: http://paste.koha-community.org/2474 # Why 3.14? 06:39 wahanui hi Joubu are you around? 06:39 mtj hi Joubu 06:37 Joubu mtj[m]: are you around? 06:28 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 normal, P5 - low, ---, oleonard, NEW , showCart incorrectly calculates position if content above navbar 06:28 magnuse bug 28901 06:27 magnuse \o/ 06:24 cait1 hi marcelr 06:20 marcelr hi #koha 06:13 cait1 good morning #koha