Time  Nick         Message
01:19 tuxayo       hi fridolin :)
01:48 fridolin     tuxayo: hello you ;)
01:49 * fridolin   running upgrades to 20.11, its a very good milesime
01:54 tuxayo       :D
01:54 tuxayo       fridolin: upgrading customers?
01:55 fridolin     yep
01:55 fridolin     the changes in OPAC bootstrap 4 disturbs a bit the custom CSS they made
01:55 fridolin     but hey its 2021 now ;)
01:55 tuxayo       ^^
01:57 tuxayo       «very good milesime»
01:57 tuxayo       that's until one goes in the quote editor and hits the "add quote" button :P
01:57 tuxayo       If you don't know yet, just try it ;)
01:59 fridolin     french users barely use it
02:00 tuxayo       good lol :D
06:09 marcelr      hi #koha
06:09 reiveune     hello
06:10 marcelr      bonjour reiveune
06:44 marcelr      hang on alexbuckley
06:57 alexbuckley  yep marcelr ?
06:57 alexbuckley  sorry only just saw your ping
06:57 marcelr      np
06:58 marcelr      go for it
06:59 alexbuckley  marcelr : Have attached my amended follow-up, so I'm all done now
06:59 marcelr      great alexbuckley++
06:59 marcelr      will have a look soon might be next week
06:59 alexbuckley  thanks marcelr++
07:00 alexbuckley  that's all good :) I'm finishing for the evening now bye all
07:52 cait         good morning #koha
07:52 marcelr      hi cait
07:53 marcelr      why does my FQA score goes so high.. sigh
07:53 cait         because you do good work?
07:53 cait         sometimes it's like this
08:04 Joubu        FQA++ :D
08:05 cait         for me it's importing patrons this morning and I think I am a little rusty
08:09 Joubu        marcelr: "valid" QA checks is "perl -wc", not perlcritic
08:10 marcelr      perlcritic is very interesting too ;)
08:11 Joubu        I was answering to this comment: bug 20817 comment 35
08:11 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 enhancement, P5 - low, ---, kohadevinim, Failed QA , Add ability to retain 9xx fields when adding on order item to existing record
08:12 Joubu        marcelr: do you know you can run koha-qa.pl with --failures to only display the FAIL? It makes the output a bit more readable.
08:12 marcelr      i dont know much Joubu, you should know, haha
08:13 marcelr      but i may like that option yes
08:14 Joubu        marcelr: there is also --run-tests ;)
08:15 marcelr      do we also have -fix-bugs ?
08:16 Joubu        Still not fully implemented
08:16 Joubu        but we have misc/devel/add_missing_filters.pl!
08:16 Joubu        that's kind of a start
08:17 marcelr      hmm that might be interesting for aleisha on the digital signs stuff
08:23 Joubu        tuxayo: around?
08:38 Joubu        @later tell tuxayo I've attached a patch on 28675. It was assigned but it was not clear if you were still working on it or waiting for help. Feel free to drop the patch if you have a better solution.
08:38 huginn       Joubu: The operation succeeded.
08:57 fridolin     Bug 28698
08:57 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 major, P5 - low, ---, fridolin.somers, Needs Signoff , News for all displays in all locations
08:57 fridolin     big problem with news
12:26 tuxayo       Hi #koha
12:26 tuxayo       hi Joubu
12:30 Joubu        o/
12:33 koha-jenkins Project Koha_21.05_U18 build #20: UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/20/
12:34 tuxayo       Indeed, it was not clear about bug 28675. Thanks for the patch, i'll check it out
12:34 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 major, P5 - low, ---, koha-bugs, Needs Signoff , QOTD broken in 20.11 and below
12:35 koha-jenkins Project Koha_21.05_D11 build #26: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/26/
12:49 Joubu        bug 24387 # huge patch and change there
12:49 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rename News tool
12:51 koha-jenkins Project Koha_21.05_U20 build #23: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/23/
12:52 oleonard     Joubu: The plural "Additional contents" isn't grammatically correct in English unfortunately. How hard would it be to make it "Additional content" ?
12:55 Joubu        erk
12:55 Joubu        content is always plural?
12:56 Joubu        funny that we had the problem with "News" and get it again with its successor
12:57 Joubu        oleonard: It is easy to replace on the UI, but what about Koha::AdditionalContent[s]?
12:57 koha-jenkins Project Koha_21.05_U_Stable build #22: SUCCESS in 57 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/22/
13:07 koha-jenkins Project Koha_21.05_D9 build #18: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/18/
13:08 koha-jenkins Project Koha_21.05_U16 build #21: SUCCESS in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/21/
13:13 koha-jenkins Project Koha_21.05_D11 build #27: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/27/
13:15 ashimema     ooh..
13:15 ashimema     did you add the 'default language' stuff in bug 24387.
13:16 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rename News tool
13:16 ashimema     that's well worth highlighting.. it's a massive improvement way beyond just splitting the page into two
13:22 Joubu        it's in the commit messsage :)
13:23 ashimema     indeed it is
13:23 ashimema     I'd possible go even further and split the data into two tables again.
13:23 ashimema     like.. does 'position' still make sense for the blocks..
13:23 ashimema     it does for news.. but not so much for blocks to me.
13:23 ashimema     I like the translations
13:27 * ashimema   would be tempted by 'content_news', 'content_blocks' and 'content_pages' as an eventual goal.. they each have their own use case and thus slightly different requirements in my opinion.
13:29 Joubu        ashimema: please think "baby" steps
13:29 Joubu        the changes is huge enough
13:29 Joubu        the idea is to make it extensible
13:29 ashimema     deffo
13:29 Joubu        Like we could add a whole new page here
13:29 Joubu        ho, what you said in your last message :)
13:30 ashimema     as for my thoughts on a later enhancements to the UI..
13:31 Joubu        To be honest, I didn't know I would write as much code. I just wanted to "rename" it at the beginning. But the way the sysprefs have been "moved" there was not clean at all
13:31 Joubu        the way we used the "lang" column was a lazy trick to prevent adding the columns the patch is adding now
13:31 ashimema     I mean instead of a table UI for the content blocks.. it would be nice to have a visual representation of where the blocks get placed
13:31 ashimema     indeed
13:31 Joubu        yes, that would be great, that's a job for Owen ;)
13:32 ashimema     yeah.. I think you've done a great job
13:32 ashimema     just thinking of next steps
13:32 Joubu        actually it's still horrible, but things are improved
13:32 ashimema     I reckon lets get this first step through a quick SO + QA.. then I'd be more than happy to take a punt at a follow-up bug to split it again which cleans it a bit more
13:32 ashimema     etc
13:32 ashimema     agreed
13:33 ashimema     but it's a huge improvement on what's there right now ;)
13:33 ashimema     you've got me excited by starting
13:34 Joubu        ashimema: actually the next step IMO is bug 24975
13:34 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 enhancement, P5 - low, ---, julian.maurice, In Discussion , Refactor database translations
13:35 ashimema     indeed
13:35 ashimema     I'd really like to see that completed
13:35 Joubu        then get back to news/block/additional contents/whatever we call them
13:35 Joubu        and notice templates
13:35 ashimema     totally
13:35 Joubu        because notice templates are actually... an "additional content"
13:36 Joubu        in the way it's now implemented, they are very similar
13:36 ashimema     indeed they are
13:37 ashimema     though in my opinion I'd like to keep them distinct.. we can share a certain amount of code but we do often end up adding little local code each time and it gets confusing if it's all centralised too much
13:37 Joubu        we could have different DB tables, but the logic code for CRUD should be merged
13:37 ashimema     hence my wanting to split the tables
13:37 ashimema     indeed
13:37 ashimema     share as much crud as possible
13:37 ashimema     kinda like the idea of superclassing here
13:37 ashimema     or using roles
13:38 Joubu        ashimema: if you want to scratch your head on that patch you can take a look at the "Limitations of the upgrade" part in the commit msg
13:38 ashimema     I have been ;)
13:39 ashimema     need to add some translations to play with before running through the upgrade to fully understand how that's working
13:39 koha-jenkins Yippee, build fixed!
13:39 koha-jenkins Project Koha_21.05_U18 build #21: FIXED in 32 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/21/
13:39 Joubu        ashimema: I have a dump of the table, I will share it on the bug
13:40 Joubu        with dumb data
13:40 ashimema     :)
13:40 ashimema     awesome
13:42 Joubu        The dbrev is missing comment, sorry about that.
13:42 Joubu        Just keep in mind that we REQUIRE a lang=default, so we need to create it during the upgrade
13:43 Joubu        if lang != "en"
13:43 Joubu        beurk I certainly explained that better on the commit message
13:43 Joubu        I am tired of this code :D
13:46 koha-jenkins Project Koha_21.05_U20 build #24: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/24/
13:53 koha-jenkins Project Koha_21.05_D9 build #19: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/19/
13:58 koha-jenkins Project Koha_21.05_U16 build #22: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/22/
14:10 koha-jenkins Project Koha_21.05_U20 build #25: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/25/
14:14 koha-jenkins Project Koha_21.05_D11 build #28: SUCCESS in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/28/
14:32 koha-jenkins Project Koha_21.05_U16 build #23: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/23/
14:34 Joubu        khall_: Hi, can you confirm me that koha-sandboxes-docker does a git pull of k-s-d repo nightly?
14:34 Joubu        I had in mind that it does, but I cannot find where it's doing it
14:36 Joubu        hum nope, it's not doing it!
14:42 khall_       it should be! The server gets re-provisioned nightly
14:42 khall_       270     - cron:
14:42 khall_       271         name: "Re-provision server nightly"
14:42 khall_       272         minute: "0"
14:42 khall_       273         hour: "0"
14:42 khall_       274         job: "cd {{pwd_output.stdout}} && {{pwd_output.stdout}}/setup-sandbox-server.sh && bash -l -c 'hypnotoad {{pwd_output.stdout}}/sandbox_manager/script/sandbox_manager' > /dev    /null 2>&1"
14:42 khall_       NORMAL  áš  master!  ansible/setup-sandbox-server.yml
14:43 khall_       124     - name: "Clone koha source to /usr/local/src/koha"
14:43 khall_       125       git:
14:43 khall_       126         repo: git://git.koha-community.org/koha.git
14:43 khall_       127         dest: /usr/local/src/koha
14:43 khall_       128         accept_hostkey: yes
14:43 khall_       129       notify:
14:43 khall_       130         - "Install koha git config"
14:44 khall_       the 'update' option is 'yes' by default
14:44 khall_       so if that cronjob is running nightly, the kohaclone should be updatedated nightly
14:44 khall_       https://docs.ansible.com/ansible/latest/collections/ansible/builtin/git_module.html#parameter-update
14:44 khall_       if it's not we've got a bug
14:46 koha-jenkins Project Koha_21.05_U18 build #22: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/22/
14:55 koha-jenkins Project Koha_21.05_U_Stable build #23: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/23/
14:55 reiveune     bye
15:12 koha-jenkins Project Koha_21.05_U20 build #26: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/26/
15:19 koha-jenkins Project Koha_21.05_D11 build #29: UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/29/
15:40 koha-jenkins Project Koha_21.05_U20 build #27: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/27/
15:46 koha-jenkins Project Koha_21.05_U16 build #24: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/24/
15:49 koha-jenkins Yippee, build fixed!
15:49 koha-jenkins Project Koha_21.05_D11 build #30: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/30/
15:54 koha-jenkins Project Koha_21.05_D9 build #20: UNSTABLE in 1 hr 22 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/20/
15:55 koha-jenkins Project Koha_21.05_U18 build #23: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/23/
16:52 koha-jenkins Project Koha_21.05_U_Stable build #24: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/24/
16:59 oleonard     Have I already wished for a normalized isbn in the API biblio information?
16:59 oleonard     I do.
17:20 koha-jenkins Yippee, build fixed!
17:20 koha-jenkins Project Koha_21.05_D9 build #21: FIXED in 1 hr 25 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/21/
18:18 koha-jenkins Project Koha_21.05_U18 build #24: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/24/
18:25 koha-jenkins Project Koha_21.05_U16 build #25: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/25/
18:36 koha-jenkins Project Koha_21.05_U20 build #28: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/28/
18:41 koha-jenkins Project Koha_21.05_U_Stable build #25: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/25/
18:44 koha-jenkins Project Koha_21.05_D11 build #31: SUCCESS in 57 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/31/
18:50 koha-jenkins Project Koha_21.05_U18 build #25: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/25/
19:05 koha-jenkins Project Koha_21.05_U16 build #26: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/26/
19:11 koha-jenkins Project Koha_21.05_D9 build #22: SUCCESS in 1 hr 25 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/22/
19:23 koha-jenkins Project Koha_21.05_D11 build #32: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/32/
19:37 koha-jenkins Project Koha_21.05_U20 build #29: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/29/
19:43 koha-jenkins Project Koha_21.05_D11 build #33: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/33/
20:34 koha-jenkins Project Koha_21.05_U_Stable build #26: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/26/
20:39 koha-jenkins Project Koha_21.05_D9 build #23: SUCCESS in 1 hr 27 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/23/