Time  Nick          Message
00:13 fridolin      yey
00:21 tuxayo        fridolin: :D
00:33 fridolin      tuxayo: yello
00:33 * fridolin    gets the habit of living without a t-shirt ;)
00:34 fridolin      we find some pur USA products here its fun, like corn-syrup
00:34 fridolin      an crunchy peanup butter
00:43 tuxayo        > living without a t-shirt ;)
00:43 tuxayo        not hot enough in marseille yet to need to do that ^^
00:46 tuxayo        > pur USA products
00:46 tuxayo        eating-disorders++
00:46 tuxayo        Though in France there is a lot of junk food also ^^"
00:47 fridolin      indeed, and we also find a lot of products from Europe, even water !!!!
00:48 fridolin      its crazy
00:48 fridolin      some NZ products are fine, like milk
00:48 fridolin      of suggar
00:48 fridolin      its the nearest place ;)
00:49 tuxayo        :D
00:51 tuxayo        really, bottled water from Europe? It wasn't enough terrible so now it's exported to the other side of the planet XD
00:51 tuxayo        modern-civilization--
00:54 tuxayo        What find of food is produced in French Polynesia?
00:55 tuxayo        *kind
01:43 fridolin      mmm some fruits i bet
01:43 fridolin      and Monoï, from coco and tiare flower
01:43 fridolin      fish is the main meal
03:09 fridolin      Bug 20529 nearly done, needs a QA ?
03:09 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 normal, P5 - low, ---, victor, Failed QA , Return to results link is truncated when the search contains a double quote
03:43 koha-jenkins  Yippee, build fixed!
03:43 koha-jenkins  Project Koha_21.05_U20 build #22: FIXED in 51 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/22/
05:53 reiveune      hello
06:36 cait1         good morning #koha!
06:55 alex_a        Bonjour
09:09 huginn        News from kohagit: Bug 28409: Adjust regression test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dca25b9dcea4823a7fb7bb9a1f4ca83aa09c9fc1>
09:09 huginn        News from kohagit: Bug 28462: Remove line breaks in TT tags <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=46340efc933d408275ddc7f8de127a72d1477e4e>
09:09 huginn        News from kohagit: Bug 28611: Fix width to 50% for additem form elements <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e6c04ff745a066b33b0b38d5fee46267cb0b76a5>
09:09 huginn        News from kohagit: Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=85594dbbfcc9866ceadc45c45f5c3552540bb7c8>
09:09 huginn        News from kohagit: Bug 28523: Escape 'rank' in bor_issues_top.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7d795fcf5f72e105667eb21e671fb1a63db8383b>
09:09 huginn        News from kohagit: Bug 28524: Escape 'rank' in cat_issues_top.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5faddae26f7dd2c877161652f396414f56337421>
09:09 huginn        News from kohagit: Bug 28455: Update wording on TrackLastPatronActivity <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=83c3c7d57d12e44741c2e9bbb787ec61876e0327>
09:09 huginn        News from kohagit: Bug 28462: Remove TT tag on several lines - opac-advsearch.tt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5f2964c2ec042f8f872e428046de2ce551d3ce3c>
09:09 huginn        News from kohagit: Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3a2a0eef1043f0e3432531026dae216fa087d674>
09:09 huginn        News from kohagit: Bug 28409: Simplify data validation <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=69c3fc9729d189ede9f14ec4005e989947404ec1>
09:09 huginn        News from kohagit: Bug 28409: Comprehensively validate category in opac-shelves.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e99f7ad63f45f85e6e7d2f3080a960379e3e6f79>
09:09 huginn        News from kohagit: Bug 28299: Unit tests for buildKohaItemsNamespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eb157ae2d2ee642541255870dff418c668bf85d8>
09:09 huginn        News from kohagit: Bug 28299: Make buildKohaItemsNamespace accept Koha::Items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a882783326c2f7f731f388703fab9cc9fee1b345>
09:09 huginn        News from kohagit: Bug 28299: Take OpacHiddenItems into account on opac-shelves <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4d8ff723d53abe8c95e18d5034d4c727b0dbfb3e>
09:43 koha-jenkins  Project Koha_Master_D10_CPAN build #369: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/369/
09:56 koha-jenkins  Project Koha_Master_U20 build #139: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U20/139/
10:08 koha-jenkins  Project Koha_Master_U_Stable build #205: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/205/
10:11 koha-jenkins  Project Koha_Master_D11 build #332: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_D11/332/
10:18 koha-jenkins  Project Koha_Master build #1700: UNSTABLE in 1 hr 9 min: https://jenkins.koha-community.org/job/Koha_Master/1700/
10:18 koha-jenkins  Project Koha_Master_D9_My8 build #604: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/604/
10:35 koha-jenkins  Project Koha_Master_D9 build #1697: SUCCESS in 1 hr 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1697/
10:39 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #625: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/625/
10:45 koha-jenkins  Project Koha_Master_D10_CPAN build #370: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/370/
11:03 marcelr       hi #koha
11:05 cait          hi marcelr :)
11:08 marcelr       hi cait
11:14 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #626: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/626/
11:59 koha-jenkins  Project Koha_Master_D9 build #1698: SUCCESS in 1 hr 23 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1698/
12:04 tcohen        hole
12:12 marcelr       hola
12:16 Joubu         ole!
12:22 tuxayo        🙌🙌🙌🙌
12:31 Joubu         bug 28660 # AutoSelfCheck is broken in 21.05
12:31 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 blocker, P5 - low, ---, oleonard, NEW , Self checkout is not automatically logging in
12:33 oleonard      Joubu: Have you investigated it?
12:34 Joubu         yes, it's coming from bug 21325
12:34 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 normal, P5 - low, ---, dcook, Pushed to master , Prevent authentication when sending userid and password via querystring parameters
12:35 Joubu         if ($request_method eq 'POST'){
12:35 Joubu         this is wrong
12:35 Joubu         but I don't know how to fix it properly
13:15 marcelr       GET /cgi-bin/koha/members/boraccount.pl?accountlines_id=40&action=discount&borrowernumber=51&amount=2.50&op=discount ?
13:16 marcelr       would expect POSTs here..
13:19 ashimema      marcelr and Joubu are talking about different things right?
13:19 ashimema      or am I missing something?
13:22 marcelr       yes very different
13:23 marcelr       just wondering about GETs that change the accounts
13:25 ashimema      yeah... we're really inconsistent with GET vs POST
13:27 Joubu         caroline: it would be helpful to have your new coworkers around here
13:27 ashimema      well
13:28 ashimema      GET triggers the page reload so perhaps they do make sense
13:29 tuxayo        A POST won't reload the page?
13:29 ashimema      if we were in an API I think POST would make sense.. but as we're doing things the old fashioned way I think GET does make sense for these.. else how would the page get updated with the added lines?
13:29 Joubu         @later tell caroline it would be helpful to have your new coworkers around here
13:30 ashimema      POST doesn't inherantly return a fresh page
13:30 tuxayo        Can it?
13:30 ashimema      must admit I often get confused
13:31 Joubu         @later tell caroline Ask Salman to have a second look at 28576. Tell him to ping me if he needs help or does not understand what I'm asking for.
13:33 tuxayo        > else how would the page get updated with the added lines?
13:33 tuxayo        I remember something about doing a get redirect after a post. It also allow to refresh the page without having the browser POST pop up asking if we really want to refresh
13:34 tuxayo        Found it!
13:34 tuxayo        https://en.wikipedia.org/wiki/Post/Redirect/Get
13:34 tuxayo        Post/Redirect/Get (PRG) is a web development design pattern that lets the page shown after a form submission be reloaded, shared, or bookmarked without ill effects, such as submitting the form another time.
13:34 marcelr       tuxayo++
13:34 cait1         oleonard++
13:34 cait1         using get would allow to craft a link to make a fine... would it?
13:35 Joubu         bug 22543
13:36 huginn        Joubu: The operation succeeded.
13:36 huginn        Joubu: The operation succeeded.
13:36 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543 major, P5 - low, ---, magnus, CLOSED FIXED, Patron might be logged in again using browser back button
13:36 Joubu         is that just me or everything is slow here?
13:41 caroline      Joubu: I passed on the message. He's on client work right now, but he's gonna look at it when he has a minute
13:42 huginn        News from kohagit: Bug 22544: Restore newdate and timestamp for slip notices <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c4b4db21d2586fd95de942d38913d5142f694563>
13:42 huginn        News from kohagit: Bug 22544: Fix OpacLoginInstructions <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5f99d55ac48a9386d52b25515c0f944bd8272283>
13:42 huginn        News from kohagit: Bug 22544: TT plugin should return hashref only if news exist <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=76d53f6787532dcb1da4109f624de09e7a3335e5>
13:42 huginn        News from kohagit: Bug 22544: Use template plugin for news author display <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=52ff082aa0fa78a72cbf73097906f4498f013f76>
13:42 huginn        News from kohagit: Bug 22544: Add default language value to KohaNews template plugin <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4838615d084be7875c05a66fab4b6662bf314588>
13:43 huginn        News from kohagit: Bug 22544: Enhance exception description <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8e0c80de9744e0b56b9da3749bbb8f5b7f30751a>
13:43 huginn        News from kohagit: Bug 22544: Clarify documentation and change param 'type' to 'location' <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=98392c82eeee72670db41416d639d0b7061edbad>
13:43 huginn        News from kohagit: Bug 22544: Fix filtering by location on tools -> news management <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ec6d2900b4ad5c187a452281c6625e18f1ca3963>
13:43 huginn        News from kohagit: Bug 22544: Update search_for_display to be able to take more types <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c4985dd2ee530f74ec044bc3557a8af9d211917a>
13:43 huginn        News from kohagit: Bug 22544: Update to current codebase <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=15573ab950690d133bc5fa6d3624648caff1d08d>
13:43 huginn        News from kohagit: Bug 22544: (QA follow-up) Fix spelling <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ac70d7cfae28af57eed1be279afeb51ebca7c6b5>
13:43 huginn        News from kohagit: Bug 22544: Refactor searching of news items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6eaae7e626236d47921ece99d68b16ef4229b419>
13:43 huginn        News from kohagit: Bug 22544: Add tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e7d21b6b623be3ad4cceaaefd0ef28c68c06278b>
13:43 huginn        News from kohagit: Bug 22544: Move GetNewsToDisplay to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9ca8d08a51f823a55998dd8c36f4bf2aae7b71aa>
13:43 huginn        News from kohagit: Bug 22544: Move add_opac_item to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05798ec1aaf38546da6153e435de02c2db14d6c9>
13:43 huginn        News from kohagit: Bug 22544: Move upd_opac_new to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3d5a7199208193ded7ea4edcdabee7a186cc98e1>
13:43 huginn        News from kohagit: Bug 22544: Move del_opac_new to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5866c88d840709bdae2b6ef7e573b6fa2890141d>
13:43 huginn        News from kohagit: Bug 22544: Move get_opac_news to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ae0c08c936126f63e048b63257e587abe783a171>
13:43 huginn        News from kohagit: Bug 22544: Move get_opac_new to Koha namespace <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eb606ddfcf2ce383cc7a70d1d28071ad16fed6cc>
13:44 cait1         oh nice
13:48 marcelr       Looks like we have new news
13:55 marcelr       ashimema: reversible revertable ot reversable ?
13:56 marcelr       s/ot/or/ ;)
14:20 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #627: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/627/
14:23 koha-jenkins  Project Koha_Master_U20 build #140: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_U20/140/
14:26 oleonard-away Joubu: Regarding Bug 28650, do you agree with the solution marcelr used in Bug 27948 in his QA follow-up?
14:26 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650 normal, P5 - low, ---, oleonard, NEW , Assumed branchcode variable appears to be empty
14:26 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 enhancement, P5 - low, ---, agustinmoyano, Passed QA , Add disclaimer text to article requests feature
14:30 marcelr       oleonard: and there is another patch where kidclamp does the same
14:30 marcelr       for suggestions
14:37 Joubu         oleonard: yes, sounds good (make sure there is a [% USE Branches %] at the top)
14:48 koha-jenkins  Project Koha_Master_D9 build #1699: SUCCESS in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1699/
14:51 koha-jenkins  Project Koha_Master_D10_CPAN build #371: SUCCESS in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/371/
14:51 kidclamp      marcelr: what did I do where?
14:52 koha-jenkins  Project Koha_Master_D11 build #333: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_Master_D11/333/
14:54 koha-jenkins  Project Koha_Master_D9_My8 build #605: SUCCESS in 1 hr 12 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/605/
14:55 marcelr       kidclamp: you did something !
14:56 marcelr       you resolved a KohaNews call
14:56 marcelr       and oleonard is going to solve them all
14:57 marcelr       htg
14:57 koha-jenkins  Yippee, build fixed!
14:57 koha-jenkins  Project Koha_Master build #1701: FIXED in 1 hr 13 min: https://jenkins.koha-community.org/job/Koha_Master/1701/
14:57 kidclamp      ah, yes
15:01 koha-jenkins  Project Koha_Master_D10_CPAN build #372: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/372/
15:06 Joubu         bug 24387
15:06 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Rename News tool
15:06 Joubu         just saying...
15:18 oleonard      Super-Fun Party Bus Celebration tool.
15:23 Joubu         opac_news.lang="slip" - This is terrible..
15:27 koha-jenkins  Project Koha_Master_D9 build #1700: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1700/
15:35 reiveune      bye
15:45 koha-jenkins  Project Koha_Master_U_Stable build #206: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/206/
15:52 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #628: SUCCESS in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/628/
15:56 koha-jenkins  Project Koha_Master_D11 build #334: SUCCESS in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master_D11/334/
15:59 koha-jenkins  Project Koha_Master build #1702: SUCCESS in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master/1702/
23:02 dcook         Darn timezones..
23:18 tuxayo        dcook: ?
23:18 tuxayo        Hi :)
23:18 dcook         hola tuxayo
23:18 dcook         bug 28660
23:18 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 blocker, P5 - low, ---, dcook, ASSIGNED , Self checkout is not automatically logging in
23:18 dcook         I'm the one who broke it :| wish I culd've been around to talk about fixing it
23:19 dcook         Always a terrible feeling when you introduce a regression :(
23:43 tuxayo        Think about your ratio of fixes vs breaks, it must be great :)
23:55 dcook         Great might be an exaggeration heh