Time  Nick          Message
19:26 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 major, P5 - low, ---, nick, Failed QA , If ElasticSearch enable is not possible to edit or save records with '  ES reserved charset' like []
19:26 tuxayo        Issue found on bug 28326
19:26 tuxayo        kidclamp: hi :)
19:08 tuxayo        ok, there was a related update to the KTD code which has related stuff, that's likely what I'm missing.
19:06 tuxayo        hum same issue with ES 5 when the only the ES 6 image was updated recently
19:02 tuxayo        No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::ANON at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 416
19:02 tuxayo        Any koha-testing-docker user having a problem to start koha with ES enabled in the .env file? I updated the images (using ES6) today and the message is
17:54 nlegrand      bye all
17:31 kohaputti     no, that's old thing
17:30 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26322 major, P5 - low, ---, tomascohen, Pushed to oldstable , REST API plugin authorization is not checked anymore
17:30 cait          bug 26322 changes maybe?
17:30 cait          even better :)
17:29 cait          ah ok
17:29 kohaputti     err, reset_all..
17:29 kohaputti     restart_all....
17:28 kohaputti     hmm now it works
17:26 cait          i wonder if imight have seen a bug about this
17:20 kohaputti     If I'm not mistaken around 1 month ago it still worked
17:18 kohaputti     I've been trying to debug for couple hours but no luck
17:18 kohaputti     tcohen, ping
17:18 kohaputti     Hi, does your API plugins work with latest koha master? For some reason after upgrading to latest master the plugin's controller functions don't get called at all
16:31 reiveune      bye
16:30 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Release team 21.11
16:30 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 critical, P5 - low, ---, martin.renvoize, Signed Off , Error when printing receipt of point of sale
16:30 Joubu         a bit of help needed on bug 28368 and bug 28442, please
16:21 tcohen        I like their approach
16:21 tcohen        the 'Download' link gives you their file
16:20 tcohen        https://docs.docker.com/engine/api/v1.25/#
16:20 tcohen        I'm looking at the docker API
16:19 tcohen        I'm leaning towards keeping 'illrequests' (easier to write, easier to not make typos) and leave room for (maybe) documentation people to add their prose to the descriptions
16:17 Joubu         tcohen: in which cases do you have name != display name?
16:16 Joubu         ashimema: https://gitlab.com/koha-community/release-tools/-/merge_requests/24 I am happily let you put your stamp on that :)
16:16 cait1         jajm++ # I fell in love witht he new gulp translations updates - so much faster and more convenient than before
16:13 tcohen        what do you think?
16:09 pastebot      "tcohen" at 127.0.0.1 pasted "Joubu, ashimema" (21 lines) at http://paste.koha-community.org/666
15:55 nlegrand      Joubu++
15:55 nlegrand      tcohen++
15:54 nlegrand      and finaly, it works!!!
15:54 nlegrand      Joubu: api-error.log
15:47 Joubu         oops
15:47 Joubu         ha, we have one already! :D
15:47 huginn        Joubu: Highest karma: "Joubu" (986), "cait" (843), and "ashimema" (630).  Lowest karma: "-" (-68), "failed" (-47), and "ie" (-40).  You (Joubu) are ranked 1 out of 1101.
15:47 Joubu         @karma
15:47 tcohen        ;-)
15:47 Joubu         true, we need a bot for that
15:46 tcohen        he he
15:46 tcohen        where do we log owed drinks?
15:45 Joubu         nlegrand: noted for the drink! where was the log?!
15:43 SimonVoyer    :)
15:42 nlegrand      Marjorie :)
15:42 nlegrand      Ha yes!
15:42 SimonVoyer    hey nlegrand ! so basically I re-adapted some 18.05 inlibro code to federate search on multiple ES indexes. I'm still working on cleaning up results so that the title links to the appropriate Koha instance instead of linking to an inexistant local biblionumber. if anyone is interested I'll be happy to share
15:42 nlegrand      SimonVoyer: who?
15:42 nlegrand      so true
15:42 tcohen        meeting in person
15:42 tcohen        I mean y'all
15:41 tcohen        I miss Marseille so much
15:41 nlegrand      Joubu, tcohen: if one day we could redo hackfest in Marseille, I'll owe you a drink!
15:39 SimonVoyer    cait1: nlegrand and I also share a friend
15:39 nlegrand      hey SimonVoyer
15:39 nlegrand      cait1: the most crazy data right now in ES is to put brackets in title :D
15:39 nlegrand      thanks a lot Joubu and tcohen!
15:38 cait1         nlegrand: let me introduce you to SimonVoyer - I migh thave mentioned to him that you are using Elastic on crazy data :)
15:38 nlegrand      So my spec were fishy. I reread them with an example and I had a wrond {} sequence. And now that it's better, I've got errors.
15:38 tcohen        great, nlegrand !
15:38 nlegrand      I'm always so happy when I've got errors.
15:37 nlegrand      I've got errors!!!
15:37 nlegrand      \o/
15:33 cait1         SimonVoyer++
15:23 koha-jenkins  Project Koha_Master_D10_CPAN build #343: SUCCESS in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/343/
15:11 koha-jenkins  Project Koha_Master build #1658: SUCCESS in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_Master/1658/
15:09 Joubu         just in case your logger config is not set correctly
15:09 Joubu         nlegrand: put a "warn $error;" right before this line
15:07 nlegrand      $logger->error("Plugin $class route injection failed: $error"); #I will so much like to see you Plugin $class route injection failed :D
15:03 ashimema      no worries
15:03 ashimema      yeah.. it's my customisation that breaks it.. hehe
15:02 * oleonard    goes afk again
15:02 oleonard      ashimema: The demo site seems to have the behavior you want, so seems doable
15:02 ashimema      for styling issues etc tomas and I are working with it directly
15:01 ashimema      in terms of docs fixes we just improve the swagger file in Koha and it'll get display nicely here..
15:01 ashimema      and some clever docker/gitlab-ci scripts to pull the schema out of koha and build this pretty site.
15:01 ashimema      we're using redoc-cli
14:59 oleonard      The site looks great though. Is it a packaged thing?
14:59 oleonard      ashimema: Sorry it's definitely not obvious to me
14:55 nlegrand      Now it doesn't do anything apart having an apiroutes. It doesn't have a tool or report method for instance.
14:55 ashimema      I should really teach myself flex properly
14:55 ashimema      no worries if it's not obvious..
14:54 ashimema      lol
14:54 oleonard      So I guess I agree it's broken!
14:54 oleonard      Now I can't see the working version anymore :D
14:53 ashimema      interseing.. that's differnt than here
14:53 nlegrand      tcohen: no it doesn't.
14:53 oleonard      Oh wait... until a section is expanded!
14:53 tcohen        nlegrand does install_plugins.pl mention the plugin?
14:53 ashimema      oh.. really
14:52 oleonard      ashimema: The search box stays fixed for me
14:52 nlegrand      Joubu: nice one. Unfortunately there is nothing about this plugin.
14:52 * ashimema    has tried changing the body to flex and had reasonable results.. but then the nav highlight as you scroll the main content fails
14:52 ashimema      but.. i broke it when I added the topnav bar which is fixed.. wondered if you had any magic idea's..
14:51 ashimema      the left navigation column.. it has a search option at the top.. it's meant to be 'fixed'.. i.e the nav beneath it scrolls but the search box itself stays..
14:51 Joubu         have that always running when you dev
14:51 Joubu         nlegrand: tail -f /var/log/koha/YOUR_INSTANCE/*.log
14:50 ashimema      I'm struggling to wrap my brain around the fixed header I created on api.koha-community.org
14:50 Joubu         nlegrand: plack logs
14:50 oleonard      Sorry ashimema I was afk. What about flexbox?
14:49 nlegrand      if my specs are not good, where should I see the errors?
14:49 nlegrand      ok, so my operationIds are unique, there is api_namespace and api_routes in plugin_methods, no errors with my plugin with plugin_install, it is enabled, and no routes are showing themselves in .html
14:42 tcohen        beware the operationId needs to be unique
14:42 tcohen        if you copied from other examples
14:38 Joubu         the json defining the rest api routes
14:37 nlegrand      what's a valid spec?
14:37 Joubu         but even harder without log/error :D
14:37 Joubu         "have a valid spec" < this is the hardest IMO, because the errors are not meaningful
14:36 nlegrand      thanks a lot! Now I've got a lot of places to look :D
14:35 tcohen        are added
14:35 tcohen        and see if api_namespace and api_routes
14:35 tcohen        > SELECT * FROM plugin_methods;
14:35 tcohen        koha-mysql <instance
14:34 nlegrand      the route is not added in /api/v1/.html
14:34 tcohen        you can also see
14:34 tcohen        Koha should report that some routes have been skipped
14:34 nlegrand      didn't try koha-shell, will do that
14:34 tcohen        - have a valid spec
14:34 tcohen        - have valid namespace (that doesn't collide with others)
14:34 nlegrand      great
14:34 tcohen        - load
14:34 tcohen        plugins need to:
14:33 tcohen        if there are unmet dependencies, or things like that
14:33 tcohen        it might give you some info
14:33 tcohen        inside koha-shell?
14:33 tcohen        have you tried install_plugins.pl
14:33 tcohen        ok
14:33 nlegrand      nope it's a package install
14:33 tcohen        are you on KTD?
14:32 tcohen        http://localhost/api/v1/.html
14:32 nlegrand      where should I see the routes added?
14:32 tcohen        there should be a warning in the logs, saying a plugin has been skipped
14:32 nlegrand      tcohen: hey
14:32 nlegrand      mostly plack
14:32 tcohen        if they are not there
14:32 tcohen        you should see your routes added
14:32 nlegrand      What I have done is derived from kitchensink and some examples in BatchPermissionsModifier
14:32 tcohen        point your browser to /api/v1/.html
14:32 tcohen        did you restart all the things?
14:31 tcohen        nlegrand
14:31 koha-jenkins  Project Koha_Master_D10_CPAN build #342: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/342/
14:31 nlegrand      There is.
14:31 tcohen        hola
14:30 Joubu         nlegrand: there is a working example on the kitchensink I think
14:22 koha-jenkins  Project Koha_Master_D9_My8 build #582: SUCCESS in 1 hr 10 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/582/
14:17 koha-jenkins  Project Koha_Master_D11 build #306: SUCCESS in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_Master_D11/306/
14:14 nlegrand      tcohen: around?
14:14 koha-jenkins  Project Koha_Master_D9 build #1666: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1666/
14:14 nlegrand      ashimema: :)
14:13 nlegrand      my eyes are touching themselves right now
14:13 ashimema      tcohen nlegrand^
14:13 ashimema      oleonard.. hows your flexbox?
14:12 nlegrand      I'm not very successful in my first try to implement api routes in a plugin. I've got 404 and I can't find anything in logs. How one should debug api routes in plugins?
14:02 koha-jenkins  Project Koha_Master_U_Stable build #180: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/180/
13:56 EvrenTombul   bye all,
13:56 EvrenTombul   bye,
13:56 EvrenTombul   ok, thanks again,
13:55 ashimema      pass actually.. I have no idea
13:55 EvrenTombul   ashimema: are these infos are DEWEY, right? not LC, I need dewey because
13:52 koha-jenkins  Project Koha_Master_U20 build #118: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U20/118/
13:47 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #600: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/600/
13:45 ashimema      hope it helps
13:44 EvrenTombul   ashimema: thanks for the information, thanks a lot
13:43 severine_q    hahaha nlegrand :) it's been a while !
13:42 nlegrand      Bonjour severine_q.
13:42 severine_q    Hi #koha :)
13:38 ashimema      i'll email.. it'll be easier
13:37 ashimema      so the main one I know uses
13:36 EvrenTombul   let me contact with them
13:36 EvrenTombul   kindergarten, primary school and high school
13:36 EvrenTombul   can you share the name of these K12 colleges's names that use KOHA? not university just K12
13:35 ashimema      those are very different books ;)
13:35 ashimema      but it sounded like you wanted primary.. i.e 5 - 11 age group
13:34 ashimema      and uni's etc of course
13:34 EvrenTombul   Joubu: thanks, let me ask to  ibresources.org then, maybe they can say something about z3950 dewey about K12 books
13:34 ashimema      so pupils from 11 -> 18 ish..
13:34 ashimema      We have a few secondary schools, lots of higher education
13:33 EvrenTombul   Isn't there any college in the UK using KOHA?  Let me simplify my question as follows: Do you know any institutions using KOHAs from K12s? Not a university, K12 college ? friends?
13:32 Joubu         EvrenTombul: did you contact them?
13:30 ashimema      I'm afraid we don't really have any primary level schools using Koha here in the UK.. well, not one's that are customers of ours.. as such I'm afraid I have no idea of a suitable Z target.
13:29 EvrenTombul   ashimema: I mean, I am searching for an institution / library where I can access the mark records of kindergarten and primary school books, which previously entered their library system and shared those catalog records, and where I can access that mark records with the dewey connection
13:27 EvrenTombul   IB books, that is, colleges get IB school accreditation from ibo.org, they generally add their books to their library systems.
13:24 Joubu         https://ibresources.org/ib-textbooks/ IB Books?
13:21 ashimema      thanks Joubu
13:21 ashimema      :)
13:21 Joubu         Yes, template->lang is the more appropriate
13:21 ashimema      EvrenTomul: What pupil age range are you talking about?... it's hard to recommend a source without really knowing how education works in your part of the world.. IB-Books is meaningless to us without context.
13:20 ashimema      I thought template->lang was the current session..
13:19 ashimema      I wasn't sure...
13:19 ashimema      the default lang for the logged in user
13:19 ashimema      or..
13:19 ashimema      logged_in_user->lang.. is that current session lang?
13:19 Joubu         yes, session language seems ok
13:19 ashimema      I suppose printing in the staff users lang is probably the best bet
13:19 ashimema      but we're printing for a patron..
13:19 ashimema      so can't use that..
13:19 ashimema      we don't have a patron
13:18 ashimema      I wasn't sure which lang to use honestly.
13:18 ashimema      we could use logged_in_user..
13:18 Joubu         ashimema: what is template->lang? why not logged_in_user->lang instead?
13:17 oleonard      EvrenTombul: What is an IB book?
13:16 cait1         Joubu++
13:16 cait1         Joubu: thx a lot, that was it, i was running out of ideas!
13:15 EvrenTombul   Does anyone know about it? can i meet that friend?  my e-mail address is evren.tombul@istek.k12.tr
13:15 ashimema      I feel like 28368 should be in 21.05 however Joubu.. the fix is trivial really.. but it's waiting for QA still.
13:14 EvrenTombul   My purpose is to write here. Do you know any IB schools using KOHA? Is there a place where I can share their marc records, ie dewey records, connect with z3950 protocol and share data? We want to access your catalog records from the Z39.50 protocol, we need z39.50 user & pass and connection information, but there should be a library resource that includes IB books.
13:14 EvrenTombul   koha, this is a job of 2-3 minutes, actually they do not always register books, 2-3 thousand books come a year, they can do them for once. I set the dewey z3950 connection from 2 universities, but we also have IB books, which our librarians say, there should be kindergarten and primary school books, it is said that universities do not have these books.
13:14 EvrenTombul   Hello everyone, I am the IT manager of the educational institution, Evren, Istek.k12.tr, I set up koha last month, kutuphane.istek.k12.tr, I teached training to our librarians, the old system we used was the routine, yordam.com. I haven't made our librarians love koha yet, although I know the benefits of koha. What they tell me is that they can do the catalog registration in 20 seconds, but in
13:14 cait1         oh good call, i will check that
13:12 Joubu         cait1: compare quantityreceived and quantity
13:12 Joubu         the quantity?
13:11 cait1         and orderstatus is complete...
13:11 cait1         they got a datereceived and a linked invoice
13:11 cait1         anyone know why that woudl be?
13:11 cait1         hm I have some orders that are complete and still show on late orders :(
13:10 huginn        News from kohagit: Bug 28419: Fix addorderiso2709.tt translatability <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7efdbccfc2dd79ff6658a60f6381182aff8c84b6>
13:10 huginn        News from kohagit: Bug 28419: Remove suspicious occurrence in opac-shelves.tt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f6b562da6d86d9a19e2e5245014595a398f6b283>
13:10 huginn        News from kohagit: Bug 28386: Disambiguate Tomas and Blou <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fe65caf5fb1a353e4ec971b6c638bdfccfa90b78>
13:10 huginn        News from kohagit: Bug 28461: Specify only one tag per route <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9de4594cf7ddb1c6b82b643e611055b72d7e70ce>
13:10 huginn        News from kohagit: Bug 28461: Fix SMTP servers and extended attributes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=09e47b434c4fcb4ad60608f50ecff4fde4785f5e>
13:10 huginn        News from kohagit: Bug 28461: Fix orders, biblios, holds <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4a15c972a89fe155112b8e8d9a8e297c4a9033fc>
12:59 Joubu         Luckily it was at the beginning of the file and I spotted it easily!
12:57 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 major, P5 - low, ---, jonathan.druart+koha, Passed QA , Page addorderiso2709.pl is untranslatable
12:57 oleonard      Good detective work on Bug 28419 Joubu
12:42 cait1         thx for testing the translation bug too
12:38 ashimema      fix stuff.. hehe
12:38 Joubu         what did I do?
12:36 ashimema      Joubu mostly ;)
12:36 ashimema      lol
12:35 cait1         ashimema++ Joubu++
12:23 oleonard      Great news
12:23 magnuse       Joubu and ashimema are fixing all the things ;-)
12:19 oleonard      What's goin' on today?
12:13 tcohen        hola magnuse
12:03 magnuse       kia ora tcohen and oleonard
11:45 oleonard      Hi all
11:40 tcohen        morning
11:10 ashimema      thanks
11:09 Joubu         ok so I am adjusting 28421
11:08 ashimema      in short.. it can wait I think.. Nick flagged it as high priority in the first place I think
11:07 ashimema      the problem also exists in previous versions.. but I have no idea how to fix it.
11:07 ashimema      in short.. the bug is fixed by the bugs it depends on.. the bug there is just a test to prove it.
11:07 ashimema      ack..
11:06 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , account_offset types should be codes not descriptions
11:06 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 normal, P5 - low, ---, martin.renvoize, Needs Signoff , When refunding lost fees we should not include voided payments
11:06 Joubu         that's confusing :)
11:06 Joubu         ashimema: you flagged bug 28421 for 21.05, but it depends on bug 22435, an enh you flagged for 21.11
10:03 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #599: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/599/
09:53 koha-jenkins  Project Koha_Master_U_Stable build #179: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/179/
09:53 koha-jenkins  Project Koha_Master_D9_My8 build #581: SUCCESS in 1 hr 12 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/581/
09:29 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #598: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/598/
09:23 koha-jenkins  Project Koha_Master_D9 build #1665: SUCCESS in 1 hr 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1665/
09:07 ashimema      it's really wierd
09:05 koha-jenkins  Project Koha_Master build #1657: SUCCESS in 1 hr 11 min: https://jenkins.koha-community.org/job/Koha_Master/1657/
09:04 Joubu         ashimema: it would be good to understand what's going on exactly. I was pretty sure moving to Data::Session would fix the problem but it doesn't!
09:03 ashimema      not great at this time of the cycle
09:03 ashimema      yeah.. I can imagine it being lots of work to move..
09:03 ashimema      things have moved fast on that one
09:03 ashimema      I'm not at all against this approach.. just surprised as I'd not looked at the bug in a couple of days..
08:58 Joubu         ashimema: I am open to any other alternatives!
08:58 Joubu         well, not tricky, but time consuming
08:58 Joubu         I've started the rewrite yesterday but it's not trivial. I wanted to know how it would be to move it. And it's tricky :D
08:57 Joubu         yes
08:56 ashimema      So, the idea now is to drop the background handling entirely.. then restore it using the modern pattern during the next cycle?
08:53 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 critical, P5 - low, ---, jonathan.druart+koha, Signed Off , Lost items not charging when marked lost from batch item modification
08:53 ashimema      blimey
08:53 ashimema      ooh.. bug 28158 has changed a bit since I last looked
08:51 koha-jenkins  Project Koha_Master_D11 build #305: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D11/305/
08:41 koha-jenkins  Project Koha_Master_U20 build #117: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U20/117/
08:28 koha-jenkins  Project Koha_Master_D10_CPAN build #341: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/341/
08:26 dcook         ciao for now
08:26 dcook         I need to run out of the office but thinking of coming back online when I get home..
08:25 dcook         Joubu: good point *shameface*
08:25 ashimema      :)
08:25 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 enhancement, P5 - low, ---, dcook, NEW , Build generic authentication module interface
08:25 dcook         ashimema: bug 24539 is what I've done
08:24 * ashimema    is on 28419 now
08:16 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 major, P5 - low, ---, jonathan.druart+koha, Signed Off , Page addorderiso2709.pl is untranslatable
08:16 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 critical, P5 - low, ---, jonathan.druart+koha, Signed Off , Lost items not charging when marked lost from batch item modification
08:16 Joubu         I know it's way less impressive than a C4::Auth rewrite, but bug 28158 and bug 28419 are blocker for the release (in 2 days)
08:15 * dcook       cranks up the tunes and bashes away on the keyboard
08:15 dcook         Pleasure as always
08:15 dcook         Ciao ashimema
08:14 ashimema      Have a good evening dcook :)
08:13 * ashimema    is walking and typing on the school run
08:13 dcook         But that's for another time haha
08:13 dcook         The hard part is that there's lots of little changes to make so there needs to be some momentum
08:13 ashimema      S/shoot/adopt
08:12 dcook         yeah there's an idea
08:12 ashimema      Indeed
08:12 dcook         Well C4::Auth::checkauth() really
08:12 ashimema      We could do like we did for PayPal.. and hooks, build up plugins then remove the core and shoot the plug-in as a community project
08:12 dcook         Then I want to slowly break up C4::Auth
08:12 dcook         I'm thinking this plugin idea rn
08:12 dcook         I think so too
08:11 ashimema      As much as I'd love to replace it all, small steps is definitely key to getting into Koha
08:11 dcook         Yeah I should add it to the roadmap..
08:11 dcook         Oh so small
08:11 ashimema      I like your plugins idea.. that would be a small piece for core initially
08:10 ashimema      It'll keep, stick it on the roadmap and maybe we can team up on it
08:10 ashimema      Hehe
08:10 ashimema      I thought kivis approach want bad.. the challenge was trying to wrap ones head around it all at once and how it would affect everything that already exists
08:09 dcook         Maybe if I add enough warnings to it..
08:09 dcook         Want to leave work atm but keen to post a functional example..
08:09 ashimema      That was Kivi actually.. lari took it over when kivi left I think
08:09 dcook         I wonder if I should just post my patch now. I was about to try to do a simple plugin..
08:08 dcook         yuuup haha
08:08 ashimema      I've written MFA and OAuth before.. but shoe horning it into Koha is a whole different proposition.. haha
08:08 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 enhancement, P5 - low, ---, olli-antti.kivilahti, BLOCKED , Authentication rewriting
08:08 dcook         bug 7174
08:08 dcook         Ah my bad, Lari
08:07 ashimema      Excellent
08:07 dcook         As I think he had something that included challenges..
08:07 dcook         Joonas might be a good one to talk to about that I think
08:07 dcook         So thinking I'll get the infrastructure into Koha, and then whoever wants to do the best plugin wins
08:07 ashimema      Right now it's just at the 'we want it stage'.. so I'm well and truly open in the design front
08:06 dcook         I have a (not amazing) generic OpenID Connect client which I've actually implemented locally using a plugin approach..
08:06 dcook         Mark Jaroski at the WHO wants to add OpenID Connect for AzureAD, so he's got me back on the AuthN train
08:06 dcook         Ooooh I'd like to hear more about that
08:06 ashimema      I have to add 2FA as a project very soon though.. so can get back into it :)
08:05 dcook         It's on the list heh
08:05 ashimema      I remember the flow inside C4::Auth always bring awfully convoluted.. anything to split it up into clear functional modules would be great
08:05 dcook         But they're not necessarily mutually exclusive so step by step..
08:05 dcook         I just have too many different ideas.. O_O
08:05 dcook         All good. I should have some patches shortly heh
08:04 ashimema      dcook, I think I need to get back up to speed on Auth two be honest.. it's an area of knowledge I've unfortunately let dwindle for a while
07:56 dcook         That's where ashimema works
07:56 dcook         TimothyAlexis: https://www.ptfs-europe.com/
07:55 TimothyAlexis ashimema: What is ptfs-e?
07:53 huginn        News from kohagit: Bug 15720: Add connexion user and password options to connexion daemon <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=16851a23aa914cf7426e4cc62e8a6fc040dcbea8>
07:53 huginn        News from kohagit: Bug 27942: Prevent XSS vulnerabilities in quote-upload <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=146f7314cf983ae20c35b2606acce7408e42e00e>
07:53 huginn        News from kohagit: Bug 20982: Sanitize category to prevent XSS on opac-shelves.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=abf1b6596c39b55b8a929c9c0329d113ea1f72df>
07:53 huginn        News from kohagit: Bug 28386: Add more disambiguations to .mailmap <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=335382e4553cd8bdd3b8ad07408888a0bae4b111>
07:21 * dcook       ponders
07:20 dcook         Ah maybe I will keep it all in C4::Auth just for the sake of familiarity..
07:13 dcook         Actually, if it's creating its own session, it doesn't even really need to call checkauth()..
07:11 dcook         Although I cheat with the session creation in that patch >_>
07:11 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 enhancement, P5 - low, ---, dcook, Needs Signoff , Use low privileged tokens to enable authenticated iCal feed
07:11 dcook         I wonder though if it would be nicer if auth plugins created their own sessions and just handed the sessions to checkauth() like I do with bug 27305
07:10 dcook         And using session data, it can also perform a logout
07:10 dcook         I give an $auth_plugin object to checkauth() and let it perform the login
07:10 dcook         I actually already have this running locally...
07:10 dcook         ashimema: You might have some thoughts on this
07:10 * dcook       is debating authN strategies..
07:09 * dcook       waves
07:07 ashimema      else I'd have tried to snap you up ;)
07:07 ashimema      ptfs-e are hiring now.. but they're all junior positions and not in my team unfortunately..
07:07 ashimema      ooh, Wikimedia would be a fun place to work I reckon
07:01 alex_a        Bonjour
07:00 TimothyAlexis Thank you. Well, if I could keep working with Koha then that could be interesting. But I've switched stack enough times to do it again if need be. I applied for a position at Wikimedia which would have worked very well, but didn't get a response.
06:58 TimothyAlexis ashimema I'm still looking. I found one, but I declined when we were about to start. Had an interview yesterday too.
06:57 ashimema      it's been good having you around anyways.
06:55 ashimema      Did you find another Job TimothyAlexis.. I seem to remember you looking semi-recently.
06:44 TimothyAlexis (in koha-conf.xml)
06:44 * magnuse     confuses all the people
06:43 magnuse       what he said
06:43 TimothyAlexis or are they somehow required for some reason..?
06:43 TimothyAlexis We're running Koha with Elastic Search, can we remove the settings for Zebra?
06:42 TimothyAlexis Äh jag trodde du var typ fransk..
06:41 TimothyAlexis hemskt mycket = awful lot
06:38 reiveune      hello
06:38 nlegrand      hämskt??? Hvorfor?
06:33 magnuse       nlegrand: hej hej hämskt mycket hej
06:14 nlegrand      hej
05:33 tuxayo        TimothyAlexis: yay 😃
05:06 TimothyAlexis We have*
05:06 TimothyAlexis So, I've kind of emptied our backlog. If I'm working here until mid october, I think that I'll be able to contribute a lot to Koha community.
00:00 koha-jenkins  Project Koha_20.11_D10-Core build #30: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_20.11_D10-Core/30/