Time Nick Message 23:52 aleisha i think maxreserves was intentional but honestly its been so long since i first wrote it that i cant remember! 23:52 tuxayo no worries 23:52 aleisha hey tuxayo sorry i was in a meeting 23:34 tuxayo (once the QA fixes are there) 23:34 tuxayo If the above is not an issue then you can count my signoff and QA :) 23:34 tuxayo Holds per day and holds total count the group as one. 23:34 tuxayo dcook: is the above list correct? If so, is it expected that for maxreserves = 3 it blocks a group hold of more than 3? 21:49 tuxayo What should be checked? mexreserves, holds per day, holds total. Is that was it's about? 21:49 tuxayo aleisha: «Note: A hold group is counted as only one hold» 21:39 tuxayo Found! For example /cgi-bin/koha/circ/circulation.pl?borrowernumber=5#reserves 21:36 tuxayo *Which 21:36 tuxayo With page is it? 21:36 tuxayo [...] 21:36 tuxayo - circ/circulation.pl 21:36 tuxayo > Note: the "hold group" link is displayed in the following pages: 21:36 tuxayo aleisha: 21:06 tuxayo great, let's try 21:05 aleisha i think it doesnt affect the behaviour of the patches so you probably could test! I'll submit fixes for those qa errors later today in a followup 21:04 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 new feature, P5 - low, ---, aleisha, Failed QA , Allow to place a hold on first available item from a group of titles 21:04 tuxayo aleisha: would the work needed for QA of bug 15516 invalidate a signoff? i.e. should I wait or can I start testing stuff? 20:50 tuxayo hi :) 20:46 aleisha hello 19:30 caroline lol! 19:29 tuxayo https://invidious.namazso.eu/watch?v=9VJSISCI4Uc&quality=medium&start=0m54s 19:29 tuxayo Me when the 25th and last step of a test plan is: «Repeat the above test plan but do your searching with the OPAC advanced search.» 17:32 tcohen like in function notify_that() { var report = []; $(".search_result_selector").each(function(){ $.ajax().success( report.push(...) ) }) } 17:31 tcohen so you need a variable, in which you can push all those informations that come from the API calls 17:30 tcohen I see. 17:30 oleonard So I'm fighting with async operations. 17:30 oleonard I was trying to come up with a system for giving the user feedback on operations from catalog search results... Specifically, "The following titles cannot be placed on hold" 17:29 tcohen what are you trying to do? 17:28 tcohen javascript is async, so it might be tricky; or at least it will look convoluted 17:27 oleonard I'm trying to work around the fact that I can't get more than one biblio at a time 17:26 oleonard Have you ever dealt with a situation where you had to make multiple ajax requests to the API and collect the result? 17:26 tcohen hey 17:26 oleonard Hi tcohen 17:22 tcohen oleonard-away yes 16:37 oleonard tcohen around? 15:55 huginn haris_niche: downloading the Perl source 15:55 haris_niche @magnuse The user and pass are same in koha and sip config file 15:29 reiveune bye 15:01 tuxayo khall++ kidclamp++ thanks for maintaining the next stable :D 14:44 domm1 or what exactly I have to configure in z3950servers.pl to make dnb.de/sru/authorities work 14:43 domm1 I assume that dnb.de returns a 400 BAD REQUEST, but I cannot figure out what request Koha is sending (and I don't want to dust off wireshark..) 14:43 domm1 can somebody help me setting up a Z39.50/SRU server config? We want to query https://services.dnb.de/sru/authorities, but I don't get any results, because it seems Zoom gets a 400 error (which is not reported to the UI) 13:56 tcohen hi all 13:22 Joubu :D 13:22 Joubu + C4::Circulation::updateWrongTransfer is never called but should be 13:22 Joubu - C4::Circulation::updateWrongTransfer is never called and should be removed 13:20 * ashimema wants to follow through and improve it with his cleanup next cycle 13:20 ashimema I think it'll need some reworking for backporting.. even though I kept it as low impact as possible for it to work at all with master it needed to account for all the recent work. 13:19 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 minor, P5 - low, ---, martin.renvoize, Needs Signoff , C4::Circulation::updateWrongTransfer is never called but should be 13:19 ashimema anyone fancy testing bug 24434 ? 13:11 magnuse easy to forget/miss 13:10 magnuse the user haris.niche must have the same password in koha and in the SIP config file 13:03 Joubu haris_niche: "Login Failure", did you double check the login/pwd? 12:31 haris_niche https://ctxt.io/2/AACg5YFhEg 12:30 haris_niche [2021/05/06 12:29:35] [DEBUG] Configuration::find_service: Trying 8023/tcp C4::SIP::Sip::siplog /usr/share/koha/lib/C4/SIP/Sip.pm (220) [2021/05/06 12:29:35] [DEBUG] telnet_transport: timeout is 60 C4::SIP::Sip::siplog /usr/share/koha/lib/C4/SIP/Sip.pm (220) [2021/05/06 12:29:40] [DEBUG] telnet_transport 1: uid length 43, pwd length 1 C4::SIP::Sip::siplog /usr/share/koha/lib/C4/SIP/Sip.pm (220) C4::SIP::Sip::siplog /usr/share/koha/lib/C4/SIP/Sip.p 12:30 haris_niche Here are the sip logs from when i try to login 12:23 haris_niche and I get login; in it's response 12:22 wahanui i already had it that way, huginn. 12:22 huginn haris_niche: I'll give you the answer just as soon as RDA is ready 12:22 haris_niche @kidclamp here is the raw message: 9300CNharis.niche|COword2P@ss|CP|AY1AZF2F4 12:21 nlegrand Hej #koha 12:19 kidclamp can you see the raw message you are sending? or tail the Koha sip logs to see what is happening? 12:17 haris_niche Any thoughts on what i am doing wrong? 12:16 haris_niche So i am wondering if this is because of some misconfiguration on my end in Koha SIP2 12:16 haris_niche And the issue I am seeing is that upon login request I get "login:" message in the response where as the response should be something starting with a couple of digits 12:14 haris_niche I have tried the following packages: https://www.npmjs.com/package/sip2 , https://www.npmjs.com/package/siptwo 12:12 haris_niche Hey Guys, Has anyone here worked on SIP2 server integration with NodeJS before? I am able to connect to the SIP2 on koha using telnet but i am not getting the right response in my code. 12:11 ashimema the fact it took customers so long to find kinda shows that 12:11 ashimema so it's a minor really 12:11 ashimema we're just a bit lost with where they're coming from. 12:11 ashimema the end result should be that the items still reach their final destination 12:11 ashimema but in reality it's cosmetic only 12:10 ashimema well.. kinda 12:10 Joubu transfer*s* 12:10 Joubu does it mean there are "wrong transfer" in the DB we will need to adjust? 12:10 ashimema it predates allot of my transfers work 12:10 ashimema yeah 12:10 ashimema ok.. converting the modal to a form it is then 12:10 Joubu bug is there since 19.05.00 :-/ 12:10 ashimema mmm 12:09 Joubu I would try and produce the simplest patch as possible, for backport 12:09 ashimema perhaps.. though I will need to update updateWrongTransfer to reflect all the other transfers changes.. but that should be simple enough 12:08 ashimema so get the modal to trigger it again 12:08 Joubu at least as a first step 12:08 Joubu shouldn't we only restore the previous behaviour with updateWrongTransfer? 12:07 ashimema now 'OK' does nothing because it's not a form submit.. it's just a modal close 12:07 ashimema and prior to this bug.. OK actually triggered the 'updateWrongTransfer' 12:06 ashimema in the past.. we had 'OK', 'OK and Print Slip', 'Cancel' 12:06 ashimema kinda 12:06 Joubu like, "cannot be transfer click to cancel and recreate"? 12:05 Joubu will we, at 3a ask the user what to do? 12:04 ashimema that's not the hard bit really.. it's where to implement calling it... template, controller or model 12:04 ashimema so it kinda replaces the 'updateWrongTransfer' function.. 12:03 ashimema I was tempted by the latter 12:03 ashimema or, for an audit path, cancel the original transfer with a trigger of 'WrongTransfer' and add a new transfer with the new 'from_branch' and the original 'to_branch' 12:03 ashimema simply update the 'from_branch' in the existing transfer 12:02 ashimema we have two options.. 12:02 wahanui i heard the fix was to add this in _before_dispatch : https://paste.debian.net/1049851/ 12:02 Joubu ashimema: what's the fix? 12:02 ashimema but also feels like it could be a bit too far reaching/scary to so in AddReturn right now. 12:01 ashimema it feels dirty to do it within the controller script 12:01 ashimema the template is already really overly complicated.. 12:01 ashimema but I'm not sure where to fix it.. 12:00 ashimema I've finally managed to identify the actual bug that's crept in.. 12:00 ashimema any thoughts on my above conundrum 12:00 Joubu yes 11:56 ashimema Joubu around.. ? 11:56 ashimema should I fix it in C4::Circulation.. circ/returns.pl or returns.tt 11:55 ashimema it's challenging to wrap one's head around.. 11:55 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 enhancement, P5 - low, ---, martin.renvoize, BLOCKED , C4::Circulation::updateWrongTransfer is never called and should be removed 11:55 * ashimema is trying to grok how to fix bug 24434 now 11:53 ashimema tcohen isn't around right now 11:53 * oleonard tried it 11:53 ashimema apparently Lucas has played with it lots 11:53 ashimema but tha'ts a guess 11:53 ashimema I have a vague feeling you could pass comma delimited 11:53 * oleonard wishes he could retain his knowledge of JavaScript from day to day 11:52 oleonard ashimema: I've got it working for a single biblionumber but I hoped I could pass multiple, e.g. 2/3/4 11:50 ashimema see oleanard queries above tcohen 11:50 ashimema can you not pass biblionumber in the q query tcohen ^ 11:49 ashimema man the modal logic in the returns page is such a mess 11:07 Joubu we don't have it 11:04 Joubu certainly with the GET /biblios route 11:04 oleonard Do you know if there is a way to pass multiple biblionumbers at once? 11:03 Joubu oleonard: and so you have an example there: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576 11:02 huginn Bug 23677: new feature, P5 - low, ---, tomascohen, CLOSED FIXED, Add API route to get a bibliographic record 11:02 Joubu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677#c23 11:02 Joubu I thought it had a default value 11:01 oleonard Oh I see, I got it this time. 11:00 Joubu a header iirc 11:00 oleonard A param I mean? 10:59 oleonard As a key? 10:59 Joubu ha it's for a GET, you need to pass the format you want 10:58 oleonard And I think I misread it, it's 406 not acceptable. 10:57 oleonard biblios 10:57 Joubu which route, oleonard? 10:56 oleonard Hm... 10:49 Joubu not enough permissions 10:48 oleonard What does "403 not acceptable" mean as an API response? 10:36 oleonard Hi all 09:44 ashimema they fill the logs so much it's hard to see the wood for the trees 09:23 magnuse ashimema: yes, i have seen stuff like that 09:13 ashimema for all sorts of pages 09:12 ashimema lines in their logs at the moment 09:12 ashimema and `Use of uninitialized value $lang in concatenation (.) or string at /home/martin/kohaclone/C4/Templates.pm line 296` 09:12 ashimema does anyone else see allot of `Use of uninitialized value $interface in string eq at /home/martin/kohaclone/C4/Templates.pm line 280` 08:17 ashimema :) 07:40 magnuse that one would be awesome to have in koha! 07:40 magnuse ashimema++ 07:37 ashimema ended up a late night 07:37 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 new feature, P5 - low, ---, glasklas, Passed QA , Write protecting MARC fields based on source of import 07:37 ashimema bug 14957 back to PQA :).. I'm sure a second QA signoff wouldn't go a miss though cait, cait1 etc.. lots of small qa follow-ups to fix all the qa script issues including a couple at the end where I clearly got it wrong first time around and thus fixed with followups whilst I ran through testing the whole feature again.. 06:58 alex_a Bonjour 06:52 Joubu thx, mtj! 06:48 mtj Hi joubu.. I'll aim to fix the ktd hirsute build tonite 06:40 reiveune hello 06:38 magnuse \o/ 04:08 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 enhancement, P5 - low, ---, aleisha, Failed QA , Change/Edit estimated delivery date per order line 04:08 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 enhancement, P5 - low, ---, aleisha, Failed QA , Show due date and availability in item search results 04:08 aleisha bug 17748 and bug 15348 04:08 aleisha i'm stuck on a couple of other bugs if there are any datatables experts 04:08 aleisha yes they just need testing ! 03:00 dcook That's all right. We'll get to the others 03:00 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 enhancement, P5 - low, ---, aleisha, Signed Off , Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search 03:00 dcook Oh wait it looks like bug 21249 is the only one that I can move on.