Time  Nick          Message
06:18 reiveune      hello
06:18 wahanui       kia ora, reiveune
06:38 magnuse       \o/
06:42 alex_a        Bonjour
08:06 TimothyAlexis In the staff interface at "cgi-bin/koha/catalogue/detail.pl" there is a  MARC preview.
08:07 TimothyAlexis Some of the librarians here have requested this as a column in the table at cgi-bin/koha/authorities/authorities-home.pl too.
08:53 ashimema      can someone remind me how locale_data.js gets generated.. where.. ?
08:54 Joubu         install a new language
08:57 Joubu         then koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js
08:59 ashimema      tuxayo around?
09:00 ashimema      indeed.. but where do the strings actually come from Joubu.. we're seeing some odd things in en-GB and our translator person is sure he's translated the relevant strings
09:02 Joubu         ashimema: they are coming from __() from .js files
09:02 ashimema      I see..
09:02 ashimema      I'll go digging a bit
09:03 Joubu         for instance:
09:03 Joubu         "Loading... you may continue scanning."
09:03 Joubu         is coming from
09:03 Joubu         koha-tmpl/intranet-tmpl/prog/js/checkouts.js:        var msg_loading = __('Loading... you may continue scanning.');
09:07 jajm          ashimema, translations are taken from po/en-GB-messages-js.po (notice the "-js" part)
09:08 ashimema      thanks jajm.. I'll check with our translator.. he may well have missed it somehow
09:16 Joubu         mtj: I bet you noticed the API failures on Ubuntu latest. Is it because we are missing the json-validator "really" package for hirsute?
09:17 TimothyAlexis What I'm thinking is if I should make a patch for it in master or if we should make a local edit for our libraries. There is already a link to the MARC Details in that table.
09:22 Joubu         TimothyAlexis: what is "that table"? the authorities search result?
09:23 TimothyAlexis Joubu Yeah
09:23 Joubu         I don't see "MARC detail" links
09:23 Joubu         https://snipboard.io/ytRkdU.jpg
09:24 TimothyAlexis oh
09:25 ashimema      ok, next daft question
09:25 TimothyAlexis So that was already custom then ;)
09:25 ashimema      why would I get getting a 403 when trying to fetch prog/en/modules/admin/preferences/items.json and other .json files in that location?
09:26 TimothyAlexis Hmm no, I asked my colleague about it and he says it's supposed to be there.
09:26 ashimema      we have a few customers having that.. it means the modals with select options don't have any select options to pick from in the system preferences
09:27 TimothyAlexis https://snipboard.io/eYUoT8.jpg
09:28 TimothyAlexis This is what ours look like, we have version 20.05.03
09:28 TimothyAlexis First one there links to: ...cgi-bin/koha/authorities/detail.pl?authid=150048
09:29 Joubu         TimothyAlexis: I am on master and I don't see it :)
09:30 Joubu         either it has been removed or it's something custom you have
09:30 Joubu         ashimema: did you compare the versions? Is that a problem on a specific version only?
09:31 ashimema      I think it's perhaps to do with install types
09:31 ashimema      we have a bit of a mix
09:43 huginn        News from kohagit: Bug 28210: Add issue, replacementprice, and set onloan so check-in tests work <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9dbe57b5648b776298576d91c684154f8cc54a39>
09:43 huginn        News from kohagit: Bug 28210: Unit test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bc0cf683eee210909012f068c8ea30c0c2055e90>
09:43 huginn        News from kohagit: Bug 28210: Pass skip_record_index through LostItem <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00883fc411975905710c1a53fedd300a6d3a37ab>
09:43 huginn        News from kohagit: Bug 24446: (follow-up) Fix tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9d14bc5a0581080c97c5775571a2b99657d1070>
09:43 huginn        News from kohagit: Bug 27281: (QA follow-up) Fix Indexer Test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b15138278518227b64e725c7a4ac5ad97f5e99b>
09:49 ashimema      ok
09:49 ashimema      bug 22844 doesn't work for standard or dev type installs
09:49 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 enhancement, P5 - low, ---, oleonard, Pushed to master , Simplify the process of selecting database columns for system preferences
09:49 ashimema      the .json files are under a restricted directory in the apache config
09:56 Joubu         ashimema: Looks like they are missing from makefile.pl?
09:56 ashimema      could be
10:03 * ashimema    needs more tea
10:04 Joubu         tuxayo: "tuxayo > Joubu: I'm preparing the email for the election meeting ^^"
10:04 Joubu         tuxayo: did you send it?
10:05 ashimema      I think I saw one.. it was very brief though
10:11 Joubu         I don't see it
10:12 Joubu         ho, I see it now :)
10:12 Joubu         tuxayo: ok nevermind, you did! thx
10:13 ashimema      wouldn't hurt to follow up on it again
10:19 oleonard      Hi
10:19 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #578: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/578/
10:19 ashimema      @later tell tuxayo any chance of a backport for bug 24567
10:19 huginn        ashimema: The operation succeeded.
10:19 ashimema      Hi oleonard
10:19 wahanui       hi oleopard
10:46 koha-jenkins  Project Koha_Master_D9 build #1637: SUCCESS in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1637/
10:48 koha-jenkins  Yippee, build fixed!
10:48 wahanui       Congratulations!
10:48 koha-jenkins  Project Koha_Master build #1632: FIXED in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master/1632/
10:58 koha-jenkins  Project Koha_Master_D10_CPAN build #312: SUCCESS in 1 hr 14 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/312/
11:01 tcohen        morning
11:03 magnuse       midday
11:03 oleonard      morning
11:14 koha-jenkins  Project Koha_Master_D9_My8 build #559: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/559/
11:19 koha-jenkins  Project Koha_Master_D11 build #279: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D11/279/
11:22 Joubu         SO and QA needed on bug 28200 please
11:22 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 normal, P5 - low, ---, dcook, Needs Signoff , Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
11:22 Joubu         D11 test failing
11:25 kohaputti     cait1, "I haven't verified yet, but that would be a killer for any German installation..." in bug 28230 made my day (it literally kills the Koha instance).
11:25 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28230 blocker, P5 - low, ---, joonas.kylmala, Signed Off , Renewing/Checking out record with AE or OE letter in title can make Koha totally unfunctional
11:27 tcohen        hehe
11:27 tcohen        Joubu I proposed an alternate patch on bug 28234
11:27 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28234 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , TestBuilder->build_sample_biblio does not deal correctly with encoding
11:29 kohaputti     tcohen, let me qa it.
11:29 tcohen        (y)
11:29 kohaputti     oh, or sign-off, I thought it was already SO'd
11:30 tcohen        you can count my SO on my patch...
11:30 tcohen        it is too trivial anyways
11:30 tcohen        he
11:31 kohaputti     oh wait, two patches.
11:31 kohaputti     which one to select :D
11:31 tcohen        the correct one, of course :-D
11:33 tcohen        you can FQA them, as none has tests LOL
11:34 kohaputti     test to test tester :D
11:36 kohaputti     why do we have this stuff in SetMarcUnicodeFlag()
11:39 kohaputti     some places in Koha we don't use it and in some places we do... I mean some use just that ->encoding('UTF-8') instead of the "koha way"
11:40 koha-jenkins  Project Koha_Master_U_Stable build #168: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/168/
11:59 Joubu         tcohen: does it deal with the header?
12:00 tcohen        it is a problem?
12:01 tcohen        setting the ->encoding will set the right LEADER position with the right value
12:02 tcohen        but the rest of it will remain empty
12:02 tcohen        https://metacpan.org/release/MARC-Record/source/lib/MARC/Record.pm#L544
12:05 Joubu         tcohen: your patch is better then
12:18 cait1         kohaputti: not a lie... we have many of those
12:18 tcohen        Joubu do you remember us havnig tests for 'no warns' ?
12:18 cait1         kohaputti: actually, we once provided a patch to fix the Pokémon problem with SIP, because it died for diacritics
12:19 cait1         and I was later told it was known as the pokemon problem in some US libraries
12:19 kohaputti     haha
12:19 kohaputti     :)
12:19 cait1         but that was many many moons ago
12:20 Joubu         tcohen: nope, I don't think we have. Do you mean QA checks to prevent "no warns;"?
12:28 tcohen        Joubu in this case we would benefit from something like
12:29 tcohen        no_warns { $builder->build_sample_biblio()... }
12:29 cait1         you know what makes me sad? the notes for an order arenot shown anywhere but on basket summary
12:29 tcohen        to write tests
12:33 oleonard      cait1: I remember the Pokémon problem!
12:33 * oleonard    wonders how many records we still have in Koha with no diacritics because catalogers took them all out
12:35 cait1         ouch
12:35 cait1         glad that would not even be an option here .)
12:35 oleonard      (being an American public library there weren't *that* many, but still...)
12:35 cait1         so the bug got fixed in the end
12:36 oleonard      I like the mental image triggered by "the pokemon problem in US libraries" Little Pokémon running around causing trouble in the stacks.
12:36 tcohen        Joubu https://metacpan.org/pod/Test::Warnings
12:36 oleonard      tcohen: Is it possible to write an API route for DB columns? That'd be cool and useful.
12:36 * oleonard    bbl
12:36 tcohen        yeah, why not?
12:36 tcohen        can you give me a spec?
12:37 tcohen        is it per language?
12:37 * ashimema    thinks oleonard just saw my bug about json files
12:39 ashimema      I actually wondered if rather than db columns we should be pulling in from the api specs.. they list available fields already
12:39 Joubu         tcohen: t/db_dependent/Koha/Objects.t
12:39 Joubu         1255     warnings_are { Koha::Cities->delete }[],
12:39 Joubu         1256       "No warnings, no Koha::City->delete called as it doesn't exist";
12:41 tcohen        thanks Joubu
12:41 tcohen        I wonder who wrote that, LOL
13:25 oleonard      Yes ashimema I saw your bug about json files
13:26 ashimema      :)
13:56 tuxayo        hi #koha o/
13:57 ashimema      hi tuxayo
13:59 tuxayo        ashimema: «any chance of a backport for bug 24567»
13:59 tuxayo        Yep, I'll check it :)
13:59 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 normal, P5 - low, ---, nick, RESOLVED FIXED, Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once
13:59 ashimema      thanks dude :)
14:00 tuxayo        Good to know oldoldstable is used by some of your customers :D
14:00 ashimema      loads ;)
14:00 ashimema      as of late.. we jump the .05 cycles to we only run .11's
14:00 ashimema      but we don't upgrade all customers at once..
14:00 ashimema      so we have a mix of 18.11, 19.11 and 20.11's at the moment
14:01 ashimema      very few 18.11's, a good number of 19.11's and a few 20.11's
14:01 ashimema      (and a few others mixed in for 'fun'.. lol)
14:02 Joubu         the real fun is only when you run master ;)
14:03 tuxayo        lol
14:03 ashimema      lol
14:03 tuxayo        I'm may have misunderstood but someone kinda does that right?
14:03 ashimema      take a look at Version  on https://hea.koha-community.org/systempreferences... there's loads of 19.11's still ;)
14:04 ashimema      we ran master for a while with a number of customers.. fair few years back now..
14:04 ashimema      it certainly was 'fun'
14:04 ashimema      not done that for a long time
14:04 ashimema      it's scary
14:04 tuxayo        ashimema: «loads of 19.11» yep, not on my versions yet, but I'm monitoring that ^^
14:06 oleonard      I suspect that customers who want to run master don't really know what they're getting themselves into
14:07 ashimema      to be fair.. Koha's master branch is way more reliable and stable now that it has been at times.. we have lots more tests and run them far more vigilantly in recent cycles
14:07 ashimema      but yes.. it does break.. and does break often..
14:07 ashimema      tests fail.. and we fix bugs :)
14:07 oleonard      And sometimes we do dumb things with bad CSS.
14:07 ashimema      hehe
14:07 ashimema      ohhh, yes.
14:15 tuxayo        ashimema: thanks for the info about the versions. It good to have an idea how it Koha is used :D
14:15 ashimema      pleasure
14:15 * ashimema    is a stats geek
14:28 huginn        News from kohagit: Bug 26734: DBRev 20.12.00.041 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1937f1b1d10aa6ddf8bea8b6da05ae4361149fe0>
14:28 huginn        News from kohagit: Bug 27790: Add the new column to columns_settings.yml <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ad2dec0737657bd61a4c05ee0073eb813d0187b6>
14:28 huginn        News from kohagit: Bug 27790: (QA follow-up) Fix offsets due to new columns <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a568716e92d91a69b2e26b9ae8297dc679bdfb7e>
14:28 huginn        News from kohagit: Bug 27995: (QA follow-up) Update POD <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1c29873160d9102d9a4b2648f0f441e0561ad486>
14:28 huginn        News from kohagit: Bug 26734: Add notices for translations <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=643aed1af6a607d1dc5fc657165e9f78713624cc>
14:28 huginn        News from kohagit: Bug 26734: (QA follow-up) Add warning to database update <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f38832d95b2ded90f049c4d6002273ff81e88cf4>
14:28 huginn        News from kohagit: Bug 26734: (follow-up) Add back 'UPGRADE' type to logviewer <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a0327fa6bc2a4c796bba1ff5f496f7029763a459>
14:28 huginn        News from kohagit: Bug 27636: Update failing test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3181539df6aae5361a9e5e6bcb5f67fd484c682a>
14:28 huginn        News from kohagit: Bug 27636: Update ->pay to use ->payin_amount internally <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=630aa51502bf39d6fc5e32ccf5a5e7535e720b59>
14:28 huginn        News from kohagit: Bug 27995: Update return for Koha::Account::Line->apply <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fb3a67f21b90433fa73bf8a739f1508e226025b0>
14:28 huginn        News from kohagit: Bug 27995: Unit tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=479c8d997e3c73415861b5d15b6bf207d6c59ca1>
14:28 huginn        News from kohagit: Bug 26734: (QA follow-up) Add 'tendered' and 'change' to notice <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5f507d60f4fee138547175be6111878d0e19e224>
14:28 huginn        News from kohagit: Bug 26734: (QA follow-up) Unit tests for C4::Letters <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d9a508a49944f8a73d64c615e070490c6195e102>
14:28 huginn        News from kohagit: Bug 26734: (QA follow-up) Add missing copyright statement <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1a748520188e4cada61c84ca395d3c34019cc480>
14:28 huginn        News from kohagit: Bug 27790: separate earliest hold date into two different columns <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9abbdf7065ea67cfc54cd15231a2c8138dcdfb71>
14:28 huginn        News from kohagit: Bug 27636: Add payin_amount to Koha::Account <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4bb73229b8fce7527909d72b02a43e265336f0d6>
14:28 huginn        News from kohagit: Bug 26734: (follow-up) Replace db update with backup and default <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0bdfedc13e63f3e70ace2eac37b04307cd39d75b>
14:28 huginn        News from kohagit: Bug 26734: Update existing notices to new syntax <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e6ed0c7151ed0e5de137a9ad17daf3a6d17aa39b>
14:28 huginn        News from kohagit: Bug 26734: Update sample notices to use standardised syntax <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3f7b1e4230959808f4a85727be50428241484500>
14:28 huginn        News from kohagit: Bug 26734: Convert printfeercpt/printinvoice to use GetPreparedLetter <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cff7ed4fd3358b079283b57a8946a05b87542a4d>
14:29 ashimema      :)
14:42 ashimema      cait around?
14:43 ashimema      cait, cait1, cait2, cait3, cait4
14:59 oleonard      Not a single cait
14:59 ashimema      seems not
14:59 ashimema      I think I've untangled what I was looking for now..
15:02 reiveune      bye
15:04 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #579: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/579/
15:30 koha-jenkins  Project Koha_Master build #1633: UNSTABLE in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master/1633/
15:31 koha-jenkins  Project Koha_Master_D9 build #1638: UNSTABLE in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1638/
15:44 koha-jenkins  Project Koha_Master_D10_CPAN build #313: UNSTABLE in 1 hr 15 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/313/
16:03 koha-jenkins  Project Koha_Master_D9_My8 build #560: UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/560/
16:04 koha-jenkins  Project Koha_Master_D11 build #280: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D11/280/
16:04 nitesh        Hello.. Unable to find koha-foreach.xml  file. so not able to apply patch of bug 17717. Currently using koha version 16.11
16:04 huginn        Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 critical, P4, ---, tomascohen, UNCONFIRMED , Fix broken cronjobs due to permissions of the current directory
16:07 koha-jenkins  Project Koha_Master_D10_CPAN build #314: STILL UNSTABLE in 31 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/314/
16:22 koha-jenkins  Project Koha_Master_U_Stable build #169: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/169/
16:34 koha-jenkins  Project Koha_Master_D9 build #1639: STILL UNSTABLE in 58 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1639/
21:26 tuxayo        bywater++ thanks for the public tutorials, it's not the first time that helps me to sign-off.
21:26 tuxayo        I didn't found how to merge patrons but got saved by this :) https://bywatersolutions.com/education/merging-patron-18-05