Time Nick Message 00:38 tuxayo see ya 00:38 tuxayo o/ 06:04 reiveune hello 06:10 magnuse \o/ 06:19 cait1 good morning äkoha 06:19 cait1 #koha too :) 06:46 alex_a Bonjour 06:51 cait1 fridolin: could you check bug 27811 for 20.11 plesae? 06:51 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27811 normal, P5 - low, ---, koha-bugs, NEW , Manage patrons fines and fees (updatecharges) subpermissions shows links/buttons that cannot be accessed 06:53 cait1 and bug 27889 (working through our 20.11 testing findings) 06:53 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 normal, P5 - low, ---, oleonard, Pushed to master , Form fields in OPAC are "out of shape" 06:54 fridolin cait1: oki i will 06:54 cait1 fridolin: checking on our bug list, sorry to bother .) 06:55 fridolin no problem ;) 07:22 cait1 fridolin: good news is, most bugs my coworkers found are already fixed in the latest 20.11 verions :) 07:25 cait1 or will be fixed 07:36 fridolin good 08:27 mkuhn Hi - I got an error message about setting variable "access_dir" in "koha-conf.xml" but except in bug 11317 I cannot find any information about this variable (actually there are two variables with the same name inside "access_dirs"). It is not documented in the Koha manual. I'm not sure how to set it - does anyone know about this? 08:27 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 enhancement, P5 - low, ---, philippe.blouin, CLOSED FIXED, Add a way to access files from the intranet 08:27 cait1 I think this belongs to the tool for accessing files from within koha 08:27 cait1 tools > access files 08:28 cait1 you can file a bug for missing documentation 08:28 mkuhn Yes but what directories to use? 08:28 cait1 i think you would use the directory you want to use, for example where you store files for print notices generated on the server 08:29 cait1 the use wold depend on your config and how you have set up things - or how you want to use the feature 08:29 mkuhn Should I add this comment to bug 11317 or open a new bug? 08:29 cait1 never add to closed bugs 08:29 cait1 always make a new one and link them in this case 08:30 cait1 i'duse depends on 08:30 mkuhn Yes, it seems - this should be described somewhere. It is also unclear to me why there are two "access_dir" inside "access_dirs" - also these varoiables were missing when updating from an earlier version. Too bad. 08:30 cait1 i thin it might just be a way to tell you that you can set up mulitple 08:30 cait1 not being limitd to one path 08:31 ashimema it's an example mkuhn 08:31 ashimema for example.. you might want to allow access to logs in one dir and notices in another 08:31 ashimema access_dir is repeatable inside access_dirs 08:31 ashimema yes.. it needs documenting better though.. add a bug and it'll get picked up by the documentation team 08:31 mkuhn No, in fact there is no example. When updating form earlier versions the variable8s) are not there. When installing Koha 20.11 the variable(s) are there but empty. 08:32 mkuhn OK, thank you very much, I'll file a bug on this. 08:32 cait1 mkuhn: that's normal 08:32 cait1 i mean for an existing installation the koha-conf.xml is not altered 08:32 cait1 i think you always need to check the newer for changes? ashimema might correct me 08:32 cait1 that's just something i picked up from talking internally 08:33 ashimema I'm not so sure.. it's been a while since I worked in upgrades ;) 08:33 ashimema I 'think' it depends on the way you'e done your install 08:33 cait1 i believe i have seen "checking kohaconf-variables" on our sysadmins checklist 08:33 ashimema the makefile replaces and adds a backup 08:33 ashimema but packages may behave differently 08:34 ashimema yeah.. you certainly always need to check them 08:34 cait1 we have packages 08:34 mkuhn Well, since I was doing the update I can't remeber there was a note saying the variable access_dirs / access_dir schould be added. And since there is no documentation about it... as said, I'll file a bug. 08:35 cait1 it's an optional feature, it should not break things if you are missing it apart from not being able to use this one tool 08:35 cait1 if you open it without it being set it might even tell you to do it 08:36 ashimema ping the bug number in here once you've recorded it mkuhn.. I'll take a look at quickly writing some docs for it.. I didn't develop the feature but I think I mostly understand how it works at present. 09:02 mkuhn I have now filed bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28151 09:02 huginn Bug 28151: normal, P5 - low, ---, koha-bugs, NEW , Missing documentation on variable "access_dir" 09:03 ashimema ta 10:25 oleonard Hi all 10:36 henryb Hi oleonard 10:36 wahanui hi oleopard 10:36 ashimema morning henryb 10:36 ashimema hi oleonard 10:36 wahanui hi oleopard 10:37 henryb morning ashimema 10:47 tcohen morning 10:48 ashimema morning tcohen 11:12 oleonard kidclamp: Got a question for you about Bug 16787 when you get a moment 11:12 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 normal, P5 - low, ---, nick, Needs Signoff , 'Too many holds' message appears inappropriately and is missing data 11:13 kidclamp sure 11:15 oleonard In the test plan, step 7: Does this refer to placing a multihold from search results? 11:19 davewood im importing marcxml records and i get a lot of "Already in a transaction" errors/warnings. im using the script bulkmarcimport.pl ... script output at the end is: 23480 MARC records done in 1939.21913790703 seconds 11:19 davewood there is this bug report ... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 11:19 huginn Bug 27245: major, P5 - low, ---, jonathan.druart, Pushed to oldoldstable , bulkmarcimport.pl error 'Already in a transaction' 11:20 davewood im faintly rememebr having this conversation/issue before but i cant find it anywhere 11:20 davewood xml is valid (checked with xmllint --schema MARC21slim.xsd) 11:21 pastebot "tcohen" at 127.0.0.1 pasted "Joubu:" (20 lines) at http://paste.koha-community.org/145 11:22 kidclamp oleonard: yes 11:23 oleonard kidclamp: I notice a difference in how multiholds behave before an after the patch if you access request.pl directly, e.g. request.pl?biblionumbers=1/2/3/4/5 11:23 oleonard Before the patch, submitting a patron from that page will result in a page which shows a warning about some items not being available. 11:23 oleonard After the patch that warning doesn't appear. 11:28 davewood we are using this koha version (from our apt sources list) -> deb [trusted=yes] http://debian.koha-community.org/koha 20.11 main 11:32 kidclamp can you send me screenshots Owen, I don't recreate 11:33 oleonard I'll try to describe more clearly on the bug 11:49 kidclamp what makes the items non-holdable in that scenario? 11:51 oleonard All items on the record have an item type which cannot be placed on hold. 11:53 kidclamp I am not recreating. let me try following my own test plan 12:01 kidclamp I cannot recreate owen - does the first record have multiple item types? are the items allowed '0' acosta 12:02 kidclamp heh. that is 'allowed 0 holds, or no holds allowed'? I am seeing that any reason that blocks is showing the message 12:05 oleonard All the items on the record are a non-holdable itemtype, but the biblio-level itemtype is different (and holdable) 12:06 oleonard fridolin around? 12:08 kidclamp using item level itemtypes? 12:10 oleonard Oh--I thought I was but I just checked and I had it switched. So my test showed an improvement rather than a regression? 12:10 oleonard I will test again! 12:10 kidclamp hahah, thank you! 12:16 koha-jenkins Project Koha_20.11_U20 build #64: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/64/ 12:16 fridolin oleonard: yep ? 12:17 oleonard fridolin: Looking at Bug 27861, I'm not finding any errors in my logs. Which log file should I see it in? 12:17 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27861 normal, P5 - low, ---, fridolin.somers, Needs Signoff , Warning in C4/XSLT.pm - use of uninitialized value in numeric eq (==) 12:17 fridolin davewood you need to specify OS after "main", like bionic for Ubuntu Bionic 18.04 12:18 fridolin oleonard: ah plack error logs 12:18 fridolin maybe now it is managed by log4perl 12:20 oleonard plack-api-error.log, plack-error.log, plack-intranet-error.log, plack.log, plack-opac-error.log 12:20 oleonard so many plack error logs 12:21 kidclamp oleonard: added a small follow-up to make sure the full error is displayed 12:30 oleonard Sorry fridolin no sign of that error that I can see. 12:31 koha-jenkins Project Koha_20.11_D10 build #84: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/84/ 12:32 fridolin oleonard: ok I'll retest, add a comment please 12:36 oleonard fridolin: The data in my test system didn't have NULL in itemtypes.notforloan, it had zero. But I tested both ways. 12:37 koha-jenkins Project Koha_20.11_U2010 build #59: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.11_U2010/59/ 12:43 koha-jenkins Project Koha_20.11_D10 build #85: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/85/ 12:48 koha-jenkins Project Koha_20.11_U16 build #66: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/66/ 12:52 koha-jenkins Project Koha_20.11_D9 build #81: SUCCESS in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/81/ 12:56 davewood fridolin: https://wiki.koha-community.org/wiki/Koha_on_Debian ... is it a bug here then? all these examples on https://wiki.debian.org/SourcesList do not mention the OS part you are talking about as far as I can see 13:00 davewood well, have to correct myself, the second link does show the debian version. in my example we use 20.11 ... I guess that is the version you are talking about 13:04 fridolin indeed wiki page should tell that 13:10 oleonard One OS crash later... 13:10 koha-jenkins Project Koha_20.11_U18 build #60: SUCCESS in 1 hr 27 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/60/ 13:12 koha-jenkins Project Koha_20.11_U18 build #61: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/61/ 13:16 koha-jenkins Project Koha_20.11_U2010 build #60: SUCCESS in 28 min: https://jenkins.koha-community.org/job/Koha_20.11_U2010/60/ 13:30 koha-jenkins Project Koha_20.11_U20 build #65: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/65/ 13:33 koha-jenkins Project Koha_20.11_D11 build #97: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/97/ 13:45 ashimema henryb around still? 13:49 henryb Here ashimema 13:50 henryb Did you want me to do a second sign off for bug 26703 ? 13:50 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 enhancement, P5 - low, ---, wainuiwitikapark, Signed Off , We should reconsider best practice for our title elements 13:50 ashimema I wondered if you had the motivation to run through the testing for title elements :) 13:50 ashimema I could convert my SO to a QA that way ;) 13:50 ashimema and I trust you to do a good job.. hehe 13:51 * ashimema likes to have a library eye take a look at things like this.. rather than just my sometimes overly technical tunnel vision :) 13:52 Joubu henryb: +1 from me too! 13:55 * ashimema is currently working through the OPAC headers bug 14:04 ashimema does anyone else get some funky stuff on the opac on master at the moment? 14:05 ashimema I get a stray '1' in the top left corner.. and the 'Skip to main content' button seems to always be visible.. but partially off screen 14:05 oleonard No ashimema, only the funky font stuff 14:07 ashimema https://snipboard.io/IiuYEc.jpg 14:07 ashimema that's what I see.. can't for the life of me work out why 14:24 ashimema hmm 14:24 oleonard Any luck ashimema? 14:24 ashimema 'Welcome, NAME'.. why is that an H3 ? 14:24 ashimema no luck 14:24 ashimema my userjs and user css are both empty 14:24 ashimema no custom style sheets etc 14:24 oleonard Are you testing a particular patch? 14:25 ashimema and all the news blocks and opac prefs have just a simple single line text string in to make them all appear 14:25 ashimema I'm testing the headings bug 14:25 ashimema bug 27740 14:25 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 enhancement, P5 - low, ---, wainuiwitikapark, Signed Off , Accessibility: OPAC - Headings should have correct tags and hierarchy 14:26 ashimema but even on master, with no bugs applied I get this oleonard 14:26 ashimema it's weird 14:28 ashimema aha.. 14:28 ashimema ok.. ignoring my random '1' for now 14:28 ashimema why is the 'Welcome, USER' dropdown constructed differently on opac-main to every other page on the opac.. i.e. why do we not use the include there? 14:30 ashimema oooh... 14:30 ashimema I'm a muppet 14:30 ashimema on opac-main I'm looking at totally the wrong thing on the page! 14:30 ashimema doh! 14:31 ashimema humm.. 14:32 ashimema henryb.. what's your thoughts on the header for the usersummary on the opac.. when you're logged in and on the front page a box appears on the right with a summary of your account details.. 14:32 ashimema it's has an out of order header 14:50 ashimema ok.. left some feedback on bug 27740.. I was pretty rigorous 14:50 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 enhancement, P5 - low, ---, wainuiwitikapark, Signed Off , Accessibility: OPAC - Headings should have correct tags and hierarchy 14:51 ashimema some of it may want some input form the UX master oleonard.. like 'box titles'.. do they constitute being headings 14:56 oleonard I don't know the answer off the top of my head, but I'm happy with incremental improvement so it doesn't have to be perfect. 14:56 * ashimema is mostly wanting to make sure we don't go backwards :) 14:56 ashimema but yes.. I'm happy with incremental change 15:06 reiveune bye 15:07 henryb Sorry ashimema, I'm still thinking about this one. I'll take a proper look once I've finished bug bug 26703 15:07 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 enhancement, P5 - low, ---, wainuiwitikapark, Signed Off , We should reconsider best practice for our title elements 15:07 ashimema okies, thanks hendryb 15:08 henryb Although I would say that "Welcome X" isn't the most descriptive heading (whatever the level) - Account Summary or something similar would probably be better 15:09 henryb I agree about incremental change though, especially because we want to avoid having to rebase 15:29 henryb ashimema I'm getting a conflict on some of the patches for bug 26703. What's the quickest way to fix it? 15:29 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 enhancement, P5 - low, ---, wainuiwitikapark, Signed Off , We should reconsider best practice for our title elements 15:30 henryb e.g. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 26703: cataloguing folder 15:31 henryb I can obsolete and add my own patch, right? but then we'd need sign off again? 15:31 henryb Or is there clever rebase function somewhere 15:37 ashimema humm 15:38 ashimema git mergetool is what I'd use to get them right again 15:39 ashimema humm.. 15:39 ashimema or ask for the original author to rebase them.. then add your SO line after 15:39 ashimema I can take a quick look if you like 15:46 henryb Yes please if you have time 15:48 ashimema on it 15:50 henryb Thanks! ashimema++ 15:51 ashimema wow.. someone changed quite a lot.. lol 16:01 ashimema I blame oleonard ;) 16:02 ashimema bug 28037 and bug 27846 16:02 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 enhancement, P5 - low, ---, oleonard, Pushed to master , Improve breadcrumbs of CSV profiles page 16:02 ashimema to be precise 16:02 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 enhancement, P5 - low, ---, wainuiwitikapark, Pushed to master , Accessibility: Staff Client - Breadcrumbs should be more accessible 16:02 ashimema lol 16:02 ashimema one was in fact wainuiwtika 16:03 ashimema wainui even 16:04 ashimema all done henryb.. those patches should now apply 16:13 henryb Thanks! I will get testing before anything else changes! 16:14 ashimema thanks dude :) 16:14 ashimema much appreciated 16:18 cait1 wainui++ btw 16:18 cait1 did you see she signed up for rmaint too? :) 16:18 henryb Yes, definitely wainui++ 16:20 cait1 bye all 16:28 henryb Bye cait1, hi cait. Where are cait2 and cait3? 19:02 ashimema Oh nice one, that's great news 19:02 ashimema wainui++