Time Nick Message
06:37 liliputech_asu hi koha
06:45 liliputech_asu hi there, while trying to provision a sandbox on bywater selfprovisionning system :
06:45 liliputech_asu TASK [Clone koha source to /usr/local/src/koha] ********************************
06:45 liliputech_asu fatal: [localhost]: FAILED! => {"changed": false, "cmd": ["/usr/bin/git", "fetch", "--tags", "origin"], "msg": "Failed to download remote objects and refs: fatal: unable to connect to git.koha-community.org:\ngit.koha-community.org[0: 3.23.183.225]: errno=Connection refused\n\n"}
06:46 liliputech_asu salut lds, tu es bien matinal :)
06:52 lds liliputech_asu: hello toi aussi :)
06:56 liliputech_asu c'est l'air (frais) de la montagne lds ;)
06:59 liliputech_asu anyone (not biblibre) willing to test bz7376?
07:07 reiveune hello
07:44 alex_a Bonjour
07:53 lds hello 502 gateway timeout when i clone https://git.koha-community.org/Koha-community/Koha.git this morning
07:54 lds liliputech_asu: ^
07:56 cait1 lds: it's working for me right now
07:56 cait1 do you want to check again?
07:56 lds cait1: git clone --branch 19.11.x --single-branch https://git.koha-community.org/Koha-community/Koha.git src -> time out
07:57 cait1 ah ok
07:57 cait1 not sure about this one and can' test cloning myself right now
07:57 cait1 hm i can do a git pull maybe
07:58 cait1 that appears to work
07:58 lds cait1: is POST git-upload-pack (177 bytes)
07:58 lds cait1: cloning is blocked on : POST git-upload-pack (177 bytes)
07:59 cait1 might have to wait for Joubu then
07:59 cait1 hi Oak :)
08:00 Oak Hello cait1 !
08:20 lds Joubu: hello, in the place ?
08:20 liliputech_asu yes lds, this is the error i had with bywater sandbox
08:42 lds strange i cant clone the full depot but not branches
08:53 Joubu lds: around?
08:54 ashimema bug 7376
08:54 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 major, P5 - low, ---, lari.taskula, Needs Signoff , Transfer limits should be checked at check-in
08:58 lds Joubu: im here
08:58 lds Joubu: je peux pas cloner git clone --branch 19.11.x --single-branch https://git.koha-community.org/Koha-community/Koha.git src -> time out
09:10 * ashimema reads the code for bug 7376 and isn't sure about it.
09:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 major, P5 - low, ---, lari.taskula, Needs Signoff , Transfer limits should be checked at check-in
09:44 liliputech_asu ashimema: yup?
09:45 liliputech_asu about bz7376 ?
10:03 ashimema it's to prevent the 'acceptance' of a transfer right..
10:03 ashimema not to check that an item would get caught at a destination and not able to be transfered back home/holding
10:05 ashimema I find it a bit confusing that 'to_branch' changes
10:06 ashimema humm..
10:06 ashimema maybe it just clicked for me
10:06 liliputech_asu ashimema, this is to "not" allow return to a location where transfer won't allow the item to return to homelib
10:07 ashimema I think I get it now
10:08 ashimema I was thinking of it as "Can't be returned here as it could never be transferred back due to the limits"
10:08 ashimema it's the side of the equation
10:08 ashimema "Can't be returned here as you're not allowed for transfer to here"
10:09 ashimema Can you add some text to the release notes box?
10:10 liliputech_asu Can't be returned here as it could never be transferred back due to the limits -> this is it
10:11 ashimema humm..
10:11 ashimema the code reads the other way around
10:12 cait1 waht would be the other way?
10:13 ashimema i.e. do we prevent accepting the transfer because the rule says 'A -> B is not allowed' and you're checking into B... or do we prevent accepting the item because the rule says 'B -> A is not allowed' and we're checking into B...
10:13 ashimema in the first case we're checking the 'forward' transfer...
10:13 ashimema in the second we're checking the 'return' transfer
10:13 liliputech_asu 2secs
10:14 ashimema haha.. it's complicated aye ;)
10:14 ashimema I think the code there is doing the first option above. (as we're always assuming 'From' is holding branch.
10:17 cait1 i believe what asu wrote, made sense
10:17 cait1 if you let them return it at a branch that has no way to send it home, that's the problem
10:18 cait1 we are sending home/forward, right?
10:18 ashimema indeed.. but the code reads as the reverse as far as I can tell
10:18 cait1 so... don#t let it return at a branch it couldn't be sent to?
10:18 ashimema yeah
10:18 ashimema pretty sure that's how it's working
10:19 cait1 ok, i vote for the first behaviour :)
10:20 ashimema which is..
10:20 ashimema 1. 'A -> B is not allowed' and you're checking into B
10:20 ashimema 2. 'B -> A is not allowed' and we're checking into B
10:24 cait1 you mean which to prevent?
10:24 ashimema yup
10:24 cait1 1 is incomplete
10:24 cait1 i don't know from the example if B-> A is allowed
10:24 liliputech_asu itemhomebranch is to be considered
10:25 cait1 waht about another hold
10:25 cait1 hm guess it just has to go home first
10:25 cait1 Allow checking if transfer from there to the homebranch is allowed
10:25 cait1 checkin-library -> homebranch_library / hold_destnation_library(*) shoudl be allowed?
10:27 liliputech_asu ok, available now (sry, visio)
10:28 liliputech_asu so, the behavior of the patch is supposed to be the following :
10:29 liliputech_asu A -> B is not allowed and itemhomebranch is B, checking to A shall not be possible (that makes sense right?)
10:30 liliputech_asu A -> B is not allowed and itemhomebranch is A, checking to A is allowed (no need to transfer to B)
10:30 liliputech_asu A -> B is not allowed and itemhomebranch is B, checking to B is ok
10:32 ashimema I think those statements make sense
10:32 liliputech_asu you shall not be able to checkin an item to a library which cannot transfer back to the home library (that's how i understood the problem at least, may be wrong)
10:32 ashimema so yeah.. I think that makes sense
10:32 liliputech_asu ashimema u'r testing it? thanks alot! :D
10:34 liliputech_asu ashimema: i did wrote a bunch of unit tests to prove those statements, but if I have error in my tests then... ~(@_@)~
10:34 ashimema but the code currently does 'can holdingbranch (prior to being updated by return) transfer to 'this branch'/'holdingbranch'/'homebranch'
10:34 ashimema I'll re-read the unit test :)
10:34 liliputech_asu hum...
10:34 liliputech_asu yes please ^^
10:35 liliputech_asu with cherry *and chocolate flakes* on top
10:36 ashimema :w
10:36 liliputech_asu rereading as well
10:37 liliputech_asu in the test, homebranch and holdingbranch are same-same
10:37 ashimema I think we need three branches in the test
10:37 ashimema to test all scenarious
10:37 ashimema * to test all scenarios
10:38 ashimema I'll work on a unit test followup :)
10:38 liliputech_asu oooh, great :)
10:38 ashimema it'll help me wrap my head around it whilst testing :)
10:38 * liliputech_asu starts to scrap chocolate tabs
10:40 liliputech_asu huuum, not "scrap" but "something" (chocolate tab to flakes, missing english vocabulary)
10:40 liliputech_asu maybe "shred" ?
10:41 cait1 hm i think checking holdingbranch is wrong
10:41 cait1 you need to check the checkin library
10:41 cait1 depending on where in the workflow you are - the holdinglibrary might not be the one they return it to
10:41 cait1 in a consortia
10:41 cait1 they could have checked out at b but return to c
10:42 cait1 i am not sure when the holdingbranch is updated -but i believe as we are about to deny checkin, we are before the update
10:42 liliputech_asu cait1: yup, in the tests i wrote, the checking branch is checked
10:42 liliputech_asu is ( $homebranch->{branchcode} , $message , 'With transfer limits asks return to homebranch');
10:42 liliputech_asu is ( 0 , $allowed , 'With transfer limits cannot return to otherbranch');
10:42 cait1 ok, just wanted to make sure :)
10:43 cait1 transfers are terrible
10:43 liliputech_asu it doesn't check transfer limit to holdingbranch though i think (not sure)
10:43 liliputech_asu but, maybe thats another issue? ;)
10:46 liliputech_asu the tests only try checkin to a branch other than homebranch, then check checkin can occur depending on transfer rules *from* "otherbranch" *to* "homebranch"
10:46 liliputech_asu "check checkin" -> brrrrr...brrrrraiiiinnnzzz...
10:48 liliputech_asu tests checks in both allowed and forbidden transfer conditions.
11:10 oleonard Hi all
11:11 Oak Hi Owen
11:47 ashimema liliputech_asu : I've added a followup with extensions to the tests to cover more combinations...
11:47 ashimema take a careful look at the NOTE lines.. I'm really not sure this does what is intended
11:47 ashimema as far as I can tell.. it only blocks one additional action..
11:48 ashimema a return where there's a transfer block from the holdingbranch prior to the return to the current return branch
11:48 ashimema cait1.. would appreciate you're input on the test too.. I have a feeling I've still missed some cases.
11:50 ashimema I "think" what you're really trying to cover/catch in a harder case is the code found in the block between lines 2239 and 2254 in Circulation.pm#
11:54 cait1 morning oleonard
11:54 cait1 got a moment?
11:54 oleonard Yes
11:55 cait1 for bug 25777 :)
11:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 minor, P5 - low, ---, dcook, Signed Off , Datatables on z3950_search.pl show incorrect number of entries
11:55 cait1 sometimes i just use FQA if i have questions - there is no "need feedback"
11:56 cait1 I am ok with the explanation they both work - just in the diff of all patches both files show up, so it was a bit confusing
11:56 oleonard I understand. And I worry that if I don't change the status back to "signed off" it won't get back on your radar when I think I've answered your question.
11:57 oleonard If that happens and I *haven't* answered your question, don't hesitate to put it back to FQA!
11:57 cait1 you can totally change it back
11:58 cait1 i expect you to :) and usually i catch those at some points reading bug mail... but sometiems i need a bit longer to catch up
12:01 cait1 hope I didn't fail too many other things... i feel like I had a bit of a fail run going on
12:02 liliputech_asu ashimema: time to go lunch, will check this out when back
12:02 ashimema no worries
12:05 oleonard cait1: Maybe some folks are discouraged by FQA but not me, especially not yours because you're always clear and reasonable with your explanation
12:05 oleonard cait1++
12:05 oleonard QA++
12:18 ashimema :)
12:19 ashimema dang cait.. did you have to wipe the floor with me so much in the leader board ;)
12:57 cait1 oleonard: thx, I try - and hope people know they can talk to me if they feel I was unreasonable:)
12:57 cait1 oleonard++
13:59 huginn News from kohagit: Bug 27581: DBRev 20.12.00.009 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3439d04e1ea9e4232a87a5d10509e763e113aad4>
13:59 huginn News from kohagit: Bug 27628: Compiled CSS <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9cbcbc3120ec32d79660771c268f4ed299f3488>
13:59 huginn News from kohagit: Bug 27581: Fix missing occurrences in tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8924206c914154957647bf28e862ed8c8662a677>
13:59 huginn News from kohagit: Bug 27604: Init to {} <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4784b8ffe52b78a1a0a7fe168b9ffc27657d0196>
13:59 huginn News from kohagit: Bug 27581: (QA follow-up) Fix occurence in it-IT custom.sql <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3431ddedc71ffecd870cbc138a864c01c25cd8ed>
13:59 huginn News from kohagit: Bug 27604: (QA follow-up) Limit the libraries during the query <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=60a749ff5a6ab1e7bbbcc28d7db69bdca51b2eed>
13:59 huginn News from kohagit: Bug 27633: (bug 15436 follow-up) Fix duplicate of 440$v at the OPAC <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b3c58aafcf249efdfe91b00d4da9c66472c4a141>
13:59 huginn News from kohagit: Bug 27289: (follow-up) Update payment type too. <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4904abf1c323c6d1c4d41108e3e2eb283f008676>
13:59 huginn News from kohagit: Bug 27154: Remove Koha::Util::SystemPreferences <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ac11405321ae3e5fdd72701ddb41b62675e42c97>
13:59 huginn News from kohagit: Bug 27628: Fix minor HTML markup errors in OPAC search results templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=15c3be55afbcff1d5f149f53273bfb25009582a7>
13:59 huginn News from kohagit: Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bb692e83ea97a32eb16eb1b1336a67f41c66d0de>
13:59 huginn News from kohagit: Bug 27604: Make sure PatronSelfRegistrationLibraryList is used <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=376bf9b980b877a38acc6680445ad5aa0078620c>
13:59 huginn News from kohagit: Bug 27454: Pass the arrayref <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e9195d166e8175044f6f76ff24ecc9399cf0abbe>
13:59 huginn News from kohagit: Bug 27581: Rename USeICU preference to UseICUStyleQuotes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c8f1fad8f2b1881af3da269871a9b3aae54ba52f>
13:59 huginn News from kohagit: Bug 27563: Remove check-url.pl in favor of check-url-quick.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3feade167f2713e3dc3e47fda35b423443af9f07>
13:59 huginn News from kohagit: Bug 27398: Made values in number patterns subscription length translatable <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9df4daab1f780f14fed1fba9f4afad8c4c73d30>
13:59 huginn News from kohagit: Bug 27454: Add sorting of patron attributes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0821a5890d98d17b58ffecaebbb02d673a864714>
13:59 huginn News from kohagit: Bug 27290: Clean up validation <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=01fc41ca593ee030a77c2462acda0dc59dfe7ec0>
13:59 huginn News from kohagit: Bug 27289: Template tweaks for point of sale page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f27e91f1ad4a0048e360e67e6bd0c6723a981577>
13:59 huginn News from kohagit: Bug 25632: Update MARC21 frameworks to update Nr. 30 (May 2020) <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f259298fd4f7b20ccd458af923e6d57a87df32dd>
14:11 liliputech_asu ashimema thanks for all the new tests cases :)
14:16 ashimema no worries
14:16 ashimema in the end.. I think the code works as described by Paul way back when
14:16 ashimema the challenge is working out if that's how it should work..
14:17 ashimema I think perhaps a followup bug needs adding if people want to prevent 'return to a branch where the item can't be transfers back to homebranch/holdingbranch'
14:19 cait1 ashimema: i read Paul's differently than you
14:19 cait1 i tmatches for me what we said earlier
14:19 cait1 i commented taking it apart a bit
14:20 liliputech_asu uhhh... anyway, the tests are all green (good point) and... one question (maybe stupid but...) are transfer_rules bidirectionnal or can it be assymetric?
14:21 ashimema single direction
14:21 cait1 i believe it depends
14:21 liliputech_asu omg.
14:22 ashimema they have 'from' and 'to'
14:22 cait1 branch transfer rules are defined one direction
14:22 ashimema thus.. the rules are single direction
14:22 cait1 branch transfer matrix counts in both directions i believe
14:22 ashimema the tests are green.. but read the notes
14:22 ashimema I don't know that they're proving the right thing
14:22 ashimema oh really...
14:22 ashimema so if you add to the transfer matrix.. does it add a rule for each direction?
14:22 ashimema if it does then the tests are completely wrong
14:23 ashimema we're only adding one rule at a time.. if we actually add a rule in each direction then the patch does work.. but more inadvertently than by design as far as I can tell
14:23 cait1 the transfer COST matrix has only one field in a matrix i believe
14:23 cait1 so it is the same cost to and from i guess?
14:24 cait1 while the transfer rules seem to have a from and to, as you define them for each library
14:27 ashimema I think this patch ONLY looks at the limits and not the costs.
14:28 liliputech_asu ashimema: finished reading the notes, indeed, for "this is the only change introduced by bz7376" for me this is also what the whole bz is about. and yes, doesn't look after costs, only limits
14:29 ashimema So...
14:29 liliputech_asu it "justs" prevent checking in an item to a library different from home or holding branch, which doesn't allow transfer back to home or holding branch.
14:29 cait1 it maeks sense
14:29 cait1 the costs didn't exist then
14:29 cait1 the patch is old stuff
14:29 liliputech_asu \o/
14:29 ashimema wrong
14:29 ashimema 'transfer back to'
14:29 ashimema it is NOT preventing that
14:30 liliputech_asu owhf
14:30 cait1 i'll let the 2 of you sort hat
14:30 cait1 maybe you need to get out the code review tools
14:30 ashimema hehe
14:31 ashimema see 'Should we prevent return here...'
14:31 ashimema is that not the exact feature you're looking for
14:31 ashimema which the test proves it's not doing?
14:31 liliputech_asu huuum. you're right ashimema, we "should prevent" here. hence tested returnvalue shall be 0
14:31 ashimema maybe I should have written the test to fail to make it more clear
14:32 ashimema exactly..
14:32 ashimema I wrote the tests to pass.. we should now adapt them to test for exactly what result we want
14:32 ashimema problem is.. I don't think we can actually do it at this level
14:32 ashimema we'd need to reverse the can_be_transferred logic..
14:33 ashimema i.e pass a 'frombranch' or THIS branch.. and a tobranch of 'holdingbranch' OR 'homebranch' (depending on the relevent pref)
14:33 liliputech_asu huuum exactly
14:34 ashimema i.e.
14:34 ashimema we'll need to pass the param from this line in : https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Circulation.pm#L1982
14:35 ashimema what really surprises me though...
14:36 ashimema I think that's pretty much what this line does: https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Circulation.pm#L2244
14:36 ashimema only.. it's AFTER the return has actually happened.. I think
14:36 liliputech_asu wait a min, if transfer not allowed from returnbranch to home, but allowed to holding, shall we accept the checkin? i don't think this case is tested?
14:36 ashimema it may well not be..
14:36 ashimema my brain was hurting writing those tests..
14:37 liliputech_asu haha
14:37 ashimema there are lots of combinations :|
14:37 liliputech_asu indeed...
14:38 liliputech_asu why do you put discard_change after all your "store"?
14:38 liliputech_asu (curiosity) -> does it have anything to do with the ORM and database mock?
14:39 ashimema I don't think it's actually needed in this case
14:39 ashimema just habbit
14:39 liliputech_asu okay
14:41 liliputech_asu huuuum so then, correct me if i'm wrong, when you set a second transfer limit from return to holding (after setting a first one from return to home) then, both limits applies right?
14:42 ashimema in the tests I wrote?
14:42 ashimema I don't add.. I update
14:42 ashimema so.. we only add the one rule in the test.. then update it to the various different single rules we're testing
14:43 ashimema I suppose I could have added all the rules at once.. but I have a feeling that would have broken my brain even more
14:44 liliputech_asu haha, yes indeed... okay, i'll try to fix it (damn you've been so fast adding those tests! can't compete :)
14:45 ashimema haha
14:45 ashimema no worries
14:45 ashimema sorry for being a pain
14:45 ashimema these things are super complicated.. suppose that's why I ended up on QA.. haha
14:45 ashimema Circulation.pm is a minefield
14:46 kohaputti Hi ashimema ! I'm back now so I will check the transfers patch series status :)
14:46 ashimema dude.. welcome back
14:46 ashimema hope you had a restful break :)
14:48 cait1 kohaputti: your ears must have been ringing :)
14:48 cait1 welcome back
14:49 kohaputti thanks
14:57 * ashimema is really looking forward to whenever the next hackfest can take place.. I'm missing the in-person dev contact
14:58 * liliputech_asu too
14:58 cait1 yea :(
15:01 * liliputech_asu missing the mexican taco
15:02 cait1 omg yes.
15:02 cait1 we got to have a 2 wek hackfest to make up for the missed ones
15:02 liliputech_asu beer and munchies <3
15:03 ashimema hell yes.. 2 week hackfest
15:03 liliputech_asu (did I forgot to mention wonderful people?)
15:03 ashimema though.. not sure my liver could cope with it..
15:03 ashimema and not sure I'd get signoff from the other half.. haha
15:04 ashimema hehe
15:05 liliputech_asu haha, definitely hard on the liver... but stomach pain from not releasing stress is probably no better :)
15:13 cait1 you just have to stop drinking...
15:13 * cait1 doesn't understand the issue
15:14 ashimema but there are soo many good beers to be drunk
15:15 ashimema much like there's so much good food to be eaten
15:16 liliputech_asu yup, most of them are not as enjoyable when it's not shared though (at least for me)
15:16 ashimema agreed
15:18 lukeG1 good morning!
15:19 liliputech_asu morning lukeG1 :) may the force be with you.
15:21 fridolin Bug 27657 need your opinion
15:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27657 enhancement, P5 - low, ---, fridolin.somers, NEW , Item search uses items.itype even when item type is on biblio level
15:22 kohaputti ashimema, FAIL Koha/Exceptions/Item/Transfer.pm – FAIL pod coverage
15:22 fridolin hackfest was so good to practice Anglish
15:22 ashimema dang
15:23 fridolin ou Frençais
15:23 fridolin ^^
15:23 oleonard fridolin: Should we hide the item type limiter if item types are on biblio level?
15:23 kohaputti ashimema, other than that I'm ready to sign-off
15:23 ashimema awesome
15:23 * ashimema runs QA tools to check where that failure presents
15:24 ashimema I thought I'd already dealt with it..
15:24 ashimema looking now anyway
15:26 kohaputti ashimema, if you push fix please keep the two patches from bug 22569 still on top so I can ignore those
15:26 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 new feature, P5 - low, ---, martin.renvoize, BLOCKED , Add a 'Transfers to send' report
15:27 * kohaputti is unsure how the POD coverage QA tool check works
15:28 ashimema sometimes it spits out false failures.. it's not good at spotting when a method has been removed
15:28 ashimema but.. in this case that sounds a tad unlikely.
15:28 ashimema will do
15:30 Joubu it also fails when a new module is added iirc
15:30 fridolin oleonard: its the simplest fix
15:31 fridolin or a complex if then in SQL query (it exists in other places)
15:31 kohaputti ashimema, the error is:
15:31 kohaputti $ perl -MPod::Coverage=Koha::Exceptions::Item::Transfer -e666
15:31 kohaputti Koha::Exceptions::Item::Transfer has a Pod::Coverage rating of 0
15:31 kohaputti 'description' is uncovered
15:34 ashimema I think it's a false one..
15:35 ashimema it's a method that's inherited from the base class
15:35 ashimema not entirely sure why it's caught?
15:35 ashimema any idea's Joubu
15:35 ashimema just running the QA tools over the whole set again.. it found a spelling mistake too!
15:36 kohaputti the tree where this issue happens is https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 for those wondering
15:36 ashimema will push when I get back from a quick walk round the block
15:37 kohaputti ashimema, hmm, I wonder if it could be because we import Koha::Exceptions::Exception but I don't think it is used anywhere
15:38 ashimema Ah, could be
15:38 ashimema Must admit the exceptions system is a bit confusing to me
15:45 Joubu ashimema: which patch?
16:07 kohaputti ashimema, removing Koha::Exceptions::Exception didn't help
16:10 huginn News from kohagit: Bug 27005: Compiled CSS <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=66bd88a6e621cdf26e81734d7985a00a322b1e06>
16:10 huginn News from kohagit: Bug 23763: (QA follow-up) Add +x to Search.t file permissions <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0751f9b0c9aedf4fd0c35f87895c19a567602e24>
16:10 huginn News from kohagit: Bug 27643: Add CodeMirror custom syntax highlighting for SQL runtime parameters <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=58cc70a0cbc5721cdac79954faedf90c4214996c>
16:10 huginn News from kohagit: Bug 27618: Don't show dropdown if PatronSelfRegistrationLibraryList only has one... <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fecb9a11fc44f9d1c8bb9be37ad532c7b2ad710a>
16:10 huginn News from kohagit: Bug 27422: YouTube videos are HTTPS only <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ca5efc9aa45c3c7893a09cf0067718fdaab63507>
16:10 huginn News from kohagit: Bug 27587: Use Basic auth on API tests - stockrotationstage.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e6b5483503e7feb0afc6ef526a675bde767dd8e>
16:10 huginn News from kohagit: Bug 27587: Use Basic auth on API tests - illrequests.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=368104ec267fbd6558ffe82ede1f28153768b951>
16:10 huginn News from kohagit: Bug 27587: Use Basic auth on API tests - acquisitions_vendors.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=50ae6e371f90a506905aada052abd0300b4dc743>
16:10 huginn News from kohagit: Bug 27587: Use Basic auth on API tests - patrons_password.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9bcc8596177a01fd583604423965f844bcc0bb8a>
16:10 huginn News from kohagit: Bug 27587: Use Basic auth on API tests - patrons_accounts.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=db2c902f28acea5f5adc9ff77f08348da10fd6d4>
16:10 huginn News from kohagit: Bug 27005: (follow-up) Add missing aria-hidden attributes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9d32423311a9531ae46fe7bd17009cfc3fd4c043>
16:10 huginn News from kohagit: Bug 23830: Adapt callers <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ba5eff837b9d6d004ada5d7289c2c1b7b07ce544>
16:10 huginn News from kohagit: Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f24b281057fd6a52e59da3ff5136a5aee88b5acb>
16:10 huginn News from kohagit: Bug 26708: Add SQL popup when hovering over name of report <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d3323881d508d17d5fcfd9e134281c0778a6590f>
16:10 huginn News from kohagit: Bug 27005: (follow-up) Exclude links column from sort and export <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0214cabf514e05786c2e7c03ce7cc5d3ff5c1042>
16:10 huginn News from kohagit: Bug 27005: (follow-up) Enable the exclusion of columns from export <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ecd26e4bb926315b4b49709fde6a62ce3804bf5>
16:10 huginn News from kohagit: Bug 27050: Allow multiple category_codes in delete_patrons.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8fbfa9da187341d892f230b30ff1d5cf85357293>
16:10 huginn News from kohagit: Bug 27005: Adding a filter in the datatable of opac-readingrecord page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ebc20ffef41a62ef31f0be5e5f16cea68ed0107f>
16:10 huginn News from kohagit: Bug 23763: Make search on staff and opac use new routine <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=832aa322a822ed3be5d2a2f0b8e3f4f65f4bc32a>
16:10 huginn News from kohagit: Bug 23763: Create a pagination_bar routine <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=98e778335015dc822bdd8a053d1c45d9b8eb7b3f>
16:12 kohaputti ashimema, looks like time for another rebase. I will check the progress tomorrow, see you! :)
16:21 Joubu mtj, tcohen: all nodes are offline
16:21 ashimema lol.. nice to see master moving :)
16:27 Joubu mtj, tcohen: it's the connection between the nodes and jenkins actually. Restarting jenkins to see if it fixes the problem
16:28 koha-jenkins Project Koha_Master_D9_My8 build #499: FAILURE in 47 sec: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/499/
16:38 cait1 bye all!
16:55 koha-jenkins Project Koha_Master_D9 build #1553: FAILURE in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1553/
18:09 koha-jenkins Project Koha_20.11_U20 build #36: FAILURE in 8 min 20 sec: https://jenkins.koha-community.org/job/Koha_20.11_U20/36/
18:15 reiveune bye
18:41 koha-jenkins Project Koha_20.11_D10 build #52: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/52/
18:42 koha-jenkins Project Koha_20.11_U2010 build #36: UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_20.11_U2010/36/
18:47 koha-jenkins Project Koha_Master_D9_My8 build #500: STILL FAILING in 4 min 48 sec: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/500/
18:50 koha-jenkins Project Koha_20.11_U18 build #35: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/35/
18:54 koha-jenkins Project Koha_Master_D9 build #1554: STILL FAILING in 7 min 6 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/1554/
19:08 koha-jenkins Project Koha_20.11_D9 build #46: SUCCESS in 1 hr 29 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/46/
19:21 koha-jenkins Project Koha_20.11_U16 build #39: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/39/
19:28 koha-jenkins Yippee, build fixed!
19:28 wahanui Congratulations!
19:28 koha-jenkins Project Koha_20.11_U20 build #37: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/37/
20:05 koha-jenkins Project Koha_20.11_D9 build #47: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/47/
20:48 koha-jenkins Project Koha_20.05_U16 build #224: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/224/
20:54 koha-jenkins Yippee, build fixed!
20:54 wahanui Congratulations!
20:54 koha-jenkins Project Koha_20.05_D9 build #221: FIXED in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/221/
21:03 koha-jenkins Project Koha_20.05_U20 build #252: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/252/
21:07 koha-jenkins Project Koha_20.05_U18 build #87: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/87/
21:19 koha-jenkins Project Koha_20.05_U2010 build #119: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/119/
21:20 koha-jenkins Project Koha_20.05_D10 build #223: SUCCESS in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/223/
21:36 koha-jenkins Project Koha_20.05_U16 build #225: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/225/
21:53 koha-jenkins Project Koha_20.05_D9 build #222: UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/222/
22:01 koha-jenkins Project Koha_20.05_U18 build #88: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/88/
22:01 koha-jenkins Yippee, build fixed!
22:01 wahanui Congratulations!
22:01 koha-jenkins Project Koha_20.05_U20 build #253: FIXED in 53 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/253/
22:22 koha-jenkins Project Koha_20.05_D10 build #224: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/224/
22:41 koha-jenkins Project Koha_20.05_U20 build #254: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/254/
22:54 koha-jenkins Project Koha_20.05_U18 build #89: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/89/