Time Nick Message 00:45 rangi @later tell joubu PR merged and schema updated 00:45 huginn rangi: The operation succeeded. 07:33 reiveune hello 07:51 alex_a_ Bonjour 07:51 wahanui hola, alex_a_ 08:10 fridolin hi 08:10 wahanui privet, fridolin 08:10 fridolin wahanui: coffee please 08:10 wahanui fridolin: wish i knew 08:11 fridolin wahanui: find me a gift 08:11 wahanui fridolin: huh? 08:11 fridolin wahanui: sleep well 08:11 wahanui fridolin: i'm not following you... 09:20 ashimema mornin' 09:24 huginn News from kohagit: Bug 27205: Improve logic readability in conditional <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=85c25260853aa1c8003b0a041dba2772cd2f316b> 09:24 huginn News from kohagit: Bug 27205: Check valid pickup location on POST /holds <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c913bd7d698a8fbc9992f93db426a35c79f330c7> 09:24 huginn News from kohagit: Bug 27209: (follow-up) Add ->is_pickup_location_valid <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=865a1dab5c346920c61237c4b7593202328e04f8> 09:24 huginn News from kohagit: Bug 27205: Check valid pickup location on PUT /holds/:hold_id <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1bfe7ea16ef1346585211345ba89d18e303a0c32> 09:24 huginn News from kohagit: Bug 27209: Add Koha::Hold->set_pickup_location <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=672413ea294679d4b5b30d30839650f6d30b45ca> 09:24 huginn News from kohagit: Bug 27209: Unit tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=295787223e4dbbe116cba20119db05da4992e0b1> 09:24 huginn News from kohagit: Bug 27124: JS error "select2Width is not defined" <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ff7318c62ec7097c5b88f7278b71d0cc7feb1f39> 09:24 huginn News from kohagit: Bug 27127: Make Koha::BackgroundJob->messages return a scalar <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c5efece0dc8db3a1438bab40afbcaa7f164f2f75> 09:24 huginn News from kohagit: Bug 27117: Only place_holds permission is needed to adjust pickup locations <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=69c01ee0f2dccd04cfbe8201ba580a15727f5280> 09:24 huginn News from kohagit: Bug 26634: Remove GetHoldRule subroutine in C4::Reserves <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=de4d6983ab614f56d0514ff4060543da69b2b651> 09:24 huginn News from kohagit: Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1ea55acd0c997b96039a2a1a4a9f9941d2558bda> 09:24 huginn News from kohagit: Bug 26941: Fix OPAC password recovery error messages <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=470c7606695bff93a6c6f4491227bfb6705c21e8> 09:24 huginn News from kohagit: Bug 26849: Fix Array::Utils dependency in cpanfile <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a43fcaf1416057905c277951fb2b0bff13977d33> 09:24 huginn News from kohagit: Bug 24519: Match paycollect form validation for change collection <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=080288bce48cf4fa94b19d35a117dd3e1967a4c9> 09:24 huginn News from kohagit: Bug 14564: Set permissions on configuration backups <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6982680ae9e71d5d038e894842125860fcc986d6> 09:25 ashimema nice 10:02 magnuse \o/ 10:51 tcohen morning 11:20 domm hey, another BackgroundJob question: I run `koha-worker --start foo`, and later try to enque a job. But: Error connecting to localhost:61613: Connection refused at /usr/share/perl5/Net/Stomp.pm line 26. 11:21 domm what should be listing on 61613? 11:21 domm or rather, how do I start it? 11:21 Joubu rabbitmq 11:21 wahanui rabbitmq is probably big, in the sense that it takes care of keeping track of those messages, if they reached destination, need retry, etc 11:21 Joubu how did you install? 11:21 domm ok, I though I don't need rabbitmq and use the DB instead? 11:22 domm debian koha 22.11 main into a docker contaner 11:22 domm but I did nothing regarding rabbitMQ 11:23 Joubu you don't need the worker 11:23 domm and I'm now not sure id we need, or if we can use DB-polling instead 11:23 Joubu it's when the message is enqueued that we will default to the DB 11:23 Joubu If you want to play with the task queue I'd recommend you to setup rabbitmq 11:23 Joubu it's pretty trivial 11:24 domm ah, yes, the job is in the DB 11:24 oleonard Hi #koha 11:24 domm Joubu: ok 11:24 Joubu domm: apt install rabbitmq-server; rabbitmq-plugins enable rabbitmq_stomp; 11:24 Joubu then restart rabbitmq-server 11:24 domm thx 11:24 Joubu and maybe restart the koha-worker 11:25 domm are there any docs on the BackgroundJob architecture? 11:25 Joubu s/maybe/certainly 11:25 Joubu Outside of bug 22417, I don't think so 11:25 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 new feature, P5 - low, ---, jonathan.druart, Pushed to master , Add a task queue 11:26 Joubu but let me know if you have any questions 11:27 domm ok, I've rea/skimmed 22417, but of couse it's a bit hard to extract the current state from all the discussions :-) 11:27 domm I will :-) 11:27 Joubu basically it's: the pl controller will enqueue using Koha::BackgroundJob->connect->enqueue 11:28 Joubu the koha-worker will receive the frame and run the job 11:28 Joubu there is a DB table (background_jobs) to track down the job list 11:29 Joubu and a UI view based on this DB table, to see what's has been executed, what is currently being execute, what failed, etc. 11:29 Joubu and you have access to a "report" to see how things went 11:29 Joubu the UI is at /cgi-bin/koha/admin/background_jobs.pl 11:30 domm and koha-worker is also involved? 11:30 Joubu koha-worker is receiving the frame, it's "after rabbitmq" 11:31 domm ok, that was what I assumed 11:31 Joubu the koha-worker is connected to rabbitmq and listen (while 1) 11:31 Joubu when a new job is ready (to be "consumed"), then it's processed 11:43 domm /cgi-bin/koha/admin/background_jobs.pl yields /en/modules/admin/background_jobs.tt: not found 11:43 domm (and it's not in the Admin menu, is it?) 11:44 domm oh, and can I see STDERR/STDOUT of the worker? 11:44 domm ah, found worker-output.log 11:51 Joubu No, it's not (yet) in the admin menu. No real good reasons for that. 11:52 Joubu are you getting a '.tt not found' error when you hit admin/background_jobs.pl? 11:54 domm Joubu: yes: /en/modules/admin/background_jobs.tt: not found 11:55 domm and the template is not in my filesystem 11:55 cait hm 11:55 cait packages? 11:55 wahanui packages are done 11:55 domm I can see it in Koha git, but in the container where I installed Koha, it seems to be missing 11:56 cait i have an idea 11:56 cait it's probably missing from Makefile.pl again 11:56 cait hm or actually not 11:57 cait https://git.koha-community.org/Koha-community/Koha/src/branch/master/Makefile.PL admin/ should cover it i gues 12:04 oleonard If there is no special permission associated with viewing background jobs I suggest we move it from administration to tools. 12:07 tuxayo hi #koha :) 12:18 Joubu oleonard: the list of the jobs should be only accessible to librarian with the admin permissions 12:19 Joubu oleonard: the view of a given job can be accessible by the librarian who started it 12:22 oleonard Okay, so perhaps the background job view should check permissions before displaying the administration sidebar menu 12:25 oleonard Never mind, I guess it's all built into the menu already 12:35 oleonard ashimema around? 12:52 magnuse happy solstice, good people of #koha! 12:53 oleonard Hi magnuse! I'm very ready for longer days! 12:56 * Nemo_bis looks at 15.00 foggy night over the sea in Helsinki 12:57 magnuse oleonard: me too! 12:57 magnuse getting quite dark here now, almost 2pm 12:57 magnuse wow, the man-pages for the koha-* scripts look broken 12:59 ashimema Hi 13:02 oleonard ashimema I have a question about the register details page 13:02 ashimema fire away 13:03 oleonard I'm curious why the "older transactions" table is separate from the other table of transactions. Seems like you could offer the "older transactions" filter form but display the results in the "main" table. 13:04 ashimema good question 13:05 ashimema no real reason.. it's an old fashioned datatable, not api driven so I just limited the amount of data returned in one hit in the first place. 13:05 ashimema then we wanted to add the ability to fetch older transactions on demand.. so the second table was born 13:05 ashimema but there's not a strong reason to keep them distinct.. 13:05 ashimema the only think that might be useful.. would be to somehow mark the 'cashup' cutoff.. 13:06 oleonard I don't know the process well enough to evaluate that. 13:07 ashimema I suppose also.. if you were searching for an older transaction by date then limiting to a specific set might be helpfull... but with API driven datatables I don't think that would matter either 13:07 ashimema converting it to an ajax datatable would mean we can merge them easily I woudl say 13:08 oleonard Okay, just something to think about I guess 13:08 ashimema I like the ida 13:08 ashimema * I like the idea 13:09 * ashimema isn't sure how one would do ajax tables with the rowgrouping 13:09 ashimema would be interesting to see 13:10 ashimema I'd love to continue to refine this whole area.. but alas the funding has dried up for that area now.. so it's a labour of love at this point 13:26 magnuse is it possible to mix the "alligator syntax" <<>> and tt syntax in messages and slips? or must everything be tt if you use it anywhere in a message? 13:46 Joubu you can mix them 13:46 Joubu well, don't mix a TT loop with << some vars >> 13:46 Joubu you can have both, but don't mix them too much... 13:47 Joubu that's the short answer 13:57 magnuse perfect, thanks! 13:57 magnuse Joubu++ 14:06 ashimema is it just me.. or in 20.11 does leaving the opacnav and opacnavbottom prefs empty leave an empty block behind.. in prior versions the block went away entirely if those prefs were empty 14:06 ashimema or have i missed something 14:06 ashimema hmm. must have been some whitespace of something in one of the prefs.. managed to get them to go away now 14:07 Joubu on master, opacnavbottom empty and the element is in the DOM 14:08 ashimema I had to add a space in both prefs 14:08 ashimema then delete the space again in both prefs 14:08 ashimema to get it to actually empty 14:08 ashimema then the DOM element goes away for me 14:09 Joubu when both are empty yes 14:09 oleonard Probably empty code inserted by the WYSIWYG editor 15:27 tuxayo Does anyone know how to export like 100 records in a marc format? The cart doesn't offer the right formats. 15:28 oleonard tuxayo: The export tool accepts a list of biblionumbers 15:30 tuxayo oleonard++ Great I didn't know about that tool, that did it :D 15:39 oleonard Joubu should I be able to delete a quote during import preview? 15:51 Joubu no 15:51 Joubu oleonard: no longer 15:51 Joubu did I forget to remove the "delete" button? 15:52 oleonard No, but I remembered there being the ability before, and I thought no delete button appeared then either 15:52 oleonard I'm wondering why we can select a line if we can't do anything with it. 15:54 oleonard Joubu: Also I'm getting an error when trying to save a set of imported quotes 15:54 Joubu We shouldn't be able to select a line 15:54 Joubu you found a bug, congrats 15:54 Joubu :D 15:54 Joubu what error do you get? 15:55 oleonard Routing to controller "Koha::REST::V1::Auth" and action "under" Routing to controller "Koha::REST::V1::Quotes" and action "add" 500 Internal Server Error (0.021664s, 46.160/s) 15:56 Joubu something before that? 15:57 pastebot "oleonard" at 127.0.0.1 pasted "Errors shown by koha-plack-err when importing quotes" (126 lines) at http://paste.koha-community.org/26656 15:58 Joubu the api logs 15:58 Joubu try tail -f /var/log/koha/kohadev/*.log 15:59 Joubu /var/log/koha/kohadev/api-error.log 15:59 Joubu must be there 16:00 oleonard Couple of things: Column 'timestamp' cannot be null and Data too long for column 'source' 16:00 oleonard That probably means my database is out of date eh? 16:01 oleonard Hm, not according to updatedatabase 16:01 Joubu source is mediumtext 16:02 Joubu that's MEDIUMTEXT | 16,777,215 (224−1) bytes = 16 MiB :D 16:02 Joubu should be enough! 16:03 Joubu can you share your CSV file? 16:04 Joubu and "timestamp" is `timestamp` datetime DEFAULT NULL 16:04 Joubu shouldn't be a problem either 16:06 oleonard My quotes table doesn't have those settings. source = varchar(45) and timestamp is NOT NULL. 16:07 pastebot "tcohen" at 127.0.0.1 pasted "Joubu, kidclamp, ashimema" (62 lines) at http://paste.koha-community.org/26657 16:10 Joubu bug 24640 16:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, quotes.timestamp should default to NULL 16:11 kidclamp should we only filter_out_lost if hidelostitems is set? 16:11 Joubu - `source` varchar(45) DEFAULT NULL, 16:11 Joubu + `source` text DEFAULT NULL, 16:11 Joubu oleonard: this is coming from d42e35ef4970c46bf131eb0a0126c8559e89b58a w 16:11 Joubu from May 21 14:08:57 2012 16:11 Joubu you DB is... well yes... outdated :D 16:12 oleonard Bug 24640 16:12 oleonard ...? 16:12 oleonard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 16:12 huginn Bug 24640: normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, quotes.timestamp should default to NULL 16:13 oleonard Shouldn't that bug have put the change into updatedatabase? 16:14 oleonard And if a table change is in updatedatabase shouldn't it be added as a new update rather than changing an old update? 16:16 * oleonard back soon 16:17 Joubu 24640 added a 16:17 Joubu 24640 added a new DB rev 17:14 reiveune bye 17:55 pastebot "tcohen" at 127.0.0.1 pasted "Joubu, ashimema, kidclamp" (17 lines) at http://paste.koha-community.org/26659 18:41 oleonard secret agents are communicating with each other via pastes 21:19 tuxayo If someone using Koha testing docker wants to do an easy signoff (change config and run tests), then bug 27055 is for you ;) 21:19 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 major, P5 - low, ---, victor, Needs Signoff , Update Firefox version used in Selenium GUI tests