Time Nick Message
22:06 koha-jenkins Project Koha_20.05_U2010 build #5: STILL FAILING in 2 min 18 sec: https://jenkins.koha-community.org/job/Koha_20.05_U2010/5/
22:05 koha-jenkins Project Koha_20.05_U18 build #123: FAILURE in 1 min 21 sec: https://jenkins.koha-community.org/job/Koha_20.05_U18/123/
22:05 koha-jenkins Project Koha_20.05_U20 build #157: STILL FAILING in 2 min 9 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/157/
22:04 koha-jenkins Project Koha_20.05_D9 build #123: STILL FAILING in 2 min 47 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9/123/
22:04 koha-jenkins Project Koha_20.05_U18 build #122: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/122/
22:03 koha-jenkins Project Koha_20.05_D10 build #117: STILL FAILING in 2 min 25 sec: https://jenkins.koha-community.org/job/Koha_20.05_D10/117/
22:01 koha-jenkins Project Koha_20.05_D9_My8 build #120: STILL FAILING in 2 min 25 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/120/
22:01 koha-jenkins Project Koha_20.05_D11 build #63: STILL FAILING in 2 min 47 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/63/
22:01 koha-jenkins Project Koha_20.05_U16 build #118: FAILURE in 2 min 1 sec: https://jenkins.koha-community.org/job/Koha_20.05_U16/118/
21:59 koha-jenkins Project Koha_20.05_D9 build #122: FAILURE in 2 min 35 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9/122/
21:59 koha-jenkins Project Koha_20.05_U20 build #156: STILL FAILING in 3 min 11 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/156/
21:58 koha-jenkins Project Koha_20.05_U2010 build #4: FAILURE in 2 min 32 sec: https://jenkins.koha-community.org/job/Koha_20.05_U2010/4/
21:56 koha-jenkins Project Koha_20.05_U16 build #117: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/117/
21:55 koha-jenkins Project Koha_20.05_D10 build #116: FAILURE in 2 min 36 sec: https://jenkins.koha-community.org/job/Koha_20.05_D10/116/
21:55 koha-jenkins Project Koha_20.05_D9_My8 build #119: FAILURE in 3 min 8 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/119/
21:53 koha-jenkins Project Koha_20.05_D11 build #62: FAILURE in 2 min 46 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/62/
21:52 koha-jenkins Project Koha_20.05_D9 build #121: FIXED in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/121/
21:52 wahanui Congratulations!
21:52 koha-jenkins Yippee, build fixed!
21:50 koha-jenkins Project Koha_20.05_U2010 build #3: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/3/
21:17 koha-jenkins Project Koha_20.05_U20 build #155: FAILURE in 1 min 12 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/155/
21:16 koha-jenkins Project Koha_20.05_D9_My8 build #118: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/118/
21:09 koha-jenkins Project Koha_20.05_U18 build #121: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/121/
21:07 koha-jenkins Project Koha_20.05_D10 build #115: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/115/
21:01 koha-jenkins Project Koha_20.05_U20 build #154: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/154/
20:29 koha-jenkins Project Koha_20.05_U16 build #116: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/116/
20:29 koha-jenkins Project Koha_20.05_D9 build #120: FAILURE in 2 min 3 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9/120/
20:26 koha-jenkins Project Koha_20.05_U18 build #120: FIXED in 45 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/120/
20:26 wahanui Congratulations!
20:26 koha-jenkins Yippee, build fixed!
20:24 koha-jenkins Project Koha_20.05_D11 build #61: STILL UNSTABLE in 1 hr 31 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/61/
20:10 koha-jenkins Project Koha_20.05_D9 build #119: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/119/
19:49 koha-jenkins Project Koha_20.05_D9_My8 build #117: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/117/
19:40 koha-jenkins Project Koha_20.05_U20 build #153: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/153/
19:14 koha-jenkins Project Koha_20.05_U16 build #115: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/115/
19:06 koha-jenkins Project Koha_20.05_U18 build #119: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/119/
18:56 koha-jenkins Project Koha_20.05_D9 build #118: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/118/
18:52 koha-jenkins Project Koha_20.05_U2010 build #2: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/2/
18:52 wahanui Congratulations!
18:52 koha-jenkins Yippee, build fixed!
18:29 huginn tuxayo: The operation succeeded.
18:29 tuxayo @later tell khall nevermind, the sandbox issues look random
18:27 koha-jenkins Project Koha_20.05_D9_My8 build #116: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/116/
18:19 koha-jenkins Project Koha_20.05_U20 build #152: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/152/
18:19 wahanui Congratulations!
18:19 koha-jenkins Yippee, build fixed!
18:10 koha-jenkins Project Koha_20.05_U18 build #118: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/118/
18:09 koha-jenkins Project Koha_20.05_D10 build #114: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/114/
17:43 koha-jenkins Project Koha_20.05_U16 build #114: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/114/
17:28 koha-jenkins Project Koha_20.05_D9_My8 build #115: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/115/
17:25 koha-jenkins Project Koha_20.05_D9 build #117: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/117/
17:24 koha-jenkins Project Koha_20.05_D11 build #60: STILL UNSTABLE in 1 hr 33 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/60/
17:03 koha-jenkins Project Koha_Master_D10_Deps build #138: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/138/
17:03 wahanui Congratulations!
17:03 koha-jenkins Yippee, build fixed!
16:55 ashimema I'm clocking off I'm afraid
16:47 ashimema honestly.. I've not seen a decent request on the mailing list for a while to be honest.
16:47 ashimema I've seen a few people come on for 30s, complain about not having been added yet.. then dissapear
16:47 ashimema indeed
16:40 cait ashimema: Guest is no longer hereand not sure which entry that was meant to be?
16:40 cait caroline: don't translate it
16:40 koha-jenkins Project Koha_Master_U18 build #948: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_U18/948/
16:30 koha-jenkins Project Koha_20.05_U20 build #151: UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/151/
16:26 tuxayo (other than name reuse)
16:26 tuxayo ashimema that seems to be another issue for the PTFS-E ones :(
16:25 huginn tuxayo: The operation succeeded.
16:25 tuxayo @later tell khall sandbox: it seems using a past sandbox name makes a new sandbox break
16:19 koha-jenkins Project Koha_20.05_U18 build #117: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/117/
15:51 koha-jenkins Project Koha_20.05_U16 build #113: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/113/
15:51 koha-jenkins Project Koha_20.05_D9_My8 build #114: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/114/
15:40 koha-jenkins Project Koha_20.05_D9 build #116: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/116/
15:40 koha-jenkins Project Koha_Master_D10 build #407: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D10/407/
15:05 koha-jenkins Project Koha_Master_D9 build #1496: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1496/
15:01 koha-jenkins Project Koha_Master_U20 build #145: FIXED in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U20/145/
15:01 wahanui Congratulations!
15:01 koha-jenkins Yippee, build fixed!
15:00 caroline translation question... should this string be translated? Looks like code, but I'm not sure "%s %s [%% IF ( OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size > 0 and expanded_options ) or ( OpacAdvSearchOptions and OpacAdvSearchOptions.size > 0 and not expanded_options ) %%] "
14:58 koha-jenkins Project Koha_Master_D9_MDB_Latest build #442: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/442/
14:57 Joubu same, bye #koha!
14:56 tcohen bye @magnuse
14:56 magnuse have a nice weekend, #koha!
14:46 Joubu failure, even better
14:43 koha-jenkins Project Koha_Master_D10_Deps build #137: FAILURE in 1 min 39 sec: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/137/
14:43 Joubu aborted koha-jenkins?
14:43 ashimema ^
14:42 ashimema cait:
14:42 koha-jenkins Project Koha_Master_U18 build #947: ABORTED in 11 min: https://jenkins.koha-community.org/job/Koha_Master_U18/947/
14:42 Guest5744 Anyone online that can tell me why I haven't been able to get a response for being added to the paid services area of the website? Been trying to do this for over 4 months without a reply.
14:41 severine_q thanks ashimema for trying :) it was really kind of you
14:35 ashimema sorry severine_q
14:35 ashimema give it 1 minute then you should be able to
14:35 severine_q no worry, i think it's too late for that one anyway
14:34 ashimema I think
14:34 ashimema I've not enabled the line Joubu suggested yet to get ES up and running..
14:34 ashimema ah..
14:34 Guest5744 Anyone online that can tell me why I haven't been able to get a response for being added to the paid services area of the website? Been trying to do this for over 4 months without a reply.
14:33 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 normal, P5 - low, ---, koha-bugs, Needs Signoff , IncludeSeeFromInSearches not honoured in Elasticsearch
14:33 severine_q long enough for bug 25030 you think ?
14:33 severine_q great ashimema !!
14:32 ashimema the issue is a really odd one
14:32 ashimema not sure how long it will last
14:32 ashimema severine_q ours are back for a while
14:30 koha-jenkins Project Koha_Master_D9_My8 build #465: SUCCESS in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/465/
14:29 Guest5744 Anyone online that can tell me why I haven't been able to get a response for being added to the paid services area of the website? Been trying to do this for over 4 months without a reply.
14:27 severine_q thanks fridolin for trying, no emergency so don't worry :)
14:26 ashimema 30gb disk spare
14:26 ashimema only used 35%
14:26 ashimema nope
14:25 Joubu ashimema: df?
14:25 fridolin we have to work on this
14:24 fridolin arf ok no, its ES5
14:24 fridolin severine_q : https://wiki.koha-community.org/wiki/Sandboxes#BibLibre try sandbox 11
14:23 ashimema seems we're back to a temp directory failure
14:22 ashimema grr
14:19 severine_q ByWater's are KO too, any informations in the logs ? I'm definitely unable to read them :(
14:18 ashimema they just seem to magically stop working
14:18 ashimema not a clue
14:14 Joubu do you know what's the problem with sandboxes?
14:13 koha-jenkins Project Koha_Master_U2010 build #50: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/50/
14:13 ashimema but yes.. we should certainly enable that
14:13 koha-jenkins Project Koha_Master_D11 build #142: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D11/142/
14:13 ashimema issue for now is that the sandboxes keep falling over :(
14:12 ashimema :)
14:12 Joubu that will set ES by default
14:12 Joubu ashimema: http://paste.koha-community.org/26130
14:11 koha-jenkins Project Koha_Master_U16 build #129: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_Master_U16/129/
14:10 severine_q thanks Joubu ! I hope I'll have a bit of chance, I didn't see them working theses days :/
14:09 ashimema snadboxes need some work.. :(
14:09 ashimema pass
14:09 ashimema er..
14:08 Joubu maybe not, ashimema do you know if we have the ES env var set when the sandbox is building?
14:07 Joubu *should*
14:07 Joubu you can select unimarc, then if you switch the search engine syspref it should just work
14:07 Joubu severine_q: did you try http://sb1.sandboxes.bywatersolutions.com/create ?
14:06 severine_q fridolin again... any chance to see sandbox 11 with ES working ?
13:39 magnuse Joubu: yeah, that is true
13:26 huginn News from kohagit: Bug 26963: Don't call 'can_be_transferred' for each possible library for each item <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=780ced27f5ac90d227c88e6fcab2fa43c0b3ffb5>
13:26 huginn News from kohagit: Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=83d471394562b8137fce9b3a538d19efc41fa1e1>
13:26 huginn News from kohagit: Bug 26988: Make ->patron prefetchable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=75456ba973f87d3c46d045811ad32dfe2a153e3f>
13:26 huginn News from kohagit: Bug 26988: (QA follow-up) Make the API return proper library objects <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=14506040292201a78733a9c1746bf7f590205fe3>
13:26 huginn News from kohagit: Bug 26963: Unit tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=db1865ba346704d47be28cf8afdcc6052f55d61a>
13:26 huginn News from kohagit: Bug 26963: (follow-up) Change subroutine name for QA tools <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b06c361d6c9a45fb07c853f07fb9aa5d4d77c37>
13:26 huginn News from kohagit: Bug 26988: (follow-up) Adjust code to use api field names <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4388d20fb12f77aa733498baa4a287e4fb7c6998>
13:26 huginn News from kohagit: Bug 26988: (follow-up) Fix filter and encode api values and escape rendered values <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=19a30acaece904aeedcc6a3728e3815895d10c56>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Convert to ResultSets <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7179a29feaf994f35de871d06084f71dfc9eebcc>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Don't delete existing data before tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b09e86a8d3609e03988be4ad387f018a91d0fd7>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Fix up tests and cover case of undefined ccode <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e61bcc270e8bc9a13939af60df45a1db53e51530>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Fix cases where we expected a list <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7a42c85889bf779bbcaf82a31793438ebcffc076>
13:26 huginn News from kohagit: Bug 26988: (follow-up) Change event to focus <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7edb1a55bc54fd5c68700e703be9deff3d6a0199>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Update mocked return of pickup_locations <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=04a4a34d6e9b7a235ae238b82b991795ca5abb8a>
13:26 huginn News from kohagit: Bug 26963: (QA follow-up) Migrate unit tests into pickup_location <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b6a7a3c8a8fa040409f4c42d10149b72a427cf54>
13:26 huginn News from kohagit: Bug 26963: Ignore existing libraries <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b6deb941dc95f8642ef8d20da7f2fcabbc0a15d7>
13:26 huginn News from kohagit: Bug 26988: No need to check if hold is linked to a patron <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f83e703abd69383cb80ca36cd8219959f1ab205>
13:26 huginn News from kohagit: Bug 26988: Adjust for bug 26963 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=91e21d3a95520f19fa3632d87f2c8f32b11ea1eb>
13:25 Joubu we should have updated the item level field, not setting all them to 0
13:24 Joubu not a big problem but it's a bug in the upgrade process :)
13:22 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, Reverting a waiting hold should lead to the former hold type (item or biblio level)
13:22 magnuse i thought there were several where "itemnumber is not null and item_level_hold = 0" but all of them except one have found=w|t, so not a big problem. it could be a reverted waiting hold, as discussed in bug 9834
13:21 magnuse Joubu: yes before the upgrade
13:19 Joubu At first glance the code in AddReserve look ok to me, we should not have inconsistencies between those 2 fields. Even if called by the API route
13:18 Joubu magnuse: has the hold been placed before the upgrade? :)
13:17 ashimema well... it might be as I think within the scripts we also set defaults which correspond to the defaults in the template config files for when the elements are missing
13:17 magnuse (ah, reserves.item_level_hold was added by the upgrade to 19.11)
13:16 tuxayo etc and debian/templates, that's good to know
13:16 ashimema exactly
13:16 ashimema as a general rule we souhld try to keep any such templates in sync accross the two place
13:16 tuxayo So not the same default conf ^^"
13:16 tuxayo ok!
13:16 ashimema one is for installs using 'make' and the other is for debian packages
13:15 ashimema they're both templates for the config file
13:15 magnuse Joubu: hm, i only see one occurence of it. the hold was placed through the REST API and it was not meant to happen, the library does not allow item lever holds
13:15 ashimema well.. they're out of sync and shouldn't be..
13:15 tuxayo ashimema: I didn't get that in the ticket, what's up to syncing these files?
13:14 ashimema did I imagine a bug that re-synced etc/SIPConfig.xml with debian/templates/SIPConfig/xml
13:14 tuxayo ashimema: thanks, that will help to put the pieces of the puzzle together :)
13:13 Joubu ?
13:13 Joubu magnuse: can you confirm it happens for holds placed on an item (still in reserves) before 19.06.00.005
13:13 magnuse make that found=w|t
13:13 magnuse Joubu: which upgrade are you thinking of?
13:12 magnuse Joubu: looks like it will happen when found=w
13:11 ashimema the golden nugget is to use Sip::Constants.pm to help understand the overly cryptic docs
13:11 Joubu that's a bug
13:11 Joubu magnuse: the upgrade does not deal with existing entries in reserves
13:11 ashimema :)
13:11 tuxayo Thanks for confirming it's the right document and version, I wasn't sure.
13:11 tuxayo Thanks ashimema ^^ I was able to get it from the Internet Wayback Machine and find the link from the SIP Wikipedia page.
13:10 Joubu it could have happened
13:10 Joubu actually
13:09 Joubu magnuse: indeed, should not happen
13:08 ashimema present in your inbox tuxayo
13:06 magnuse so a reserve that has an itemnumber, but item_level_hold = 0 -- that shouldn't really happen?
13:05 severine_q windows 10 :/
13:05 magnuse severine_q: better to look at koha-testing-docker, perhaps
13:05 tcohen severine_q what OS?
13:05 severine_q i still need to learn how I can install my one devbox...
13:05 tuxayo ashimema: thanks, I'll retest the bug and try to QA it :)
13:02 fridolin we still need to recreate our sandboxes with the docker system
13:02 ashimema Nice work trying to get to grips with sip
13:02 ashimema Hi tuxayo
13:01 tuxayo ashimema: hi o/
12:58 severine_q hope you can solve it as "easily" as frido ashimema !
12:57 severine_q thanks fridolin !
12:56 Joubu kohaputti: message transport types
12:55 fridolin severine_q: better , was missing a new perl dep
12:53 kohaputti Joubu, mmt?
12:52 Joubu kohaputti: I'd make it behave like extended_attributes, and return the mmt after a "set" call
12:52 huginn ashimema: The operation succeeded.
12:52 ashimema @later tell tuxayo if your happy to finish off your testing of bug 25761 then feel free to convert my SO to a PQA ;)
12:51 ashimema tuxayo around?
12:50 ashimema no worries severine_q , it's not your fault.. I'm just a bit stuck as to why the sandboxes are suddenly so fragile
12:50 kohaputti that is both getter and setter
12:50 kohaputti (I was doing code review of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107612&action=diff for sub message_transport_types)
12:50 Joubu (and is_* when return a boolean, we almost already agreed on that)
12:50 ashimema Joubu++
12:49 fridolin severine_q: i look :D
12:49 Joubu I'd be in favor of: set_ when only set (password example), get_ when is just an accessor (you don't have necessarily a set_ corresponding method), and ->stuff for both set and get (like extended_attributes)
12:48 kohaputti ok, just a moment while I go read more about what you just mentioned, will get back soon with follow-up questions
12:47 tcohen while there's a 'password' attribute, setting the password shouldn't be confused with an accessor
12:47 Joubu Koha::Patron->extended_attributes is a good example I think
12:47 tcohen for example $patron->set_password
12:47 tcohen for calculated or not accessor methods
12:46 tcohen but sometimes we put get_ set_
12:46 tcohen you can get and set with the same call style
12:46 tcohen accessors should be accessors i.e. $patron->name('') should be an accessor
12:44 kohaputti which one we should start using?
12:44 kohaputti we have two different OO coding styles in use: first is sub set_index_status(XXX) together with sub get_index_status() then another one style is sub index_status() together with sub index_status(XXX)
12:31 severine_q sorry ashimema :/
12:22 ashimema these darn sandboxes are starting to really bug me..
12:22 ashimema grr
12:09 severine_q I wanted to test some unimarc stuff
12:08 severine_q oh there are 2 provisioned but also dead :/
12:08 ashimema using the biblibre ones severine_q ?
12:04 severine_q help fridolin, all sandbox are dead :(
12:01 ashimema :)
12:01 Joubu well, after lunch!
12:01 Joubu ashimema: I am on a follow-up for the second error reported on that bug
12:00 Joubu so if you are running MySQL8 then you don't have such values
12:00 Joubu ashimema: no, the DBMS won't accept date with 0000-00-00
11:28 ashimema bit odd that the mysql8 update itself doesn't flag those issues
11:28 * ashimema wonders if a script for removing those should be run prior to any mysql8 upgrades
11:27 ashimema not great
11:27 ashimema interesting.. so you hide them in the upgrade with your patch.. but then the person says they just re-appear in live running
11:26 ashimema nice to see.. I'll take a look at that patch :)
11:25 magnuse ashimema++
11:25 ashimema but I have seen loads of those errors on my dev systems actually
11:25 ashimema thankfully not on mysql8 yet for this one
11:25 ashimema oh, good call
11:24 ashimema 4 years.. suppose that's not too terrible
11:24 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Database Mysql Version 8.0.22 failed to Update During Upgrade
11:24 Joubu ashimema: bug 26997 - in case you face it
11:24 ashimema we have a couple of 16.11's still lurking too.. those have been waiting for all their customisations to make it into community.. something I think I've at last succeeded in doing with the release of 20.11!
11:23 ashimema but there are a few monster DB updates
11:23 ashimema so not THAT old ;)
11:23 ashimema 3.22
11:22 magnuse ashimema: how old?
11:22 * ashimema is happy to say he's seen the back of all the 2.2 upgrades he had to do back in the day... this one is childs play in comparison to those .. hehe
11:21 enkidu ^good
11:21 enkidu goog luck ashimema !
11:16 ashimema always fun
11:15 * ashimema is currently upgrading a pretty old Koha...
10:57 mtj ashimema: i think ci.debian.net is running the tests, so ignore my previous statement
10:49 ashimema huh
10:48 mtj oops, fake news... https://ci.debian.net/packages/libm/libmojolicious-plugin-openapi-perl/unstable/amd64/
10:47 ashimema yikes
10:45 mtj i recently discovered that the debian perl packages dont run any of their ./t tests
10:42 mtj ..its a debian problem, i think
10:41 mtj Joubu: yes :)
10:38 Joubu or directly mojo's authors
10:37 Joubu don't you think we should contact mojolicious-plugin-openapi debian maintainer?
10:34 mtj hmm, it seems that D11's libjson-validator-perl(4.10+dfsg-1) is somehow broken...?
10:33 Joubu mtj: it's familiar to me, I got that when I tried few days ago.
10:27 mtj like that.. -> https://gitlab.com/mjames/ktd-d11/-/jobs/847606026
10:22 mtj something odd that i cannot explain, is if you swap 'cpanm -n json-validator' with 'apt install json-validator' the tests fail?!
10:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 normal, P5 - low, ---, koha-bugs, NEW , Deleting a biblio should alert/fail if there are existent subscriptions
10:21 severine_q TimothyAlexis : I update status to NSO for bug 9565, for I can't sign it as it's NEW
10:19 mtj ..just for the log :)
10:19 mtj hi ashimema, Joubu, you can see D11 building mojolicious-plugin-openapi here -> https://gitlab.com/mjames/ktd-d11/-/jobs/847580267
09:59 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 normal, P5 - low, ---, koha-bugs, NEW , Deleting a biblio should alert/fail if there are existent subscriptions
09:59 TimothyAlexis bug 9565 is ready for sign off
09:46 koha-jenkins Project Koha_Master_U20 build #144: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U20/144/
09:45 koha-jenkins Project Koha_Master_U18 build #946: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_Master_U18/946/
09:36 TimothyAlexis Got it, thank you
09:36 TimothyAlexis Joubu++
09:35 * kohaputti drowns in plack-error.log warnings
09:34 TimothyAlexis detail.pl has this: $template->param(biblio => $biblio);
09:33 Joubu TimothyAlexis: if you have the biblio object you can: biblio.subscriptions.count
09:29 koha-jenkins Project Koha_Master_D10_Deps build #136: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/136/
09:29 wahanui Congratulations!
09:29 koha-jenkins Yippee, build fixed!
09:29 TimothyAlexis Is there something similarly easy to check if there's a subscription attached to the biblio?
09:28 TimothyAlexis It counts the items attached to the biblio.
09:28 TimothyAlexis [% IF ( count ) %]
09:28 TimothyAlexis There's this in cat-toolbar.inc:
09:19 ashimema I think that's why it came back
09:19 ashimema so that the rmaints can still get it appearing
09:19 ashimema I did wonder about setting it based on version in the config
09:19 ashimema agreed
09:18 Joubu ashimema: it needs to be adjusted on release day
09:17 Joubu ashimema: yes, it's on my list. It's hardcoded from the release tools.
09:17 TimothyAlexis With the same functionality as when there are existent items.
09:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 normal, P5 - low, ---, koha-bugs, NEW , Deleting a biblio should alert/fail if there are existent subscriptions
09:16 TimothyAlexis bug 9565
09:16 TimothyAlexis I'm thinking about solving 9565
09:16 koha-jenkins Project Koha_Master_D10 build #406: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D10/406/
09:15 ashimema D8 is officially out of support by debian these days
09:15 ashimema oh.. btw.. Joubu the release notes still claim support for Jessie and MySQL 5.5... I'm sure I dropped those or said we would drop them with 20.05... we should remove them from the supported list for 20.11 I reckon
09:14 ashimema it feels like we're moving towards upping our minimum versions for these libs.. which has me wondering how hard it will be to backport the newer one's to older OS's
09:14 mtj i think we are on the correct track for a fix
09:14 ashimema thanks mtj
09:13 mtj i'll set up a jenkins test with the new modules so we can properly compare failed tests
09:13 ashimema indeed
09:13 ashimema instead we updated the few controllers we had already written to not use the old passing structures
09:12 ashimema i.e. we're not using that around_action hook..
09:12 ashimema looking at the code, I think we upgraded properly
09:12 mtj ah yes.. we have moved from swagger to openapi - i think it doesnt apply then
09:11 ashimema we certainly used the Swagger2 plugin in the early days.. I wasn't part of the effort to move us to OpenAPI
09:10 ashimema it could very well do
09:06 mtj "This guide is useful if your application is already using Mojolicious::Plugin::Swagger2."
09:06 mtj ashimema, Joubu - does this info apply to koha? -> https://metacpan.org/pod/release/JHTHORSEN/Mojolicious-Plugin-OpenAPI-3.40/lib/Mojolicious/Plugin/OpenAPI/Guides/Swagger2.pod
09:05 mtj (and D10 has incompatible versions too)
09:05 mtj currently D11's J::V (4.10) and Mojolicious::Plugin::OpenAPI (2.21) modules are incompatible
09:03 Joubu it's not
09:03 mtj ^ its not a very nice solution :/
09:02 mtj ...a fix could be to tell users to make the kc repo have a higher priority (like 600) - which would allow apt to select an older pkg
09:00 mtj ..the problem is that apt always selects the newer pkg, as both apt repos have the same '500' priority
08:58 wahanui somebody said the problem was it has several code issues
08:58 Joubu mtj: what's the problem?
08:56 koha-jenkins Project Koha_Master_D9 build #1495: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1495/
08:56 ashimema it's not an area I'm close enough to :(
08:56 ashimema had a feeling there might be..
08:55 mtj ashimema: there is a problem with forcing an older pkg version, via the deb/control file too :/
08:54 ashimema interesting
08:54 ashimema I think we generally need to get strict about locking down a Mojo + OpenAPI + JSON::Validator versions.. they're all really closely tied to each other.. updating them out of order is kinda asking for trouble
08:54 mtj hmm, yes same ones are failing, with similar errors (i think)
08:53 koha-jenkins Project Koha_Master_U20 build #143: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U20/143/
08:53 ashimema dang, that's not so good :(
08:53 Joubu same ones are failing?
08:53 ashimema I didn't mean to throw out your idea of updating Koha.. I had just already tried that route before suggesting the packaging route to fixing the issue
08:53 mtj ...but sadly, the koha tests did not pass with the updated modules? :'(
08:52 ashimema oh nice, thanks mtj
08:52 Joubu mtj: how does it turn out?
08:51 Joubu mtj: great
08:50 mtj ashimema: i did make some progress and built the latest Mojolicious::Plugin::OpenAPI (3.40) on d11, with its tests passing OK
08:46 magnuse cait: yes!
08:46 koha-jenkins Project Koha_Master_D9_MDB_Latest build #441: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/441/
08:43 severine_q oh yes cait !!
08:43 cait :)
08:43 mtj cait: me too
08:40 mtj ...we had a similar problem on buster with incompatble versions of json-validator and Mojolicious::Plugin::OpenAPI
08:40 cait someoen else glad it's Friday?
08:39 did Joubu: yep , thanks
08:38 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 blocker, P5 - low, ---, koha-bugs, NEW , New version of JSON::Validator (D11) break our REST API routes
08:38 mtj ashimema: i did a bit more looking at bug 26893, i think you are correct :)
08:37 mtj hey #koha
08:35 Joubu did: git pull, see last commit!
08:34 ashimema mornin' #koha
08:21 koha-jenkins Project Koha_Master_D9_My8 build #464: SUCCESS in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/464/
08:16 magnuse hiya cait
08:13 cait good morning all :)
08:04 koha-jenkins Project Koha_Master_D11 build #141: NOW UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D11/141/
08:03 severine_q hi @magnuse alex_a :)
08:03 koha-jenkins Project Koha_Master_U2010 build #49: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/49/
08:00 koha-jenkins Project Koha_Master_U16 build #128: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_U16/128/
07:51 alex_a Salutation magnuse
07:51 magnuse bonjour alex_a
07:45 alex_a Bonjour
07:41 magnuse bonjour severine_q & #koha!
07:19 severine_q good morning #koha !
07:16 huginn News from kohagit: Bug 22818: Fix the last_insert_id call <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad>