Time  Nick          Message
00:53 hughrun       Hi is anyone around today?
06:49 alex_a        Bonjour
06:52 * dcook       waves
07:05 cait          good morning #koha
07:10 fridolin      good moring you all
07:59 magnuse       \o/
10:01 vfernandes    hi #koha
10:02 vfernandes    it's possible to send all Koha emails with one CC email?
10:44 oleonard      Hi all
10:56 magnuse       kia ora oleonard
11:12 kohaputti     vfernandes, check if NoticeBcc syspref is good enough for your purpose, otherwise you can configure your mail server to add the cc.
11:25 vfernandes    that's it... :) thanks kohaputti
11:30 ashimema[m]   mornin' #koha
11:30 ashimema[m]   jajm around?
11:30 jajm          ashimema[m], yes
11:31 ashimema[m]   any chance you could push a copy of your local bug 24975 branch?
11:31 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 enhancement, P5 - low, ---, julian.maurice, In Discussion , Refactor database translations
11:31 ashimema[m]   I want to get a feeling for how it all fits together without the pain of trying to rebase it (or inflicting a rebase on you)
11:31 * ashimema[m] didn't get to it on Friday
11:31 ashimema[m]   any public repo would be good
11:33 TimothyAlexis Where should we enter meta name="description" ?
11:34 jajm          ashimema[m], sure : https://gitlab.com/jajm/Koha/-/tree/bug/24975
11:34 ashimema[m]   ta, much apreciated
11:38 oleonard      TimothyAlexis can you explain more?
11:38 TimothyAlexis meta description tag for search engines
11:39 TimothyAlexis <head><meta name="description" content="This description will show in search engine results." /></head>
11:40 TimothyAlexis I added it to doc-head-close.inc, but I'm thinking it should be available in the System preferences.
11:41 oleonard      That seems like a reasonable idea
11:51 TimothyAlexis Should it be under Administration or OPAC?
12:02 oleonard      OPAC if it only affects the OPAC
12:06 TimothyAlexis Thank you Owen
12:07 ashimema[m]   oleonard++
12:09 TimothyAlexis When creating a patch, how is a new system preference added into the database?
12:10 oleonard      https://wiki.koha-community.org/wiki/System_Preferences
12:10 oleonard      and https://wiki.koha-community.org/wiki/Database_updates
12:14 ashimema[m]   or as a self contained patch example: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24197&attachment=109552
12:41 TimothyAlexis Thank you oleonard and ashimema[m]
12:42 TimothyAlexis I'll look at it again tomorrow.
12:48 tcohen        morning
12:50 nlegrand      Salut à tous et à toutes !
12:55 ashimema[m]   Hmm, the more I think about it the more inclined to agree with you I am regarding using the "description" as the key for these translations.. I feel like if people want to refine the description for a particular interface or framework or whatever they should probably start by refining it in the primary language first and then work through translations accordingly
12:56 ashimema[m]   Oops.. forgot to actually put jajm in the above comment
12:59 nlegrand      What is today's standard to install ES? Is it written some
12:59 nlegrand      where?
12:59 ashimema[m]   the only case where I could see this becoming an issue.. and one wanting multiple translated versions of the same key text would be if we wanted to eventually support plural forms and things at a DB level of translations?
12:59 nlegrand      I mean for a production instance.
13:03 tcohen        nlegrand we are using the koha/elasticsearch-icu docker image
13:03 tcohen        he
13:03 ashimema[m]   i.e. can you see a case where we might need db_tn, or db_tx or even db_tnx for example?
13:03 ashimema[m]   jajm ^
13:05 ashimema[m]   if so.. I think we should probably stick to a single db_t method, but get it to expect to be optionally passed extra levels of detail to allow a more refined selection of the translated text as and when required.. does that make sense?
13:13 kohaputti     nlegrand, you could install the elasticsearch package for your distro and then analysis-icu plugin, then after that you need to define the elasticsearch server ip, port and some custom mappings and search index settings to be used in koha-conf.xml, otherwise your logs will be full of deprecation warnings. Then after it is all set change the syspref SearchEngine to ES and use koha-elasticsearch command line tool to rebuild the index.
13:15 kohaputti     nlegrand, you could grep the koha code for elasticsearch configs in koha-conf.xml like this: rgrep elasticsearch | grep config
13:15 kohaputti     and then look what are the default files used for mappings, index, etc. and modify those to fit your needs
13:16 kohaputti     some wiki instructions would be good to have for this at some point I guess :D
13:17 magnuse       document all the things!
13:38 nlegrand      tcohen, kohaputti thanks! I was more looking for documentation. I think this is what I was looking for: https://wiki.koha-community.org/wiki/Koha_on_Debian#Elasticsearch
14:02 jajm          ashimema[m], what kind of extra data db_t should expect ? do you have a concrete example in mind ?
14:02 ashimema[m]   not at the moment.. hence the question
14:03 ashimema[m]   can we imagine any of our existing things that we want to add db level translation to (itemtypes, authorized values, frameworks perhaps) needing plural forms or masculine/feminine forms etc?
14:03 ashimema[m]   i.e can we imagine ever needing/wanting to pass in a 'count' to get a plural from of an authorized value description?
14:04 ashimema[m]   I can't envisage it for itemtypes (though I might be wrong.. I'm no linguist)
14:04 ashimema[m]   and we english tend to cheat allot and just use one word to mean lots of things..
14:05 ashimema[m]   for Joubu's case of having two AV's with matching descriptions.. I see that as a real odd case which we should probably just ignore/prevent double translations for such cases)
14:05 jajm          ashimema[m], i can imagine it for itemtype, like a list of items grouped by itemtype: 1 book, 2 DVDs, ... but i don't know if it will be that useful
14:07 ashimema[m]   generally I'm leaning more towards your keying on the text rather than a code.. I'm struggling to see reasoning behind Joubu's view that it needs to be keyed on codes.. (other than perhaps for plural type handling.. which I think we can certainly handle with some extra logic later on if needed
14:08 ashimema[m]   my comment on the bug isn't great.. I was coming at it from trying to keep joubu happy by allowing optionally keying on code instead of description.. but although I think I can make it work.. it's going to end up messy and I feel.. pointless complexity
14:13 ashimema[m]   as a side note.. I might have rebased wrong but the itemtypes admin page appears to be broken with your patchset as it stands
14:14 ashimema[m]   I can't remember how it should look with your patchset.. but currently it calls a non-existant translated_descriptions method from the template
14:16 jajm          ashimema[m], the patches should remove all calls to translated_description, but some might have been added since the last rebase
14:17 ashimema[m]   aha.. I see
14:17 ashimema[m]   I'll drop them in my local branch
14:46 lukeG         Good morning
14:47 tcohen        hi lukeG !
14:47 tcohen        bug 26193
14:47 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26193 enhancement, P5 - low, ---, lucas, RESOLVED WORKSFORME, Allow for a minimum payment threshold when using PayPal OPAC Payments
14:47 tcohen        you need to install the paypal plugin to your partner
14:48 lukeG         i see
14:48 cait          tcohen: is this something we should make sure goes into release notes? deprecating/removing the old paypal code?
14:48 lukeG         thanks tcohen!
14:48 cait          i was wondering abut the relationship since i remembered your work ont he plugin
14:48 tcohen        cait I'm sure that was the case
14:49 cait          hm time to phase out the Koha side then?
14:49 cait          I don't remember really, just a fan of clean-up
14:49 tcohen        I'm trying to find it
14:49 tcohen        and cannot
14:52 tcohen        you are right
14:52 tcohen        this hasn't been advertised
14:54 cait          do the work and talk about it ;)
14:54 cait          what is the next step? adding a deprecation warning ot the prefs etc?
14:55 tcohen        yeah, I think amoyano added a button to import the 'old' sysprefs into the plugin config
14:55 tcohen        and we used Koha's strings for the translation part
15:05 cait          yes, I had seen it looked quite completed
15:05 cait          do we need a meeting or just a bug?
15:08 cait          tcohen: bug 23215
15:08 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 enhancement, P5 - low, ---, koha-bugs, NEW , Remove PayPal logic from Koha
16:38 oleonard      I wonder if there's any reason why moredetail.pl couldn't accept just an itemnumber.
16:40 oleonard      I assume there's a way to get a biblionumber from an itemnumber...
17:24 cait          oleonard: dating back to biblioitems or so?
17:24 cait          bye all :)
17:31 tcohen        oleonard can you help me with bug 26327? It seems cait doesn't like my design capabilities
17:31 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 enhancement, P5 - low, ---, tomascohen, Failed QA , Include transacting library in fines
17:56 oleonard      I'll take a look tcohen
17:56 tcohen        thanks!!
18:01 oleonard      tcohen if you're referring to cait's last comment on the bug, you're just missing a correction to the colspan of the table footer in boraccount.tt
18:02 oleonard      you corrected it in pay.tt but not boraccount.tt.
18:02 tcohen        ah!
18:02 tcohen        thanks
18:07 * oleonard    waves to downstairs oleonard
18:29 oleonard      Bug 26458
18:29 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Get item details using only itemnumber
19:12 oleonard      ^ that bug will facilitate parts of this feature: https://zivotdesign.com/p/view.php?p=16001106769882
19:22 oleonard      Bug 5697
19:22 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 enhancement, P5 - low, ---, gmcharlt, NEW , Automatic linking in guided reports
19:58 cait          oleonard++ glad you understand my comments :)
20:18 tuxayo        lukeGaround?
20:32 cait          hm tcohen - do you have a moment?
20:33 tcohen        Was about close the lid
20:33 tcohen        whatsup?
20:33 cait          heh it's ok
20:33 cait          i will bug someone else
20:33 tcohen        ok, I can take a look tomorrow
20:40 koha-jenkins  Project Koha_19.05_D9 build #276: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/276/
20:41 koha-jenkins  Project Koha_19.05_U18 build #278: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/278/
20:48 lukeG         tuxayo: i am around now :)
20:50 tuxayo        lukeG it seems you backported Bug 26253 according to the branch but not to the ticket. Any issue/test failed?
20:50 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26253 blocker, P5 - low, ---, jonathan.druart, Pushed to master , duplicated mana_config in etc/koha-conf.xml
20:51 koha-jenkins  Project Koha_19.05_D9_MDB10.3 build #24: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_19.05_D9_MDB10.3/24/
20:53 lukeG         tuxayo: no issues, it looks like I just failed to update the bug ticket, will do that now
20:53 lukeG         http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=53c99fcb46b5486ff244cc2b07ba5fad28a3940d;hp=45e8f2f5c600094f90f938b1b30d81c236d10020
20:56 tuxayo        lukeG: I'm catching up bugzilla notifications and just found out we should have backported this for a while :o
20:56 tuxayo        176 emails to go
20:57 aleisha       thanks lukeG - normally if i see you've missed updating the bug ticket i just do it for you
20:57 aleisha       but wasn't sure about that one
20:59 lukeG         tuxayo, aleisha: sorry about that one. I think that was in the midst of last months security release and I just missed that one :(
21:00 aleisha       it's okay! easy to miss a step in the process when there are so many, especially that release :)
21:01 tuxayo        lukeG: it's okay, it's hard to be upstream. For next cycle I'm worried that I wouldn't be ready to take something else than oldoldstable.
21:42 koha-jenkins  Project Koha_20.05_U18 build #75: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/75/
21:47 koha-jenkins  Project Koha_20.05_D11 build #35: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/35/
21:49 koha-jenkins  Project Koha_20.05_U16 build #71: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/71/
21:57 koha-jenkins  Project Koha_20.05_U20 build #73: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/73/
22:19 koha-jenkins  Project Koha_20.05_D10 build #83: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/83/
22:24 caroline      How do you translate <<items.fine>> in TT in notices?
22:25 * ashimema[m] thinks the rmaints are doing great :)
22:25 caroline      since it's not an actual db column, I'm having a hard time with it
22:25 cait          what do you mean by translate
22:25 cait          ?
22:25 cait          "current fine for the item"?
22:26 cait          maybe
22:26 caroline      make it in Template toolkit instead of << >>
22:26 cait          oh
22:26 cait          not sure if you can yet
22:26 cait          ashimema[m] if awake would maybe know
22:26 * ashimema[m] is half asleep
22:27 ashimema[m]   what notice?
22:27 wahanui       notice is, like, ACQORDER
22:27 caroline      ODUE
22:30 * ashimema[m] is digging
22:31 ashimema[m]   I think you're going to have to dig a bit to get there
22:32 ashimema[m]   something along the lines of [% item.checkout... %]
22:32 ashimema[m]   OK.. it's not possible.. yet
22:32 ashimema[m]   we need more object relations for you to get there..
22:32 caroline      blegh... and it's not possible to have hungry alligators in a FOREACH loop?
22:32 ashimema[m]   what you would end up with (if the methods existed down the whole chain) would be
22:33 ashimema[m]   [% item.checkout.fine.amountoutstanding | $Price %]
22:34 ashimema[m]   which would mean.. for the ITEM give me the most recent CHECKOUT.. find the FINE attached to that checkout and finally give me the AMOUNTOUTSTANDING field (and then pass it through the $Price filter to make it look nice)
22:34 ashimema[m]   does that make sense?
22:35 ashimema[m]   they're all sensible enough relations to want.. if you add a bug describing it I can have a go at adding the relations for you.. should be a fairly trivial set of patches when you know how
22:35 caroline      i guess... I still don't understand TT, so it's hard for me to say... I do a lot of trial and error and copying from the wiki
22:36 * ashimema[m] is happy to walk someone else through it too.. but not tonight.. I'm fixing a translations thing whilst I can't sleep
22:36 ashimema[m]   it's not really TT as much as it's Koha::Objects ;)
22:36 ashimema[m]   in this case
22:36 ashimema[m]   basically.. once you open up using TT you have access to all the gory methods available to you from the Koha::Object you are passed.. which is very powerful
22:37 ashimema[m]   but also, not easy to document in a simple fashion just for templates
22:37 * caroline    is getting hangry at TT notices
22:37 ashimema[m]   you can actually do some really horrible things come to think of it..
22:38 lukeG1        tuxayo or aleisha still about?
22:38 koha-jenkins  Project Koha_20.05_D9 build #89: UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/89/
22:38 aleisha       yup!
22:38 ashimema[m]   for example.. you could in theory write a notice that added a cost to the patron every time it was sent out.. I like that actually.. hehe.. you could charge for notices without writing any code whatsoever in Koha to do it.. just by adding to the template
22:38 ashimema[m]   cool
22:38 aleisha       whats up lukeG1
22:38 ashimema[m]   for anyone following along with my revelation there
22:38 koha-jenkins  Project Koha_20.05_D9_My8 build #80: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/80/
22:38 lukeG1        Im wondering if we are going back to the normal schedule of 15th for string freeze and 22nd for  a release
22:39 lukeG1        for this month
22:39 ashimema[m]   [% patron.account.add_debit amount => 1.00, type => notice %]
22:39 tuxayo        lukeG1: «still about» ?
22:39 tuxayo        IIUC yes
22:39 ashimema[m]   something along those lines in a notice that includes a patron object would magically add a charge to the patron every time it was triggered to send.. hehe
22:40 aleisha       yup lukeG1 i believe that was the plan :)
22:40 aleisha       those are always the dates unless we agree to change them, like we did last month
22:40 lukeG1        Yup, just making sure! Thanks :)
22:40 tuxayo        lukeG1: In the email from jonathan sent on "Wed, 9 Sep 2020 10:00:56 +0200"
22:40 aleisha       never hurts to make sure!
22:40 tuxayo        +1
22:41 tuxayo        So yep, we understood the same thing :)
22:41 aleisha       lukeG1: how are you going with backporting those string patches?
22:43 lukeG1        aleisha: Ive backported everything I need into 20.05, Im all caught up with master now
22:44 cait          can you consider the other de-DE one again? hope i didn't miss it
22:45 cait          bug 25129
22:45 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25129 enhancement, P5 - low, ---, katrin.fischer, Pushed to master , Update German (de-DE) web installer files for 20.05
22:45 lukeG1        cait: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=8e86f81b4130ce7d6a1e5556b2cfb1a2f19559d6
22:46 cait          yep that's frameworks
22:46 cait          thi sis installer
22:46 cait          2 bugs
22:46 lukeG1        cait: oh thank you! I did miss 25129
22:46 lukeG1        Ill go get it right now
22:46 cait          lukeG++
22:48 aleisha       thanks :)
22:55 koha-jenkins  Project Koha_20.05_U18 build #76: UNSTABLE in 58 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/76/
22:57 koha-jenkins  Project Koha_20.05_U16 build #72: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/72/
23:11 koha-jenkins  Project Koha_20.05_U20 build #74: SUCCESS in 1 hr 13 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/74/
23:21 koha-jenkins  Project Koha_20.05_D10 build #84: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/84/
23:22 koha-jenkins  Project Koha_20.05_D11 build #36: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/36/
23:27 koha-jenkins  Project Koha_20.05_U16 build #73: ABORTED in 5 min 6 sec: https://jenkins.koha-community.org/job/Koha_20.05_U16/73/
23:40 koha-jenkins  Project Koha_20.05_D9_My8 build #81: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/81/
23:55 koha-jenkins  Project Koha_20.05_D9 build #90: STILL UNSTABLE in 59 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/90/