Time Nick Message 22:40 aleisha night cait ! 22:40 cait and good night #koha! 22:40 cait hi aleisha 22:38 aleisha hello 20:07 koha-jenkins Project Koha_19.05_D9 build #256: NOW UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/256/ 19:40 koha-jenkins Project Koha_19.05_U18 build #258: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/258/ 19:11 koha-jenkins Project Koha_19.05_D9 build #255: STILL FAILING in 51 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/255/ 19:01 koha-jenkins Project Koha_19.05_D9_MDB10.3 build #4: FIXED in 44 min: https://jenkins.koha-community.org/job/Koha_19.05_D9_MDB10.3/4/ 19:01 wahanui Congratulations! 19:01 koha-jenkins Yippee, build fixed! 18:27 koha-jenkins Project Koha_Master_D11 build #36: NOW UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D11/36/ 18:11 koha-jenkins Project Koha_19.05_U18 build #257: FIXED in 1 hr 11 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/257/ 18:11 wahanui Congratulations! 18:11 koha-jenkins Yippee, build fixed! 18:04 huginn tcohen: The operation succeeded. 18:04 tcohen @later tell oleonard does yarn.lock need to be kept in the repo? 17:44 koha-jenkins Project Koha_Master_U16 build #20: STILL UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U16/20/ 17:19 koha-jenkins Project Koha_Master_D10_Deps build #25: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/25/ 17:10 koha-jenkins Project Koha_19.05_D9_MDB10.3 build #3: FAILURE in 12 min: https://jenkins.koha-community.org/job/Koha_19.05_D9_MDB10.3/3/ 17:04 koha-jenkins Project Koha_Master_D10 build #298: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D10/298/ 17:00 koha-jenkins Project Koha_19.05_D9 build #254: FAILURE in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/254/ 16:58 koha-jenkins Project Koha_Master_U18 build #839: ABORTED in 17 min: https://jenkins.koha-community.org/job/Koha_Master_U18/839/ 16:48 koha-jenkins Project Koha_Master_D9_My8 build #367: STILL UNSTABLE in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/367/ 16:40 koha-jenkins Project Koha_Master_U20 build #39: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_U20/39/ 16:35 koha-jenkins Project Koha_Master_D9_MDB_Latest build #344: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/344/ 16:28 koha-jenkins Project Koha_Master_D9 build #1385: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1385/ 15:52 koha-jenkins Project Koha_Master_D11 build #35: STILL FAILING in 1 min 4 sec: https://jenkins.koha-community.org/job/Koha_Master_D11/35/ 15:51 cait1 caroline++ 15:48 huginn News from kohagit: Bug 25723: Drop DateTime::Set dependancy <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0f0553da225052ff5b8b9bca7a386e04472f32da> 15:48 huginn News from kohagit: Bug 25723: (follow-up) Fix Unit Test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b2990d270fdde9fd7f69f6402db9ee171b6473e> 15:48 huginn News from kohagit: Bug 25723: Drop DateTime::Set from cpanfile <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cd862763c9654ded15c1a7d79fafb2ec73e4f20e> 15:48 huginn News from kohagit: Bug 25723: Use a hasref for lookup <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e1dfe50522a01a7640fcca6e2a015206939579c9> 15:48 huginn News from kohagit: Bug 25723: Use the same code for single and exception holidays <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ae0b2befe8c9086df24469cb546c7c5f8d98de95> 15:48 huginn News from kohagit: Bug 25723: Update cache flushing calls <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=61141c28b0fcbbb021371bb4c2dd8e818aec0691> 15:48 huginn News from kohagit: Bug 25723: Remove tests for removed method <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=25f0d425eaa7c66953d02c5a5717b1b2abcb89a6> 15:48 huginn News from kohagit: Bug 25723: (QA follow-up) Silent POD warning <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5851539424d04eda0da52ef8744925227dd6ce0f> 15:48 huginn News from kohagit: Bug 25801: Add itemnumber parameter to opac-detail <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dbaf146266a5d25d2c3843cde977cfa027854134> 15:48 huginn News from kohagit: Bug 25801: (follow-up) Add Show all items-link on opac-detail <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5fdbfcf6163af5ce475488eaf897541bfd14e97c> 15:48 huginn News from kohagit: Bug 25801: (follow-up) Fix indentation level of else block <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6a6d0802e89cfc6634896d9ab9385fac16c87c5e> 15:48 huginn News from kohagit: Bug 25798: Add copyright year to "Holds to pull" report <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=58abd5b39b248eb08065e3a0d7f5f811175cecca> 15:48 huginn News from kohagit: Bug 25717: Improve automatic renewal error messages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=379fd6d838d9909ea5784011486f3d184766a833> 15:48 huginn News from kohagit: Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=581bd91319703aaf8c972fbf4226d25d87e556a2> 15:48 huginn News from kohagit: Bug 25827: Add floating toolbar to the holds summary page in staff interface <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=01ab775440ee8418e21872c309acee7b1739fad8> 15:48 huginn News from kohagit: Bug 25799: Add edition information to "Holds queue" report <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c4cff589ba80984a8029c4b4675afb55d09030a9> 15:48 huginn News from kohagit: Bug 25718: Correct typo in additem.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2440d480ca24bd1d15731fbd32aec0ea3aa71086> 15:48 huginn News from kohagit: Bug 25723: (QA follow-up) Handle holiday and exception on same day <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=223b603f08267f801860bf5deaaa1884e58eab1e> 15:48 huginn News from kohagit: Bug 25723: (QA follow-up) Remove unused module import <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e8fe7de5be946735b59fdc5cd8e8c6b166ed2475> 15:48 huginn News from kohagit: Bug 25511: Add POD for --force <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0c0666c531133a4c743a50ee01a0aada84c2e3cf> 15:39 reiveune bye 14:17 caroline ok so I'll keep the newest one bc th e title is better and the description has a test plan 14:17 tcohen he 14:17 tcohen if they don't have patches, obviously 14:17 Joubu usually we keep the oldest one, unless the newest is better (explanation, discussion, etc.) 14:16 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21292 enhancement, P5 - low, ---, koha-bugs, NEW , Patron Deletion Tool 14:16 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483 enhancement, P5 - low, ---, koha-bugs, NEW , When batch deleting patrons, report who was not deleted and why 14:16 caroline bug 24483 and bug 21292 14:16 caroline when marking bugs as duplicates, do you keep the oldest one, or the one with the best description? 14:08 koha-jenkins Project Koha_Master_U16 build #19: UNSTABLE in 59 min: https://jenkins.koha-community.org/job/Koha_Master_U16/19/ 13:49 koha-jenkins Project Koha_Master_U18 build #838: UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_U18/838/ 13:38 koha-jenkins Project Koha_Master_D10 build #297: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D10/297/ 13:25 koha-jenkins Project Koha_Master_D10_Deps build #24: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/24/ 13:10 kohaputti hmm, ok, I guess we could do then CanItemBeReservedOPAC() which adds that extra check 13:08 koha-jenkins Project Koha_Master_D9_My8 build #366: UNSTABLE in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/366/ 13:08 Joubu OPACHoldsIfAvailableAtPickup is only for OPAC, and that's why it's not in a module 13:08 kohaputti I'm asking this because it would be really nice to get this check in CanItemBeReserved() since that thing is called so many times 13:07 kohaputti cait1, ping ^ 13:06 kohaputti having different policies for opac and intranet and rest really makes the availability calculation a mess 13:05 kohaputti Joubu, OPACHoldsIfAvailableAtPickup doesn't apply to rest or intranet. Shouldn't it? This begs the question does the library have two different policies for holds, if they call you you get it, but if you try online through opac you wont' 13:04 koha-jenkins Project Koha_Master_D11 build #34: FAILURE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D11/34/ 13:01 eythian making 3D images from book cover images. 13:01 eythian https://3d-book-css.netlify.app/ might be relevant to people here 12:56 koha-jenkins Project Koha_Master_U20 build #38: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U20/38/ 12:53 huginn ashimema: The operation succeeded. 12:53 ashimema @later tell oleonard I'd be interested in your thoughts on my final comment on bug 24201 as the person closest to how we currently structure templates.. 12:53 koha-jenkins Project Koha_Master_D9_MDB_Latest build #343: STILL UNSTABLE in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/343/ 12:53 Joubu thanks tcohen! 12:53 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26005 critical, P5 - low, ---, oleonard, Passed QA , OPAC cart display fails with error 12:53 tcohen Joubu bug 26005 12:53 Joubu kohaputti: if you disable the pref you won't be able to select a library where the item is available. Which certainly means the same thing as well ;) 12:49 kohaputti it might mean the same thing but I cannot parse the first description really :D 12:48 kohaputti Joubu, aha.. I think I was bit confused by the syspref description "Allow to pickup up holds at libraries where the item is available. " When it actually, when reading code, is "Allow to make a hold to item if it is available for hold in it's holding library" 12:48 koha-jenkins Project Koha_Master_D9 build #1384: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1384/ 12:45 Joubu cc me if you create a new bug report 12:44 Joubu kohaputti: ok, maybe you are right :) My brain is not fully with you at the moment (gonna push some stuffs), but I can have a look this week 12:43 kohaputti Joubu, I think the issue was then that the pickup locations were checked on biblio level and not item level, the bug I ran into 12:42 huginn Bug 17453: new feature, P5 - low, ---, jonathan.druart, CLOSED FIXED, Inter-site holds improvement 12:42 kohaputti (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453) 12:42 kohaputti Joubu, The original need for the the syspref was "At the moment users can reserve items and choose any library as a pick uplocation, but there is no mechanism to prevent users from reserving items thatare available on the shelf at any given location from reserving the item at thesame location, essentially creating a Fetch and Collect scenario." 12:41 ashimema oleonard around? 12:35 kohaputti well it kinda did already, since pickup parameter only adds the branchtransfer rules 12:34 kohaputti the opac-reserve.pl was missing the pickup parameter to IsAvailableForItemLevelRequest so that's why it didn't check if it was available at the pickup branch 12:33 kohaputti on shelf holds 12:33 Joubu I am not sure I understand. Which circ rules could replace OPACHoldsIfAvailableAtPickup? 12:32 kohaputti I think currently the syspref doesn't even do what it says it does... 12:31 kohaputti so I guess we need to keep this still around and just mark it as deprecated 12:31 kohaputti and well, then it would affect intranet and rest api 12:31 kohaputti what makes this more difficult is OPACHoldsIfAvailableAtPickupExceptions 12:30 kohaputti in case OPACHoldsIfAvailableAtPickup = True 12:30 kohaputti We could probably do some really complex circ rule transformation in db though 12:30 kohaputti but I guess if the library has not defined the rules in circ rules then their holdability would change unless they update the circ rules during koha upgrade 12:29 kohaputti Joubu, should we seriously keep backwards compability with OPACHoldsIfAvailableAtPickup ? It is not very useful since the rules could come from circulation rules 12:22 tcohen morning 12:07 huginn News from kohagit: Bug 24379: Make login_attempts not nullable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7bb31cffae27dc398a7b4a4decf3623ec65478ac> 12:07 huginn News from kohagit: Bug 24473: Add $raw filter for Syndetics content <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6b9572e0c8fb9f1ad1e60ed5db50e69c60ac1a00> 12:07 huginn News from kohagit: Bug 25293: Don't call escapeHtml on null <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2b56ae1d4a231a83f52420ec9efc4829226fa86a> 12:07 huginn News from kohagit: Bug 25726: make holds to pull ignore holds where found is not null and itemnumber... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=56220d211d7b5c4e2622787f9ea38ab12c8868f5> 12:07 huginn News from kohagit: Bug 25862: Prevent TinyMCE to mangle local url links <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2fbe775070637ebdddcc9ea0b455e80dbb85a83d> 12:07 huginn News from kohagit: Bug 25868: Fix transfers page to show effective itemtype <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e441cb35fb13670e65b9437706561c17d1311945> 12:07 huginn News from kohagit: Bug 25869: Fix Coce display for lists <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f77a377c939080eed36401746b5d722c91ee964b> 12:07 huginn News from kohagit: Bug 25896: Add missing closing </td> tag <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a21a3bba6b23beed7aef9852f7c82efbfc1c3c1e> 12:07 huginn News from kohagit: Bug 25950: Remove <client> in X-Forwarded-For from proxy tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b84fda33b23347846ae50016f1e4b38b0fd95f4> 12:07 huginn News from kohagit: Bug 25974: Remove inline style from table settings administration page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00a12f548b4336f6c6eae8ce30e7c6cfaf7ed05c> 12:07 huginn News from kohagit: Bug 25987: Fix alignment of fields in label batch creation form <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00f04146e915b2b1a9881439ac34088e6486921f> 12:07 huginn News from kohagit: Bug 24379: DBRev 20.06.00.005 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=312dd03223fbce83c77315250af9f1fc9ee0d4a1> 12:07 huginn News from kohagit: Bug 24379: DBIC schema changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f058e63b5ae573469ea21777b76b822afd8a3442> 11:13 vfernandes https://github.com/Koha-Community/Koha/blob/master/C4/Search.pm#L126 11:12 ashimema nlegrand around? 11:11 vfernandes FindDuplicate of C4::Search only works with Zebra? 11:11 vfernandes hi #koha 10:18 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26005 critical, P5 - low, ---, oleonard, Needs Signoff , OPAC cart display fails with error 10:18 Joubu Could someone have a look at bug 26005? 09:50 kohaputti ok, then I think I'm pretty much done... Except testing.. So I guess plenty of more work to do :D 09:50 Joubu yes, that would help to have its own bug 09:49 kohaputti And make another bug report about it 09:49 kohaputti I mean.. Maybe we can leave this bug here as it is... 09:49 kohaputti but bumbed into this other bug now 09:49 kohaputti Joubu, ...I started doing the thing I told in the bug report 09:48 kohaputti I think it fails later on though 09:48 kohaputti so for a specific item if the user select item level request it might show available in the reserve page even though it is 09:48 kohaputti but that variable is only for biblio level 09:48 kohaputti we push the non available pickup branches to @not_available_at variable 09:47 kohaputti Joubu, no, this logic in opac-reserve.pl 09:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 normal, P5 - low, ---, nugged, Needs Signoff , Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available 09:46 Joubu kohaputti: maybe related with bug 24683? 09:45 kohaputti we simply inform whether a given item is available somewhere but not in a specific branch even though the user will select a specific branch for pickup always 09:42 kohaputti cait1, Joubu the opac-reserve.pl page seems to be broken for item level reserves pickup location checking 08:13 Nemo_bis morning ashimema 08:03 ashimema mornin' #koha 07:52 wahanui hi Joubu are you around? 07:52 cait1 hi Joubu 07:29 Joubu hi #koha 06:49 alex_a Bonjour 06:38 reiveune hello 01:59 wahanui que tal, aleisha 01:59 aleisha hello 01:30 Crob04 http://koha.drfop.com/ 01:30 Crob04 Hey there, every single tutorial I can find for koha asks me to load up 127.0.0.1 to do the web config.. but I am installing to a VPS without a browser. When I try to access my KOHA site using the FQDN, I get the standard apache webserver page. Sorry for the extreme newb question, but I cant find a single tutorial or wiki page that shows me how to access the web server for outside of the local machine