Time Nick Message 02:22 wizzyrea @later tell joubu hi, what needs doing to the community git server? 02:22 huginn wizzyrea: The operation succeeded. 05:58 huginn News from kohagit: Bug 24897: (RM follow-up) Drop tests for es-ES notices <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f00a2570eb93f012b13d8cec04375164e6103a84> 05:59 koha-jenkins Project Koha_Master_D9 build #1296: FAILURE in 14 hr: https://jenkins.koha-community.org/job/Koha_Master_D9/1296/ 05:59 koha-jenkins Project Koha_Master_D8 build #837: STILL FAILING in 18 hr: https://jenkins.koha-community.org/job/Koha_Master_D8/837/ 06:09 magnuse \o/ 06:28 ashimema Ooops, I think I broke Jenkins again.. 06:28 ashimema I did however get gitlab mirroring going again last night.. 06:28 ashimema good ol' switch it off and on again ;) 06:49 magnuse "the method recommended by 10 out of 10 it professionals" 07:26 SoniaB hi 07:26 wahanui hello, SoniaB 07:50 ashimema Mornin' #koha 08:13 nlegrand a gut yor 08:19 Joubu @later tell wizzyrea Hi Liz, I sent an email to koha-devel to explain a bit more. 08:19 huginn Joubu: The operation succeeded. 11:04 * oleonard waves 11:04 TimothyAlexis You waved 11:06 TimothyAlexis oleonard I asked about submitting a patch for indentations and markup in opac-detail.tt the other day and you helped me by suggesting I submit bug reports in Bugzilla to submit the patches. 11:07 oleonard Yup. Hi 11:07 TimothyAlexis I was thinking about choosing the Templates component, unspecified version and severity: minor. Would that be correct? 11:08 oleonard We usually pick "master" for the version unless we can narrow the issue to a specific release 11:09 TimothyAlexis So, 2 reports, one for the markup and one for the indentations and then supply 1 patch, will that be proper? 11:10 oleonard The reverse: I recommend one bug report for the markup problems (the actual bug), and submit two patches. The first is reindentation only, the second is the fix. 11:11 oleonard You could also submit two bug reports and submit a patch on each. It's up to you. 11:11 oleonard Maybe the latter is better when you're just starting out... 11:11 TimothyAlexis Oh ok. Thank you again for the guidance. :) 11:14 TimothyAlexis Yeah that makes sense. I'll do this now. I wish you pleasant times ahead with blessings coming your way in both unexpected but also expected ways. That you may succeed in peace. :D 11:16 oleonard Thanks TimothyAlexis, I look forward to testing your patches :) 12:02 magnuse oleonard++ 12:10 Joubu oleonard: there are 2 more .dropdown in opac-detail-sidebar.inc 12:12 oleonard Joubu: I limited my search to the staff client since that's where the problematic combination of DataTable + dropdown happens 12:13 Joubu oleonard: ok 12:54 koha-jenkins Project Koha_Master_U18 build #758: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_U18/758/ 12:55 TimothyAlexis Just to make sure a line like this does nothing, correct? [% BLOCK cssinclude %][% END %] 12:58 Joubu TimothyAlexis: It does nothing but should not be removed. It is there to tell devs where CSS code should be put. 12:58 TimothyAlexis Joubu Thank you for the clarification :) 13:04 koha-jenkins Project Koha_Master_D10 build #205: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D10/205/ 13:21 tcohen Joubu the solution needs to happen in Koha::LIbraries->delete 13:21 tcohen not a generic one 13:21 Joubu tcohen: it's to prevent wrong call 13:21 Joubu with this patch we won't have bad calls 13:24 Joubu tcohen: take Koha::Item->delete as an example 13:25 ashimema the use of Class::Inspector seems to be reasonable tcohen.. I didn't spot it either. 13:25 Joubu we don't need to have Koha::Items->delete that will loop on the $item->delete 13:25 Joubu we need to generic method that guesses if we need to loop or not 13:25 Joubu it's what Koha::Objects->delete does with the inspector bit 13:25 * tcohen is meditating 13:26 tcohen we could have a Koha::Items->delete that is smarter than that 13:26 * Joubu plays Tibetan bowl 13:26 tcohen that's what I mean 13:26 tcohen hahahah 13:26 Joubu tcohen: we have Koha::Patrons->delete that is smarted than that 13:26 Joubu and it won't use Koha::Objects->delete 13:27 tcohen that's what my meditation was leaning to 13:27 Joubu one does not exclude the other 13:27 tcohen we can move forward with this, and if we want, we can have a smarter Plural->delete 13:27 tcohen agreed 13:27 tcohen thanks for playing the tibetan bowl, it cleared my mind 13:28 ashimema thanks guys 13:28 Joubu ashimema: btw in Koha::Account::CreditTypes->delete you forgot the transaction 13:28 ashimema oh.. oops 13:28 Joubu and DebitTypes 13:28 ashimema tanks 13:30 koha-jenkins Project Koha_Master_D9 build #1297: NOW UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1297/ 13:39 tcohen Joubu do I have your blessing with Koha::Objects->empty then? 13:39 tcohen I have mst's hehe 13:40 Joubu I will test it later 13:40 Joubu but it reads good 13:40 ashimema :) 13:41 * ashimema was about to look at that one.. sounds like it's in hand :) 13:41 tcohen I would recommend adding coding guidelines once it is in master 13:41 tcohen so we are all consistent in return values from now on 13:45 ashimema +1 13:45 ashimema any preference on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185#c7 13:45 huginn Bug 23185: major, P1 - high, ---, jonathan.druart, ASSIGNED , Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' 13:46 ashimema :) 13:46 ashimema Joubu++ 13:54 koha-jenkins Project Koha_18.05_U18 build #288: SUCCESS in 24 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/288/ 13:55 ashimema the debittypes and credittypes one's don't need a transaction the way they're written 13:56 ashimema we first check the data then we call the parent delete on the set 13:56 ashimema unless I'm missing something 13:56 koha-jenkins Project Koha_Master_D9_MDB_Latest build #263: STILL UNSTABLE in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/263/ 13:59 Joubu tcohen: we should clearly defined when to use it, undef still need to be returned when needed 13:59 Joubu I am not sure we have a lot of places where it should be used 14:00 Joubu but that's a good thing to have :) 14:31 koha-jenkins Project Koha_Master_D9_My8 build #288: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/288/ 14:48 TimothyAlexis oleonard are you still here by chance? 14:48 oleonard Yes 14:48 TimothyAlexis I created a bug report for the indentations and whitespace inconsistencies and attached a patch using git-bz. 14:49 TimothyAlexis So, next step is to do some fixes I found while doing that. 14:49 TimothyAlexis Can I do that using the same opac-detail.tt ? 14:49 koha-jenkins Yippee, build fixed! 14:49 wahanui Congratulations! 14:49 koha-jenkins Project Koha_Master_U18 build #759: FIXED in 53 min: https://jenkins.koha-community.org/job/Koha_Master_U18/759/ 15:04 oleonard TimothyAlexis did you create a branch in git for your changes in Bug 25302? 15:04 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 minor, P5 - low, ---, timothy_alexis.vass, ASSIGNED , The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. 15:07 TimothyAlexis oleonard Yeah I created a branch, should I have pushed too? 15:07 oleonard No that's not necessary 15:07 oleonard For your second patch you want to create a new branch based on your 25302 branch (as opposed to creating it based on master) 15:08 TimothyAlexis Oh that makes sense. 15:13 oleonard TimothyAlexis, the changes you made in 25302 look good, but I would ask that you reformat your commit message 15:13 Joubu TimothyAlexis: that is going to introduce a lot of conflicts with existing patches 15:13 oleonard https://wiki.koha-community.org/wiki/Commit_messages 15:14 TimothyAlexis oleonard: Oh, thank you for that. 15:16 TimothyAlexis My workday is over, would it be fine if I reformat tomorrow? 15:16 oleonard Of course 15:16 TimothyAlexis Joubu: Should I have left it? 15:18 TimothyAlexis I started working with Koha at Lund University Library 4 days ago. 15:19 Joubu I cannot tell right now the number of patches that is touching opac-detail.tt. But ideally that should be confirmed before modifying such file 15:19 Joubu there is this tool: https://splitter.koha-community.org/files 15:19 Joubu but it's currently down 15:19 TimothyAlexis Oh 15:19 TimothyAlexis What is it for? 15:20 Joubu search for patches that have been submitted on our bug tracker 15:20 Joubu oops, sorry wahanui 15:21 Joubu @later tell rangi can you bring splitter back to live please? 15:21 huginn Joubu: The operation succeeded. 15:22 wizzyrea hi 15:23 TimothyAlexis Thank you Joubu, primary focus is to contribute in a way where it is actually an improvement, so good to know. Wish you all a blessed day and hope we may all have a pleasant time ahead. :D 15:47 tcohen Joubu could you look if my tests for Koha::IObjecxts->delete look correct? 16:55 ashimema tcohen++ 19:21 cait oleonard-away: still a bit around maybe? 19:21 oleonard Yes 19:21 cait ah 19:21 cait qa tools complain about aria attribute for bug 25271 19:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 enhancement, P5 - low, ---, oleonard, Signed Off , Add floating toolbar to OPAC cart 19:22 cait are there cases when we don't want the aria attribute? or can i just always add them? 19:23 oleonard There are cases where we don't want them, let me look at that one again 19:23 cait od you want the line numbers? 19:23 cait http://paste.koha-community.org/19274 19:23 cait brb... ran out of tea :) 19:28 oleonard cait, those instances are fixed by Bug 25166... don't know if it's necessary to satisfy the qa tools with this bug 19:28 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 enhancement, P5 - low, ---, oleonard, Passed QA , Add aria-hidden = "true" to Font Awesome icons in the OPAC 19:28 cait ah I didn't realize we had a separate one already 19:28 cait i will just add a note 19:28 cait maybe we will get a conflict to fix tho? 19:28 oleonard Yeah 19:29 cait i will continue testing 19:30 cait for the future... can youexplain when we don't want the aria attribute? 19:31 oleonard If the icon is not decoration but the actual control we don't want the hidden attribute. 19:32 oleonard I think 25166 will need some follow-up to address cases where the mobile view needs changes to the aria attributes 19:34 cait so if the button 'is' the icon 19:34 cait without any explaiining text for example? 19:34 oleonard Yes 19:35 cait ok 19:35 cait should we put that in the style guide/coding guidelins maybe? 19:39 oleonard I think so 20:52 koha-jenkins Project Koha_19.11_D8 build #119: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/119/ 21:14 koha-jenkins Project Koha_19.11_U18 build #121: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/121/ 21:25 koha-jenkins Yippee, build fixed! 21:25 wahanui Congratulations! 21:25 koha-jenkins Project Koha_19.11_D9 build #115: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/115/ 21:36 mtompset Greetings, #koha 21:37 mtompset @seen druthb 21:37 huginn mtompset: I have not seen druthb. 21:37 mtompset Nevermind... Oops. :) 21:50 koha-jenkins Project Koha_19.11_D8 build #120: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/120/ 22:01 koha-jenkins Project Koha_19.11_U18 build #122: STILL UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/122/ 22:27 koha-jenkins Yippee, build fixed! 22:27 wahanui Congratulations! 22:27 koha-jenkins Project Koha_19.11_D8 build #121: FIXED in 26 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/121/ 22:39 koha-jenkins Project Koha_19.11_D9 build #116: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/116/ 23:04 koha-jenkins Project Koha_19.11_U18 build #123: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/123/ 23:20 philor fun, you can create a framework with the code A&B 23:20 philor how many places does the framework code get used in a URL unescaped? 23:24 philor given that trying to import an exported framework into it so I can test does absolutely nothing when you click the Import menuitem, I'd say that's the first place we use it unescaped :) 23:28 koha-jenkins Project Koha_19.11_D9 build #117: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/117/