Time Nick Message 02:18 philor I just don't get the patch workflow 02:20 philor too much time with Mozilla's rigid heirarchy, "you should start out by signing off some patches" just seems wrong to me 02:41 philor especially when I'm considering signing off something that tuxayo didn't :) 02:43 tuxayo > too much time with Mozilla's rigid heirarchy, "you should start out by signing off some patches" just seems wrong to me 02:43 tuxayo What do you mean philor ? 02:44 philor tuxayo: Mozilla's style is "you write patches, you get an authorized person to review your code, maybe if you do that for five or six years and do it really well, we'll let you become a reviewer too" 02:44 tuxayo *bugzilla? 02:45 philor no, Mozilla, the company and foundation and project that produce Firefox 02:46 philor which I worked on for several of my formative years, and got used to its odd ways being The Right Way 02:46 tuxayo Ho, I though you were talking about the processing on Koha. 02:46 tuxayo Now I'm even more confused about: 02:46 tuxayo > especially when I'm considering signing off something that tuxayo didn't :) 02:47 philor bug 22437 02:47 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 major, P5 - low, ---, m.de.rooy, Needs Signoff , Subsequent authority merges in cron may cause biblios to lose authority information 02:48 philor the sample data is linked to authorities bizarrely, it's surprising that you wind up with any results at all since authid 35 is a Saramago uniform title, and the bibs are all Perl books saying their Perl subject is linked to that Portuguese title 02:48 philor since my day job is cataloging, I just created authorities, created bibs linked to them, and it does indeed work perfectly when given reasonable stuff to work on 02:49 philor but 15 years of "code review is something only done by those experienced reviewers who have been anointed to do it" makes me reluctant to do more than comment that it does actually work 02:56 tuxayo > the sample data is linked to authorities bizarrely 02:56 tuxayo Which sample data? I'm using koha-testing-docker. 02:56 tuxayo authid 35 is 02:56 tuxayo Uniform title Colecç~ao "O Campo da palavra" 02:56 tuxayo Uniform title is the framework 02:57 tuxayo Indeed it's actually what you are talking about 02:59 philor but if you look at the 9 bibs linked to it, do any of them contain that uniform title? 02:59 tuxayo I don't get what's odd with this auth. Since I'm not a librarian I have a lot to learn to test some patches 03:00 tuxayo "uniform title" No idea what is that. I'm like a chicken who found a knife. (french saying) 03:00 tuxayo (or a fork, I'm don't know ^^") 03:00 philor linking *should* mean that every one of the bibs, in the field that has a subfield 9 with a 35 in it, is a field with that title 03:00 tuxayo > since my day job is cataloging, I just created authorities, created bibs linked to them, and it does indeed work perfectly when given reasonable stuff to work on 03:00 tuxayo That's great news! 03:02 tuxayo > linking *should* mean that every one of the bibs, in the field that has a subfield 9 with a 35 in it, is a field with that title 03:02 tuxayo I don't get everything but indeed when browsing the MARC tab of a biblio, there is mention of the auth Campo da palavra 03:03 philor ugh, did I look at them after a merge, when they had been changed to the thing they were merged to? give me a minute to kd/ku 03:04 tuxayo > makes me reluctant to do more than comment that it does actually work 03:04 tuxayo Actually feedback on the test data from librarian would be very valuable. This is the data where the automated testing is ran also so I'm important that I makes sense. 03:04 rangi philor: you can sign off, that just moves it to the QA queue 03:05 rangi it's not like we merge it in without 2 more sets of eyes on it 03:05 rangi it goes 3 more if it's for a backport 03:06 rangi your sign off will get it into the QA queue, if it passes there, then the RM 03:06 tuxayo philor: when you were talking about code review, in koha, it's the QA step. 03:07 philor ah! 03:08 philor to me, QA is... well, actually, it's pretty much what Koha's signing off is 03:08 tuxayo Code review from someone not in the QA team is totally welcome and might help lots of patches. Because QA team not large enough. 03:08 tuxayo And QA takes a lot of time 03:08 tuxayo (that's my current understanding) 03:09 rangi thats why we like initial sign off, so that we dont spend time QAing something that doesn't even apply, or work 03:09 philor and after a restart, http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&q=an=35 does indeed give me 9 Perl books without any relationship to Mr. Saramago's Colecç~ao 03:10 tuxayo Thanks for the info. That might help to understand why I don't have expected results. 03:12 tuxayo > to me, QA is... well, actually, it's pretty much what Koha's signing off is 03:12 tuxayo Ok. Actually signing off is were business logic could/should be discussed. 03:12 tuxayo Not only in QA. Since a lot of QAers are programmer and not librarians. 03:14 hayley Yes, it's very good for people who are librarians/cataloguers to sign off patches, as they are the ones who will actually be benefitting from the changes and understand why they're needed 03:14 philor thanks for the explanation, I just need to swap review and QA in my head 03:15 philor the same head that is typing 'hg status' multiple times a day in a Koha git repo :) 03:16 tuxayo > Yes, it's very good for people who are librarians/cataloguers to sign off patches 03:16 tuxayo Even if a patch test plan is too technical for librarians. Feedback from reading the patch comments and test plan if very valuable. Even without sign them off. 03:17 hayley yes also true 03:18 tuxayo rangi: hi btw o/ 03:18 tuxayo And question about doing release maintaining: I'm thinking about doing that for the next cycle. 03:18 tuxayo Anything else needed other than: 1. having a few hours a week. 2. being used to signing off 3. being used to git conflicts. 03:19 hayley tuxayo as first time release maintainer for 18.11.x, nope! 03:19 rangi i agree with hayley, especially if you take 19.05.x 03:20 hayley that's pretty much the knowledge I went in with - and yeah if it's your first time, going for the oldest stable release is best 03:21 hayley as you get to follow the branches of the oldstable above your version rather than having to check everything pushed to master 03:23 tuxayo > especially if you take 19.05.x 03:23 tuxayo > going for the oldest stable release is best 03:23 tuxayo Why? I though it should be left if possible to previous Rmaintainer. Because they already now all the API changes, renames, etc 03:23 tuxayo > than having to check everything pushed to master 03:23 tuxayo Indeed, that points to not going for stable. But is there something more difficult with oldstable? 03:27 rangi tuxayo: because oldoldstable is pretty much only critical/security bugs 03:27 rangi so there is far less to deal with 03:28 rangi the point with it is to not break things, no new features, not even bug fixes that are risky. Most of the tricky choices will have been made by the 2 rmaints ahead who are more experienced 03:28 rangi its is a good way to learn the ropes, then move to oldstable or stable 03:32 tuxayo Thanks for the tips rangi and hayley . Now I can more confidently candidate for 19.05/oldoldstable for next cycle :D 03:41 tuxayo hayley: How much was the weekly time that you had to dedicate to Rmaint? 03:43 hayley hmm, hard to say. towards the time of release it gets busier, but probably on average 2-5 hours? some weeks I didn't do anything if there were no new patches on the branches above, so it varies 03:46 tuxayo Thanks, that matches the impression I got from others. 03:51 philor mmm, the things you learn from tests 03:53 philor https://koha-community.org/manual//19.11/en/html/systempreferences.html#authoritymergemode doesn't quite happen to mention that strict mode also removes duplicate instances of the heading, a thing which would be popular if it didn't come with the (wrong) behavior that's actually documented 03:54 philor well, strict's behavour isn't exactly wrong, but loose makes up for the lack of another behavior 03:56 philor but there's a test that when you merge "Foo" to "Bar" and the bib already had both Foo and Bar in it, it winds up with only one Bar, which I've seen multiple bugs and comments in other bugs asking for 03:57 philor just have to enable a preference that says nothing at all about that, and boom, wish granted! 03:59 tuxayo philor: that might be worth a ticket or an email to the koha-docs list 04:00 tuxayo https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-docs 04:02 philor yeah, I'll file it, since I'll probably write it, once I get out of my current broken manual-editing state 04:05 tuxayo ^^" 04:08 tuxayo I especially thank you since the manual is especially useful to me as not being a librarian. Quite a barrier when wanting do a lot of signoffs. 04:22 philor I don't understand https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913#c16 though 04:22 huginn Bug 17913: normal, P5 - low, ---, m.de.rooy, CLOSED FIXED, Merge three authority merge fixes 04:24 philor unless it means that we never actually look at the contents of the bib field, only look for the tag number and subfield 9, and then either replace the whole field without looking at it, or replace the subfields that are in the authority record without looking at them 04:31 philor and failing to understand { map { ( $_->[0], 1 ); } ( @record_from, @record_to ) } is why I don't get paid to write code 04:40 philor okay, makes sense for the way the code's written, just doesn't happen to be what any user would ever want 06:36 reiveune hello 06:52 cait1 good morning #koha 06:55 magnuse \o/ 06:57 Nemo_bis huomenta 07:01 alex_a Bonjour 07:01 wahanui privet, alex_a 07:13 ashimema[m] morning #koha 07:13 kohaputti mtj, I noticed the koha-elasticsearch package is not in our koha master repo's control file. That could probably be added? 07:13 ashimema[m] nice to see you philor :) 07:13 ashimema[m] alwsys like new faces :) 07:14 ashimema[m] tuxayo for rmaint.. nice.. I'd be there to help if you ever need it tuxayo 07:30 magnuse tuxayo++ 07:34 Joubu @later tell tuxayo selenium tests are blocked but should be new, I will change the status. Current patches on the bug reports need to be rewritten. 07:34 huginn Joubu: The operation succeeded. 11:09 oleonard Hi #koha 11:10 cait1 hm i wonder if the spammers are experimenting 11:11 cait1 saw subjects with more than one word and soe fake ones with actual text :( 11:11 oleonard Yeah I see that too 11:18 oleonard Joubu++ # Bug 25186 11:18 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25186 minor, P5 - low, ---, jonathan.druart, Signed Off , Lots of white space at the bottom of each tab on columns configuration 11:19 huginn News from kohagit: Bug 25176: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=510ee153c0d0d0bc01ca1abc3cd6aa28a4d0f9ff> 11:19 huginn News from kohagit: Bug 25176: Fix style of checkout form <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8758cffcd2b3573561eda9d28ce45bb920a6978d> 11:20 oleonard Thanks for spam-fighting cait1 11:22 cait feels like i am ont doing much else currently :( 11:25 oleonard Judging by the Bugzilla emails cait, that's definitely not true 11:27 * ashimema[m] makes cait happy.. most of these are hers 11:27 cait davidnind++ Joubu++ ashimema[m]++ :) 11:29 huginn News from kohagit: Bug 13518: Delete patron's modifications along with the patron <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d8dd31142c0bfd9b09f9fa8e02fc292cf9deed2c> 11:29 huginn News from kohagit: Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8218653df75cc61676ce40f2feea70bb5671614b> 11:29 huginn News from kohagit: Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3ba823db6ea9c77e74dcdaa4d3a88f424ea7695d> 11:29 huginn News from kohagit: Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c54654c12944250ed75bbdd011e6ac6cacf58d3f> 11:29 huginn News from kohagit: Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=563120a004f03a96c935b179af36cace874f708c> 11:29 cait oleonard++ too and Marjorie 11:30 cait have to say... having my patches go in still gives me happy feelings :) 11:30 * ashimema[m] wants a longer cycle.. really feels like we have lots more that are teatering no the edge 11:30 ashimema[m] but alas.. I just announced the freeze dates 11:31 oleonard ashimema[m] it's time to declare yourself RM for life and start issuing decrees 11:33 cait heh 11:33 cait i know the feeling 11:33 cait it's always like that 11:33 cait and always hard to see stuff missing the line by just a little bit 11:33 cait but we still got a little bit of time, don't we? 11:33 oleonard ashimema[m]: Leave some stuff for cait to approve when she's RM in the next cycle 11:35 cait not sure you people would like that :) 11:35 * cait goes to stir curry 11:47 ashimema[m] hehe 11:47 ashimema[m] Feature Freeze 1st May 11:48 ashimema[m] so we have 11 days (not including today) 11:50 magnuse cait++ 12:07 * ashimema[m] wouldn't mind at all if cait was RM.. though someone would have big boots to fill as QA Manager 12:14 tcohen morning 12:14 ashimema[m] hey ho 12:38 eythian @later tell eythian testing 12:38 huginn eythian: The operation succeeded. 12:39 huginn News from kohagit: Bug 14229: Remove extra spaces <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=80dc5c36b823be0113ff7b456d17ad81e1da368e> 12:39 huginn News from kohagit: Bug 23349: (follow-up) Correct translation function <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=93fbfcb1bfb420a415c75d850b3eef0dacb2df06> 12:39 huginn News from kohagit: Bug 14229: Add link from patron search results fine to accounting tab in patron account <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2dc31f65aef1357d98c20872eaa9a2a6f3b98beb> 12:39 huginn News from kohagit: Bug 24819: (follow-up) Rename suggestor to suggester <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e5001c5a37f4df02cad9f0490376fc2179aa966b> 12:39 huginn News from kohagit: Bug 25135: Improve clarity and navigation of columns settings administration <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e5870e30de55129b5b1037a00283aa9c6aa4095d> 12:39 huginn News from kohagit: Bug 20484: Allow configuration of ES before switching to ES <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b331d19e8df506991fc1deafc372c27a1554015a> 12:39 huginn News from kohagit: Bug 23349: Add batch operations to staff interface catalog search results <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=743f40a202ba915dccbf35058e5b7ecf707e3e67> 12:39 huginn News from kohagit: Bug 24819: (follow-up) Rename suggestion_search to suggestor_search <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=14783dabbee9817329c50972f18d63cf22b2edf2> 12:39 huginn News from kohagit: Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fa580344912781d8b010f81fab8e1e4298c493e7> 12:40 eythian @seen rangi 12:40 huginn eythian: rangi was last seen in #koha 9 hours, 11 minutes, and 51 seconds ago: <rangi> its is a good way to learn the ropes, then move to oldstable or stable 12:54 cait1 Joubu++ thx for your feedback, will try to respond soon 12:55 cait1 does anyone else see 2 empty lines in the permissions in staff? i thnk it's in accounting 12:55 cait1 could be my database 13:23 oleonard Oh, is Bug 25216 why my XSLT customizations blow up? 13:23 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25216 minor, P5 - low, ---, oleonard, NEW , XSLT can only use HTTP not HTTPS URL. 13:24 oleonard did++ 13:24 oleonard (but don't leave it assigned to me XD ) 13:24 cait1 interesting 13:24 cait1 i guess only applies to remote XSLT? 14:24 cait tcohen: around? 14:24 tcohen sort of 14:24 cait i need a bug consult :) 14:25 cait when you have 5-10 minutes where you can think 14:25 cait i mean focus 14:25 tcohen if you ask me, I can try 14:25 tcohen and answer once I have the answer 14:26 tcohen Javier is demanding at the moment 14:26 cait not time critical 14:33 reiveune bye 16:40 cait Joubu: thx for QA - noticed tons of typos in that ocmmit message, going ot fix it 21:31 tuxayo philor++ 21:31 tuxayo Thanks for the SO of bug 22437 21:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 major, P5 - low, ---, m.de.rooy, Signed Off , Subsequent authority merges in cron may cause biblios to lose authority information 22:07 philor tuxayo: do you happen to remember what your C authority, the one with one linked record, was? 22:07 philor I meant to see whether I could tell what happened there this morning, but forgot all about it 22:25 philor never mind, I can repro with any authid that has one mis-linked bib 22:31 philor a possibly interesting bug, but not that bug, because it's more like "merging mislinked authorities live doesn't change the bib field at all, merging them with the cronjob does" 22:53 talljoy anyone around to help me figure out what "edit the DOM" means? 22:53 talljoy trying to test a patch 22:57 philor without context, I'd expect it to mean "Tools - Web Developer - Inspector, click on some part of the page, then in the inspector window change the whatever and hit enter" 23:13 talljoy thanks! i'm just not having much luck finding the one bit in the inspector that i need. 23:15 talljoy ill keep poking away at it! 23:15 talljoy at least i'm on the right path. :) good to know. 23:22 tuxayo hi philor :) 23:23 philor tuxayo: hello! 23:23 tuxayo > never mind, I can repro with any authid that has one mis-linked bib 23:23 tuxayo Ho, great 23:24 tuxayo > "merging mislinked authorities live doesn't change the bib field at all, merging them with the cronjob does" 23:24 tuxayo Nice catch 23:30 philor I'm hoping marcelr will tell me what I need to file from that, so I moved on to the mis-linking of the sample data, though I haven't yet found where it lives