Time  Nick            Message
01:53 * oleonard-away whispers... Anyone awake?
01:53 hayley          I am!
01:53 oleonard        Hi hayley!
01:53 hayley          hey oleonard!
01:53 wahanui         oleonard is seeing some buggy stuff though
01:54 hayley          you're talking crap wahanui
01:54 lari            jajm: https://wiki.koha-community.org/w/index.php?title=Git_bz_configuration&action=historysubmit&diff=20350&oldid=20322
01:54 lari            this change is not working right for me
01:54 * oleonard      whispers in Haley Joel Osment voice, "I see buggy stuff though"
01:57 lari            jajm: nevermind, it works :) i thought it adds "exec git commit..." in the commit message, but of course it was the interactive rebase screen
01:57 lari            sorry
01:58 lari            4:00AM brain not functioning
01:58 * oleonard      was not aware of the possibility of 4AM brain
02:03 * oleonard      shouldn't be awake either but was curious who was around
02:04 hayley          3pm for me!
02:06 oleonard        The "world clock" on my phone currently shows my time zone, UTC, Marseille, Wellington, and Portland
02:06 oleonard        All the important spots
02:06 hayley          :D
02:07 oleonard        Bodo, Konstanz, etc... Hold a hackfest and maybe you can replace Marseille in the lineup ;)
02:11 * ashimema      is weirdly awake too
02:11 ashimema        I see the USA is no winning the covid race.. well done. 🙃
02:12 ashimema        Bug 22660
02:12 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 enhancement, P5 - low, ---, koha-bugs, NEW , Allow use of CodeMirror for editing HTML in the news editor
06:51 marcelr         hi #koha
06:53 marcelr         anyone for a signoff on bug 24903 ?
06:53 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Special characters like parentheses in numbering pattern cause duplication in recievedlist
06:53 marcelr         serials
07:01 marcelr         Upgrade to 19.12.00.054 done [07:00:32]: Bug 13881 - Add desk management DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'A' at line 2 [for Statement "             ALTER TABLE suggestions ADD CONSTRAINT `suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE
07:01 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 enhancement, P5 - low, ---, nicolas.legrand, Pushed to master , Add desk management
07:21 Joubu           fixed marcelr
07:21 huginn          News from kohagit: Bug 20415: (follow-up) DBRev 19.12.00.056 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=77f481a37b9e97aab7f8db1b7e9215fd0ca5d904>
07:30 marcelr         great Joubu
07:30 marcelr         hi calire
07:32 calire          hi marcelr
07:36 reiveune        hello
07:37 marcelr         hello reiveune
07:43 ashimema        Hmm, did I miss a dB fix.. I did one last night to get Owen going.  But I thought to was only in the bug.. not in master.
07:43 * ashimema      will should check this morning
07:45 Joubu           ashimema: I fixed it
07:46 Joubu           I let you a pm to let you know ;)
07:49 did             hi
07:49 wahanui         hey, did
07:49 Joubu           in 3 we hit bug 25000
07:49 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000 could not be retrieved: InvalidBugId
07:52 did             about reserve table is (found == null and itemnumber == null)  valid ? Same with (branchcode == null) ?
07:53 did             sorry (found == null and itemnumber != null)
08:02 alex_a          Bonjour
08:02 wahanui         niihau, alex_a
08:04 Joubu           did: try again
08:12 did             Joubu: I'm looking  at an issue  with holds and  in reserves  table there's rows where branchcode is null, which doesn't play well with displaying patrons' holds in pro, there's other rows with an itemnumber but found fields is still NULL but in Reserver.pm - 'found : NULL       : means the patron requested the 1st available, and we haven't chosen the item', if itemnumber is not null it's selected , right? so what aboud found?
08:25 Joubu           did: if you have an itemnumber in reserves, that means the hold has been placed at item-level, or the hold has been "found". A hold that is found mean that it is waiting of in transit
08:25 Joubu           you should not have found != null and itemnumber==null
08:25 Joubu           does it answer your question?
08:26 SoniaB          hello kohaers
08:27 Joubu           marcelr: which "messages" are you talking about on bug 24883?
08:27 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 enhancement, P5 - low, ---, jonathan.druart, Passed QA , Command line utility to load yaml files
08:27 Joubu           Salut SoniaB!
08:27 did             Joubu: yep and for branchcode null? thanks.
08:27 marcelr         errors
08:28 Joubu           marcelr: bad usage of the script?
08:28 Joubu           or sql errors?
08:29 marcelr         yaml syntax stuff
08:29 cait1           hm pickup branch
08:29 cait1           hi SoniaB
08:30 * ashimema      finds reserves really confusing..
08:30 ashimema        it's the next area for me to really get to grips with once I've finished working through transfers logic
08:31 ashimema        blimey.. you guys were busy over night..
08:32 ashimema        lots more for me to push again today
08:39 ashimema        incoming
08:39 huginn          News from kohagit: Bug 24988: Default to autorenew_checkouts for new patrons <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a8ea4c1df8b3c325f6c6da4e91d81c1dc1a3943d>
08:39 huginn          News from kohagit: Bug 24964: Fix perl critic warning <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a5576f62ebe2e6b22437312cc130b522e7cd9eae>
08:39 huginn          News from kohagit: Bug 24976: Guided report - "Save" button on last step is misleading <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ed5f3ecc05be45038293588e429d796760476c96>
08:39 huginn          News from kohagit: Bug 24964: Prevent random failures sorting by borrowernumber <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=693d56d0e94a01deb71b1f26d6e9ad848ff7598a>
08:39 huginn          News from kohagit: Bug 24964: Do not filter patrons after they have been fetched <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9a23ba31664b241410d695527583b898992c5705>
08:39 huginn          News from kohagit: Bug 24964: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f1bc7201d71f89adc84ab03d2a3e2447bad873ba>
08:39 huginn          News from kohagit: Bug 24905: Make installer update log4perl.conf for instances <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=70aee86791d17754fa2300c38908ee8049cb7106>
08:39 huginn          News from kohagit: Bug 24905: Add missing entry in log4perl-site.conf.in <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f606ff6bf108c2e70d6698e51e7194759d5151a>
08:40 liliputech_asu  hi koha
08:53 ashimema        incoming
08:54 huginn          News from kohagit: Bug 24475: Cronjobs don't always live in misc <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2611789b1ffad7be201cad50cff263428f688e53>
08:54 huginn          News from kohagit: Bug 24475: Reword FinesMode system preference <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c923f2f622b39bd2345561a7c8c74f30db61daf4>
08:54 huginn          News from kohagit: Bug 20648: Attribute option 'Display in check-out' should be renamed <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=11a91d6e0cde1711c51a771a2aa38abf761f7114>
08:54 huginn          News from kohagit: Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dcc93816914d467191481542f318c1c8ca415105>
08:54 huginn          News from kohagit: Bug 22001: Remove the RaiseError occurrences from tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2849b188c885bb6752e9e5c7db381e291ed4bb30>
08:54 huginn          News from kohagit: Bug 22001: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=46ecd9def51f2bb48f962d2492cddfc567bc2162>
08:54 huginn          News from kohagit: Bug 22001: Enable RaiseError for tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=600217eb69abf8218b68c32b8eaca223c87ceec3>
08:54 ashimema        and breath...
08:55 ashimema        I'll hold off now until Jenkins is happy.. 22001 is the one I suspect to throw issues if any do
08:56 * ashimema      gets back to working on bug 24446
08:56 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 enhancement, P5 - low, ---, martin.renvoize, NEW , Stockrotation: Update to use daterequested in branchtransfers
08:57 * ashimema      thinks he's going to combine that with bug 23092
08:57 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Transfers should record 'requested' as well as  'sent' and 'arrived' dates.
09:15 marcelr         ashimema: I rebased 21190; two months waiting for qa
09:16 ashimema        bug 21190
09:16 wahanui         bug 21190 is ready for my signoff :)
09:16 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 enhancement, P2, ---, m.de.rooy, Signed Off , GDPR: Log successful/unsuccessful login attempts [part 1]
09:16 ashimema        OK.. will take a look
09:22 ashimema        bug 7902
09:22 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7902 enhancement, P5 - low, ---, cnighswonger, CLOSED FIXED, Adding Function to Check for Existence of Tables
09:23 ashimema        @seen mtj
09:23 huginn          ashimema: mtj was last seen in #koha 3 weeks, 3 days, 21 hours, 38 minutes, and 2 seconds ago: <mtj> ..a good way to spot problematic upstream perl modules, before they hit debian stable
09:24 ashimema        hope he's OK..
10:01 nlegrand        a gut yor
10:03 * cait          waves
10:15 ashimema        to be fair.. there are some much older bugs in the QA queue marcelr.. I know it's annoying
10:15 ashimema        I'll try to find someone to take a look of course
10:16 Joubu           ashimema: I take it
10:16 ashimema        Thanks Joubu :)
10:16 ashimema        82 in the NQA queue.. that's the best we've been in ages I think.
10:16 ashimema        but still high :(
10:18 * ashimema      will attempt to tackle a bunch of the accounts related ones as that's an area I'm currently pretty expert in :).. Hadn't spotted there were a few
10:19 cait            yeah still high
10:19 cait            i'd be appy if you took a look at the accounts ones
10:19 cait            esspecially how they play with other recent changes
10:27 ashimema        :)
10:27 fridolin        hi there
10:28 ashimema        bug 19036 is a nice one which I can't QA however ;)
10:28 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 enhancement, P5 - low, ---, julian.maurice, Signed Off , Number payment receipts / payment slips
10:28 ashimema        but it's also pretty recently SO'd so not especially high in the queue if you go in date order
10:28 * ashimema      wants all the things :)
10:29 * cait          too
10:29 ashimema        I'm looking into the current Jenkins failures btw Joubu
10:29 ashimema        before we clash again ;)
11:14 ashimema        Joubu, followup attached to bug 22001
11:14 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , RaiseError and PrintError flags must be set for tests
11:14 ashimema        wouldn't mind a second pair of eyes before I push it ;)
11:15 Joubu           will do ashimema
11:18 Joubu           ashimema: I think local could have done the trick: local $dbh->{RaiseError} = 1;
11:18 Joubu           = 0 I mean
11:19 ashimema        I just tried to clone what you had done above
11:19 ashimema        But happy to switch
11:22 tcohen          morning
11:25 cait            do we have a script to fix items mappings?
11:25 fridolin        tcohen: ola
11:25 fridolin        tuxayo yey are you there ?
11:25 cait            i got a case where homebranch holdingbranch mappings were lost
11:25 cait            so it stored in more_subfields_xml
11:25 fridolin        tuxayo[m]: cc
11:26 cait            and wonder if there is a good way to undo that
11:26 fridolin        cait: oh hugly, i think using SQL with where extractvalue() will do it
11:26 fridolin        one query per branchcode
11:28 ashimema        hmm.. OK.. not sure I understand where you're thinking of adding local RaiseError's Joubu
11:28 ashimema        my brain seems t be slow today :(
11:30 fridolin        cait:  or maybe : update items set homebranch=extractvalue(more_subfields_xml, "//datafield/subfield[@code='a']") where homebranch is NULL
11:31 ashimema        OK.. brain has rebooted..
11:31 ashimema        I know what you mean now Joubu!
11:31 cait            fridolin: yeah i was thinking along these lines too
11:31 cait            get the columsn filled from more_subfields_xml, fix frameworks... restart everything and maybe clean_up more_subfields_xml?
11:32 cait            no sure if it it will clean up itself if you resave the items
11:32 cait            thankfull not one of ours
11:33 huginn          News from kohagit: Bug 22001: (RM follow-up) Allow RaiseError tests in Reports/Guided.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bb637c825bfc81066f430d5f396480bab87d531c>
11:33 Joubu           I attached an alternative patch
11:33 Joubu           not strongly attached to it, do whatever you want
11:34 tcohen          amoyano feliz cumpleaños!
11:35 ashimema        :)
11:35 ashimema        all sorted :)
11:35 ashimema        thanks
11:35 Joubu           ha, was too slow
11:36 fridolin        cait: yep in order to clean more_subfields_xml run misc/batchRebuildItemsTables.pl
11:36 ashimema        no worries..
11:36 ashimema        my brain rebooted and I worked it out..
11:36 Joubu           [off] kidclamp is annoying me in private to QA all his patches
11:36 ashimema        we pretty much made the same thing
11:37 kidclamp        [off] Joubu is assigning me all the bugs he doesn't want, seems fair
11:37 kidclamp        Joubu++
11:37 cait            amoyano: Alles Gute zum Geburtstag!
11:37 ashimema        [off] makes a change.. it's usually me annoying him to QA all your patches :P
11:37 Joubu           kidclamp++
11:37 Joubu           I'll take you one more after the patches
11:37 cait            kidclamp: , Joubu - glad you guys get along so well :)
11:38 cait            about to hopefully switch to QA - fingers crossed
11:42 ashimema        Joubu...
11:42 wahanui         joubu is, like, kidding, right ;)
11:43 ashimema        bug 24765.. are we allowing calls to JS native function `toLocalDateString()`
11:43 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765 major, P5 - low, ---, kyle, Passed QA , Updated on date in Claims returned starts off as 01/01/1970
11:45 ashimema        That has a code smell to me.. we should consistently use our sysprefs for date display (or consistently use browser locale).. but it feels wrong to have a mixture (even though I believe they should match in the majority of cases)
11:46 Joubu           ashimema: yes, but that was for another bug
11:47 Joubu           I also opened bug 24999
11:47 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 normal, P5 - low, ---, koha-bugs, NEW , Date not correctly formatted in claims table
11:47 ashimema        aha..
11:47 ashimema        so you also spotted that
11:47 ashimema        brill
11:47 ashimema        thanks
11:48 Joubu           ashimema: there is that one, and another that is not formatted at all
11:57 amoyano         Thanks cait and tcohen
11:57 * cait          is waiting for the rest to figure it out :)
12:00 Joubu           ¡Feliz cumple amoyano! :)
12:01 * ashimema      is looking for the incipits for that famous song...
12:02 oleonard        Hi all
12:07 ashimema        С Днем Рождения amoyano
12:08 * ashimema      liked the idea of Plaine & Easie (as amoyano wrote the patch).. but my brain isn't clever enough to work that out :(
12:09 cait            i think you probably need something to convert
12:09 cait            the notation
12:09 cait            ashimema: russian, nice :)
12:10 * ashimema      has a mother who speaks russian (and we have russian clients)
12:10 amoyano         Thanks joubu and ashimema!.. my first birthday in Koha
12:10 ashimema        very little of it roubed off though
12:19 oleonard        Man I sure hope Bugzilla survives all these "hacks" :P
12:24 ashimema        i n c o m i n g . . .
12:30 cait            lol
12:30 * cait          waits for it
12:31 ashimema        my push hook found that I'd missed a DB update
12:31 ashimema        woopsie
12:31 enkidu          We created a bug for that
12:31 enkidu          Bug 25000
12:31 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000 blocker, P5 - low, ---, kohadevinim, Needs Signoff , SQL report not updated
12:31 enkidu          and the patch is coming
12:32 enkidu          Patch ready.
12:33 huginn          News from kohagit: Bug 23204: DBRev 19.12.00.060 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e684fac28dee49184339a05b9372d9152c1955a9>
12:33 huginn          News from kohagit: Bug 18177: DBRev 19.12.00.059 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a444f643ad10a1e77edbe65543429059fdcd6539>
12:33 huginn          News from kohagit: Bug 23473: (QA follow-up) Fix number of tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b4eb87483f4f04ed57fd70221de6b8e762d98b2>
12:33 huginn          News from kohagit: Bug 18177: Do not remove columns if at least one value exists <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f50fee2546c8a97da9654e7de79f6f09bafb579b>
12:33 huginn          News from kohagit: Bug 18177: DBIC changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=57788803e0e13b7cceb30665666f0e77c2e97fa2>
12:33 huginn          News from kohagit: Bug 18177: remove aqbooksellers.currency <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=93ed21862a667f24159ec51c71f049fec5848d6b>
12:33 huginn          News from kohagit: Bug 18177: DB changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=287416fcad8deed10601b1e45b561bfc6f12724e>
12:33 huginn          News from kohagit: Bug 18177: remove aqbooksellers.bookselleremail <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=607049246275e00a0ecd4721e8ed8688424c2dce>
12:33 huginn          News from kohagit: Bug 18177: remove aqbooksellers.booksellerurl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a961487d65dce0d6c49757834f9fd642490f119b>
12:33 huginn          News from kohagit: Bug 18177: remove aqbooksellers.booksellerfax <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0d9ff747a221eb53769982f36894c755757a1491>
12:33 huginn          News from kohagit: Bug 18177: remove aqbooksellers.othersupplier <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b1122cf0f3e1b242a94b4feaca1ff0596d117585>
12:33 huginn          News from kohagit: Bug 23888: (follow-up) Wrap English string in translation function <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=97913b8a648b607401a45b15525914f5e1d4d209>
12:33 huginn          News from kohagit: Bug 23473: (follow-up) Fix QA complaints (tabs, filters, Dumper) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=68776ef2e685fa7f4dc6f38769a28e48b56af621>
12:33 huginn          News from kohagit: Bug 23473: Don't allow staff password changes for imports <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=214d78309d6452da82054fe6a481548ae48084d7>
12:33 huginn          News from kohagit: Bug 23473: Don't allow setting blank passwords via import <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9a6134710d6651d0594c1b2eaaec59024bb37aea>
12:33 huginn          News from kohagit: Bug 23888: Do not allow invalid vendor id on creating a subscription <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c52e15689f123faa083626d725420def07dbfdc5>
12:33 huginn          News from kohagit: Bug 23473: (follow-up) Catch and show password exceptions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8c7ae857a286a2b73573f6f216eedfb90ea46753>
12:33 huginn          News from kohagit: Bug 23473: (follow-up) check if overwrite_passwords is set <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=481bc59de55432aca4c63ef9bd0ad53f72ecf5d7>
12:33 huginn          News from kohagit: Bug 23473: (follow-up) Make passwords 'secure' for tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4c6517d05b6dbbced1a4c27ed2bc7ee3f515cc7a>
12:33 huginn          News from kohagit: Bug 23473: Allow overwrite of passwords during import <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6464ada6c6801ab9a10d7a64154212ba30428ab9>
12:34 oleonard        There it is
12:35 enkidu          We've just created 25000th bug, :-D
12:36 enkidu          What a big community
12:36 ashimema        We've pushed bug 25000 :)
12:36 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000 blocker, P5 - low, ---, kohadevinim, Pushed to master , SQL report not updated
12:36 ashimema        thanks for the fast fix.. can't believe I missed that! :(
12:38 enkidu          thanks ashimema. your and other friends's works are wonderful
12:39 * oleonard      sits in his rocking chair and regales the children with tales of Bug 1000
12:39 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1000 enhancement, P2, ---, gmcharlt, CLOSED INVALID, installer: drop/suppress entries in mysql if re-launching installer script
12:40 oleonard        Not a great story in retrospect. Will punch it up next time.
12:41 ashimema        lol
12:42 amoyano         oleonard: lol
12:43 oleonard        If Ol' Grampa Rangi were here I guess he could tell us of Bug 1!
12:43 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 major, P2, ---, chris, CLOSED FIXED, Missing uploadedmarc table definition
12:43 huginn          News from kohagit: Bug 25000: SQL report not updated <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2cf5ae07f1751303830209f278b943d25e8750cb>
12:44 oleonard        It's the last day of Hackfest and everyone is catching their flights out of Marseille but if anyone is not too sad y'all could test a trivial patch: Bug 24996
12:44 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 minor, P5 - low, ---, oleonard, Needs Signoff , Unwanted CSS change unhides OPAC results sorting button
12:50 cait            :)
12:56 kidclamp        oleonard, can you check, does checking the  boxes for search results enable the 'Place hold' button for you on the opac?
13:00 oleonard        Computer decided to auto-sleep while I was literally typing. Cool cool cool.
13:01 corilynn        lol
13:01 oleonard        kidclamp: No. Sad-face.
13:01 corilynn        "I'm working here"
13:02 * cait          can understand computer
13:03 ashimema        Oh dears...
13:05 Joubu           @later tell enkidu how did you find bug 25000 so fast?? Thanks for the fix
13:05 huginn          Joubu: The operation succeeded.
13:08 * ashimema      just re-read his comment on bug 24980 and isn't sure if it clarifies anything
13:08 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 major, P5 - low, ---, agustinmoyano, Signed Off , Date formatting from JS - use timezone only with dates with offset
13:08 cait            tcohen: would you be able to QA bug 17268?
13:08 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 normal, P5 - low, ---, nick, Signed Off , Advanced cataloging editor - rancor - macros are lost when browser storage cleared
13:09 cait            bug 25000
13:09 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000 blocker, P5 - low, ---, kohadevinim, Pushed to master , SQL report not updated
13:09 tcohen          cait I have just proposed a different path for the API on the RFC
13:09 tcohen          need to talk to kidclamp
13:09 tcohen          about it
13:09 cait            ok to add you QA contact?
13:10 cait            it would be a really useful addition to the editor
13:13 * cait          just did it
13:23 ashimema        Did I imagine a bug that renamed the 'News' tool?
13:25 oleonard        I saw a comment about it on another bug, but I don't think there's a new bug
13:25 ashimema        ah, ok..
13:25 ashimema        I though there was one..
13:26 oleonard        [off] I remember the comment because I thought, "If you think it should be renamed why not file a new bug?"
13:27 * oleonard      agrees it should be renamed
13:28 ashimema        hehe
13:28 ashimema        agreed
13:28 ashimema        I thought I'd seen such a bug.. but can't find it now
13:28 ashimema        filing
13:30 ashimema        bug 25001
13:30 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001 enhancement, P5 - low, ---, koha-bugs, NEW , 'News' should be renamed now we are migrating other content blocks to it
13:31 * ashimema      pokes that at David (PTFS-E).. sure he'll like that one :)
13:31 * oleonard      bbl
13:33 ashimema        Joubu when you get a moment.. I can't work out why the RaiseError test is failing.. I can't replicate it here
13:33 ashimema        hugs
13:34 cait            25001 hm wondering if that is a duplicate
13:35 cait            i thought we already had a rename suggestion somehwere but i think it was on one of the other bugs - never mind!
13:36 ashimema        I thought similar cait.. but I couldn't find one
13:37 cait            24963 might also be a good one
13:37 cait            bug 24963
13:37 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963 trivial, P5 - low, ---, oleonard, NEW , Terminology: auto renewal, auto-renewal or autorenewal?
13:37 cait            we got 2 clear votes for auto-renewal at the moment
13:56 * amoyano       thinks ashimema's comment on bug 24980 is clear enough
13:56 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 major, P5 - low, ---, agustinmoyano, Signed Off , Date formatting from JS - use timezone only with dates with offset
13:58 ashimema        The core thing is we want the time to always behave as set in the config.. we never want to allow the browser to override it... that sums it up I think
13:58 ashimema        that's your understanding too right amoyano
14:16 cait            did i miss code spaghetti start?
14:16 ashimema        45 mins time
14:16 cait            oh
14:16 cait            so the time converter tricked me :)
14:22 magnuse         what's that about? how to cook spaghetti with code?
14:23 * ashimema      is looking forward to seeing
14:24 cait            live bug squashing i think
14:24 cait            check the trello :)
14:25 ashimema        kidclamp and khall getting jiggy with code
14:34 oleonard        My doctor has advised me that at my age I should refrain from getting jiggy with code
14:35 * oleonard      ignores them
14:35 * magnuse       has to make pizza anyway - have fun #koha, take care!
14:40 fridolin        seeee u
14:40 fridolin        pizza++
14:46 jzairo          we are getting ready to launch in about 10 minutes https://www.youtube.com/user/bywatersolutions/live
15:38 caroline        Do you guys know if the fines.pl script stop calculating fines after a certain amount of days overdue?
15:39 caroline        I'm trying to calculate fines on migrated data and a person has an item overdue since 2017 (!!) and the fines are not calculating
15:39 huginn          News from kohagit: Bug 23204: Fix tests swapping fields (they are not ordered) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7d8ddfb675e4dba64d7b2e6ec6348ace0f9aa4e3>
15:40 caroline        I'm thinking it's maybe the maxfinesdays argument, but the script is not very explicit (for us non-devs) as to what this argument actually does
15:41 reiveune        bye
15:41 AndrewFH        @caroline that's how I'd read that script, too. maxdays could set a limit. but it doesn't look like there's a default value if you don't set one explicitly
15:41 ashimema[m]     caroline
15:41 wahanui         it has been said that caroline is off the grid
15:41 huginn          AndrewFH: I'll give you the answer as soon as RDA is ready
15:41 wahanui         i already had it that way, huginn.
15:41 ashimema[m]     I actally just added an option for that
15:44 kidclamp        https://snipboard.io/2zEf5i.jpg
15:44 ashimema[m]     bug 24651
15:44 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 enhancement, P5 - low, ---, martin.renvoize, RESOLVED FIXED, Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines.
15:44 ashimema[m]     caroline ^
15:44 caroline        just reading the title, it seems to do the opposite of what I want
15:45 * oleonard      wonders to what extent he should heckle kidclamp's in the live stream
15:45 ashimema[m]     maxfinesdays is how many days a fine will keep accruing for (it's an alternative to a max fines cap)
15:45 kidclamp        to the extreme
15:45 ashimema[m]     the --maxdays option on the command line will prevent the fines.pl script from picking all overdues since the beggining of time.
15:45 ashimema[m]     so you kinda use them in tandem
15:46 caroline        but that's what I want to have all the fines from the beginning of tme
15:46 ashimema[m]     oh.. ok
15:46 ashimema[m]     I thought you meant the script was taking forever to run.. or dieing
15:46 ashimema[m]     ok.. so don't use --maxdays
15:46 caroline        Right now, this person who has overdues since 3 years has no fines
15:46 ashimema[m]     and it should run to the beggining of time
15:46 oleonard        kidclamp: git bisect suggests a different solution to Bug 25004
15:46 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 normal, P5 - low, ---, oleonard, Needs Signoff , Search results place hold button not enabled when checking result checkboxes on opac-search.pl
15:47 ashimema[m]     but could take a while if you have lots and lots of overdues
15:47 kidclamp        can you comment on the bug Owen?
15:47 oleonard        Yes
15:47 kidclamp        oleonard that is
15:47 caroline        even if I run fines with no argument, they don't get fined... so weird... I thought maybe there was a maxdays default
15:49 caroline        I wonder if it's because the person's patron category is onw that is restricted to no loans
15:49 ashimema[m]     pass
15:49 caroline        I still put fines in the circ rule, I though that was the problem
15:50 caroline        I'll try it again... maybe I was too tired last night when I tried this
15:50 huginn          News from kohagit: Bug 18177: (follow-up) remove aqbooksellers.currency <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ff19fd48060aee94eb98ae5e0ae883c86f81475a>
15:55 liliputech_asu  have a nice weekend, we'll be missing one hour here in france (just around apero time, what a shame...)
16:07 oleonard        kidclamp++
16:07 oleonard        khall++
16:07 oleonard        jzairo++
16:07 oleonard        AndrewFH++
16:07 kidclamp        oleonard++
16:07 oleonard        Good spaghetti!
16:08 ashimema[m]     that was great guys :)
16:08 ashimema[m]     kidclamp++
16:08 * oleonard      viciously shoots down both your patches
16:08 ashimema[m]     khall++
16:08 ashimema[m]     jzairo++
16:09 cait            kidclamp++ oleonard++ khall++ heather++ jzairo++ i am sure i forgot someone!
16:09 cait            AndrewFH++
16:13 jzairo          thank you everyone - Here is a link to the recording https://bywatersolutions.com/education/koha-virtual-hackfest-code-spaghetti
16:16 * ashimema[m]   needs to learn how to host such a stream.. we've been meaning to do it for ages with our customers and I'd hoped to run one this week
16:16 ashimema[m]     time got away from me.. as ever
16:18 huginn          News from kohagit: Bug 24614: Fix Reports/Guided.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=624a24b8203624d94cbe0efdb37106065cf6cd92>
16:19 cait            lisettelatah++ !
16:19 ashimema[m]     :)
16:20 * ashimema[m]   goes to grab some tea :)
18:02 oleonard        I've definitely got last-day-of-hackfest brain today
20:58 tcohen          does it make sense that opac-showmarc.pl allows passing an importid?
20:58 tcohen          it seems like a leakage
21:49 cait            importid?
21:56 tcohen          cait 25009
21:57 cait            bug 25009
21:57 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25009 is not accessible.
21:58 tcohen          pm