Time  Nick          Message
01:12 alexbuckley   does anyone know if we can see if an xslt file has been picked up? the record detail page's custom xslt is not displaying and the path in the system preference looks right
01:13 alexbuckley   for example in the network tab we can't see it and in all of the logs we cannot see it
07:10 * magnuse     waves
07:13 ashimema[m]   Did you just upgrade alexbuckley.. there and xslt girl loading security bug in the recent maint releases
07:19 magnuse       autocorrect++
07:25 marcelr       hi #koha
07:37 reiveune      hello
07:49 ashimema[m]   Lol.. silly autocorrect
07:54 eythian       hi
08:04 magnuse       o/
08:07 cait          morning all
08:08 marcelr       hi cait
08:09 cait          hi marcelr
08:39 ashimema[m]   bet dcook isn't around?
08:39 ashimema[m]   bit late I reckon
08:40 marcelr       ashimema[m]: i recommend bug 24052 for this version
08:40 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Housekeeping for bug 23290 (follow-up)
08:40 marcelr       xslt cleanup
08:40 ashimema[m]   Awesome, thanks for the quick follow-up marcelr..
08:41 ashimema[m]   I'll take a look this morning
08:41 ashimema[m]   Just trying to work out how to get dcooks netmask tests to pass on D10..
08:41 marcelr       ok
08:42 ashimema[m]   They assume an older version of netmask which doesn't support IPv6.... But buster ships the shiny new version that does have support. 😀
08:42 marcelr       dependencies are fun
08:42 ashimema[m]   D10 is soooo close now.. I can feel it. 😀
08:42 ashimema[m]   Indeed they are
08:43 ashimema[m]   I added an extra Jenkins job yesterday.. should help us catch dependency issues much earlier.. runs twice a month and basically pulls all dependancies directly from cpan so we get the latest and greatest of everything before throwing the test suit at it.
08:44 ashimema[m]   Hopefully it'll mean we catch things much earlier.
08:44 marcelr       cool
08:45 ashimema[m]   Also looking to do the same sort of thing with the coverage variable.. twice a month.. right now we have to add it manually and that doesn't happen very often so we don't spot test coverage trends..
08:45 koha-jenkins  Project Koha_Master_D10_Deps build #2: STILL FAILING in 10 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/2/
08:45 ashimema[m]   I think we may have reduced very slightly this cycle.. I've been a little more lenient.. perhaps unduly
08:50 Joubu         ashimema[m]: the idea was to run the coverage once per release, then keep the build result to have the nice graph
08:51 Joubu         the one we kept is from May 2019
08:52 Joubu         a build with coverage takes around 4h :-/
08:54 ashimema[m]   Indeed.. Jenkins allows scheduled builds though.. for the deps one I scheduled it to run twice a month at a random hour overnight on the two days I picked..
08:55 ashimema[m]   I'm thinking to do something similar for coverage.. to save us having to remover to run it once a cycle
09:21 ashimema[m]   marcelr.. did I miss something in the XSLT bug..
09:21 ashimema[m]   not sure why the tests are failing.
09:21 marcelr       what error ?
09:22 marcelr       the second patch btw fixes an error in testing
09:22 * ashimema[m] sent a long message:  < https://matrix.org/_matrix/media/r0/download/matrix.org/VZHMCAYlktbMZuZBzmmylUqX >
09:23 marcelr       Might D8 be the reason?
09:23 ashimema[m]   being on debian 8 you mean
09:23 ashimema[m]   could be
09:24 marcelr       runs with me under D9
09:24 ashimema[m]   18 is also failing though
09:24 ashimema[m]   :(
09:24 ashimema[m]   same tets
09:24 * ashimema[m] runs up a D8 docker
09:25 ashimema[m]   intersetingly though.. the squashed patch you did for the rmaints seems to have worked cleanly for them
09:25 ashimema[m]   no failure on their branches
09:26 marcelr       thats weird
09:26 marcelr       ashimema[m]: i will have a further look
09:26 ashimema[m]   thanks
09:26 ashimema[m]   hopefully it's something obvious.. I'm sure it all passed locally when I tried it way back
09:29 ashimema[m]   I'm going to trigger a build.. see if it was a random failure
09:29 ashimema[m]   it just passed for me on D8 locally
09:29 marcelr       random failures are even worse
09:29 ashimema[m]   yeah..
09:29 ashimema[m]   I thought it was consistently failing.. sure I've run it twice on Jenkins already..
09:30 ashimema[m]   but as it just passed perfectly on a local koha-testing-docker I'm starting to doubt myself
09:30 ashimema[m]   Only difference I can think of is I ran just that test.. jenkins obviously runs them all
09:30 marcelr       no configuration differences?
09:30 ashimema[m]   literaly just started up a koha-testing-docker to run it
09:31 ashimema[m]   so no.. exact same configs
09:32 marcelr       interesting, i will do some further testing too
09:33 ashimema[m]   thanks
09:42 Joubu         @later tell oleonard What are your thoughts about 18127 (see comment 6)?
09:42 huginn        Joubu: The operation succeeded.
09:42 ashimema[m]   bug 18127
09:42 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 enhancement, P5 - low, ---, aleisha, Needs Signoff , Add batch modified records to an existing list
09:43 Joubu         @later tell oleonard second point only
09:43 huginn        Joubu: The operation succeeded.
10:09 koha-jenkins  Yippee, build fixed!
10:09 koha-jenkins  Project Koha_Master_D8 build #719: FIXED in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D8/719/
10:20 koha-jenkins  Project Koha_Master_U18 build #640: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U18/640/
10:44 marcelr       ashimema[m]: D8 didnt fail..
10:44 ashimema[m]   indeed.. the re-run just passed on Jenkins
10:44 marcelr       but U18 did..
10:44 ashimema[m]   we'll wait and see if it's a rucurrent random failure
10:45 ashimema[m]   for U18 it did your right..
10:45 ashimema[m]   so that's twice in a row..
10:45 ashimema[m]   but.. on my local run.. it passed on U19
10:45 ashimema[m]   * but.. on my local run.. it passed on U18
10:45 ashimema[m]   grr
11:31 paxed         someone should write automated script to go through all the "Needs SO" bugs, check that the patch applies, and if it doesn't, set bug state and post a comment with the error.
11:41 koha-jenkins  Project Koha_Master_U18 build #641: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U18/641/
11:59 ashimema[m]   already exists paxed
12:00 ashimema[m]   it was disabled because it created enormous amounts of noise for people
12:00 ashimema[m]   and doesn't actually help reflect if a bug is active or not
12:04 paxed         okay
12:08 paxed         although, if the bug was last changed a year or two ago, i wouldn't classify it as active.
12:09 cait          paxed: we had that - the auto-apply check, but people wanted it turned off again
12:09 cait          only wanting to rebase when someone actually wants to test... kind of a hen and egg issue
12:11 ashimema[m]   indeed
12:12 ashimema[m]   the bug may 'become active', if you go to test it and find it doesnt apply..
12:12 ashimema[m]   the act of marking it doesn't apply gets the authors attention to say someone is interested in testing it
12:12 ashimema[m]   hard call which way round is most annoying
12:23 enkidu        Joubu and ashimema[m], thanks for your quick response for yesterday bug.
12:31 oleonard      Hi #koha
12:38 ashimema[m]   no worries enkidu
12:40 enkidu        Hi all, is there any quick way making kohadevbox up-to-date other than using git fetch and git checkout origin/master?
12:45 oleonard      @later tell Joubu There may be a better way to design the final step of Bug 18127 but I don't think it should hold up the bug
12:45 huginn        oleonard: The operation succeeded.
13:16 Guest17586    How can I install Koha on Cpanel
13:19 oleonard      Anyone else find that they can't edit news items?
13:23 oleonard      Guest17586: Koha is not designed to be installed via Cpanel
13:26 oleonard      Anyone else find that they are here in #koha?
13:30 marcelr       oleonard: i can edit news items ;)
13:31 oleonard      :/
13:31 oleonard      Thanks for checking marcelr
13:31 marcelr       even opacheader after restarting plack
13:33 marcelr       oleonard: just noticing now that the regular news editor kills my html tags when I am not alert
13:34 marcelr       it creates one big <p> where I had several tags
13:34 marcelr       need to save under Source code
13:35 oleonard      Very Wordpress-like ;)
13:35 marcelr       o no
13:36 marcelr       i liked the older one ouch
13:39 tcohen        hola #koha
13:39 marcelr       hola tcohen
13:39 marcelr       com esta
13:39 tcohen        muy bien, sleepy
13:39 tcohen        just got back from vacation
13:40 marcelr       you should not be sleepy then :)
13:48 tcohen        it was a long series of flights, with two small kids
13:48 tcohen        :-D
13:49 marcelr       :)
13:51 oleonard      Okay, update: I can't edit a news item if there isn't a value in the "Appear in position" field.
13:51 marcelr       sql mode ?
13:52 marcelr       strict stumles over a non integer ?
13:52 marcelr       b
13:52 pastebot      "oleonard" at 127.0.0.1 pasted "Error when saving news item with no value defined for number field" (1 line) at http://paste.koha-community.org/18852
13:52 marcelr       yeah seems like it
13:52 marcelr       set strict to 0 :)
13:52 marcelr       or change the code ;)
13:53 oleonard      I'll add that to the manual, "change the code." :P
13:53 marcelr       it would be a nice addition
13:57 koha-jenkins  Project Koha_Master_D10_Deps build #3: NOW UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/3/
14:00 cait          file a bug and temporarily remove the strict?
14:00 oleonard      Bug 24742
14:00 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24742 normal, P5 - low, ---, koha-bugs, NEW , Can't save news item in strict mode without value in number field
14:09 koha-jenkins  Project Koha_Master_D10_Deps build #4: FAILURE in 12 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/4/
14:33 eythian       http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=0e7f7ab051c8a23705ea802005f15877ca40d16f five years huh
14:34 ashimema[m]   aww.. it's only a babe ;)
14:38 cait          eythian: your toddler is in Koha now :)
14:38 eythian       haha
14:50 eythian       @later tell cait https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567#c38 "5) Wahttps://perldoc.perl.org/perlpodspec.html#Pod-Formatting-Codess the C intentional?" please refer to https://perldoc.perl.org/perlpodspec.html#Pod-Formatting-Codes :)
14:50 huginn        eythian: The operation succeeded.
14:50 huginn        Bug 14567: enhancement, P5 - low, ---, nick, Pushed to master , Browse interface for OPAC
14:51 eythian       @later tell cait https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567#c38 "5) Was the C intentional?" please refer to https://perldoc.perl.org/perlpodspec.html#Pod-Formatting-Codes :)  [fixed version]
14:51 huginn        eythian: The operation succeeded.
14:51 huginn        Bug 14567: enhancement, P5 - low, ---, nick, Pushed to master , Browse interface for OPAC
15:29 talljoy       good morning!
15:29 oleonard      Hi talljoy
15:30 talljoy       hi owen!
16:00 sociales      delete password at opac koha login which file modify, thanks
16:06 oleonard      sociales: Can you explain more?
16:09 sociales      be able to enter only with the user disable the password
16:09 tcohen        por qué querrías hacer eso?
16:09 reiveune      bye
16:14 sociales      tcohen  facilidad
16:36 pastebot      "oleonard" at 127.0.0.1 pasted "Would this be the correct way to return false if no news items were found?" (11 lines) at http://paste.koha-community.org/18853
16:38 oleonard      ^^ Perl baby question please don't yell at me
16:39 ashimema[m]   erm
16:39 ashimema[m]   sort of depends on what's looking at it
16:40 ashimema[m]   return; will return the value of whatever was returned from the last function..
16:40 oleonard      ashimema[m]: Looking at Koha/Template/Plugin/KohaNews.pm
16:40 oleonard      In the template: [% SET OpacHeader = KohaNews.get(...
16:41 oleonard      Even if there are no news items in that category "OpacHeader" evaluates as true.
16:41 oleonard      It should not.
16:43 ashimema[m]   I take it there's then something like `[% IF OpacHeader`
16:43 oleonard      Right
16:45 ashimema[m]   `The number 0, the strings '0' and '', the empty list "()", and "undef"
16:45 ashimema[m]   are all false in a boolean context. All other values are true.`
16:45 ashimema[m]   so I'd perhaps explicitly return one of those
16:46 ashimema[m]   or
16:46 ashimema[m]   check on OpacHeader.content in the template instead.. as that should be empty as such false.
16:47 oleonard      I started coming at the issue from the KohaNews.pm side when I saw that OpacHeader.size evaluated to "3"
16:49 ashimema[m]   .size in that case is the number of keys in the hashref you are returning
16:49 ashimema[m]   you could do OpacHeader.content.size probably
16:49 ashimema[m]   content is an arrayref inside the hashref by the looks
16:50 ashimema[m]   perl is a pain for this sort of thing ;)
16:50 ashimema[m]   you are not alone finding it confusing ;)
16:50 oleonard      But in terms of returning sensible data would you agree that returning undef would make more sense?
16:53 oleonard      ...rather than digging through an empty data structure of some kind
17:22 oleonard      Haha, "# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s)."
17:23 oleonard      I guess I'll go with 0
19:02 talljoy       oleonard do you know of a way to use printcss on the holds queue for printing?  we have a site that wants a 'pretty' holds queue printout.
19:04 oleonard      You can use a media query in custom CSS to specify it for print only : https://joshuawinn.com/css-print-media-query/
19:04 oleonard      Does that sound like what you're looking for?
19:06 talljoy       that won't work for the datatables 'printy thingy' according to khall
19:07 oleonard      So the question is how to target CSS at the DataTables print view
19:07 khall         https://datatables.net/extensions/buttons/examples/print/customisation.html
19:08 khall         the datatable is already a var, `var holdst = KohaTable("holdst", {`
19:09 khall         so the question is, is there a js way to modify the print button's 'customize' property
19:09 khall         which is actually a callback function
19:11 oleonard      khall: I don't know off the top of my head. One of the disadvantages of the KohaTable wrapper is that it can make stuff like that harder to get to
21:46 corilynn      anyone around to talk about a REALLY BIZZARE Z39.50 issue?
21:49 corilynn      bizarre searching, in Koha...
22:09 Pit-Work      corilynn, Thanks again for your help last week!
22:09 Pit-Work      creating that table in virtual shelves did the trick
22:09 corilynn      oh, you're welcome! Did you get it all working?
22:09 corilynn      fantastic
22:10 Pit-Work      yup literairly as soon as i figured out how to get the lines from install file for msql table creation into command line msql input
22:10 Pit-Work      worked like a charm no restart needed
22:10 Pit-Work      no reindexing, just straight up worked :D
22:10 corilynn      yeah, i wouldn't think it'd need a restart
22:10 Pit-Work      was really happy
22:10 corilynn      sweetness
22:11 corilynn      walked out of here and onto a plane to San Francisco this weekend, so my husband was being impatient
22:11 Pit-Work      hah i bet
22:11 Pit-Work      i would be too
22:11 Pit-Work      i got itw orking literairly 10 minutes after you pasted the code and signed off
22:11 corilynn      nice
22:12 corilynn      Bug 24752 - Z39.50 not returning full MARC record (in case anyone has any idea...)
22:12 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24752 enhancement, P5 - low, ---, koha-bugs, NEW , Z39.50 not returning full MARC record
22:13 Pit-Work      i just feel sad that i had to get it working in order to get our librarian prepped for putting data into it before the library and archive goes into cold storage indefinatelly
22:13 Pit-Work      and she loses her job :/
22:13 corilynn      ugh, that's depressing
22:13 Pit-Work      when she started 7-8 years ago there was no records just random items on shelves
22:14 corilynn      we've seen a lot of that here
22:14 Pit-Work      now there is a proper archive, data sets, checkouts, with 13000 books all MARC'ed catalogued and organized and thousands of archival material
22:14 corilynn      i work for a cataloging company
22:14 corilynn      we do recon projects
22:14 Pit-Work      :/
22:15 Pit-Work      i get it square footage is expensive in major cities, and not every one wants to keep that much stuff in their offices
22:17 Pit-Work      just hits me on multiple fronts as i seen people come and go from this company, low staff retention etc, but she reallyd edicated her time here to all she did
22:17 Pit-Work      and i kinda grew up in a library
22:17 corilynn      i totally grew up in a library
22:17 Pit-Work      when i was a lil one my mom was a school librarian so i would spend time there between classes, before, after etc, even when i was "sick" and she would not leave me home alone id just be in the library