Time Nick Message 07:33 marcelr hi #koha 07:37 reiveune hello 07:37 * magnuse waves 08:02 alex_a Bonjour 08:02 wahanui hola, alex_a 08:31 ashimema mtj happen to be around? 08:34 ashimema @later tell mtj Any idea what I got wrong when adding libarray-utils-perl to the deb control files? For some reason it's not getting installed in the Jenkins dockers and has also produced a patch to remove it again on bug 17084 08:34 huginn ashimema: The operation succeeded. 08:44 kohaputti Joubu, the edits to tests in t/db_dependent/Koha/IssuingRules.t looks super random to my eye 08:44 kohaputti they say they test one thing but then in reality test another 08:47 mtj hi ashimema, i guess the docker images dont know about the libarray-utils-perl package yet, so the build fails 08:47 ashimema I thought it was the control file which lead to the nightly builds getting the dependancy in their packages? 08:47 Joubu kohaputti: changes from patch "(follow-up) Add foreign key and scope enhancement to circ rules"? 08:48 kohaputti Joubu, http://paste.debian.net/plain/1127844 not sure which patch 08:49 kohaputti actually this was the one I paid attention to: http://paste.debian.net/plain/1127845 08:50 mtj ashimema: aah ok, the nightly-builds stuff is something i havent looked at yet 08:50 kohaputti Joubu, oops, looks like it was buggy/weird before this patch set also 08:51 kohaputti the strange thing is that $rule is fetched with itemtype => $itemtype, 08:51 kohaputti even though the test is testing with itemtype => undef 08:51 kohaputti and we add for the circ rule fetching: 08:51 kohaputti 6474 + rule_name => 'fine', 08:51 kohaputti 6475 + rule_value => 14, 08:52 kohaputti which is not necessary 08:52 Joubu kohaputti: because the rule does not exist? 08:52 mtj ashimema: https://apt.abunchofthings.net/koha-nightly/pool/main/k/koha/ 08:53 mtj ashimema: looks like it hasnt been updated in a while? - aka broken? ^ 08:53 kohaputti Joubu, I think it returns a wrong rule here for the test 08:54 kohaputti the test should probably check rule_value == 13 08:54 kohaputti bbl 08:54 Joubu kohaputti: yes you are right, I will take a look 08:57 ashimema aha.. that would be the problem then mtj 08:57 ashimema good spot 08:58 ashimema that's annoying.. that would be why we have to keep adding things to the DockerFile which we really needn't 09:03 mtj hmm, any public repo for the koha-nightly stuff? 09:06 mtj 'master' looks like its still updating-ish 09:07 mtj https://apt.abunchofthings.net/koha-nightly/unstable-gitdiff.txt 09:07 mtj + -- <nightly@abunchofthings.net> Mon, 27 Jan 2020 00:31:58 +0100 09:07 mtj https://apt.abunchofthings.net/koha-nightly/unstable-log.txt 09:08 ashimema hmm.. I think it's only master that gets the nightlies 09:08 ashimema though actually.. perhaps that's wrong as we have been relying on them for all the jenkins runs 09:09 ashimema it's only really the dependancies from the nightlies we're interested in 09:09 mtj cp: error writing 'debian/koha-common/usr/share/koha/misc/translator/po/kn-Knda-staff-prog.po': No space left on device 09:09 ashimema we symlink in a git clone for the actual koha code 09:09 ashimema lol 09:10 * ashimema looks at your repo's and remarks how pretty they are again.. 09:10 * ashimema must try harder with the ptfs-e version of that 09:19 mtj ta, feel free to pinch the css :0) 09:20 mtj re nightly build... you can set an attempt to build the latest... 09:20 mtj +koha (19.06.01~git+20200127003158.fcb58e02-1) unstable; urgency=medium 09:21 mtj https://apt.abunchofthings.net/koha-nightly/unstable-gitdiff.txt 09:21 mtj using the latest commit... HEAD is now at 8a468824fd Bug 24509: Fix API relared tests failing on MySQL8 09:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509 normal, P5 - low, ---, tomascohen, Pushed to master , API related tests failing on MySQL8 09:22 mtj but, if you look in the koha dir, the build is missing :'( 09:22 mtj https://apt.abunchofthings.net/koha-nightly/pool/main/k/koha/ 09:22 mtj koha-perldeps_19.06.01~git+20190902111037.c2ef833b-1_all.deb 2019-09-02 11:23 31K 09:23 mtj ^ ..was the last successful build in sept 2019 09:23 mtj 19.06.x was 'master' back then 09:23 ashimema I see 09:25 mtj so, i guess the last unstable nightly package (from sept) is missing the new 'libarray-utils-perl' dep 09:25 ashimema makes sense 09:26 ashimema it's wierd that the magical script that spits out patches for the control file removes it though.. I have no idea how that works 09:26 mtj hmm, and now..how to fix? :) 09:27 ashimema for now I can manually patch it in the DockerFile to get Jenkins happy in the short term 09:32 * ashimema still wonders about Mirko.. it's been many months since we heard from him now.. hope he's OK 09:34 mtj 1 tic, ill test 09:34 ashimema :) 09:40 ashimema whilst on packaging.. I always refer to 'Building Debian packages - The Easy Way'.. do we think we could just get rid of the original page 'Building Debian Packages' on the wiki at this point.. it's not been updated since 2016 by the looks. 09:55 kohaputti Joubu, I finished the code review part. Everything seems to be OK except for the two croaks in the patch set – which might be ok too if we decide soo but a Koha::Exception would definitely be the way to go. 09:56 kohaputti (and except for the DisallowHoldIfItemsAvailable.t we just discussed via pm) 09:56 * kohaputti continues with the testing 10:01 mtj ashimema: using a stretch vm with unstable kc.org repo, debian/update-control script leaves 'libarray-utils-perl' intact 10:01 ashimema indeed 10:01 ashimema aha.. i bet it's running on a Jessie 10:02 ashimema I don't think the package is available on jessie 10:02 mtj ah click 10:04 mtj ill add that to kc.org repo in 20 10:05 ashimema thanks :) 10:17 kohaputti cait1, the sign-up for hackfest opened up just, check the email from paul_p on the mailing list 10:17 huginn News from kohagit: Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=95231815ccf47253967b02663b34d278117279f5> 10:17 paul_p kohaputti, cait1 already sent me an email to say "i'll be there", so she's the 1st registered ;) 10:17 huginn News from kohagit: Bug 24497: Turn off smartIndent for SQL <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=aad0802f825d7767ce2b103ecbf34419cfa77fc7> 10:17 huginn News from kohagit: Bug 24511: Update variable names to avoid confusion <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=194cdef333e85c49f998cb38b72c4278b4128d88> 10:17 huginn News from kohagit: Bug 24484: Add explanatory text to batch patron deletion <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bebb0eaf2f5e98645ab04688491a6c9f0ad3ae45> 10:18 kohaputti paul_p, ahaha :) 10:19 cait1 paul_p: yay! 10:19 cait1 paul_p: tbh - I thought i had seen a call for registration and realized later it was from 2019... 10:20 paul_p there will be 8 ppl from bywater ! 10:20 cait1 so I heard 10:20 cait1 really looking forward to it this year (as always) 10:27 ashimema haha 10:27 ashimema I'll be there.. 10:27 ashimema just looking at arranging transport now.. hoping I might be able to catch the same train in from long as bag and gang :) 10:28 ashimema also persuading lucyvh to attend in a documentation capacity.. hopeing some other keen documentors attend 10:43 huginn News from kohagit: Bug 24339: Do not assume there are exactly 3 SIP* AVs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4f6dc86d2402ed552ae139e3cd6390422356d9ad> 10:43 huginn News from kohagit: Bug 24339: Remove SIP payment types from staff pay screens <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a6f538cbcd67303a8d7e8ff6f9ef79f68182649f> 10:43 huginn News from kohagit: Bug 24339: Add SIP2 payment types for installation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a10b520b9b8cc01ac443bb2e67a16cd9d0473c83> 10:43 ashimema two more majors and we'll be under 100 again! 10:49 cait1 heh 10:52 kohaputti Joubu, do you have any preference on what to do with the croaks? 10:55 Joubu kohaputti: they should never be raised to the interface, it's for dev purpose. We can switch them to Koha::Exception if you think it's useful. IMO they could stay croak 10:56 koha-jenkins Project Koha_Master_D8 build #638: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/638/ 10:56 koha-jenkins Project Koha_Master_D9_MDB_Latest build #88: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/88/ 11:09 koha-jenkins Project Koha_Master_D9 build #1101: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1101/ 11:11 kohaputti Joubu, yup, it definitely looked just for devs so I don't mind if we keep it as croak 11:18 Joubu ere: about bug 24428, do you know if it ever worked with ES? 11:18 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428 critical, P5 - low, ---, koha-bugs, NEW , Elastic search index does not contain consistent item information 11:20 ere Joubu: It's possible that it did (in a way), by chance, but only for the fields indexed. 11:20 cait1 I think the bug says so... but haven't tested 11:20 ere I don't think we have had all item fields in the default mappings. 11:21 Joubu Even if we had, how could it be fixed? 11:21 ere Oh, I'll backtrack. In a way it probably did work as it indexed the full MARC record (with embedded items?) as a JSON structure. 11:21 ere Anyway, that's optional even now, so just turn the pref on :) 11:22 ere If the MARC data doesn't include items, then it won't work, though. 11:23 ere To solve the issue properly, we'd need another mapping for item fields so that they could be properly mapped into their own sub-records in the indexed record. 11:24 Joubu ok, that is what I thought. That quite a big work then. 11:24 Joubu I th 11:24 Joubu I think it's more an enhancement request than a critical bug 11:35 cait1 we have bugs filed for this 11:35 cait1 but it's not a regression - it's a bug in Zebra as well 11:35 cait1 people trying to limit location x with itemtype y etc. 11:35 cait1 never worked 11:36 cait1 well... maybe enhancement... but still quite annyoing .) 11:37 ere yeah, with normal rules you'd get a record that matches any combination of values in its items 11:37 koha-jenkins Project Koha_Master_U18 build #572: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/572/ 11:41 ere Anyway, workaround is to set ElasticsearchMARCFormat to "Searchable array" and the item information is there (I checked). 11:43 ere i made a note of that in the bug. 11:44 kohaputti Joubu, I asked now one librarian to try break the circ rules :) 11:46 Joubu :) 11:52 ere Anyone able to help with a REST API issue? I can't get the authorization to work properly. OAuth2 is working fine, but any time authorization is actually needed, Auth::authenticate_api_request doesn't actually receive the x-koha-authorization field and deems all query params invalid. A sample request would be: http://localhost/api/v1/checkouts/?patron_id=306 11:53 ere Does it depend on a specific version of Mojolicious::Plugin::OpenAPI or something? 11:57 Joubu ere: I added you to bug 22522 11:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 is not accessible. 11:59 ere Joubu: thanks, that explains.. 11:59 koha-jenkins Project Koha_Master_D9_My8 build #110: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/110/ 12:10 koha-jenkins Project Koha_Master_D8 build #639: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D8/639/ 12:14 koha-jenkins Project Koha_Master_D9_MDB_Latest build #89: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/89/ 12:34 oleonard Hi #koha 12:47 koha-jenkins Project Koha_Master_D9 build #1102: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1102/ 13:59 caroline_catlady good morning! 14:23 tcohen !bang 14:23 AnnaBoten There is no hunt right now! You can start a hunt with the 'start' command 14:23 oleonard Hi tcohen, caroline_catlady 14:23 tcohen hi ere 14:23 ere hi tcohen 14:28 tcohen ere I consider your solution reasonable 14:28 tcohen we just were't sure if other problems would arise, we really need to test it in deep 14:28 tcohen and plan for a version upgrade as well 14:28 tcohen we are just sorting packaging ATM 14:31 ashimema you beat me to it tcohen.. I was about to say the same :) 14:31 ere tcohen: That's cool. I'm right now testing with latest versions to see if/how things work. I've a nasty feeling that I can't find a version combination where everything would work with OOTB master version of Koha. 14:32 ashimema I was trying that earlier.. if I got Mojolicious, OpenAPI and JSON::Validator from cpan.. lots of tests fail 14:32 ashimema I would love to see that progressed though.. I didn't get very far with my testing 14:35 lukeG Good morning Koha! 14:36 Marie-Luce good morning 14:40 ere ashimema: Oh well... I'll see what happens anyway. 14:48 Null404 Hello everyone 14:50 Null404 I have a question: how to find books with "null" Collection or "null" Home library ? 14:55 caroline_catlady Null404: have you looked in the SQL library https://wiki.koha-community.org/wiki/SQL_Reports_Library 15:38 * ashimema quietly wonders if cait1 was going to qa 22359 now everyone seems reasonably happy with it. 15:42 cait1 bug 22359 15:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 normal, P5 - low, ---, martin.renvoize, Signed Off , Improve usability of 'change calculation' (bug 11373) 15:42 cait1 not sure i shoudl QA anything today 15:44 ashimema fair enough 15:46 oleonard not sure I should anything either 15:53 * cait1 is grumpy cait 15:55 ashimema yikes.. don't look then ;) 15:55 ashimema grumpy cait scares me 15:55 oleonard Wait for forgiving cait 15:58 cait1 yeah 15:59 cait1 i'd recommend that too ;) 16:00 huginn News from kohagit: Bug 24486: Remove duplicated account information at the OPAC <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=624bc03ea85f5027f2fcdb29ff80a5f5e94372c8> 16:00 huginn News from kohagit: Bug 24421: Unit tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=daaf0ca35ccefe73222c47b4b19e17e4360b8206> 16:00 huginn News from kohagit: Bug 24421: Check if subfields are valid using the biblio tag <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c129a47ae5512b7a8026915894500b6390c64726> 16:36 koha-jenkins Project Koha_Master_D8 build #640: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/640/ 16:42 koha-jenkins Project Koha_Master_D9_MDB_Latest build #90: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/90/ 16:51 reiveune bye 16:59 koha-jenkins Project Koha_Master_D9_My8 build #111: STILL UNSTABLE in 57 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/111/ 17:23 koha-jenkins Project Koha_Master_U18 build #573: STILL UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_U18/573/ 17:24 koha-jenkins Project Koha_Master_D9 build #1103: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1103/ 17:46 oleonard Hi davidnind 17:50 davidnind H oleonard 17:50 wahanui oleonard is happy for ashimema to write the release script 17:50 oleonard Thanks for all the testing, I really appreciate it 17:52 davidnind You're welcome - didn't quite get it down to under 10 needing sign-off :) 18:19 tcohen !bang 18:19 AnnaBoten There is no hunt right now! You can start a hunt with the 'start' command 18:42 wizzyrea hi 18:42 wahanui privet, wizzyrea 18:45 tcohen hi 18:57 huginn News from kohagit: Bug 24361: Silent t/db_dependent/Items.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a29d1db971450322f99f68af26295d097f44a0b9> 19:36 koha-jenkins Project Koha_Master_D9_MDB_Latest build #91: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/91/ 19:37 koha-jenkins Project Koha_Master_D8 build #641: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D8/641/ 19:47 koha-jenkins Project Koha_Master_D9 build #1104: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1104/ 19:58 tcohen @later tell Joubu if ->store calls ->update_or_insert, I would expect DBIC not to pass the timestamp column as it is not 'dirty', are you sure we need to manually handle timestamps?? 19:58 huginn tcohen: The operation succeeded. 20:16 koha-jenkins Project Koha_Master_U18 build #574: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/574/ 20:32 koha-jenkins Project Koha_Master_D9_My8 build #112: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/112/ 21:18 cait hm no oleonard... 21:18 cait does someone know how the club holds work? 22:15 cait Happy birthday, kathryn :) 22:30 bag happy birthday kathryn 23:25 wizzyrea HAPPY BIRTHDAY KATHRYN 23:25 wizzyrea (and happy birthday soon to your wee sprite)