Time Nick Message
01:20 luthlexor Hi there, is anyone available to give me some advice? Our koha admin site has been down for about a week now, just returning a error 400 page. It looks like it's returning broken html, with the formatting all wrong. I've spent multiple probably a dozen hours on this issue, but am making zero progress. Can anyone advise?
01:20 luthlexor The main OPAC website works fine. Admin login page (or any other page) cannot be accessed.
01:21 luthlexor "
01:21 luthlexor n error has occurred! Error 400 This message may have been caused by any of the following reasons: You made use of an external link to an item that is no longer available You followed an outdated link e.g. from a search engine or a bookmark You tried to access a page that needs authentication An internal link in the client is broken and the page does not exist
01:23 hayley hi luthlexor, did anything change a week ago when the page became inaccessible?
01:25 luthlexor Not to my knowledge
01:26 luthlexor Obviously something changed, but I don't think it was a direct action by a staff member.
01:35 hayley You could check that the link you are going to and the DNS in the apache config on load balancer or the server are the same
01:43 luthlexor Hm, okay, I'll give that a shot
06:47 marcelr hi #koha
06:56 marcelr hi cait
07:02 paxed @later tell rangi btw, 2019-12-11 i talked with Joubu in here about the bugzilla wrapping emails annoyingly. he pointed me to you. here's the patch: https://bilious.alt.org/~paxed/koha/bz_email_txt_nowrap.diff
07:02 huginn paxed: The operation succeeded.
07:40 reiveune hello
07:58 alex_a Bonjour
07:58 wahanui hey, alex_a
07:58 fridolin yooooo
08:00 * magnuse waves
08:01 kohaputti Joubu, if the default rule has "hours" as lengthunit instead of "days" then it makes sense to have that follow-up for Fees.t. It's entirely possible someone runs the tests with a koha installation which settings has been modified after running populate_db.pl
08:01 kohaputti I mean populate_db.pl added the default rule with lengthunit = days
08:08 stefan_norinder hello everyone. this is my first time here.
08:08 stefan_norinder I need your help with notices. I can't get Koha to change what "message" to use. This is the scenario:
08:09 stefan_norinder 1. Execute cron job sudo perl /usr/share/koha/bin/cronjobs/overdue_notices.pl -t -v -html /tmp on server
08:09 stefan_norinder 2. Koha adds notice to message queue using notice "DUE 1".
08:09 stefan_norinder 3. Change "message" drop down under module "Overdue notice/status triggers" in Koha staff client to "DUE 2" and save changes.
08:09 stefan_norinder 4 Clear memcache on server echo "flush_all" | nc -q 2 localhost 11211
08:09 stefan_norinder 5 .Execute cron job sudo perl /usr/share/koha/bin/cronjobs/overdue_notices.pl -t -v -html /tmp on server
08:10 stefan_norinder 6. Koha adds notice to message queue still using notice "DUE 1".
08:10 stefan_norinder It seems like the cron job i unaffected by the changes in the Koha staff client. Or is there something I'm missing?
08:18 Joubu kohaputti: indeed, I readded it!
08:18 ashimema Joubu++ kohaputti++
08:19 ashimema erm.. either my understanding of the due notices is wrong or you're not understanding them stefan_norinder
08:20 ashimema DUE1 is the 'first overdue notice', DUE2 is the 'second overdue notice'.. as in.. DUE1 goes after x days, then DUE2 goes after y days.. and so on.
08:21 * ashimema is probably wrong.. I'm going off old inaccurate memory
08:21 cait an overdues question?
08:22 ashimema overdue notices
08:22 ashimema 8.08 this morning
08:25 cait no logs in my client
08:26 ashimema http://irc.koha-community.org/koha/2020-01-24#i_2212038
08:26 ashimema ;)
08:30 kohaputti cait, <ashimema> http://irc.koha-community.org/koha/2020-01-24#i_2212038 (in case you didn't see)
08:30 cait hm
08:31 cait Some things in the GUI to check: there is an all vs branch specific tab
08:31 cait or page
08:31 cait common mistake: change for all, but have branch specific set, that wins
08:32 cait the codes of the overdue notices don' matter, but the trigger configuration should work
08:32 cait and when -t is used, that's where the config comes from
08:33 cait stefan_norinder: still around?
08:33 * magnuse is talking to him on the swedish slack
08:33 magnuse sure he'll come back
08:33 cait ok :)
08:34 * cait goes back to torture the ticket system
08:36 magnuse cait: you were right, it was a branch specific rule winning over the default
08:37 stefan_norinder yes I'm here. magnus helped me in slack. it had nothing to do with the cache. I made the changes to the "default" library. Even though we only have one library I had to choose "SH" for the settings to kick in.
08:38 cait ;)
08:38 cait although that was a bug that shoudl have been fixed a long time ago. hm.
08:39 cait I hope it hasn't reappeared
08:43 magnuse stefan_norinder: which version are you on?
08:44 kohaputti Joubu, any particular reason for not using koha logger: https://gitlab.com/joubu/Koha/commit/4e72a5fb8f5a7d958f4b285ac7b3d4054c79104c#b1d0e153cddd321613ca73c327dae0d69f463c7c_265_312
08:46 Joubu not really
08:46 cait bug 9180
08:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 major, P5 - low, ---, jonathan.druart, CLOSED FIXED, Default rules are not always used for overdues
08:46 Joubu laziness certainly
08:47 cait bug 2720
08:47 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 enhancement, P3, ---, fridolin.somers, CLOSED FIXED, Overdues which debar automatically should undebar automatically when returned
08:47 cait um not that one
08:47 cait bug 3025
08:47 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3025 normal, PATCH-Sent (DO NOT USE), ---, nahuel.angelinetti, CLOSED INVALID, bug with holds a multiple check-in
08:47 cait argh
08:47 cait bug 3035
08:47 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3035 major, P3, ---, gmcharlt, CLOSED MOVED, Notice Triggers doesn't work for default
08:47 cait so i found 2 where we broke/fixed it before (if you ignore the 2 typos)
08:48 huginn News from kohagit: Bug 24149: Skip Koha::Statistics for TestBuilder tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88d699fece53a1ae588554166f761d66edc95e69>
08:48 kohaputti Joubu, do we have any unwritten or written rules regarding logging / is that warn ok?
08:48 stefan_norinder magnuse: 19.05
08:48 * ashimema finds our logging confusing at present.. as you say.. there's Koha::Loggers, C4::Log, Koha::Statistics at least
08:49 Joubu ashimema: all those 3 have different uses
08:50 ashimema indeed.. but the distinctions aren't clear anywhere in my opinion..
08:50 Joubu kohaputti: We should replace them all then add a guideline. So far we do not.
08:51 ashimema agreed
08:51 kohaputti them all = warns?
08:51 Joubu yes
08:51 kohaputti ok
08:52 * ashimema thinks he's going mad
08:53 marcelr dont write patches now ashimema ;)
08:54 cait yes please, don't
08:56 ashimema lol
08:59 marcelr Joubu: any change to get 23290 further ?
08:59 marcelr chance
08:59 kohaputti Joubu, something strange going on with some commit removing copyright notices from Koha/CirculationRules.pm. ...lunch now and then will check what's up with that
09:00 cait bug 23290
09:00 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23290 is not accessible.
09:00 marcelr security patch
09:00 Joubu marcelr: it's on my list, you asked me already ;
09:00 marcelr ok maybe you forgot about it :)
09:17 stefan_norinder I think we have Bug 10720 in our Koha instance. This was fixed in 2013 in version 3. We are on version 19.05. How can this be?
09:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 normal, P3, ---, sophie.meynieux, CLOSED FIXED, Substitution term in overdue notices shouldn't be removed even if they don't match
09:18 huginn News from kohagit: Bug 22831: (RM follow-up) Add libarray-utils-perl to control <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2ee96d2abd9037723a8e844d1d6ed1c1c3a0c556>
09:18 huginn News from kohagit: Bug 17084: Automatic debian/control updates (unstable/master) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e326231cf6a5e853bf4b3b4bf71898d858d651c4>
09:19 ashimema mtj around
09:24 mtj hie ashimema
09:24 ashimema evening mtj
09:25 ashimema did you just spot my control file change I wonder..
09:25 koha-jenkins Project Koha_Master_D9_MDB_Latest build #84: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/84/
09:25 ashimema I was hoping you were around.. I'm not 100% sure what to do there
09:26 ashimema it's packaged for stretch and up.. but jessie is missing that one... but.. we're also not going to be backported the requirement to jessie as it's an enhancements feature..
09:26 magnuse stefan_norinder: regressions happen! (where old bugs return)
09:26 ashimema the easy way out is to just get rid of the dependancy entirely.. in this case that's easy enough.. but I thought I'd ask your thoughts before doing that
09:26 cait stefan_norinder: can you describe your issue ab it more?
09:27 koha-jenkins Project Koha_Master_D8 build #634: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/634/
09:27 magnuse stefan_norinder: if you are confident you have a bug, report it as a new bug and refer to the old bug
09:27 cait did you check the html checkbox?
09:27 cait on your notice?
09:27 mtj ashimema: that one -> Bug 22831: (RM follow-up) Add libarray-utils-perl to control master
09:27 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 enhancement, P5 - low, ---, nick, Pushed to master , Elasticsearch - add a maintenance script for checking DB vs index counts
09:27 ashimema yup
09:27 ashimema that one
09:27 wahanui that one is probably running fine for me
09:28 cait are you seeing problems with print or email?
09:30 stefan_norinder cait: it pretty much as described here https://gitlab.deichman.no/digibib/Koha/commit/394be84dcd65a4569d0467bc12b99dbd6341fc43
09:31 mtj ashimema: seems ok to me - i should be able to add libarray-utils-perl_0.5-1 to kc.org repo, for jessie
09:31 ashimema :)
09:31 ashimema hugs
09:31 stefan_norinder cait: the system complains on every html component and writes a message "The following terms were not matched and replaced:"
09:31 cait ok, so print
09:31 cait i think there is a different bug open for that
09:32 stefan_norinder i see
09:32 cait bug 22131
09:32 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22131 new feature, P5 - low, ---, koha-bugs, NEW , overdue_notice.pl and gather_print_notices.pl should honor letter.is_html
09:32 cait i hink this one
09:32 stefan_norinder the generated html page is more or less without content
09:33 cait hmm
09:33 mtj ill aim to upload the koha packages tonite
09:33 ashimema thanks dude
09:33 cait if the old fix works, it ight be worth a new bug - but wondering if the old lines crept back in and how?
09:34 cait you are right it sounds more like the old one
09:35 cait but we need a new bug report and a link to the old if possible - for fixing it
09:35 cait never reopen an alredy pushed one - always use a new one :)
09:35 stefan_norinder I get a bit nervous. I new to koha, no perl programmer and have limited linux knowledge. hope i'm not confused....
09:35 cait you can report and someone can tell you it works for them.. nothing lost :)
09:35 stefan_norinder ok. I try to write a new bug report then
09:35 cait best case, you will find out what's going on
09:36 ashimema opening new just means we'll spot it.. if it's pushed or closed it far less likely we'll notice it ;)
09:36 cait and it messes with the release notes if we reuse them
09:36 ashimema indeed
09:36 cait don't be nervous about reporting a bug :)
09:37 koha-jenkins Project Koha_Master_D9 build #1097: STILL UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1097/
09:52 kohaputti Joubu, https://gitlab.com/joubu/Koha/commit/861d8fbbd7bbd59b644c6f1691c29e8f82d4ee4a#353fbe8d272a5754cc5433c9ab2b331868350dc3_1_1 I can't find any explanation for removing the copyright notices here so we should probably assume it is a mistake and leave out those two lines removing the notices from the patch
09:53 kohaputti khall is not on irc but we should also ask if he knows something about this
09:58 Joubu kohaputti: f576fb9c3ea88fad65ad83076e59f4f728e908ce
09:58 Joubu I think the copyright was wrongly added initially
10:03 Joubu marcelr: do you remember the bug # where we had problem comparing the output of Koha::Exception? Between 2 different DBIC versions the ouput of the DB column changed, like "column_name" vs "table_name.column_name"
10:03 kohaputti could be the case, though the code looks pretty similar to Koha/IssuingRules.pm
10:03 Joubu or someone else?
10:04 kohaputti Joubu, I would prefer to have the removal of possible wrong copyright notice info in a separate bug
10:05 stefan_norinder I've registered a new bug 24505
10:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24505 normal, P5 - low, ---, koha-bugs, NEW , Print overdue notice with html gives message: "The following terms were not matched and replaced"
10:05 Joubu kohaputti: t
10:05 koha-jenkins Project Koha_Master_U18 build #569: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/569/
10:05 Joubu kohaputti: the code added by Vaara-kirjastot is coming from e3f81857d8193245c8e8483838a9daef676ea994 and is an "empty" class
10:06 Joubu however I do not really mind and can add it back if you like
10:06 kohaputti oops.. looks like I'm the author there ....
10:08 marcelr Joubu i remember the topic not the bug #
10:08 Joubu marcelr: do you remember something else? Like the file? or the context?
10:09 marcelr hmm
10:09 marcelr sub store of koha object ?
10:09 Joubu bug 23825
10:09 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 normal, P5 - low, ---, m.de.rooy, Pushed to master , Object.t is failing - Exception not caught
10:10 Joubu that's the one! thanks!
10:15 marcelr Joubu: do you have an idea how the splitting on [[ or ]] in get_prepped_report is supposed to work? wouldnt it just generate sql syntax errors instead ?
10:15 marcelr in guided_reports.pl
10:17 kohaputti Joubu, looks like the IssuingRules.pm stub in e3f81857d8193245c8e8483838a9daef676ea994 doesn't share any works/code with the version of CirculationRules.pm where the copyright notice is removed so I'm leaning towards that this is okay too, but I'm no lawyer.
10:18 Joubu marcelr: I am not sure I understand the question
10:18 kohaputti there was the other Koha team something copyright too
10:18 marcelr the code offers adding types somehow in a sql query with [[ type ]]
10:18 marcelr but i am wondering how it works
10:19 marcelr you are depending on that stuff in 24305
10:19 marcelr just grep on get_prepped_report
10:19 kohaputti Joubu, Copyright Koha Development Team 2016 is added by you, so I guess you are fine with removing it?
10:20 Joubu That could be kept, and adjusted
10:20 Joubu I am using that Copyright statement for my code, others do as well
10:21 Joubu marcelr: I can see that 24305 depends on 19233, but it's not adding that [[]] stuff
10:22 Joubu bug 23390
10:22 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 enhancement, P5 - low, ---, nick, RESOLVED FIXED, Add placeholder syntax for column names
10:22 kohaputti Joubu, so that's a fake entity? O.o
10:22 marcelr Joubu: I will bisect it
10:22 koha-jenkins Project Koha_Master_D9_My8 build #107: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/107/
10:22 marcelr it wasnt in 3.0 ;)
10:22 Joubu not sure "we" are fake
10:23 Joubu but I am not a lawyer either ;)
10:24 Joubu marcelr: the placeholders are removed from the sql query, so that should not be a problem
10:24 marcelr maybe i mean something else; i will check
10:25 koha-jenkins Project Koha_Master_D9_MDB_Latest build #85: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/85/
10:33 Joubu @later tell tcohen we have several api related tests failing on MySQL 8. It's the table_name.column_name vs column_name in the errors. I fixed one similar on bug 24507. It would be good to have the API ones fixed as well. Could you have a look?
10:33 huginn Joubu: The operation succeeded.
10:35 koha-jenkins Project Koha_Master_D8 build #635: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D8/635/
10:35 kohaputti Joubu, we need to address removal of the following circ rules:
10:35 kohaputti 982 + # Not included (deprecated?):
10:35 kohaputti 983 + # * accountsent
10:35 kohaputti 984 + # * reservecharge
10:35 kohaputti 985 + # * restrictedtype
10:36 kohaputti if you know already the reason why we don't have those anymore please let us know
10:37 Joubu @later tell tcohen see bug 24509
10:37 huginn Joubu: The operation succeeded.
10:37 Joubu kohaputti: columns are in issuingrules, but not used in the code
10:37 kohaputti Joubu, can you then send follow-up removing that comment?
10:38 Joubu why do you want to remove the comment?
10:38 Joubu it states that they are deprecated/removed
10:39 Joubu kohaputti: If I am not mistaken we do not want to remove them arbitrarily, one may use it (?)
10:40 kohaputti ah, I see, then changing "Not included (deprecated?):" to "Not included (deprecated):" would be useful
10:40 Joubu So the idea was to copy them, do not handle them (there are several places in the code where we skip them), then remove them on its own bug report, with its own update DB entry and warn if they are not empty
10:40 kohaputti Joubu, do you mean some external program using interal Koha objects might use it?
10:41 kohaputti ok
10:41 Joubu no, a fork
10:41 Joubu well, I do not know, and cannot know. Just prefer to be on the safe side and not remove data without telling anything
10:42 Joubu Maybe QA will catch something. That seems better to keep a comment (and occurrences for git grep) than remove them silently
10:42 kohaputti ok
11:08 tcohen morning
11:10 kohaputti Joubu, in /cgi-bin/koha/admin/smart-rules.pl all the delete rule buttons link to /cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=*&categorycode=*&branch=* – can you reproduce?
11:11 kohaputti This means I can only delete rules with branchcode=null, categorycode=null, itemtype=null
11:11 kohaputti other rules I cannot delete
11:14 Joubu kohaputti: trying now
11:15 Joubu kohaputti: oops, yes
11:15 kohaputti the code in template is href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=[% rule.itemtype || '*'
11:15 koha-jenkins Project Koha_Master_D9 build #1098: STILL UNSTABLE in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1098/
11:15 kohaputti so I think rule.itemtype is not defined
11:15 kohaputti the file is b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
11:19 tcohen Joubu: ok
11:19 Joubu kohaputti: fixed
11:21 kohaputti Joubu++
11:29 vfernandes hi #koha
11:41 ashimema sorry mtj.. another jessie packaging issue.. bug 24508
11:41 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508 normal, P5 - low, ---, koha-bugs, NEW , Perl version stops upgrade
11:41 ashimema @later tell mtj Sorry mate, another packaging issue for Jessie.. bug 24508
11:41 huginn ashimema: The operation succeeded.
11:42 ashimema I should really announce a deprecation of Jessie support come 20.05 release
11:44 tcohen jessie gets EOL one month after 20.05 is released
11:45 ashimema indeed
11:46 ashimema hense I think we should drop it for at 20.05, 19.11.12, 19.05.18
11:54 tcohen +1
11:56 ashimema https://jsfiddle.net/ashimema/1uxysdap/12/
11:57 ashimema is it just me, or is there a bug in jquery validate?
11:58 ashimema seems that 'min' works up to 99.99 but breaks at 100
12:07 mtj ashimema: bz 24508 looks to be caused by a deb8 server running a deb10 version of perl
12:07 ashimema interesting
12:08 mtj so.. not technically our problem
12:09 mtj they could attempt to build/install a new libnet-z3950-simpleserver-perl package, for their frankensystem
12:09 mtj i'll suggest that in the bz
12:10 ashimema ta
12:21 kohaputti Joubu, the new way of deleting circulation rules looks awful, you have to list all the individual rules you want to delete and cannot say for example let's delete all rules from branch A!
12:21 kohaputti shall we leave this improvement for a follow-up bug report?
12:23 Joubu kohaputti: bug 15522 you mean?
12:23 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , New interface for revamped circulation rules
12:24 kohaputti no, I mean the way you have to use Koha::CirculationRules->set_rules to delete rules
12:24 Joubu you can use Koha::CirculationRules->search({branchcode => $branchcode})->delete
12:24 kohaputti soo you have to use that to set all the individual rules to undef for them to be deleted
12:25 kohaputti ah, well then the person writing this code didn't probably remember to use that
12:25 kohaputti it's the code in admin/smart-rules.pl I'm talking about
12:26 Joubu kohaputti: I will need to think about that, after lunch :)
12:27 Joubu not sure this set_rules call is correct
12:27 kohaputti oh yes, I looks strange so I was about to test it too, but I for now assume it is correct
12:27 kohaputti it looks*
12:30 ashimema @later tell oleonard can you see anything obviously wrong with my javascript on https://jsfiddle.net/ashimema/1uxysdap/17/ It's driving me mad.. I'm sure it's a bug in the validate plugin.
12:30 huginn ashimema: The operation succeeded.
12:33 oleonard Hi #koha
12:34 kohaputti ashimema, what issue?
12:36 kohaputti never mind you wrote it earlier
12:37 oleonard ashimema: Is that JS giving you an error? What's the issue?
12:38 ashimema no errors
12:38 ashimema it's bug 22359
12:38 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 normal, P5 - low, ---, martin.renvoize, ASSIGNED , Improve usability of 'change calculation' (bug 11373)
12:39 ashimema my code seems to work perfectly untill you try to pay 100.. at which point it just stops doing propre validation entirely
12:39 ashimema I've opened https://github.com/jquery-validation/jquery-validation/issues/2311
12:40 ashimema but want to make double sure my jsfiddle is totally wrong
12:40 oleonard What happens when you pay 100? I don't understand
12:41 ashimema in the fiddle.. try reducing the 'collected from patron' amount
12:42 ashimema it should fail validation as 'collected from patron' should be min capped to the value of amount being paid
12:42 ashimema if you reduce 'amount being paid' to below 100.. then the validation on 'collected from patron' magically starts working
12:43 ashimema lol
12:45 tcohen amoyano around?
12:48 * ashimema pushes some bugs for light relief
12:55 mtj hmm, fiddle seems to work for me on ff and chrome
12:55 Joubu kohaputti: IMO the set_rules call should be replaced with a delete => undef sometimes means "unlimited", and we want to default to the general rule, not consider it unlimited
12:55 mtj Amount being paid: 100.00
12:55 mtj Collected from patron: 200.00
12:55 mtj Change to give: 100
12:55 wahanui mtj: that doesn't look right
13:00 ashimema try collecting less than 100
13:00 cait just please avoid html5 number
13:00 cait i beg you
13:00 ashimema explain cait?
13:01 cait it is something weird with plack locale/browser language settings
13:01 cait it ends up asking us to enter prices with comma
13:01 cait which then koha doesn#t like
13:01 cait apart form... we don't want a few forms to ask for comma andothers not
13:01 cait i had to remove every single instance on our branch
13:02 cait and replace with a pattern check
13:02 cait but people don't believe me ;)
13:02 ashimema so we can't use `type=number`
13:02 cait i think because noone has exactly the same setup and we haven't figured out exactly what is causeing it
13:02 cait number without decimal is fine
13:02 ashimema that's interesting..
13:02 cait once it's decimal things get hairy
13:02 ashimema I wasnt' aware of that
13:02 tcohen cait on all browsers?
13:02 cait indeed plack can make a strange difference too
13:02 cait firefox at least, which is the most common used around here
13:03 ashimema I am very tempted to just give up entirely on this bug then :(
13:03 ashimema I've sunk sooo much time into it already
13:03 cait the usability one?
13:04 ashimema yup
13:04 cait i haven't tested yet :(
13:04 cait what's the issue?
13:04 wahanui the issue is too... thi swould have been better as several bugs
13:04 ashimema it uses type=number and step=0.01
13:04 cait just kill it with a pattern check?
13:04 oleonard ashimema: I'd be happy to take a look, I'm just swamped today with non-Koha stuff
13:05 ashimema no worries oleonard
13:05 ashimema I'm just at the point of admitting defeat.. may need to unassign it and let someone else have a go
13:06 cait type="text" pattern="\d+(\.\d{2})?" is what I use
13:06 ashimema but then you can't use 'step' as far as I understand
13:06 cait yes, but why woudl you?
13:06 cait i think noone is really going ot use the up and down keys there
13:06 ashimema I can't remember
13:06 ashimema it was asked for
13:07 cait huh.
13:07 ashimema surely that pattern breaks your currencyFormat issue
13:08 cait no
13:08 cait input is always with .
13:08 cait what i was asking you was only fixing the display
13:08 cait for input we have the something on_editing flag
13:08 cait to avoid breaking things
13:09 ashimema :'(
13:10 cait the input issue is unsolved right now - but when we solve it... we can't solve it in one single input field
13:10 cait because that means librarians will get very confused
13:10 cait we had that on the order receive for some time... and ended up with lots of funny prices
13:11 cait just trying to say... don't try to solve all the things there
13:15 cait ... and if you use the number thing... i'd probably just have to patch it again *shrugs*
13:16 oleonard cait: There a problem with input type "number" ?
13:18 Joubu bug 18186
13:18 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 major, P5 - low, ---, koha-bugs, In Discussion , Plack config: Amounts with decimal comma instead of decimal dot breaking payments
13:18 Joubu this is the bug cait is talking about
13:18 ashimema I wasn't aware of a requirement not to use number before..
13:18 ashimema thanks for highlighting it..
13:19 Joubu it's not really confirmed IIRC
13:19 ashimema replaced it in my fiddle now.. doesn't resolve my issue
13:19 Joubu ashimema: try pattern="[0-9]+"
13:20 Joubu well, adapt if you need decimals
13:20 ashimema https://jsfiddle.net/ashimema/th0a4k71/2/
13:20 ashimema it's not the patturn stuff that's causing me fun..
13:20 ashimema it's the min validation
13:21 cait i think there is another bug somewhere too - we had lots of weird things happen
13:22 cait the plack issue is independent of the filter
13:22 cait it's kind of horrifying that a change to the plack config has any effect to how your numbers display...
13:23 ashimema mm
13:24 cait bug 17098
13:24 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 normal, P5 - low, ---, gmcharlt, NEW , Validation problems with form field type "number" (decimal separator)
13:24 cait mveron reported it - we foudn the same issues
13:25 cait in our 18.11 testing we ran into the problem again
13:25 cait on some fields that I hadn't patched
13:28 ashimema raise it for a coding guidline cait
13:29 tcohen number_type--
13:46 kohaputti Joubu, admin/smart-rules.pl: http://paste.debian.net/plain/1127398 This looks unintended for me
13:46 kohaputti do you know about this or should I investigate further?
13:46 kohaputti 2452 - branchcode => $branch,
13:46 kohaputti 2453 + branchcode => undef,
13:48 * kohaputti is a bit worried the code review will continue next week
13:48 Joubu having a look right now
13:49 Joubu kohaputti: that code http://paste.koha-community.org/18783 rug
13:50 Joubu right
13:50 Joubu ?
13:50 kohaputti yes
13:50 Joubu what worries you?
13:50 Joubu that is corret
13:50 kohaputti before the refund amount was branch specific and now it is not
13:50 Joubu yes
13:51 Joubu you are right I think
13:54 Joubu it was part of the original patchset so it's not a problem due to a wrong conflict resolution. but the error is obvious
13:55 Joubu kohaputti: I pushed a follow-up
13:56 kohaputti it's definitely buggy, If I set refund policy for centerville to "No" and then for fairfield to "Yes", then centerville becomes also "Yes"
13:56 Joubu ashimema's jsfiddle issue was a wrong cast to number for the paid value, so the validate plugin was comparing string, not number (alpha comparaison)
13:57 kohaputti Joubu, there is one tiny follow-up in my branch also if you have time to cherry-pick it
13:57 Joubu kohaputti: ideally we should push 15522 and so regression to smart-rules could be ignored..
13:58 Joubu kohaputti: done
13:59 kohaputti well I'm pretty much done with reviewing smart-rules.pl so no follow-ups there needed anymore (most likely...)
14:03 cait ashimema: I'll try to put something up about it later
14:06 Joubu kohaputti: what about the delete operation?
14:06 kohaputti delete of circ rule or refund policy?
14:06 kohaputti Joubu, I have not tested either of them yet after your follow-ups
14:07 kohaputti and I had some concerns your follow-up for circ rule deletion might not be correct but I will let you know when I test
14:07 kohaputti Joubu, aaah, you mean the set_rule mess
14:08 Joubu yes, set_rules is called when a rule is deleted
14:08 Joubu which seems wrong at first glance
14:08 kohaputti if you can investigate that would be nice, I still have some thousand lines to review.
14:16 kohaputti Joubu, something for you to cherry-pick on my branch
14:19 Joubu kohaputti: pushed, thanks
14:28 kohaputti http://paste.debian.net/plain/1127407 the Koha::Items import is most likely unnecessary but feeling too lazy to test...
14:30 Joubu kohaputti: will have a look
14:32 Joubu kohaputti: that was not in the original patchset:
14:32 Joubu -use Koha::IssuingRules;
14:32 Joubu +use Koha::CirculationRules;
14:32 Joubu use Koha::Items;
14:32 kohaputti ah, rebase issue then
14:32 Joubu so I am going to edit the commit and removing the add of Koha::Items
14:34 Joubu kohaputti: done
14:35 kohaputti in 4a0fa82a5b3ed2f493c55c1b74bf3dac2738c47f tcohen removed the Koha::Items import so rebase isssue it is
14:48 oleonard hi wizzyrea talljoy caroline_catlady
14:48 * cait wqaves
14:49 * cait waves
14:50 oleonard cait + wizzyrea + talljoy + caroline_catlady ... One more member of the Glorious Ladies of Koha to form their own Voltron.
14:50 talljoy good morning!
14:57 koha-jenkins Project Koha_19.11_D10 build #1: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_19.11_D10/1/
14:58 caroline_catlady maybe later we can have aleisha or hayley join us :)
14:58 oleonard Yes
15:02 kohaputti Joubu, will be next week until I'm done, I'm now going half way of the code and I still have to do some testing on intranet and REST API. Heading off to spend the weekend soon.
15:03 Joubu thanks kohaputti, enjoy your weekend!
15:04 Joubu kohaputti: I assigned you the bug report (QA contact)
15:06 kohaputti ok, could we use your sign-off in addition to me (QA) and ashimema (RM)?
15:07 Joubu ho right it's not signed off yet, I missed that!
15:07 kohaputti I don't remember how much of this you coded
15:07 ashimema 1
15:07 ashimema +1
15:08 Joubu kidclamp: were not you going to test bug 15522 and so 18936?
15:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , New interface for revamped circulation rules
15:09 kohaputti we could ask some librarian to test things on koha sandbox and get one sign off from them for this
15:09 Joubu kohaputti: talking about librarians you know?
15:10 kohaputti I could recruit some for this
15:10 Joubu that would be awesome
15:20 tcohen I can get users testing that bug Joubu
15:21 Joubu I would be in favor of testing 15522 directly
15:21 Joubu as it changes the UI
15:21 huginn News from kohagit: Bug 24509: Fix API relared tests failing on MySQL8 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8a468824fd32d96af9e43c26635491d6579c19e2>
15:21 huginn News from kohagit: Bug 24305: (QA follow-up) Strip table name in [[table.field|alias]] <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dc419ab2a9e7f3c49934272161597d903c24ea95>
15:21 huginn News from kohagit: Bug 24305: (follow-up) Add small comment for square brackets in get_prepped_report <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c3e96a900b5ab0ed12e6e58d29ed2b13ce31716d>
15:21 huginn News from kohagit: Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0c404e0529ace3ac2eee218c1d0451ace8cea857>
15:21 huginn News from kohagit: Bug 24503: fix missing use in value builder barcode_manual.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6a2223356bd332d666863cb9a75aad4c43c28b71>
15:21 huginn News from kohagit: Bug 23407: (QA follow-up) Same change for UNIMARC XSLT <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8894fcba9e512d9e03d5bcbb6facd934885112c>
15:21 huginn News from kohagit: Bug 23407: (QA follow-up) Remove some XSLT item leftovers <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9654dd74ff4317f1113c6589b2bed9eb6dc446e5>
15:21 huginn News from kohagit: Bug 24443: Unit test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=703fc7ad6363f09297c37152c49752630d8cb73d>
15:21 huginn News from kohagit: Bug 24443: Consider NULL as 0 for issues in items search <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=80f1374f262544a750b5d81a7d9605c8708c53b1>
15:21 huginn News from kohagit: Bug 23443: Do not checkin an item if checked out to another patron when lost fee... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=518bb04d8a56edceeada645755de69530844f435>
15:21 huginn News from kohagit: Bug 23443: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78ac663aa7947dd873ebdc748ff3e0abb0ed6823>
15:21 huginn News from kohagit: Bug 24305: Remove previous declaration of batch_biblionumbers <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3d388167698dbd43d42e1b0f83b435620d341cd8>
15:21 huginn News from kohagit: Bug 24305: Fix links to batch tools when report's columns do not contain integers <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00020bdfa9614b5627303fbd095e32b5cb5384b8>
15:22 huginn News from kohagit: Bug 23407: Don't process items for XSLT on details pages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7c2319f8070ee00c2cd1b2042754d9ad3b06bdc7>
15:23 kohaputti Joubu, there are some *s as parameters for Koha::CirculationRules->set_rules in t/db_dependent/Circulation/issue.t – but not sure we care about them for the tests – or is the plan to drop the * support at some point?
15:24 Joubu not important I'd say
15:24 kohaputti ok
15:26 kohaputti Joubu, but the librarians know how the old UI is supposed to work
15:26 kohaputti they don't know what the new one does
15:35 kohaputti Joubu, in t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t this looks dodgy: http://paste.debian.net/plain/1127423
15:36 koha-jenkins Project Koha_Master_D8 build #636: FAILURE in 13 min: https://jenkins.koha-community.org/job/Koha_Master_D8/636/
15:36 kohaputti onshelfholds => 0, vs onshelfholds => 2,
15:36 kohaputti and those other missing
15:36 kohaputti actually maxissueqty => 99,
15:36 kohaputti was not even in the old code
15:40 Nemo_bis Such a facepalm when you open an ExLibris product and the code still has "Aleph" over it, because of course the latest thing is a total rewrite which just happens to be very nostalgic.
16:02 koha-jenkins Project Koha_Master_D9_MDB_Latest build #86: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/86/
16:03 reiveune bye
16:15 kidclamp Joubu I asked our educators to test them, I thought they would be better at poking real life use cases
16:16 koha-jenkins Project Koha_Master_D9_My8 build #108: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/108/
16:33 koha-jenkins Project Koha_Master_D9 build #1099: STILL UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1099/
16:42 koha-jenkins Project Koha_Master_U18 build #570: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/570/
17:14 tcohen back
17:27 tcohen !start
17:27 AnnaBoten The hunt starts now!
17:35 AnnaBoten \_o< quack!
17:35 wahanui oops, slipped over
17:35 oleonard !bang
17:35 AnnaBoten \_x< oleonard: 1 (3.58 seconds)
17:41 AnnaBoten \_o< quack!
17:41 wahanui *click*
17:41 oleonard !bang
17:41 AnnaBoten \_x< oleonard: 2 (4.26 seconds)
17:46 AnnaBoten \_o< quack!
17:46 wahanui oops, slipped over
17:47 oleonard !bang
17:47 AnnaBoten \_x< oleonard: 3 (92.79 seconds)
17:47 AnnaBoten \o/ oleonard: 3 ducks out of 3: perfect!!! +5 \o/
17:47 AnnaBoten Best time: oleonard with 3.58 seconds
17:50 tcohen I get distracted by work, this is not fair
17:51 tcohen LOL
17:57 AnnaBoten \_o< quack!
17:57 wahanui !bang
18:06 oleonard !bang
18:06 AnnaBoten \_x< oleonard: 1 (554.21 seconds)
18:09 AnnaBoten \_o< quack!
18:09 wahanui oops, slipped over
18:15 davidnind !bang
18:15 AnnaBoten \_x< davidnind: 1 (355.53 seconds)
18:19 AnnaBoten \_o< quack!
18:19 wahanui oops, slipped over
18:21 oleonard !bang
18:21 AnnaBoten \_x< oleonard: 2 (98.52 seconds)
18:21 AnnaBoten [('oleonard', 2), ('davidnind', 1)]
18:21 AnnaBoten Best time: oleonard with 98.52 seconds
18:21 davidnind !bang
18:21 AnnaBoten There was no duck! davidnind: -1 (109.33 seconds)
18:21 davidnind :-(
18:28 AnnaBoten \_o< quack!
18:28 wahanui *click*
18:29 tuxayo[m] !bang
18:29 AnnaBoten \_x< tuxayo[m]: 1 (75.22 seconds)
18:36 AnnaBoten \_o< quack!
18:36 wahanui !bang
18:36 oleonard !bang
18:36 AnnaBoten \_x< oleonard: 1 (15.89 seconds)
18:38 AnnaBoten \_o< quack!
18:38 wahanui *click*
18:57 corilynn !bang
18:57 AnnaBoten \_x< corilynn: 1 (1126.00 seconds)
18:57 AnnaBoten [('tuxayo[m]', 1), ('oleonard', 1), ('corilynn', 1), ('davidnind', -1)]
18:57 AnnaBoten Best time: oleonard with 15.89 seconds
18:59 AnnaBoten \_o< quack!
18:59 wahanui *click*
19:05 tcohen !bang
19:05 AnnaBoten tcohen, you missed the duck!
19:05 corilynn !bang
19:05 AnnaBoten \_x< corilynn: 1 (338.01 seconds)
19:05 tcohen hmpf
19:12 AnnaBoten \_o< quack!
19:12 wahanui oops, slipped over
19:12 oleonard !bang
19:12 AnnaBoten \_x< oleonard: 1 (3.89 seconds)
19:20 AnnaBoten \_o< quack!
19:20 wahanui *click*
19:32 tcohen !bang
19:32 AnnaBoten \_x< tcohen: 1 (678.37 seconds)
19:32 AnnaBoten [('tcohen', 1), ('oleonard', 1), ('corilynn', 1)]
19:32 AnnaBoten Best time: oleonard with 3.89 seconds
19:33 AnnaBoten \_o< quack!
19:33 wahanui oops, slipped over
22:15 Marie-Luce !bang
22:15 AnnaBoten \_x< Marie-Luce: 1 (9692.38 seconds)
22:20 AnnaBoten \_o< quack!
22:20 wahanui !bang