Time Nick Message
03:00 Amit_Gupta hi All
03:00 Amit_Gupta GM
03:01 hayley hello
03:05 tcohen hi all
03:21 aleisha hey can anyone help me with some DBIx stuff? i'm trying to join two tables and specify the join condition to something new (i.e. reserves and items, join on biblionumber). any ideas?
03:28 tcohen aleisha: what's your query?
03:29 aleisha i think i actually figured it out
03:29 aleisha kind of
03:31 tcohen This is THE reference https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Joining.pod
03:32 aleisha i just didnt know where to put it
03:32 aleisha it works when i put it at the bottom of the schema file
03:32 tcohen are you adding a new relation?
03:33 tcohen is this Koha?
03:34 aleisha yes :) dont worry i sorted it
03:34 aleisha thanks!
03:34 tcohen if you are working on Koha, and are creating a new constraint, the update_dbix_class script should generate the relation
03:34 aleisha was adding a new one
03:35 tcohen an unwritten guideline about relations
03:35 tcohen they need to be named as the accessor you're going to use on the Koha::Object-derived class
03:37 tcohen so if you are adding (say) Koha::Patron->holds there needs to be a 'holds' relationship in the Borrower.pm schema file
03:37 aleisha yup :) got it
03:37 tcohen that way we can prefetch things using the same name
03:37 tcohen ok
03:38 * tcohen stops over explaining
03:38 tcohen I just found there's no written rule (yet) about it
03:38 tcohen good night
03:38 aleisha thanks !
07:32 marcelr hi #koha
07:33 liliputech_asu hi marcelr (&all)
07:33 marcelr hi liliputech_asu
07:47 reiveune hello
07:55 * magnuse waves
08:01 alex_a Bonjour
08:54 huginn News from kohagit: Bug 24481: DBRev 19.12.00.012 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0ad865d8222adc3c2fde88a7d1572060c357e508>
08:54 huginn News from kohagit: Bug 24481: Permissions update for POS menu include <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=451752009243fdfa6ddbb51a0f5a070f982e0ad6>
08:54 huginn News from kohagit: Bug 24481: Permission corrections for admin menu templates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8604e82db11944276a59ec5ea554599fd7111a1f>
08:54 huginn News from kohagit: Bug 24481: Move manage_cash_registers to parameters permission <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=637afc8f6dbf9143380ad05a7331186a871f089f>
08:54 huginn News from kohagit: Bug 24481: Correct permission name in admin/cash_registers.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=035d58617358be473503d8861359b55922ada9a3>
08:54 huginn News from kohagit: Bug 24477: Require `takepayment` permission in pos/pay.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7015ba70599b96c6cdfc733b704a328afd000ba2>
08:54 huginn News from kohagit: Bug 24432: Use from_api_mapping to translate column name in _build_order_atom <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=451bc0fca595f426257b4a790fc6f83cc10f32f9>
08:54 huginn News from kohagit: Bug 24432: add Koha::Objects->from_api_mapping <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=62da76b84b4714851a1be3d33a565382d5d1037a>
08:54 huginn News from kohagit: Bug 24432: Regresion test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d8bd366b5c5ce36e52b3c8466d08feeeed5098d9>
09:11 huginn News from kohagit: Bug 24441: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3760af11f7b098b8de68ce4429d348737caf4be1>
09:11 huginn News from kohagit: Bug 24345: Fix OPACViewOthersSuggestions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c61876322213d9a70edc12b033894217d2116391>
09:11 huginn News from kohagit: Bug 24459: Make ->to_api pass $params through <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1e52cb442b57248b837a73a5e2d7a59fb10ee42e>
09:11 huginn News from kohagit: Bug 24459: Regression tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e003a3c16495c8f488a2970b57e00e1070f64e7d>
09:11 huginn News from kohagit: Bug 24457: Make overloaded ->to_api pass the params to parent method <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cf038dd938636303c3936ce186f1a64ae9cf10db>
09:11 huginn News from kohagit: Bug 24457: Regression tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8e399b62e78d56d7437597ea589af64954005ca>
09:11 huginn News from kohagit: Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0dbf76c290f031e58dcb04e16047f1bd984560ef>
09:11 huginn News from kohagit: Bug 24397: Remove out of sync script populate_db.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=991f51b27240bd5d5e2ce302db7260f17d7e680c>
09:11 huginn News from kohagit: Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ed5ec62cac48a96413a9e468d8bacc2a4ef80ea5>
09:11 * cait lights the oleopard signal
09:11 huginn News from kohagit: Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78190371d00cb91ae668eb3d28a48ef33c112676>
09:11 huginn News from kohagit: Bug 24236: Fix pagination to use query_cgi <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=367df45840cf4b829c0757144a83db42c9ada92f>
09:11 huginn News from kohagit: Bug 23064: Use Koha::Subscription in ModSubscription <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1c07cacff2b41a9b58f8999b3565a888b018fbf9>
09:18 cait @later tell oleonard *ligted the oleopard signal* - can I pick your mind about a bug?
09:18 huginn cait: The operation succeeded.
09:20 ashimema ll
09:20 ashimema morning #koha
09:20 ashimema see you were busy lat night cait.. thanks :)
09:21 ashimema * see you were busy last night cait.. thanks :)
09:21 cait trying... but got to sleep sometime :)
09:22 cait at least that's what THEY keep telling me...
09:23 davidnind cait++
09:30 sjamso Hello Everyone. I was trying to install SSL certificate for my Koha site. Its works for OPAC but does not work with staff client. Any solution to this?? Please help!!!
09:34 davidnind sjamso: might not be much help here, but u=if you are using port numbers did you add that to ports.conf for your Apache configuration? Or are you using a full domain name?
09:34 liliputech_asu sjamso: if you're using domain-name then there is little chance you can use the same certificate for both interfaces :/
09:34 magnuse cait++
09:35 koha-jenkins Project Koha_Master_D9_MDB_Latest build #80: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/80/
09:35 magnuse sjamso: are you using letsencrypt?
09:36 magnuse if you are, and you have different domains for opac and staff, you need to tell letsencrypt to create one cert for both domains
09:37 magnuse or two different certs, one for each domain
09:42 koha-jenkins Project Koha_Master_U18 build #565: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U18/565/
09:51 koha-jenkins Project Koha_Master_D9_My8 build #103: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/103/
09:55 sjamso @magnuse. Thank you. Yes I am using one domain with two different ports.
09:55 huginn sjamso: I suck
09:56 sjamso and I am using lestencrypt
09:57 magnuse sjamso: and you have added the ssl configs to both the opac and the staff virtualhosts in the apache site config?
09:57 sjamso @magnuse Ok. I will try with two separate domain for OPAC and staff client and create separate certificate and try
09:57 huginn sjamso: downloading the Perl source
09:57 magnuse is the installation public, so we can se how it behaves?
09:58 sjamso yes . its public
09:58 magnuse one domain and different ports should be easier to set up
09:58 sjamso @magnuse https://library.jnec.edu.bt
09:58 huginn sjamso: I'll give you the answer just as soon as RDA is ready
09:58 wahanui i already had it that way, huginn.
09:59 sjamso https://library.jnec.edu.bt:8080 doesn't work
09:59 sjamso @huginn thank you.
09:59 huginn sjamso: I've exhausted my database of quotes
10:02 sjamso @magnuse . Yes. One domian and two different ports would be easier but I could not get it work
10:02 huginn sjamso: I'll give you the answer as soon as RDA is ready
10:02 wahanui i already had it that way, huginn.
10:02 ashimema silly question.. are you sure your firewall is open for 8080..
10:02 * ashimema joins the conversation late
10:03 sjamso @ashimema 8080 is open and it works without SSL. But after installing SSl the staff client didn't work for me.
10:03 huginn sjamso: I've exhausted my database of quotes
10:04 davidnind I'm getting this error in Firefox: Error code: SSL_ERROR_RX_RECORD_TOO_LONG
10:05 koha-jenkins Project Koha_Master_D8 build #631: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D8/631/
10:06 cait hm i have seen that before
10:06 magnuse if i request the staff without https it works
10:07 cait trying to see if i can find something in our archive
10:07 magnuse if i add https i get ERR_SSL_PROTOCOL_ERROR
10:07 cait are we talking about the same installation here?
10:07 sjamso @magnuse yes. it works without https. I want to make it work with SSL also.
10:07 huginn sjamso: downloading the Perl source
10:08 magnuse my first thought is that the staff part of the apache config is missing the ssl stuff
10:08 magnuse or it is not configured right
10:08 ashimema +1 magnuse.. that's my thining too
10:08 magnuse sjamso: do you have access to look into the apache config?
10:08 sjamso @cait we are discussing on SSL
10:08 huginn sjamso: downloading the Perl source
10:09 cait hm didn't come up with anything
10:09 sjamso @magnuse. Yes I have access
10:09 huginn sjamso: I've exhausted my database of quotes
10:09 magnuse /etc/apache2/sites-enabled/<instancename>.conf
10:12 magnuse there are two sections that start with <VirtualHost in there, do both have the settings "SSLEngine on" etc?
10:12 davidnind :q
10:13 sjamso @magnuse.. SSLCertificateFile /etc/letsencrypt/live/library.jnec.edu.bt/fullchain.pem SSLCertificateKeyFile /etc/letsencrypt/live/library.jnec.edu.bt/privkey.pem Include /etc/letsencrypt/options-ssl-apache.conf
10:13 huginn sjamso: downloading the Perl source
10:14 magnuse sjamso: looks good, i think, and do you have that two times in the apache config file?
10:14 sjamso @magnuse. It does not start with "SSLEngine on"
10:14 huginn sjamso: I've exhausted my database of quotes
10:14 magnuse hm, i will show you an example from one of my sites
10:15 davidnind What do you have in your ports.conf file? Using SSL the port numbers need to be inside the <IfModule ssl_module> directive - Listen 443 and Listen 8080 as well
10:16 sjamso @magnuse for SSL another file is create "library-le-ssl.conf"
10:16 huginn sjamso: I'll give you the answer as soon as RDA is ready
10:16 wahanui i already had it that way, huginn.
10:16 pastebot "magnuse" at 127.0.0.1 pasted "Sample https config" (56 lines) at http://paste.koha-community.org/18778
10:16 magnuse ooh, good point davidnind
10:17 sjamso @davidnind, I have 80 and 8080 only
10:17 huginn sjamso: downloading the Perl source
10:17 sjamso @davidnind.. let me conform
10:17 huginn sjamso: I suck
10:18 pastebot "magnuse" at 127.0.0.1 pasted "/etc/apache2/ports.conf" (4 lines) at http://paste.koha-community.org/18779
10:18 magnuse ports.conf should look like that, i think ^
10:19 magnuse (sjamso: if you drop the @ in front of usernames huginn (a bot) will be less noisy :-)
10:19 sjamso @magnuse..<IfModule ssl_module> Listen 443 </IfModule> . i have just 443
10:19 huginn sjamso: downloading the Perl source
10:20 magnuse if you want to run on ports 80 and 8080 you need to add "Listen 80" and "Listen 8080" to ports.conf, inside the IfModule
10:24 sjamso @magnuse I get apache error with that. AH00526: Syntax error on line 9 of /etc/apache2/ports.conf: Jan 23 10:22:37 koha apachectl[11460]: Cannot define multiple Listeners on the same IP:port
10:24 huginn sjamso: I've exhausted my database of quotes
10:25 magnuse sjamso: do you have "Listen 80" both inside and outside of IfModule, perhaps?
10:26 magnuse or "Listen 8080"
10:27 sjamso @magnuse . Ok. My bad!!!
10:27 huginn sjamso: I'll give you the answer as soon as RDA is ready
10:27 wahanui i already had it that way, huginn.
10:28 koha-jenkins Project Koha_Master_D9 build #1094: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1094/
10:29 sjamso @magnuse I did remove "Listen 8080" from outside and put it under <IfModule ssl_module> directive along with Listen 443 but still the page is not accessible
10:29 huginn sjamso: downloading the Perl source
10:30 sjamso @magnuse.. Listen 80 <IfModule ssl_module> Listen 443 Listen 8080 </IfModule> <IfModule mod_gnutls.c> Listen 443 </IfModule>
10:30 huginn sjamso: I'll give you the answer as soon as RDA is ready
10:30 wahanui i already had it that way, huginn.
10:32 magnuse hm, i get "ERR_CONNECTION_CLOSED"
10:33 magnuse both for opac and staff
10:33 magnuse try running "sudo apache2ctl -t" and see if that gives anything interesting
10:34 magnuse sjamso: would you mind sharing the whole apache config file with us? (do not paste it in irc, but use http://paste.koha-community.org/)
10:34 sjamso @magnuse opac works but not the staff client
10:34 huginn sjamso: I've exhausted my database of quotes
10:35 magnuse ah, yes, so it does. good! :-)
10:36 sjamso @magnuse. i have added all the ports in same directives <IfModule ssl_module> Listen 443 Listen 80 Listen 8080 </IfModule>
10:36 huginn sjamso: I've exhausted my database of quotes
10:37 sjamso still not luck for staff client
10:37 magnuse no, so we must fix that :-)
10:38 magnuse the main thing is you need to have the same SSL* settings inside the config for the staff client as you have inside the config for the opac
10:38 magnuse like i do in the example i pasted
10:41 sjamso @magnuse., I just followed the instruction by letsencrypt. https://certbot.eff.org/lets-encrypt/ubuntubionic-apache
10:41 huginn sjamso: I suck
10:41 huginn News from kohagit: Bug 24478: DBRev 19.12.00.013 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=435e80fb8d3e011491d439d617014ed15bf8ff44>
10:41 huginn News from kohagit: Bug 22831: (RM follow-up) Code golf <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=56fcf5a34d580026e0799baf07b537ac5bc43bb5>
10:41 huginn News from kohagit: Bug 24149: (QA follow-up) Add pod for Koha::Statistics->object_class <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ddb51a7f26a83eeb27259836048b18acfe20c1f9>
10:41 huginn News from kohagit: Bug 24025: Make CodeMirror content searchable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=15f73bcf5ebf5bb8996dbc4b98e74ddc238bbe3c>
10:41 huginn News from kohagit: Bug 24478: Use `EnablePointOfSale` preference <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b2d557d424b6060e0856040fdbe2121a1f37ab2c>
10:41 huginn News from kohagit: Bug 19809: Remove some new occurrences <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=127dfc0b8fddfc0c409bd5fc6d76b131369a1324>
10:41 huginn News from kohagit: Bug 24478: Add `EnablePointOfSale` system preference <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=11112b22cbc1a6b336fab9c076bfd6a23ed63e81>
10:41 huginn News from kohagit: Bug 24452: Advanced editor - show multiple spaces visually <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=44ab1fd5c70e7ba825ee9c37ed616d332f2d8bde>
10:41 huginn News from kohagit: Bug 24478: Fix sequence in sysprefs.sql and add missing comma <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=83d98dfad595421a6e03364fd36c42de5c14daf5>
10:41 huginn News from kohagit: Bug 24149: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9520baf0a0a4f9bd4803d745bb33a200febe974>
10:41 huginn News from kohagit: Bug 24149: Add Koha::Statistic->item <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e737f46c394f20091b2e7da20cc84e441561af06>
10:41 huginn News from kohagit: Bug 24149: Add Koha::Statistic[s] classes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=346d6031db3cc6e33abf7d913a982d5711a463fa>
10:41 huginn News from kohagit: Bug 24105: Fix error when running longoverdue.pl with --itemtypes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6fa4fbbbd7a80c0d74f5548f4fa746c4cf85ed1d>
10:41 huginn News from kohagit: Bug 22831: (follow-up) Sort results, group by db <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e9f7a0dd1cef9e32ec6b93fa3cfed5711f84a64c>
10:41 huginn News from kohagit: Bug 22831: (follow-up) Determine where the record is missing and provide link, show... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d5c79c201d5602245d173f6142ab5bb5b29e9c43>
10:41 huginn News from kohagit: Bug 23884: Merge strings.inc and browser-strings.inc <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=164c228e97ba9f313351c0a5c50ce1370ef0fae3>
10:41 huginn News from kohagit: Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2b32aee8258002269ab4d789496ea188465d016a>
10:41 huginn News from kohagit: Bug 19809: Re-allow to call Koha::Objects::find in list context <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0e73e723efa4db15d2c4ab1404fb8b50b0f61380>
10:41 magnuse sjamso: yeah, but i think those instructions might not work if you have two configs in the same file, like we do with the standard koha setup
10:45 sjamso @magnuse http://paste.koha-community.org/18780
10:45 huginn sjamso: I've exhausted my database of quotes
10:47 mtj hi sjamso, your apache config wont work
10:47 sjamso @magnuse this is the ssl file http://paste.koha-community.org/18781
10:47 huginn sjamso: I've exhausted my database of quotes
10:48 sjamso @mtj.. will need your help
10:48 huginn sjamso: downloading the Perl source
10:48 mtj ..to fix your problem you will need to move admin/staff interface from 8080 to 80
10:48 mtj http://library.jnec.edu.bt
10:48 mtj http://library-admin.jnec.edu.bt
10:48 ashimema hi mtj :)
10:48 sjamso @mtj .. you mean I have to give different domain
10:48 huginn sjamso: I'll give you the answer just as soon as RDA is ready
10:48 wahanui i already had it that way, huginn.
10:49 ashimema do be quiet huginn
10:50 magnuse mtj: i think it should be possible with 1 domain/ 2 ports too?
10:51 magnuse anyway, really sorry, but i gotta go get some lunch
10:51 mtj hi ashimema, just saw your dep. msg
10:51 ashimema dug a little further
10:52 sjamso @magnuse thank you for your help. I will work on it in the mean time
10:52 huginn sjamso: I'll give you the answer just as soon as RDA is ready
10:52 wahanui i already had it that way, huginn.
10:52 ashimema I think it's because we end up pulling a newer version of JSON::Validator from the debian repo's than we want to.. we're not pinned back to the version on our koha/distro repo
10:53 mtj magnuse: i think its not possible unless NameVirtualHost are used
10:53 ashimema tomas was saying mirko had a hack around that somehow.. renaming the package or something like that?
10:54 ashimema what we should really do is fix versions for Mojolicious, OpenAPI and JSON::Validator as they are all very closely tied and shouldn't really be upgraded in the background without us having tested the combination
10:54 davidnind sjamso: you need SSL configuration directives inside both the virtual hosts, like the one magnuse posted. In your one you only have them in the :80 one.
10:55 sjamso @davidnind thank you. I will try as suggested by @magnuse
10:55 huginn sjamso: I suck
11:02 mtj ashimema: agree :)
11:04 mtj ..i think the best plan is to take the testing/bullseye libmojolicious-plugin-openapi-perl package
11:06 ashimema sounds reasonable..
11:06 mtj ..and test it with the stable/buster versions of libjson-validator-perl, libmojolicious-perl and libyaml-libyaml-perl
11:06 ashimema I've not hugely kept up with what's been happening in that plugin of late.. I used to be a core contributor there way back when..
11:06 ashimema also not entirely sure if we're doing anything unexpected at our end with it.
11:06 ashimema good plan
11:06 mtj https://packages.debian.org/bullseye/libmojolicious-plugin-openapi-perl
11:07 mtj ^ you can see it wants a newer version of libjson-validator-perl (>= 3.15)
11:07 mtj stable only has libjson-validator-perl (3.06), etc..
11:08 mtj ..so we might need to grab libjson-validator-perl (3.17) from testing etc
11:09 ashimema yup
11:11 mtj so worst case situ means that pulling libmojolicious-plugin-openapi-perl (2.20-1) from testing
11:12 mtj ... means we need to backport https://packages.debian.org/bullseye/libjson-validator-perl too
11:13 mtj ..and a few other testing/bullseye deps too
11:13 ashimema sorry it's all ended up so complicated
11:14 koha-jenkins Project Koha_Master_D9_My8 build #104: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/104/
11:14 mtj one thing i have not tested is using libmojolicious-plugin-openapi-perl (2.20-1) with buster's old packages
11:14 koha-jenkins Project Koha_Master_U18 build #566: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_U18/566/
11:16 mtj ashimema: no probs :)
11:21 koha-jenkins Project Koha_Master_D9_MDB_Latest build #81: UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/81/
11:33 kohaputti Joubu, going at line 430 of the circ rule diff that is in total 7439 lines :o
11:37 Joubu 15522 is 33 files changed, 3847 insertions(+), 1860 deletions(-)
11:37 Joubu but
11:37 Joubu admin/smart-rules.pl | 617 --------------------------------------------------
11:37 Joubu koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 1037 ------------------------------------------------------------------------------------
11:37 Joubu yarn.lock | 1681 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
11:37 Joubu that does not count
11:38 Joubu sorry for that ugly c/p output :)
11:45 koha-jenkins Project Koha_Master_D8 build #632: UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D8/632/
12:01 koha-jenkins Project Koha_Master_D9 build #1095: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1095/
12:20 tuxayo[m] Hi Koha :)
12:20 tuxayo[m] o/
12:24 koha-jenkins Project Koha_Master_D9_My8 build #105: STILL UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/105/
12:36 oleonard Hi #koha
12:36 tuxayo[m] o/ oleonard
12:49 koha-jenkins Project Koha_Master_D9_MDB_Latest build #82: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/82/
12:52 koha-jenkins Project Koha_Master_U18 build #567: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U18/567/
13:08 tcohen morning
13:09 oleonard Hi tcohen
13:10 tcohen oleonard my email never reached the koha-devl list, right?
13:10 oleonard Not that I saw tcohen
13:10 tcohen its the illuminati
13:11 Joubu it contained pictures
13:12 tcohen wow
13:12 tcohen that's too 2019 dude
13:13 oleonard No, we don't want the mailing lists to become the wild west
13:14 oleonard Or maybe the mailing list uses the same filter Tumblr uses to flag adult content. Those screenshots were dangerously sexy
13:15 tuxayo[m] few hundred kilobyte per picture times the number of subcribers, that's a lot of space
13:15 tcohen yes yes, I know
13:15 tuxayo[m] hue hue hue
13:15 tuxayo[m] tcohen: solution: self destructing images after few months: https://framapic.org/
13:16 tcohen I expected some moderator to say 'hey, this is safe'
13:16 tcohen but yeah, will stick with other options next time
13:16 oleonard tcohen: Next time make it a Flash movie
13:17 tuxayo[m] I guess that was too shocking even for a human filter.
13:17 tuxayo[m] Some nasty bug are just too much.
13:17 tcohen I think I will start a blog on Theke's site
13:17 tcohen and just send a link there
13:17 tuxayo[m] For nasty pictures?
13:17 tcohen it was just a screenshot of two simple methods (Perl code)
13:18 tcohen to highlight a point
13:18 oleonard tcohen: There are some great ideas out there for blog content: https://www.buzzfeed.com/joannaborns/incorrect-food
13:19 tuxayo[m] > it was just a screenshot of two simple methods
13:19 tuxayo[m] I guess it didn't pass QA then
13:19 tcohen hehe, we have a Theke blog, I will post there
13:21 tuxayo[m] question for users of `koha-testing-docker`: are some test failures expected?
13:21 tuxayo[m] I just did `ku` and `prove -r t/ xt/` in the container
13:22 tuxayo[m] I would have though to have the same results as: https://jenkins.koha-community.org/view/Koha%20Master/job/Koha_Master_D9/
13:24 tcohen did you run that inside a koha-shell?
13:25 tcohen kshell
13:25 tcohen then prove -r t/ xt/
13:25 tcohen the db_dependent tests require many things set in ENV
13:25 tcohen which are per-instance
13:25 tcohen so you need to be inside the instance's shell
13:26 tcohen kshell is your friend
13:26 tuxayo[m] Yes, almost all test passed
13:26 tuxayo[m] Like 5 have failed:
13:26 tuxayo[m] https://framabin.org/p/?83ae275cc2b4ed7c#wCgqBucGaJ1VUkiv9lI7d+8s9gEaiJOe/pWYjO3yWcM=
13:26 tuxayo[m] Elasticsearch => false positive
13:28 kohaputti Joubu, check Koha/CirculationRules.pm article_requestable_rules()
13:28 Joubu tuxayo[m]: what are the errors of valid-xml, strict and TestBuilder?
13:28 kohaputti the categorycode => [ $category, '*' ] is there with a *
13:28 tuxayo[m] Then I got stuff like
13:28 tuxayo[m] - Can't locate Array/Utils.pm in @INC
13:28 kohaputti in the other cases the rules are search with the primary search value and then defaulting to undef / null
13:29 Joubu tuxayo[m]: it's a new fresh dependency
13:29 Joubu install it
13:29 kohaputti Joubu, but as I noticed yesterday the search with undef doesn't appear to work the same way as it did in the old code with *
13:29 ashimema you is too quick kohaputti
13:29 ashimema :)
13:30 ashimema new deps take a night or so to go into the nightly packages ;)
13:30 ashimema I need the automated build scripts to spit out a patch and then I apply said patch assuming it's sane.. then the next night the automated build uses the patched code to build new packages
13:30 ashimema took me ages to get my head around that
13:30 tuxayo[m] Thanks Joubu , I'm suprised that doesn't fail in CI. Are the new deps installed manually there?
13:31 tuxayo[m] TestBuilder error:
13:31 tuxayo[m] https://framabin.org/p/?cb75da4c56eb8a7b#1ais9aBs4XRHboASsciDQuhddp8tAuN5V7lryRxrYfQ=
13:31 ashimema I only pushed it a few minutes ago.. it probably is/will fail any minutes ;)
13:31 tuxayo[m] hoooo
13:31 Joubu https://jenkins.koha-community.org/job/Koha_Master_D9/lastCompletedBuild/consoleFull
13:31 Joubu it does
13:32 tuxayo[m] My bad, I though yellow was OK but it's "unstable"
13:33 Joubu kohaputti: good catch, that's obviously wrong
13:33 Joubu (what happens when there is no test...)
13:33 kohaputti Joubu, I'm checking whether we have atomic upgrade to convert * -> NULL
13:34 kohaputti (that could be one reason the stuff don't work as I expect
13:34 tuxayo[m] The only remaining issue is about the valid XML and it's due to the test going in the node_modules directory
13:34 Joubu kohaputti: yes we have a IF()
13:34 Joubu SELECT IF(categorycode='*', NULL, categorycode), IF(branchcode='*', NULL, branchcode), IF(itemtype='*', NULL, itemtype), \'$column\', COALESCE( $column, '')
13:34 tcohen Joubu kohaputti curious: what are you talking aobut?
13:34 Joubu bug 18936
13:34 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Convert issuingrules fields to circulation_rules
13:35 kohaputti tcohen, this test failed here because we didn't fallback to * rules: https://gitlab.com/joubu/Koha/commit/0aa846e8a6821b1feef74bc65afead74f3c4ff2a
13:38 Joubu kohaputti: I am expecting tests in t/db_dependent/Koha/IssuingRules.t to back me on that
13:41 marcelr oleonard: bug 13305; if you could sign off within the next six years or so :)
13:41 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 minor, P5 - low, ---, m.de.rooy, Needs Signoff , Fix tab order in cataloguing/item editor
13:43 oleonard marcelr: My schedule for the next six years is wide open! :D
13:44 marcelr hope nobody heard that..
13:44 kohaputti Joubu, we need to add new test for this fallback bug – I'm working on it.
13:45 Joubu kohaputti: I am about to push something
13:45 kohaputti ok
13:46 kohaputti the buggy function appears to be get_effective_rule()
13:46 kohaputti or its callee
13:46 Joubu done
13:46 marcelr Joubu: did you resolve all the bugs?
13:47 Joubu kohaputti: the test I wrote tell me we are good. What am I missing?
13:47 Joubu marcelr: all the Koha bugs?
13:47 Joubu not yet, sorry
13:48 kohaputti Joubu, so open this https://gitlab.com/joubu/Koha/commit/0aa846e8a6821b1feef74bc65afead74f3c4ff2a and I will explain ...
13:48 Joubu yup
13:49 kohaputti before running that test I have added a circulation rule to circulation_rules table with branchcode = NULL, categorycode=NULL, itemtype=NULL, rule_name=, lengthunit=days
13:49 kohaputti so it should fallback to that rule but it doesn't
13:50 kohaputti I mean if we don't have that commit fixing the test it fails since it doesn't fallback to the rule I have in the database
13:51 kohaputti the code in the get_effective_rule() looks like it tries to fallback to the rules with branchcode,catcode,itemtype = NULL but in reality it doesn't do that
13:52 kohaputti Joubu, see the line
13:52 kohaputti search_params->{categorycode} = defined $categorycode ? [ $categorycode, undef ] : undef;
13:52 kohaputti in the function
13:52 Joubu yes
13:53 kohaputti is the intention of this falling back to the rules with null values?
13:53 Joubu yes
13:53 kohaputti ok so we need a test for this now since it is not working
13:53 Joubu I thought it is what I test with my last patch
13:54 * Joubu burns his English grammar book
13:58 cait you got one?
13:59 cait thinking about it... it hink i still have my old grammar books from school
13:59 marcelr i hink that incorrect
14:00 oleonard Hi cait, I got your @later
14:02 cait :)
14:03 cait Joubu says he had already asked you
14:03 cait I was irritated by bug 2394
14:03 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 major, P3, ---, gmcharlt, CLOSED FIXED, canreservefromotherbranches preference not working
14:03 cait um not that one
14:03 cait bug 23594
14:03 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 new feature, P5 - low, ---, jonathan.druart, Needs Signoff , Batch modification for itemtypes on suggestions page
14:07 Joubu cait: It was already burnt actually :D
14:07 cait I shoudl follow you rexample :)
14:08 * ashimema is loving the feedback loop going on for the point of sale bugs
14:12 kohaputti so the bug I thought there was with fallbacking to circ rules was caused by me forgetting to do "updatedatabase"
14:12 caroline_crazycatlady good morning!
14:14 kohaputti Joubu, I have to continue the review tomorrow unfortunately but hopefully we will be done then with this
14:16 Joubu thanks kohaputti!
14:17 kohaputti Joubu, will you send follow-up for article_requestable_rules()?
14:17 Joubu yes
14:17 kohaputti great, now I'm off -->
14:17 Joubu and I will work on a patch for misc4dev
14:20 tuxayo[m] Should the following test exclude node_modules?
14:20 tuxayo[m] https://gitlab.com/tuxayo/Koha/blob/master/t/00-valid-xml.t#L32
14:20 tuxayo[m] It's normal to have the node_modules folder if working on CSS right? If so, then the test shouldn't scan it to avoid false positive.
14:27 tuxayo[m] *It is
14:33 magnuse kohaputti++
14:33 Joubu tuxayo[m]: do you have xml file in node_modules
14:33 Joubu ?
14:37 * tuxayo[m] sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/yNqzchgwMFmSurSCQLoMMhVq >
14:38 tuxayo[m] damn
14:38 tuxayo[m] take 2:
14:38 tuxayo[m] Joubu:
14:38 tuxayo[m] ./node_modules/json-schema/draft-zyp-json-schema-03.xml
14:38 tuxayo[m] and
14:38 tuxayo[m] ./node_modules/json-schema/draft-zyp-json-schema-04.xml
14:39 tcohen node_modules is not part of the repo
14:40 tcohen and it is present, but should be skipped
14:47 Joubu u
14:47 Joubu indeed, it fails for me as well
14:48 tuxayo[m] So is it relevant that I sent a patch to skip node_modules?
14:48 tuxayo[m] *send
14:48 Joubu tuxayo[m]: you won the opening of a new bug report
14:48 Joubu yes
14:49 tuxayo[m] Indeed, that for plan :)
14:51 tuxayo[m] *was
14:51 tuxayo[m] *the
15:18 Joubu @later tell kohaputti follow-ups pushed to fix 1. new installs, 2. * vs undef in article_requestable_rules. Also you should consider to use the branch bug_18936 from my koha-misc4dev repo (that will fix reset_all)
15:18 huginn Joubu: The operation succeeded.
15:18 Joubu @later tell kohaputti I also removed your follow-up which was adding the rule in Fees.t, I think it does not longer make sense
15:18 huginn Joubu: The operation succeeded.
15:23 oleonard !bang
15:23 AnnaBoten There is no hunt right now! You can start a hunt with the 'start' command
15:24 ashimema one cannot have two subpermissions (of different flags) that have the same name at the moment can one?
15:25 * ashimema wants a distinct 'refund' permission assigned to the cash_management flag to go with the one under 'updatecharges'
15:27 ashimema only place I can see it being an issue though perhaps is the permissions.inc template
15:38 tuxayo[m] Does anyone else gets a failure on TestBuilder.t ?
15:38 tuxayo[m] https://framabin.org/p/?1ee84ecbdc289b77#quUU4qPxqVCKLHd+A/Qn5TMeKLA4JdWimIjt17gn8aE=
15:38 tuxayo[m] Module Koha::Statistics should have koha_object[s]_class method if needed
16:14 huginn News from kohagit: Bug 24080: (RM follow-up) Add payout to 'accounts.inc' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9597a384f3d714c866ca6fc58d480495384e65d7>
16:15 huginn News from kohagit: Bug 23442: (RM follow-up) Add 'Refund' to accounts.inc <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=697ba67bc520bb1485025b9229bf0adc40540b61>
16:15 huginn News from kohagit: Bug 23442: (RM follow-up) Fix for missing 'uc' in offset_type call <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=83a9c309c8a1d0b9db27d5cc77def9dd5ebe5e37>
16:18 reiveune bye
16:55 koha-jenkins Project Koha_Master_D9_MDB_Latest build #83: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/83/
17:05 koha-jenkins Project Koha_Master_U18 build #568: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U18/568/
17:12 koha-jenkins Project Koha_Master_D9_My8 build #106: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/106/
17:25 koha-jenkins Project Koha_Master_D8 build #633: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D8/633/
17:28 ashimema seems out js validator can't do decimals!
17:28 ashimema aparently 99.99 is more than 100.00
17:30 oleonard ashimema: Using the "number" setting?
17:54 koha-jenkins Project Koha_Master_D9 build #1096: STILL UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1096/
18:27 tcohen hi
18:27 tcohen !start
18:27 AnnaBoten The hunt starts now!
18:32 AnnaBoten \_o< quack!
18:32 wahanui oops, slipped over
18:32 oleonard !bang
18:32 AnnaBoten \_x< oleonard: 1 (3.99 seconds)
18:36 AnnaBoten \_o< quack!
18:36 wahanui *click*
18:36 oleonard !bang
18:36 AnnaBoten \_x< oleonard: 2 (3.97 seconds)
18:38 AnnaBoten \_o< quack!
18:38 wahanui *click*
18:38 oleonard !bang
18:38 AnnaBoten \_x< oleonard: 3 (3.44 seconds)
18:38 AnnaBoten \o/ oleonard: 3 ducks out of 3: perfect!!! +5 \o/
18:38 AnnaBoten Best time: oleonard with 3.44 seconds
18:40 AnnaBoten \_o< quack!
18:40 wahanui *click*
18:45 oleonard !bang
18:45 AnnaBoten \_x< oleonard: 1 (334.49 seconds)
18:46 AnnaBoten \_o< quack!
18:46 wahanui !bang
18:47 oleonard !bang
18:47 AnnaBoten oleonard, you missed the duck!
18:49 oleonard !bang
18:49 AnnaBoten \_x< oleonard: 2 (160.68 seconds)
18:55 AnnaBoten \_o< quack!
18:55 wahanui !bang
18:57 oleonard !bang
18:57 AnnaBoten \_x< oleonard: 3 (91.87 seconds)
18:57 AnnaBoten \o/ oleonard: 3 ducks out of 3: perfect!!! +5 \o/
18:57 AnnaBoten Best time: oleonard with 91.87 seconds
19:05 AnnaBoten \_o< quack!
19:05 wahanui !bang
19:19 tcohen !bang
19:19 AnnaBoten \_x< tcohen: 1 (820.68 seconds)
19:20 AnnaBoten \_o< quack!
19:20 wahanui *click*
19:21 tcohen !bang
19:21 AnnaBoten \_x< tcohen: 2 (82.16 seconds)
19:28 AnnaBoten \_o< quack!
19:28 wahanui oops, slipped over
19:31 oleonard !bang
19:31 AnnaBoten \_x< oleonard: 1 (161.12 seconds)
19:31 AnnaBoten [('tcohen', 2), ('oleonard', 1)]
19:31 AnnaBoten Best time: tcohen with 82.16 seconds
19:39 AnnaBoten \_o< quack!
19:39 wahanui oops, slipped over
19:40 hayley !bang
19:40 AnnaBoten \_x< hayley: 1 (23.54 seconds)
19:45 AnnaBoten \_o< quack!
19:45 wahanui oops, slipped over
19:45 oleonard !bang
19:45 AnnaBoten \_x< oleonard: 1 (14.07 seconds)
19:53 AnnaBoten \_o< quack!
19:53 wahanui *click*
19:59 hayley ~bang
19:59 hayley !bang
19:59 AnnaBoten hayley, you missed the duck!
19:59 hayley !bang
19:59 AnnaBoten \_x< hayley: 2 (319.05 seconds)
19:59 AnnaBoten [('hayley', 2), ('oleonard', 1)]
19:59 AnnaBoten Best time: oleonard with 14.07 seconds
20:06 AnnaBoten \_o< quack!
20:07 wahanui !bang
20:17 hayley !bang
20:17 AnnaBoten \_x< hayley: 1 (628.98 seconds)
20:18 AnnaBoten \_o< quack!
20:18 wahanui !bang
20:19 hayley !bang
20:19 AnnaBoten \_x< hayley: 2 (41.68 seconds)
20:19 hayley !stop
20:19 AnnaBoten [('hayley', 2)]
20:19 AnnaBoten Best time: hayley with 41.68 seconds
20:19 AnnaBoten Longest time: hayley with 628.98 seconds (this is your new longest time in this channel! Your previous longest time was 388.08)
20:19 AnnaBoten Nothing to stop: there's no hunt right now.
21:19 Miguel install ssl in koha but show me the apache no koha page, please some guide
21:21 Guest14440 install ssl in koha but show me the apache no koha page, please some guide
22:10 bag !bang
22:10 AnnaBoten There is no hunt right now! You can start a hunt with the 'start' command
22:11 hayley !start
22:11 AnnaBoten The hunt starts now!
22:11 hayley there ya go bag
22:11 bag !bang
22:11 AnnaBoten There was no duck! bag: -1
22:11 bag hehe
22:12 AnnaBoten \_o< quack!
22:12 wahanui oops, slipped over
22:12 hayley !bang
22:12 AnnaBoten \_x< hayley: 1 (14.95 seconds)
22:14 hayley marc 245?
22:14 hayley marc245?
22:14 hayley rmaints?
22:14 wahanui hmmm... rmaints is talljoy, lucas, hayley
22:14 hayley yay
22:15 cait @marc 245
22:15 huginn cait: The title and statement of responsibility area of the bibliographic description of a work. [a,b,c,f,g,h,k,n,p,s,6,8]
22:15 cait :)
22:16 hayley thanks cait!
22:17 rangi karma
22:17 hayley @karma
22:17 huginn hayley: Highest karma: "Joubu" (782), "cait" (772), and "oleonard" (489). Lowest karma: "-" (-61), "failed" (-43), and "ie" (-38). You (hayley) are ranked 107 out of 996.
22:17 rangi wahanui: karma for hayley
22:17 wahanui hayley has karma of 5
22:17 aleisha wahanui: karma for rangi
22:17 wahanui rangi has neutral karma
22:17 rangi wahanui: marc245
22:17 wahanui rangi: sorry...
22:17 rangi wahanui: marc 245
22:17 wahanui rangi: huh?
22:17 hayley rangi++
22:17 rangi !marc
22:17 AnnaBoten Error: "marc" is not a valid command.
22:17 aleisha wahanui: karma for rangi
22:17 wahanui rangi has neutral karma
22:18 hayley it's a silly friday in the koha nz team today cait
22:18 cait hm?
22:18 cait @eightball will it snow tomorrow?
22:18 huginn cait: The answer is a resounding no.
22:19 cait @excuse
22:19 huginn cait: I'll give you the answer just as soon as RDA is ready
22:19 wahanui i already had it that way, huginn.
22:19 rangi excuse?
22:19 wahanui rangi: techtonic stress
22:19 cait excuse?
22:19 wahanui cait: Sysadmin accidentally destroyed pager with a large hammer.
22:19 AnnaBoten \_o< quack!
22:19 wahanui oops, slipped over
22:19 hayley !bang
22:19 AnnaBoten \_x< hayley: 2 (5.75 seconds)
22:22 cait excuse?
22:22 wahanui cait: Internet exceeded Luser level, please wait until a luser logs off before attempting to log back on.
22:23 cait I wanted sun spots...
22:25 aleisha excuse?
22:25 wahanui aleisha: The rolling stones concert down the road caused a brown out
22:28 AnnaBoten \_o< quack!
22:28 wahanui oops, slipped over
22:28 hayley !bang
22:28 AnnaBoten \_x< hayley: 3 (23.64 seconds)
22:28 AnnaBoten \o/ hayley: 3 ducks out of 3: perfect!!! +5 \o/
22:28 AnnaBoten Best time: hayley with 5.75 seconds
22:28 hayley >:D
22:28 hayley !stop
22:28 AnnaBoten Not a single duck was shot during this hunt!
22:28 AnnaBoten Nothing to stop: there's no hunt right now.