Time Nick Message
06:24 ashimema Mornin' #koha
06:24 ashimema Thanks cait
06:25 * ashimema would like to encourage a more formal status change process on each point release..
06:38 reiveune hello
07:04 alex_a Bonjour
07:08 fridolin yolo
07:11 liliputech_asu morning
07:39 nlegrand bonjour #koha
08:51 huginn News from kohagit: Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=19fbc1cfa295edc0ff7e8801dd8a7026f2d75638>
09:01 koha-jenkins Project Koha_Master_D10 build #28: STILL FAILING in 7 min 34 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/28/
09:26 koha-jenkins Project Koha_Master_D9 build #918: STILL UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D9/918/
09:36 koha-jenkins Project Koha_Master_D8 build #458: STILL UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D8/458/
09:42 koha-jenkins Project Koha_Master_U18 build #397: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/397/
10:00 koha-jenkins Project Koha_Master_D9 build #919: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D9/919/
10:19 kohaputti ashimema, any chance someone from PTFS could fix the sandboxes: http://staff-ff.sandboxes.ptfs-europe.co.uk/provision_log/test
10:19 kohaputti ashimema, or am I using it wrong?
10:20 ashimema I lose a day every time I dig into those.. I'm tempted to just take them offline at this point :(
10:20 ashimema probably your not using them wrong.. they just don't seem all that reliable at the moment
10:20 ashimema it's a mysql connection issue that randomly creeps in after they've been running a while
10:21 ashimema and a quick restart doesn't seem to resolve it
10:21 kohaputti ah, ok
10:22 ashimema I'll have a quick look
10:44 ashimema sorry.. I can't get it to work :(
10:44 ashimema I'll ask khall when he comes online
10:45 ashimema my docker foo just isn't good enough yet :(
11:30 oleonard Hi #koha
12:00 oleonard Joubu around?
12:14 Joubu oleonard: yep
12:16 oleonard Hi Joubu. I know you've worked on rebasing Bug 15522, and you must be frustrated with it being stuck
12:16 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, BLOCKED , New interface for revamped circulation rules
12:16 oleonard Do you know of any plan to get it moving forward?
12:17 oleonard I was about to post to the devel list calling for some cooperation on it because I don't think it's going to move otherwise
12:23 Joubu There is a remote branch, if someone wants to test it. I did not see it was BLOCKED, I am going to rebase the patches for bug 18936.
12:23 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 enhancement, P5 - low, ---, jonathan.druart, Patch doesn't apply , Convert issuingrules fields to circulation_rules
12:24 oleonard Joubu: Do you think it would be useful to call for a coordinated effort to test 18936?
12:24 Joubu always good to ask for help, yes :)
12:24 Joubu especially if we want it ready for 19.11
12:25 Joubu the whole stuff can be tested anyway, even if the remote branch is not up-to-date against the current master
12:44 Joubu ashimema, tcohen: would it be possible/make sense to have an order in the build process of jenkins? Like: run D10, if green run others, otherwise do not start other runs and save polar bears
12:49 huginn News from kohagit: Bug 13937: (RM follow-up) Set working directory for daemon mode. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=82abbb29f9b660533966b358554d854cc157f4b9>
12:53 * ashimema crossses everything in the hopes that patch makes Jenkins happy again
12:54 ashimema hmm,
12:54 ashimema well D10 isn't passing fully yet
12:54 koha-jenkins Project Koha_Master_D10 build #29: STILL FAILING in 4 min 49 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/29/
12:55 ashimema I actually like that we get the results for all builds each run myself... yes it's possibly a little wastefull but there are time when we seem to pass in older versions and not newer ones and so it's helpful to immediately know to check both when implimenting a fix.
12:56 ashimema D10 is certainly a work in progress..
12:56 ashimema i've not swung around to focus fully on it yet..
12:57 Joubu D9 then :)
12:58 ashimema if we have enough nodes present to run the three in parallel why wait?
12:59 Joubu avoid unecessary processing cycle?
12:59 ashimema mmm
13:01 ashimema so really, you're just talking about making our process a tiny bit greener
13:02 Joubu yes
13:02 ashimema I believe our nodes are sitting there waiting for work anyways.. I doubt in reality we'de really be saving much
13:02 ashimema perhaps I'm mistaken
13:03 ashimema unless of course we ran on just one node and threw away the others
13:03 Joubu CPU waiting and CPU at 100% has not the same impact :)
13:04 Joubu not super important, just asking
13:04 ashimema indeed
13:05 Joubu given that if D9 is failing 1+ test it will fail in >95% of the situation on the other branches
13:06 ashimema very true
13:06 ashimema well I'd be happy for us to take that approach
13:06 ashimema so long as they all get built eventually
13:10 Joubu ashimema: btw do you know why D10 is failing? Is it a packaging issue?
13:11 ashimema I believe so, yes
13:12 ashimema fridolin and tcohen were discussing it at hackfest.. i can't remember the result
13:24 huginn News from kohagit: Bug 23038: Remove unused stderr vars <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=77884d6c76319431ce98a7332be9b27b7387f94d>
13:24 huginn News from kohagit: Bug 23528: Show 'log in to add tags' link on all search result entries <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=04cd884d10a4b9b6a889c084d40b44742e3d7279>
13:24 huginn News from kohagit: Bug 23772: Revert to passing itemtype objects to the template <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da90b8736ee66bf2cde78cbf3ae52fa4cbd585f5>
13:24 huginn News from kohagit: Bug 17247: (follow-up) Terminology fix: Use Restricted instead of debarred <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8e6c9a87e9a5e6c7b67be0ea84f714eee8544af>
13:24 huginn News from kohagit: Bug 23129: Set holdingbranch to library that initiates transfer <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=40380339f9bdd0b2a056c820bc61a3cdc8545df3>
13:24 huginn News from kohagit: Bug 23129: Unit test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=61aa04e6cb04f1628dd549008de7924c39392527>
13:24 huginn News from kohagit: Bug 23038: Hide expected warnings from tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=04ec6627e2d40a9bb34f7b95e4a3276b04a5fee1>
13:24 huginn News from kohagit: Bug 17247: Check if patron is restricted in HoldItem and HoldTitle <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=95fd391ae710dd1f04405c534e6738feb846b0d8>
13:26 ashimema trivial qa for someone on bug 23551
13:26 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 major, P5 - low, ---, martin.renvoize, Signed Off , Problem with renewal period when using the renewal tab
13:28 koha-jenkins Project Koha_Master_U18 build #398: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U18/398/
13:28 ashimema lol
13:29 * ashimema sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/CFghueGdsulvpOyelJUcAnjb >
13:29 ashimema Koha code makes me smile somtimes
13:29 Joubu ashimema: I do not understand th patch
13:29 ashimema which patch?
13:29 Joubu dt_from_string( scalar $cgi->param('renewonholdduedate')) should return now() if the param is undef
13:30 ashimema 23551?
13:30 Joubu yes
13:31 * ashimema reminds himself
13:31 ashimema I basically cloned the code from somewhere else that does the exact same thing
13:31 ashimema I did investigate it
13:32 koha-jenkins Yippee, build fixed!
13:32 wahanui Congratulations!
13:32 koha-jenkins Project Koha_Master_D9 build #920: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D9/920/
13:34 koha-jenkins Project Koha_Master_D10 build #30: STILL FAILING in 6 min 11 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/30/
13:36 ashimema something to do with scalar perhaps?
13:36 ashimema in particular perl versions?
13:36 koha-jenkins Project Koha_Master_D8 build #459: STILL UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D8/459/
13:37 ashimema aha, that's it
13:37 ashimema not scalar at all
13:37 ashimema https://github.com/Koha-Community/Koha/blob/master/C4/Circulation.pm#L2876-L2882
13:37 ashimema we don't want to pass date_due unless it's be specified
13:38 ashimema passing 'now' is wrong
13:38 ashimema hense this patch passes undef instead of now to AddRenewal
13:38 ashimema that's the difference
13:38 ashimema Joubu^
13:38 Joubu ho right, it's the due_date we are passing
13:39 ashimema you 'could' move the 'RenewalPeriodBase' stuff into the controller script as an alternative.. but I think that's worse
13:39 ashimema lol
13:39 Joubu that's bad
13:39 ashimema brain fuzz.. of course.. now you say it that way it's even more obvious we don't want that to end up as 'now'
13:39 ashimema lol
13:40 ashimema indeed it is
13:42 ashimema D10 is `Error: Can't locate JSON/Validator/OpenAPI/Mojolicious.pm` btw.. so yeah, packaging
14:06 koha-jenkins Project Koha_Master_U18 build #399: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_U18/399/
14:15 koha-jenkins Project Koha_Master_D9 build #921: UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D9/921/
14:15 ashimema hmm.. transfers.. always fun
14:20 koha-jenkins Project Koha_Master_D8 build #460: STILL UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D8/460/
14:40 tcohen oleonard: did it work?
14:41 tcohen koha-testing-docker
14:41 wahanui koha-testing-docker is even more awesome...
14:41 oleonard I haven't tried it today. Working from my laptop instead.
14:41 oleonard Should I try it again?
14:42 corilynn Is it me, or is the download button on the SQL reports page an upload icon?
14:47 oleonard corilynn: It's not you
14:49 corilynn kewl
14:50 corilynn do you already know there's a bug open? if not I'll create one
14:50 oleonard I don't think there is corilynn
14:53 corilynn kewl
14:54 tcohen oleonard: it would be great if you could try
14:54 tcohen I'm leaving right now, but will take a look at your comments, or just send me a whatsapp message
14:58 corilynn Bug 23812 Submitted
14:58 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 enhancement, P5 - low, ---, koha-bugs, NEW , Download icon is an upload icon
15:33 ashimema anyone here got an opion on the failing test in 23129
15:33 ashimema * anyone here got an opion on the failing test in bug 23129
15:33 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 normal, P5 - low, ---, nick, Pushed to master , Items holdingbranch should be set to the originating library when generating a transfer
15:34 ashimema TL;DR When an item is marked as lost whilst in transfer what should it's holding branch be set to.. the 'from' branch of the transfer or the 'to' branch?
15:37 kidclamp I would think the 'from' branch - it never arrived at the new location so the last time we saw it was when transferred
15:38 ashimema I think I agree..
15:38 ashimema so it's the test that needs updating I think.. rather than the code.
15:42 ashimema ooh.. hang on
15:42 ashimema I asked that question wrong
15:42 ashimema right.. the test that fails actually isn't to do with lost.. it's checking the holdingbranch before it's lost
15:43 ashimema and tests for the exact oposite of what your bug changes..
15:47 ashimema I reckon the old test is just wrong.. I'll update it as an RM follow-up
15:51 huginn News from kohagit: Bug 23129: (RM follow-up) Fix failing test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=480434bbf4a32750c5e47a3600b6a386d9732296>
16:01 koha-jenkins Project Koha_Master_D10 build #31: STILL FAILING in 6 min 29 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/31/
16:27 koha-jenkins Project Koha_Master_D9 build #922: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D9/922/
16:35 koha-jenkins Project Koha_Master_D8 build #461: STILL UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/461/
16:42 koha-jenkins Yippee, build fixed!
16:42 wahanui Congratulations!
16:42 koha-jenkins Project Koha_Master_U18 build #400: FIXED in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/400/
16:58 koha-jenkins Project Koha_Master_D9 build #923: FAILURE in 33 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/923/
16:59 * ashimema is confused
16:59 koha-jenkins Project Koha_Master_D9 build #924: STILL FAILING in 29 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/924/
17:09 oleonard Welcome back to myself I guess
17:44 reiveune bye
17:59 oleonard Hi wizzyrea
18:00 wizzyrea hello!
18:00 wizzyrea how are you
18:00 oleonard scatterbrained
18:01 wizzyrea ooh, look oleonard, a squirrel!
18:01 wizzyrea teehee
18:02 * wizzyrea waits for him to return
18:02 oleonard I'm back. I never found the squirrel
18:02 wizzyrea there you are
18:02 wizzyrea hehehehehehehe
18:06 ashimema Squirrel... Where.. was it a red one or a black one... Or a pesky grey
18:06 oleonard Where I live there are only grey ones
18:07 oleonard But we have chipmunks, so that's some consolation
18:08 ashimema We have mostly Grey's, but there's a few black coming into the area.. be nice if we got some reds back
18:08 ashimema Chipmunks,. Cool
18:10 oleonard Growing up in Kansas I thought deer and chipmunks were very exotic because we didn't have them around
18:11 cait oleonard++ thx!
18:14 wizzyrea what where in kansas did you live where squirrels and deer were not around?
18:14 wizzyrea because... uh...
18:14 wizzyrea I grew up in kansas and deer and squirrels were always around?!
18:18 oleonard Squirrels yes, chipmunks no
18:18 wizzyrea deer tho?
18:18 oleonard And I dunno, I never saw deer growing up in Lawrence
18:19 wizzyrea last winter I saw deer nearly every day. Leaping gleefully in front of my car.
18:19 wizzyrea thaat was topeka tho
18:20 wizzyrea when I lived in lawrence, I had a neighbour who put up one of those light up xmas light deer that have little motors that make them look like they're nibbling grass
18:20 wizzyrea we had a whole herd in their yard one night, because the deer all saw this light up deer and I guess thought that deer jesus had found the best grass in the neighbourhood.
18:20 oleonard wow
18:21 wizzyrea that neighbourhood was kinda close to the edge of lawrence but not *that* close
18:22 wizzyrea it'd have been a lot closer to the edge when you were growing up tho, I reckon
18:22 wizzyrea probably it was brand new then.
18:22 wizzyrea houses built in the late 70's/80's
18:29 tcohen hi all
18:30 * cait waves
18:30 cait busy day it looks like, still reading bug mail :)
18:57 oleonard See y'all tomorrow
19:19 koha-jenkins Yippee, build fixed!
19:19 wahanui Congratulations!
19:19 koha-jenkins Project Koha_Master_D9 build #925: FIXED in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D9/925/
19:44 ashimema Woopie
19:44 cait cool :)
20:46 koha-jenkins Project Koha_Master_D8 build #462: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/462/
21:12 ashimema Grrr