IRC Logs

Time Nick Message
23:00 mtompset Well, it is a lot later now, so I doubt I'll get good response time: ashimema ashimema ashimema (like BeetleJuice)
22:38 mtompset well old-school package install.
22:38 * mtompset is trying old-school install of Koha on Debian Buster.
22:21 mtompset borrower stats shouldn't.
22:21 mtompset memberentrygen might have the same issue.
22:17 mtompset and borrower_stats.
22:17 mtompset for extended attributes.
22:16 mtompset Oh, and I just noticed that memberentrygen as the same lack of Koha.Preference.
22:13 mtompset hopefully I didn't make any typos, because I didn't test.. bad me. :)
22:13 lukeG1 i see, thanks so much!
22:12 mtompset confirm the pass.
22:12 mtompset interactively apply the rest of the patch.
22:12 mtompset confirm the fail.
22:12 mtompset You interactively apply the test part of the patch.
22:12 mtompset This is handy when you have things like a patch with tests that fail before patch and pass after patch too.
22:11 mtompset Then it only applies the second. :)
22:11 lukeG1 yup, OK!
22:11 mtompset You then comment out the first patch with a # on the front of the line.
22:11 lukeG1 testing soon
22:11 lukeG1 got it, thanks
22:11 mtompset i
22:11 mtompset git bz apply 23283
22:10 mtompset now you know there are two patches, so you don't say 'y'es, you say 'i'nteractive.
22:10 mtompset git checkout -b bug_23283_counter origin/18.11.x
22:10 mtompset so you are on a fresh branch, right?
22:10 mtompset Ah okay... let me walk you through that. It's easy.
21:59 lukeG1 but ive never had to apply one patch when there is a 2nd counter patch
21:58 lukeG1 yours looks better
21:58 lukeG1 mtompset, i will
21:55 mtompset So, did you sign it off, lukeG1? ;)
21:42 lukeG1 thanks mtompset
21:41 lukeG1 ah, i see
21:41 mtompset Don't apply both... just mine, or just yours.
21:40 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283 normal, P5 - low, ---, koha-bugs, Needs Signoff , cannot view/edit additional attributes in 18.11.x
21:40 mtompset feel free to sign off my patch on bug 23283. :)
21:40 mtompset I've pushed up the counter patch without obsoleting yours.
21:38 mtompset modify the template file.
21:37 mtompset lukeG1, 23283... wrong way to patch.
21:34 wizzyrea teehee
21:34 mtompset git checkout -b bug_18.11.x origin/18.11.x # grunt grunt grunt
21:34 mtompset I'm taking a look around...
21:34 mtompset wizzyrea, quite possibly.
21:33 wizzyrea *shrug* it happens
21:33 wizzyrea my feeling is it's a backport thing - it applied cleanly so YAY backport OOPS something else fundamentally changed >.< whoops.
21:32 lukeG1 yea, sorry i should have said. It is only in 18.11.x right now
21:32 mtompset wizzyrea, just rambling outloud... :)
21:32 wizzyrea the problem is only 18.11
21:32 wizzyrea mtompset, that might be a change in later versions?
21:31 mtompset but even better ($params) = @_; v1 = $params->{p1} // q{}; -- hashrefs be the best.
21:29 mtompset Then v3 //= q{}; or whatever.
21:29 mtompset less breakage.
21:29 mtompset (v1,v2,v3) = @_;
21:28 mtompset lukeG1, ... shift, shift, shift... yuck!
21:27 lukeG1 something about bz22910 breaks it
21:26 lukeG1 mtompset i thought so, but its not working in 18.11.07
21:25 mtompset lukeG1, Doesn't the template file use Koha.Preference() to get it?
21:15 lukeG1 if anyone could take a look at that patch, id be forever grateful
21:14 huginn` Bug 23283: normal, P5 - low, ---, koha-bugs, Needs Signoff , cannot view/edit additional attributes in 18.11.x
21:14 lukeG1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283
21:14 lukeG1 i seemed to have broken additional patron attributes in 18.11.x
18:20 koha-jenkins Project Koha_Master_D8 build #321: STILL UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/321/
18:11 koha-jenkins Project Koha_Master_U18 build #303: STILL UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_Master_U18/303/
18:08 koha-jenkins Project Koha_Master_D9 build #812: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/812/
17:36 huginn` News from kohagit: Bug 23280: Silence warning <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=481d34613183300bff31f7f6a66abe8aa893e07a>
17:36 huginn` News from kohagit: Bug 22709: (RM follow-up) Add rollback to plugin test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=803e209e37086029d553778561088b45c36cb4cf>
17:02 ashimema but that's next
17:02 ashimema no idea how
17:02 ashimema I've managed to get it to fail :)
17:02 ashimema woohoo
17:01 ashimema huh.. what
16:57 tcohen ashimema: did you turn the FAIL_RANDOMLY_PRANK flag locally?
16:48 mtompset I couldn't get this to work in a modal.
16:48 oleonard If that is your concern I would suggest either making it a modal window or simply not opening a new tab
16:46 mtompset otherwise, people will nest upon nest upon nest tabs/windows.
16:46 mtompset -- so that people will save, and then close it.
16:46 oleonard The template doesn't follow the structure of a staff client template... No header and footer includes, no breadcrumbs, etc.
16:46 mtompset It was meant to be functional.
16:45 mtompset You don't like the template file? It wasn't meant to be pretty.
16:45 mtompset give what a look, oleonard?
16:42 oleonard mtompset: In the meantime could you give the template a look? Or do you want it just to be a proof of concept?
16:41 oleonard Shoot I forgot to test that on a machine with a webcam
16:41 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 enhancement, P5 - low, ---, mtompset, Needs Signoff , Capture member photo via webcam
16:41 mtompset bug 6815
16:40 mtompset I think my windows box doesn't like me... tested well on my ubuntu laptop.
16:40 mtompset oleonard, did you try 6815 further?
16:40 mtompset Botsnake? *smirk*
16:40 * oleonard thinks wahanui is probably not seeking a botsnake...
16:39 oleonard Botsnake will not come if we wait for some other person, or if we wait for some other time. We are the ones we've been waiting for. We are the botsnack that we seek.
16:38 * mtompset laughs, "Wahanui doesn't like Barak Obama's quote."
16:38 wahanui mtompset: that doesn't look right
16:38 mtompset Change will not come if we wait for some other person, or if we wait for some other time. We are the ones we've been waiting for. We are the change that we seek.
16:38 mtompset Hmm... tries a political quote...
16:38 wahanui oleonard: huh?
16:38 oleonard wahanui: Don't ever change
16:37 ashimema hehe
16:36 oleonard mtompset: wahanui doesn't like it if you start a sentence with "Change"
16:35 mtompset Okay, that is weird.
16:35 wahanui mtompset: that doesn't look right
16:35 mtompset Change your name to Wahanui, and I broke it?
16:34 wahanui mtompset: that doesn't look right
16:34 mtompset Change your name to Jenkins, and it might? :)
16:34 ashimema why oh why can I not get these Jenkins failures to fail locally
16:34 mtompset ashimema, I think so.
16:34 ashimema nice
16:34 ashimema pass I'm afraid.. sounds like a nasty dependancy loop
16:33 mtompset mariadb
16:33 ashimema or is that `buster or bust` ;)
16:33 * mtompset notes that Debian buster defaults to 10.3 -- no more auto-increment problem. :)
16:33 mtompset buster, not bust. :)
16:32 mtompset But I suspect that is a tcohen problem. :)
16:32 mtompset mysql-server doesn't exist, default-mysql-server does.
16:32 mtompset Actually... any ideas on how to get Debian bust kohadebox to work? ;)
16:31 ashimema :P
16:31 mtompset ashimema++ # quick response time.
16:31 mtompset There was a smile at the end, it was a cry-wolf scenario. :)
16:31 mtompset Okay, it's true. :)
16:31 ashimema what's up mtompset ;)
16:31 ashimema hello
16:30 * mtompset goes, "AAAAAAAAAAAAAAAAAAAAAAAAAAAA!" just to test that claim. ;)
16:27 ashimema shout if I can be of any furher assistance
16:27 ashimema hugs
16:26 ashimema it relised on having a Koha::Item object..
16:26 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 major, P5 - low, ---, martin.renvoize, Pushed to master , Returning a lost item not marked as returned can generate additional overdue fines
16:26 ashimema you deffo need that applied before the current working of bug 22877 will work..
16:26 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, C4::Items - Remove GetItem
16:26 ashimema bug 21206 even
16:25 ashimema yeah.. but 21206
16:24 ashimema there was also a big bug (still trying to track it down) which moved a bunch of stuff to Koha::Item... feels like you're also missing that
16:23 ashimema that's the one that removes $return_date.. applied a few months before 22877 (may be unrelated)
16:22 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 normal, P5 - low, ---, tomascohen, RESOLVED FIXED, book drop / drop box mode incorrectly decrements accrued overdue fines
16:22 ashimema wizzyrea do you have bug 14591 applied?
16:21 wizzyrea just leave it for now
16:21 wizzyrea its ok don't worry about it I'll check master here in a little
16:20 ashimema hehe
16:19 * mtompset pulls out Tylenol, Advil, and Aspirin... "Which pain reliever would you prefer, ashimema?" :)
16:17 ashimema my brain hurts
16:17 ashimema hang on.. the dropbox stuff relies heabily on $return_date
16:17 ashimema it's the "|| $return_date )" I don't have
16:17 ashimema could still be a bug.. but maybe in an older version
16:16 wizzyrea well never mind then it's obviously something else :)
16:16 wizzyrea hm
16:14 ashimema I don't have a line like that in master
16:14 ashimema what koha version are you running?
16:14 ashimema now that's even more interesting..
16:14 wizzyrea that's where it dies, with that patch for 22877
16:12 wizzyrea if ( ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && !$item->itemlost ) || $return_date ) {
16:12 wizzyrea yeah it might be but it's this line
16:11 ashimema that line numbers is wierd
16:10 * ashimema has a couple of tests still to fix on master which is slowing him down today (as well as a daughter with chicken pocks at home)
16:10 ashimema fancy opening a new bug dependant on this one and I'll write a test given what you've just said, then get onto attempting to fix it.
16:09 ashimema cool, thanks wizzyrea..
16:08 mtompset Greetings, wizzyrea ashimema
16:08 wizzyrea but it does return it
16:08 wizzyrea i just did it on my docker
16:07 wizzyrea you will gget can't call method itemolost on unblessed reference
16:07 wizzyrea with that patch, when you return an item in book drop mode that is overdue
16:07 wizzyrea yep I got it
16:05 wizzyrea :/ yeah
16:03 ashimema such an undertested area in the first place
16:03 ashimema problem round that area was I had major issues replicating half the problems.. hence it's been a bit of a "Hey, I can write a test for that now" thing.. each time I can come up with a failing test I've usually managed to fix it
16:02 ashimema I really need a solid test case.. then I'm more than happy to dig back into it..
16:01 wizzyrea I think
16:01 wizzyrea it's a new issue but caused by that patch
16:01 wizzyrea oh i eman
16:00 wizzyrea same
16:00 ashimema or another one?
16:00 ashimema is this the same issue?
16:00 wizzyrea for whatever reason we don't have an item at that spot in dropbox mode
16:00 wizzyrea we get a Can't call method "itemlost" on unblessed reference at /usr/share/koha/lib/C4/Circulation.pm line 1916.
16:00 wizzyrea well I mean, I know it happens
15:59 ashimema when you can ;)
15:59 ashimema hehe
15:59 ashimema grr
15:59 wizzyrea an example that I have is that the item was overdue, but I haven't been able to replicate it properly yet
15:58 wizzyrea 22877 seems to break drop box mode for certain cases
15:58 ashimema ish
15:58 wizzyrea ashimema, about?
15:41 mtompset Greetings, #koha.
15:28 eythian hallo wizzyrea
15:28 wizzyrea hi eythian
15:28 * eythian presses 2
15:26 oleonard Hi eythian, click here to chat with live human persons
15:21 eythian I WAS TALKING TO YOU WAHANUI
15:20 eythian hi
15:10 wizzyrea :)
15:03 reiveune bye
14:57 oleonard ze
14:57 * oleonard is just making noice
14:53 oleonard wizzyrea: I don't mean it's not worth complaining about, I just mean it may not be getting back to me
14:52 wizzyrea so not sure exactly what's happening
14:52 wizzyrea dunno have had 2 people complaining about it this morning
13:55 oleonard I haven't seen that wizzyrea but it seems like the kind of thing people wouldn't complain about if it was both rare and worked the second time
13:48 wizzyrea my instinct is to say "yeah it's gonna happen sometimes just check it in again and it'll go right" because that will be nearly impossible to replicate
13:46 wizzyrea notably it's probably an item that was lost before an upgrade to let's say - 18.11.06?
13:46 wizzyrea have you all seen a problem recently where an item that had been lost gets checked in, gives an ISE, but then checking it in again it's fine?
13:23 cait have to run, bye all!
13:22 cait i will text the export next, htank you!
13:22 cait tcohen: looks like it worked perfectly )
13:20 cait ok what i did was just add it as an argument to the up - should this work too?
13:20 tcohen add export XSLT_REPO=/home/katrina/git/xslt_works
13:19 cait hm?
13:19 tcohen in your ~/.bashrc
13:18 cait i put the XSLT_REPO i made in my up statement
13:13 cait where woudl i set the env then? i need to make up a new one?
13:12 cait and nope, it's not packaging cost or invoice adjustments... i will figure it out tomorrow
13:12 cait tcohen: i did, but i am still missing money
13:12 cait I want to copy and change this part here? http://paste.koha-community.org/1156
13:12 tcohen for such report you need to take taxes into account I guess
13:11 tcohen sort of
13:11 tcohen hi cait
13:11 cait tcohen: still around?
12:52 cait *sighs*
12:52 cait trying to make a report that matches the amount shown on the start page... failing
12:52 cait acq--
12:45 corilynn (i recently had a huge pile of bugs because I didn't account for a space in a keyname in AWS)
12:45 ashimema know.. even
12:45 ashimema ta.. that's usful to konow
12:44 corilynn is there a bugzilla for this interface?
12:44 corilynn worked without a space in the "creator" field
12:42 ashimema that is so odd
12:41 corilynn trying with no space in the "creator" field
12:40 corilynn on that same box, is "cori1" and has the same issue :(
12:40 koha-jenkins Project Koha_Master_D8 build #320: STILL UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/320/
12:38 koha-jenkins Project Koha_Master_U18 build #302: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U18/302/
12:37 ashimema feel free to steal that one
12:37 corilynn weird
12:36 ashimema all works as expected for me
12:36 ashimema martin1
12:35 ashimema http://sandboxes.ptfs-europe.co.uk/
12:34 corilynn did you click on the staff button?
12:34 ashimema no sign of any errors
12:34 corilynn which sandbox?
12:34 corilynn huh
12:34 ashimema just worked perfectly for me
12:34 ashimema hmm
12:33 ashimema wierd
12:32 ashimema mine is taking a few minutes to provision.. but the logs are looking promising
12:32 corilynn in provision_log: fatal: [localhost]: UNREACHABLE!
12:32 ashimema okies
12:32 corilynn no, i'm specifically testing that the bug doesn't exist in the "before"
12:31 ashimema adding any particular bug corilynn?
12:31 * ashimema runs up an instance to test
12:30 corilynn ashimema, it says "service unavailable" after it's built
12:28 wahanui somebody said the issue was too... thi swould have been better as several bugs
12:28 ashimema whats the issue?
12:28 ashimema cait managed to fine this morning
12:28 koha-jenkins Project Koha_Master_D9 build #811: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/811/
12:28 corilynn I've tried http://sb1.sandboxes.bywatersolutions.com/ and http://sandboxes.ptfs-europe.co.uk/ and got the same issues
12:27 corilynn is something wrong with making new sandboxes again?
11:57 huginn` News from kohagit: Bug 23230: (RM follow-up) Add rollback to plugin test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=22c99262ec5512cf7d2658e6f98f8bf64df57d12>
11:35 oleonard Hi #koha
11:23 koha-jenkins Project Koha_Master_D9 build #810: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_Master_D9/810/
11:22 tcohen winter holidays for Manuel
11:21 tcohen i'll be around a little more, and then after lunch
11:16 cait will you be around a little later? just finishing up this support ticket before i can try
11:15 cait next time we see each other you can convert me to koha-testing-docker
11:14 cait so i'd make my own branch... or how best to maintain?
11:14 tcohen well, I'd use koha-testing-docker and have a special alias for it
11:14 cait hm ok
11:14 tcohen that's what I would do
11:14 cait with xslt it's a constant save and try
11:14 tcohen yeah, hack Vagrantfile
11:14 tcohen oh
11:14 cait yeah but working on files?
11:14 tcohen vagrant reload?
11:14 cait and my new directory didn't show up
11:14 cait i tried that yesterday
11:13 cait but it seems to only sync on starting the box
11:13 tcohen is rsynced into /vagrant
11:13 tcohen anything you put on the kohadevbox clone
11:13 cait but i don't want to edit them from command line...
11:13 cait i'd be happy if i just had the files
11:13 tcohen copy your xslts clone there
11:13 cait i don't need git on both sides
11:13 tcohen hm, no, that wont' work
11:12 tcohen would be to symlink in the kohadevbox clone
11:12 tcohen the easiest way
11:12 cait hm and then provision?
11:12 tcohen but with your own variable/mount point
11:12 tcohen cait: duplicate the code for PLUGIN_REPO in Vagrantfile
11:01 cait and how to access that repo/sync the files between devbox and host
11:01 cait tcohen: i am trying to work out a workflow for working with a separate repository for our xslt files
11:00 cait hello :)
10:54 tcohen cait: what's up?
10:53 tcohen hola
08:59 ashimema okies
08:59 cait i wanted to pick his brain about my repository devbox thing
08:58 cait ashimema: more leaving it for later
08:54 ashimema morning #koha
08:53 ashimema bit early for tcohen
08:14 cait tcohen: ping?
08:03 cait hello #koha
06:37 reiveune hello
06:29 marcelr hi fridolin
06:29 fridolin hi
06:29 marcelr hi #koha