Time  Nick         Message
06:40 reiveune     hello
06:40 wahanui      salut, reiveune
06:40 fridolin     hi
07:01 alex_a       bonjour
08:01 cait         alex_a: if yo ucould still take a look at the sru bug that would be awesome
08:02 cait         alex_a: most of all make sure no regressions... so it might still go in
08:04 alex_a       cait, i planned that for thursday
08:04 cait         hm cutting it close, but I'll take it ;)
08:13 cait         alex_a++
08:28 ashimema     Sorry I didn't get further with that one alex_a , cait. .. it just ended up a tad too far outside my comfort zone in a few too many ways for me to feel confident continuing to work through it.. especially at this stage.  There's some fairly funky clever code in there which is further reaching than I thought it would be
08:28 ashimema     Good luck
09:55 Archie^      Hey everyone! i've translated a lot of opac and intra into Latvian language, where can i upload these files?
10:01 ashimema     https://translate.koha-community.org/
10:08 ashimema     Archie^: you'll need to request an account
10:22 vfernandes   talking about koha translate project, something is strange with 19.05 portuguese translation (https://translate.koha-community.org/pt/)
10:23 vfernandes   1 critical, 8 incomplete... but when you click on them it says "No results."
10:57 Archie^      hmm... is there a way to categorize books in what library "part" they are? As in "kids section" or "in reserves"
11:08 magnuse      Archie^: you can use either "location" (authorized value category LOC) or "collection" (authorized value category CCODE) for that, on the item level
11:44 huginn`      News from kohagit: Bug 22816: OPAC detail holdings table should now look a bit better <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=604c7b818b63b93c66bb751ceb9d99bc1c109be9>
11:44 huginn`      News from kohagit: Bug 22813: (follow-up) Add missing condition <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=45b1ff8dfa1054590544caff200b307144bd02cf>
11:44 huginn`      News from kohagit: Bug 22813: remove repetitive queries inside two nested loops in searchResults <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10efe4e3f239c47b847c53f06f82245e07d54759>
11:44 huginn`      News from kohagit: Bug 22808: Move Cache.t to db_dependent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6509d73d7925fe5d317d6f2baa1d1565d8d36220>
11:44 huginn`      News from kohagit: Bug 22787: Add mapping of letters "ů" and "Ů" to zebra definitions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d57239ca78e7719f4c04865e8c493919c6362c15>
11:44 huginn`      News from kohagit: Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9bff787ca863a45128cbd3a05a109e8f66d4fdf>
11:44 huginn`      News from kohagit: Bug 22791: Unify calculation between aqui-home and ordered.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=100b1e3eecb4de27f6a85095196019f6b36251c0>
11:44 huginn`      News from kohagit: Bug 22527: web installer links to outdated DB manual <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=abd4445cd2b86fe601de20b403bb621115b27c83>
11:44 huginn`      News from kohagit: Bug 22453: Make TestBuilder generates dates taking into account the timezone <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c1513a10c35f721e3c519d5ab3c38c7154b7fa1c>
11:44 huginn`      News from kohagit: Bug 22420: Remove wrong calculation on approved tags <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=28bcc5aa68733e41d50a6a801088b06857968f42>
11:44 huginn`      News from kohagit: Bug 21671: Prevent Modifications.t to fail randomly <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=914f23970de536df3972ebd75b280ee8eec98955>
11:44 huginn`      News from kohagit: Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88b37330abaee6372ec999c1a81fd216d66a1379>
11:44 huginn`      News from kohagit: Bug 21036: Fix warnings from C4/Biblio <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=295e9b1054386cf188c5fc1eb4fd590e5c451513>
11:44 huginn`      News from kohagit: Bug 21036: Fix uninitialized value within @itemnumber in string ne <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4560d9623663e9fd0b60f9a39ec53082cdd90f24>
11:46 cait         nicest noise ever
12:08 magnuse      bring the noise!
12:13 koha-jenkins Project Koha_Master_D9 build #722: UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/722/
12:23 koha-jenkins Project Koha_Master_U18 build #217: UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U18/217/
12:30 koha-jenkins Project Koha_Master_D8 build #231: UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/231/
13:01 fridolin     hi
13:06 magnuse      bonjour fridolin
13:45 wizzyrea     hi
13:46 calire       hi wizzyrea
13:50 ashimema     not so nice noise.. UNSTABLE ;)
14:24 wizzyrea     hm that
14:24 wizzyrea     is rather odd
14:24 wizzyrea     er
14:24 wizzyrea     maybe not
14:27 ashimema     Lol
14:28 wizzyrea     ok it seems that currently, the default checkout hold and return policy rules override the all-all rule?
14:28 wizzyrea     is that expected?
14:28 wizzyrea     so for example if you have total current checkouts allowed 1
14:28 wizzyrea     and an all all rule with 2
14:28 wizzyrea     which one should apply?
14:29 wizzyrea     all-all feels like a global default rule to me
14:29 wizzyrea     or library default
14:29 wizzyrea     maybe you shouldn't be able to set it to a value less than an existing all-all rule
14:30 wizzyrea     joubu, tcohen, kidclamp ^ thoughts?
14:31 kidclamp     the tables under the circ rules should override the general circ rules
14:31 ashimema     I'm inclined to agree with your logic there wizzyrea
14:32 kidclamp     all-all is poorly named - "All else" is more accurate - the rule of last resort - only use if you have nothing else
14:32 wizzyrea     then we have a lot of terminology problems in the rules
14:32 ashimema     No, sorry, kidclamp is right.. the all-all is the fallback rule isn't it.. so you should be able to override it in either direction I would have thought
14:33 kidclamp     you read that page from the bottom section to the top section, then the top section from the top to the bottom :-)
14:33 kidclamp     simple really
14:33 wizzyrea     you're funny ^.^
14:33 wizzyrea     so really
14:33 wizzyrea     that table should be above the main rules
14:33 wizzyrea     that default checkout hold and return policy table
14:34 wizzyrea     anyway, you don't consider it a bug that the rule can be set in a confusing way
14:35 wizzyrea     (I really just don't feel like it's clear which values are the be all end all buck stops here rule)
14:36 wizzyrea     also that 2nd table of defaults, it's not reflected in the instructions above
14:36 wizzyrea     maybe that's all that really needs to be done, is add that to the instructions at the top
14:36 wizzyrea     though I'm really wondering why we have those rules at all.
14:37 wizzyrea     for people who don't define an all-all?
14:40 wizzyrea     sorry this just feels to me like a "cut the end off the ham" problem (i.e. granddaughter always cuts the end off of the ham, wasting a lot of ham, because granny always did, asks granny why, granny says "to make it fit in the pan")
14:41 wizzyrea     granddaughter doesn't have the pan size constraint, so wasting the ham was dumb.
14:41 kidclamp     the second table does some diferent stuff
14:41 kidclamp     all-all saying 10 checkouts allowed means 10 for any patron/categroy not defined
14:42 kidclamp     the second table says 10 total - so you can reach the limit of any category, but 10 overall
14:42 kidclamp     sort of a n overarching implementation of 21946
14:42 * kidclamp   runs off
14:42 wizzyrea     bye
14:43 wizzyrea     alright I will accept that answer :)
14:43 wizzyrea     I like to avoid/eliminate granny ham problems
14:43 wizzyrea     but this doesn't seem like it is one.
14:50 wizzyrea     ashimema, about?
14:50 wizzyrea     unrelated to all of that biz
14:51 wizzyrea     checking out an item with a rental fee seems to cause Can't call method "lengthunit" on an undefined value at /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101
14:51 tcohen       rules apply from more specific to global
14:51 tcohen       so all-all is the fallback
14:52 wizzyrea     yeah I think I've got it now - it still seems weird that you can set a global rule that's less than all all
14:52 wizzyrea     but the use case dictates that no one *should* ever do that
14:53 * ashimema   was on school run
14:53 ashimema     reads back
14:55 wizzyrea     it manages to add both the fee and the issue
14:55 wizzyrea     but it bombs in between
14:55 wizzyrea     maybe I don't have a syspref set?
14:56 ashimema     wierd
14:57 ashimema     let me remind myself what that code looks like ;()
14:57 wizzyrea     trying to think of what we've added lately that might cause that
14:57 wizzyrea     it happens in master
14:58 ashimema     wierd.. I wouldn't have thought it possible to fail to find an issuing rule
14:58 ashimema     perhaps I'm overlooking something in `get_effective_issuing_rule`
14:59 wizzyrea     there is something funny because
14:59 wizzyrea     i went and set a rule for that specific type
14:59 wizzyrea     and now it's fine
14:59 wizzyrea     so it's like it wasn't seeing all-all
14:59 Joubu        wizzyrea: there is no check at all on the rules, you can insert whatever you want
15:00 wizzyrea     right ok
15:00 wizzyrea     oh actually
15:00 wizzyrea     I had no all-all rule only the default policies
15:00 wizzyrea     which don't have a unit
15:00 wizzyrea     no hourly loans on the default rules
15:01 wizzyrea     that
15:01 wizzyrea     is exactly it
15:01 wizzyrea     I had no all-all rule defined
15:01 wizzyrea     only the default rule
15:02 wizzyrea     theoretically that shouldn't happen to libraries
15:02 wizzyrea     sorry to be so chatty :/
15:02 wizzyrea     the onboarder makes sure that all new koha installs have an all-all rule it should be hard to get there
15:02 ashimema     no worries.. that's interesting to know
15:03 reiveune     byye
15:03 wizzyrea     to get it to die like that anyway
15:03 ashimema     I wonder if we aught to be validating the rules more strictly.. I clearly pressume `get_effective_issuing_rule` will always return me something meaningful
15:03 Joubu        there is a "no rule" warning displayed somewhere
15:03 ashimema     I think there are likely lots of other places that do the same
15:04 wizzyrea     this is what you get for asking me to test the rules i'm gonna try to break it :P
15:04 Joubu        NO_RULE_DEFINED - only for maxissueqty actually
15:04 ashimema     I vaguely remember digging into it once a while back.. I have this funny feeling that I raised it at the time that Circulation.pm has a funny hard coded 'do this if nothing else is defined' rule
15:04 wizzyrea     yeah there's a superfallback
15:04 ashimema     brb.. kids calling
15:04 wizzyrea     like, it's a skellie rule
15:05 wizzyrea     it allows issuing if there are no rules at all.
15:05 wizzyrea     i'm sure there are things to be fixed here but now isn't probably the time
15:06 Joubu        but it would be interesting to keep track of them :)
15:06 wizzyrea     i'm honestly not sure how best to express what needs fixing besides
15:06 wizzyrea     gol dern this is confusing
15:12 wizzyrea     what about, if we have an all-all rule for a library
15:13 wizzyrea     we put the maxissues value into the default checkout policy value
15:13 wizzyrea     if it's greater than what's there
15:13 wizzyrea     i feel like people would expect that the absolute maximum would be the same as all-all
15:14 wizzyrea     if you choose not to have an all-all
15:14 wizzyrea     or the value in your all-all is less than the default value, leave it alone
15:16 ashimema     it's in C4::Circulation::GetLoanLength I was thinking about btw
15:16 ashimema     that was yet another thing on my long todo list I never got to
15:17 ashimema     sure I recorded it in a bug somewhere
15:17 ashimema     https://github.com/Koha-Community/Koha/blob/master/C4/Circulation.pm#L1595-L1599
15:17 wizzyrea     oh the fallback's fallback/
15:18 wizzyrea     that's been around as long as I can remember, probably from version1
15:18 ashimema     it goes all the way through an interesting fallback, fallback, fallback loop
15:18 ashimema     and then finally gives up and sets a hard coded rules of '0' days, '0' renewals and 'lengthunit' of `days`
15:18 ashimema     mmm
15:19 wizzyrea     oh it's a bit weird then that it would have died with the lengthunit isn't it
15:19 ashimema     kinda scary hard codery.. but I could effectively do the exact same thing to squash the warning we get above
15:19 wizzyrea     without an all-all rule
15:19 ashimema     not sure it exactly makes sense to though
15:19 ashimema     get_effective doesn't do the same
15:20 ashimema     my comment way back was that perhaps it should
15:20 ashimema     but I don't think we reached a conclusion..
15:20 ashimema     sure I talked to tcohen and Joubu about it at the time
15:20 ashimema     probably near the end of the last cycle.. or perhaps the beggning of this one
15:30 Joubu        I guess we deal with it on bug 18936.
15:30 huginn`      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Convert issuingrules fields to circulation_rules
15:31 ashimema     oh.. interesting.
15:32 ashimema     Not sure that's one I've looked at yet
15:47 wizzyrea     testing those is actually quite challenging
15:47 wizzyrea     imo
15:48 Joubu        sure it is!
15:48 wizzyrea     i had to take a break and rest my brain!
15:50 ashimema     haha.. yup
15:50 ashimema     they certainly are challenging to test
15:59 huginn`      News from kohagit: Bug 22527: (RM follow-up) Add filter <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d38d78bcf4cc62d34aa953864cf6da87bef93c80>
16:07 ashimema     kidclamp++
16:25 koha-jenkins Yippee, build fixed!
16:25 wahanui      Congratulations!
16:25 koha-jenkins Project Koha_Master_D9 build #723: FIXED in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/723/
16:35 koha-jenkins Project Koha_Master_U18 build #218: STILL UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_Master_U18/218/
16:44 koha-jenkins Yippee, build fixed!
16:44 wahanui      Congratulations!
16:44 koha-jenkins Project Koha_Master_D8 build #232: FIXED in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D8/232/
16:55 koha-jenkins Project Koha_18.05_D8 build #273: UNSTABLE in 18 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/273/
17:05 koha-jenkins Project Koha_18.05_U18 build #262: UNSTABLE in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/262/
17:10 * cait       waves
17:10 wizzyrea     hi cait
17:10 cait         hello
17:28 koha-jenkins Project Koha_18.05_D9 build #265: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/265/
19:29 wizzyrea     @later tell rangi you should have a look at bug 19919 - how would Horowhenua feel if that functionality went away?
19:29 huginn`      wizzyrea: The operation succeeded.
19:48 rangi        updated the bug wizzyrea
19:48 wizzyrea     champion :D
21:34 cait         @seen lucasG
21:34 huginn`      cait: I have not seen lucasG.
21:34 cait         @seen lucasg
21:34 huginn`      cait: I have not seen lucasg.
21:50 MWR          Hey everyone, Marc import question here. I finially have imports working with items! Yay! But, now I have a new problem: Mulitiple copies of books. This is the current import I am using:
21:50 MWR          =952  $aNHS$bNHS$yBOOK$pT 80476$pT 22838$pT 23634
21:51 MWR          As you can see, I have 3 $p entries. (Yes, the spaces are part of the barcodes. ugh.) But when I import this, it comes in as one book/item. Any way to make sure it imports this as 3 different items?
21:51 cait         yes
21:51 cait         you need to make 3 =952
21:52 cait         each one represents one item
21:52 MWR          Ah... Ok. That makes sense... hrm.. is there a "for each" in MarcEditor? I'll have to research... Thanks!
21:53 cait         i tihnk there are some notes on the internet if you look for marcedit and Koha
21:53 cait         different people have written up stuff, but I personally have not much experience
21:54 MWR          Thanks again. I appreciate it.
21:57 cait         you are welcome
21:57 cait         where ar you from?
22:05 MWR          Washington State.
22:11 cait         MWR: South of Germany
22:12 MWR          Isn't it midnight where you are? You should go to bed. Sm:)e.