Time  Nick            Message
01:24 mtj             hey peeps, liz about?
01:25 mtj             i took another look at the plack timestamp patches, but bumped into the same problem as joubu
02:08 mtj             ..i updated the ticket
02:13 mtj             hmmm, i wonder if the 'plack-error.log' needs to be 'chown root:root' like the other 2 log files. i cant recall if i tried that.. :3
02:15 mtj             looks like i did
03:55 mtj             hmm, looks like bug 16357 doesnt work for me
03:55 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 normal, P3, ---, mtj, Failed QA , Plack error logs are not time stamped
07:35 marcelr         hi #koha
07:42 josef_moravec   hi marcelr
07:44 marcelr         hi josef_moravec
07:45 reiveune        hello
07:53 ashimema        morning
07:53 josef_moravec   hi reiveune
07:53 josef_moravec   hi ashimema
07:55 ashimema        seems we all missed a pretty scary edge case regarding cron scripts always defaulting to '0' for manager_id when we did bug 22008 josef_moravec
07:55 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 enhancement, P5 - low, 19.05, martin.renvoize, Pushed to Master , accountlines.manager_id is missing a foreign key constraint
07:55 ashimema        koha's database is 'weird'
07:56 josef_moravec   ashimema: yes, I see it now... but don't know hot to fix it
07:56 alex_a          bonjour
07:56 josef_moravec   to be honest, I do not like hardcoded "fake" (aka system) user...
07:56 marcelr         hi alex_a ashimema reiveune
07:57 ashimema        bug 22593 is the quivk fux
07:57 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 blocker, P5 - low, ---, martin.renvoize, Signed Off , Cronjobs/Scripts dealing with accountlines need updating for bug 22008
07:57 josef_moravec   ashimema: yes, I am looking at it now
07:57 reiveune        salut marcelr josef_moravec
07:58 ashimema        I think kidclamp has convinced himself it's OK to make that change (to null) as he believes we can get the data from branchcode + manager_id
07:58 ashimema        I still sorta prefer the other bug I did as a proof of concept to add system users in the negative borrowernumbers range
07:59 ashimema        but I think that's a scary change with possible far reaching effects..
08:00 ashimema        thanks
08:11 josef_moravec   ashimema: what about an 'interface' column in accountlines to distinguish between action by deleted patrons and cron/cli actions?
08:11 ashimema        haha
08:11 ashimema        I suggested just that in another bug recently
08:12 ashimema        I do like the idea
08:12 josef_moravec   ashimema: oh, I missed it probably, sorry!
08:12 ashimema        nah.. I have no idea what bug it was and can't find it now
08:12 ashimema        I just happened to be discussing it with nick yesterday too
08:12 ashimema        as a possible resolution
08:13 ashimema        if you like the idea I could happily add it in this bug
08:13 josef_moravec   i like that idea, it is semantically best I can think of...
08:13 ashimema        if we do. I think we should patch the db update from 22008 restrospectively to find '0' manager_id's and set the interface correctly
08:13 ashimema        else we'll have lost data during 22008 db update
08:14 ashimema        okies.. I'll add a followup with that.. fancy commenting on the bug?
08:15 josef_moravec   on which bug number we'll be continue on that? Bug 22593?
08:15 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 blocker, P5 - low, ---, martin.renvoize, Signed Off , Cronjobs/Scripts dealing with accountlines need updating for bug 22008
08:15 ashimema        I still think setting a userenv for scripts would be a good idea at some point.
08:15 ashimema        I reckon add 'interface' to accountlines could be it's own bug or part of 22593.. what do you think?
08:16 ashimema        if I split it off it probably needs to be another blocker as I'll take care of the restrospective fixing of updatedatebase.pl within it.
08:16 * ashimema      will quickly go create a bug for it.
08:17 josef_moravec   ashimema: generally, yes, we just need to find out, what concrete userenv propagate to cron, but yes, i like such an idea
08:18 ashimema        did you see my attempt in bug 22577
08:18 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 enhancement, P5 - low, ---, martin.renvoize, In Discussion , Cronjobs (and other scripts) should be attributed to a 'real' user
08:18 josef_moravec   Yes
08:19 josef_moravec   The idea is of Koha::Cron is nice, I just do not like creating some "system" user in patrons database...
08:19 ashimema        I'd really appreciate feedback and iterations on that.. I really like the introduction of a Koha::Cron base class, I'm not so sure about having to change the constraints in the borrowers table (dropping NOT NULL in both categorycode and branchcode) but I couldn't see a way around them
08:19 ashimema        coolios
08:58 fridolin        OMG bug 22601
08:58 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 normal, P5 - low, ---, oleonard, NEW , Table filters link cant be translated
08:58 fridolin        looks like a lot of strings cant be translated anymore
08:59 fridolin        cait:  could you have a look ? maybe i'm wrong
08:59 cait            18.11?
08:59 wahanui         18.11 is very new still
08:59 fridolin        cait: since 18.05
08:59 cait            i have an 18.11 installation i can check in quickly sec
09:00 fridolin        in /cgi-bin/koha/catalogue/detail.pl you see "activate filters"
09:00 cait            yep
09:00 cait            in english for me too
09:00 cait            i am not sure where the string shoudl be pulled from
09:00 cait            looks like the js only has a placeholder
09:01 cait            maybe a missing include?
09:01 cait            ah, yeah, what you said on bugzilla
09:03 josef_moravec   fridolin, cait: it is the same problem as bug 22490
09:03 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 major, P5 - low, ---, koha-bugs, NEW , Some strings in javascript files are untranslatable
09:03 josef_moravec   koha-tmpl/intranet-tmpl/prog/js/table_filters.js:        .html('<i class="fa fa-filter"></i> ' + _("Activate filters") )
09:03 fridolin        ah indeed, i set as duplicate
09:03 fridolin        i did not found it
09:04 fridolin        josef_moravec: how there is a coding guide line, super thanks
09:05 josef_moravec   fridolin: not at all, this is not hard to fix, by relatively a lot of work :(
09:06 fridolin        Each js file must have an include ? like : prog/js/catalog.js and prog/en/includes/catalog-strings.inc
09:06 josef_moravec   ashimema++ for filling bug 22600
09:06 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 blocker, P5 - low, ---, martin.renvoize, NEW , We should add an 'interface' field to accountlines
09:06 * ashimema      is just working on code for it now
09:07 cait            fridolin: yes, js files never translate, so we use includes or put the strings int he template where it's used
09:07 cait            i wonder who broke it and who passed qa *hides just in case*
09:07 * josef_moravec is looking forward to test it
09:08 fridolin        cait its from Bug 9573 for filters
09:08 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Ability to download items lost report
09:08 ashimema        opinion.. C4::Overdues->UpdateFine currently always adds it's debit with undef user_id.. makes sence.. do you think interface should be something hard coded here.. like 'internal process'
09:08 fridolin        #shitappens
09:09 ashimema        it could get called from scripts or returns via opac or staff but 'where' is sort of not important here
09:09 josef_moravec   cait: it is so easy to oversight it in js files during QA I think...
09:09 ashimema        hmm.. I'm overthinking.. I'll just stick to C4::Context->interface and let it deal with it.
09:10 * ashimema      has missed js translation fails before.. too easy to miss it
09:11 ashimema        perhaps we should try adding something to the qa script
09:11 ashimema        a warning for "There's a JS change here.. make sure it doesn't include strings"
09:13 fridolin        QAscript++
09:14 fridolin        grep the _()
09:14 cait            don't work
09:14 cait            because often they also forget the _(
09:14 ashimema        fancy adding that as an issue to the qa script repo.. then joubu or I will try to get o it?
09:15 * ashimema      doesn't mind the qa script throwing false issues if those issues are there to remind the qa team to look for something.. in this case that might be one of those
09:18 fridolin        oki warning is good
09:24 cait            hm maybe 2 checks
09:24 cait            a warning and a contains _( in js
09:24 fridolin        sounds good
09:26 fridolin        cait: how do we trigger this ? mail to Joubu ?
09:26 cait            i think an issue on gitlab woudl work
09:27 ashimema        https://gitlab.com/koha-community/qa-test-tools/issues
09:27 fridolin        oki
09:27 ashimema        add an issue there and Joubu or I will pick it up
09:28 ashimema        we currently pick them up then qa each others work there effectively
09:28 ashimema        though if you fancied having a punt yourself you're more than welcome to ;)
09:28 cait            ashimema++ Joubu++ :)
09:28 ashimema        oh, and Tomas.. he does it too sometimes
09:29 cait            i like bug 22600 appraoch
09:29 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 blocker, P5 - low, ---, martin.renvoize, NEW , We should add an 'interface' field to accountlines
09:29 cait            and a nice memorable bug number too - must bring luck
09:30 ashimema        lol
09:30 ashimema        on that bug.. do you think interface should allow null or be a not null
09:31 * ashimema      is debating it at the moment
09:31 cait            we can't set it retro...
09:31 cait            so i'd say allow null
09:31 ashimema        well.. we could 'ish'
09:32 ashimema        we can kinda derive fairly well from what other fields are populated and how
09:32 ashimema        for example if a credit if manager_id == borrowernumber then we know it happend via online payments via the opac
09:32 ashimema        I tihnk
09:33 ashimema        I like `not null` as it makes devs think going forward.. making sure we populate it when we add new features
09:33 ashimema        if I did do 'not null' what do you think it should contain for 'internal' calculations cait?
09:34 ashimema        don't worry.. I think I've resolved it in my head now
09:42 cait            i'd copy from what action_log does
09:42 cait            reusing the same if possible
09:43 ashimema        well.. it pretty much always falls back to `C4::Context->interface`
09:43 ashimema        you can pass $interface into the `actionlog()` call.. but it's only actually passed in within the tests.. never in real code
09:44 cait            ?
09:44 cait            i don#t think that's true
09:44 cait            tomas added it
09:44 ashimema        we are slowly getting to the point where we won't need actionlogs for accounts at all
09:44 cait            i see Null and opac in my test database
09:44 cait            i know, but it makes sense to reuse codewords i guess
09:45 ashimema        oh certainly
09:45 cait            action_logs has the interface column as well
09:45 ashimema        but those are currently coming solely from C4::Context->interface
09:45 ashimema        mmm
09:45 ashimema        it's a weird column there though.. it's a massive varchar for what it contains
09:48 cait            not sure why, i know it was tcohen tho :D
09:57 fridolin        https://gitlab.com/koha-community/qa-test-tools/issues/15 ashimema cait josef_moravec
09:58 ashimema        fridolin++
10:05 cait            fridolin++
10:21 ashimema        interesting.. interface defaults to 'opac' in C4::Context if it's not been set!
10:22 ashimema        cait.. would you want to differentiate between cron scripts and commandline scripts
10:22 josef_moravec   ashimema: ah, it explains some strange thing I've seen in action log recently!
10:22 ashimema        indeed.. I wasn't expecting at all
10:23 ashimema        also.. Context only allows for 'opac', 'intranet', 'sip' and 'commandline' as interface options currently (seems sane).. but prompted my question regarding 'cron'
10:24 ashimema        I also think adding 'api' to the mix would be helpful
10:25 ashimema        for the rest api's
10:34 josef_moravec   ashimema: I thought about "api" interface too
10:35 ashimema        I reckon 'api' and 'cron' are helpful additions.. it's nice to differentiate between cron runs and human intiated scripts in my opinion
10:36 * ashimema      is adding a followup
10:36 josef_moravec   the cron is type of commandline, but could be useful to have different interface for this
10:36 ashimema        some initial code is now submitted on 22600
10:36 ashimema        indeed
10:39 josef_moravec   ashimema: why did you made default interface "script"?
10:40 ashimema        I did?
10:40 josef_moravec   in db update, the default value
10:40 ashimema        likely wasn't deliberate
10:40 ashimema        ah yes
10:40 ashimema        I think the DB update needs work.. I wanted to make it NOT NULL as I like enforcing population going forward as much as possible
10:41 ashimema        but I haven't fully worked out how to populate going back or a suitable default.. I'm thinking set with Nullable, fill in the retrospective values somehow, then alter to 'not null' and no default.
10:41 ashimema        sound sane?
10:42 josef_moravec   ashimema: does make sense to me
10:43 ashimema        so yeah.. it's not ready for signoff.. but ready for a quick peak and feedback
10:43 josef_moravec   that's what I am trying ;)
10:43 ashimema        :)
10:43 ashimema        I also made a copy paste error in a SIP module.. setting it to 'opac'
10:43 josef_moravec   yes, i see it ;)
10:43 ashimema        just fixing that now by working my way backwards to where the modules are used.
11:03 ashimema        am I mis-remembering.. we prevent the same auth session from being used accross opac and staff interfaces don't we
11:03 ashimema        I thought we prevented that for a long time now.. but I can't find the code that does it.
11:04 josef_moravec   I don't think so
11:04 ashimema        we don't prevent it?
11:05 josef_moravec   I just logged in staff and was automatically logged in opac too
11:05 ashimema        hmm.. perhaps it's just that all my systems never re-use the base domain anymore
11:05 josef_moravec   ashimema: maybe
11:05 ashimema        back in the day when intranet was always on :8080 cookie sharing happened all the time;.
11:06 josef_moravec   yes, so now it is problem only on devbox ;)
11:06 ashimema        hehe
11:39 kidclamp        morning
11:39 ashimema        morning kidclamp
11:41 ashimema        so.. how confident are you about identifying cron runs from manager_id = null + branchcode = null ?
11:42 * ashimema      isn't entirely.. UpdateFine sets exactly that I believe and it can be called via opac, cron and intranet
11:42 ashimema        but.. I'm not sure it entirely matters retrospectively.
11:43 ashimema        and.. i think it was setting '0' before the manager_id change anyways
11:43 ashimema        so also wouldn't be identifiable before either
11:43 * ashimema      talks himself round again
12:26 kidclamp        can it ever be called via a user though? ah, agreeing with you, we couldn't tell before
12:27 kidclamp        I think we want to add info in the future, but don't knwo that we are losing info now, just making it slightly less obvious
12:42 * kidclamp      waves to marcelr
12:42 marcelr         kidclamp: hi
12:43 marcelr         kidclamp: discussion obsolete after so much time on 12159
12:43 kidclamp        that was my guess, but wanted confirmation that it can be pushed
12:43 marcelr         shouldnt be that hard to rebase the other one?
12:44 kidclamp        josef has a rebased branch
12:44 marcelr         i normally dont pass qa on patches that i would not recommend to push ;)
12:44 kidclamp        that's appreciated
12:45 marcelr         ashimema: is 22557 actually the same problem as your cronjob stuff ?
12:46 ashimema        er..
12:46 ashimema        it could be
12:47 marcelr         sounded similarly
12:47 ashimema        though it sort of depends whether one wants to attribute it to the cron user or attribute it the person who triggered it
12:47 ashimema        I'm not entirely sure
12:48 ashimema        my cron stuff in the end side steps it entirely now.. bug 22600 adds an interface field to the accountlines so we can stick to 'undef' for manager_id but retain the information that it's via a cron job.
12:48 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 blocker, P5 - low, ---, martin.renvoize, Needs Signoff , We should add an 'interface' field to accountlines
12:53 talljoy         i like that
12:53 talljoy         great idea.
12:55 kidclamp        gold star for ashimema
12:55 talljoy         yassss
13:11 josef_moravec   ashimema++ for filling bug 22603
13:11 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 enhancement, P5 - low, ---, koha-bugs, NEW , Move boilerplate into Koha::Cron class
13:11 josef_moravec   great idea
13:12 ashimema        my mission over the next year may be to get my git stats onto the side of 'more lines removed than added' :)
13:13 josef_moravec   ashimema: that is my mission on almost every project I am working on :D
13:13 ashimema        hehe
13:14 ashimema        I've got allot of catchin up to do in koha.. What code I have submitted has usually been adding feature.. which obviously adds lines
13:14 ashimema        doesn't help how much boilerplate we added with Koha::Objects.. I find myself doing loads of copy paste there
13:15 josef_moravec   Yes, I could imagine some code generator here :D I do not like copying code...
13:28 huginn`         News from kohagit: Revert "Bug 22399: Improve responsive behavior of the basic marc editor" <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a993bd3843fdfcf3a7f2df916299b32d4601b879>
13:28 huginn`         News from kohagit: Bug 10577: (QA follow-up) Remove tab chars <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=100e1e758c622234d1a176b1cdb45def8443833f>
13:28 huginn`         News from kohagit: Bug 22560: Forgotten password "token expired" page still shows boxes to reset password <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ac1457ffc27cf6ec5a3a7bab6abc8a010e02b6a>
13:28 huginn`         News from kohagit: Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=50be1c4006e0a1d7e3b537bd849bc77f7a6bb56f>
13:28 huginn`         News from kohagit: Bug 12159: (QA follow-up) Remove double use module <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3c69e084d7b1fd75dd04f5dc35fb99ceca9efb39>
13:28 huginn`         News from kohagit: Bug 12159: (QA follow-up) Rename relation in Patron::Attributes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e0b9d98827fa616f622e296254259ad475b742a2>
13:28 huginn`         News from kohagit: Bug 22550: OPAC suggestion form doesn't require mandatory fields <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=28e7f1d4e7a114b04d6940463f47351466a638dd>
13:28 huginn`         News from kohagit: Bug 22536: Display problem in Holds to Pull report <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9a321c128fed457bf6d11d2ce7ee7edf7dd28004>
13:28 huginn`         News from kohagit: Bug 10577: (QA follow-up) Remove bad call signature <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=92af7e53130304d27e5b0d9d531a89628c8ba1be>
13:28 huginn`         News from kohagit: Bug 22495: Restore Elasticsearch mapping for su-geo <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=53b059afbb5731373a92a3ebaaceea4e1d656363>
13:28 huginn`         News from kohagit: Bug 17746: (QA follow-up) Make set_password.pl generate a password if required <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3ef48c8708736e9d5b16e462e520302c007cb4c1>
13:28 huginn`         News from kohagit: Bug 17746: Make koha-reset-passwd user set_password.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0cd4ca289bd2e1bd11fdbd015225a909971ce213>
13:28 huginn`         News from kohagit: Bug 17746: Add misc/admin/set_password.pl script <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e2f6542e1ebbd15977b47c86d2a9ef55fa0c5e9b>
13:28 huginn`         News from kohagit: Bug 22076: Add missing whitespace on if statments <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0e5790947df32383864466724a3e4838ee659bd>
13:28 huginn`         News from kohagit: Bug 22076: Fix the same situation for lost items <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2153d851a094c6617551381899f8ec54d9e2fb0e>
13:28 huginn`         News from kohagit: Bug 22076: SIP checkin for withdrawn item returns ok in checkin response <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c7e48b0a1ad72b36445bc5d4202adb1b34bb8387>
13:28 huginn`         News from kohagit: Bug 21974: Make Elasticsearch connection settings configurable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=65f35447e93008810cec3eba63a286b9940d5824>
13:28 huginn`         News from kohagit: Bug 12159: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1218364dbea4d99b56b4abb0a4e77136a0c8d479>
13:28 huginn`         News from kohagit: Bug 12159: Fix getting extended patron attributes for circ-menu <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4fe300dec1937a7dc739573bc502fc566a55587d>
13:28 huginn`         News from kohagit: Bug 10577: Improve semantics of GetBudgetPeriod() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cc2a62bdee88908edb429155ae0d274ee9a6dfdb>
13:55 koha-jenkins    Project Koha_Master_D9 build #695: UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/695/
14:05 koha-jenkins    Project Koha_Master_D8 build #201: UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/201/
14:06 koha-jenkins    Project Koha_Master_U18 build #188: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_Master_U18/188/
14:34 wizzyrea        hallo
15:06 wizzyrea        it's oh so quiet
15:15 caroline1       hello everyone!
15:16 wizzyrea        hi caroline1
15:32 uno             hi
15:33 uno             they help me, when I edit record does not save it leaves me without data. Thank you
15:34 caroline1       uno, what version of koha do you use?
15:37 uno             18
15:37 uno             18.05.02.000
15:43 caroline1       anybody remember if there was a bug about this? I remember something about a character in 245$a that would erase everything
15:44 talljoy         that's right.
15:44 caroline1       but I can't remember if it was in 18,05 or 18,11
15:45 talljoy         quotes in the title
15:45 talljoy         18.05 iirc
15:47 caroline1       uno, are there quotes in your title?
15:47 kidclamp        bug 22395
15:47 wahanui         somebody said bug 22395 was the one
15:47 huginn`         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22395 critical, P5 - low, ---, koha-bugs, RESOLVED FIXED, Data in 245 field (subfield a or b) will be deleted if it has Quotation Marks
15:47 caroline1       thx kidclamp++
15:53 uno             field 952 subfield 8 with authorized values
15:53 uno             Caroline1
15:54 caroline1       uno what is your question?
15:59 uno             help me, when I edit record does not save it leaves me without data. Thank you
15:59 uno             field 952 subfield 8 with authorized values
16:00 caroline1       does your record have this character " in the title?
16:01 huginn`         News from kohagit: Bug 18235: (follow-up) fix tests and remove trailing space <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ffef0c0027f81e5420445c33b4f14dfebea9a5b5>
16:01 huginn`         News from kohagit: Bug 18213: DBRev 18.12.00.033 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=775029660cb6498e13b95434f213b3299804bc31>
16:01 huginn`         News from kohagit: Bug 18235: DBRev 18.12.00.032 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7cfeb543747cea87223cfaa7e380f48df754a017>
16:01 huginn`         News from kohagit: Bug 18235: (RM follow-up) fix mappings reset <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=450fbad7512b01da1ec4300b8443210281e6e3d3>
16:01 huginn`         News from kohagit: Bug 18235: (QA follow-up) Restore facet_order for su-geo field in mappings file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=915b4861fbd30b66898d834ac20e2ed55d011059>
16:01 huginn`         News from kohagit: Bug 21049: Set 007/00 when selecting material type (Rancor) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=856425db1e156ee4faf1aae70b0a78845711ba43>
16:01 huginn`         News from kohagit: Bug 18235: (QA follow-up) Series facet name after rebase <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eba63272995b7f71815cd6e0028a55a2a042bd6f>
16:01 huginn`         News from kohagit: Bug 18235: (QA follow-up) Make db update idempotent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b311938370568a7b43d31392e0f266f45a1fdc2a>
16:01 huginn`         News from kohagit: Bug 18235: Do not call get_facetable_fields excessively <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cbfeaca85998f77686a4c6860e21d1e7e02c9770>
16:01 huginn`         News from kohagit: Bug 18235: Update facet_order default value in atomic update <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5170880f7a1040240b15b0dd29fff6e6f7fff6b2>
16:01 huginn`         News from kohagit: Bug 18235: (QA follow-up) Add missing filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6ec68be83af08945d6b49c7335b7b19f807c645a>
16:01 huginn`         News from kohagit: Bug 18235: (QA follow-up) Fix POD <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bd2758c2141187289edf9047b9e5abe8d3c00b70>
16:01 huginn`         News from kohagit: Bug 18235: Add missing POD to get_facetable_fields <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bdb1652360530fb8dd66155fd8bcc2c2d3a6da72>
16:01 huginn`         News from kohagit: Bug 18235: Add unit tests for get_facetable_fields <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=854a7503764098ac348d637abeb1d13dd7ed02b1>
16:01 huginn`         News from kohagit: Bug 18213: (follow-up) Correctly sort facets <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=13ca80c20bb7461b1007bdbfddfde2ae3a5d2d1f>
16:01 huginn`         News from kohagit: Bug 18213: Add Template plugin and fix for C4/Languages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d1bd416341bca9824b08c2c2b24d5c32f8730dc3>
16:01 huginn`         News from kohagit: Bug 18213: DB Update (facet order) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e2394f62438dfdd6cabf128cb76d0a4847aba202>
16:01 huginn`         News from kohagit: Bug 18213: Add language facets to Elasticsearch <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=59918a3c2146a0e558125e246d0ac1b300189cf8>
16:01 huginn`         News from kohagit: Bug 18235: DB changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=565cf4ac4032c77a15d05709bda1043b1b3c5949>
16:01 huginn`         News from kohagit: Bug 18235: ES - Facets configurable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b47e01cdc2affce3f0272b0ffe3c4890b1281be0>
16:02 tcohen          woooooohooooo
16:02 talljoy         stuff and things
16:04 barton          git: |=======================>|  120 %
16:06 reiveune        bye
16:07 ashimema        dang, there goes my inbox zero!
16:20 wizzyrea        hah
16:32 koha-jenkins    Yippee, build fixed!
16:32 koha-jenkins    Project Koha_Master_D9 build #696: FIXED in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/696/
16:38 koha-jenkins    Project Koha_Master_U18 build #189: UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U18/189/
16:40 koha-jenkins    Project Koha_Master_D8 build #202: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/202/
18:19 huginn`         News from kohagit: Bug 19722: DBRev 18.12.00.035 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0b1809bb9386b839d8dceae84f751f7ff8c0ad01>
18:19 huginn`         News from kohagit: Bug 22516: DBRev 18.12.00.034 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cf85d02daeba82507c3cdf1570c33480763cc58a>
18:19 huginn`         News from kohagit: Bug 21772: (follow-up) Minor markup correction and reindentation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=29c1c8ff92509e08b86106abea11436261b432df>
18:19 huginn`         News from kohagit: Bug 21772: (QA follow-up) Fix setting variables to PROCESS in holds <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=281c89dd59105761c20700a9113ef9ebbc9117d0>
18:19 huginn`         News from kohagit: Bug 21772: (QA follow-up) Fix button class on Cancel hold button <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ab5160a52088c55f5c66da8d4741630be6839b36>
18:19 huginn`         News from kohagit: Bug 21772: (QA follow-up) Hide .tdlabel class in sco for consistancy with opac-user... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=60f817a5676d5a65db7e5e4cdd6a17b046def81d>
18:19 huginn`         News from kohagit: Bug 19722: Don't show items at job completion if over pref <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c18fd98bc7209bdc56b223469d3394b157548086>
18:19 huginn`         News from kohagit: Bug 22525: Navigation arrows on the bottom of Cataloging search pages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d2e562947e4d511df587cf92085de56c3346cdc2>
18:19 huginn`         News from kohagit: Bug 22516: Database update <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a52c3f5fa37fa9b66ad4e5b90e2ca4834efbb58e>
18:19 huginn`         News from kohagit: Bug 22516: Remove remaining calls to lastincrement <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f68fec12df1ad2f7a44b905dc24f0306604f521a>
18:19 huginn`         News from kohagit: Bug 22505: Add column configuration to patron list table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5d4f637a52bfb22dc5b031726c552e28b81e56f1>
18:19 huginn`         News from kohagit: Bug 21772: (follow-up) Included more information on tab label for SCO <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c421f0806568e46aadaf06ba799ba31b9bfa6f0c>
18:19 huginn`         News from kohagit: Bug 21772: (follow-up) Remove redundant variable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ce7096870ac1e6d2443b67d119e927574bd6ca30>
18:19 huginn`         News from kohagit: Bug 21772: Add holds and account information to SCO <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3ce8fa6f104edb49ff4f3e7e1d9bf7a2e210f1af>
18:19 huginn`         News from kohagit: Bug 21772: Move OPAC holds and account tables into .inc <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6a7d4b19c7fa224fc1a5abd596a81d3ca52f43f9>
18:19 huginn`         News from kohagit: Bug 19722: (follow-up) Adjust template parameters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0e6f7861a8b62b3c4cebff7376eba9e7828bdb7d>
18:19 huginn`         News from kohagit: Bug 19722: Add MaxItemsToDisplayForBatchMod systempreference <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=32cdfed1ecbe76bc435cc9a5f9db884a424e5669>
18:47 koha-jenkins    Project Koha_Master_D9 build #697: UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/697/
18:53 koha-jenkins    Yippee, build fixed!
18:53 koha-jenkins    Project Koha_Master_U18 build #190: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U18/190/
19:00 koha-jenkins    Yippee, build fixed!
19:00 koha-jenkins    Project Koha_Master_D8 build #203: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/203/
19:41 huginn`         News from kohagit: Bug 13895: (QA follow-up) Make the class plural <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eabcec1d6c172e0e590aa497eae0c264bcd2b5dc>
19:41 huginn`         News from kohagit: Bug 13895: Fix test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=583328e3f8c2e1827419185628069ad8c9979943>
19:41 huginn`         News from kohagit: Bug 13895: Adapt naming according to voted RFC <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a142369b309068ed2ba5d34f033f4e047483401d>
19:41 huginn`         News from kohagit: Bug 13895: (follow-up) Fix POST response <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=47ad7afccaf1ca0ae7b8dbfad9998aaac6d9a938>
19:41 huginn`         News from kohagit: Bug 13895: Change renewal endpoint <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=95d23bc3c38f3cd6a4e6be3aac451c3899cccc83>
19:41 huginn`         News from kohagit: Bug 13895: Refactor test using REST Basic auth <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a0148b440a4f05c6a6d216c85b03ea502b0da95b>
19:41 huginn`         News from kohagit: Bug 13895: Remove create_item and create_biblio subs from test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a7e704382fa97ba08c8d2d57f6a818e76e858770>
19:41 huginn`         News from kohagit: Bug 13895: Remove the opac checks in privileged endpoint <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4672e6e6c40cf595da7e836525e5b6e486f78efe>
19:41 huginn`         News from kohagit: Bug 13895: (follow-up) Adapt checkout endpoint to openapi, update terminology <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1dfb57164fd6d986b110caa695a3baf9800ff93a>
19:41 huginn`         News from kohagit: Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b63fd774c181b96e514122c0d693f222b99b1cdd>
19:41 huginn`         News from kohagit: Bug 13895: Add API routes for checkouts retrieval and renewal <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e3f2e346f884e2ba6e4a8f43709955f776a259de>
19:53 alexbuckley     hi all
19:55 kidclamp        hi alexbuckley
19:56 alexbuckley     :)
20:12 koha-jenkins    Yippee, build fixed!
20:12 koha-jenkins    Project Koha_Master_D9 build #698: FIXED in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/698/
20:13 koha-jenkins    Project Koha_Master_U18 build #191: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U18/191/
20:21 koha-jenkins    Project Koha_Master_D8 build #204: UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/204/
21:35 corilynn        ugh, when your running a test that takes to hours and you get impatient in the last 15 minutes and do something to break the test so you have to start over
21:35 corilynn        *you're
21:36 corilynn        https://media1.tenor.com/images/ddaf53bd25105cf4d616aa89cae41d02/tenor.gif?itemid=6012433