Time  Nick             Message
07:48 magnuse          \o/
07:54 alex_a           bonjour
08:03 fridolin         hi
08:03 wahanui          bidet, fridolin
08:05 reiveune         hello
08:05 wahanui          hey, reiveune
08:09 magnuse          josef_moravec++ a thousand times over for looking after bug 8995
08:09 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 enhancement, P5 - low, ---, julian.maurice, Failed QA , Show OpenURL links in OPAC search results
08:09 josef_moravec    magnuse: what do you think we should done now with that, ta make it to Koha?
08:11 josef_moravec    Do you have some resolver to test with? I think i could write tests for GetOpenURLResolverURL and maybe for other changes if there is need/willl to have this feature in Koha.
08:17 magnuse          i certainly need and want it in Koha! :-)
08:18 josef_moravec    great, i will try to write some test, and you can than sign-off it again ;)
08:18 magnuse          i just to have a gitified install with the patch(es) from that bug...
08:18 magnuse          oh i will!
08:19 magnuse          it's one of those things where i can't really understand how academic libraries can use Koha without it
08:27 * cait           waves
08:27 cait             andreashm: your package arrived :D
08:27 magnuse          kia ora cait and andreashm
08:27 andreashm        cait: wonderful! =)
08:27 cait             thank you! andreashm++
08:27 andreashm        enjoy! haha
08:28 cait             the haha is not very reassuring :)
08:28 magnuse          surströmming?
08:28 andreashm        pictures later or it didn't happen!
08:28 andreashm        magnuse: almost
08:28 magnuse          please don't poison the qa manager
08:28 cait             magnuse: might be some evil plan to take over the job
08:28 andreashm        it's in the weird food category at least
08:28 andreashm        *evil laugh*
08:29 * magnuse        is now infinitely curious
08:29 josef_moravec    hi cait and andreashm
08:29 andreashm        hi josef_moravec
08:30 cait             hi josef_moravec!
08:30 andreashm        cait: don't forget to share with your co-workers! =)
08:30 cait             i'll make sure of it
08:30 andreashm        hehe
08:51 koha-jenkins     Project Koha_17.11_D8 build #152: SUCCESS in 28 min: https://jenkins.koha-community.org/job/Koha_17.11_D8/152/
08:53 magnuse          josef_moravec: any norwegian foods or sweets i can bribe you with to create the tests for 8995?
08:55 josef_moravec    magnuse: hard to say, i don't know any of norwagian  specific food... ;)
09:06 AndrewIsh        josef_moravec:  Did you happen to notice, while QA'ing Bug 18589 whether the tests in t/db_dependent/api/v1/illrequests.t were currently passing for you? They're all failing for me, so I'm suspecting freaky data or something rather than actual broken tests
09:06 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 enhancement, P5 - low, ---, andrew.isherwood, Failed QA , Show ILLs as part of patron profile
09:06 josef_moravec    AndrewIsh: it was passing for me yesterday
09:07 AndrewIsh        josef_moravec:  Excellent, thanks :)
09:07 josef_moravec    AndrewIsh: what is error you see?
09:08 magnuse          josef_moravec: we have nice milk chocolate with almonds, right cait?
09:09 josef_moravec    magnuse: ;)
09:10 AndrewIsh        josef_moravec:  https://gist.github.com/AndrewIsh/7767ab9a355a3bd4dc1dbd8cd687233c
09:10 AndrewIsh        josef_moravec:  Looks like it might be a weird authentication problem in the first instance
09:13 ashimema         pull master andrew
09:14 ashimema         your seeing bug 22483
09:14 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 major, P5 - low, 19.05, martin.renvoize, RESOLVED FIXED, haspermissions previously supported passing 'undef' for $flagsrequired
09:15 AndrewIsh        Oh poop, good spot ashimema, I'll do that, thanks
09:15 ashimema         no worries
09:15 ashimema         I broke it.. so it was easy to spot for me ;)
09:16 AndrewIsh        ashimema:  When was it merged? I'm sure I pulled yesterday
09:16 ashimema         the last followups were yesterday I think
09:16 AndrewIsh        Ah, OK
09:16 ashimema         hmm.. Sunday by the looks
09:17 ashimema         but the errors you're seeing are certainly the same symptom
09:17 ashimema         all api requests did it
09:18 AndrewIsh        Yep, pulled and all fine now, thanks
09:25 cait             magnuse: i love that choclate... with salt :)
09:26 cait             josef_moravec: don't let him bribe you witht he brown cheese
09:31 josef_moravec    cait: looks like you have an experience ;)
09:31 cait             i've known magnuse for some time now... :)
09:31 josef_moravec    ;)
09:33 cait             josef_moravec: ot sure when i will get to more complex patches, maybe someone else coudl take a look at the timestamp ILL patch?
09:49 josef_moravec    cait: that is ok, we'll try to find somebody else ;)
09:51 cait             thx!
10:05 koha-jenkins     Project Koha_18.11_D9 build #48: UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_18.11_D9/48/
10:12 koha-jenkins     Project Koha_18.11_U18 build #46: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_18.11_U18/46/
10:16 koha-jenkins     Project Koha_18.11_D8 build #48: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_18.11_D8/48/
10:17 ashimema         boo
10:27 koha-jenkins     Yippee, build fixed!
10:27 koha-jenkins     Project Koha_Master_D8 build #189: FIXED in 22 min: https://jenkins.koha-community.org/job/Koha_Master_D8/189/
10:28 cait             boo for success?
10:32 ashimema         yeay :)
10:32 ashimema         first one was a failure
11:05 koha-jenkins     Yippee, build fixed!
11:05 koha-jenkins     Project Koha_18.11_D9 build #49: FIXED in 46 min: https://jenkins.koha-community.org/job/Koha_18.11_D9/49/
11:35 magnuse          frank.hansen++ for so on bug 14957
11:35 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 enhancement, P5 - low, ---, eivin, Signed Off , Write protecting MARC fields based on source of import
11:47 andreashm        hurray for that one!
11:49 magnuse          indeed!
12:07 oleonard         HI all
12:32 * oleonard       eats all the chips since no one is around
12:34 andreashm        oleonard: the chips with licorice flavor?
12:34 oleonard         Oh no is that a thing? I was just thinking about how I like all kinds of chips and now I find out that there is a licorice flavor!
12:35 * oleonard       is not a fan of licorice unfortunately
12:42 andreashm        =)
12:43 andreashm        it is in Sweden at least.
12:43 andreashm        you can ask cait about how they taste. =)
13:04 calire           we just tried them
13:04 magnuse          ...and?
13:04 calire           mixed reactions xD
13:04 oleonard         What exactly are they?
13:05 calire           I am confused at how they are cirsps and yet they have not just liquorice flavour, but salty liquorice flavour
13:05 calire           and not salt from the crisps, but actually in the liquoriceness
13:05 calire           owen, crisps with liquorice flavour
13:06 calire           that's not how irc works... i meant oleonard
13:06 oleonard         Still, my brain sent me a notification
13:06 calire           oh, phew
13:07 oleonard         Does Japan know that the Swedes have escalated the crisp flavor war with licorice?
13:07 calire           wait, what did Japan do?
13:08 * magnuse        is reminded of the norwegian-canadian moose war
13:09 oleonard         calire: I'm pretty sure Japan is the king of all flavors
13:10 oleonard         For example: https://kotaku.com/the-delicious-world-of-japanese-doritos-1506401118
13:11 calire           I do like doritos
13:11 calire           that last one looks like beer and bar snack flavour
13:12 calire           oh, nope, anchovy and garlic, that could go wrong fast
13:12 calire           German potato flavour \o/
13:13 oleonard         Sweden seems to be doing pretty well: https://www.chipsandcrisps.com/estrella.html.
13:14 oleonard         But hey chipsandcrisps.com, where is your coverage of Larsson's?
13:18 oleonard         Hey I am still looking to get a working git pre-commit hook... Does anyone have a good example?
13:21 ashimema         https://pastebin.com/TzxmNFbC works for me
13:21 ashimema         oleonard: ^
13:22 oleonard         Cool ashimema, thanks!
13:43 wizzyrea         ji
13:43 wizzyrea         hi
13:46 wizzyrea         have you ever tried to install the sample patrons without the sample patron categories? Well, I am here to tell you that it doesn't work.
13:46 cait             yeah there are depenencies, have always been
13:46 cait             libraries is needed too
13:47 calire           hi wizzyrea
13:49 pastebot         "oleonard" at 127.0.0.1 pasted "Added to ashimema's pre-commit hook to check for compiled CSS files" (76 lines) at http://paste.koha-community.org/2597
13:51 josef_moravec    magnuse: I started working on tests for 8995, they could be made better, but it is something at least, so I attached it to bug report ;)
13:52 magnuse          awesome! i will test it tomorrow
13:53 wizzyrea         can someone explain what "evil modules" are
13:53 * tallestjoy     has thoughts
13:53 wizzyrea         heh
13:53 magnuse          C4? compared to the angelic Koha modules?
13:53 wizzyrea         I mean in the context of the QA test
13:53 tallestjoy       search.pm
13:54 oleonard         SoulShredder.pm
13:54 eventallermagnus lulz
13:54 tallestjoy       funny eventallermagnus
13:55 josef_moravec    eventallermagnus: I started to think also about how to not implement the open urll staff in in C4, would be nice to just call $biblio->open_url
13:55 ashimema         oleonard++ for enhanced git hooks
13:55 ashimema         fancy updating the one on the wiki per chance?
13:56 oleonard         ashimema: Yes, especially if you don't see anything dumb in my revision
13:58 ashimema         looks solid to me :)
13:58 ashimema         in fact.. I've just added it to my own
13:58 josef_moravec    khall++
13:58 ashimema         hang on.. maybe I got something wrong
13:58 ashimema         it just failed for me
13:59 ashimema         haha
13:59 ashimema         no.. I just missed a bit when adding it to my own
13:59 ashimema         as you were ;)
14:00 cait             andreashm++ thx!
14:02 eventallermagnus josef_moravec: sounds like a good idea :-)
14:04 wizzyrea         so nobody knows what "   FAIL	  critic
14:04 wizzyrea         # Modules::ProhibitEvilModules: Got 1 violation(s).  "
14:04 wizzyrea         means?
14:05 * wizzyrea       sighs and goes to dig out the qa tool code
14:05 eventallermagnus wizzyrea: https://metacpan.org/pod/Perl::Critic::Policy::Modules::ProhibitEvilModules ?
14:06 eventallermagnus "Use this policy if you wish to prohibit the use of specific modules. These may be modules that you feel are deprecated, buggy, unsupported, insecure, or just don't like."
14:07 wizzyrea         yeah but i don't see anything in the perlcriticrc to say which oens
14:07 wizzyrea         ones
14:09 ashimema         we'll have a list somewhere I would think
14:11 wizzyrea         yeah I don't see one :(
14:13 eythian          often perlcritic will give more info around the message
14:13 eythian          or tell you where it's coming from.
14:13 eythian          otherwise you'd never be able to fix anything
14:14 josef_moravec    bye #koha
14:15 ashimema         indeed.. I'm surprised critic didn't spit more out
14:15 ashimema         how are you running the QA script.. with -v 2 ?
14:18 wizzyrea         that's right
14:18 wizzyrea         with -v 2
14:41 * ashimema       hopes he didn't upset @caroline too much
14:46 cait             ashimema: what did you do?
14:48 ashimema         failed a bug
14:48 ashimema         for good reason.. but I still feel mean
14:49 ashimema         on the upside.. it's an easy fix for her
14:49 oleonard         It's tough love
14:49 ashimema         simple change of `WHERE acountype = PF` to `WHERE accounttype IN ( PF, L )`
14:50 ashimema         but I thought it better to get her to do it in this case so she see's and learns
14:50 ashimema         hehe
14:51 ashimema         bug 21953
14:51 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 minor, P5 - low, ---, caroline.cyr-la-rose, Failed QA , Term "Lost item" is untranslatable
14:52 ashimema         cait are you on the case with bug 22237
14:52 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 major, P5 - low, ---, oleonard, Signed Off , Subscriptions are not linked to Mana upon edit
15:24 wizzyrea         hi again
15:33 cait             ashimema: not right now
15:33 cait             i am deep into isbd punctuation specification...
15:33 cait             please take over if youc an
15:36 eythian          cait: I wouldn't stay there too long if I were you, it's not safe.
15:36 eythian          sorry, cait : I wouldn't stay there too long if I were you. : it's not safe¸ .
15:37 wizzyrea         *snort*
15:38 cait             hmpf
15:42 wizzyrea         eythian++ thank you for the perlcritic tip
15:42 eythian          hope it's useful
15:42 wizzyrea         totes
15:42 wizzyrea         installer/onboarding.pl: Found use of Switch. This module is deprecated by the Perl 5 Porters at line 35, column 1.  Find an alternative module.  (Severity: 5)
15:42 wizzyrea         this is much more useful than the qa tool message
15:42 wizzyrea         :)
15:42 eythian          heh
15:58 ashimema         agress it's bad to have use of Switch
15:58 ashimema         what tip was that?
15:58 wizzyrea         A+ for whoever did the permissions revamp
15:58 wizzyrea         that's nice
15:58 ashimema         and.. why do the qa tools not spit that message out.. grr
15:59 wizzyrea         that was the perlcritic bi
15:59 ashimema         your welcome ;)
15:59 wizzyrea         bit
15:59 wizzyrea         ashimema++
16:00 * ashimema       adds an issue to https://gitlab.com/koha-community/qa-test-tools/issues for the lack of perlcritic detail
16:00 wizzyrea         on bug 22489
16:00 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 blocker, P2, ---, hayleymapley, Failed QA , Onboarding tool fails due to inserting maxissueqty into IssuingRule
16:00 wizzyrea         well I think if it's going to complain about it ought to at least you know, tell you what's wrong
16:00 wizzyrea         i mean to find out you can just perlcritic <the file>
16:00 wizzyrea         at the default level
16:01 wizzyrea         but still it's less useful to have to take a 2nd step
16:01 wizzyrea         and remember another thing.
16:02 ashimema         I agree
16:02 ashimema         it's likely just an oversight
16:02 ashimema         I'll take a look when I get a moment
16:02 ashimema         ?
16:03 ashimema         indeed
16:03 wizzyrea         oh up2u really
16:03 wizzyrea         it's definitely not urgent ^.^
16:05 ashimema         it's always good to help the QA people ;)
16:05 ashimema         keeps them sweet
16:06 wizzyrea         teehee
16:06 wizzyrea         that's what the cookies are for
16:07 ashimema         cookies.. mmmmm, cookies
16:23 ashimema         lol
16:23 ashimema         we literally take out the useful data:https://gitlab.com/koha-community/qa-test-tools/blob/master/QohA/File/Perl.pm#L114
16:23 ashimema         oh well
16:31 wizzyrea         ha oh.
17:19 Guest3090        hi
17:20 coyas            hello
17:20 wahanui          hello, coyas
17:21 coyas            i need help to split koha's interface in opac.bn.cv e admin.bn.cv
17:22 coyas            what i need to do in virtualhosts file
17:39 coyas            hello?
17:46 ashimema         You'll need to adapt the two chair stanzas, probably adding an Alias
17:47 ashimema         You'll also need to update your DNS entries for bn.cv
17:47 ashimema         To point the two subdomains to the server
17:48 coyas            ok
17:48 coyas            it is done
17:48 coyas            tks u
17:50 ashimema         😄
17:51 wizzyrea         wtf I told that guy the exact same thing a week ago
17:51 ashimema         Lol
17:52 wizzyrea         *throws in towel*
17:52 wizzyrea         I am having a serious disagreement with the sip cli emulator.
18:02 * ashimema       has similar fun with that one often
18:13 * oleonard       seems to be both away and not away
18:19 ashimema         Oleonard is in a state of cat
18:19 wizzyrea         ok we've settled our differences
18:34 wizzyrea         oleonard, is there a reason why on the hold tab in the patron detail on the intranet, to delete a hold it's a drop down instead of a link to delete?
18:34 wizzyrea         i mean, a hmmm reason besides "that's just the way it was done yonks ago"
18:35 oleonard         No good one. I have an in-progress branch which tries to fix it, but I got stalled somewhere.
18:35 wizzyrea         right I figured it was something like that
18:35 oleonard         I think maybe I was waiting for a chance to ask about the correct way to use the API to delete a hold?
18:36 wizzyrea         seems legit
18:42 oleonard         cait what are asking about with Bug 22477?
18:42 huginn`          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 normal, P5 - low, ---, oleonard, Passed QA , Missing DataTables configuration when searching patrons for holds
18:57 cait             oleonard: the line you chagned made me think it was configurable - but it isn't
18:57 cait             it's ok if that's the case - it just confused me
18:58 oleonard         What I had to do was copy the configuration from the circulation page which uses the same include
18:58 cait             it's ok, it works
18:59 cait             got to leave - way too late alredy
18:59 cait             bye all
18:59 oleonard         Bye cait
18:59 * oleonard       leaves too
19:48 rangi            morning
20:04 kidclamp         morning rangi
20:04 * cait           waves
20:05 rangi            hi kidclamp and cait
21:45 cait             ashimema++ thx for all the qa work
23:12 cait             @later oleonard tell do you think it would be ok to close Bug 6615        - Add shelving location option to transfers page ?
23:12 huginn`          cait: I've exhausted my database of quotes