Time Nick Message
06:37 cait AndrewIsh: around already?
06:37 cait AndrewIsh_: maybe just you and your evil clone? :)
06:42 cait y
06:43 cait hi fridolin
06:43 josef_moravec morning cait ;)
06:43 cait morning josef_moravec :)
06:43 cait thx for posting the notice templates
06:43 cait really helpful
06:43 josef_moravec Ah, you have seen it ;)
06:43 cait sure have :)
06:44 cait bug 20581 - 22 patches... pqa.
06:44 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 enhancement, P5 - low, ---, andrew.isherwood, Passed QA , Allow manual selection of custom ILL request statuses
06:44 josef_moravec I like them, they look nice on our printers, we designed it with my collegue just few days ago ;)
06:44 fridolin hello
06:44 cait it shows some of the stuff you can do with TT
06:44 cait we still sorely lack documentation
06:45 cait like what are the loop variables and such
06:46 josef_moravec true, I found them in C4::Letters code, but that's not the way how it should be done ;)
06:47 josef_moravec cait: would you like to see it in manual, or in wiki?
06:50 cait hm, at the moment i am happy ot just have something, but ultimately it shoudl be i manual
06:50 cait sometimes for moving a bit faster starting in the wiki might be an option?
06:51 cait i had started a page after kohacon in portland
06:51 josef_moravec link?
06:51 wahanui link is, like, strange, add / at the end
06:51 cait https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
06:51 cait kyle gave us some help with syntax, but we didn't get much about hte variables
06:51 cait like their actual names :)
06:51 josef_moravec i could add them ;)
06:52 cait it would help a lot i tihnk
06:52 cait also to see if what i wrote made sense
06:52 cait i already spotted a typo at least
07:00 josef_moravec Am I only one who thinks there is missing something on https://perldoc.koha-community.org/
07:05 ashimema <_oftc_josef_ "Am I only one who thinks there i"> Erm.. any hints to what?
07:11 ashimema We could use a newer podrenderer.. the one we use doesn't appear to be maintained any longer by the looks
07:11 cait hm it seems to go up unti 18.11.02
07:11 josef_moravec ashimema: it should refer to POD of whole codebase, but there are many modules missing: Koha::Patrons, Koha::Libraries, ...
07:11 cait seems recent
07:12 cait maybe file a bug with infrastructure on bugzllla
07:12 josef_moravec I'll do
07:12 cait I think it might be gmcharlt for perldoc, butnot sure
07:16 magnuse \o/
07:18 magnuse cait++ for https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
07:25 magnuse josef_moravec for the same :-)
07:26 josef_moravec magnuse: still working on it ;)
07:34 cait josef_moravec: could you take a look at bug 19821 for qa maybe?
07:34 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 enhancement, P5 - low, ---, julian.maurice, Signed Off , Run tests on a separate database
07:34 cait it's one of the older ones
07:35 cait ashimema signed off and jajm wrote it - so 2 down :)
07:37 marcelr hi #koha
07:37 cait so many andrews
07:37 cait hi marcelr :)
07:37 cait gotta run off, bbiab
07:37 marcelr hi cait
07:38 josef_moravec cait: I'll look into it
07:41 reiveune hello
07:41 wahanui bonjour, reiveune
07:47 alex_a bonjour
07:53 magnuse cait++ a thousand times over for qa'ing ill-stuffs
08:04 ashimema Good luck on bug 19821, I remember it being one of the more challenging ones to wrap my head around.. it's kind enough ago that is SO'd it that I've entirely forgotten how it works
08:04 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 enhancement, P5 - low, ---, julian.maurice, Signed Off , Run tests on a separate database
08:07 ashimema Ah, cait is catching up fast on the way leaderboard
08:08 ashimema dashboard.koha-community.org
08:19 magnuse ashimema, AndrewIsh: To use the FreeForm backend on 18.11.x, should I use the master branch or the 18.05 branch?
08:26 AndrewIsh magnuse: master should do it :)
08:26 magnuse thanks!
08:36 ashimema master
08:37 magnuse master!
08:37 wahanui master is the WIP version. in November, whatever is in the master will become version 18.11 and we'll continue to work on it for the 19,05 version
08:41 ashimema wahanui forget master!
08:41 wahanui ashimema: I forgot master
08:42 magnuse master is Master of puppets, pulling your strings!
08:42 ashimema wahanui master is the WIP version. In May, whatever is in the master will become version 19.05 and we'll continue to work on it for the 19.11 version
08:42 wahanui ...but master is Master of puppets, pulling wahanui's strings!...
08:43 ashimema Lol
08:44 ashimema wahanui master is also the WIP version. In May, whatever is in the master will become version 19.05 and we'll continue to work on it for the 19.11 version
08:44 wahanui okay, ashimema.
08:44 ashimema master
08:44 magnuse master?
08:44 wahanui it has been said that master is Master of puppets, pulling my strings!
08:47 ashimema what is master?
08:47 wahanui i heard master was Master of puppets, pulling my strings!
08:47 ashimema is that really master?
08:47 ashimema hmm
08:47 ashimema odd
08:47 ashimema oh well
10:34 josef_moravec cait: I just went through code and tried to document variables in notices, this could definitely be improved, but it's at least something ;)
10:34 josef_moravec https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
10:37 cait you are awesome, thank you
10:38 cait this will be so helpful
10:38 cait josef_moravec++
10:39 paxed why is the wiki left-side bar all the way down in that article?
10:40 paxed mismatched tag?
10:42 cait missing category
10:42 cait but category has been deactivated
10:42 cait i think you can enter them using {{ somehow but my mediawiki fu is weak
10:42 cait i just know adding a category fixes display
10:43 paxed [[Category:foo]] is the mediawiki way
10:48 eythian hi
10:48 wahanui bidet, eythian
10:50 ashimema anyone fancy testing some presently untested code which should add a nice little enhancemt to the actionlogs details for member updates?
10:50 ashimema bug Koha/Patron.pm
10:50 ashimema bug 3820
10:50 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Members in Log Viewer Showing ?? in UPDATE
10:51 ashimema I threw the code together quick as a proof of concept
10:51 * ashimema will add tests and polish it up a bit, but it looking for early feedback at this point
10:54 paxed ashimema: are the fields always in the same order?
10:55 ashimema not yet.. nice suggestion.
10:55 ashimema that's easy enough to do
10:55 ashimema think it needs a few tweaks for setting/unsetting nul fields too
10:55 paxed (we've got similar change, but it just uses Data::Dumper)
10:56 ashimema feel free to throw it up as an alternative :)
10:56 ashimema this was to try and get a conversation going :)
10:57 paxed nah, i think json is better for this
10:57 cait would lovve to see this one fixed
10:57 cait better logs would have already helped me so muchtoday
10:57 cait ashimema++
10:58 ashimema patch inbound adding 'canonicalisation' to the to_json call :)
10:58 ashimema thanks for that hint :)
10:58 cait lunch time bbiab
11:00 ashimema lol
11:00 ashimema it's exposed to me that the shift to Koha::Patron means that when we do any form of modification for the first time since the change we actually also do a 'fixup' on null fields.. setting defaults
11:01 ashimema I changed just 'othername' as a test but the log showed me that it also updated 'lost' and 'gonenoaddress' from 'null' to '0';
11:01 ashimema fun aye
11:08 * ashimema fires up koha-testing-docker to see how many tests he broke with that
12:00 magnuse talking of logs, i just saw bug 20750
12:00 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 enhancement, P5 - low, ---, andrew.isherwood, Failed QA , Allow timestamped auditing of ILL request events
12:03 ashimema poor andrew
12:18 AndrewIsh magnuse: Working on it now! :-D
12:24 * kidclamp waves
12:51 oleonard Hi all
12:57 cait hi oleonard :)
12:58 cait AndrewIsh: it's ok if you solve more than one issue in a patch :)
12:59 cait added the numbers more for referene and discussion
13:01 Bora currently i have configure for self check in and out
13:01 Bora how can we set for check in and out withouhgt user login
13:02 Bora i mean we allow user to do self check in and out withough login
13:02 Bora ?
13:08 oleonard cait: https://zivotdesign.com/p/view.php?p=15501496577045
13:17 matts Hey #koha! Anyone knows why we used datatables.inc to translate DataTable messages and not directly the i18n plug-ins for datatable ?
13:17 matts Is there a good reason ?
13:19 oleonard matts: My guess is it was more consistent with the way we handle translations in general. We don't really have an established procedure for using JavaScript plugin translations
13:20 oleonard It's definitely something which is worth re-evaluating
13:20 matts Actually I'm implementing DataTables for Coral ERM and was considering both options.
13:21 matts Thank you for your feedback oleonard
13:22 oleonard matts: I'll be interested to hear what you decide to do with Coral and whether you think we should change the way we do it in Koha
13:23 matts oleonard, well, the first thing that with i18n plugins, the translations are provided by Datatable, you cannot change them if you wanted to.
13:24 * matts is gonna try both
13:25 * oleonard did not know the TranslateNotices preference existed
13:27 magnuse AndrewIsh++
13:28 magnuse oleonard: so many preferences! :-)
13:29 matts oleonard, also, for example, there's only "English", and not en_US and en_GB.
13:29 * matts thinks he'll go the koha way
13:29 oleonard matts: Don't want the English speakers fighting!
13:29 matts :)
13:39 AndrewIsh cait: Re: solving more than one issue in a patch. Feels wrong to me. A patch = a commit and modifying unrelated things in a single commit is something I always try and avoid. Sorry, it means there's lots of patches :-/
13:41 eythian AndrewIsh: it's a good approach as it makes a) analysing the commit that introduced a bug easier, and b) easier to revert without conflicts or impacting other parts of the application if needed.
13:42 oleonard Agreed (and do as I say not as I do!)
13:43 AndrewIsh eythian: Precisely, that's exactly why I do it. I've been caught out before when I've not done it and had huge pain tracking stuff down and reverting bits of it. Learnt the lesson the wrong way!
13:43 cait hehe
13:43 cait you 22 patches on the last bug is all I say :P
13:43 eythian yes, commit early, commit often
13:43 cait i had to count them 3 times to make sure i upload them all back up again
13:44 AndrewIsh cait: Yes, I'm not proud of the number of patches, but they are all nice discrete changes
13:45 oleonard Oh are we talking about multiple patches on a single bug? I change my vote :)
13:45 cait it's ok, not a serious complaint from my side
13:46 AndrewIsh oleonard: :-P
13:46 oleonard :D
13:47 cait is someone using runreport.pl?
13:47 cait i think the mail to the mailing list could be resolved putting that in cron
13:47 cait [Koha] How to receive reports to email
13:47 cait but we don't use it
13:48 oleonard But still.... Bug 3935
13:48 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 enhancement, P5 - low, ---, chris, NEW , Schedule tasks periodically
13:48 cait yeah, ut i think it's a workaorund
13:48 oleonard Sure
13:48 cait obviously a bit tedious, because you have to hardcode it all into the report
13:48 cait into the cronjob sorry
13:49 cait AndrewIsh: i seem to remember ptfs-e was using it?
13:50 * AndrewIsh stares blankly
13:50 cait sorry :)
13:50 AndrewIsh I dunno, ashimema might know
13:53 cait 2) I felt there shoudl be another way with using an existting function doing this date math
13:53 cait should say that on the bug i guess :)
13:53 ashimema confused
13:53 ashimema I think my irc is going wonky
13:53 cait bug 20750
13:53 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 enhancement, P5 - low, ---, andrew.isherwood, Failed QA , Allow timestamped auditing of ILL request events
13:54 cait there is a function get_epoch
13:54 cait in logger
13:55 cait I was wondering if there is not a standard function doing that already
13:55 cait so we could do without the method
14:00 ashimema tight
14:00 ashimema I've caught back up
14:00 ashimema really odd
14:00 ashimema so.. yes we do use the runreport.pl stuff from the cron for a number of customer
14:01 ashimema yes it's a workaround, but every time I've dug into the UI stuff for scheduled tasks I've been met with "but that's a security issue" type responses so I gave up..
14:01 ashimema I think lots of people have tried to fix that one.
14:04 AndrewIsh cait: I did look to see if there was a get_epoch type function already available, but came up blank, I'll have another look
14:06 AndrewIsh cait: I'm sure (though I've not checked) it can be done using using DateTIme, but it feels a bit heavy handed to be instantiating two datetime objects per row just to be able to compare them, particularly given how slow DateTime is
14:08 kidclamp we use runreport a lot
14:08 kidclamp also bug 16149 - eh? eh? interested?
14:08 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 enhancement, P5 - low, ---, nick, Needs Signoff , Generate and send custom notices based on report output
14:10 Archie^ hey josef_moravec you here?
14:11 oleonard Bug 22337 and Bug 20935 won't apply cleanly on each other but I can handle it...if anyone wants to check 'em out :)
14:11 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22337 enhancement, P5 - low, ---, oleonard, Needs Signoff , Make it clearer that language preferences can be re-ordered
14:11 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 enhancement, P5 - low, ---, oleonard, Needs Signoff , Redesign system preferences interface
14:15 * oleonard craving signoffs: https://gifimage.net/wp-content/uploads/2017/12/jonesing-gif-6.gif
14:16 ashimema allot of our syspref names are cryptic as heck
14:16 ashimema I'm not sure if you're new interface makes that even more obvious
14:17 ashimema I think as you've removed the ability to collapse sections too, then we need to float the left menu
14:18 ashimema example.. if the `Acquisitions` tab is selected you can quickly click to the `Printing` section.. but you can't quickly click back up.. that feels like a step backwards to me
14:18 ashimema oleonard: ^
14:19 ashimema I like the look of it but actually I feel it all reads a bit less clear to me I'm afraid :(
14:21 oleonard Thanks for looking at it ashimema, I appreciate the feedback
14:21 * ashimema is racking his brains for what might help him like it more
14:22 ashimema I really do like how it looks.. but I'm hung up on how much more scrolling I seem to have to do.. and although there's more space between things it actually feels harder to read..
14:22 ashimema really odd and counter intuitive gut feelings there
14:22 ashimema on the upside.. it all works so could easily be signed off
14:22 josef_moravec Hi Archie^, need something? ;)
14:22 cait while we are talking about things that would make my life easier... can we please implement loggin for circulation condition changes too?
14:22 ashimema as far as my quick testing goes so far at least
14:22 cait ok, we weren't actually talking about that, but we shoudl
14:23 Archie^ josef_moravec: yah so i had a question regarding the "lav" errors during mapping authorities to records
14:23 ashimema even the overriden prefs stuff get highlighted nicely.. which is something I thought would be easily overlooked
14:23 Archie^ josef_moravec: so this is the errors i'm having https://prnt.sc/ml2b1h
14:23 ashimema cait.. is there a bug for it?
14:24 Archie^ josef_moravec: BUT according to marc21 xml standrats everyting hsould be fine https://www.loc.gov/marc/languages/language_code.html <-- search for " lav " and you will see Latvian
14:24 Archie^ josef_moravec: so im wondering maybe i've missed some sort of setting enabled in koha?
14:25 josef_moravec Archie^: your "lav" is used as tag name, which is bad
14:26 cait ashimema: i know what you mean, i had a similar response
14:26 cait argh, scrolling broken = re new syspref intereface
14:26 ashimema also.. is there no way to collapse the html editor for such syspref blocks once it's been opened
14:27 josef_moravec Archie^: ah, that's different problem, but still not "lat" as latvian
14:27 cait bug 16544
14:27 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 enhancement, P5 - low, ---, koha-bugs, NEW , Changes to circ rules should be logged.
14:27 Archie^ josef_moravec: so i've searched thein records and this is what it looks like https://prnt.sc/ml2l6a
14:27 josef_moravec Archie^: it is that you have authority code "lav" in biblio record
14:28 josef_moravec Archie^: subfield $9
14:29 josef_moravec Archie^: $9 is default, but you may change it in biblio frameworks...
14:29 Archie^ josef_moravec: but this is in authority records, not sure what biblio records has to do with it ?
14:30 josef_moravec Archie^: it could be in authority OR biblio record, I can't know it, so mayby field 001 in authorities?
14:32 josef_moravec have to go, by all
14:51 ashimema oleonard: I've SO'd the other one now though..
14:51 ashimema so I'm not all mean :
14:52 oleonard ashimema: I do not consider it mean to disagree with me :)
14:52 oleonard ashimema++
14:52 oleonard The only person you can't disagree with is kidclamp because he will cut you
14:53 ashimema hehe.. I've dissagreed with him plenty ;)
14:53 ashimema we like a good debae
14:59 kidclamp I'm just a knife, knifin' around....cut cut cut cut cut cut cut
15:00 ashimema wow.. circ rules are actually directly hacked at in the pl script rather than going via any classes/modules! :(
15:00 * ashimema was wondering about adding logging
15:00 ashimema but wow.
15:01 oleonard ashimema: That's because no one can touch that page. Patches submitted for it are cursed to die
15:01 ashimema lol
15:01 * ashimema has never tried to date
15:02 * ashimema now thinks he wont
15:03 * ashimema quietly giggles at the conversation going on in WhatsApp
15:07 oleonard I could have sworn there was a failed patch for removing SQL from smart-rules.pl but now I can't find one.
15:08 ashimema lol
15:25 kidclamp oleonard: I blame you that this is stuck in my head https://www.youtube.com/watch?v=PUykn7v5UXE
15:31 * oleonard will take that heat
16:01 reiveune bye
16:11 oleonard Hi CrispyBran
16:14 Margaret happy valentines day koha
16:15 oleonard Hi Margaret
16:15 Margaret morning oleonard
16:20 eythian wahanui: saint valentine is the patron saint of bees, epilepsy, and the plague.
16:20 wahanui OK, eythian.
16:20 eythian (it's true, look it up.)
16:21 oleonard I think I will!
16:21 oleonard saint valentine?
16:21 wahanui i guess saint valentine is the patron saint of bees, epilepsy, and the plague.
16:21 oleonard Wow... verified!
16:21 eythian see
16:34 kidclamp ashimema++
16:34 kidclamp david_gustafson++
16:35 kidclamp I don't know his IRC name
16:35 ashimema :)
16:35 oleonard In that case they obviously don't really exist
16:58 oleonard Bug 22318 is ready for a look.
16:58 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Extend Koha news feature to include other content areas
17:14 tcohen hi
17:14 wahanui bidet, tcohen
17:16 oleonard Hi tcohen
17:16 tcohen hi oleonard
17:16 wahanui hi oleopard
18:20 cait Joubu?
18:20 wahanui Joubu is, like, kidding, right ;)
18:30 tcohen hola Joubu
18:30 ashimema Joubu we've missed you....
18:35 cait i still do... i thought i saw him on bugzilla
18:39 ashimema You did.. it surprised me too
20:16 * andreashm waves
20:17 alexbuckley hi all
20:17 andreashm hi alexbuckley
20:17 cait alexbuckley: wasn't it you having a patch for removing sql from issuingrules? :)
20:18 cait someone asked about it earlier, ashimema i think
20:18 alexbuckley yes that's right cait :)
20:19 cait can you remind me of the bug number?
20:25 alexbuckley sure
21:09 alexbuckley hi cait, I trawled through bugzilla but can't seem to find it. I remember I had an series of bug reports for removing the SQL from a number of places. I had to set the assignee back to 'Bug Lists' due to a lack of time recently. I wonder if it has been removed
21:10 cait h not deleted
21:11 cait maybe a status not included in your search?
21:11 cait using ALL in front of the search queries makes sure everything turns up
21:11 cait deleting bugs is realy hard, so we don't do that, aprat from spam sometimes
21:12 alexbuckley ah right yup
21:41 caroline1 ashimema around?
21:42 cait caroline1: late - almost 10pm in uk i think
21:43 caroline1 I know, but sometimes he's there anyway
21:43 caroline1 cait: maybe you know
21:43 caroline1 didn't he write a wiki page on the development process?
21:44 caroline1 like patch is submitted, then reviewed and signed off, then qa'd etc..
21:45 caroline1 I'm trying to find the page on the wiki, but I can only find the one where he explains the versionning
21:45 caroline1 https://wiki.koha-community.org/wiki/Koha_Versioning
21:46 cait there are some pages about that
21:47 andreashm cait's ppt about the qa process should be on the wiki! very easy to follow
21:47 cait https://wiki.koha-community.org/wiki/Development_workflow
21:47 cait oh thank you
21:47 cait i think this is still published via bywater
21:47 caroline1 oh cool! thanks!
21:48 caroline1 andreashm is this the ppt from last kohacon?
21:48 cait and here too: https://swop.bsz-bw.de/frontdoor/index/index/docId/1322
21:48 andreashm caroline1: that's the one
21:49 cait just remembered we put it in our repo too
21:49 caroline1 cool!
21:50 caroline1 Some random person is asking Pierre-Marc if his patch will be in the next version of Koha... I'm like "eehh... probably not"
21:50 caroline1 But she is new to Koha, so we wanted to give her more info on how it works
22:00 * andreashm looks at the most recent document at the bsz repo
22:01 andreashm why? no idea
22:01 cait heh
22:01 cait no idea what it is
22:02 cait not a lot in english there
22:12 andreashm yeah, I noticed. and my german is poor. but a little interesting
22:15 andreashm trying to read a document about the gbv-bsz cooperation. =)
22:16 cait ah
22:16 cait let me know if i can help
22:17 alexbuckley hi cait, found the bug report: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 , reopening it
22:17 huginn` Bug 17954: minor, P5 - low, ---, koha-bugs, REOPENED , Remove the sql code from the smart-rules.pl administrative script
22:18 cait ashimema: see bug 17954 - i thnk you were looking for it earlier
22:18 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 minor, P5 - low, ---, koha-bugs, NEW , Remove the sql code from the smart-rules.pl administrative script
22:18 alexbuckley using the ALL helped thanks
22:20 cait :)
22:23 cait good night all
22:23 caroline1 bye!
22:23 alexbuckley bye
22:27 andreashm night
23:21 koha-jenkins Project Koha_18.05_D8 build #202: SUCCESS in 20 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/202/
23:25 koha-jenkins Project Koha_18.05_D9 build #200: SUCCESS in 26 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/200/
23:40 koha-jenkins Project Koha_18.05_D8 build #203: SUCCESS in 19 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/203/
23:44 koha-jenkins Project Koha_18.05_U18 build #202: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/202/
23:52 koha-jenkins Project Koha_18.05_D9 build #201: SUCCESS in 26 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/201/