Time  Nick            Message
01:17 huginn          News from kohagit: Bug 21704: (QA follow-up) Fix evil tabs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c579b9c8f4dbffd0a521198d530d7012eb5d2402>
01:17 huginn          News from kohagit: Bug 21704: (follow-up) Remove unused 'frameworkcode' template param <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=edf99afa63e2c57fcda3f39ef36a651ac109d643>
01:17 huginn          News from kohagit: Bug 21704: Edit framework subfield link is broken (TT filter) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e7c049fea753232a51d78e07a9f15354cd71a469>
01:17 huginn          News from kohagit: Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5256f25d24b114a5186a9ed612e845e114bebb7e>
01:17 huginn          News from kohagit: Bug 20720: (QA follow-up) Some minor corrections <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3a150b5d7519c2969de6d966193af242e1e787e0>
01:17 huginn          News from kohagit: Bug 21186: (follow-up) Incorrect Bootstrap modal event name in multiple templates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b94399131614a304b3a0282ec8a85194cc72b3cf>
01:17 huginn          News from kohagit: Bug 21641: (follow-up) Address wrong call method <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4858c4f736d366701fa6a3f1def2727dd85c70ce>
01:17 huginn          News from kohagit: Bug 21641: (follow-up) Address additional call <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6fba062d291e065b4a6d7ffebdf82db9d6935971>
01:17 huginn          News from kohagit: Bug 21611: Fix priority dropdown for holds <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=de40a681625b544efdb697ab25b960bff08cb200>
01:17 huginn          News from kohagit: Bug 21311: (follow-up) Adjust wording of failed login message <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e64650216f568e7d7ad26e25ae59493202d871a3>
01:17 huginn          News from kohagit: Bug 21641: Added C4::Accounts to getnextacctno() call <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=344dba2fb84a743603c1c51294be4e378e6e5dc7>
01:17 huginn          News from kohagit: Bug 21634: Keep "circulation" module selected when viewing patron's logs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ad56b39888f1422606b16375b903fffa19bc59ba>
01:17 huginn          News from kohagit: Bug 20720: Found some more sponsors to add to 'about' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5367bfcabd395c926be1c8e215d0e8c2eb76898f>
01:17 huginn          News from kohagit: Bug 20720: Using git Sponsored-by lines to update 'about' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cde4bb0d2337add26de87dcb68ca5da371283099>
01:17 huginn          News from kohagit: Bug 21621: Remove incorrect GROUP BY from tools/letter.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0cffb0f7589aa52d65bda9a8a4934790a141f3a0>
01:17 huginn          News from kohagit: Bug 21613: (QA follow-up) Resolve warning on $ENV{_} - avoid autovivification <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b3661a5caeb634cbb6ca012998048d18d2f782b2>
01:17 huginn          News from kohagit: Bug 21613: (QA follow-up) Resolve warning on $ENV{_} <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8c45ed8601ce8ebe6c4b2c6ccc452865921a7ae9>
01:17 huginn          News from kohagit: Bug 21613: Turn strict SQL modes on for tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bab5ff0645768a1283f28d651687bd1cc6d3dfbe>
01:17 huginn          News from kohagit: Bug 21613: Add a test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5a979fd0c4c34f5ccd2da744dd2847faf72aef2b>
01:17 huginn          News from kohagit: Bug 21311: Remove locked message from opac-auth.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=716301d6f5bb149e963c5547d69d4019c20953db>
01:17 huginn          News from kohagit: Bug 21349: Instructors with special characters in cardnumber cannot be removed from... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2ca766f39245e1c3bd9b4acc9ce01a9eeaec8a56>
01:17 huginn          News from kohagit: Bug 21242: If not searching for patron, move to log viewer <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=411e78864918c909feffeadb341db37cea0a4393>
01:17 huginn          News from kohagit: Bug 21186: Incorrect Bootstrap modal event name in multiple templates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b6107beaf06d3e3956dc69145d966a35de1a59d>
06:38 josef_moravec   morning #koha
07:42 reiveune        hello
07:43 * andreashm     waves
07:44 * josef_moravec waves
07:50 marcelr         hi #koha
07:51 josef_moravec   hi marcelr
07:51 marcelr         hi josef_moravec
07:54 alex_a          bonjour
07:54 wahanui         hi, alex_a
07:55 magnuse         \o/
08:08 matts           hi
08:55 ere             morning #koha
08:56 * cait          waves
09:00 ashimema        morning #koha
09:00 cait            morning ashimema :)
09:01 marcelr         hi ere, cait and ashimema
09:01 cait            morning marcelr
09:02 ere             morning cait, marcelr and ashimema :)
09:03 * ere           dances for the first snowing in Helsinki
09:03 paxed           @wunder joensuu
09:03 huginn          paxed: Joensuu, Finland :: Clear :: 19F/-7C | Wind Chill: 14F/-10C | Monday: Mainly sunny. High 29F. Winds light and variable. Monday Night: A clear sky. Hard freeze expected. Low near 20F. Winds light and variable.
09:16 andreashm       @wunder stockholm
09:16 huginn          andreashm: Stockholm, Sweden :: Overcast :: 20F/-7C | Monday: Generally cloudy. High 29F. Winds ESE at 5 to 10 mph. Monday Night: Snow showers early will become steadier snow overnight. Cold. Low 23F. Winds E at 10 to 15 mph. Chance of snow 90%. 1 to 3 inches of snow expected.
09:20 marcelr         cait, ashimema: i have no problem with bug 21299; please explain
09:20 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move referer code from changelanguage to module in opac and staff
09:43 marcelr         ashimema: what about comment24
09:44 marcelr         ashimema: git mv
09:50 ashimema        hmm
09:51 ashimema        perhaps splinter review doesn't follow git mv
09:51 ashimema        I'll grab the patch proper
09:51 marcelr         that should be it
09:54 marcelr         ashimema: go ahead and finish the job :)
09:55 ashimema        I'm about to ;)
09:55 marcelr         thx
09:55 ashimema        no worries.. sorry for the false positive
09:55 ashimema        I was juggling allot ;)
10:25 ashimema        done
10:28 magnuse         ashimema++
10:30 marcelr         ashimema++
10:38 cait            ashimema: trailing whitespace shoudl not be an issue, i think the question was if we have a tabor spaces between the date and the dev
10:39 ashimema        well.. my whitespace fix just fixed trailing/leading space inside fields defined by tabs
10:39 ashimema        so hopefully should be fine
10:39 ashimema        I've left the status as NEW deliberately btw.. just in case you were tempted to switch it
10:40 ashimema        I wanted ot get some feedback from the people that know before submitting it proper..
10:40 ashimema        gonna ask Joubu to take  alook
10:40 ashimema        and rangi probably
10:42 marcelr         ashimema: somewhere on Bugzilla i must have left a similar script about developers and history..
10:43 marcelr         just wondering how useful the dev list in history.txt is btw; redundancy etc.
10:49 * kidclamp      waves
10:49 marcelr         hi kidclamp
10:49 marcelr         kidclamp++ # busy weekend
10:49 calire          hi kidclamp
10:49 marcelr         hi calire
10:49 kidclamp        just trying to keep up :-)
10:50 calire          hey marcelr :)
11:10 cait            marcelr, ashimema: i think it was an attachement on the about.pl omnibus bug
11:10 cait            the script from marcel
11:12 ashimema        my plan is to extract the developers list from history.txt and have a single 'contributors' file that can be used to construct history, all developers, contributors etc
11:12 ashimema        and then maintain that file via the release-tools
11:13 ashimema        it's a lunch break project ;)
11:26 paxed           jajm: the wiki page on the i18n plural forms etc, the "More on context" part should probably say the context is only a hint for translation, and is not shown for users.
11:26 marcelr         ashimema: dont forget the lunch break purpose ;)
11:27 jajm            paxed, ok I will add that, thanks
11:27 paxed           jajm: also making clear that same translation string but different context lets translators translate the string in different ways
11:39 oleonard        Hi all
11:39 jajm            paxed, done, thanks again for the feedback
11:39 calire          hi oleonard
11:39 wahanui         hi oleopard
11:41 paxed           jajm: nice, that's much clearer :)
11:47 cait            jajm++
11:49 cait            i wonder why you need both: items.count, { count = items.count }
11:49 cait            it seems a bit... verbose
11:50 cait            can it handle multiple params too?
11:53 jajm            cait, 3rd parameter is for gettext, the 4th is for replacements in string, not necessarily the same, but we can probably add a helper function to reduce verbosity
11:55 jajm            cait, if you mean multiple "{NAME}" in strings, yes, you can add as many as you want, but only one value as 3rd parameter for gettext to determine the plural form to use
11:56 jajm            for instance [% tnx('Hello {name}, you have {count} item', 'Hello {name}, you have {count} items', items.count, { name = 'John', count = items.count }) %]
11:57 cait            sorry, not getting it yet
11:58 cait            the first is singlular, the second is plural
11:58 cait            can you explain 3 and 4 again?
11:58 cait            i thought 4 was for variable replacing
11:58 cait            having an example with multiples on the wiki would be good too i think
11:59 jajm            there is one example with multiples on the wiki
12:01 jajm            cait, the 3rd parameter is used to determine which plural form will be used, in English, the singular form will be picked if items.count == 1, and the plural form otherwise, in French the singular form will be picked if items.plural is 0 or 1, and the plural form otherwise
12:02 jajm            cait, and you're right about the 4th parameter, every piece of string that looks like {name} in string will be replaced by the corresponding entry of the hashref passed as 4th parameter
12:02 cait            ah sorry, missed it (the example)
12:03 ashimema        is Pierre-Marc still working on bug 12446 do we know?
12:03 jajm            it's the equivalent of %s in our current translations, but with names
12:03 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 enhancement, P5 - low, ---, charles.farmer, Needs Signoff , Enable an adult to have a guarantor
12:03 cait            bbiab
12:03 ashimema        Just a quick look at the code and I can see there's a fair bit more cleaning up to do :(
12:04 paxed           jajm: maybe add a generic example line of the functions to the wiki page? like "tnx(singular_string, plural_string, integer, hash)"
12:04 paxed           jajm: and then refer to the parameters with those names instead of "3rd parameter" or "4th parameter"?
12:10 jajm            paxed, good idea, i should also probably start with the simpler tn function, without the 4th parameter
12:19 paxed           jajm: btw, problem nr. 2 is fixed quite well by bug 12221
12:19 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12221 enhancement, P5 - low, ---, pasi.kallinen, NEW , Remove TT statement placeholders from translatable strings
12:24 oleonard        Come back, splitter.koha-community.org!
12:26 ashimema        :(
12:28 Archie^         where the heck is default koha directory?
12:29 oleonard        What is the context for this question Archie^?
12:42 Archie^         oleonard: if i installed koha using packages
12:43 Archie^         i wanna know where is the files for Koha (like the PL scrip for MARC21 library bulk import)
12:47 magnuse         Archie^: most of it is in /usr/share/koha
12:48 magnuse         /usr/share/koha/bin/migration_tools/bulkmarcimport.pl
12:48 oleonard        We are finally approaching an adequate number of calires
12:48 Archie^         tnx
12:48 calire2         i dunno what is going on with my connection today
12:48 magnuse         we will accept no fewer than 3!
12:56 corilynn        bonjour #koha
12:57 andreashm       salut corilynn
12:58 corilynn        anyone else having problems pulling master today?
12:58 oleonard        Not me corilynn
12:58 corilynn        k, huh
13:04 tcohen          morning
13:05 ashimema        @later tell Joubu You didn't fancy casting your eye over my followup on bug 8000 for a final QA did you.. should be a quick one.
13:05 huginn          ashimema: The operation succeeded.
13:09 ashimema        cait?
13:09 wahanui         cait is qa manager
13:09 ashimema        what does PDA mean?
13:09 ashimema        ah
13:09 ashimema        doesn't apply
13:09 ashimema        silly me
13:12 oleonard        ashimema: Public Display of Affection
13:12 oleonard        Big problem with that on Bugzilla.
13:12 calire          :D
13:12 ashimema        hehe
13:14 ashimema        next bug on my hit list.. Racalls..
13:14 ashimema        Recalls.. even
13:14 ashimema        Damn!!.. this one's mahooosive
13:14 calire          ashimema yes
13:14 marcelr         yeah too big
13:16 ashimema        it's on caits hit list
13:22 calire          ashimema does it apply for you?
13:25 marcelr         hmm DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout' cannot be null at /usr/share/koha/devclone/Koha/Object.pm line 125
13:26 marcelr         ok, strict sql modes
13:42 caroline        Hi everyone!
13:47 oleonard        cait: Follow-up attached to Bug 20966
13:47 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 enhancement, P5 - low, ---, oleonard, Needs Signoff , Add column configuration to table of orders in a basket
13:47 oleonard        Hi caroline
13:54 andreashm       so strict sql mode can affect mariadb too?
13:54 * andreashm     that that was only mysql
13:55 tcohen          andreashm: both can change the default modes they run from version to version.
13:55 tcohen          the problems are:
13:56 tcohen          - unsafe ones hide bugs (so it is good to enable strict ones in dev)
13:56 Archie^         unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. why tho :/
13:56 tcohen          - some (unsafe) modes are deprecated and even removed in later versions of both engines
13:56 * andreashm     got a "DBIx::Class::Storage::DBI::_dbh_execute(): Field 'lowestPriority' doesn't have a default value at /home/kohamaster/kohaclone/Koha/Object.pm line 121" error on a test server after switching to mariadb
13:56 andreashm       when placing a hold
13:56 tcohen          andreashm: that's on your dev environment?
13:57 andreashm       one of them, yes
13:57 tcohen          file a bug, and submit a patch :-P
13:57 andreashm       pfff.
13:57 andreashm       magnuse already filed a bug
13:57 tcohen          file a bug
13:57 tcohen          ok!
13:57 andreashm       bug 19492
13:57 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492 normal, P5 - low, ---, koha-bugs, RESOLVED DUPLICATE, Field 'lowestPriority' doesn't have a default value (MariaDB)
13:58 tcohen          if you need to, you can disable the strict modes
13:58 andreashm       the interestin thing is that we switched two servers to mariadb, to test. one has issues placing holds, one has not.
13:58 andreashm       will go and look at the sql modes, see if there is any difference
13:59 oleonard        cait: I don't understand the QA tool warnings from Bug 20658
13:59 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 enhancement, P5 - low, ---, oleonard, Failed QA , Move template JavaScript to the footer: Installer and onboarding
13:59 oleonard        "FAIL   valid_template : filter not found" ?
13:59 oleonard        What does that mean?
14:00 marcelr         no filter like html or url or so ?
14:00 oleonard        If a filter is missing from a variable a different error is shown.
14:01 marcelr         [% blabla | html %]
14:01 oleonard        "missing_filter at line XX"
14:01 ashimema        er
14:01 * oleonard      removed some filters to confirm
14:01 ashimema        that a filter is there that we don't recognise in the qa scripts yet?
14:01 ashimema        perhaps
14:02 AndrewIsh       Anyone got a sec to confirm whether I've just found a unpleasant bug in master?
14:02 ashimema        no typos for uri or html?
14:03 * ashimema      is guessing at this point
14:03 ashimema        is it a big furry spider AndrewIsh (IRC)
14:03 AndrewIsh       Oooh, oooh, I saw that one on Friday oleonard here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 No idea what's causing it
14:03 huginn          Bug 21529: major, P5 - low, ---, jonathan.druart, Needs Signoff , Print notices no longer outputs html notices
14:04 AndrewIsh       Is it ashimema
14:04 AndrewIsh       s/Is it/It is/
14:04 oleonard        Oh I've got it. A template includes an include which uses the $raw filter but there's no USE raw
14:05 marcelr         ask Joubu to change the wording..
14:05 AndrewIsh       oleonard:  I did wonder about that but, upon checking, there's loads of examples where $raw is used but not USE'ed. So I discounted that as the cause
14:06 AndrewIsh       oleonard:  But, from what you say, it sounds like I was mistaken, doh!
14:10 AndrewIsh       oleonard:  Yep, that's the cause, weird that the error is wrongly reporting the missing filter. Anyway, I can sign off 21529 now, thanks! :)
14:13 ashimema        no I can't calire
14:13 ashimema        marcelr or mtompset still about?
14:13 marcelr         hi ashimema
14:14 ashimema        wondering if either of you can apply bug 19532, I'm sure last time i got stuck with this same apply error (on another alex buckley patch) one of you guys could apply it without issue
14:14 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 new feature, P3, ---, aleisha, Patch doesn't apply , Recalls for Koha
14:14 ashimema        wondering if it's the same issue
14:14 marcelr         will try
14:15 marcelr         Applying: Bug 19532: recalls history fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt).
14:15 ashimema        thankyou
14:15 marcelr         np
14:15 ashimema        same issue..
14:15 ashimema        okies
14:15 ashimema        ta
14:16 ashimema        guess I'll move onto the next one then :(
14:16 AndrewIsh       Any chance someone on master could go to the front page on Acquisitions and search for a vendor? I'm getting "Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088." when I do
14:19 ashimema        on it
14:19 ashimema        works for me AndrewIsh (IRC)
14:20 AndrewIsh       Ah crud, must be user error, thanks ashimema :)
14:20 ashimema        do you have vendors defined?
14:20 AndrewIsh       I do
14:20 ashimema        odd
14:20 AndrewIsh       I'll do some poking, thanks
14:30 Archie^         oleonard: can you explain me the bulkmarcimport.pl syntaxis? ./bulkmarcimport.pl -file /home/koha/Desktop/KOHA/lnc04_xml_eksperiments.xml -d       Is ths not correct ?
14:31 oleonard        Sorry Archie^ I'm not very familiar with that
14:31 Archie^         :(
14:31 oleonard        ...but there are other people here...
14:32 Archie^         anyonye used bulkmarcimport.pl here before? cait  ?
14:35 AndrewIsh       ashimema:  When you did that vendor search for me, did you have strict_sql_modes enabled?
14:35 caroline        Archie^: what are you trying to do? Can you not go trhough the ui?
14:36 AndrewIsh       ashimema:  I'm guessing not since as it's that that is causing the problem
14:37 ashimema        in theory I did yeah
14:37 ashimema        `<strict_sql_modes>1</strict_sql_modes>` inside <config> in koha-conf.xml
14:38 ashimema        ack
14:38 ashimema        apache restart required
14:38 ashimema        grr!
14:38 ashimema        or memcached
14:38 ashimema        sorry AndrewIsh (IRC)
14:38 ashimema        I see it now
14:39 AndrewIsh       No worries :) I'm just creating a bug for it
14:47 Archie^         right, so i have a marcxml file that contains ~ 20 000 records. i want to put it all in coha
14:48 Archie^         if i go trough the GUI it locks on ~ 6k records
14:50 caroline        Archie^: huh, really? I've imported 11k -20k records before
14:50 caroline        There might be a system preference?
14:51 Archie^         ya maybe. Someone said that i can do it trough bulkimport
14:52 caroline        sorry, I can't help you with command line importing. I've always just used the interface for all migrations :/
14:54 oleonard        Archie^: have you tried bulkmarcimport.pl and gotten an error?
14:56 Archie^         oleonard: ya it get's angry at me and and says "unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244." and then opens the manual for it
14:56 caroline        Is there a way to use the cities from Cities & Towns in a dropdown menu in an sql report? like <<Branch|branches>> uses libraries and <<item type|itemtypes>> use item types
14:57 oleonard        Archie^: I understand now. You should try it from koha-shell
14:57 oleonard        https://wiki.koha-community.org/wiki/Commands_provided_by_the_Debian_packages#koha-shell
14:58 Archie^         ok thank you i will try it :)
14:58 oleonard        caroline: I don't think so but that's a nice idea.
15:02 Archie^         lol it asks me for koha-library password
15:02 Archie^         now to understand what excatly that password is
15:03 oleonard        Archie^: bulkmarcimport.pl does? Or koha-shell?
15:04 Archie^         koha shell
15:04 Archie^         this sometimes makes me wish i wouldnt change my job xD
15:04 oleonard        Archie^: It should only require the name of your Koha instance.
15:05 oleonard        "koha-shell kohadev" or possibly "sudo koha-shell kohadev" ... if "kohadev" were your Koha instance name
15:06 Archie^         ya
15:06 Archie^         sudo koha-shell library
15:06 Archie^         it instantly asks me for the password... i dont remember setting any password for a specific koha shell
15:07 oleonard        Sounds like it's asking for the password for sudo
15:09 Archie^         not the sudo password, ive checked ;)
15:11 cait1           sudo koha-shell - root password
15:11 cait1           of your linux system
15:11 cait1           or of any user that can do sudo
15:12 Archie^         can't just sudo koha-shell it asks for instance
15:13 cait1           sudo koha-shell <instancename > and then the sudo password :)
15:14 * ashimema      starts to read the latest version of ES indexing improvement patches
15:14 Archie^         oh wow it worked!
15:14 Archie^         thanks cait1 !
15:14 cait1           ashimema++ thx for elasticsearch patch passing
15:15 ashimema        hoep I tested it well enough.. I couldn't break it.. ;)
15:15 ashimema        code looked sane
15:15 ashimema        always worried about big ones like that.. but someones got to dive in right?
15:17 cait1           i think we need to dive in
15:17 cait1           if the only production sites run with lots o extra code on top of normal version...
15:17 cait1           we need to catch up :)
15:17 ashimema        agreed
15:42 tcohen          I'm pretty sure 'Payment, thanks' is not the right description for an account type
15:43 bag             it should be “Show me the money!"
15:43 tcohen          hi bag!
15:43 bag             heya tcohen
15:43 ashimema        hello tochen
15:44 ashimema        tcohen.. even
15:44 tcohen          it should be 'Payment', and if required it would be used as '[% account_type_description %], thanks!
15:44 tcohen          not sure how we ended up here haha
15:44 ashimema        before I go and dig into creating an 'add_debit' method for Koha::Account.. have you any work no this already tcohen?
15:44 * tcohen        checks
15:45 tcohen          the biggest problem is tracking down all the hardcoded accounttype and offset types
15:46 cait1           tcohen: i agree, it should just be payment
15:46 cait1           tcohen: the whole decription for the gui was stored in the database
15:46 cait1           and non-translatable for a long long time
15:47 tcohen          I bet it was :-D
15:47 cait1           that's how we ended up there..
15:47 tcohen          I filed bug 21715
15:47 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Ease translation of account and account offset type descriptions
15:47 tcohen          to ease translating
15:47 cait1           and in old db you still have that of course
15:47 cait1           i thin it should only use the type for gui - no text
15:48 tcohen          yes, this is the GUI
15:48 tcohen          it is just that the collection of descriptions doesn't look correct either
15:51 ashimema        do we have a minimum perl requirement
15:51 ashimema        I can't seem to find one
15:52 tcohen          Perl 5.10 as per the release notes
15:52 tcohen          it's been debated
15:53 tcohen          I think Jessie's was th eone, but not sure
15:53 ashimema        jessie is packaged with 5.20.2
15:53 ashimema        wonder if we could push to that as anything behind jessie really is unsupported
15:53 * ashimema      likes 5.20.. it's the magic where signatures can be turned on
15:54 ashimema        https://packages.debian.org/search?keywords=perl
16:04 reiveune        bye
16:23 tuxayo          ashimema: hi :) Are signatures the thing that makes that we don't have to only use @_ to get parameters? i.e. naming and getting param like in many other widespread languages?
16:24 ashimema        yup
16:25 ashimema        still experimental though :(
16:26 ashimema        I've been using them with Mojo::Base for a while.. and hadn't apreciated that they're still still still experiemental
16:27 Miguel          Customize, print summary, so that the data of the barcode in the reservations come out thanks
16:28 Guest1713       Customize, print summary, so that the data of the barcode in the reservations come out thanks
16:29 caroline        Guest1713: print summary is not customizable
16:29 Guest1713       :(
16:30 * oleonard      wonders if there is a bug for that
16:30 cait            i think there is
16:31 * cait          grumps about translation bugs
16:31 cait            phrase got translated as exact
16:31 cait            which is not the same in zebra... because there is a thing like exact search
16:33 oleonard        Bug 11340
16:33 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 enhancement, P5 - low, ---, koha-bugs, NEW , Make the 'print summary' a custom slip/notice
16:33 caroline        since 2013... eesh
16:35 oleonard        The only reason I even remember 2013 is because I have a pen that says "kohacon13" on it.
16:35 caroline        lol!
17:19 mtompset        Greetings, #khoa.
17:20 mtompset        Greetings, #koha, even. :)
17:20 mtompset        @seen ashimema
17:20 huginn          mtompset: ashimema was last seen in #koha 54 minutes and 3 seconds ago: <ashimema> I've been using them with Mojo::Base for a while.. and hadn't apreciated that they're still still still experiemental
17:21 mtompset        ashimema, you here? Did you see my "waste" of time on bug 21682? :)
17:21 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 major, P5 - low, ---, martin.renvoize, Signed Off , Stock Rotation: Update DB is failing with strict_sql_modes ON
17:21 mtompset        Well, I probably shouldn't have marked it signed off. :)
17:22 mtompset        Finding that bizarre test state is going to be a pain, but I think the code changes would do it. :)
17:32 alexbuckley     hi #koha
17:45 alexbuckley     hi cait
17:46 cait            hi alexbuckley - sorry, just got home
17:46 cait            will be available a bit later
17:46 ashimema        hi mtompset
17:46 ashimema        just reading now
17:46 alexbuckley     no worries, I'll be offline in a bit soon as well walking to work :)
17:48 alexbuckley     hi ashimema trying to work out what's going on with git  re. 19532, it applies cleanly for me on up to date master
17:48 ashimema        ack
17:49 ashimema        this is the second patch I've had issues like this with.. though at least this time others could reproduce the issue
17:49 ashimema        it's really odd
17:49 ashimema        sorry for being a pain
17:50 alexbuckley     no worries, can you please tell me what git version your on?
17:50 ashimema        perhaps rebase the set and re-upload them all.. feels like I've got some missing history that's you git knows about
17:51 * oleonard      whispers conspiratorially, Squash it!
17:52 alexbuckley     ashimema, will do
17:52 ashimema        thankyou :)
17:52 ashimema        right.. need to go cook tea now.. be back in a bit
17:56 cait            can I come?
17:56 * cait          doesn't want to cook
17:58 Joubu           hi #koha
17:58 oleonard        Hi Joubu
17:59 cait            hi Joubu
17:59 cait            hi oleonard :)
18:02 mtompset        cait, bug 17218.
18:02 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 enhancement, P5 - low, ---, aleisha, RESOLVED FIXED, New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively
18:02 mtompset        Can't users still log into to 17.11 as DB User?
18:03 mtompset        If so, this needs to be a 17.11 patch, not resolved fixed.
18:03 mtompset        -- at least for the next 30ish days. :)
18:05 mtompset        ashimema, perhaps you grabbed bug 21682 before I pushed all four up? It applies cleanly for me.
18:05 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 major, P5 - low, ---, martin.renvoize, Signed Off , Stock Rotation: Update DB is failing with strict_sql_modes ON
18:13 Joubu           oleonard: for clarification:
18:13 Joubu           FAIL	  valid_template
18:13 Joubu           : filter not found
18:14 Joubu           Is an error raised by the TT parser, because a filter is used but "not found". Usually it means that the USE statement is missing (raw, KohaDates, etc.)
18:14 cait            mtompset: ok, but 30 days is really not long now
18:15 mtompset        Will we still have a RM for 17.11 after then?
18:15 Joubu           otherwise there is a "missing_filter" check, that fails if TT variables are found without being filtered
18:17 oleonard        Thanks Joubu, it was confusing until I realized what was going on.
18:41 Joubu           Guys, please do not start adding the raw filter everywhere when something is broken
18:41 Joubu           it's certainly not the way to go, you should read the difference between "uri" and "url" in the TT doc, or the wiki page I wrote
18:43 Joubu           @later tell kidclamp bug 19550 comment 14
18:43 huginn          Joubu: The operation succeeded.
18:45 mtompset        @seen fridolin
18:45 huginn          mtompset: fridolin was last seen in #koha 5 days, 4 hours, 27 minutes, and 58 seconds ago: <fridolin> enjoy :)
18:48 mtompset        I agree with you, Joubu. The links should be URL filtered.
18:52 Joubu           uri filtered
18:52 Joubu           yes url filtered
18:53 Joubu           lol I am editing all the wrong occurrences I can catch, so I am a bit lost
18:54 kidclamp        it works though :-)
18:54 kidclamp        but yes, that was almost 2 months ago, have learned since then
18:55 cait            i still have to read up on url /uri i have to admit
18:55 cait            still confused too :)
18:55 cait            kidclamp: grumpy with me for filling your queue? :)
18:55 kidclamp        just trying not to get behind
18:55 kidclamp        early push, gives more time to test
18:58 mtompset        Can I put a plug in for bug 14385? It would be nice to hit 18.11 :)
18:58 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, Passed QA , Extend OpacHiddenItems to allow specifying exempt borrower categories
18:59 oleonard        Bye #koha, 'til tomorrow
18:59 mtompset        Oh wow. It's that late already?
19:19 Joubu           @later tell mtompset can you eyeball the follow-up I have just attached to bug 21526 please?
19:19 huginn          Joubu: The operation succeeded.
19:52 Miguel          add column to table biblio is possible. Thanks
19:53 Guest1735       add column to table biblio is possible. Thanks
19:53 wahanui         i already had it that way, Guest1735.
19:53 Guest1735       i already had it that way, Guest1735.
19:53 cait            Joubu: do you have an idea maybe how i can make my koha explode? i tried to activate the stricts but something seems wrong
19:54 Guest1735       add column to table biblio is possible. Thanks
19:54 wahanui         i already had it that way, Guest1735.
19:54 cait            Guest1735: Koha is open source, so you are free to do anything with it, but I would not recomment making such changes
19:54 cait            you will want to keep Koha easy to maintain and easy to update
19:54 cait            what's the problem you are trying to solve?
19:55 Joubu           cait: how that?
19:55 Joubu           ha
19:56 cait            I've left a comment on the funds/budgets bug
19:56 cait            i tried testing it but I think my strict mode didn't take
19:56 Joubu           cait: bug 21604
19:56 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 major, P5 - low, ---, jonathan.druart, Signed Off , Cannot add/edit funds, cannot add budgets
19:56 Guest1735       Add a column to the biblio table, when I remember error when the loans are shown
19:56 Joubu           cait ha you commented on it!
19:57 cait            i did :)
19:57 cait            sorry Guest1735 that makes no sense to me
19:58 Joubu           cait: see others related to bug 17258, that are not pushed to master yet
19:58 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 major, P5 - low, ---, gmcharlt, NEW , [OMNIBUS] MySQL 5.7
19:58 Joubu           but what you reporte is weird, it should explode
19:58 Joubu           report*
19:58 cait            hm yeah :(
19:58 cait            it's prpbably something silly i am missing
19:58 cait            i edited the right koha-conf.xml right?
19:59 Joubu           cait: edit Koha/Database.pm and add a warn $sql_mode_query; before the connection is made
19:59 cait            one sec
20:00 cait            below uses?
20:00 cait            ah no, isee
20:01 cait            seems to be missing some
20:01 cait            IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
20:07 Joubu           seems like it's not picking the config entry, where did you put it?
20:08 Joubu           it must be inside the "config" tag, close to "dev_install"
20:09 cait            ok
20:09 cait            i didn't do that
20:09 cait            mine is below elasticsearch
20:10 cait            also, hsould be restart memcached be restart mysql here? https://wiki.koha-community.org/wiki/SQL_modes
20:10 Joubu           no, it should not be needed, just memcached then plack
20:11 cait            we should update the wiki page :)
20:12 cait            i did a restart_all
20:13 cait            got some nice warns...
20:13 cait            DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /home/vagrant/kohaclone/Koha/Objects.pm line 209
20:14 Joubu           not related
20:14 cait            i know
20:14 cait            but missing the sql modes now, that's confusing me
20:14 Joubu           your branch is up-to-date
20:15 Joubu           ?
20:15 cait            yes
20:15 cait            it was there a minute ago, same branch
20:15 cait            maybe the connection is still the same?
20:16 cait            hah got it now, sorry
20:16 cait            'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
20:16 cait            better
20:16 cait            shoudl be easy to explode things now :)
20:17 cait            btw... i just noticed i have some spam data in my db that look like a test created it
20:17 cait            itemtypes and staff users
20:17 cait            might have missed a test somewhere that does not properly use transactions :(
20:21 Joubu           hard to say which ones, but IIRC there were some api tests that did not clean correctly
20:21 Joubu           or selenium tests maybe...
20:23 cait            didn't run selenium ones, maybe something else
20:23 cait            hard to figure out now, but maybe someone else notices something
20:29 Joubu           @later tell kidclamp follow-up 2 attached to bug 21596
20:29 huginn          Joubu: The operation succeeded.
20:38 cait            Joubu++ btw, thx for helping :)
20:39 Joubu           you are welcome :)
20:43 cait            i pudated the wiki page a bit
20:47 cait            possibly this is not a bug but a data problem? Bug 21707        - Wrong CSRF token - adding a new patron with  auto generated card number turned on
20:53 cait            hi caroline :)
21:03 cait            alexbuckley: back on the holds now
21:04 alexbuckley     thanks cait :)
21:05 cait            the thing was that the checkboxes didn't lock for m
21:05 cait            e
21:05 cait            i have to try and see how to get there
21:06 cait            it looks better now :)
21:07 alexbuckley     great :)
21:07 cait            maybe 3 was a side effect
21:08 cait            or something missing
21:08 cait            the other fixes look good too
21:08 alexbuckley     brilliant!
21:08 cait            cool, just checked, it has a class too so could be hidden
21:08 cait            excellent
21:08 wahanui         darn tootin' it is.
21:12 corilynn        l8r #koha
21:13 cait            alexbuckley: can you please add text to go in the release notes?
21:13 alexbuckley     sure
21:13 cait            warning of the bheaviour change?
21:13 cait            not available in the opac before, just staff
21:14 cait            just so libraries know, not as a scary warning warning
21:23 alexbuckley     is this alright with you cait? http://paste.koha-community.org/142
21:23 cait            sounds good :)
21:23 cait            you know where to put it?
21:24 alexbuckley     thanks, and yup I know where to put it
21:25 alexbuckley     great added
21:25 cait            cool
21:25 cait            acq is very explosive once you have turned strict on...
21:25 alexbuckley     would you like me to remove the keyword 're;ease-notes-needed'?
21:26 alexbuckley     or would you like to?
21:28 cait            i was just about to :)
21:28 cait            done
21:31 alexbuckley     thanks for qa'ing cait :)
21:31 cait            np :)
22:21 cait            tcohen: can you maybe have a look at bug 21273?
22:21 huginn          Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21273 major, P5 - low, ---, koha-bugs, NEW , After upgrade from 17.11.08 to 18.05.02 intra not working, Software error: Template process failed
22:21 cait            or Joubu?
22:21 wahanui         Joubu is kidding, right ;)
22:21 cait            wahanui: always, especially about evil bug
22:21 wahanui         cait: i'm not following you...
22:25 Joubu           wahanui: I am not kidding with you
22:25 wahanui         ...but joubu is kidding, right ;)...
22:25 Joubu           not with you
22:26 caroline        wow, I come in and Joubu seems to be having a very serious conversation with wahanui...
22:27 Joubu           cait: no idea about 21273
22:29 cait            i couldn't quite follow his explanation
22:30 cait            they are simiar to us - public institution supporting libraires in their area
22:35 caroline        good night #koha!
22:48 wizzyrea        joubu++
22:52 Joubu           wizzyrea: the bug is quite fun as it happens randomly, I guess that's why I closed it few months ago
22:54 cait            'fun'
23:23 mtompset        Greetings, alexbuckley cait Joubu
23:44 mtompset        @seen Joubu
23:44 huginn          mtompset: Joubu was last seen in #koha 52 minutes and 24 seconds ago: <Joubu> wizzyrea: the bug is quite fun as it happens randomly, I guess that's why I closed it few months ago
23:44 mtompset        You still around, Joubu?