Time  Nick             Message
00:22 dcook            Ohai has anyone contributed to "marc-perl"?
00:22 dcook            I know gmcharlt has https://github.com/gmcharlt/marc-perl and has lots of MARC modules on CPAN...
00:22 dcook            And I think tcohen has contributed at some point
00:22 dcook            Just wondering what the canonical repo is for it...
00:24 dcook            Maybe https://sourceforge.net/projects/marcpm/ ?
00:26 dcook            @last seen dcook
00:26 huginn           dcook: (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message must match; --nolimit (1 more message)
00:26 dcook            @last dcook
00:26 huginn           dcook: (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message must match; --nolimit (1 more message)
00:26 dcook            @seen dcook
00:26 huginn           dcook: dcook was last seen in #koha 5 seconds ago: <dcook> @last dcook
00:26 dcook            @seen gmcharlt
00:26 huginn           dcook: gmcharlt was last seen in #koha 1 day, 3 hours, 59 minutes, and 57 seconds ago: <gmcharlt> cait: awww. yeah, my colleagues mentioned that to me; just tied up keeping fires burning at home, as it were
00:27 dcook            @later tell gmcharlt Hey Galen, what's the canonical repo for marc-perl? I was thinking of contributing to marc-lint, but not finding any documentation for contributions.
00:27 huginn           dcook: The operation succeeded.
00:31 dcook            @later tell gmcharlt I see git://git.code.sf.net/p/marcpm/code and git://marcpm.git.sourceforge.net/gitroot/marcpm/marcpm around the interwebs. How does one send a merge request?
00:31 huginn           dcook: The operation succeeded.
06:03 archie           Good morning everyone
06:18 fridolin         hi there
06:33 calire           morning #koha
06:34 alex_a           bonjour
06:35 * dcook          waves
06:37 calire           hi dcook
06:37 reiveune         hello
06:37 dcook            hey calire :)
06:54 ere              good morning :)
06:56 ashimema         morning #koha
06:56 ashimema         rangi or wizzyrea still about by any chance?
06:56 * ashimema       doubts it.. bit late over there I tihnk
07:00 dcook            Yeah I think its' about 8pm there as it's 6pm for me
07:01 cait             good morning #koha
07:01 dcook            morning cait
07:01 ashimema         indeed
07:01 ashimema         thought so
07:01 * dcook          needs to go buy more electronics components and do more programming after spending 8+ hours programming at work
07:02 ashimema         lol
07:02 * ashimema       thinks dcook is a geek... in a good way
07:07 dcook            ^_^
07:07 ashimema         caroline about yet?
07:08 ashimema         nope
07:08 cait             too early for canada i think
07:09 dcook            3am for caroline I think
07:10 * dcook          is clearly very good at leaving the office
07:11 ashimema         lol
07:14 * cait           waves
07:14 cait             drojf: are you real?
07:14 dcook            O_O
07:15 * drojf          makes ghost noises
07:17 * cait           is scared
07:17 * drojf          is a friendly ghost
07:18 drojf            mostly
07:18 cait             like caspar? :)
07:20 ashimema         Lol
07:21 ashimema         My cats not a friendly ghost?
07:22 cait             drojf: nice to see you around :)
07:23 cait             morning andre
07:23 cait             andreashm (auto-complete fail)
07:24 andreashm        guten morgen liebe kollegin
07:24 andreashm        cait
07:25 andreashm        cait: ready for Luleå next week? =)
07:26 * ashimema       had also been wondering where drojf has been
07:26 ashimema         Nice to have you back
07:26 cait             andreashm: not quite yet... but hopefully getting there. getting sick was not planned for
07:27 drojf            how was kohacon?
07:28 cait             what can I say without feeling mean?
07:29 drojf            it was bad, trump showed up and made everybody sad, stuff like that
07:30 cait             can't really say that happened
07:30 cait             i think it rained a bit one day...
07:31 andreashm        hi drojf!
07:31 andreashm        cait: hope you will feel better soon!
07:32 cait             already do, but it took a bit of time away :)
07:32 * dcook          waves to andreashm
07:32 dcook            I always mix up andreashm and ashimema's names visually heh
07:32 dcook            But I'm off. Hope you all have good days.
07:32 andreashm        hi dcook!
07:32 andreashm        dcook: working late again?
07:32 dcook            Always
07:32 dcook            heh
07:33 dcook            Off to an electronics shop to buy more components so I can do a bit of work at home too apparently
07:33 andreashm        maybe me and ashimema should change nicks one day, as watch the confusion that follows
07:33 dcook            Need to make my house smarter
07:33 dcook            heh
07:33 dcook            I better run now though
07:33 * dcook          waves
07:33 andreashm        change as/and
07:33 wahanui          andreashm: that doesn't look right
07:34 ashimema         lol
07:34 andreashm        =)
07:36 * ashimema       is on a mini website cleaning spree
07:39 cait             ashimema++
07:40 ashimema         first time properly playing with wordpress for years.. so far so good
07:42 drojf            bug 21536 is tiny and would make packages happy
07:42 marcelr          drojf!
07:42 drojf            :)
07:42 marcelr          is it real?
07:46 drojf            i think so
07:48 drojf            @wunder berlin, germany
07:48 huginn           drojf: Berlin, Germany :: Clear :: 59F/15C | Wind Chill: 56F/13C | Thursday: Sunny. Warm. High near 75F. Winds SE at 10 to 20 mph. Thursday Night: A clear sky. Low 53F. Winds SE at 10 to 15 mph.
07:49 drojf            actually wearing sun glasses
07:50 drojf            in mid october
07:50 marcelr          october is the new august
07:51 marcelr          gsm
07:51 marcelr          oops
08:26 ere              @wunder helsinki, finland
08:26 huginn           ere: Helsinki, Finland :: Clear :: 52F/11C | Thursday: Sunny to partly cloudy. High near 55F. Winds SW at 5 to 10 mph. Thursday Night: Cloudy skies. Low 48F. Winds SSW at 5 to 10 mph.
08:27 ere              not bad for the time of year :)
10:00 paxed            if i were to add a syspref that is YAML text field, where could i put the example value for it? the preferences/*.pref format is not very good for that.
10:28 cait             Some are decribed on the wiki and in the pref descriptions (even if not so nicely)
10:28 cait             i think there is a patch about validating the input and displaying issues on about.pl somewhere too
10:28 cait             the format for opachiddenitems is on the wiki
10:28 cait             you could also submit a bpatch to the manual
10:55 josef_moravec    cait: it is bug 21502
10:55 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 enhancement, P5 - low, ---, josef.moravec, Needs Signoff , Add checks for YAML formatted system preferences to about page
10:58 * josef_moravec  wondering if all the plugins hooks are documented somwhere
11:26 oleonard         Yo
11:27 calire           waddup
11:37 cait             paxed ^
11:43 paxed            cait: not quite what i was looking for, but i think the patch for the manual will be best
11:54 oleonard         calire++
11:54 oleonard         Thanks for the signoffs!
11:56 calire           you're welcome, I'd have done a few more but the emails are flowing steadily today...
12:00 * oleonard       wonders how many half-finished git branches is a normal amount
12:00 eythian          there's no upper bound, trust me
12:00 * ashimema       knows that wonder
12:39 Archie_          anyone used vagrant before?
12:41 oleonard         Yes
12:42 Archie_          oleonard: had any issues with it? i can't launch it :/
12:43 oleonard         What's your host platform?
12:44 barton           Archie_: when you run 'vagrant up', it should tell you what it's going at each step... how far does it get?
12:44 oleonard         Are you trying to install kohadevbox?
12:44 Archie_          no, i'm trying to run openlibrary
12:44 Archie_          i guess it's at the end of vagrant up, i'm getting this error
12:44 Archie_          ./usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/communicators/ssh/communicator.rb:257:in `execute': The SSH command responded with a non-zero exit status. Vagrant (Vagrant::Errors::VagrantError)
12:45 Archie_          the vagrant irc group is SUPERsilent and openlibrary slack group looks like deserted place ;(
12:47 oleonard         Archie_: My guess is that it's not Vagrant you're having a problem with but the box you're using. No idea how to advise you.
12:47 Archie_          oh well
12:48 barton           yeah, whoat oleonard said... that error is *very* generic.
12:51 barton           so vagrant is basically talking to the virtual machine via ssh, probably doing some sort of provisioning. That error is basically saying that an error occurred while using ssh, which vagarant is basically going to use for *everything*.
12:53 barton           ... you might try running 'vagrant halt' and then try 'vagrant up' again. I sometimes have problems with ssh connections in virtualbox, and have to run through that several times in a row before a successful ssh connection.
12:53 marcelr          always try it three times :)
12:54 barton           I would also try your luck at googling for the error if you haven't already.
12:54 barton           or 'duck duck going' if you're one of the cool kids.
12:55 marcelr          cool++
13:06 tcohen           @wunder cordoba, argentina
13:06 huginn           tcohen: Cordoba, Argentina :: Rain :: 51F/10C | Thursday: Showers early, then cloudy in the afternoon. High 57F. Winds E at 5 to 10 mph. Chance of rain 30%. Thursday Night: Showers early, then cloudy overnight. Low 47F. Winds SSE at 5 to 10 mph. Chance of rain 50%.
13:12 ashimema         hello tcohen
13:20 Freddy_Enrique   Heeeello eveyone
13:32 Archie_          barton: tried everything you said ;D nothing works. even reinstalled vagrant, still no luck
13:32 Archie_          also it's not as generic as it would seem, since i couldn't find anything on google
13:33 eythian          @wunder ams
13:33 huginn           eythian: Amsterdam, Netherlands :: Partly Cloudy :: 70F/21C | Thursday: Showers late. Lows overnight in the upper 50s. Thursday Night: Clear skies early then increasing clouds with showers late. Low 57F. Winds SSE at 10 to 15 mph. Chance of rain 40%.
13:33 eythian          wtf 21°
13:36 Archie_          what i don't understand is, if vagran lounches virtualbox and then exits with 1, i check the virtualbox and the machine is "running|
13:37 oleonard         Archie_: Part of what vagrant does is to perform a bunch of setup work on the guest machine. The guest machine can be "running" without that process having completed successfully.
13:37 Archie_          oleonard: is there some sort of a log that i can check for this ?
13:37 mtompset         cait++ # Thanks for discovering 14385 needed a rebase.
13:38 oleonard         Archie_: I don't know
13:39 corilynn         anyone around to talk about the "Manage staged MARC records" page?
13:39 corilynn         aka "Staged MARC management"
13:41 corilynn         my basic question is what changes an import batch from "staging" to "staged"
13:42 fridolin         ashimema: hi dear RMaint
13:42 fridolin         I try to rebase Bug 21385
13:42 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 major, P2, ---, martin.renvoize, Pushed to Stable , Vendor search: Item count is incorrectly updated on partial receive
13:42 mtompset         Not sure, corilynn. But if one had the patience to read code, I'm sure it would become apparent. Sadly, I'm working on a rebase, so can't look.
13:42 barton           tcohen: any thoughts on Archie_'s vagrant issues? He's trying to get an openlibrary vagrant box up ^^
13:42 fridolin         i cant get the UT to pass
13:43 corilynn         mtompset, greping the code like my next meal depends on it
13:43 mtompset         Greetings, #koha oleonard Archie_ corilynn barton tcohen fridolin :)
13:43 fridolin         bonjour
13:43 wahanui          niihau, fridolin
13:43 barton           morning mtompset!
13:43 Archie_          Hey there!
13:44 mtompset         corilynn, grepping?! I said read, as in like a newspaper. :)
13:44 oleonard         corilynn: Why do you ask?
13:44 mtompset         "I wonder what's happening in the world of MARC record staging. Let's read {insert filename}."
13:45 corilynn         working on bug 18823, and my import batch is in state "staging" so the magic buttons don't show up
13:45 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 enhancement, P5 - low, ---, carnold, ASSIGNED , Advanced editor - Rancor - add ability to edit records in import batches
13:45 corilynn         the one I imported the way it was originally designed (by importing files) is in state "staged"
13:45 corilynn         and it has magic buttons
13:46 oleonard         corilynn: Does it say somewhere in the interface that your batch is "staging?"
13:46 corilynn         it does, on the stage-marc-import.pl page
13:47 corilynn         no
13:47 corilynn         cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1
13:47 corilynn         Status: staging
13:49 oleonard         I don't know corilynn. I didn't think a batch would appear on that page at all before it had the status "staged."
13:49 corilynn         mm k
13:49 oleonard         The template doesn't even have the word "staging" in it
13:50 cait             tcohen: around?
13:50 corilynn         but what makes it "staged" something in the cgi-bin/koha/tools/stage-marc-import.pl?
13:50 cait             it's always staged first
13:50 corilynn         oleonard, yeah, that's the result of my grepping ;)
13:50 cait             before you commit it
13:50 corilynn         cait, yes
13:51 cait             there is no way to directly import without staging first
13:51 corilynn         word
13:51 cait             hm?
13:51 cait             sorry might be misunderstanding
13:51 corilynn         I think it's a bug in the 18823 code
13:51 cait             bug 18823
13:51 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 enhancement, P5 - low, ---, carnold, ASSIGNED , Advanced editor - Rancor - add ability to edit records in import batches
13:51 cait             ah
13:52 corilynn         so, when the import batch is created from Rancor, it's set to "staging"
13:52 corilynn         but never set to "staged"
13:55 cait             hm either something new... or a typo?
13:56 corilynn         new, looks intentional(ish), but I'm not sure why
13:56 corilynn         thx for your help cait
13:56 cait             probably more confusing than helpful :)
13:57 corilynn         nah, I wanted to know if there was tribal knowledge of why it might be set to staging to avoid some 'no don't do that it'll make everything broken'
14:05 mtompset         cait, bug 14385 is rebased. :)
14:05 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, Signed Off , Extend OpacHiddenItems to allow specifying exempt borrower categories
14:05 mtompset         One silly test count line.
14:18 mtompset         cait++ # prompt replies on bug 14385. :)
14:18 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, Signed Off , Extend OpacHiddenItems to allow specifying exempt borrower categories
14:31 oleonard         Hi CrispyBran
14:31 CrispyBran       Hello oleonard
14:33 CrispyBran       oleonard: question.  When you enable SYNC_REPO, is your startup much slower?
14:33 oleonard         I've only ever used SYNC_REPO.
14:35 CrispyBran       So, when you create a branch, does it copy EVERYTHING to the branch?  I created a branch, which took a while, and then with git status it looks like every file is in there and red.
14:40 cait             it doesn't really copy
14:40 cait             not in like a file sytem works
14:41 CrispyBran       but does it show up that way for you?
14:50 mtompset         Greetings, CrispyBran
14:51 CrispyBran       greetings
14:52 mtompset         CrispyBran, what do you mean "startup"? If you vagrant up after a vagrant destroy... SYNC_REPO is a heaven-sent blessing!
14:53 corilynn         MJ
14:53 corilynn         oops
14:53 CrispyBran       When I was using vagrant without SYNC_REPO, it started up fairly quick.  Maybe 30 seconds.  Now with SYNC_REPO, it takes a minute or two to startup
14:53 CrispyBran       First time with this, so just trying to get a grid for what to expect.
15:17 oleonard         CrispyBran: "Startup" meaning from "vagrant up" to being ready to "vagrant ssh?"
15:38 oleonard         AndrewIsh around?
15:38 AndrewIsh        oleonard:  \o/
15:39 oleonard         What is the motivation behind Bug 20883? userid rarely appears in Koha
15:39 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 enhancement, P5 - low, ---, andrew.isherwood, Needs Signoff , Patron userid should be exposed
15:40 AndrewIsh        oleonard:  Request from a customer, beats me
15:41 oleonard         :D
15:41 cait             might be what they autenticated for the ill?
15:43 AndrewIsh        cait:  Sorry, not sure I follow
15:44 cait             if the userid was the email, they might see that in the external ILL too.... or something like that?
15:44 cait             if there is an external system... might think too much in how things work here
15:44 cait             and shoudl go home anyway :)
15:45 AndrewIsh        No idea to be honest, I can do some digging to find out why we were asked for it
15:45 AndrewIsh        Have a good evening cait! :0
15:45 cait             thx AndrewIsh, you too :) will probably be back later
15:45 cait             got some bugs to file
15:46 oleonard         I don't object to it AndrewIsh, it just seems odd to me because it's so uncommon in the interface.
15:46 AndrewIsh        oleonard:  I agree, though it would be good to know why we're including it! I'll do some digging :)
15:47 ashimema         I don't see that one on our trello board at all AndrewIsh
15:47 AndrewIsh        ashimema:  I fully expect it was the result of an aside made to by a customer at some point
15:48 AndrewIsh        Man, there wasn't much coherent English in that last comment was there
15:49 AndrewIsh        Basically, I think it was a "oh, by the way, can we include user ID in the request display" comment made at some point
15:50 ashimema         must admit.. I also don't see the point of exposing patron_id.. it's an internal number and we already show name and cardnumber and link to the patron profile btw the looks so just seems a bit odd
15:50 * oleonard       wonders if they meant card number
15:51 ashimema         I think they might have done
15:51 ashimema         or I suppose if they use usernames instead of cardnumbers to login then perhaps username
15:51 ashimema         but not id in any case
15:51 ashimema         cardnumber is already there..
15:52 AndrewIsh        Frankly I have no memory of the who, why or where, I'm asking around in the hope that someone can shed some light
15:52 ashimema         so I reckon it must be username (login) ?
15:52 ashimema         actually.. wierdly cardnumber isn't visible even though it was already returned
15:53 AndrewIsh        This is an area that is touched by a number of bugs that have yet to be merged, so it's in flux
16:00 ashimema         ;)
16:05 caroline         Hello everyone!
16:12 oleonard         Hi caroline
16:13 caroline         Hi oleonard!
16:13 wahanui          hi oleopard
16:13 caroline         I was starting to wonder if I was in the right channel
16:13 caroline         quiet today?%
16:34 corilynn         I was busy following the white rabbit of "staged" import_batches
17:30 * CrispyBran     waves
17:43 mtompset         corilynn shall hence forth be known as Alice in Staging Land. :)
17:44 mtompset         Did you figure our problem out, corilynn?
17:44 corilynn         the staging thing?
17:44 corilynn         it wasn't exactly a problem until the code for 18823 was introduced that doesn't go through the normal import batch processing
17:45 corilynn         I just forced import batches created by the cataloging interface to be created as "staged" b/c there's no mechanism to make them that way
17:45 corilynn         now my problem is unsanitary input from the user
17:46 corilynn         because I broke all kinds of goodies putting things like "It's got to work now" in the string
17:47 corilynn         mtompset, I don't think C4::Scrubber does that... do we have something that does?
17:48 mtompset         You should have cleaned up your MARC before importing. I use MarcEdit.
17:48 corilynn         it's not mark, but the name of the import batch
17:48 corilynn         MARC
17:49 corilynn         or rather the "Comments" field for import_batch
17:51 mtompset         Sorry, my brain is not understanding the problem. I blame a lack of lunch. :)
17:52 mtompset         I think I may grasp now, but don't know how to address it.
17:53 corilynn         if you put "Tom's Files" in the Comments field when you are doing a MARC import, it will hang the code for bug 18823
17:53 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 enhancement, P5 - low, ---, carnold, ASSIGNED , Advanced editor - Rancor - add ability to edit records in import batches
17:53 corilynn         so I have to either sanitize the input, or encode the output
18:15 cait             corilynn: interesting!
18:16 corilynn         cait, probably the first test my hubby would do...
18:16 cait             he is tom?
18:17 corilynn         he's a long time QA guy
18:17 corilynn         he would put !@#$%^&*()_+{}::"';-=[]<>?,./ as the comment
18:18 cait             :)
18:18 cait             i am tempted
18:18 corilynn         when we were picking out baby things he broke them at the store to test their limits
18:18 cait             are you using a kohadevbox?
18:18 corilynn         i am
18:18 cait             that sounds a little annoying :)
18:18 cait             well depending on how the store takes it
18:18 corilynn         to the store maybe
18:19 corilynn         i donno, I kinda liked that we had things we could trust
18:19 cait             have you run the qa script on the patches?
18:19 cait             that's a good point
18:19 corilynn         not today
18:19 cait             it would be interesting to see if it's missing filters
18:19 corilynn         but previously
18:19 corilynn         filters?
18:19 cait             html filters
18:20 cait             TT filters to prevent XSS
18:33 corilynn         no hmlt filter issues, but I got a fail on valid_template
18:44 tcohen           cait: around?
19:11 * andreashm      waves
19:12 corilynn         cait, finished fixing all the QA tools tests, no mention of html fileters to prevent XSS
19:13 cait             it's good then
19:14 corilynn         well, no
19:14 cait             hm
19:14 cait             maybe check if qa tools are current
19:14 cait             cd home/vagrant/qa-test-tools
19:14 cait             git pull
19:14 cait             the checks were added very recently
19:15 corilynn         Already up-to-date.
19:16 corilynn         I think it's just not checking for this particular issue
19:17 cait             maybe something totally different
19:17 cait             the reason i mean
19:18 corilynn         yeah, i think that's it
19:25 ashimema         Hello
19:34 cait             hello
19:35 cait             ashimema: late night qa? ;)
19:42 ashimema         Just thought I'd check in
19:43 cait             just trying to tempt you :)
19:43 andreashm        qa cookies?
19:43 ashimema         Just realised I've missed a message from fridolin too.. can't work out when he sent it though.. phone is confused
19:43 ashimema         Hehe
19:43 ashimema         Got one in mind Cait?
19:44 cait             bug 11297
19:44 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 enhancement, P5 - low, ---, charles.farmer, Signed Off , Add support for custom PQF attributes for Z39.50 server searches
19:44 cait             is signed off, it's one of those that have been going on forever
19:45 ashimema         Ooh.. fun
19:45 ashimema         I like zebra challenges
19:45 ashimema         Haha
19:48 ashimema         That looks like it could take some brain power.. lok
19:53 rangi            caroline: are you about?
19:53 caroline         hi rangi !
19:53 rangi            hi :)
19:54 ashimema         I've stuck it at the top of tomorrow's pile Cait.. all looks sane but I'm not trusting my one beer down brain 😉
19:54 rangi            it doesn't look like i can get the modified thing to be per page sorry
19:54 caroline         rangi no worries!
19:55 cait             thx :)
19:55 caroline         thx for checking tho
19:56 caroline         I haven't had time to check for auto date update
19:56 caroline         probably won't have time before december
19:56 ashimema         caroline did you spot that I tidied up the documentation page on the community website btw.. hopefully you guys are happy with it.. just shout if you can think of any further improvement s
19:56 caroline         too many migration
19:57 caroline         ashimema: no, goign to check now :)
19:58 ashimema         Haha, if you weren't familiar with it you may not notice any difference.. I tried to keep the change subtle.. just cleaned it up a bit.. made the links consistent between versions and updated to latest stable versions etc
19:58 caroline         looks good (I admit I don't remember what it looked like before)
19:59 caroline         Was the dev version there before?
19:59 cait             it was, but still 18.05 labelled as dev :)
20:00 cait             wondered the same when martin asked me this morning
20:00 caroline         I meant if 18.11 was there before, but I guess not if 18.05 was labeled as dev
20:00 ashimema         Yup
20:00 ashimema         I made the dev one less prominent by moving it down the page.. felt sensible
20:00 caroline         I like it
20:01 caroline         ashimema++
20:01 ashimema         Yeah.. 18.11 wasn't there.. but as 18.05 was labeled as dev it made sense to add it in and label it properly
20:01 ashimema         Coolios.
20:02 ashimema         I feel happier now knowing a docs team person has taken a quick look 😀
20:03 caroline         I didn't remember about user created documentation
20:03 caroline         do you think that should be a wiki page so ppl can add their docs?
20:03 caroline         this : https://koha-community.org/documentation/other-docs/
20:05 caroline         btw you might soon see new @inlibro.com ppl on bugzilla! https://twitter.com/inLibro/status/1050449916617781253
20:06 caroline         (in French, but basically we're hiring) yay!
20:06 rangi            yay :)
20:08 ashimema         Yay
20:08 * ashimema       slinks off to bed..
20:08 * ashimema       feels like he's suddenly getting old
20:08 cait             sleep well :)
20:08 cait             caroline: wishing you the best new coworkers :)
20:09 caroline         :)
20:09 reiveune         bye
20:14 cait             hm also looking for qa on bug 21511 now... or additional sign-off :)
20:14 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 enhancement, P5 - low, ---, oleonard, Signed Off , Don't show acquisition details on subscription detail when there is no acq data
20:17 cait             ... and bug 20044 also signed by me...
20:17 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, Signed Off , Switch single-column templates to Bootstrap grid: Cataloging
20:20 cait             i had forgotten that and almost pqa on it :(
20:41 * caroline       feels bad for an intern because a coworker said to him "even caroline can do that" >_<
20:41 wizzyrea         omg rude.
20:41 cait             i feel bad for the coworker
20:41 cait             well that came not out like i wanted
20:42 cait             you are awesome, and he should know that.
20:42 caroline         it was for a server thing which is definitely not my expertise
20:42 wizzyrea         still rude.
20:42 wizzyrea         poor intern.
20:42 caroline         throw MARC at me and I'm fine, but sudo whatever
20:42 wizzyrea         and poor you!
20:43 wizzyrea         well not poor really
20:43 wizzyrea         worthy of indignance.
20:43 wizzyrea         on both of your behalf.
20:43 caroline         I thought it was funny (but still felt bad for the intern who studied 3 years in software engineering)
20:44 wizzyrea         everybody starts learning somewhere and nobody knows everything. I give it a harrumph.
20:44 caroline         thank you for your confidence :)
20:45 wizzyrea         ^.^
20:45 caroline         The devbox is working fine btw :)
20:46 wizzyrea         oh YAY
20:46 caroline         I imported the whole project gutenberg catalogue in it
20:46 caroline         which was what I wanted to try
20:46 CrispyBran       Anyone available to help me with a test.  I've no idea what I am doing.
20:47 wizzyrea         https://media.giphy.com/media/vFwpaVo3WAt3O/giphy.gif
20:47 caroline         CrispyBran: even caroline can do that!
20:47 caroline         (joking, I probably can't)
20:47 CrispyBran       :
20:47 CrispyBran       :)
20:47 caroline         aww thx wizzyrea!
20:47 wizzyrea         (after research and maybe a little struggling and some practice)
20:50 corilynn         what are we testing CrispyBran?
20:50 corilynn         (i might need a trade soon)
20:52 cait             caroline: how many are those?
20:52 caroline         cait: the project gutenberg thing?
20:52 caroline         there are 40000+ records
20:54 cait             ah, not too bad
20:54 caroline         I was looking for James Joyce books and though "that's probably public domain", which is a reflex I was never able to develop when I did reference
20:54 cait             thx
20:55 caroline         Ppl would come looking for classics which we didn't have and I never thought to look online
20:55 caroline         So I figured if I could import the whole thing in a library catalog, the reference librarians wouldn't have to think to look elsewhere (which is their job, but making it easier)
20:55 corilynn         Ppl were whining just the other day that classics weren't in the "Kindle" collection at ref, I said Guttenburg!!
20:56 corilynn         they ran away before I could show them :(
20:56 CrispyBran       I've been asked to work on the unit test for bug 21503.  tcohen wrote the start of something for me, but I don't understand it, and what he wrote doesn't even get past line 21.
20:56 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 enhancement, P5 - low, ---, cbrannon, Needs Signoff , Update AuthorisedValues.pm to fall back to code if description doesn't exist
20:56 caroline         :/
20:57 corilynn         CrispyBran, as I understand it they are suppposed to fail until you write the code to make them pass
20:57 corilynn         tcohen was talking about test driven development the other day
20:58 corilynn         https://technologyconversations.com/2013/12/20/test-driven-development-tdd-example-walkthrough/
20:58 corilynn         where is tcohen's code?
20:58 CrispyBran       in the bug.  2nd patch
20:59 corilynn         what do you mean by it doesn't get past line 21?
21:00 CrispyBran       It's breaking on line 21, which isn't even at the test section yet
21:00 corilynn         ah
21:00 wizzyrea         does it give an error when it dies?
21:01 CrispyBran       returned 13 (wstat 3328, 0xd00)
21:01 wizzyrea         are you running that in koha-shell
21:01 CrispyBran       should I?
21:02 wizzyrea         or, how are you running that
21:02 corilynn         yes
21:02 wizzyrea         ^
21:02 corilynn         (I only learned that today)
21:02 corilynn         but like at 9am
21:03 CrispyBran       ;)  Smart people hang out here
21:03 CrispyBran       I vaguely remember that tidbit.
21:03 wizzyrea         (reason is that koha-shell has all of the koha things in the ENV, your normal user probably doesn't)
21:03 CrispyBran       Need it in my notes.
21:03 corilynn         notes be saving our butts CrispyBran
21:06 cait             caroline++ corilynn++ wizzyrea++
21:06 cait             :)
21:06 * Freddy_Enrique after a nighmare day, decides to read the irc chat
21:06 * Freddy_Enrique OMG
21:06 caroline         cait are you just throwing karma around?
21:08 Freddy_Enrique   good afternoon caroline, cait, everyone
21:08 Freddy_Enrique   you've been busy I see
21:08 caroline         Hi Freddy_Enrique!
21:09 caroline         I thought it was quiet today
21:09 caroline         but maybe that's just because I didn't have irc on my 2nd as usual
21:10 cait             caroline: nope
21:10 * corilynn       takes a victory lap for solving my input problem
21:10 corilynn         on that note... going home
21:10 cait             have a good evening corilynn
21:10 caroline         bye corilynn!
21:11 Freddy_Enrique   victory lap....
21:11 * Freddy_Enrique Mr Google translator
21:11 Freddy_Enrique   jeje
21:17 Freddy_Enrique   not again... Talk to you later guys :(. Too many requests T_T
21:24 wizzyrea         CrispyBran, did you get yourself sorted out?
21:25 CrispyBran       Sort of.  Now I just need to figure out how to test specific things.  Deciphering what is there right now.
21:25 wizzyrea         but it runs and stuff now, cool :)
21:29 CrispyBran       yes
22:04 CrispyBran       @seen cait
22:04 huginn           CrispyBran: cait was last seen in #koha 53 minutes and 33 seconds ago: <cait> have a good evening corilynn
22:04 CrispyBran       cait: are you here?
22:04 CrispyBran       @seen Joubu
22:04 huginn           CrispyBran: Joubu was last seen in #koha 2 days, 1 hour, 20 minutes, and 46 seconds ago: <Joubu> @later tell tcohen did you fix emails on jenkins?
22:04 CrispyBran       @seen tcohen
22:04 huginn           CrispyBran: tcohen was last seen in #koha 3 hours, 20 minutes, and 10 seconds ago: <tcohen> cait: around?
22:05 CrispyBran       @seen mtompset
22:05 huginn           CrispyBran: mtompset was last seen in #koha 4 hours, 12 minutes, and 31 seconds ago: <mtompset> I think I may grasp now, but don't know how to address it.
22:05 CrispyBran       ugh!
22:06 wizzyrea         well you can just ask :)
22:19 caroline         good night #koha!
22:37 CrispyBran       is there a way to unobsolete a patch?
22:41 wizzyrea         ah yea
22:41 wizzyrea         there's a tickbox  sec lemme look
22:41 wizzyrea         CrispyBran, if you see the patch on the bug
22:41 wizzyrea         click "details"
22:41 wizzyrea         then click "edit details"
22:41 wizzyrea         on the left hand side
22:42 wizzyrea         there's a tickbox for "obsolete"
22:42 wizzyrea         just untick it
22:42 wizzyrea         and submit
22:42 CrispyBran       awesome!
22:43 wizzyrea         👍
22:47 CrispyBran       Ok, either my patch is bad, or I failed epicly at writing a test.  The test fails as expected on master, but fails again with the patch, but the patch does what it is supposed to do.  :/
22:47 wizzyrea         I find writing tests very hard.
22:48 wizzyrea         I always have to think for a looooong time