Time Nick Message 00:01 caroline_ hey everybody! 00:08 dcook salut caroline_ 00:10 caroline_ salut dcook! 00:10 caroline_ it's rare that we're on at the same time! 00:11 dcook It's true! What are you doing up so late? 00:11 dcook Well and on a Sunday? 00:13 caroline_ meh, bf is watching tv and I'm trying to install kohadevbox on my personal computer 00:13 caroline_ not with much success 00:13 dcook Oh tell me more? 00:14 dcook Owen, Tomas, Mark, and I have been discussing this 00:14 dcook https://gitlab.com/koha-community/kohadevbox/issues/273 00:14 dcook What kind of computer do you have? 00:14 caroline_ stuck at "kohadevbox login: _" 00:14 caroline_ macbook 00:14 dcook "kohadevbox login: _" 00:14 dcook I've never heard of that 00:15 dcook Where are you seeing that? 00:15 dcook Do you run Ansible from your Mac or do you use LOCAL_ANSIBLE=1? 00:15 caroline_ uh... not sure...? 00:15 dcook To which question? Heh 00:16 caroline_ I followed the instructions on gitlab up to "vagrant up" 00:16 dcook And after you do "vagrant up", it's prompting with "kohadevbox login: _"? 00:16 wizzyrea yeah does it do "stuff" 00:16 wizzyrea before it dies? 00:16 dcook ^ 00:16 * dcook waves to wizzyrea as it's been like a million years 00:16 wizzyrea hey dcook :) 00:17 dcook Hey ^_^ 00:17 caroline_ I'm not sure how I got there. I did that maybe two weeks ago. And now I clicked on the VM in Virtual Box and it's just a black screen with "kohadevbox login:_" 00:17 wizzyrea oh 00:17 wizzyrea you need to go into your terminal 00:18 wizzyrea go into your kohadevbox directory 00:18 wizzyrea and type vagrant ssh 00:18 wizzyrea and it should autologin? 00:18 wizzyrea cuz it sounds like it's provisioned and just sitting there, ready for you to do work :) 00:18 dcook ^ 00:19 caroline_ Should I turn off the vm? 00:19 dcook Nope 00:19 wizzyrea naw, if you do that it won't be running anymore. 00:19 wizzyrea and you can't log into something that isn't there 00:19 wizzyrea ^.^ 00:19 dcook When you click on the VM in Virtualbox, you're opening up a console through Virtualbox. But you don't need to do that. 00:20 wizzyrea you could also try 00:20 wizzyrea http://localhost:8080/ 00:20 wizzyrea in your browser 00:20 wizzyrea it should do stuff 00:20 caroline_ Ah ok so once i'm in vagrant@kohadevbox:~$ I can use my browser normally? 00:20 wizzyrea you don't even have to be logged in 00:20 wizzyrea if the vm is up 00:21 wizzyrea koha will work 00:21 caroline_ I don't need to open the VM and go into the browser there? 00:21 wizzyrea no, you shouldn't 00:21 wizzyrea i mean 00:21 wizzyrea YMMV 00:21 wizzyrea but it's kinda designed to expose whatever's running on the VM to your local computer 00:21 dcook ^ 00:21 caroline_ and localhost is literally "localhost" or I should sub that for something else? 00:22 wizzyrea yep, just as noted in the docs 00:22 dcook literally localhost 00:22 wizzyrea https://gitlab.com/koha-community/kohadevbox it's the next step here after vagrant up :) 00:22 wizzyrea it'll probably (maybe?) be in maintenance mode, depending on if you've been through the installer 00:23 wizzyrea which you may have done when you isntalled it weeks ago 00:23 caroline_ No, I didn't get to the koha interface 00:23 dcook Yeah Virtualbox uses portforwarding to forward port 80 to localhost:8080 and port 8080 to localhost:8081 00:23 dcook If they're not working, you might have something else binding to those ports on your computer 00:23 dcook What do you see when you go to http://localhost:8080? 00:23 wizzyrea usually if you're watching 00:24 wizzyrea you can see what ports it uses when you vagrant up 00:24 wizzyrea there's a command too 00:24 wizzyrea to show them 00:24 dcook I think I've had an issue where my IIS was binding to port 8080 so kohadevbox didn't work 00:24 dcook So I had to unbind IIS and restart my VM 00:25 caroline_ getting a bit too technical for me :) 00:25 dcook Sorry ;) 00:25 dcook What do you see when you go to http://localhost:8080 on your browser? 00:25 dcook In Safari or whatever it is one uses on a Mac 00:25 wizzyrea vagrant port in your terminal, in your kohadevbox directory, would show you what's happening with ports 00:27 caroline_ I went to localhost:8080 and localhost:8081 in Chrome and it's just spinning 00:27 pastebot "wizzyrea" at 127.0.0.1 pasted "for caroline - this is what mine looks like, and what that means in my browser." (5 lines) at http://paste.koha-community.org/109 00:27 wizzyrea right 00:27 wizzyrea you could also try 00:27 wizzyrea instead of localhost 00:27 wizzyrea 127.0.0.1:8080 00:27 wizzyrea 127.0.0.1:8081 00:28 wizzyrea it's possible that it didn't finish provisioning 00:28 wizzyrea so is in some kind of broken state 00:28 dcook That'd be my guess too 00:29 wizzyrea if you have some time, and don't have a sunk cost over this particular VM 00:29 wizzyrea you could destroy it and try again (that's one of the lovely things about vagrant/kohadevbox, actually - it's not a pet, it's cattle.) 00:29 caroline_ 8080 shows Apache page (I guess that's progress), 8081 doesn't work 00:30 caroline_ :( poor cattle... 00:30 wizzyrea yeah that sounds like it's not fully provisioned 00:30 wizzyrea ehh, if it were me I'd send that one to the abbatoir. 00:30 wizzyrea i mean, we can try to walk you through maybe 00:31 caroline_ so from vagrant@kohadevbox:~$ I do vagrant destroy 00:31 wizzyrea naw 00:31 wizzyrea if you type exit 00:31 wizzyrea that will log you out 00:31 wizzyrea it's inception terminal 00:31 wizzyrea a terminal within a terminal 00:32 wizzyrea once you are at something like ~/kohadevbox 00:32 wizzyrea then you vagrant destroy 00:32 caroline_ destroying in progress 00:32 wizzyrea if that makes sense? 00:32 wizzyrea yay :) 00:32 wizzyrea before you vagrant up 00:32 wizzyrea I'd make sure to do a git fetch in there 00:32 wizzyrea to make sure you have the latest fixes to kohadevbox 00:33 wizzyrea (since it's presumably been a couple of weeks since you downloaded it) 00:33 caroline_ pulled and now up-to-date 00:33 wizzyrea yassss 00:33 wizzyrea now, you can vagrant up 00:33 caroline_ up in progress 00:33 wizzyrea and just kinda watch it, and see if it poops out anywhere. 00:34 wizzyrea it's gonna take a bit you might want some ice cream. 00:34 caroline_ thx wizzyrea++ dcook++ 00:34 wizzyrea ah you can give me karma when you can see the web installer in your browser. :) 00:35 caroline_ you spent a lot of time walking me through, so you deserve it :) 00:41 dcook Cattle could be pets too... 00:42 dcook Maybe I won't tell those stories 00:42 dcook And no worries! 00:42 dcook koha-testing-docker is even more awesome... 00:42 wizzyrea I have a friend who raises cows, 00:42 wizzyrea they are both pets and cattle 00:42 dcook :D 00:42 wizzyrea "they are gonna have the best life until their one very bad day" 00:42 wizzyrea which I think is all any of us can hope for really 00:42 dcook With koha-testing-docker, the provisioning happens when you build the image, so start-up time takes maybe a minute or less. It's wonderful. 00:42 dcook Well not all the provisioning. But lots of it. 00:43 dcook wizzyrea: too right 00:43 dcook Although to each their own 00:43 * dcook tries to recall if caroline_ is vegetarian 00:43 caroline_ yes :) 00:43 wizzyrea oh I was referring broadly to the human condition 00:44 dcook and I was agreeing wizzyrea heh 00:44 dcook Here's hoping my one very bad day is a long ways off yet 00:44 dcook But I could ramble a lot about the living our best lives thing 00:44 wizzyrea ok, these are herbs not flowers. Chop them down any old time and grow new ones. 00:45 dcook Nicely put 00:45 dcook Of course now I'm hungry... oo 11:45am... 00:45 wizzyrea basically lunch time. 00:45 dcook And if you use SYNC_REPO, you will have a faster vagrant up 00:45 dcook Cloning the Koha git for each "vagrant up" is a real time killer 00:45 wizzyrea yeah that one does help, but can be messy for first timesrs 00:45 dcook Truth 00:46 wizzyrea and on a mac, and, and, and 00:47 caroline_ my colleague blou did my install on my work computer, so I didn't have to worry about that 00:47 caroline_ But I wanted to try some things out of work hours 00:47 wizzyrea fair enough :) 00:48 caroline_ at least now, ~1 yr later, I know basic git and terminal use 00:48 wizzyrea \o/ 00:49 dcook :D 00:49 wizzyrea it's not exaggeration to say that when you use git with koha 00:50 wizzyrea you kind of start at pro mode. 00:50 dcook basic git and terminal use is basically my life 00:50 wizzyrea we ask all the hard things straight from the get go. 00:50 dcook ^ 00:50 wizzyrea it's gotten better over time with gitbz and devbox 00:51 dcook Sooo true 00:51 caroline_ I don't disagree :) But I signed up for it knowing I wasn't super linux/oss geek 00:51 wizzyrea but you're still git fetch && git rebase origin/master and git checkout -b bug-xxxxxxx 00:51 dcook I feel like it was a baptism by fire back in the day 00:51 caroline_ I'm a long way from children's librarian :) 00:51 dcook heh 00:52 dcook Yeah, when I started on Koha, I'd just installed Linux for fun at home like 3 months before starting my job working on Koha 00:52 dcook Actually, I didn't even install it 00:52 wizzyrea I had literal 0 experience with git when I started. 00:52 dcook My girlfriend of the time bought a Ubuntu computer from someone 00:52 dcook Yeah I had 0 experience with git 00:52 dcook I think rangi and jcamins taught me everything I knew about git at the start 00:52 wizzyrea literal 0 about perl in itself. 00:52 dcook ^ that too 00:52 wizzyrea (stuff about other languages but not perl) 00:53 caroline_ I hope to be as good as you when I grow up :) 00:53 wizzyrea pf 00:53 wizzyrea you're probably better already. ;) 00:53 dcook It just comes with practice and experience 00:53 wizzyrea ^ 00:53 * dcook has an English BA, a French certificate, and a Librarianship masters 00:53 wizzyrea and poking your nose into it until it makes sense. 00:53 dcook ^ 00:54 dcook That was the advice I just wrote to David Nind about Docker on the listserv 00:54 dcook I think koha-testing-docker was my first time using Docker? 00:54 wizzyrea tbh I hate docker 00:54 dcook But then I have done more with Docker at home and at work apart from that 00:54 dcook :O 00:54 dcook I love Docker so much 00:54 wizzyrea it messes up the networking on my computer 00:54 dcook Really? 00:54 wahanui hmmm... Really is good to have josef_moravec back.. always get a boost from seeing a bunch of signoffs :) 00:54 wizzyrea and I don't have time for that crap. 00:54 dcook Weird 00:54 wizzyrea yep 00:54 caroline_ what is the difference between devbox and docker? 00:54 dcook I haven't had that problem at all but that would suuuuck 00:54 wizzyrea basically, if you need to be able to ssh from outside of your machine 00:54 dcook caroline_: Different underlying technologies 00:55 wizzyrea putting docker on messes it up 00:55 caroline_ but basically the same use? 00:55 dcook wizzyrea: That's very odd as I have no problems with that on servers or desktops :S 00:55 wizzyrea has happened to a bunch of people here 00:55 dcook Recently? 00:55 wizzyrea last 6 month 00:55 wizzyrea s* 00:55 dcook caroline_: basically it's ways of encapsulating apps yeah 00:56 dcook caroline_: Running code in a system within a system kind of 00:56 dcook More inception heh 00:56 dcook wizzyrea: That's super interesting. I'll keep an eye out for that. 00:56 wizzyrea inception servers 00:56 wizzyrea (everything is basically inception servers now though) 00:56 dcook Yarp 00:57 wizzyrea I try not to think too hard about it 00:57 wizzyrea unless I need to for some reason. 00:57 dcook Basically, kohadevbox leverages Virtualbox for virtualization 00:57 dcook That creates an entire system within a system 00:58 dcook Totally separate from the host system 00:58 dcook Whereas Docker re-uses the kernel of its host so it only separates some things 00:58 dcook It makes for a faster more efficient system 00:59 dcook Kernel being... kind of like the brian 00:59 dcook brain* 00:59 dcook (And Docker for Windows cheats) 00:59 dcook koha-testing-docker is awesome, but kohadevbox is the most ubiquitous so probably the best to know and use 01:20 caroline_ Is "Clone repository" supposed to take very long? It's been stuck there for at least 15 minutes 01:20 caroline_ I wish it were more verbose... like 0-100% 01:20 caroline_ at least I'd know it's working and not frozen 01:21 dcook Yeah "Clone repository" can take a super long time 01:21 dcook I think it once took me nearly an hour? 01:21 caroline_ ok thx :) 01:21 dcook That was with I think a 20Mbps download speed 01:22 caroline_ ooh... So I better not kill my VMs too much then 01:22 wizzyrea caroline_, this bit only happens when you provision the first time 01:22 wizzyrea definitely don't close your laptop 01:22 wizzyrea just leave it up and go to sleep :) 01:22 caroline_ can it go in sleep mode? 01:22 wizzyrea mm probably better not to 01:23 caroline_ ok, I'll plug it in to make sure it stays awake long enough 01:23 dcook Yeah once it's finished and you're ready to stop for the day, run "vagrant halt" I believe 01:23 dcook And that will gracefully shut it down until next time 01:23 dcook But yeah the time involved with kohadevbox is what I don't like 01:24 dcook We were saying how you can make it faster with a more advanced configuration 01:24 dcook But probably worthwhile to become a kohadevbox pro and then move on to more advanced configuration 01:24 caroline_ yeah... baby steps 01:33 dcook Oooh /var/log/apt/term.log is so cool :3 01:33 dcook And yep! All about the baby steps! 02:03 caroline_ :O https://snag.gy/1aTAmd.jpg \o/ 02:03 dcook Hurray! 02:04 wizzyrea hey nice :D 02:08 caroline_ yay! I'm in! thx wizzyrea++ and dcook++ :D 02:08 dcook You did all the hard work :) 02:09 rangi dcook: did you know jessie is doing a talk about her regrets about containers at kiwicon? 02:09 caroline_ Just so I know for next time, when I'm finished, I enter "exit", then when I want to go back I do "vagrant ssh" and then open my regular browser to localhost:8081 02:09 rangi dcook: https://kiwicon.org/the-con/talks/#e278 02:10 dcook rangi: Nope. I just remember kiwicon being finished and then hearing that it was starting up again? 02:10 wizzyrea you don't technically have to vagrant ssh 02:10 dcook ^ 02:10 rangi caroline_: you should do vagrant halt to shut it down, and vagrant up again (unless you want to leave it running, it doesnt take long to start back up and it reclaims a bunch of ram) 02:10 wizzyrea you just have to vagrant up 02:11 rangi exit will just get you out of the ssh, but it will be still running, unless you do a vagrant halt 02:11 rangi and it gets kinda confused sometimes if you suspend your machine 02:11 caroline_ ok so when I'm done: vagrant halt (I miswrote that as vagrant halp); when I want to go back: vagrant up 02:11 dcook ^ 02:12 wizzyrea that's right 02:12 dcook rangi: Just read the abstract. Sounds super interesting. 02:12 caroline_ +1 thank you! 02:12 caroline_ going to bed, but will start experimenting soon :) 02:13 wizzyrea sleep well. 02:13 caroline_ nice talking to you guys! 02:13 dcook rangi: So what's the story about kiwicon? It's a thing once again? 02:14 rangi at least for this year 02:14 rangi who knows if it is again next year 02:14 dcook Hmm 02:16 dcook "Note that this is a Friday and Saturday, not a week day or just on a weekend as per some other ‘cons. We're good like that." 02:17 rangi im pretty sure it's sold out already 02:19 dcook I wouldn't be surprised 02:19 dcook Makes decision-making that much easier ^_^ 02:19 dcook I'm still debating LCA2019... 02:19 dcook Also these FAQ are really cracking me up 02:29 dcook rangi: So you're presenting with your dad? 02:30 rangi yep, altho he might have to be on video as im not sure hes gonna be in the country 02:32 dcook Ahh sounds like a neat talk in any case 04:07 paxed @wunder joensuu 04:07 huginn paxed: Joensuu, Finland :: Clear :: 28F/-2C | Wind Chill: 22F/-6C | Monday: Sunny skies during the morning will give way to cloudy skies and light rain late. High 41F. Winds S at 10 to 20 mph. Chance of rain 90%. Monday Night: Cloudy. Periods of rain early. Low 36F. Winds SSW at 10 to 20 mph. Chance of rain 90%. 05:50 fridolin hi there 06:09 calire morning #koha 06:12 m23 morning claire 06:14 calire o/ 06:16 dcook I don't often upgrade databases, but when I do... 06:16 dcook hey calire \o 06:17 dcook The update for 3.14.02.001 and 3.15.00.006 are the same.. 06:17 dcook So if you're upgrading 3.14.02.001... you're going to get an error :S 06:17 dcook Well a warning at least I guess 06:17 dcook Safe to ignore I suppose.. 06:19 calire hey dcook 06:19 dcook How's it going? 06:20 dcook Need to fix one permission issue and then this database should upgrade.. 06:20 magnuse \o/ 06:20 dcook heya magnuse 06:21 magnuse howdy dcook 06:21 dcook oh wait not permissions... foreign issue. Yuck.. 06:23 calire dcook, good thanks ... monday 06:23 calire hi magnuse 06:23 dcook calire: I hear that 06:23 * dcook is counting down the minutes until the end of the day 06:23 calire I could do that but it's be a long count ^^ 06:23 dcook Well cursing relational databases and counting 06:24 dcook heh no kiding 06:24 dcook kidding* 06:24 magnuse Guten Morgen calire 06:24 magnuse dcook: not too far to count, perhaps? 06:24 dcook Not at all 06:33 dcook Hurray. foreign key issue was due to the collation in update_database.pl not being up-to-date. Weee. 06:38 reiveune hello 06:46 alex_a bonjour 07:07 marcelr hi #koha 07:23 ashimema Mornin' #koha 07:24 marcelr o/ 07:24 calire hi marcelr, ashimema 07:25 marcelr hi calire 07:25 ashimema calire 😀 07:26 * ashimema feels like the pushed to master list is never ending at the moment.. must be a release coming up.. 08:01 ashimema anyone know if there's a general effort going on to work through this tree: https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=20654 08:02 marcelr bug 20654 08:02 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 enhancement, P5 - low, ---, oleonard, ASSIGNED , Omnibus: Update two-column templates to use Bootstrap grid 08:02 calire ashimema, when patches appear I try to sign off yes 08:02 calire was off last week though ;) 08:03 ashimema coolios calire 08:04 ashimema I don't really have any more room on my queue.. so I'm really glad someone is continueing to work through them :) 08:04 ashimema be nice to get the whole set in for 18.11 rather than having a half finished UI switch :) 08:05 * andreashm waves 08:18 calire ashimema, ok I'll try and get some more sign offs done 08:18 ashimema hehe 08:18 ashimema sorry.. that wasn't a complaint 08:18 calire ;) 08:18 calire no, they are on my to do list 08:18 ashimema I'll happily follow you along with QA's ;) 08:19 * ashimema wants to keep oleonard motivated 08:37 andreashm guten morgen liebe Kolleginnen und Kollegen 08:37 calire ;) 08:38 andreashm :P 08:59 paxed ha. loc.gov marc21 format page gives internal server error :D 09:10 marcelr bug 21336 is ready to go again 09:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove 09:13 magnuse calire++ ashimema++ 09:48 RudyW Hi ashimema and kidclamp, here my update regarding ldap 09:48 RudyW you were right, after adding <anonymous_bind>0</anonymous_bind> to the config file ldap with AD is now working fine 09:50 ashimema glad it worked RudyW 09:50 ashimema Joubu around per chance? 11:03 Arthur_ Hi everyone! 11:06 ashimema bug 21247 11:06 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21247 enhancement, P5 - low, ---, koha-bugs, NEW , Cannot add more than one emoji across the entire database as a tag 11:06 magnuse ...so choose wisely ;-) 11:06 ashimema am I being daft.. how does one 'add an emoji to a biblio in the OPAC' 11:06 magnuse as a tag? 11:07 ashimema what.. a MARC tag? 11:07 magnuse no tagging, folksonomy 11:07 magnuse s/no/no:/ 11:07 magnuse at least i think that is what is meant, havn't really looked at the bug 11:08 ashimema aha.. one has to enable that 11:10 Arthur_ Hi guys, anyone know what might be the issue when i'm creating the lxc package, I get following error: "Error creating container u1" 11:11 magnuse ashimema: looks like the default is on: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/sysprefs.sql;h=bc7af05dd84b9fe377e5db191763b7b8b92690f6;hb=HEAD#l558 11:11 ashimema ta magnuse 11:11 magnuse np 11:12 ashimema perhaps.. this was an upgraded system 11:12 ashimema all good.. i manged to replicate it on master 11:12 ashimema going through my 18.05.x search on bugzilla and setting to master it if applies there too 11:13 ashimema (and fixing the easy ones as I go along 😉 ) 11:18 Arthur_ as far as i can find Eclipse is the best IDE for koha 11:18 Arthur_ really can't create package for it :/ 11:18 * ashimema just uses vim 11:21 * paxed uses emacs 11:24 Arthur_ i'm fairly new in development, can anyone help me out with this? 11:28 * magnuse uses gedit 11:29 ashimema basically what we're all saying is that we use a text editor rather than an IDE 11:29 ashimema in my experience to date.. there isn't really an IDE that makes sense for perl development (though of course one can add lots of fancy plugins to bring your favourite IDE features into your prefered text editor) 11:30 ashimema what sort of development are you hoping to do on Koha? 11:30 ashimema might help us advice 11:30 Arthur_ the basic configuration, modifying something etc 11:35 ashimema personally.. I'd just start with a lightwieght editor.. atom or something if you're a more gui minded person 11:38 Arthur_ sweet thank you 11:38 Arthur_ another question 11:38 Arthur_ so i'm used to use oracle sql developer, and maybe TOAD. how can i see my TNS in order to access my newly created database? If i don't want to terminal for this 11:46 Arthur_ Right so i've got Atom. Now i need to access source files for koha 12:35 kidclamp Ere++ 12:38 ere Whee! 12:39 ere kidclamp: On a related note, would you be able to address the review comments in bug 18316 sometimes in the nearby future? 12:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 enhancement, P5 - low, ---, alex.arnaud, Signed Off , Add weighting/relevancy options to ElasticSearch 12:47 ashimema kidclamp 12:47 wahanui somebody said kidclamp was getting the queue as clean as possible before Kohacon 12:47 ashimema I just pushed a patch you might want to cherry-pick ;) 12:47 kidclamp holiday for us today, only slightly around 12:47 kidclamp bug number? 12:47 ashimema looks like a rebase error crept in somewhere 12:47 ashimema it's the very tip of my branch 12:48 ashimema a followup I wrote 12:48 ashimema Bug 21352: (qa followup) - correction to testplan 12:48 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352 enhancement, P5 - low, ---, kyle, Pushed to Stable , Allow plugins to add CSS and Javascript to Staff interface 12:48 * LeeJ waves 12:48 LeeJ hi #koha 12:48 ashimema it'll make Jenkins happy again on your branch ;) 12:49 ashimema that's assuming you've not already fixed it locally and just have't pushed up yet ;) 12:49 ashimema go enjoy your holidayt and ignore me though ;) 12:50 * ashimema likes to see a sea of green on the dashboard.koha-community.org 12:53 huginn News from kohagit: Bug 21352: (QA follow-up) - correction to testplan <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cc52094f208d78fd06d888975f4710de0886c7a7> 12:53 ashimema :D 12:54 kidclamp will try ere, unless alex_a_ is working on it? 12:54 kidclamp i'm off :-) 12:56 LeeJ even though for 99% of the country considers today a holiday, I work for a Catholic university so we're unfortunately business-as-usual today :) 13:01 ere kidclamp: Oh, right, have a nice holiday! 13:09 LeeJ @later tell kidclamp tomorrow or whenever...can you add a heading for the release notes Enhancements? There's one for New features but not for Enhancements that I've been able to find :) 13:09 huginn LeeJ: The operation succeeded. 13:15 tcohen bonjour 13:15 LeeJ #endmeeting 13:24 * ashimema wonders if it's just him being picky when it comes to bug 17311 13:24 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 normal, P5 - low, ---, mirko, Needs Signoff , koha-common service should be restarted on upgrade 13:37 magnuse ashimema: nah, the maintenance message is there for a reason :-) 13:37 magnuse if plack is stopped it just gives an error or something? 13:37 ashimema likely a 503 or other unformatted server error 13:38 ashimema I think 13:38 ashimema I might be getting it wrong.. I don't think we fall back to cgi errors if plack has gone away do we? 13:38 ashimema tcohen might know? 13:41 tcohen 503 13:41 ashimema so yeah.. I don't think I'm being too mean then :) 13:41 ashimema though I have no idea what the best alternative solution would be either :( 13:41 tcohen should we add a 'Maintenance mode' functionality and use it? 13:41 ashimema doing it all in the post inst perhaps 13:42 tcohen koha-maintenance $(koha-list --enabled) 13:42 ashimema huh.. there's already such functionality isn't there? 13:42 ashimema oh.. you mean at the package level somehow do you? 13:42 * ashimema needs more :tea: 13:57 tcohen ashimema: I mean for packages, so we call it from the pre/post install scripts 13:57 tcohen I would like drojf and magnuse to weight in 13:57 ashimema :) 14:06 tcohen and I mean koha-maintenance —enable|—disable $(koha-list --enabled) 14:11 ashimema is the almightly oleonard here? 14:12 ashimema usa too.. likely no holibobs 14:12 ere kidclamp: ..and, uh, sorry, I should have asked alex_a_ about bug 18316 but looked at the assignee of another bug or something 14:12 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 enhancement, P5 - low, ---, alex.arnaud, Signed Off , Add weighting/relevancy options to ElasticSearch 14:15 alex_a_ ere, ? 14:15 alex_a_ ask! 14:15 alex_a_ (hello :)) 14:17 ere alex_a_: Julian had some comments that need to be addressed, it seems. 14:17 ere alex_a_: Hi! :) 14:18 alex_a_ ere, yes i saw that 14:18 ere alex_a_: So what I was supposed to ask it you'd have an estimate when you could check those out. It's just that it's functionality that we'd really like to have. :) 14:18 alex_a_ It's in my todo list 14:19 ere alex_a_: Ok, perfect. Just wanted to know that it hasn't slipped the radar. 14:19 alex_a_ ere, work on it this week 14:20 ere alex_a_++ 14:33 * ashimema wonders wether it's safe to dig into bug 20244 yet 14:33 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 enhancement, P5 - low, ---, ere.maijala, Signed Off , Elasticsearch - Indexing improvements 14:35 * ashimema realises he just confused bug 20244 with bug 19893 14:35 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 enhancement, P5 - low, ---, glasklas, Failed QA , Alternative optimized indexing for Elasticsearch 14:39 corilynn usa isn't totally on 'holibobs' :) learned a new word... 14:40 ashimema lol 14:40 ashimema very british colquealism there corilynn 14:41 corilynn yeah, i looked it up on urban dict :) Anyway, my hubs and I have to work, but our kid is off school. it's a randomly given holiday 14:42 corilynn so, I'm looking at bug 19263 14:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 enhancement, P5 - low, ---, nick, Failed QA , Advanced Editor - Rancor - Add auto control number (001) widget 14:43 corilynn the first line in the "failed QA" message is "Please add the new authorised value category to the default list and add a database update." can someone point me to a fixed bug that does that so I can poke around? 14:57 ashimema brb.. then I'll try to dig such a bug out for you 15:01 corilynn ashimema, I found bug 13379 ... I think what I need to do is update installer/data/mysql/atomicupdate/bug_XXXXX.perl where XXXXX is my bug 15:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 major, P5 - low, ---, jonathan.druart, CLOSED FIXED, authorised_values.category is varchar(16) 15:02 ashimema er.. sort of 15:02 corilynn ok, i'll await your details 15:04 ashimema trying to find a sort of sensible one is the challenge ;) 15:04 corilynn i can imagine 15:05 ashimema bug 5670 adds one.. but it's in the middle of adding a load of other stuff ;) 15:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 new feature, P5 - low, ---, alex.sassmannshausen, RESOLVED FIXED, Housebound Readers Module 15:05 ashimema bug 9468 also does it 15:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 enhancement, P5 - low, ---, kyle, CLOSED FIXED, Add ability to hide itemtypes from purchase suggestions forms 15:06 ashimema looks like new auth values haven't been added for ages! 15:08 corilynn I think I get it... I'm sure someone will steer me if I flub it 15:08 ashimema https://wiki.koha-community.org/wiki/Database_updates - should help in terms of how to code it 15:08 ashimema i.e using the modern 'atomic updates' workflow 15:08 ashimema and is similar to the bug you found first as an example 15:08 ashimema the two I linked to give more of an idea of how the db update sql itself might look 15:08 ashimema hope that helps 15:09 corilynn yes, immensely 15:10 reiveune bye 15:25 CrispyBran Bug 21503 15:25 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 enhancement, P5 - low, ---, cbrannon, Needs Signoff , Update AuthorisedValues.pm to fall back to code if description doesn't exist 15:26 * CrispyBran waves 15:26 CrispyBran Welcome feedback on bug 17854 15:27 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 enhancement, P5 - low, ---, cbrannon, Signed Off , Print Slip and Close button 15:28 ashimema that's a ternary and a half there CrispyBran 15:31 ashimema I bet you don't happen to have a copy of PBP available to you do you? 15:31 ashimema page 31 gives a reasonable hint on how to format that a little more nicely 15:32 ashimema https://books.google.co.uk/books?id=gJf9tI2mytIC&pg=PT53&lpg=PT53&dq=Format+cascaded+ternary+operators+in+columns&source=bl&ots=Hn0jfIszeq&sig=W8yxxWs2fOCn5ZTjzm8Lw5Ype08&hl=en&sa=X&ved=2ahUKEwjOw9SVlffdAhVmC8AKHbJ7A70Q6AEwC3oECAUQAQ#v=onepage&q=Format%20cascaded%20ternary%20operators%20in%20columns&f=false 15:42 tcohen ashimema: it seems koha-disable does the 'under maintenance' trick 15:43 ashimema cool 15:43 tcohen the only problem is you might have some instances disables 15:43 tcohen disabled on purpose 15:43 tcohen and you don't want them enabled 15:43 tcohen in postinst 15:43 tcohen so we need a way to filter them out 15:46 * ashimema continues on his mission to get the SO queue down to below 70 before clocking off.. 15:47 ashimema need a couple of trivial ones.. not got long to go 16:30 corilynn bug 19263 ... not 100% sure I did that right, but i'm willing to listen to feedback 16:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 enhancement, P5 - low, ---, carnold, ASSIGNED , Advanced Editor - Rancor - Add auto control number (001) widget 17:10 ashimema @later tell ere is bug 19365 effectively blocked by bug 19893 at the moment.. just trying to understand the flow for so/qa ;) 17:10 huginn ashimema: The operation succeeded. 17:52 CrispyBran @later tell Joubu When you get a chance, please look at bug 21503 and sign off if you think it looks good. Thank you! 17:52 huginn CrispyBran: The operation succeeded. 18:04 tcohen CrispyBran: why does it say '17.05' instead of master? 18:04 ashimema CrispyBran did you see my comments regards that bug earlier.. just some hints on better formatting 18:06 CrispyBran tcohen: no clue. Just set it to master now. 18:06 tcohen excellent 18:06 wahanui darn tootin' it is. 18:08 CrispyBran ashimema: simply expanded on Joubu's work. Seems everyone has a preference about it and I can't satisfy everyone. 18:08 tcohen CrispyBran: I think you should start on a clean master branch, and try to write a test for the new behaviour, in t/db_dependent/Template/Plugin/AuthorisedValues.t 18:08 tcohen I can help 18:12 CrispyBran tcohen: Do you mean include test plan for old behaviour before patch? 18:13 tcohen ideally there should exist unit tests for the current behaviour, so you just go and tweak the tests so they 'expect' the new behaviour, then change the code (as you did) and check the tests now pass 18:14 tcohen but there aren't tests for GetDescriptionByKohaField 18:14 tcohen I will write the tests for the current behaviour 18:14 tcohen and you change them, ok? 18:14 CrispyBran Thanks. I have no idea what any of that means. It has never been explained. 18:14 tcohen ok 18:14 tcohen this is called test-driven develo,pment 18:15 tcohen so 18:15 tcohen before writing the actual 'code change' 18:15 tcohen you write some 'test' (you code it) that checks (as a blackbox) if the method behaviour is the one you want 18:15 tcohen for example 18:16 tcohen calling the GetDescriptionByKohaField method with some parameters 18:16 tcohen as, for example, an authorized value that doesn't have a description 18:17 tcohen and expect it to return the same value you passed instead of the empty string 18:18 tcohen is(Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField('non_existent_thing'), 'non_existent_thing', 'If the required authorised value has no description, the same value is returned'); 18:18 tcohen ^^^ that'd be a test 18:20 tcohen CrispyBran: does it make sense? 18:20 CrispyBran Yeah, I guess this is something new I need to learn. Someone is going to have to walk me through that process or point me to documentation on it. Where do these tests live and how are they implimented? 18:20 tcohen you're familiar with kohadevbox of course 18:20 tcohen if you go into kshell 18:21 tcohen you can try running some test 18:21 tcohen prove t/db_dependent/Koha/Patrons.t 18:21 tcohen so, inside the t/ dir, there are the tests 18:21 tcohen what I thought is I could write the tests for the current behaviour 18:22 tcohen attach it to the bug 18:22 tcohen so master + the tests patch will pass 18:22 tcohen i.e. running the tests will return 'green' 18:22 tcohen then you apply your patch, you will notice they fail 18:22 tcohen ('red') 18:23 tcohen you then go tweak the tests to match the new behaviour with my aid 18:31 CrispyBran tcohen: forgive my ignorance. How do I get in a kshell? 18:31 CrispyBran Need to add this to my notes. 18:32 CrispyBran Wait 18:33 CrispyBran I think I have it. 18:39 tcohen from the vagrant user 18:39 tcohen you usually run 18:39 tcohen sudo koha-shell kohadev 18:39 tcohen or just use the handy alias: kshell 18:40 CrispyBran tcohen: looking at the test. Interesting. I have no clue how to begin writing tests. 18:41 CrispyBran need to see some documentation or tutorials 18:50 tcohen CrispyBran: this one is specially difficult, not the best to start with 18:55 Joubu tcohen: I disagree :) It seems to be pretty easy 18:56 Joubu At least a good candidate to understand why tests are useful, and how we should cover all the different cases 18:56 corilynn Joubu! when you have a minute... 18:56 Joubu I just had a quick look, maybe I missed something 18:56 Joubu I have 2! 18:57 corilynn oh excellent! I just fixed a bug 19263 I'd love to know all the ways I flubbed it 18:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 enhancement, P5 - low, ---, carnold, Needs Signoff , Advanced Editor - Rancor - Add auto control number (001) widget 18:57 corilynn starting with the paperwork :) I tested it on sandbox 14 19:00 Joubu corilynn: ok, I will give you feedback in a comment on the bug report 19:00 corilynn kewl-e-o, Joubu 19:03 Joubu corilynn: did you take into account the second point of comment 4? 19:04 corilynn yes, sorta... 19:04 corilynn if you don't have a 001 field the widget doesn't show 19:05 corilynn if you DO have a 001 field, the widget will show (like 008 etc does) 19:05 corilynn oh, i'm re-reading the comment and I think I get it more now 19:05 Joubu ok, I was just looking at your patch (the second one) and just saw changes to 2 files 19:06 tcohen Joubu: I think it is a good example, yes. But 19:06 corilynn Katrin is saying that you should check to see if there are entries in authorised_values and if not then don't show the widget? 19:06 tcohen GetDescriptionByKohaField requires existing mappings on the frameworks 19:06 tcohen so the tests are easy but preparing the ground isn't 19:06 Joubu corilynn: that's what I understand, yes 19:06 corilynn Joubu, my patch fixed 1 and 3 in Katrin's comments 19:07 tcohen that's why I was proposing to write the basis so CrispyBran writes his tests 19:07 * ashimema often finds the preparing the grounds step the hardest part when writing tests for koha 19:07 Joubu tcohen: yep but we have tests doing that already, so CrispyBran will have to find a mimick them ;) 19:07 corilynn Joubu, fail it then, I'll see if I can fix it 19:07 Joubu ashimema: we have TestBuilder to help us ;) 19:08 ashimema Indeed.. it's easier than it used to be 19:08 CrispyBran I am so lost now. 19:08 tcohen CrispyBran: don't listen to Joubu and you'll be fine 19:08 Joubu that's expected if you are starting with tests :D 19:08 ashimema Hehe 19:09 Joubu lol 19:09 corilynn thx muchly Joubu! 19:09 Joubu you are welcome 19:09 corilynn although, I thought I did start my commit message with Bug 19263 19:09 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 enhancement, P5 - low, ---, carnold, Failed QA , Advanced Editor - Rancor - Add auto control number (001) widget 19:11 Joubu corilynn: "Bug 19263: " 19:11 corilynn ah, missing colon 19:11 corilynn sooooo close... 19:11 Joubu corilynn: did you run the QA tests? They should have caught that 19:12 corilynn Yeah, but I didn't "get" it 19:12 corilynn I'm like... it's there! 19:14 Joubu corilynn: do you have a suggestion to make it more explicit? 19:14 corilynn I'll think on it 19:15 corilynn It's all just getting used to stuff. I haven't been a developer in 5 years, and I've only used git cursorily 19:28 * cbrannon[A] is now away - Reason : With a patron 19:31 * CrispyBran is no longer away : Gone for 3 minutes 39 seconds 19:46 rangi morning 19:54 * CrispyBran has a brain that is melting trying to understand tests 20:05 * cbrannon[A] is now away - Reason : Lunch 20:06 wizzyrea hi 20:37 corilynn Joubu... you still there? 20:38 corilynn anyone... what do I do if the koha-qa.pl says fail? 20:38 wizzyrea well, you can run koha-qa with verbose 20:38 wizzyrea and it will tell you more about the failures 20:38 corilynn oh 20:39 wizzyrea and then you fix them :) 20:54 corilynn wizzyrea, thx! they were easy fixes :) 20:54 wizzyrea \o/ awesome 20:57 corilynn wizzyrea, when I do a git bz attach -e <num> HEAD it's not automagically changing the bug to "Needs Signoff", what am I flubbing? 21:15 * CrispyBran is no longer away : Gone for 1 hour 10 minutes 4 seconds 21:16 * CrispyBran waves 21:17 * corilynn does the one-woman stadium wave 21:24 CrispyBran corilynn: you need to remove the hash (#) in front of that status when you edit (-e). 21:32 * corilynn smacks head 21:32 corilynn thx CrispyBran