Time Nick Message 05:35 marcelr hi #koha 05:49 cait good morning #koha 05:49 cait hi marcelr! 05:49 cait still catching up from KohaCon here... hope to be back to QA next week 05:50 cait @later tell magnuse - could you please test 14716? it's the normarc patch for the XSLT 05:50 huginn` cait: The operation succeeded. 05:59 marcelr hi cait 05:59 josef_moravec hi cait 05:59 josef_moravec hi marcelr 06:00 marcelr o/ 06:00 cait ih josef_moravec :) 06:07 magnuse cait: it's in my inbox, waiting for me to find some time 06:32 reiveune hello 06:32 wahanui what's up, reiveune 06:36 alex_a bonjour 06:36 wahanui kia ora, alex_a 06:49 * ere waves 06:56 ere hi cait, you recovered already? 07:04 calire morning #koha 07:12 ere hi cait, you recovered already? 07:15 fridolin hi there 07:15 wahanui hi, fridolin 07:15 fridolin salut wahanui 07:16 ashimema mornin' #koha 07:23 cait ere: much better today than yesterday 07:24 cait i managed to stay awake to my usual bedtime and sleep until the alarm went off 07:24 cait how are you doing? settled into your timezone yet? 07:25 ere cait: Same here. Still a bit hazy, but at least I managed to sleep over 6 hours last night. The first night home was easy since I didn't sleep on the flights, but the second was really bad. 07:27 cait maybe sleeping on the plane was my mistake then :) 07:27 cait but yeah, second day was the worst 07:30 ere cait: Not sure, I suppose a couple of hours would have been fine. When I had been awake for 28 hours or so, I started to fall asleep while sitting and watching tv.. 07:30 ere or fell asleep and woke up like a million times 07:32 cait yeah the waking up is the bad part 07:43 ere cait: And now there's a bit of work to do to catch up with everything :) 07:47 cait yeah... i still have about 900 bug mails to read 07:48 ere cait: Uh.. I'll just shut up and read my 150 messages 07:48 cait heh :) 09:02 magnuse hm, pootle wont let me translate this: 09:02 magnuse enhanced_content.pref#LibraryThingForLibrariesEnabled# <a href="https://www.librarything.com/forlibraries/">sign up</a>, then enter in your ID below. 09:02 magnuse it complains about xml-elements and URLs 09:03 magnuse but "<a href="http://www.librarything.com/forlibraries/">meld deg inn</a>, og legg deretter inn ID-en din nedenfor." should be fine. why is pootle complaining? 09:09 cait you can check ignore if you want 09:09 cait do you have the pootle link? 09:09 cait it doesn't like html in general i think 09:11 marcelr @tell khall plz have a look at bug 10382 09:11 huginn` marcelr: The operation succeeded. 09:12 magnuse cait http://translate.koha-community.org/nb/18.05/translate/nb-NO-pref.po#filter=checks&category=critical 09:13 magnuse ah, can't see an ignore option 09:31 cait you can click on the critical error i thnk 09:31 cait ah on the sign next to it 09:31 cait the stop sign 09:31 cait then ti won't show up any longer 09:38 magnuse cait: i can't see a stop sign? 09:39 magnuse maybe i don't have all the permissions? 09:42 * magnuse needs food 09:50 cait do you see the Critical errors: XML-Tags? 09:50 cait it shows right next to that for me 09:50 cait small icon 09:50 cait let me know if you want me to uncheck it 11:17 magnuse cait: i can't see it - super awesome if you uncheck! 11:22 cait magnuse: done, should not bother you now 11:23 magnuse cait++ 11:23 magnuse thanks! 11:25 cait http://translate.koha-community.org/help/quality-checks/#xmltags for the help 11:26 cait it does some counting, i guess it could go wrong sometimes 11:33 * kidclamp waves 11:34 ashimema hola 11:34 wahanui que tal, ashimema 11:34 oleonard Hi all 11:35 ere hi 11:58 ashimema :'( 11:59 kidclamp why so sad? 11:59 * ashimema just ran head first into the stupidity of not just using dbic again! 12:00 ashimema `DBIx::Class::ResultSetColumn` is really useful guys.. ffs 12:15 Joubu hi #koha 12:15 Joubu /ignore ashimema 12:17 ashimema lol 12:18 kidclamp morning Joubu 12:23 oleonard cait: I find it hard to test accurately on my devbox but I thought self-registration emails were sent right away 12:23 oleonard (Bug 21390) 12:23 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 enhancement, P5 - low, ---, koha-bugs, NEW , Send self registration verification emails immediately 12:26 cait oleonard: hm the text in 16.11 mentions 15 minutes, was looking at that when filing 12:26 cait i didn't find a bug changing it 12:26 cait and they go via message queue 12:26 cait oleonard: i thought we only fixed the password ones 12:26 cait pretty sure actually :) 12:29 oleonard I guess I don't know the right configuration to test on a devbox 12:48 magnuse 15 minutes is the default frequency for the process_message_queue.pl script 13:11 kidclamp hey cait, around? 13:12 ashimema Was a few seconds ago 13:16 caroline_ hello! 13:17 magnuse ooh, preview for notices and slips! Very Nice! 13:20 Joubu lol 13:26 oleonard Hi caroline_ 13:33 cait kind of :) 13:50 huginn` News from kohagit: Bug 20743: Remove duplicated line 'See your public page' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d5063603f213d843d1848b44b6479ad5c1f2c63b> 13:50 huginn` News from kohagit: Bug 20819: (Follow-up) Show more clearly that a user gave no consent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8fa1bd72debea6e23020a93d5c30dd99d7ed1822> 13:55 caroline_ Joubu: was this what you were telling me, when I see huginn` say News from kohagit, it means that new patches were pushed to master? 13:56 kidclamp Yup, it means I am breaking all the things :-) 13:56 ashimema Joubu, I think bug 20144 (specifically commit 2e35da4f6b0e2c25ca1e6acb3e80f8b9d65cb658) leads to bug 21385.. any chance you could investigate at all? 13:56 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 normal, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Test suite is failing with new default SQL modes 13:56 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 normal, P5 - low, ---, koha-bugs, NEW , Vendor search: Item count is incorrectly updated on partial receive. 13:56 caroline_ hehe! Don't forget to generate to release notes too 13:57 ashimema I 'think' the group be means that we're loosing some aqorders lines from the join and thus the sum isn't correct 14:01 * ashimema goes back into his acquisitions hole 14:06 * oleonard imagines an acquisitions hole is the opposite of a hobbit hole 14:07 ashimema lol 14:23 ashimema ignore the above from my Joubu 14:23 ashimema wasn't you.. looks like it's the filter above.. been a bug for 5 years! 14:28 Joubu ashimema: pm changes without tests? :) 14:30 * ashimema is working on those now 14:31 ashimema acq code is such a minefield 14:58 reiveune bye 15:01 alex_a Bon week-end tout le monde et à lundi... à Marseille! 15:06 mtompset Greetings, #koha. 15:07 mtompset @seen cait 15:07 huginn` mtompset: cait was last seen in #koha 1 hour, 33 minutes, and 22 seconds ago: <cait> kind of :) 15:07 mtompset You're welcome, cait. :) 15:07 oleonard Hi mtompset, irma_ 15:07 cait i am here :) 15:07 mtompset Greetings, oleonard 15:07 cait kind of 15:07 mtompset Just replying to your thanks for the bug rescue. :) 15:08 mtompset irma, irma_, irma__... are you going for a pattern? :) 15:08 mtompset Someone's networking is probably wonky. :) 15:08 mtompset Greetings, oleonard. 15:08 mtompset Did you have a chance to get back to the bug? 15:10 oleonard Me? Which bug? 15:10 mtompset nevermind... you did. bug 13272. :) 15:10 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 trivial, P5 - low, ---, oleonard, Signed Off , Many inputs lack a type attribute 15:11 mtompset oleonard++ # thanks getting back to it. :) 15:11 ashimema anyone here any good at aggregate functions in sql? 15:12 mtompset I'm bad at it, but ask anyways? :) 15:13 mtompset Can't learn unless you mess around more, right? :) 15:14 mtompset ashimema, what are you trying to do? :) 15:14 ashimema right.. I've traced bug 21385 back to a filter added way back 5 years ago in https://gitlab.com/mrenvoize/Koha/commit/529434cab891a8b76b3792e12e359f8c8b171519#9e895a5fea0fdbd273a4102d90d5df3311dd5e5c_602_600 15:14 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 major, P2, ---, martin.renvoize, Needs Signoff , Vendor search: Item count is incorrectly updated on partial receive. 15:15 mtompset speak of the devil! 15:15 mtompset I was just about to look at that bug. :) 15:15 ashimema ? 15:15 ashimema my fix on the bug is bad.. just about to set it back to NEW 15:15 mtompset I am about to test and sign off bug 21385. :) 15:15 mtompset Oh... 15:16 ashimema at least I 'think' my fix is bad.. 15:16 ashimema I think what really needs to change to achieve whats intended is 15:16 ashimema from 15:16 ashimema AND (closedate IS NULL OR (aqorders.quantity > aqorders.quantityreceived AND datecancellationprinted IS NULL)) 15:16 ashimema vs 15:16 ashimema AND (closedate IS NULL OR (SUM(aqorders.quantity) > SUM(aqorders.quantityreceived) AND datecancellationprinted IS NULL)) 15:17 ashimema but you can't use a 'SUM' in the where clause there 15:17 ashimema hense the aggregate function question 15:17 mtompset but you can nest selects 15:17 ashimema does that make sense 15:18 mtompset how many aqorders lines are there per biblio? per item? 15:18 mtompset if there are multiple, then I see why you want to do the sum. 15:18 ashimema multiple ;) 15:19 cait sorry have to run, bbiab 15:19 ashimema so.. the bug is in partial recieve 15:20 mtompset just took a look at the schema. 15:20 ashimema we split the order when that happens and set one orderline to received = expected and the other to recieved = 0, expected = the difference. 15:20 ashimema the filter drops out the 'recieved == expected' rows 15:20 ashimema which we still want in the join to make up the sum 15:20 mtompset right, because we actually want to sum the acorders on biblionumber, don't we? 15:21 ashimema err 15:21 mtompset sorry if I'm wrong... caffeine hasn't hit yet. :) 15:21 ashimema no.. the aqorders by basketnumber 15:22 ashimema no worries.. it took me a good few hours for the penny to drop on this one ;) 15:23 ashimema think about it as if that filter clause turns a LEFT JOIN into an INNNER JOIN 15:23 mtompset right... I was thinking baskets might be involved... Okay, so your test case of one biblio with one item, and another biblio with two items... means one aqbasket with two aqorders? 15:24 ashimema correct 15:24 ashimema one aqbasket, with two aqorders and three items 15:24 mtompset and ... three aqorder_items, with two distinct order numbers. 15:25 ashimema when you partially recieve you end up with an aqbasket with three aqorders each with one aqorder_item attached 15:25 ashimema make sense? 15:26 mtompset ugly transformation, but yes... 15:26 ashimema it is indeed ugly 15:27 mtompset okay... and so ... let's look at the code again.... we are trying to count... 15:30 mtompset oooo.... the total_items is wrong, because the closedate is set for the partial received items. 15:30 ashimema er... 15:31 ashimema is it 15:31 ashimema I hadn't spotted that if it is.. 15:31 ashimema I thought 'closedate' was when the basket was closed rather than when items where recieved 15:31 mtompset oh... let me re-read... you might be right. 15:31 ashimema hehe 15:31 ashimema it's a proper monster of a query 15:32 mtompset Yes, yes it is. 15:32 ashimema I'm currently working along the lines of trying to get rid of the join and turn the bits that require it into subqueries.. but that's actually turning it into even more of a monster 15:35 mtompset hmmm... that allbaskets part... 15:36 mtompset what if it were a AND (aqbaskets.basketno IN (SELECT ...)) 15:36 mtompset yes, more of a nested monster. 15:37 mtompset SELECT DISTINCT(basketno) FROM aqorders_items WHERE ... 15:38 mtompset nevermind... I might be wrong... 15:38 mtompset Hmmm.... 15:39 mtompset How many times does this function get called in a page load? 15:40 mtompset Why not break the totals to separate queries, and do an ugly map thing like the cancelled one? 15:45 * Joubu wonders why ashimema is still dealing with acq whereas he is officially in week-end and could be drinking beers 15:47 ashimema back 15:47 ashimema sorry.. had a support call come in. 15:47 * ashimema has 10 mins more before official weekend time ;) 15:47 bag hehe I think ashimema was really going to get a beer as Joubu suggests 15:48 ashimema that's not a bad idea at all mtompset 15:48 ashimema that would make it significantly simpler 15:49 mtompset and it would make debugging the SQL in the future easier too. :) 15:49 mtompset and with everything indexed, it shouldn't be a horrible slow down. 15:49 ashimema thanks 15:49 ashimema I'll go have a try at that I think 15:50 mtompset -- next week? :) 15:50 ashimema yeah.. I reckon to.. 15:50 ashimema that beer is calling 15:50 mtompset Drink responsibly. :) 15:50 ashimema it's a weekend earnt whenever you've spent a few hours in acq ;) 15:51 bag hahaha true 15:51 * mtompset laughs. 15:51 mtompset No... C4/Search. :P 15:51 ashimema hehe.. deffo weekend earnt if you've delved into Search.pm 16:00 mtompset Personally, I think currency needs some reworking. But my brain fries too quick looking at people mixing up the use of the fields. 16:03 ashimema currency is an area I've avoided so far 16:03 ashimema but have a nasty feeling I'll need to dig into 16:03 * ashimema wonders if this code will get clearer with a few beers in his belly 16:04 oleonard Ha 16:09 mtompset https://xkcd.com/323/ 16:09 mtompset ashimema, ^^ :) 16:11 * ashimema giggles 16:26 Joubu kidclamp: bug 21393 \o/ 16:26 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Make template filter checks code reusable 16:32 kidclamp Joubu++ 16:38 * mtompset was looking at the bug. Nice modularization. :) 16:38 mtompset Like the line numbers too... makes it easier to find. :) 16:39 cait hello again #koha 16:39 mtompset Greetings, cait Joubu kidclamp 16:45 mtompset Joubu, the xt test fails with and without the patch. 16:46 mtompset Are there bugs which fix them? 16:51 kidclamp mtompset: find_missing_filters? it passes for me 16:51 Joubu mtompset: Jenkins tells you are wrong 16:51 Joubu I guess you have a local file that makes it fail 16:56 mtompset koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt -- hmmmm... let me hard reset 17:01 Joubu hard reset will not remove untracked files, you need "clean" 17:03 mtompset What's that option again? 17:03 bag I perfer git shower 17:04 bag hardy har har 17:05 Joubu mtompset: man git clean, I prefer you find it instead of giving you something that may remove files you do not want to remove :) 17:07 * kidclamp has a very dirty git - I hold on to all sorts of stuff - mostly because kohaclone is synced in the kohadevbox, so easy way to move things locally :-) 17:09 oleonard You're a dirty git boy 17:13 oleonard Happy weekend everyone, I'm outta here 17:14 Joubu kidclamp: I do the same, but with a directory that is git ignored. `git status` does not show them :) 17:15 kidclamp yeah, I had that once, but then I destroy my box and forget to redo it 17:20 Joubu kidclamp: it's outside the box :) 17:21 kidclamp hmm..then I lied :-) or was on another machine 17:22 kidclamp I got used to seeing them, those files are my friends (though not my friends when I accidentally add them all) 17:23 Joubu @later tell fridolin a big baby like you still forget to assign bug report to himself? ;) 17:23 huginn` Joubu: The operation succeeded. 17:24 Joubu they were my friends too, until I lost data :) 17:24 Joubu (well, not really lost, but lost time to recover them) 17:26 Joubu davidnind[m]: https://twitter.com/kohails - this logo is quite... ugly, could we change it? 17:30 Joubu @later tell rangi you should have told us how to pronounce whakawhanuangatanga! 17:30 huginn` Joubu: The operation succeeded. 17:33 mtompset Joubu, do we know where the syllable breaks are? Is wh a blend? Is ng a blend? 17:35 mtompset Joubu, I've frequently destroyed and up'd. Nothing I can't lose on them. :) 17:36 Joubu is not it a single syllable? ;) 17:37 * mtompset grins. 17:37 Joubu mtompset: to remove all untracked files, options of git clean are -f -d (hey! force and directory!) 17:37 Joubu git ignored files will not be removed ofc 17:39 mtompset kohadevbox died on my git gc --aggressive attempt. 17:39 mtompset Well, the command, not the whole box. 17:39 mtompset Guess 2GB isn't enough memory. :) 17:40 Joubu last time I did it it was a quite heavy process (cpu+ram), yes 17:40 tcohen mtompset: please say virtualbox died, sounds better 17:43 tcohen poor kohadevbox 17:43 mtompset Nah... the command I typed died painfully on the kohadevbox. 17:43 mtompset So, I'm running it on the host, rather than the devbox. 17:44 tcohen the git repo is mounted over NFS or VBOXFS, either are realaly slow and problematic with git IMHO 17:44 mtompset When there are almost a half million objects to compress... it's obvious why 2GB isn't enough memory. :) 17:44 mtompset probably, tcohen 17:48 Joubu mtompset: I never use git commands inside the devbox, toooo slow 17:49 mtompset Tell me about it. :) 17:49 mtompset Still... slow outside too, but faster than in that's for sure. :) 17:53 tcohen replace your hardware 17:53 tcohen or define slow 17:56 Joubu I guess it's slow but expected given the size of the repo 17:58 Joubu please, bug 20177! 17:58 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Remove GROUP BY clause in GetCourses 17:58 Joubu it blocks bug 20521 17:58 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 enhancement, P5 - low, ---, jonathan.druart, BLOCKED , dev installations should run with problematic SQL modes 17:58 Joubu (should have been part of 18.05 already) 17:59 tcohen I was waiting so I can QA 18:03 mtompset tcohen, I'm still waiting for git gc --aggressive to finish. 18:03 tcohen Ctrl+c 18:03 tcohen ? 18:03 tcohen why would you want t odo it anyway? 18:04 mtompset I started it before the -f -d version. 18:04 tcohen I don't think I ever ran that 18:05 mtompset when I hop back and forth between versions, I think somethings may have stayed behind. 18:06 tcohen no, git would tell you 18:06 mtompset Remember that git fetch issue on the koha-conf the other day? 18:06 mtompset probably same kind of issue. 18:07 tcohen doesn't gc only colluect dangling objects? 18:07 mtompset probably.... 18:07 wahanui probably is too hard. 18:07 * mtompset shrugs. 18:07 tcohen I think 'clean' is the one that deals with the snapshot that's on your filesystem 18:07 tcohen as Joubu said 18:07 mtompset I have a lot, I'm sure. 18:08 tcohen anyway 18:08 mtompset Right... going to finish the gc, then clean. 18:08 tcohen I doesn't hurt to clean the git repo 18:40 mtompset And 3K more objects to compress.... 18:40 mtompset Like I said, slow. :) 18:42 mtompset ARG! Rain. 18:43 mtompset @wunder orangeville 18:43 huginn` mtompset: Orangeville, Ontario :: Mostly Cloudy :: 84F/29C | Heat Index: 86F/30C | Friday: Windy with scattered thunderstorms. Storms could contain damaging winds. High near 85F. Winds WSW at 20 to 30 mph. Chance of rain 50%. Friday Night: Partly cloudy and windy this evening then becoming cloudy after midnight. Much cooler. Low 42F. Winds NW at 20 to 30 mph. 18:43 mtompset @wunder newmarket 18:43 huginn` mtompset: Newmarket, Ontario :: Scattered Clouds :: 88F/31C | Heat Index: 90F/32C | Friday: Windy with showers and thunderstorms likely. Storms may contain strong gusty winds. High 89F. Winds WSW at 20 to 30 mph. Chance of rain 80%. Friday Night: Partly cloudy this evening with more clouds for overnight. Cooler. Low near 45F. Winds NW at 15 to 25 mph. 18:43 mtompset @wunder brampton 18:43 huginn` mtompset: Brampton, Ontario :: Scattered Clouds :: 75F/24C | Friday: Windy with scattered thunderstorms. Storms could contain damaging winds. High 88F. Winds WSW at 20 to 30 mph. Chance of rain 50%. Friday Night: Partly cloudy and windy this evening then becoming cloudy after midnight. Much cooler. Low 48F. Winds NW at 20 to 30 mph. 18:51 tcohen @wunder cordoba, argentina 18:51 huginn` tcohen: Cordoba, Argentina :: Clear :: 64F/18C | Friday: Windy with a few clouds. Lows overnight in the upper 60s. Friday Night: Mostly clear and windy. Low 67F. Winds N at 20 to 30 mph. 18:53 tcohen I'm sure it is 35º outside 18:54 mtompset Probably humidex makes it feel that way. 19:10 Joubu @wunder Buenos Aires, Argentina 19:10 huginn` Joubu: Buenos Aires, Argentina :: Overcast :: 64F/18C | Friday: Mostly clear. Lows overnight in the mid 60s. Friday Night: A few passing clouds. Low around 65F. Winds NNE at 10 to 15 mph. 19:10 Joubu same here :) 19:11 cait @wunder Konstanz 19:11 huginn` cait: Error: Failed to load Wunderground API. Check the logs for more information. 19:11 bag @wunder pdx 19:11 huginn` bag: Portland International, OR :: Mostly Cloudy :: 64F/18C | Friday: Mainly cloudy. A few peeks of sunshine possible. Slight chance of a rain shower. High 78F. Winds SW at 5 to 10 mph. Friday Night: Overcast with rain showers at times. Low 59F. Winds SSW at 10 to 15 mph. Chance of rain 40%. 19:11 tcohen I think the high temperatures melted some fiber connecting the weather center 19:12 cait what? 19:12 cait @wunder Konstanz 19:12 huginn` cait: Konstanz, Germany :: Rain :: 62F/17C | Wind Chill: 61F/16C | Friday: Light rain early. Lows overnight in the low 50s. Friday Night: Becoming partly cloudy after some evening light rain. Low around 50F. Winds W at 10 to 15 mph. Chance of rain 80%. 19:12 tcohen how can we all have the same temperature? 19:12 tcohen ah 19:12 cait :) 19:13 mtompset eventually, the planet will reach a dynamic equillibrium with no major variations, and we all die. CLIMATE CHANGE! ;) 19:14 mtompset finally finished a gc and clean! :) 19:15 Joubu mtompset: you are the one who warmed everything up with you gc! 19:15 Joubu your* 19:15 * mtompset laughs. 19:15 mtompset Not with the cold crossbreeze penetrating the bay window. :P 19:17 mtompset ARG! bug 20177 branch was out of date. 19:17 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Remove GROUP BY clause in GetCourses 19:17 mtompset SO SLOW! 19:19 Joubu mtompset: the patch applied ok for me 19:23 mtompset no... I did a checkout weeks ago, and it hadn't rebased against master lately. 19:23 mtompset 2000+ updates. 19:24 mtompset I should have just deleted the branch. *sigh* 19:24 tuxayo hi cait , do you have some time for: «The return of decimal separators issues!!!!» âš¡âš¡âš¡ 19:24 tuxayo (well they never left actually) 19:24 tuxayo Thanks to kidclamp and paul (and maybe others!) during the hackfest, we might be able to agree on simpler specs and have something that can pass QA :D 19:24 tcohen mtompset: try git gc —aggressive 19:24 tcohen :-P 19:25 * mtompset gives tcohen the evil eye. 19:25 mtompset That was 30-45 minutes of pain. 19:26 Joubu nope, 2h 19:31 * cait hides 19:31 cait sorry tuxayo, I don't think i am up for it (jet lag) 19:33 tuxayo cait: no worries. Wait, should you sleep then? :P 19:33 cait not yet 19:34 mtompset Shoot... I need to leave. 19:34 mtompset Joubu, I just found this. 19:34 mtompset https://dev.mysql.com/doc/refman/8.0/en/group-by-handling.html 19:35 mtompset I think you don't need that group by, as your patch puts ALL the fields in. 19:35 mtompset https://dev.mysql.com/doc/refman/8.0/en/group-by-functions.html 19:36 mtompset And this page says, "If you use a group function in a statement containing no GROUP BY clause, it is equivalent to grouping on all rows. For more information, see Section 12.19.3, “MySQL Handling of GROUP BYâ€." 19:36 mtompset So, I'm not sure your group by is the best solution on bug 20177. 19:36 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Remove GROUP BY clause in GetCourses 19:36 mtompset Got to run. 19:37 Joubu maybe :) 19:49 tuxayo Does anyone know which are the settings needed for the email notification to be sent to the staff address? 19:49 tuxayo KohaAdminEmailAddress & emailLibrarianWhenHoldIsPlaced => checked but still no email 19:49 cait do other emails work? 19:49 cait is a branchemail set? 19:51 tcohen tuxayo: is postfix or exim configured correctly to send emails on behalf of the picked address? 19:51 cait what did you do to trigger the email? :) 19:53 cait Joubu: but is it really a regression? we use Price in a lot of places now 19:54 Joubu I do not have my brain ready for acquisition, prices question either :) 19:54 cait fair enough 19:54 Joubu juste noticing that you are doing more than just formatting 19:55 Joubu *could* lead to a regression, without that changes I would have PQAed it 19:55 tuxayo cait: emails to patrons are sent so I guess the cron is working + branchemail ok 19:55 Joubu will need more work to know if it will not have a side-effects 19:55 tuxayo tcohen: it works for other emails 19:56 cait not sure where to start there 19:56 cait might be a brain thing 20:00 * tuxayo start investigating brain 20:25 kidclamp have agood weekend all 20:26 caroline_ bye kidclamp! 20:26 caroline_ you too! 20:33 Joubu kidclamp: code is bad but exists, so I copied it.. really? :D 20:37 kidclamp Somehow I didn't think you'd let me get away with that 20:38 tuxayo hue hue hue 20:47 tuxayo About my problem: there is no process_message_queue.pl in the crontab... 20:47 tuxayo I wonder how hold-emails to patrons are sent. Maybe I misunderstood the customer. 21:01 mtompset tuxayo, did you doa koha-list --email? 21:01 mtompset (i.e. is email for koha enabled?) 21:03 tuxayo mtompset: at BibLibre we are not using the packaged version. Anyway, now I know that the fix is for a sysadmin ^^" 21:06 Joubu kidclamp: bug 21350 # First time developper from the KohaCon's hackest ;) 21:06 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21350 enhancement, P5 - low, ---, martinez.alberto, Passed QA , Add Font Awesome icon for pending onsite checkouts link 21:06 Joubu haskfest 22:20 bag @later tell kidclamp - from Joubu “kidclamp: bug 21350 # First time developper from the KohaCon's hackest ;) “ 22:20 huginn` bag: The operation succeeded. 22:21 bag @notes kidclamp 22:21 huginn` bag: Sent just now: <bag> - from Joubu “kidclamp: bug 21350 # First time developper from the KohaCon's hackest ;) “ 22:21 bag @later tell kidclamp - good candidate to push :) 22:21 huginn` bag: The operation succeeded. 22:42 fakhri Hi all.. 22:46 fakhri I just found about this project recently. I am interested but I need to know if Arabic is supported. 22:49 bag @later kidclamp MANA!!! 22:49 huginn` bag: downloading the Perl source 22:49 bag @later tell kidclamp MANA 22:49 huginn` bag: The operation succeeded. 22:50 caroline_ fakhri: yes, koha is translated in Arabic http://translate.koha-community.org/ar/18.05/ 22:52 caroline_ The manual is not entirely translated though https://koha-community.org/manual/18.05/ar/html/index.html 22:53 caroline_ You can help translating it here http://translate.koha-community.org/ar/man18.05/ 23:10 fakhri caroline_: Alright. Thanks for the answer.