Time Nick Message
06:17 * magnuse` waves
06:22 * ashimema wonders if magnuse might consider becoming a special interest qa'er for ILL. We have a singoff pipeline going with a couple of customers now.. would be great to line up QA
06:22 ashimema S/singoff/signoff
06:26 cait recruiting++ :)
06:26 cait bbiab :)
06:27 ashimema To quote caits QA manager proposal ( https://wiki.koha-community.org/wiki/Proposal_for_QAM_18.04_kfischer ): Recruit topic experts for long standing bugs for out-of-core-team QA
06:27 ashimema Hehe
06:48 winki How to set up SIP in koha?
07:01 ashimema https://koha-community.org/manual/18.05/en/html/apis_protocols.html?highlight=sip is a good start ;)
07:02 ashimema it's one of the better documented area's of koha
07:14 magnuse` wow, that is quite extensively documented!
07:17 ashimema cait++ # Starting to dig into 18639 for qa
07:20 ashimema really is good to have josef_moravec back.. always get a boost from seeing a bunch of signoffs :)
07:27 magnuse` bug 18639
07:27 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 enhancement, P5 - low, ---, nick, Signed Off , Separate replacement cost and retail price fields in acquisitions
07:28 magnuse` cait++ for all the things
09:10 cait magnuse`: got kicked out earlier.... but did you see my later about the norwegian library card bug?
09:14 magnuse check
09:16 magnuse saw the later now, and replied :-)
09:17 cait cool, thx for clarifying :)
09:18 cait the removers will be happy heh
09:19 magnuse yay
09:27 ashimema yay
09:27 * ashimema feels mean now for being a 'remover' ;)
09:27 ashimema i'm more of a 'generalizer' than a 'remover' I reckon ;)
09:27 * ashimema wants it replaced with more generic hooks rather than just removed outright really..
09:29 andreashm anyone experience issues with using the SlipPrinterJS Firefox add-on after upgrading til 17.11.06? (I know it doesn't work with Firefox Quantum, but we are currently using an older version of Firefox here)
09:39 cait it doesn't work
09:39 cait i think
09:39 cait ah, sorry. read too fast
09:39 cait we haven't been using it, so I don't know
09:40 andreashm ok
09:40 andreashm anyone else using it? or something else to print silently?
09:40 andreashm like biblibre or ptfs?
09:41 cait there is a bug report... i think for the newer versions it didn't sound like a solution was found yet
09:42 cait biblibre are using 17.11 so they might know something
09:42 cait jajm around?
09:44 andreashm tuxayo?
09:45 andreashm ashimema perhaps?
09:45 ashimema not volunteering me for more stuff are we
09:45 * ashimema reads back
09:46 ashimema erm
09:46 ashimema did i miss some context there?
09:46 ashimema what are you asking?
09:47 ashimema what are you asking andreashm
09:47 andreashm hehe
09:48 andreashm n
09:48 andreashm no
09:48 andreashm just wondering if you were using slipprinterjs for your customers
09:48 andreashm and if it worked on 17.11 for you?
09:48 andreashm (a lot if there)
09:48 andreashm if's
09:49 ashimema good question.. I have no idea but will defer up and ask the support/implimentation chaps
09:49 andreashm thanks!
09:50 ashimema wierd.. this http://irc.koha-community.org/koha/2018-08-17#i_2064666 line didn't appear at all in my irc client
09:50 ashimema no wonder I had no idea what you were talking about
09:51 andreashm strange
09:51 andreashm yeah, I can imagine your confusion. =)
09:51 * ashimema thinks maybe he does need to swtich away from matrix and riot.. :(..
10:06 tuxayo Oh me too didn't not understood (even with the text neither but still!)
10:06 tuxayo «didn't appear at all in my irc client»
10:07 tuxayo Me too, the riot bridge must have had an issue
10:09 ashimema seems we have no-one using it andreashm
10:33 tuxayo ashimema: Is it the first missing message you witness with the matrix-riot to IRC bridge?
10:34 ashimema to be honest.. I'm not sure I could tell.. it's rare to have been mentioned in something about a preceeding line
10:34 ashimema so I'm not sure I'd notice other missing lines much without really digging
10:34 tuxayo indeed
10:34 ashimema but it does make me wonder what I am missing perhaps
10:34 tuxayo me too
10:53 andreashm ashimema: thanks for checking
11:32 oleonard S'up.
11:38 kidclamp cait, I put some answers, hopefully you don't hate them :-)
11:39 kidclamp Yo oleonard
11:48 * andreashm got silent printing to work. got a tip from a colleague at gothenburg university.
11:48 andreashm the issue was bug 17014
11:48 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 enhancement, P5 - low, ---, oleonard, CLOSED FIXED, Remove more event attributes from patron templates
11:49 oleonard andreashm: A regression?
11:49 andreashm we just upgraded
11:51 andreashm just had to wrap the java code differently
11:58 andreashm oleonard: don't know what counts as a regression
12:04 cait kidclamp: fixed the test too? :
12:05 cait kidclamp: ah, was thinking about field weighting - not the cost one
12:06 cait not hathing them
12:10 kidclamp oh, my bad
12:46 cait kidclamp: who do i have to bug about the field weighting one? :)
12:54 kidclamp I will take aqlook, it is alex's bug, i assume he is on holiday
12:54 kidclamp taking off for the morning, back later
12:55 cait bye :)
12:56 * oleonard demands kidclamp's constant presence
12:56 kidclamp my spirit is always with you oleonard, you just need to look inside
12:57 oleonard Maybe the real mustache wax is the friends we made along the way
12:58 caroline Good morning!
13:01 oleonard Hi caroline
13:06 cait lol
13:53 Freddy_Enrique Good morning all
13:53 cait hi Freddy_Enrique
13:54 Freddy_Enrique :)
13:55 Freddy_Enrique hope you can help me with this one. I read and article that google chrome is going to block unsecure pages or rather pages with no https
13:55 Freddy_Enrique I not quite sure how to do this, one way I saw is... installing cerbot
13:56 Freddy_Enrique the other is using a flag or something...
13:57 Freddy_Enrique My instance is called biblioteca. So using this flag should be like this? : sudo koha-create letsencrypt biblioteca??
13:57 Freddy_Enrique sudo koha-create --letsencrypt biblioteca??
14:00 cait i think the automatism only works for new instances
14:00 cait not sure how to activate for existng, does someone around know more?
14:00 cait koha-create creates a new instance, so we are looking for a different command
14:00 cait unless this si a different server maybe?
14:00 GiuseppeP it works only for new instances, in order to active let's encrypt you have to use the classic way
14:01 Freddy_Enrique the classic way is.... cerbot? forgive me, I'm new in the topic
14:01 GiuseppeP yes
14:03 Freddy_Enrique Ok, thanks GiuseooeP :)
14:04 GiuseppeP I suggest you to use it in webroot mode, not standalone
14:05 GiuseppeP I dig in my history's log. There is what I used: letsencrypt --agree-tos --renew-by-default --webroot certonly -w /usr/share/koha/opac/htdocs/ -d domain.tld
14:06 GiuseppeP letsencrypt is a link to certbot
14:07 * Freddy_Enrique looking for Cerbot implementation manual for dummies
14:11 cait ashimema++
14:11 GiuseppeP to start I suggest you add the --staging argument to the above string, that way you will not wast a good certificate. (you can issue 20 certificates per week with production versione)
14:13 Joubu ashimema: heh... colision on bug 20312...
14:13 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 new feature, P5 - low, ---, maksim.sen, Passed QA , Add a link towards the last consulted patron
14:15 ashimema interesting.. you're screenshot looks different to what I saw
14:15 ashimema yu seem to have a nack for that though.. haha..
14:16 ashimema I'll take anoth pass.. i agree with your enhancement though.. but think they could be followups
14:16 * ashimema is aware the dev is leaving today ;)
14:17 caroline Thanks guys <3
14:17 cait the attached screenshot was a first version
14:17 cait it got changed in the processi think
14:17 cait a bi at least
14:17 Joubu there are 2 screenshots
14:17 ashimema is Pierre-Luc Lapointe still around.. can he take a bit of a look at Joubu's thoughts?
14:18 cait caroline:
14:18 caroline ashimema: yep, I'll tell him right now!
14:18 ashimema awesome.. I'm happy to do some of the followups on things that fall too far from the core development if he runs out of time..
14:19 ashimema nicer to get it in and provide some quick followups than to miss out on a new dev added to the contributors list in my opinion ;)
14:20 caroline ashimema: he asks if you expect him to do the changes Joubu asks?
14:21 caroline Apparently Joubu says to wait for other qa?
14:21 ashimema I was going to do a second run to see what the screens look like again
14:21 * caroline feels like the ham in a sandwich
14:21 ashimema joubu first comment.. show then hidden is a good catch.. if he could reverse that it would be good
14:22 ashimema adding the pref to do it.. that's a nice to have which I think we can do as a followup as I imagine it'll take him too long to get up to speed with that side of things?
14:22 ashimema if he's willing to give it a go that would be great
14:22 ashimema the others are certainly enhancements that can be in followups
14:23 caroline yeah, he said he's never done that (the sysprefs) but I'm sure he can have a look
14:24 caroline he's on it!
14:24 * oleonard doesn't think it should require a syspref to pass QA
14:25 * ashimema said it was a 'nice to have' but if he's willing to go that extra mile I'd encourage it.. I'm certainly happy to add it after the fact if he runs out of time :)
14:26 cait not insisting on a syspref - even tho i brought it up first place
14:26 cait didn't read all comments, just want to throw that in
14:28 cait caroline: for sysprefs there is some instruction on the wiki, if that helps
14:28 cait https://wiki.koha-community.org/wiki/System_Preferences
14:28 * ashimema was just trying to dig those out.. do you have a link cait ;)?
14:28 cait too slow ,)
14:28 ashimema hugs
14:29 cait :)
14:29 * cait goes back to boring updating config documents
14:29 caroline ok, so I told him to do the first point and add it as a patch and then we can discuss the rest
14:30 caroline Because I'm not a dev I only understand half of what everydoby is saying
14:30 ashimema :)
14:31 caroline I think once he's done with the first point, I'll tell him to come on IRC so you can speak without my interference which probably causes more confusion than anything else
14:32 ashimema :)
14:36 reiveune bye
14:37 caroline_ Joubu when you say "* I think it would have been more useless with the last X (5?) instead of the last one (not required)" did you mean "more useful"?
14:38 Joubu caroline_: heh, just added a comment to correct it :)
14:39 caroline_ ok! :) It makes more sense!
14:47 ashimema ok.. now my screen looks even more odd
14:47 ashimema not what joubu saw.. but not what I was seeing before either
14:47 * ashimema checks another browser
14:49 caroline_ pierreluc is here! :D
14:53 oleonard Hi pierreluc
14:53 pierreluc Hello Joubu! For bug 20312 - comment 19, I mad eit so #lastborrower-window is by default hidden. Is the id name (lastborrower-window) correct or should I change it?
14:53 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 new feature, P5 - low, ---, maksim.sen, Signed Off , Add a link towards the last consulted patron
14:54 Joubu "window" does not sound correct to me, but that's not a big deal
14:54 pierreluc Ok, if you have a name suggestion, I'll be happy to change it
14:54 ashimema I'm now struggling on positioning of it.. it looked reasonable to me to start with.. but I can't replicate what I first saw now :(
14:55 Joubu `yarn build`?
14:56 ashimema oleonard : was your suggestion to put the element inline/inside the breadcrumb bar right?
14:56 caroline_ is yarn an actual thing in programming?
14:58 * caroline_ is a knitter and therefore loves yarn
14:59 oleonard ashimema: Did you run 'yarn build' to regenerate CSS?
14:59 ashimema seems I did but it didn't run to completion.. grr my dev system is missing some deps
14:59 ashimema either way.. Joubu's screenshot shows issues too
15:01 oleonard Which screenshot? https://snag.gy/6vbjNS.jpg ?
15:02 cait don't overengineer peeps:)
15:02 ashimema indeed
15:02 cait caroline_: i knit too :) but still beginner
15:02 ashimema I thought the element was inside the breadcrumb bar.. not on top ;)
15:03 caroline_ [off] just so you know, when you guys say "yarn build" this is what I think about http://knittingwithsandrasingh.blogspot.com/2012/09/yarn-bombing.html
15:03 cait window = page?
15:03 oleonard ashimema: That was how it was in my interface proposal, but there was never a working patch with it that way
15:03 oleonard ashimema: So there's no regression
15:04 ashimema fair enough.. when i first loaded the patch on.. that's exactly where it appeared for me.. inside the bar
15:04 ashimema must have been a one off..
15:04 ashimema I'm stuck rebuilding yarn now.. seems trying to fix it has entirely borked my dev npm
15:05 ashimema all fun
15:07 cait if we add a pref, i thin it doesn't need to be perfect-perfect - turn it on/off if you like or not
15:09 ashimema indeed
15:17 ashimema yarn fixed and css built again
15:17 ashimema now it works as expected.. sorry about that one.
15:18 ashimema So.. I think all that pierreluc needs to do is that first comment of Joubu's. i.e. hide by default and unhide as required.. which I think he said he'd done.. all the rest can be covered by followup bugs in my opinion.
15:18 ashimema sorry for any confusion there pierrelic
15:21 * Joubu sent ashimema more black tea
15:21 ashimema haha.. thanks
15:21 cait not sure if MORE is the solution :)
15:22 ashimema lol
15:22 pierreluc For now, I made it so the element is hidden by default and only appears when we know the last patron (it was shown by default and then hidden when we don't have the last patron information) :)
15:23 ashimema perfect
15:25 pierreluc I'm working on the third point in comment 19 (last patron is the current patron, which is useless).
15:27 ashimema that's almost the same as my comment on comment 21
15:27 ashimema only I try to think of one way to solve it..
15:28 ashimema not sure my way is especially achievable though now I think about it.. perhaps bind on $(window).on("beforeunload", function() {}); maybe.. but I'm not entirely sure.
15:29 ashimema the alternative is to just detect when you're on a user page and compare the 'last patron' to the 'current patron' and not show if they match..
15:29 ashimema easier change that I think.
15:36 * tcohen suspects of people that don't drink coffee
15:37 * ashimema drinks both
15:37 pierreluc I like the idea ashimema! I'll look into it!
15:38 ashimema good luck :)
15:39 pierreluc Thank you! :)
16:25 cait oleonard: for bug 21151 - maybe a merge error? my patch didn#t remove th eline
16:25 cait https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77551
16:25 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 major, P5 - low, ---, katrin.fischer, Pushed to Stable , SRU search fields mapping pop-up comes up empty
16:26 cait only added the parameter
16:28 * Joubu blames kidclamp
16:29 Joubu from 19436:
16:29 Joubu -[% INCLUDE 'popup-bottom.inc' %]
16:29 Joubu +[% INCLUDE 'intranet-bottom.inc' popup_window=1 %]
16:29 Joubu then your patch:
16:29 Joubu -[% INCLUDE 'doc-head-close.inc' %]
16:29 Joubu +[% INCLUDE 'doc-head-close.inc' popup => 1 %]
16:29 Joubu and finally the line is deleted in master \o/
16:30 cait oleonard: it's because he pushed sru for authorities first
16:30 cait merge conflict
16:30 cait and falsely resolved
16:30 cait yeah
16:30 * cait glares a little at kidclamp for totally breaking her patch
16:31 cait and it only had 2 lines! heh
16:31 Joubu It let you imagine what he does with the bigger ones!
16:32 Joubu I am kidding, right ;)
16:32 cait i hope you are
16:33 cait hm we might want to check if martin cherry-picked for 18.05
16:33 cait ashimema
16:34 cait he did :(
16:34 cait can we not just revert and use the correct patch?
16:34 cait well... just
16:35 cait and noone tested after pushing.
16:38 * cait goes to make dinner
17:06 kidclamp sorry cait, I did my best, and failed
17:06 kidclamp I thought I tested together
17:07 kidclamp seriously, I am about to cause all sorts of conflicts
17:11 oleonard You go, kidclamp
17:22 huginn` News from kohagit: Bug 13618: Remove filter when assigning array <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=22ab4ba524fe1595dbd85e10b6727007133ae2e4>
17:22 huginn` News from kohagit: Bug 13618: Fix wrong condition in xt tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=facb5cb25a3e81952282b228190870640a383295>
17:22 huginn` News from kohagit: Bug 13618: Add POD to raw.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9e895e581288e4299e28d6c542ac3f66f80d6f3d>
17:22 huginn` News from kohagit: Bug 13618: (follow-up) Add html filters to all the variables <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f59b8461348e0c974c17d970757698b018e00c32>
17:22 huginn` News from kohagit: Bug 13618: (follow-up) Manually replace missing .raw <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1981db25cefcb39405835ee5e90b1fb1ca6f4928>
17:22 huginn` News from kohagit: Bug 13618: Remove html filter for NEXT <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=96e2d28fd5d342b6569ad24d17cedf8ad6415616>
17:22 huginn` News from kohagit: Bug 13618: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4321dbe2212e917ebed5fc5500e108e02dd041c0>
17:22 huginn` News from kohagit: Bug 13618: Add missing raw filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=13d0c46bdcceceace6df38bd4bf283855aff3d42>
17:22 huginn` News from kohagit: Bug 13618: Remove html filter for STOP and deal with existing USE raw <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cc5c66d27b81a5b44238f66d474b6396ad334487>
17:22 huginn` News from kohagit: Bug 13618: (follow-up) Escape HTML chars in holds.js <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=726a61ac65e4d504aba328c41cdc76ef65210222>
17:22 huginn` News from kohagit: Bug 13618: (follow-up) Add html filters to all the variables <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8d61035e8574a89d5dae44a0c4120e657539c3dc>
17:22 huginn` News from kohagit: Bug 13618: Fix item search <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f580af25e1518d0cac5ccd46a653a98e8b8d2282>
17:22 huginn` News from kohagit: Bug 13618: Explicitly use raw for itemtype.checkinmsg <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=599a4a16ef4e66b7f117502bb94e2eeab399eb57>
17:22 huginn` News from kohagit: Bug 13618: Specific for labels/spinelabel-print.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=51b7499d10b0f32eeb59b9debb7cbc99b921eef9>
17:22 huginn` News from kohagit: Bug 13618: Specific for labels <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1c0aad5a1d652c8e7ad0c18bb19214b22b3c554a>
17:22 huginn` News from kohagit: Bug 13618: Escape HTML chars in checkouts.js <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cef24888bdf188857511136afd3d35ec607a0ca3>
17:22 huginn` News from kohagit: Bug 13618: Add the escapeHtml JS prototype to String <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8ee92112e48d52eb5dad5533075f3ab0aed658ba>
17:22 huginn` News from kohagit: Bug 13618: Escape HTML chars in holds.js <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a6f9738fd2bda70428ebe49a7be0696ea997406c>
17:22 huginn` News from kohagit: Bug 13618: Deal with span in patron-title <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5a7ee2db081ea4a71ebe98291faf8a7c70994ae5>
17:22 huginn` News from kohagit: Bug 13618: Specific for IntranetCirculationHomeHTML <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=865c385f718c56ea6fc6d718496ee2ff6aa0c667>
17:23 Joubu Moooovee!
17:23 * Joubu runs away
17:43 ashimema Run away
17:44 ashimema I'll make a note to chase up the conflict you just pointed out.. grr.. just annoying missing something like that.. but way too easy the miss
17:47 kidclamp yeah, I meant to say something but you had already pushed it
17:49 * cait sends weekend cookies and beers all around
17:49 jenkins Project Koha_Master_D9 build #541: UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_D9/541/
17:49 ashimema No worries.. I was on a role that day.. basically waited for tests to pass on Jenkins them ported as fast as I could
17:50 ashimema Rushing to get the last bits in before string freezing
17:51 Joubu cait, ashimema: how do you feel about bug 21242?
17:51 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 normal, P5 - low, ---, jonathan.druart, In Discussion , Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber
17:51 Joubu see screenshot in the last-1 comment
17:53 jenkins Project Koha_Master_U18 build #29: UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_U18/29/
17:53 cait hm
17:53 cait the new thing is hte name showing, right?
17:53 cait and tha tyou can't change it?
17:55 cait torn about the read only a little, but undecided
17:59 jenkins Project Koha_Master_D8 build #30: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/30/
18:00 oleonard-away Joubu: Have you added any coding guidelines to go along with Bug 13618?
18:00 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Prevent XSS in the Staff Client and the OPAC
18:00 * ashimema is eating dinner.. will take a look after
18:01 Joubu oleonard: nope
18:01 Joubu (yet)
18:02 oleonard Please do
18:02 ashimema There is an xt test in the patch I believe oleonard.. but guidelines would be good too
18:02 * ashimema must remember to run that test as part of qa
18:02 Joubu oleonard: go read the comments!
18:03 Joubu 238, not that much
18:06 ashimema Meany
18:07 * oleonard copies all the comments into a new wiki page
18:08 huginn` News from kohagit: Bug 13618: Fix xt/tt_valid.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f130ada624a7c48bbd2e082cc77f064a793cda8b>
18:34 jenkins Yippee, build fixed!
18:34 jenkins Project Koha_Master_D9 build #542: FIXED in 25 min: https://jenkins.koha-community.org/job/Koha_Master_D9/542/
18:36 jenkins Project Koha_Master_U18 build #30: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/30/
18:36 kidclamp huzzah!
18:37 tcohen great!
18:38 Joubu tcohen: seen that one?
18:38 wahanui I haven't seen 'that', Joubu
18:38 tcohen ?
18:38 Joubu koha_1 | [JSON::Validator] GET http://swagger.io/v2/schema.json == Can't connect: Temporary failure in name resolution at /usr/share/perl5/JSON/Validator.pm line 274.
18:41 tcohen hm, we can't do anything about that
18:44 jenkins Yippee, build fixed!
18:44 jenkins Project Koha_Master_D8 build #31: FIXED in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/31/
18:46 Joubu https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_the_variables
18:46 Joubu Could anyone read that?
18:47 Joubu (Mediawiki syntax drove me crazy..)
18:47 Joubu @later tell oleonard Here it is! https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_the_variables
18:47 huginn` Joubu: The operation succeeded.
18:53 caroline_ Joubu: I don't know if I count as "anyone", but in the second example, ...Koha.Preference bla bla... just under that it says "if your_variable", shouldn't it say "if Koha.Preference bla bla"?
18:54 caroline_ Also, in the 3rd example, it says uri, but in the text under you say url. I don't know if that makes a difference
18:55 cait :)
18:55 Joubu copy-paste--
18:56 cait caroline++
18:57 Joubu caroline_: updated
18:57 caroline_ +1
18:57 Joubu uri vs url is expected, I added few more words to explain it better
19:25 Joubu bye #koha!
19:25 caroline_ have a good weekend Joubu!
19:51 kidclamp bye all! havea good weekend!
21:35 Vernoica what to do so that you do not reserve an item with a borrowed state in koha, it would be very helpful thanks.
21:38 caroline_ Vernoica: Just to make sure I understand what you are rying to do, if an item is borrowed, you don't want to be able to reserve it, but if it's available, you want to be able to reserve it
21:39 caroline_ is that it?
21:39 caroline_ I think the reverse is possible (not reserve available items, but reserve borrowed items)
21:41 Vernoica YES
21:42 Vernoica if an item is borrowed, you don't want to be able to reserve it, but if it's available, you want to be able to reserve it
21:42 Vernoica ???
21:42 caroline_ I'm not sure that's possible
21:42 Vernoica THANKS
21:43 caroline_ I think the best way to go about it is remove reservations completely, and then if someone asks, override by reserving through the intranet
21:43 Vernoica Modifying would be possible?
21:44 caroline_ You can prevent reservations in circulation rules (Administration > Circulation and fines rules)
21:44 Vernoica cancel reservations?
21:45 caroline_ And then set the AllowHoldPolicyOverride system preference to "Allow" so that staff can override the "no reservations rules"
21:45 caroline_ It's a workaround, it's not exactly what you want
21:46 caroline_ In the majority of libraries they want to be able to reserve items that are borrowed, that's the way Koha is built
21:48 Vernoica Thanks I'll try
22:04 rangi caroline_: just tidying up a couple of your merge requests, if you see mail from gitlab thats why :)
22:04 rangi (a couple had to be merged locally, not in the tool)
22:05 caroline_ rangi: yeah I just saw the emails
22:05 caroline_ Do I have to change the ones that have a conflict?
22:06 caroline_ I guess it's got to do with rebasing or something? (I'm only a yellow belt in git)
22:09 rangi naw, ive fixed them
22:10 rangi yeah someone had changed images.rst as well as you
22:10 rangi i just merged the changes
22:10 caroline_ It might've been me...
22:10 rangi when the automatic build finishes we should be able to see the new housebound module :)
22:11 caroline_ I'm always wondering how to deal with images since it's incremental...
22:11 caroline_ A decimal systemp would be so much better (says the librarian) ;)
22:12 rangi yeah, they don't need to be words
22:12 rangi it can be anything
22:13 rangi for the record this one .. |image1347| image:: images/tools/importpatrons/patronattributes.png
22:13 rangi was added by another commit, and it conflicted with the housebound ones
22:13 rangi sorted now
22:14 caroline_ I'm working on restrictions now (bug 13228) and I think I'll have to renumber my images
22:14 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13228 enhancement, P5 - low, ---, chris, NEW , Documentation of 'restrictions' tab does not show "OVERDUE" restriction
22:15 rangi ahh yep
22:35 caroline_ Good weekend #koha!
22:35 rangi cya caroline_