Time  Nick          Message
05:19 fridolin      hi everybody
05:22 ashimema      Mornin' #koha
06:18 * andreashm   waves
06:46 reiveune      hello
06:50 alex_a        bonjour
07:54 ashimema      ack... why oh why do we not return a dbic ResultsetColumn and instead shortcircuit it to a far less usful array of values :'(
07:58 ashimema      goodbye `as_query`, `sum`, `max`, `min`, `all`, `first`,  `min_rs`, `max_rs`, `sum_rs`, `func` !
07:58 josef_moravec ashimema: I was just surprised by this yesterday...
08:00 tuxayo        "Historical reasons" is the answer for any question like that.
08:00 tuxayo        ashimema josef_moravec ↑
08:00 ashimema      give me back proper dbic any day of the week.. I've tried realyl hard to understand why we chose the Koha::Object route and I just can't see it.. dbic objects have had years to mature.. why not stand on the shoulders of giants..
08:01 tuxayo        Same answer :P
08:01 ashimema      I argued against them in the first place to be honest
08:01 ashimema      so it's not really historical as such as it's not that old a decision
08:03 tuxayo        ashimema: Is it the pre-dbic way of doing it or is that yet another way?
08:05 ashimema      we added dbic.. then there was a big hoo ha over whether we should allow adding custom methods to dbic generated classes which resulted in the answer 'no' (so, we in fact decided against the recommendation of the dbic community.. the whole idea is dbic gives you a starting place which you build on by adding customer methods and resultset classes ontop of the result classes)..
08:05 ashimema      we then got annoyed with not being able to add methods as required to dbic classes that someone came up with objects.. which are basically crippled dbic classes built on top of dbic classes.
08:06 ashimema      Issue is.. we adopt new technologies but very few people take the time to learn how to use them properly and fully leverage them.. dbic is a prime case..
08:07 ashimema      I constantly find koha code where we've worked really hard to overcome a problem that was overcome a nice way long ago in a library we already use but didn't learn how to use fully and properly.
08:07 * ashimema    switches out of history lesson/rant mode
08:08 * ashimema    is just a tad annoyed at reading code and thinking.. I could do with 25 lines in 2 lines and my 2 lines would be more performant.. crap.. I'm not aloud to.
08:10 tuxayo        Thanks, interesting read :)
08:10 tuxayo        > I'm not aloud to
08:10 tuxayo        Is it still not possible to add custom methods to dbic generated classes? (thus 25 lines instead of 2)
08:11 ashimema      well you can now add methods to dbic generated classes (why are we still autogenerating I will never understand)..
08:11 ashimema      but in this aprticular case it was reading some code that got a resultset, iterated through the resultset adding up values
08:12 ashimema      when it could have simply been `->resultset()->search()->column_to_sum->sum;`
08:13 ashimema      also.. by throwing away ->as_query all over the place you actually make query construction considerably harder
08:13 ashimema      also.. chaining searches seems to not work as well as it does in all my dbic only code elsewhere.
08:13 ashimema      so thos are three things that bug me of late ;)
08:15 tuxayo        ashimema: dbic looks powerful :)
08:19 ashimema      it has it's flaws.. but they're well known and understood and there's a massive community around dbic to ask questions..
08:19 ashimema      Koha::Objects can't really say the same.. in the grand shceme of things it's a small community with few people that fully understand the code..
08:20 ashimema      I like dbic.. it is incredibly powerful and has a fairly reasonably learning curve
09:05 cait          khall: around?
09:09 ashimema      you'll need to get someone at bywater to poke him.. he no longer turns his irc on  cait
09:09 ashimema      at least that's my experience of late
09:09 cait          oh
09:10 * ashimema    has been trying to get a shared slack running to catch bywater for a while now
09:10 cait          kidclamp: ping
09:10 cait          maybe someone else knows
09:11 cait          if you have added a wrong manual fine
09:11 cait          it seems ther is no optionto delete or update it
09:11 cait          do we have something planned to change that? is there something else you can do that is not a write off?
09:11 ashimema      hmm.. that may well be deliberate
09:12 ashimema      tcohen has been working most closely with that area of late
09:12 cait          yeah but there should be a suggested workflow maybe?
09:14 ashimema      indeed..
09:15 ashimema      writeoff/credit ammendment is the most trackable way of doing it.
09:15 ashimema      I wish one could more easily associate a credit with a debit.. that way an amendment could be really clearly done
09:15 * ashimema    adds that to the tcohen wishlist
09:17 cait          i think tcohen was investigating fixing credits
09:17 ashimema      :)
09:17 ashimema      reading his submissions is on my todolist
09:20 ashimema      you guys aren't on 17.05 yet are you cait?
09:20 ashimema      wondering if you're looking at bug 19687 at all
09:20 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 major, P5 - low, ---, koha-bugs, NEW , Recent upgrade to 17.05.04.000 bulkmarcimport started to fail
09:21 cait          hm maybe i should, although we are only using this for migrations
09:21 cait          we plan an update from 16.11 to 17.11 atm
09:21 ashimema      it also affect the stage + commit
09:21 cait          working right now on fixing an authority import script with changes done to the API (we do weird things there, our fault)
09:21 cait          eek
09:21 ashimema      which I thought you used for union catalogue syncing still?
09:21 cait          you got me there
09:22 cait          hm no items for staged... but of course for migration you'd need it
09:22 ashimema      ;)
09:22 cait          have you tested it yourself?
09:22 ashimema      Ian is our migrations man.. he's tested it lots
09:23 cait          does he have a fix?
09:23 ashimema      it's on my todo list.. but I haven't had a moment to look at it yet myself
09:23 eythian       cait: https://www.bbc.com/news/world-asia-44385018 (bet he's feeling abit silly now though.)
09:23 ashimema      yes.. but I'm not sure it's the right fix.. he just adds full subroutine paths
09:23 ashimema      rather than importing the modules required
09:24 cait          hm already major, wonder why i didn't spot it
09:24 ashimema      not sure whose been converting command line scripts to work properly recently.. I'm sure someone has
09:24 cait          broken import sounds quite bad
09:24 cait          i think we didn something with the crons
09:25 ashimema      I think the general install base out there is pretty old ;)
09:37 cait          hm could someone test exporting authorities from 17.11 or higher?
09:38 cait          can't get the file to open with marcedit :(
09:38 cait          ah right... it's empty... I will come back later when I've found my head
09:46 cait          someone happen to know how to use workbench with kohadevbox?
10:26 jenkins       Project Koha_18.05_U18 build #17: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/17/
10:26 jenkins       * katrin.fischer: Bug 20793: Don't show a holds link in staff for users without permission
10:26 jenkins       * oleonard: Bug 20793: (follow-up) Add style to the non-link hold count on detail
10:26 jenkins       * gonzalez: Bug 19835: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and
10:26 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 minor, P5 - low, ---, katrin.fischer, Pushed to Stable , Don't show holds link in result list when staff user doesn't have place_holds permission
10:26 jenkins       * gonzalez: Bug 19835: Fix repeatability on MARC21 subfields
10:26 jenkins       * gonzalez: Bug 19835: Fix MARC21 frameworks revision date
10:26 jenkins       * katrin.fischer: Bug 19835: (follow-up) Correct formatting in a few places
10:26 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 enhancement, P5 - low, ---, bgkriegel, Pushed to Stable , Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
10:32 jenkins       Project Koha_18.05_D9 build #22: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/22/
10:32 jenkins       * katrin.fischer: Bug 20793: Don't show a holds link in staff for users without permission
10:32 jenkins       * oleonard: Bug 20793: (follow-up) Add style to the non-link hold count on detail
10:32 jenkins       * gonzalez: Bug 19835: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and
10:32 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 minor, P5 - low, ---, katrin.fischer, Pushed to Stable , Don't show holds link in result list when staff user doesn't have place_holds permission
10:32 jenkins       * gonzalez: Bug 19835: Fix repeatability on MARC21 subfields
10:32 jenkins       * gonzalez: Bug 19835: Fix MARC21 frameworks revision date
10:32 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 enhancement, P5 - low, ---, bgkriegel, Pushed to Stable , Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
10:32 jenkins       * katrin.fischer: Bug 19835: (follow-up) Correct formatting in a few places
10:32 jenkins       * katrin.fischer: Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016,
10:32 jenkins       * katrin.fischer: Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April
10:32 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 enhancement, P5 - low, ---, katrin.fischer, Pushed to Stable , Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
10:38 jenkins       Project Koha_18.05_D8 build #21: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/21/
10:38 jenkins       * katrin.fischer: Bug 20793: Don't show a holds link in staff for users without permission
10:38 jenkins       * oleonard: Bug 20793: (follow-up) Add style to the non-link hold count on detail
10:38 jenkins       * gonzalez: Bug 19835: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and
10:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 minor, P5 - low, ---, katrin.fischer, Pushed to Stable , Don't show holds link in result list when staff user doesn't have place_holds permission
10:38 jenkins       * gonzalez: Bug 19835: Fix repeatability on MARC21 subfields
10:38 jenkins       * gonzalez: Bug 19835: Fix MARC21 frameworks revision date
10:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 enhancement, P5 - low, ---, bgkriegel, Pushed to Stable , Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
10:38 jenkins       * katrin.fischer: Bug 19835: (follow-up) Correct formatting in a few places
10:38 jenkins       * katrin.fischer: Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016,
10:38 jenkins       * katrin.fischer: Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April
10:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 enhancement, P5 - low, ---, katrin.fischer, Pushed to Stable , Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
10:39 * ashimema    likes jenkins being happy
10:39 ashimema      though U18 still needs a little work
10:51 jenkins       Project Koha_18.05_U18 build #18: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/18/
10:51 jenkins       * katrin.fischer: Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016,
10:51 jenkins       * katrin.fischer: Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April
10:51 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 enhancement, P5 - low, ---, katrin.fischer, Pushed to Stable , Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
12:19 marcelr       hi #koha
12:20 ashimema      after singing dbics praises earlier I just found a fringe case bug in it :)
12:24 oleonard      Hi all
12:26 marcelr       hi oleonard
12:26 marcelr       oleonard++ # SO
12:29 * LeeJ        waves
12:30 oleonard      marcelr, I took a look at your GDPR patch yesterday and had a question -- is there (or is there going to be) a way for staff to see who has declined consent?
12:30 eythian       that feels problematic
12:30 marcelr       this still needs attention on another report
12:31 marcelr       it is a request to delete (unsubscribe)
12:31 eythian       "here's a list of all the people who don't want their names put into lists"
12:31 marcelr       eythian: you need a list of delete requests
12:36 ashimema      Just delete them from the list when you do the deletion
12:46 ashimema      any Koha::Object pros here..
12:47 ashimema      do we inflate/deflate DateTimes in the same was as dbic?
12:50 ashimema      Ooh.. looks like we don't use InflateColumn anywhere :'(
12:51 ashimema      am i missing something somewhere here..
12:52 ashimema      we set datetime_undef_if_invalid in the result classes but we don't actually import InflateColumn::DateTime ...
13:04 Joubu         hi #koha
13:04 marcelr       hi Joubu
13:04 caroline      Good morning!
13:05 marcelr       and hi caroline
13:05 calire        hi #koha
13:05 marcelr       and calire re !
13:05 kidclamp      hi all
13:05 marcelr       and kidclamp :)
13:05 marcelr       whats happenign here
13:06 calire        o/
13:06 caroline      marcelr: I don't know. What is happening? Did I come in in the middle of a meeting?
13:07 marcelr       nothing really
13:07 caroline      okay lol!
13:07 marcelr       it seems to be 9 in the us
13:07 caroline      yes, eastern time
13:08 oleonard      I too would like to know what's happening. What's up. What's going on. What's new.
13:08 chris_n       cait: Could you post the results of the query I added to bug 8604, please?
13:08 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 major, P5 - low, ---, cnighswonger, NEW , Patron cards made for patrons which don't have patron images use preceding card's image
13:13 oleonard      Oh hey who hasn't met chris_n before? He lurks 11 months out of the year and then POUNCES when someone has a question about labels or patron cards
13:13 oleonard      chris_n++
13:14 caroline      Oh yeah, I remember seeing the explanation on the wiki https://wiki.koha-community.org/wiki/Using_the_Patron_Card_Creator
13:18 chris_n       oleonard: ;)
13:35 ashimema      i bet adding dbic helpers is frowned upon isn't it... I want to add correlate subquery support
13:45 tcohen        morning
13:49 marcelr       hi tcohen
13:52 oleonard      @wunder 45701
13:52 huginn        oleonard: Athens, OH :: Clear :: 78F/25C | Tuesday: A mix of clouds and sun during the morning will give way to cloudy skies this afternoon. A stray shower or thunderstorm is possible. High 91F. Winds light and variable. Tuesday Night: Partly cloudy skies. A stray shower or thunderstorm is possible. Low 71F. Winds light and variable.
13:53 tcohen        @wunder cordoba, argentina
13:53 huginn        tcohen: Cordoba, Argentina :: Mostly Cloudy :: 40F/4C | Tuesday: A shower or two around the area early, then partly cloudy during the afternoon. High near 50F. Winds E at 5 to 10 mph. Chance of rain 30%. Tuesday Night: Some clouds. Low 32F. Winds NNE at 5 to 10 mph.
13:53 tcohen        Joubu: we are ready to welcome you in Cordoba, with our great weather
13:53 tcohen        hahaha
13:55 Joubu         :-/
14:02 alex_a        nlegrand, just for you: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032
14:02 huginn        Bug 21032: major, P5 - low, ---, alex.arnaud, Needs Signoff , Refining a search made on a specific index fail
14:02 alex_a        To test
14:06 oleonard      I would like to get more opinions on Bug 20729
14:06 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 enhancement, P5 - low, ---, oleonard, In Discussion , Update style of datepickers
14:09 tcohen        Joubu: Cecilia says it is snowing WTF
14:10 marcelr       winter sport
14:10 marcelr       Winter Time Fun ?
14:10 tcohen        snow tennis
14:15 Joubu         it's freezing here as well
14:15 Joubu         @wunder Buenos Aires, Argentina
14:15 huginn        Joubu: Buenos Aires, Argentina :: Clear :: 45F/7C | Wind Chill: 41F/5C | Tuesday: Partly cloudy. High 49F. Winds SE at 5 to 10 mph. Tuesday Night: Cloudy skies. Low 44F. Winds ESE at 5 to 10 mph.
14:16 marcelr       oleonard: at first i did not even see the subtle difference on 20729
14:16 marcelr       somehow it feels funny to put him inside but it works
14:19 eythian       tcohen: I learnt today that Argentina has a Welsh-speaking population.
14:19 oleonard      Thanks for taking a look marcelr
14:59 marcelr       htg
14:59 marcelr       bye #koha
15:41 reiveune      bye
19:17 oleonard-away My success with Bug 20520 has only emboldened me. Look ye on Bug 20134 and despair!
19:17 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 enhancement, P5 - low, ---, oleonard, Pushed to Stable , Re-indent moremember.tt
19:17 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 normal, P5 - low, ---, tomascohen, RESOLVED FIXED, Remove /api/v1/app.pl from the generated URLs
19:18 oleonard      whoops, Bug 21034
19:18 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 enhancement, P5 - low, ---, oleonard, Needs Signoff , Re-indent circulation.tt
19:19 ashimema      :)
20:12 oleonard      I'm off until the 16th, so everyone have fun signing off on all my patches while I'm gone!
20:15 cait          ooh
20:15 cait          missed oleonard
20:15 cait          happy vacation1
21:58 caroline      bye #koha! See you tomorrow!