Time Nick Message
05:48 fridolin hi there
06:28 reiveune hello
06:51 alex_a bonjour
07:16 magnuse \o/
07:20 * andreashm waves
07:36 gaetan_B hello
07:37 andreashm hi gaetan_B
10:51 marcelr hi #koha
11:35 oleonard Hi all
11:37 marcelr hi oleonard ; dont talk to loud here ;)
11:37 marcelr too
11:38 calire hi oleonard
11:38 wahanui hi dear loon
11:39 marcelr hi calire
11:39 calire hey marcelr :)
11:45 eythian_ oleopard: I saw some cousins of yours in the news: https://www.dutchnews.nl/news/2018/05/french-tourists-chased-by-cheetahs-after-leaving-car-in-dutch-safari-park/
11:46 marcelr eythian: those cheetahs were quite slow
11:46 eythian apparently they were well fed already
11:57 oleonard cheetahs... they think they're so cool. We get it, you're fast. Why does your VCR still blink "12:00" ?
11:57 calire XD
12:00 marcelr put some tape over your vcr
12:47 tcohen morning
12:50 magnuse ¡hola tcohen!
12:54 * LeeJ waves
12:54 LeeJ hi #koha
12:54 calire hi LeeJ
12:55 LeeJ hi calire :)
12:57 LeeJ @later tell caroline_ both merged :) thanks for the help!
12:57 huginn LeeJ: The operation succeeded.
13:16 tcohen hola Joubu
13:16 marcelr hi tcohen
13:17 tcohen I wasn't able to make the selenium docker with aliases
13:17 tcohen I think there's a bug in the official image, and I don't have the time to spend more hours on that
13:17 tcohen so I left it as koha:8080 / koha:8081
13:17 tcohen anyone wiht Docker experience around?
13:18 tcohen hey marcelr
13:20 Joubu tcohen: ok, not urgent for now
13:21 tcohen Joubu: yeah, just a note that your last patch won't be reverted for a while it seems
13:25 oleonard Thank you for the sign-offs calire
13:26 calire oleonard you're welcome
13:53 Joubu tcohen: 20428
13:53 Joubu no value for tmp_path in etc/koha-conf.xml?
13:54 tcohen it falls back to current behaviour
13:54 Joubu return C4::Context->config('tmp_path') || File::Spec->tmpdir;
13:54 Joubu then, about.pl:
13:54 Joubu +if ( ! defined C4::Context->config('tmp_path') ) {
13:54 Joubu why unless defined?
13:56 tcohen Joubu: no entiendo la pregunta
13:57 Joubu File::Spec->tmpdir is returned if the entry exists but empty ("<tmp_path></tmp_path>"), the about page will display a warning only if the tag is not present in the conf
14:00 Joubu tcohen: ^?
14:00 wahanui i guess ^ is what I think too
14:02 tcohen Joubu: my mistake
14:02 wahanui well, your mistake is i'm not deleting the es-ES trnaslation on each iteration
14:02 tcohen defined needs to be removed
14:02 Joubu tcohen: ok, I will do it
14:03 Joubu it's what other checks do actually :-/
14:04 tcohen because about.pl usually warns when there's no entry in koha-conf.xml
14:04 tcohen and don't care about the contents of the entry
14:05 Joubu that's wrong
14:05 Joubu tcohen: also, effective_tmp_dir is set to File::Spec->tmpdir, but should call Koha::UploadedFile->temporary_directory
14:07 tcohen well
14:07 tcohen we should move this to C4::Context, and have everything use that
14:07 tcohen but this bug was dealing with file uploads when it was filed
14:07 tcohen if we werent' so close to the release I would do it
14:19 huginn News from kohagit: Bug 20428: Display warning if the entry is empty <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=71eba3a74a65b49aeb5c24ddd5118df882cef14b>
14:19 huginn News from kohagit: Bug 20764: Koha_Template_Plugin_KohaPlugins.t is db dependent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=831e6fac4d84cf5cbc63354dcd1baa5100cfaba7>
14:19 huginn News from kohagit: Bug 20428: (QA follow-up) Remove redundant directory level <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a88e052ae5e420eb2f8ffa7555756b0581b72652>
14:19 huginn News from kohagit: Bug 19181: Do not screenshot <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c65526f4904d6070cd88b3e7cb56a7beaed18e20>
14:19 huginn News from kohagit: Bug 20428: Make upload_tmp a more general tmp directory <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fdb5d0ca1ac16563c4b34c47dd32d61f96913d8a>
14:19 huginn News from kohagit: Bug 20404: Turn on ExtendedPatronAttributes by default for new installations <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=624870631ce374e90db2035545150eca95c72677>
14:19 huginn News from kohagit: Bug 20428: Added missing parameter --upload-tmp-path <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8ffaa7b8a32b9ee2d9d430c097322708f090f8f7>
14:19 huginn News from kohagit: Bug 20428: Make about.pl inform about missing upload_tmp_path entry <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da2886132e8445dd472b8b9ccd67e07365657c3a>
14:19 huginn News from kohagit: Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2b0c27beafae072087d1e63bb00cc5b193ed9917>
14:19 huginn News from kohagit: Bug 20428: Add the option to specify a tmp uploads dir <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d90d8c9b272061986c101763d7c8f73ed7a9b0a2>
14:27 Joubu tcohen: did you see the big jump on coverage: https://jenkins.koha-community.org/job/Koha_Master_D8/ from 70% to 85% of the statements covered?
14:27 Joubu did we cheat somewhere? :)
14:28 tcohen I don't think so
14:28 tcohen remember you removed lots of code from C4:*
14:35 tuxayo Hi :)
14:35 tuxayo Should prove t/db_dependent/Reserves.t work?
14:35 tuxayo I get "Parse errors: Bad plan. You planned 56 tests but ran 7."
14:37 Joubu you should see an error
14:41 tuxayo Joubu: you mean that I should see this error? (about number of tests mismatch)
14:46 Joubu you should see an error just before this message
14:49 tuxayo Joubu: you are right. There was a "The method 0 is not covered by tests!" hidden at the end of some line.
14:49 Joubu something else before?
14:50 Joubu paste the whole output :)
14:50 Joubu paste?
14:50 wahanui I eat paste! It's tasty! http://paste.koha-community.org
14:51 pastebot "tuxayo" at 127.0.0.1 pasted "testing bug 20724 for Joubu" (14 lines) at http://paste.koha-community.org/38
14:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 critical, P5 - low, ---, jonathan.druart, Needs Signoff , ReservesNeedReturns syspref breaks "Holds awaiting pickup"
14:56 Guest2474 Project Koha_Master_D8 build #478: UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/478/
14:56 Guest2474 * Jonathan Druart: Bug 19181: Do not screenshot
14:56 Guest2474 * katrin.fischer: Bug 20404: Turn on ExtendedPatronAttributes by default for new
14:56 Guest2474 * Tomás Cohen Arazi: Bug 20428: Add the option to specify a tmp uploads dir
14:56 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Intranet and OPAC authentication selenium test
14:56 Guest2474 * Tomás Cohen Arazi: Bug 20428: Make Koha::UploadedFile use the new config entry for tmp
14:56 Guest2474 * Tomás Cohen Arazi: Bug 20428: Make about.pl inform about missing upload_tmp_path entry
14:56 Guest2474 * mtompset: Bug 20428: Added missing parameter --upload-tmp-path
14:56 Guest2474 * Tomás Cohen Arazi: Bug 20428: Make upload_tmp a more general tmp directory
14:56 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20404 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Extended patron attributes should always be on
14:56 Guest2474 * m.de.rooy: Bug 20428: (QA follow-up) Remove redundant directory level
14:56 Guest2474 * Jonathan Druart: Bug 20428: Display warning if the entry is empty
14:56 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 major, P5 - low, ---, tomascohen, Pushed to Master , MARC import fails on Debian Stretch
14:56 Guest2474 * mirko: Bug 20764: Koha_Template_Plugin_KohaPlugins.t is db dependent
14:56 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20764 normal, P5 - low, ---, mirko, Pushed to Master , t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
14:58 Joubu tuxayo: in Koha/Object[s].pm:
14:58 Joubu - Koha::Exceptions::Object::MethodNotCoveredByTests->throw( "The method $method is not covered by tests!" ) unless grep {/^$method$/} @known_methods;
14:58 Joubu + Koha::Exceptions::Object::MethodNotCoveredByTests->throw( error => "The method $method is not covered by tests!", show_trace => 1 ) unless grep {/^$method$/} @known_methods;
14:58 Joubu and try again, you will see a stack trace
14:59 Joubu maybe not, I have a patch somewhere but I do not find it
15:06 tuxayo Joubu: thanks, I indeed have a stacktrace now.
15:06 tuxayo /me tries to understand it
15:09 pastebot "tuxayo" at 127.0.0.1 pasted "testing bug 20724" (21 lines) at http://paste.koha-community.org/39
15:09 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 critical, P5 - low, ---, jonathan.druart, Needs Signoff , ReservesNeedReturns syspref breaks "Holds awaiting pickup"
15:10 * tuxayo failed
15:10 oleonard Bug 20756
15:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 trivial, P5 - low, ---, oleonard, Needs Signoff , OPAC "Share list" button should be styled with an icon
15:11 tuxayo Well, I can start dumping vars on strategic places at least.
15:15 reiveune bye
15:27 huginn News from kohagit: Bug 20404: Fix Patrons/Import.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=46b648545470bcd39d751bff0709c0ec6d79e041>
15:27 huginn News from kohagit: Bug 20764: Rename the test file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3a125dfb9144ae4165d9790121db1ed3b7129dc4>
15:27 huginn News from kohagit: Bug 20764: (QA follow-up) Fix path to sample plugins <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3523a01a07381a701375b81d540e325559449aae>
15:31 Guest2474 Project Koha_Master_D8 build #479: ABORTED in 2 min 47 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/479/
15:31 Guest2474 * Tomás Cohen Arazi: Bug 20764: (QA follow-up) Fix path to sample plugins
15:31 Guest2474 * Jonathan Druart: Bug 20764: Rename the test file
15:31 Guest2474 * Jonathan Druart: Bug 20404: Fix Patrons/Import.t
15:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20764 normal, P5 - low, ---, mirko, Pushed to Master , t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
15:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20404 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Extended patron attributes should always be on
15:37 huginn News from kohagit: Bug 20764: (follow-up) Rename the test file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bdad7aec0e34c81c7eb02a2de7552c4a03998a62>
15:39 Joubu khall: could you take care of bug 20766?
15:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20766 major, P5 - low, ---, chris, NEW , KohaPlugins.t does not clean up
15:40 khall I'll take a look!
15:40 Joubu thx
16:06 Guest2474 Project Koha_Master_D8 build #480: STILL UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D8/480/
16:06 Guest2474 Jonathan Druart: Bug 20764: (follow-up) Rename the test file
16:06 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20764 normal, P5 - low, ---, mirko, Pushed to Master , t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
16:07 Joubu tcohen: "koha_1 | Database is not empty! at /kohadevbox/misc4dev/populate_db.pl line 95." ^
16:09 huginn News from kohagit: Bug 20764: Fix Plugins.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3422a0d93eb2ac607b9deee57f9e5c034907c839>
16:19 Joubu tcohen: ha, it looks like the "initial cleanup" and "post cleanup" steps in the jenkins config are not the same. So when a job is aborted, the next one will not start on a clean base
16:19 Joubu (`docker rm` was missing)
16:20 bag morning
16:30 oleonard Hi bag
16:31 bag heya oleonard
16:31 wahanui oleonard is still here, if you just wish hard enough. or Koha's master UI designer
16:43 tuxayo bye #koha o/
16:46 Guest2474 Yippee, build fixed!
16:46 wahanui o/ '`'`'`'`'`'`'`'`'`
16:46 Guest2474 Project Koha_Master_D8 build #481: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/481/
16:46 Guest2474 Jonathan Druart: Bug 20764: Fix Plugins.t
16:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20764 normal, P5 - low, ---, mirko, Pushed to Master , t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
16:57 tcohen Joubu: thanks for fixing the jenkins task
17:05 Joubu tcohen: FYI bug 20767
17:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 normal, P5 - low, ---, jonathan.druart, Needs Signoff , "The method is not covered by tests!" should give more information
17:08 tcohen I always hated that message
17:42 tcohen what does 'not covered by tests' means, and why isn't just 'is not defined'?
17:44 tcohen @later tell drojf have you noticed https://gitlab.com/tomascohen/koha-dpkg-docker
17:44 huginn tcohen: The operation succeeded.
17:44 tcohen @later tell mtj have you noticed https://gitlab.com/tomascohen/koha-dpkg-docker
17:44 huginn tcohen: The operation succeeded.
17:45 mtompset #koha
17:45 mtompset Greetings, #koha.
17:45 bag heya mtompset
17:45 wahanui mtompset is back to working on Koha stuff for a bit.
17:45 mtompset @seen tcohen
17:45 huginn mtompset: tcohen was last seen in #koha 1 minute and 7 seconds ago: <tcohen> @later tell mtj have you noticed https://gitlab.com/tomascohen/koha-dpkg-docker
17:46 mtompset @later tell tcohen I was just about to start tinkering with your dockerized koha stuff. :)
17:46 huginn mtompset: The operation succeeded.
17:46 mtompset Greetings, bag
17:49 mtompset What's new with you, bag?
17:50 bag It’s finally warm/hot outside
17:51 bag so I’ve put some grateful dead music on
17:52 oleonard @wunder 45701
17:52 huginn oleonard: Athens, OH :: Scattered Clouds :: 84F/29C | Heat Index: 87F/31C | Monday: A chance of some strong thunderstorms. Storms could contain damaging winds. High 88F. Winds SW at 5 to 10 mph. Chance of rain 50%. Monday Night: Some clouds. A stray shower or thunderstorm is possible. Low 66F. Winds SSW at 5 to 10 mph.
17:53 bag strong thunderstorms
17:53 bag yeesh
18:07 magnuse @wunder bodø, norway
18:07 huginn magnuse: Error: I could not find a valid location for: bodø, norway
18:07 magnuse @wunder bodo, norway
18:07 huginn magnuse: Bodo, Norway :: Scattered Clouds :: 64F/18C | Monday: Mainly cloudy. Lows overnight in the upper 40s. Monday Night: Partly cloudy skies early will give way to cloudy skies late. Low 49F. E winds shifting to W at 10 to 15 mph.
18:08 magnuse summer!
18:08 wahanui summer is here now
18:26 mtompset magnuse, it's almost like spring decided to be compressed to a week.
18:26 bag @wunder 97215
18:26 huginn bag: Portland, OR :: Clear :: 69F/21C | Monday: Sunny. High 88F. Winds light and variable. Monday Night: Clear to partly cloudy. Low 56F. Winds light and variable.
18:26 mtompset Had some nasty wind storms the other weekend.
18:26 bag magnuse HI!!!!
18:26 magnuse bag: HI
18:26 mtompset @wunder bolton, canada
18:26 huginn mtompset: Bolton, Quebec :: Light Snow :: 15F/-10C | : :
18:26 mtompset No... wrong province, silly.
18:27 mtompset @wunder L7E 5Y5
18:27 huginn mtompset: Error: I could not find a valid location for: L7E 5Y5
18:27 mtompset @wunder L7E5Y5
18:27 huginn mtompset: Error: I could not find a valid location for: L7E5Y5
18:27 caroline I was surprised you were in quebec!
18:27 mtompset @wunder brampton
18:27 huginn mtompset: Brampton, Ontario :: Mostly Cloudy :: 75F/24C | Monday: Partly cloudy. High 78F. Winds SW at 10 to 15 mph. Monday Night: Partly cloudy skies this evening will give way to cloudy skies and rain overnight. Thunder possible. Low 59F. Winds W at 5 to 10 mph. Chance of rain 90%.
18:27 mtompset @wunder orangeville
18:27 huginn mtompset: Orangeville, Ontario :: Partly Cloudy :: 77F/25C | Monday: Partly cloudy. High 72F. Winds WSW at 10 to 15 mph. Monday Night: Partly cloudy skies this evening will give way to cloudy skies and rain overnight. Thunder possible. Low near 55F. Winds W at 5 to 10 mph. Chance of rain 90%.
18:27 mtompset @wunder nobleton, canada
18:28 huginn mtompset: Nobleton, Ontario :: Mostly Cloudy :: 73F/23C | Monday: Partly cloudy. High 77F. Winds SW at 10 to 15 mph. Monday Night: Partly cloudy skies this evening will give way to cloudy skies and rain overnight. Thunder possible. Low 57F. Winds W at 5 to 10 mph. Chance of rain 90%.
18:28 mtompset @wunder caledon, canada
18:28 huginn mtompset: Caledon, Ontario :: Mostly Cloudy :: 75F/24C | Monday: Partly cloudy. High 72F. Winds WSW at 5 to 10 mph. Monday Night: Partly cloudy skies this evening will give way to cloudy skies and rain overnight. Thunder possible. Low near 55F. Winds W at 5 to 10 mph. Chance of rain 90%.
18:28 magnuse @wunder nuuk
18:28 huginn magnuse: Nuuk, Greenland :: Mostly Cloudy :: 30F/-1C | Wind Chill: 23F/-5C | Monday: Partly cloudy. Lows overnight in the mid 20s. Monday Night: Considerable clouds this evening. Some decrease in clouds late. Low around 25F. Winds ESE at 5 to 10 mph.
18:28 * mtompset grumbles about Bolton's lack of visibility, because of Google's Caledon vs Bolton mistake!
18:29 magnuse @wunder thule
18:29 mtompset -5?!
18:29 huginn magnuse: Thule Air Base, Greenland :: Clear :: 33F/1C | Wind Chill: 29F/-2C | Monday: Mostly clear. Lows overnight in the low 20s. Monday Night: A few passing clouds. Low 23F. Winds SSE at 5 to 10 mph.
18:29 * magnuse is not in greenland
18:53 * magnuse wanders off
18:59 * oleonard is not in greenland
18:59 * oleonard wanders off
19:12 Joubu kidclamp: the random failure on 17.11 is fixed by bug 20721
19:12 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20721 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Circulation.t keeps failing randomly
19:13 kidclamp thnaks, I knew i had seen that
19:16 mtompset @later tell tcohen Just had problems with the koha-testing docker... complaining about apache modules. I didn't try to run tests after that noise.
19:16 huginn mtompset: The operation succeeded.
19:16 tcohen mtompset: ?
19:17 tcohen I don't see any problems
19:17 tcohen maybe you haven't cleaned up?
19:17 tcohen are you trying to rebuild the image?
19:17 mtompset cleaned up what?
19:17 mtompset I followed the read me.
19:17 tcohen docker containers already running
19:17 mtompset This was from scratch.
19:18 pastebot "mtompset" at 127.0.0.1 pasted "issues" (21 lines) at http://paste.koha-community.org/42
19:19 pastebot "mtompset" at 127.0.0.1 pasted "earlier noise." (18 lines) at http://paste.koha-community.org/43
19:21 mtompset I initially did the -p koha and got similar messages.
19:21 mtompset So I pressed CTRL+C once to stop it gracefuly, and then did it with kohadev.
19:21 mtompset same messages.
19:21 mtompset docker-compose -p kohadev up
19:21 mtompset This does a build if it wasn't built in the first place.
19:22 mtompset Perhaps the initial build for koha is influencing the kohadev attempt?
19:22 * mtompset doesn't like containers.
19:26 tcohen mtompset: ctrl+c is nothing but gracefuly
19:26 tcohen docker ps —filter status=exited
19:29 Joubu sounds like you will have to update the readme :D
19:41 tcohen mtompset: it shouldn't build, as it is pointing to a remotely served image
19:41 tcohen maybe you passed -f docker-compose-build.yml ?
20:17 * andreashm waves
20:48 drojf koha 18.05.00 rc1 package done & email sent. good night #koha
21:10 huginn News from kohagit: Bug 17084: Automatic debian/control updates (master) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=856d48016b853cac1c34e723628e52806fbc3d43>
21:28 Joubu @later tell fridolin I think you should revert 20234 from 17.05.x
21:28 huginn Joubu: The operation succeeded.
22:13 mtompset tcohen, Nope. I typed what was in the readme.
22:14 * mtompset gives Joubu the evil eye over his update the readme comment. :P
23:28 mtompset Oh, I think I may have stumbled down the correct install path... we'll see.
23:37 mtompset and a minor tweak to the Dockerfile to see if I can coax it further.