Time  Nick       Message
06:23 reiveune   hello
07:07 gaetan_B   hello
07:07 wahanui    hi, gaetan_B
07:44 tuxayo     hi #koha o/
08:04 cait       good morning #koha!
08:17 cait       I guess most of Europe is on holiday today :)
08:18 tuxayo     cait: really?
08:18 wahanui    really is more trouble than she's worth.
08:18 cait       oh, no holiday in france?
08:18 tuxayo     shouldn't you be in holiday in Germany?
08:18 tuxayo     cait: no
08:18 cait       i am on holiday, just choosing to make it a qa day :)
08:19 cait       we are getting close to release time!
08:20 tuxayo     cait: you have strange hobbies :P
08:20 tuxayo     Do you like marking patches as failed QA that much?
08:21 eythian    cait: no holiday here too
08:22 cait       I tihnk i already otld you yesterday that you picked the wrong country ;)
08:22 cait       tuxayo: don't tempt me ;)
08:33 cait       but if you look at the stats on the dashboard, you see I am not only failing
09:11 tuxayo     cait: indeed :D
09:11 tuxayo     great numbers there!
09:11 tuxayo     cait++
09:43 cait       @later tell tcohen Can https://wiki.koha-community.org/wiki/REST_api_RFCs be updated for patrons now and possible others? Which are the next you need a comment on?
09:43 huginn     cait: The operation succeeded.
10:13 kidclamp   cait ping
10:19 cait       pong! :)
11:01 cait       alex_a: around?
11:02 alex_a     cait: yep
11:02 cait       could you take another look at bug 20385?
11:02 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 major, P5 - low, ---, nick, Signed Off , ElasticSearch authority search raises Software error
11:02 cait       nick just passed the dependent patch for unimarc auth, so we need to resolve this one too :)
11:03 alex_a     cait: do it after lunch
11:03 alex_a     :)
11:03 cait       thank you!
12:08 cait       hi oleonard :)
12:12 oleonard   Hi cait
12:17 oleonard   cait: When testing 19474 and/or 20427 remember that you shouldn't apply the compiled CSS patches. Skip them and regenerate the CSS via the yarn build commands.
12:17 cait       ok!
12:17 cait       :)
12:17 oleonard   Thanks!
12:17 cait       i had indeed not thought about that
12:23 cait       oleonard: I CC'd you on a patch for highlighting
12:26 cait       oleonard: patches apply now, testing :)
12:28 cait       oleonard: should I worry about that? [12:27:40] gulp-autoprefixer:
12:28 cait       autoprefixer: /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.css:897:3: Gradient has outdated direction syntax. New syntax is like `to left` instead of `right`.
12:28 oleonard   It's a coding-style warning, so it's not dangerous. I hope to resolve it but can't seem to figure out what is triggering it.
12:35 cait       oleonard: found a small thing i think
12:36 cait       the suggestio message at the bottom of the result list
12:36 cait       there is a list style point
12:36 cait       but that's really the only thing i have spotted so far, can you confirm?
12:36 * oleonard digs a hole and climbs into it
12:36 cait       huh?
12:36 oleonard   I can't here you down here in the pit of shame
12:37 cait       it feels a little like you might be overreacting
12:37 cait       unless i missed something really huge and then I should be down there
12:39 eythian    geez oleonard. I thought better of you.
12:39 eythian    Look what you've gone and done.
12:41 oleonard   cait: I confirm.
12:42 cait       want to throw in a quick followup?
12:42 cait       i am done otherwise and happy
12:42 cait       ok, i found a bug in course reserves... but that's just the usual :)
12:42 cait       poking at something and finding a completely unrelated problem
12:43 cait       hello jenkins, did you sleep in too?
12:43 cait       brb
12:46 * oleonard climbs out of his hole and fills it back in
12:46 oleonard   cait: What you see is also in master.
12:59 cait       oleonard-away: lol ok :)
12:59 cait       pqa!
13:06 oleonard   <3
13:22 cait       oleonard: can you remind me of the bug with the missing screenshot from me?
13:23 oleonard   Bug 20044
13:23 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, Failed QA , Switch single-column templates to Bootstrap grid: Cataloging
13:29 cait       alex_a++ khall++ kidclamp++ thx all :)
13:29 alex_a     cait++
13:29 alex_a     (for the reminder)
13:29 cait       :)
13:29 cait       maybe Bug 19581   next? :)
13:32 alex_a     cait: i'll take a look asap
13:32 nlegrand   $ curl http://bouse02.prive.bulac.fr:9200/_cat/indices?v
13:32 nlegrand   health status index              uuid                   pri rep docs.count docs.deleted store.size pri.store.size
13:32 nlegrand   yellow open   koha_robin_biblios vFgnihNqQy2bvKBiLmlwpw   5   1    1060274            0     10.4gb         10.4gb
13:33 cait       alex_a: another candidate for you is Bug 19575        - Use canonical field names and resolve aliased fields - nick signed off, so he is out
13:34 nlegrand   We made some test with our catalog loaded in ES, the results are : indexing is faster, it takes less space on disks and we find more stuffs than before.
13:34 nlegrand   It's not perfect, but it is far better :).
13:34 cait       the right stuffs too?
13:35 nlegrand   cait: not always, we find that searching with quotes gave more accurate results.
13:35 cait       with zebra or with elastic?
13:35 nlegrand   kidclamp: you remember your problem with chinese ?
13:36 nlegrand   cait: with ES
13:37 alex_a     cait: put it on my to do list
13:37 nlegrand   cait: also, our Zebra was not that well tuned.
13:45 cait       alex_a: cool thx!
13:46 cait       nlegrand: i think it might work a little better with marc21, but not sure (zebra)
13:57 alex_a     kidclamp: around?
13:58 kidclamp   sort of
13:58 kidclamp   gimme a few
14:03 cait       We got a question about a possible change in behavour with lost editing (make it consistent) on bug 19974  - would be great to get some additional feedback
14:05 nlegrand   kidclamp you remember your bug with chinese? Putting "" around cures it.
14:05 kidclamp   weird nlegrand
14:07 kidclamp   whats up alex_a?
14:07 nlegrand   curl -H 'Content-Type: application/json' -d '{ "query": {"match": { "title" : "中國翻譯"}}}' find it. If I search in Koha form without quotes, is find nothing.
14:08 nlegrand   *finds
14:09 kidclamp   so maybe we just need to look at how we build the query that was pass
14:09 alex_a     kidclamp: do you know if there is a limit in elasticsearch to the weight we can pass on fields ?
14:09 alex_a     Did'nt find anything in the ES doc
14:11 kidclamp   I don't know of any limit, I think boost values can be arbitrary
14:13 nlegrand   no limit is not something to put in the hands of librarians :)
14:14 tuxayo     cait around?
14:15 cait       yep
14:18 alex_a     kidclamp: thx
14:20 * tuxayo   sent a long message: tuxayo_2018-03-30_14:20:38.txt <https://matrix.org/_matrix/media/v1/download/matrix.org/ErJuuHPQEOQidfVUayGwXaoq>
14:20 tuxayo     oups
14:21 tuxayo     I guess it triggered the long message behavior so I'll fragment it.
14:21 tuxayo     cait I think I've done everything which had to be done before submitting bug 12310 for sign off.
14:21 tuxayo     My current patch is here: https://gitlab.com/tuxayo/Koha/commit/01cde5d3ce61a5db36fcf7d5e29636b670e4c3e5
14:21 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
14:21 tuxayo     The question is how to make the test plan shorter.
14:21 tuxayo     Can I add something like «you don't have to try every case for all the fields when having done a full pass on the 1st field» without compromising too the quality of the test plan?
14:29 cait       kidclamp: added naother comment to the lost bug, i think hte pref is misleading too
14:29 cait       tuxayo: taking a look now
14:30 tuxayo     thanks :)
14:30 cait       tuxayo: if you edit it, don't use → - they look strange on command line :)
14:30 Joubu      tcohen: you took care of jenkins, that's it?
14:30 Joubu      hi #koha
14:31 cait       hi Joubu!
14:31 Joubu      tcohen: koha_1       | [14:20:23] t/db_dependent/00-strict.t ..................................... ok   572524 ms
14:31 Joubu      should be o
14:31 Joubu      ok
14:32 cait       tuxayo: did you add currency smbols in acq?
14:32 tcohen     yes, updated the  koha-testing-docker image when received Mirko s email
14:33 Joubu      vs
14:33 Joubu      koha_1       | [21:33:00] t/db_dependent/00-strict.t ..................................... ok  1055848 ms
14:33 cait       tuxayo: i think i am alrady a bit confused about the changes :)
14:33 Joubu      before the speed improvement patches
14:33 cait       tuxayo: i'd probably split it
14:34 cait       make a start page for either acq or fines
14:34 cait       to demonstrate
14:34 cait       and then do the other module separately
14:34 cait       this will also shorten your test plan
14:35 tuxayo     cait: oh I love "→" but it must not look good on some fonts. Ok, I note the change.
14:35 tuxayo     «did you add currency smbols in acq»: no
14:36 cait       good :)
14:36 cait       for users we should have it, but in acq it will only clutter
14:36 cait       too many numbers there
14:36 Joubu      tuxayo: did you start already?
14:36 tuxayo     «make a start page» ? → start patch? → initial patch?
14:36 tuxayo     Joubu: start what?
14:37 cait       tuxayo: start with a small part, and listen to Joubu :)
14:37 Joubu      12310
14:37 kidclamp   always listen to Joubu, except when he is wrong
14:38 Joubu      tuxayo: you really (but really) should not fix alignement in your patches
14:38 Joubu      like:
14:38 Joubu      -        <input type="button" value="Save"  onclick="Check(this.form)" />
14:38 Joubu      +        <input type="button" value="Save" onclick="Check(this.form)" />
14:38 Joubu      or empty lines
14:38 Joubu      (merge conflicts)
14:40 Joubu      tuxayo: I think we should follow what I did on bug 4078 for the separator between the symbol and the amount
14:40 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Add the ability to customize and display the symbol for a currency
14:41 Joubu      it is also what we should do for the "display the symbol before or after the amount" setting (not implemented yet)
14:41 wahanui    okay, Joubu.
14:41 Joubu      it?
14:43 oleonard   cait: I guess we need to get more opinions on Bug 20044?
14:43 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, Failed QA , Switch single-column templates to Bootstrap grid: Cataloging
14:43 oleonard   Before: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73490
14:43 oleonard   After: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73489
14:43 jenkins    Yippee, build fixed!
14:43 wahanui    o/ '`'`'`'`'`'`'`'`'`
14:43 jenkins    Project Koha_Master_D8 build #414: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/414/
14:51 tuxayo     cait:
14:51 tuxayo     1. only fines is enough or too big?
14:51 tuxayo     2. What about «Can I add something like «you don't have to try every case for all the fields when having done a full pass on the 1st field» without compromising too much the quality of the test plan?»
14:51 tuxayo     Joubu:
14:51 tuxayo     3. fix alignment: can I split the alignment in another patch? Or is it a waste of time to try to fix alignment bit by bit compared to just ignore these issues?
14:51 tuxayo     4. Should alignment fixes be in the first or last patch? I suspect that there might be a trap there.
14:51 tuxayo     5. yes I started it, it's been almost 20 time I amend the code for refactoring or bug fixes ^^"
14:51 tuxayo     6. «I think we should follow what I did on bug 4078 for the separator between the symbol and the amount»
14:51 tuxayo     There is nothing specific about symbol is this patch. It just removes everything that is not a digit,-,or a separtor.
14:51 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Add the ability to customize and display the symbol for a currency
14:51 tuxayo     I'll rephrase the commit message to reflect ↑
14:52 Joubu      oleonard: did you take care of bug 19641 comment 27?
14:52 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move patron templates JavaScript to the footer
14:52 cait       only fines should be ok
14:52 cait       but please use normal quotes too :)
14:53 cait       it's ok to give examples on the test plan, you don't have to be extensive
14:53 oleonard   Sorry Joubu I missed that. I'll work on it.
14:53 cait       some can be left to testers
15:06 Joubu      khall, cait: about the TT syntax for notices, I think we should announce it ready (experimental) for 18.05 and then make the switch (new install use TT syntax as default) for 18.11, would you agree with that?
15:08 khall      Good plan joubu!
15:12 cait       sounds good
15:12 cait       i was trying to see how far we got, but was a bit lost
15:12 cait       is there stuff missing still?
15:12 Joubu      cait: I do not remember...
15:20 Joubu      tuxayo: sorry, lagging...
15:20 cait       Joubu: i didn't see something obvious, but probabl worht checking
15:20 cait       khall: could you draw up some basic examples for people ont he wiki maybe?
15:20 Joubu      3, 4. Do not fix alignement, only fix it if you are editing the line or working inside the block (can be subjective)
15:21 Joubu      most of the examples from the wiki can be found in the tests
15:21 Joubu      I have provided the equivalent TT syntax for them
15:21 Joubu      (that was the main goal of the "provide equivalent TT version" omnibus bug)
15:23 Joubu      tuxayo: just keep in mind: if it is relative to a currency (can be different from one currency to another) you need to add an attribute to the currency, not a syspref
15:25 Shane-S    Hi all, I keep trying to stay here and get answers but keeping getting pulled away so I am sorry if you answered me prior I missed them.
15:25 Shane-S    I have 12.20.02 and I going to build a new VM with 16.04LTS and packages so I assume the 17.11 install. Can I migrate the data easily?
15:26 cait       what is 12.20.02?
15:26 jenkins    Project Koha_Master_D8 build #415: UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/415/
15:26 Shane-S    Koha is 12.20.02
15:27 Shane-S    sorry, and I will use Ubuntu 16.04LTS on the new server and likely MariaDB
15:30 Shane-S    okay..I wrote something wrong....
15:30 Shane-S    Koha version:
15:30 Shane-S    Not sure where I got 12 from in my notes
15:31 cait       oh that's a big jump
15:32 cait       make sure you do this: https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix
15:32 Shane-S    yeah other projects kept pulling me away...it was broken stuff vs upgrading working stuff...so obviously they wanted broken things fixed
15:33 cait       and also check your dbms version against htese notes to see if you need to disable strict mode: https://wiki.koha-community.org/wiki/Koha_on_Debian#MySQL.7CMariaDB
15:33 Shane-S    Now Koha is semi broken, as a new record takes 5 minutes to add (likely because the drive is full)
15:34 cait       hm also should say you absolutely want to use debian packages
15:34 Shane-S    would it be easier to stick with MySQL or is the project transistion to MariaDB (since that is really where most the open source devs went to)?
15:35 cait       the problem exist with both dbms
15:35 Shane-S    okay
15:35 cait       sql strict mode doesn't fully work well with koha yet
15:35 Joubu      cait: it's fixed in latest versions
15:35 cait       Joubu: are they available yet for the lts?
15:35 Joubu      since bug 20229 we do no longer need to change the config file
15:35 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 major, P5 - low, ---, jonathan.druart, Pushed to Master , Remove problematic SQL modes
15:36 cait       aah
15:36 cait       nice
15:36 Joubu      ho, not backported
15:36 cait       but that's not in 17.11
15:36 Joubu      sorry, I thought it was
15:36 cait       Shane-S: read both pages carefully and do that why say - it will save you trouble :)
15:37 Shane-S    and basically all I need is the stuff in the backup folder to migrate?
15:38 cait       you need your database dump
15:38 cait       if that's in the backup folder :)
15:40 Shane-S    I haven't been on the server in ages...I honestly forget...I attempted this process last summer..but go pulled into a phone system install that never ended
15:41 Shane-S    oh busy weekend and week ahead
15:41 Shane-S    time to go build the base VM ty cait
15:44 tuxayo     cait:
15:44 tuxayo     11. «please use normal quotes» where do I use not-normal quotes?
15:44 tuxayo     12. «it's ok to give examples on the test plan, you don't have to be extensive»
15:44 tuxayo     ok I'll say that it's just a list of examples and that they don't have to be tried on each field
15:45 tuxayo     Joubu:
15:45 tuxayo     13. Oh, we never fix alignment not directly related to our code even in a separate patch? Ok it's simpler but I'll will have to hold myself back ^^"
15:45 tuxayo     14. «if it is relative to a currency you need to add an attribute to the currency, not a syspref»
15:45 tuxayo     I don't get it, there is nothing directly related to a currency. It just clean the field from everything not in the folowing example "-1,234.56"
15:48 Joubu      tuxayo: alignment fixes can only be done if you are sure you will not create conflict with several patches waiting in bugzilla
15:49 Shane-S    apparently I did a migration...but never fully tested it...lol I have my data in 16.11.03 in a VM that was off.
15:49 Shane-S    Is there a way to enable apt-get to auto-update Koha packages or is that not recommended?
15:50 cait       Shane-S: some do oher don't
15:50 cait       we don't do automatic updates
15:50 cait       tuxayo: imeant these »
15:50 Joubu      tuxayo: you could imagine a system used by people using different currencies
15:50 cait       i recently looked at a patch that i could hardly read in git because of lots of special characters, just passing this on to you now :)
15:51 Joubu      do you want the input method be system-wise or depending on the currency you are using to "input numbers"?
15:51 cait       Joubu: i don't this can work currency wise
15:52 cait       global should be ok, we only have one active currency
15:52 cait       i had suggested to bind it to the display format we have, but people insisted on allowing as many variations as possible, so that's why we eneded up with a pref
15:52 cait       so you could allow to use decimal . and decimal , both at the same time
15:54 Joubu      that the point, if you are entering $12.345 or $12,345 you will never know what you are entering
15:54 Joubu      imagine you copy/paste prices from an invoice
15:55 Joubu      but ok, it was just for discussion. We could start with a syspref
15:55 Joubu      my guess it that the problem is more complex than just a syspref
15:56 Shane-S    ? will Koha packages install MySQL or MariaDB if I don't have it pre-installed?
15:58 Joubu      gaetan_B: opinion on bug 19974?
15:58 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 normal, P5 - low, ---, charles.farmer, In Discussion , Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)
16:01 gaetan_B   Joubu: currently reading
16:01 * gaetan_B would happily get rid of the "items" tab
16:03 gaetan_B   i definitely agree this looks like a long standing bug that has to be fixed
16:03 gaetan_B   i wasn't even aware of this actually...
16:03 tuxayo     cait: Oh even in IRC these quotes are causing issues? T_T
16:04 tuxayo     Joubu: «you could imagine a system used by people using different currencies»
16:04 tuxayo     How is that impacted by bug 12310?
16:04 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
16:06 Joubu      I tried to explain: 12,345 vs 12.345. Forget about that and start with a pref if you think it's enough
16:07 cait       sorry off for a bit
16:10 gaetan_B   Joubu: i made a suggestion
16:12 gaetan_B   ok i'm leaving for the weekend, happy easter ! 🔔🐰
16:16 huginn     News from kohagit: Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=08039f41c196f9119e5ca82f762e5260d8c81a1a>
16:27 reiveune   bye
16:33 * LeeJ     waves
16:33 LeeJ       hi #koha
16:43 * cait     waves
16:49 tuxayo     Joubu: Oh I get it now. Unfortunately we can't use the currency symbol to deduce the format and replace the new syspref.
16:49 tuxayo     Cause: on the same instance, for inputting the same currency. Depending on the keyboard/locale settings and habits (the numpad inputs a dot even in france) and the nationality of the librarians. Some will use dots and other comas.
16:51 tuxayo     Joubu: Cait: thanks for all your feedback :) Hopefully the next time the patch will be ready for real!
16:55 jenkins    Project Koha_Master_D8 build #416: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/416/
16:55 jenkins    Jonathan Druart: Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly
16:55 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20503 minor, P5 - low, ---, jonathan.druart, Pushed to Master , Borrower_PrevCheckout.t  is failing randomly
16:55 tuxayo     cait: about https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818#c9
16:55 tuxayo     "Please make your changes in a follow-up." (huh, ugly quotes :P )
16:55 huginn     Bug 19818: enhancement, P5 - low, ---, zoebennett1308, ASSIGNED , Add id into tag html from moremember.tt
16:55 tuxayo     Do you mean a follow up patch or follow up bugzilla?
17:08 Joubu      jenkins: you drive me crazy!
17:08 jenkins    Joubu you may not issue bot commands in this chat!
17:11 tuxayo     lol
17:11 tuxayo     bye #koha!
17:21 georgew    I'm hanging out with LeeJ in the jitsi room for his Koha documentation webinar and right now we're the only two there
17:21 georgew    anyone else want the link?
17:23 cait       is there video? :)
17:23 georgew    yes
17:24 georgew    the link is https://meet.jit.si/KohaDocsTeam
17:31 cait       thx georgew
20:08 bag        http://kohacon2018.bywatersolutions.com/
20:25 davidnind  bag: nice! really nice!
20:26 bag        :D