Time  Nick        Message
02:20 aleisha_    we have a few patches coming through from the academy now and would love some signoffs if anyone is around!
02:20 aleisha_    bug 19831 from charlotte
02:20 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Turn on EnhancedMessagingPreferences by default for new installations
02:33 aleisha_    bug 18878 from grace_
02:33 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Improve item form display / labels too far from input fields
03:10 aleisha_    bug 19818 from zoebennett
03:10 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add id into tag html from moremember.tt
03:23 aleisha_    bug 18083 from terauhina
03:23 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 enhancement, P5 - low, ---, oleonard, Needs Signoff , Don't show 'library' selection on popular titles page for single-branch libraries
03:32 aleisha_    bug 17869 from grace_
03:32 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 enhancement, P5 - low, ---, oleonard, Needs Signoff , Don't show pick-up library for holds in OPAC account when there is only one branch
03:51 aleisha_    bug 19856 from jenny
03:51 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Improve styling of reports sidebar to match tools sidebar
03:51 aleisha_    bug 19839 from grace_
03:51 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 minor, P5 - low, ---, koha-bugs, Needs Signoff , invoice.pl warns about bad variable scope
04:04 aleisha_    bug 17682 from charlotte
04:04 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 minor, P5 - low, ---, koha-bugs, Needs Signoff , Change URL for Google Scholar in OPACSearchForTitleIn
07:35 reiveune    hello
07:44 alex_a      bonjour
07:44 wahanui     que tal, alex_a
07:50 magnuse     ~~~
08:19 fridolin    hi there
08:24 tuxayo      hi #koha \o
08:38 * andreashm waves
08:43 tuxayo      Hi, I can't find in the coding guidelines the conventions for HTML ids. Is there at least a non-written one?
09:23 * cait1     waves
09:29 andreashm   hi cait1
10:26 cait1       magnuse: around?
10:26 magnuse     yup
10:27 cait1       do you have a moment for talking ILL?
12:17 saa         we have a collection of books which is around 1 lakh 50 thousand we did stock verification and we were trying to upload inventory txt file in koha web interface but after some time the error we get is timed out. we had asked this query earlier is there any way to handle it
12:17 saa         we will have to update our koha item status
12:19 kidclamp    saa - you may need to increase the timeout on the server, I would also doulbe check items if you can, sometimes the job will continue and finish while just the results page is not returned
12:20 saa         is there any way i can upload in small files
12:20 saa         would that be fine
12:23 tcohen      morning
12:26 kidclamp    breaking the file should be fine, filtering to smaller sections when comparing to barcodes scanned should make things run faster.
12:30 saa         gr8 tx
12:31 tcohen      khall: do you think we could go a declarative way for RO K::O?
12:31 tcohen      like explicitly mentioning somewhere
12:32 tcohen      the allowed methods
12:32 tcohen      in RO context?
12:32 khall       if you have an idea of how to accomplish that I'd love to see it!
12:33 khall       I'd suggest we make this list of methods permissive, that is, disallow a specific list of methods. A blacklist instead of a whitelist
12:33 khall       you could store it in a package var
12:33 khall       is that what you are thinking?
12:34 tcohen      yes
12:34 khall       yeah, that sounds good. Would you then check it in a BEGIN block or something? I don't think BEGIN is appropriate but I bet there is something available
12:35 tcohen      the problem is the overhead
12:35 tcohen      ah, no
12:35 tcohen      that's why we want a RO flag
12:35 tcohen      true => check
12:35 tcohen      false => don't care
12:35 oleonard    Hi all
12:36 tcohen      hi oleonard!
12:36 wahanui     hi olé onard
12:36 kidclamp    morning oleonard
12:37 khall       tcohen: that only issue I see is that the flag would need to 'cascade' to any related objects. If you have an idea for implementing that I'm all for it!
12:38 tcohen      we could add ->find and ->search a RO param
12:43 tcohen      khall: add a ro attribute to Koha::Object
12:43 tcohen      declare athe blacklist
12:44 tcohen      and have ->find and ->search query accept the RO param (implicitly)
12:45 khall       tcohen: that works for me! If you can submit a patch I'll test and sign!
12:45 tcohen      my $patrons_set = Koha::Patrons->new({ ro => JSON::true });
12:45 tcohen      $patrons_set->search({ blah })
12:50 tcohen      Joubu
12:50 tcohen      ?
13:01 Joubu       RO?
13:03 kidclamp    Read only
13:04 Joubu       I do not have the context to understand what you are talking about then
13:42 cait1       tcohen: kidclamp: are any of cou available to qa some academy patches?
13:42 cait1       should be fast work
13:43 cait1       bug 17682, bug 18878
13:43 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 minor, P5 - low, ---, charlotte.cordwell123, Signed Off , Change URL for Google Scholar in OPACSearchForTitleIn
13:43 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 enhancement, P5 - low, ---, gracesmythh, Signed Off , Improve item form display / labels too far from input fields
13:44 kidclamp    taking a look cait1
13:44 cait1       thx :)
13:59 kidclamp    oleonard, can you look at bug 18878 - I jind of prefer the alignment of the subfield codes right now - if they move over I would think we should change to "Description of field - {code} " so that those are still aligned
13:59 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 enhancement, P5 - low, ---, gracesmythh, Signed Off , Improve item form display / labels too far from input fields
13:59 oleonard    I will look
14:00 cait1       don't hit me if you don't like the idea :)
14:02 kidclamp    heh, cait1, my opinions are often odd. Maybe implies somehting about me...
14:04 cait1       i don't think they are odd :) but the students implemented a suggestion from me, so feeling slightly guilty you don't like it
14:05 kidclamp    I just can't decide which is better, I defer to Owen, he has a better sense of 'correct'
14:05 oleonard    I'm ambivalent.
14:05 cait1       he understands the problem but doesn't like the solution ;)
14:06 cait1       for what it's worth... ours never seemt o notice the subfield codes
14:06 cait1       they don't relate to them really
14:08 oleonard    I think the decision should be based on existing interface patterns, which means that right alignment is more consistent.
14:08 oleonard    (as cait1 points out in the bug report)
14:08 cait1       could we move text and field closer together without the change? word lengths vary with translations
14:08 oleonard    kidclamp: Let me experiment a little before you move on this one
14:09 kidclamp    kk
14:09 cait1       i think there are some more bugs from the students with changed date today in the queue
14:10 cait1       woudl be cool if they got back our tonight to see some progress
14:12 jenkins     Project Koha_17.05_D8 build #64: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_17.05_D8/64/
14:12 jenkins     * Jonathan Druart: Bug 19830: Add the Koha::Patron->old_checkouts method
14:12 jenkins     * Jonathan Druart: Bug 19599: Speed anonymise_issue_history up
14:12 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Add the Koha::Patron->old_checkout method
14:12 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 major, P5 - low, ---, jonathan.druart, RESOLVED FIXED, anonymise_issue_history can be very slow on large systems
14:15 Joubu       fridolin: seen that? ^
14:15 wahanui     I haven't seen 'that', Joubu
14:15 fridolin    Joubu: arf
14:15 Joubu       I asked fridolin, not you wahanui
14:15 fridolin    i had tested Patron.t is worked
14:16 fridolin    xt_author_valid_templates_t ah
14:26 fridolin    Joubu: thanks for the warning, I revert Bug 19514
14:26 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 major, P3, ---, alexbuckley, RESOLVED FIXED, No Password restrictions in onboarding tool patron creation
14:26 fridolin    it depends on a new 17.11 feature
14:34 Joubu       thank the tests :)
14:35 oleonard    kidclamp: I don't think there's a better way to handle that form without maybe doing a more drastic overhaul. I'd go ahead with the patch as-is
14:35 kidclamp    kk
14:35 kidclamp    oleonard++
14:55 * LeeJ      wave
14:55 * LeeJ      waves
14:56 LeeJ        hi #koha
15:07 jenkins     Yippee, build fixed!
15:07 wahanui     o/ '`'`'`'`'`'`'`'`'`
15:07 jenkins     Project Koha_17.05_D8 build #65: FIXED in 36 min: https://jenkins.koha-community.org/job/Koha_17.05_D8/65/
15:07 jenkins     * fridolin.somers: Revert "Bug 19514: Implement password restrictions into onboarding tool"
15:07 jenkins     * fridolin.somers: Revert "Bug 19514: Add client-side check"
15:07 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 major, P3, ---, alexbuckley, RESOLVED FIXED, No Password restrictions in onboarding tool patron creation
15:08 fridolin    saved piouf
15:08 fridolin    wahanui: no comment ?
15:08 wahanui     i don't know, fridolin
15:08 fridolin    then go to sleep ;)
15:22 * oleonard  whispers Bug 19474
15:22 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 enhancement, P5 - low, ---, oleonard, Needs Signoff , Convert staff client CSS to SCSS
16:25 oleonard    I am a template patch dependency monster. Stop me before I entangle again.
16:26 oleonard    P.S. Stop me by signing off on patches, or shooting me with lasers.
16:51 cait1       oleonard: hmmm
16:51 cait1       :)
16:51 cait1       oleonard: don't forget to mark them academy if it is a good one for them
16:51 cait1       it's this week
16:51 oleonard    They're doing signoffs?
16:52 cait1       did some last night :)
16:52 cait1       well... during their day
16:52 cait1       http://scoreboard.koha-community.org/
16:52 oleonard    Cool. I thought I heard someone doing signoffs last night. The racket was keeping me awake.
17:00 vfernandes  hi #koha
17:06 oleonard    Hi vfernandes
17:11 vfernandes  i'm using Koha with ElasticSearch but i'm getting one strange behaviour
17:12 vfernandes  when I use koha database user for one record/authority change, the change automatically shows on search results (immediate reindex)
17:13 vfernandes  when using another users the change isn't immediate
17:13 vfernandes  ElasticSearch needs a cronjob for this cases?
17:14 cait1       hm you shoul dnever use the db user
17:14 cait1       but it shoudl not make a difference, that's a bit confusing, i'd expect problems with the db user not the other way around
17:14 cait1       kidclamp: ?
17:16 kidclamp    hum...it shouldn't matter the user, changes should be instantaneous either way - ModZebra just does them right awya with ES i htink
17:16 vfernandes  cait1: I know that I shouldn't use the db user, it was only for debugging
17:18 Joubu       even for debugging :)
17:21 vfernandes  wait... I found the problem
17:21 vfernandes  this bug is already corrected on Koha GIT code
17:22 vfernandes  ModZebra on AuthoritiesMarc.pm is incorrectly invoked in my Koha version
17:22 cait1       hm staff can see search history in opac, but patron can not... preferences are both turned on... any ideas?
17:24 cait1       hm and it's true... can't access the search history even if it's turend on (
17:25 cait1       flagsrequired => {borrowers => 1}, ?? or opac-search-history.pl
17:25 * cait1     looks at joubu
17:25 cait1       Joubu
17:28 Joubu       bug 12497
17:28 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 minor, P5 - low, ---, victor.grousset, Pushed to Stable , Make OPAC search history feature accessible when it should
17:28 Joubu       cait1: ^
17:28 cait1       sorry, just found it
17:28 cait1       seems chris didn't pick it
17:28 cait1       for 16.11.x
17:29 cait1       i will comment
17:30 cait1       Joubu++ #making up
17:34 reiveune    bye
18:35 kidclamp    bug 19985
18:35 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 normal, P5 - low, ---, koha-bugs, NEW , TestBuilder.t fails if default circ rule exists
18:44 Joubu       kidclamp: prove t/db_dependent/TestBuilder.t returns green here
18:44 Joubu       and select categorycode, itemtype, branchcode from issuingrules; return *, *, *
18:45 Joubu       ha sorry
18:45 Joubu       ok got it :)
19:03 LeeJ        if I were trying to query patron firstname/surname and I already have my $member = Koha::Patrons->find($borrowernumber); would I use my $surname = $member->{'surname'}? Sorry, first time really using find for queries
19:04 Joubu       my $patron = Koha::Patrons->find(42); say "Hello " . $patron->surname
19:04 Joubu       s/member/patron/g
19:05 LeeJ        ooooh
19:05 LeeJ        that's easy enough
19:06 LeeJ        haven't quite figured out how that new inheritance from Koha::Objects works yet
19:06 LeeJ        thanks Joubu
19:09 Joubu       columns of the table are considered as attributes of the object
19:20 mtompset    Greetings, #koha.
19:21 mtompset    @seen marcelr
19:21 huginn      mtompset: marcelr was last seen in #koha 1 day, 4 hours, 55 minutes, and 5 seconds ago: <marcelr> maybe you can find it on the wiki
19:21 mtompset    @seen Joubu
19:21 huginn      mtompset: Joubu was last seen in #koha 12 minutes and 10 seconds ago: <Joubu> columns of the table are considered as attributes of the object
19:22 mtompset    Are you still here, Joubu?
19:22 Joubu       yes
19:23 mtompset    I was tinkering with bug 19938 further
19:23 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 minor, P5 - low, ---, mtompset, In Discussion , Refactor C4::Overdues::checkoverdues
19:23 mtompset    And discovered some ugliness...
19:23 mtompset    search_utf8.t is language dependent.
19:23 mtompset    Have you encountered cases where you have French installed, and then the test breaks if you have it visible in the staff or opac?
19:26 Joubu       tests are still data dependent
19:27 mtompset    Data dependent isn't as bad as language dependent.
19:27 mtompset    Publisher: foobar
19:27 mtompset    If you can't find the word Publisher, because your language isn't English... the test fails.
19:28 Joubu       yes, the tests are data dependent
19:28 Joubu       they depend on the value of the pref "language"
19:54 Joubu       mtompset: it does not make it not necessary, it avoids useless calls to Koha::Holds->search and GetMemberAccountRecords
19:56 mtompset    re-reading code... You're right. Sorry.
19:56 mtompset    Yours is an optimization.
20:30 wizzyrea    kia ora
21:08 aleisha_    hello
21:08 aleisha_    more academy patches that we'd love signoffs on
21:09 aleisha_    bug 18661
21:09 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 enhancement, P5 - low, ---, gmcharlt, Needs Signoff , Make "Replace only included patron attributes" default on patron import
21:09 aleisha_    bug 18236
21:09 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 enhancement, P5 - low, ---, oleonard, Needs Signoff , Add classes to material type icons on result lists and detail pages
21:19 wizzyrea    *heart eyes*
21:20 * wizzyrea  waves to the students
21:50 grace_      waves back :)
21:51 wizzyrea    hi grace_ :D
21:52 grace_      hi liz :)
22:00 aleisha_    bug 19221
22:00 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 trivial, P5 - low, ---, koha-bugs, Needs Signoff , Onboarding tool says user needs to be made superlibrarian
22:13 wizzyrea    A+ I approve of that wording
22:14 gmcharlt    @wunder 30096
22:14 huginn      gmcharlt: Duluth, GA :: Overcast :: 47F/8C | Tuesday: Chance of snow showers early. Lows overnight in the upper teens. Tuesday Night: Mainly cloudy with snow showers around this evening. Low 17F. Winds WNW at 10 to 15 mph. Chance of snow 50%.
22:14 gmcharlt    DOOM
22:15 gmcharlt    or, at least, a 50% chance of... DOOM
22:15 wizzyrea    heh you better stay off the roads if it snows
22:15 wizzyrea    georgians probably go all kinds of silly
22:16 gmcharlt    yeah, it can be pretty... interesting on the roads
22:16 gmcharlt    oddly, there have been enough snow storms in Atlanta the past few years that I think folks are actually starting to get the hang of it
22:16 gmcharlt    climate change is weird
22:17 gmcharlt    as a heads up, huginn may be temporarily knocked offline overnight Eastern Time due to a mandatory reboot of its VM
22:17 gmcharlt    I'll make sure it gets back up to its appointed duties by the morning
22:24 aleisha_    bug 19188
22:24 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 trivial, P5 - low, ---, koha-bugs, Needs Signoff , Self checkout: missing space if fine amount is blocking renewal
22:33 wizzyrea    so many kittens
22:50 mtompset    kittens? Where? I prefer puppies. :P
22:50 aleisha_    catalyst loves kittens
22:52 wizzyrea    always have to be contrary don't you
22:52 wizzyrea    last year we were saving narwhals or something
22:55 mtompset    Ooo... narwhals would be cool.
22:56 mtompset    No... I just really don't like cats period. I'll tolerate them. Admit that kittens are cute. But I rather not be near kittens.
23:07 wizzyrea    ¯\_(ツ)_/¯
23:11 terauhina   Hi, does anyone know where to find the magnifying glass icon that linked to the authority record on the OPAC? I am working on Bug 16427 and do not know where to find the magnifying glass the bug report is talking about
23:11 huginn      Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 enhancement, P5 - low, ---, koha-bugs, NEW , Direct link to authority records missing in staff detail view
23:24 wizzyrea    terauhina: yep, you'd need to have a record linked to an authority
23:24 wizzyrea    so two things
23:25 wizzyrea    you'll need to create an authority - More -> authorities -> Create new
23:25 wizzyrea    (yep I can help you put in what you need ^.^)
23:25 wizzyrea    and 2. edit one of your records to use that authority, in  cataloguing
23:26 terauhina   I've already created an authority and edited one of my records to use the authority but I still can't seem to find the magnifying glass
23:27 wizzyrea    hmm.
23:28 wizzyrea    oh,
23:28 wizzyrea    did you look at it in localhost:8080?
23:28 wizzyrea    cuz it won't turn up in the staff client, that's the bug
23:29 wizzyrea    it'd be on the detail view of the record, just below the title, in that block of stuff.
23:31 terauhina   yeah can see that the authority is there but there is no magnifying glass icon
23:32 terauhina   *I can see
23:33 wizzyrea    hmm
23:33 wizzyrea    https://library.plantandfood.co.nz/cgi-bin/koha/opac-detail.pl?biblionumber=48609 for example
23:33 wizzyrea    see where it says subjects?
23:34 wizzyrea    and Cooking has a lil magnifying glass?
23:34 wizzyrea    I wonder if it's because of the type of authority you added?
23:35 wizzyrea    i.e. a topical term not say, a personal name
23:35 terauhina   yup I see the magnifying glass with the cooking. I added a Genre/Form type of authority and named it science
23:35 wizzyrea    right, try with a topical term
23:35 terauhina   okay
23:36 wizzyrea    possible that the genre doesn't
23:36 wizzyrea    display the magnifying glass
23:37 terauhina   okay thanks I'll try it out
23:38 wizzyrea    i mean, sing out if you get stuck and I'll mosey down :)
23:39 aleisha_    also, if anyone has some terminology bugs they've always wanted fixed, please tag them with academy or pass them on to me!