Time  Nick                   Message
00:37 mtompset               @seen gmcharlt
00:37 huginn                 mtompset: gmcharlt was last seen in #koha 4 weeks, 6 days, 11 hours, 14 minutes, and 42 seconds ago: * gmcharlt waves back at cait
00:37 mtompset               Okay, that explains why that patch is still sitting there. :)
00:40 mtompset               @later tell gmcharlt Since it has been a month, I thought a reminder might be good for the TODO list: https://github.com/perl4lib/marc-perl/pull/5
00:40 huginn                 mtompset: The operation succeeded.
03:04 mtompset               @seen aleisha
03:04 huginn                 mtompset: aleisha was last seen in #koha 1 week, 1 day, 0 hours, 45 minutes, and 12 seconds ago: <aleisha> i will try and implement that
03:05 mtompset               @later tell aleisha While checking out bug 14385, I discovered GetMember calls no longer work I added a see also to the bug that changed that (I think).
03:05 huginn                 mtompset: The operation succeeded.
03:15 mtompset               Anyone here?
03:17 * wizzyrea             is nobody
03:19 mtompset               Hey, wizzyrea!
03:19 wahanui                wizzyrea is here to help. And sometimes hinder. But mostly help.
03:20 mtompset               Just when I had hoped the code was good to go, poof... a function disappears, and I need to tweak code. :(
03:22 mtompset               How are you, wizzyrea? Happy 1.5*10^9 seconds!
03:22 wizzyrea               aw that's annoying
03:22 wizzyrea               hehe
03:22 wizzyrea               tbf GetMember disappeared a couple of versions ago
03:22 wizzyrea               very annoying for some integrations
03:23 mtompset               or current Koha code: bug 18938
03:23 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 minor, P5 - low, ---, oleonard, NEW , opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember
03:26 mtompset               I think I'll call it a day, and get some sleep.
03:27 mtompset               Have a great day, #koha wizzyrea
03:29 wizzyrea               later
05:54 marcelr                hi #koha
05:55 marcelr                LeeJ++
06:37 marcelr                hi LibraryClaire
06:37 LibraryClaire          hi marcelr
11:28 * cait                 waves
11:28 cait                   LeeJ++
11:35 cait                   @wunder munich
11:35 huginn                 cait: Error: No such location could be found.
11:35 cait                   @wunder muc
11:35 huginn                 cait: Error: No such location could be found.
12:11 * LeeJ                 waves
12:11 LeeJ                   morning #koha
12:13 LibraryClaire          hi LeeJ
12:13 LeeJ                   hi LibraryClaire!
13:28 LeeJ                   is anyone running on master able to access Acquisitions? I'm getting a plack error
13:33 pastebot               "LeeJ" at 127.0.0.1 pasted "Plack error when trying to open acqui-home.pl" (1 line) at http://paste.koha-community.org/499
13:41 mtompset               Greetings, #koha.
13:41 LeeJ                   hi mtompset
13:42 LeeJ                   mtompset: do you have a standard jessie box running? Don't know why but I'm getting an internal server error when I click Acquisitions? O.o
13:43 mtompset               LeeJ: having fun? My bug 14385 work was sidetracked by discovering bug 18938
13:43 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, ASSIGNED , Extend OpacHiddenItems to allow specifying exempt borrower categories
13:43 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 major, P5 - low, ---, jonathan.druart, NEW , opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember
13:43 mtompset               Check your plack log.
13:43 LeeJ                   mtompset: just need to see if anyone else is able to open acqui-home.pl
13:43 LeeJ                   I did
13:43 LeeJ                   http://paste.koha-community.org/499
13:43 LeeJ                   and it makes zero sense
13:43 mtompset               Nope, it makes complete sense.
13:43 mtompset               *sigh*
13:44 mtompset               Too many bugs, too little time.
13:44 LeeJ                   lol
13:44 LeeJ                   I figured it wasn't something I did because I tried a reset_all and the issue still occurs
13:46 mtompset               return Koha::Whatever->find( $singular_key ); -- or some other confusing context and similar related issue. complete sense.
13:50 mtompset               oh and the I really wanted a hash, so I unblessed the object, because there is this call that really shouldn't be used, but I can access it. ;)
13:50 LeeJ                   mtompset: that's the one! ;)
13:50 mtompset               But that ties back to my initial complaint type. :)
13:52 mtompset               BTW, this would also happen in stretch.
13:52 mtompset               I'll take a look. I vaguely recall seeing some acquisitions bug thing that might be related.
13:53 mtompset               BTW, I gladly accept donations.
13:53 LeeJ                   ooh..I guess it's not really a "bug" per se but I think I found the cause
13:53 mtompset               After all, I get no salary, except for donations. :)
13:53 LeeJ                   I was logged in as koha_kohadev
13:53 LeeJ                   which still shouldn't throw an error?
13:53 mtompset               Yes, but still shouldn't barf like that.
13:54 LeeJ                   I'll file it I guess lol
13:54 mtompset               Let me confirm first.
13:55 LeeJ                   okay
13:55 mtompset               I'm still spinning up my VM.
13:55 LeeJ                   no worries
13:55 LeeJ                   [off] today and tomorrow is our campus' freshman orientation...no one here will get to be very productive today anyway lol
14:01 mtompset               Yes, I think I understand the problem.
14:02 mtompset               Even when a borrower isn't found, it likely creates a hash with lots of empty keyed values.
14:02 LeeJ                   oooh
14:02 mtompset               This doesn't evaluate to false.
14:02 mtompset               which means it doesn't return 0, like before. :)
14:03 LeeJ                   >_>
14:03 mtompset               oh wait... they were lazy and -> unblessed on a not found.
14:03 mtompset               Still same kind of issue.
14:03 mtompset               Easy enough to fix.
14:03 mtompset               Bug report it.
14:03 mtompset               I'll post a patch.
14:04 mtompset               You can then feel free to sign itoff. :)
14:04 LeeJ                   okay!
14:05 mtompset               number?
14:05 wahanui                number is, like, going down too fast
14:07 LeeJ                   typing the report lol
14:10 LeeJ                   https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942
14:10 huginn                 04Bug 18942: normal, P5 - low, ---, koha-bugs, NEW , Acquisitions module fails to load with an error when hash created on empty values
14:10 LeeJ                   description may not be fully descriptive but it'll do :P
14:33 liv_ong                hello, I have three koha-conf.xml files, how to find out which one is used?
14:51 mtompset               LeeJ_bbs: *ping*
14:53 mtompset               @later tell LeeJ bug 18942 is ready for sign off.
14:53 huginn                 mtompset: The operation succeeded.
14:53 mtompset               @later tell LeeJ_bbs bug 18942 is ready for sign off.
14:53 huginn                 mtompset: The operation succeeded.
14:53 LeeJ                   I'm back :P
14:54 LeeJ                   mtompset: alrighty
14:55 mtompset               Forgive me, but I expanded scope a little. :)
15:00 * LeeJ                 applauds mtompset
15:04 liv_ong                LeeJ: hello, the other day I've asked about logs for LDAP Auth, but it happens I  cannot
15:04 liv_ong                generate any logs yet
15:08 mtompset               liv_ong: What are the paths to these three koha-conf.xml files?
15:09 liv_ong                mtompset: oh, I've got it, well, I do want the users to authenticate via Active Directory
15:09 mtompset               I know nothing of LDAP, sorry.
15:10 liv_ong                mtompset: I've followed this howto : https://kohablog.wordpress.com/2011/03/29/using-active-directory-ldap/
15:11 liv_ong                mtompset: me too, I know little, I get this errors: Use of uninitialized value $lasttime in numeric lt (<) at /home/www/kobli/lib/C4/Auth.pm line 687.
15:11 mtompset               1) 2011/03/29 is old, 2) it's not a Koha wiki page, 3) like I said, I know nothing of LDAP.
15:12 mtompset               4) that is not the normal installation direction of Koha.
15:12 mtompset               installation directory.
15:15 liv_ong                mtompset: ok, thanks for your help
15:16 mtompset               Sorry I can't be more helpful.
15:17 mtompset               You may find better help on the mailing list.
15:17 mtompset               mailing list?
15:17 wahanui                well, mailing list is at http://koha-community.org/support/koha-mailing-lists/
15:26 mtompset               http://www.wycliffe.org/Give/MissionaryMinistries.aspx
15:26 mtompset               Oops... wrong window.
15:26 mtompset               Broken URL anyways. :)
15:37 huginn                 New commit(s) kohagit: Bug 18901: [QA Follow-up] Do not translate zzpref either <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a2c9513b1c3449a34f942d8fa53f8ce1fe374e3f> / Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ec51335e9cc4e090ef80f592cc0cc7a0786661f8> / Bug 18748: Noisy t/db_dependent/AuthorisedValues.t <http://git.koha-community
16:54 mtompset               BTW, Joubu, I noticed you just wrote, signed off, and pushed through a fix for the bug I reported. Couldn't it have waited for a second sign off? It does eyeball okay, though.
16:54 mtompset               @seen Joubu
16:54 huginn                 mtompset: Joubu was last seen in #koha 1 day, 1 hour, 22 minutes, and 26 seconds ago: <Joubu> @later tell rangi_  Ubuntu 14.04 is not supported, use 16.04 instead
16:56 mtompset               Greetings, kidclamp
16:57 kidclamp               hi mtompset
16:57 kidclamp               how goes things?
16:57 mtompset               bug 14385 is giving me testing headaches. Though, kudos to Joubu for fixing the related bug I found as a result.
16:57 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, ASSIGNED , Extend OpacHiddenItems to allow specifying exempt borrower categories
16:58 mtompset               Need a thorough test plan.
16:58 mtompset               Some changes are easy to trigger.
16:58 mtompset               Some changes are more difficult.
17:00 mtompset               You available to sign some things off? I have seven other bugs, five of which need sign off still, I believe.
17:02 kidclamp               unfortunately not today, but cc me on the bugs and I can try next week
17:06 mtompset               Okay. Just added you to the CC on the bugs.
17:19 paulofrancisco_antonio I'd like to know the directory path where koha store the file and cover attached to the records
17:27 LeeJ                   paulofrancisco_antonio: hold on..
17:27 paulofrancisco_antonio ok
17:30 Guest1429              Project Koha_Master_D8 build #217: UNSTABLE in 1 hr 47 min: https://jenkins.koha-community.org/job/Koha_Master_D8/217/
17:30 Guest1429              * jonathan.druart: Bug 18854 - Protect from DOS
17:30 Guest1429              * jonathan.druart: Bug 18854: Make sure offset will not be < 0 - protect from DoS
17:30 Guest1429              * jonathan.druart: Bug 18854: Protect few other occurrences of offset
17:30 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18854 is not accessible.
17:30 Guest1429              * jonathan.druart: Bug 18259: Koha::Biblio - Remove GetSubscriptionsId
17:30 Guest1429              * jonathan.druart: Bug 18259: [QA Follow-up] Replace variable name
17:30 Guest1429              * jonathan.druart: Bug 18880: Fix authentication fallback for external authentications
17:30 Guest1429              * jonathan.druart: Bug 18880: [QA Follow-up] Finishing touch
17:30 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Koha::Biblio - Remove GetSubscriptionsId
17:30 Guest1429              * jonathan.druart: Bug 18938: (bug 17829 follow-up) Replace 2 occurrences of GetMember left
17:30 Guest1429              * jonathan.druart: Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1
17:30 Guest1429              * jonathan.druart: Bug 18262: Fix test in MultiplePerRecord
17:30 Guest1429              * jonathan.druart: Bug 18748: Noisy t/db_dependent/AuthorisedValues.t
17:30 Guest1429              * jonathan.druart: Bug 18901: Sysprefs translation: translate only *.pref files (not
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 blocker, P5 - low, ---, jonathan.druart, Pushed to Master , Regression breaks local authentication fallback for all external authentications
17:31 Guest1429              * jonathan.druart: Bug 18901: [QA Follow-up] Do not translate zzpref either
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 major, P5 - low, ---, jonathan.druart, Pushed to Master , opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move GetMember to Koha::Patron
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Koha::Biblios - Remove GetBiblioData - part 1
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 minor, P5 - low, ---, mtompset, Pushed to Master , Noisy t/db_dependent/AuthorisedValues.t
17:31 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 normal, P5 - low, ---, julian.maurice, Pushed to Master , Sysprefs translation: translate only *.pref files (not *.pref*)
17:32 mtompset               paulofrancisco_antonio: I thought those were blobs in the DB.
17:34 LeeJ                   paulofrancisco_antonio mtompset they ARE in fact loaded into the DB in the biblioimages table
17:34 LeeJ                   http://schema.koha-community.org/master/tables/biblioimages.html
17:38 LeeJ                   paulofrancisco_antonio: if you need to discover where something gets stored in the future, you can look at the filename in the URL of the page you want to know about (in your case it would be upload-cover-image.pl) you can start by looking at the source code in your local repo or from the GitHub page https://github.com/Koha-Community/Koha/blob/master/tools/upload-cover-image.pl
17:44 LeeJ                   paulofrancisco_antonio: starting at Line 85, it indicates it uses the GD::Image module to initiate a filehandle to upload the image to the uploaded_files table, stores the uploaded image into biblioimages, then deletes the uploaded file
18:07 mtompset               kidclamp: You still here?
18:07 mtompset               @seen kidclamp
18:07 huginn                 mtompset: kidclamp was last seen in #koha 1 hour, 5 minutes, and 7 seconds ago: <kidclamp> unfortunately not today, but cc me on the bugs and I can try next week
18:08 kidclamp               one foot out the door
18:08 kidclamp               whats up mtompset
18:08 mtompset               I was looking at bug 18941
18:08 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941 normal, P5 - low, ---, nick, Needs Signoff , C4::Budgets GetBudgetByCode should return active budgets over inactive budgets
18:09 mtompset               Why did you leave it *?
18:09 mtompset               Why not limit the selected fields to the original table?
18:10 kidclamp               cause I was in a hurry?
18:10 kidclamp               you are correct, it should be aqbudgets.*
18:10 mtompset               So, failed qa it with that comment?
18:10 chris_n                fresh install of 17.05.01 on new hardware with a very lean install of ubuntu 16.04.2 over an upgraded DB, and I note this in the log
18:10 pastebot               "chris_n" at 192.168.2.204 pasted "[Thu Jul 13 10:00:48.326260 20" (1 line) at http://paste.koha-community.org/500
18:11 chris_n                should I open a bug for it?
18:11 kidclamp               you could just add a followup mtompset
18:11 kidclamp               but FQA is fair too :-)
18:11 mtompset               The problem with follow ups is mixed patches need double signoffs and those are a pain to get.
18:12 kidclamp               I'll sign your back if you scratch mine?
18:12 kidclamp               or something
18:12 wahanui                something is sketchy
18:12 kidclamp               true
18:12 kidclamp               wahanui: botsnak
18:12 wahanui                kidclamp: sorry...
18:12 kidclamp               wahanui: botsnack
18:12 wahanui                thanks kidclamp :)
18:12 mtompset               Okay... I can do that.
18:12 mtompset               I just haven't always had the greatest turn around time on that.
18:13 kidclamp               well, out the door now, either way I will return to it next week
18:13 mtompset               Okay.
18:13 kidclamp               have a good weekend #koha
18:13 mtompset               Enjoy.
18:13 mtompset               chris_n: probably?
18:21 mtompset               chris_n: Is bug 18660
18:21 huginn                 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 trivial, P5 - low, ---, veron, Needs Signoff , Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc
18:21 mtompset               Does that solve your issue?
18:31 chris_n                mtompset: No. The problem arises from calling CGI.param in a list context apparently: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter
18:32 mtompset               Right, but CGI is part of the TT stuff in the include file. The bug I pointed to removes that.
18:34 mtompset               47 is the [% END %] of an IF which has the CGI in the TT.
18:35 mtompset               And pdferr could be an array which might be the trigger?
18:35 chris_n                I applied your patch and it does not appear to correct the error I am seeing
18:36 chris_n                it might be
18:36 chris_n                I'll look around for a bit
18:45 chris_n                actually pdferr is not an array
18:45 chris_n                in this context, there does not appear to be the potential warned of by the warning
18:46 chris_n                pdferr is just a test to see if any errors were set
18:46 chris_n                it seems safe to ignore
18:55 mtompset               I was looking at the manage.pl code.
18:56 mtompset               A mis-parse of the ternary condition in brackets seems like a possibility of triggering this.
18:57 mtompset               I don't understand why there is even the need for braces.
19:03 LeeJ_kohadocs          @later tell cait at some point we need to hammer out the "style guide" I had mentioned for kohadocs..the inconsistencies in 17_cron_jobs.rst is cringe-worthy
19:03 huginn                 LeeJ_kohadocs: The operation succeeded.
19:06 mtompset               Oooo... cringe worthy. ;)
19:07 mtompset               Have a great day (24 hour period), #koha LeeJ_kohadocs chris_n
21:10 LeeJ_kohadocs          have a good night #koha