Time  Nick        Message
23:01 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 trivial, P5 - low, ---, koha-bugs, NEW , Our legacy code contains trailing-spaces
23:01 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 normal, P5 - low, ---, veron, Pushed to Master , Translatability: Get rid of exposing  [%% FOREACH in csv/cash_register_stats.tt
23:01 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 normal, P5 - low, ---, nick, Pushed to Master , Internal server error in cash_register_stats.pl when exporting to file
23:01 jenkins     * jonathan.druart: Bug 18584: Fix trailing spaces in C4/Accounts.pm
23:01 jenkins     * jonathan.druart: Bug 18694: Translatability: Get rid of exposing [%% FOREACH in
23:01 jenkins     * jonathan.druart: Bug 18734 - Internal server error in cash_register_stats.pl when
23:01 jenkins     Project Koha_Master_D8 build #199: FIXED in 1 hr 48 min: https://jenkins.koha-community.org/job/Koha_Master_D8/199/
23:01 wahanui     o/ '`'`'`'`'`'`'`'`'`
23:01 jenkins     Yippee, build fixed!
21:59 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 normal, P5 - low, ---, jonathan.druart, Needs Signoff , OAI/Server.t fails on slow servers
21:59 Joubu       mtompset: And bug 18794 should turn jenkins green
21:53 cait1       mtompset++
21:53 cait1       yay
21:51 Joubu       mtompset: around?
21:50 huginn      Joubu: The operation succeeded.
21:50 Joubu       @later tell tcohen www tests are fixed!
21:50 Joubu       mtompset++ # www tests are fixed!
21:06 huginn      New commit(s) kohagit: Bug 18584: Fix trailing spaces in C4/Accounts.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a80ed84d070f81065b1fb2fa14f5ced3c25d6431> / Bug 18694: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ec478e18f352d340c7a1ec4416121928229c2907> / Bug 18734 - Internal server error in cash_register_stats.pl when expor
21:01 Joubu       LeeJ++ # First one to finish (start?) Koha how-to!
20:36 rangi       morning
20:35 LeeJ        take care for now all!
20:35 LeeJ        Joubu: I'll let you know my findings
20:35 LeeJ        Joubu: that's very possible..when I try it again I'll wait longer before hitting next
20:34 Joubu       maybe the patch submission was not done yet when you hit "next"?
20:33 LeeJ        Joubu: yes...the patch validation didn't appear to be talking..the detection didn't seem to work. Not sure if it was the how-to itself or my machine. I'm going to try it on my box at home to see if the same issue persists..if it does I'll open an issue report for you
20:32 Joubu       LeeJ: I see that you attached twice the same patch on the bug report, did you encounter a problem?
20:31 Joubu       thanks LeeJ!
20:30 LeeJ        Joubu: that how-to is excellent
19:51 LeeJ        Joubu: certainly! I'll open others if I find any other things!
19:50 Joubu       LeeJ: can you open an issue (on github)?
19:49 Joubu       right
19:49 Joubu       LeeJ: yep, you are righ!
19:48 LeeJ        Joubu: Step 4a for Fix the issue should have "-n" as the flag not "-c" for the line numbers...it confused me for a while lol.. -c just shows how many occurrences of your query are in it according to the documentation :)
19:21 LeeJ        Joubu: ah got it now..will let you know how it goes :)
19:18 LeeJ        doing that now
19:18 Joubu       plack need to be restarted
19:18 Joubu       restart_all
19:17 LeeJ        Joubu: of course I'm getting an internal server error on koha-how when I go to run it :P
18:48 * LeeJ      guesses he'll go be a guinea pig for Joubu and run koha-howto
18:47 * LeeJ      screams
18:46 Joubu       :D
18:46 * Joubu     shoots anyway
18:46 * LeeJ      waves a white flag
18:46 LeeJ        Joubu: I give up on that bug...
18:46 Joubu       and... do not edit the original commit messages :)
18:46 Joubu       LeeJ: nope, there is only 1 patch attached
18:45 LeeJ        which doesn't make sense because there were 4 sign offs included...
18:45 LeeJ        I had to use HEAD~2^
18:45 LeeJ        hmm...well I got it to work finally
18:44 oleonard    LeeJ: HEAD~3 because it starts from zero: 0, 1, 2, 3
18:43 LeeJ        hmm..let's see..
18:43 Joubu       yes, what oleonard said :)
18:42 oleonard    LeeJ: I think that means your command included a commit which was already in master. HEAD~3 instead of HEAD~4
18:42 LeeJ        Joubu could I be having a problem because my branch creation command was "git checkout -b bug_18762 origin/master?
18:41 LeeJ        Joubu: I just pasted the error I got the last time before I screwed up the commit
18:40 pastebot    "LeeJ" at pasted "Commit rewrite warning?" (4 lines) at http://paste.koha-community.org/452
18:07 Joubu       otherwise: `git bz apply --abort; git reset --hard origin/master; git bz apply 18656` # and you are done :)
18:06 Joubu       t
18:06 Joubu       with apply and 'i' it should let you apply the patch you wan
18:06 LeeJ        Joubu: it won't let me apply just the 4th patch so I might just re-create the branch and do it that way for the last attachment
18:05 LeeJ        Joubu: that makes me feel better...because I love to contribute as I don't have a social life to speak of so this is a great replacement :)
18:04 Joubu       LeeJ: I think all of us messed our first multiple attachments :)
18:04 LeeJ        Joubu++
18:03 * LeeJ      is thankful Joubu is merciful and hasn't clubbed him over the head for botching a commit
18:01 Joubu       LeeJ: seems that you would be a good candidate to test koha-howto :) (https://tree.taiga.io/project/joubu-koha-rm-1711/task/22)
18:00 Joubu       or git bz attach -e 18656 HEAD~3^.. # if you are a dev and you start counting at 0 instead of 1
17:59 Joubu       then git bz attach -e 18656 HEAD~4..HEAD # Note that the last HEAD is optional
17:58 Joubu       then sign it off: git so 1 # signoff only 1 patch
17:58 Joubu       it will apply the last one (the one you do not have)
17:58 Joubu       comment the 3 first (the ones you have already)
17:57 Joubu       apply it with git bz apply, then hit 'i' for interactive
17:57 Joubu       the git log is ok, just one patch is missing
17:57 LeeJ        Joubu: is there a way to rollback/revert? Haven't ran into this situation before
17:56 Joubu       Bug 18762: Catch noisy conditions in t/db_dependent/Search.t
17:56 Joubu       LeeJ: one patch is missing
17:56 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 normal, P5 - low, ---, jonathan.druart, Signed Off , Some tests are noisy
17:56 pastebot    "LeeJ" at pasted "Bug 18762 commit log" (5 lines) at http://paste.koha-community.org/451
17:54 LeeJ        Joubu: but 18656 shouldn't have been picked up selecting HEAD~2^ from my understand...only if it was HEAD~3^
17:54 LeeJ        Joubu: ahh..I think I see where it went wrong. The three non-signed off ones got applied. 4th one is the 18656 >_>
17:53 tcohen      Joubu: I'm fine with whatever you choose, but it was not working
17:52 Joubu       LeeJ: right?
17:52 Joubu       should show you 4 patches from 18762
17:51 Joubu       git log --oneline
17:51 LeeJ        Joubu: yes
17:51 Joubu       LeeJ: ok, are you on the branch?
17:51 Joubu       but please, ask me next time
17:50 Joubu       tcohen: nevermind, will get back to it and reintroduce the empty file...
17:50 Joubu       tcohen: yes and?
17:50 Joubu       yes and?
17:50 Joubu       LeeJ: wait a min
17:49 tcohen      the problem can be worked around, but the base problem is the translation scripts IMHO
17:49 tcohen      I didn't consider carriage returns, though
17:49 tcohen      Joubu: I didn't understand why using such a tricky workaround if TT provided a way to do it
17:48 Joubu       I do not understand the "rely on TT for new lines"
17:47 Joubu       tcohen: export csv are broken for  translated language. I do not understand why you removed the include file, it's the only way to have carriage returns
17:46 Joubu       when signing off
17:46 Joubu       LeeJ: You are not supposed to edit commit messages
17:46 tcohen      Joubu: WWTF?
17:46 LeeJ        Ran "git bz attach -e 18762 HEAD~2^ because it had 3 commits to sign off on..
17:45 LeeJ        https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off_2
17:44 LeeJ        not sure what went wrong :(
17:44 wahanui     which instructions are you following?
17:44 Joubu       which instructions?
17:44 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 normal, P5 - low, ---, oleonard, Pushed to Master , Require confirmation of deletion of files from patron record
17:44 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 normal, P5 - low, ---, jonathan.druart, Signed Off , Some tests are noisy
17:44 LeeJ        Joubu: had a problem signing off apparently..bug 18762. I followed the instructions to sign off on multiple and it accidentally attached a commit from bug 18656 to my git bz attachment..
17:44 Joubu       Why???
17:44 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 major, P5 - low, ---, josef.moravec, Pushed to Stable , Export csv in item search, exports all items in one line
17:44 Joubu       tcohen: Bug 16914: Remove unused empty_lines.inc file
17:29 * oleonard  seeks lunch
17:27 LeeJ        oleonard: well there's a building being demolished literally 30 feet away from my office so it's hard to use brain functions when it's rattled all day from vibrations
17:26 oleonard    I certainly don't suggest using mine today LeeJ
17:26 * kidclamp  learned by making that mistake :-)
17:26 LeeJ        kidclamp: oooh...I guess using my brain a bit might help, eh?
17:26 kidclamp    actually for rebase I think it is just number of patches
17:26 kidclamp    and substitute for number
17:25 kidclamp    HEAD~#^
17:25 kidclamp    1stcommitid^ is a placeholder LeeJ  - you should count patches and subtract one
17:24 LeeJ        oleonard: tried following the git bz instructions for signing off multiple. Ran "git rebase 1stcommitid^ --interactive" and got the output "fatal: Needed a single revision invalid upstream 1stcommitid^"
17:02 Joubu       it will avoid all the issues we had in the patron toolbar and the picture because of some variables/flag not passed to the templates
17:00 Joubu       (and it removes 300 lines)
17:00 oleonard    Neat
17:00 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Send a Koha::Patron object to the templates
17:00 Joubu       oleonard: I am sure you will love bug 18789 :)
16:18 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 normal, P5 - low, ---, oleonard, Pushed to Master , Require confirmation of deletion of files from patron record
16:18 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 normal, P5 - low, ---, mtompset, Pushed to Master , t/db_dependent/www/history.t is failing
16:18 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 normal, P5 - low, ---, mtompset, Pushed to Master , t/db_dependent/www/search_utf8.t  fails
16:18 jenkins     * jonathan.druart: Bug 18656 - Require confirmation of deletion of files from patron record
16:18 jenkins     * jonathan.druart: Bug 18773: Fix failing history.t test
16:18 jenkins     * jonathan.druart: Bug 18411: Fix failing search_utf8.t tests
16:18 jenkins     Project Koha_Master_D8 build #198: STILL UNSTABLE in 1 hr 50 min: https://jenkins.koha-community.org/job/Koha_Master_D8/198/
16:08 cait        because there is no script to transform?
16:04 tcohen      why the stage marc import page doesn't offer to choose MARC flavour?
16:03 tcohen      oh noes!
15:55 Joubu       from f6486e63904f728fbdf5a9def8082777a101c64f Mon Mar 28 12:09:23 2011
15:54 Joubu       yes that sounds completely wrong
15:50 tcohen      neworderempty.pl:148
15:50 tcohen      I found that neworderempty.pl assumes holdings are on 952, and was about to file a bug for taht
15:49 Joubu       no very familiar, what is the question? :)
15:48 tcohen      Joubu: yes, that
15:48 oleonard    I just know that breeding can go very wrong. https://monsterlegacy.files.wordpress.com/2015/02/alieneggchambo.jpg
15:47 Joubu       C4::Breeding you mean?
15:46 tcohen      anyone familiar with the Koha::Breeding lib?
15:38 Joubu       Salut tcohen
15:36 tcohen      qhi Joubu
15:34 huginn      Joubu: The operation succeeded.
15:34 Joubu       @later tell reiveune hello!
15:33 reiveune    bye
15:05 mveron      BTW for OPAC all the tt directives are weeded out, for staff are some leftovers.
15:04 mveron      It is not the fanciest thing to do, but somebody has to do it...
15:04 mveron      Thanks, oleonard :-)
15:03 oleonard    mveron++ # Lots of i18n fixes for the templates
14:57 oleonard    Hi tcohen
14:57 tcohen      morning!
14:51 LeeJ        oleonard: I'm going to update that bug and sign off on the rest of the patches
14:51 oleonard    Oh, not able to grant them?
14:50 cait        the admin permissions are an issue for us
14:50 oleonard    Thanks Joubu. I was trying to do the same thing that patch does but I guess I got it wrong because it wasn't working.
14:50 cait        evaluating our options - good to know!
14:50 cait        thx LeeJ
14:49 LeeJ        cait: fyi I believe I ran into an access issue trying to run kohadevbox without running as admin
14:49 oleonard    I edit files using my Windows editor and do pretty much everything else via ssh in the devbox (git bz, signing off, etc)
14:48 mveron      Hi again #koha
14:48 oleonard    I use SYNC_REPO, so yes. Git for Windows is installed.
14:47 cait        but the git repo is outside devbox then?
14:47 cait        thx, that's what I needed to know
14:47 oleonard    cait: I believe admin rights are necessary. I run Git Bash as an administrator.
14:46 cait        hm permissions... whatever
14:46 cait        do you know if admin rights are needed?
14:46 cait        oleonard: are you running kohadevbox under windows now?
14:43 fridolin1   ahhh nice
14:34 Joubu       ok, I have a patch
14:28 oleonard    I agreed with cait's suggestion to do so.
14:28 Joubu       and fix it differently
14:27 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 minor, P5 - low, ---, fridolin.somers, Pushed to Master , Hide with CSS dynamic elements in member search
14:27 Joubu       I think the solution would be to revert bug 18551
14:27 huginn      New commit(s) kohagit: Bug 18656 - Require confirmation of deletion of files from patron record <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a38ffe2d48c35029ef80ea0a4294e36b408cd1a4> / Bug 18773: Fix failing history.t test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=25bbc181c9ceacd84582368f0006d4025250ea1f> / Bug 18411: Fix failing search_utf8.t tests <http://git.koha-community.org/gitweb/?p=koha.git;a=com
14:26 * oleonard  has always wanted to do seasonal IntranetUserCSS
14:26 fridolin1   poney
14:26 fridolin1   oleonard: lylittlepony.css you mean
14:25 kidclamp    I do like the pink
14:25 cait        brb
14:25 kidclamp    but I am not strong agaisnt it
14:25 cait        so at the moment the problem is only in 17.05
14:25 oleonard    fridolin1: I'll send you my IntranetUserCSS ;)
14:25 kidclamp    I just don't like the modal there
14:25 cait        I reverted the patches from 16.11
14:25 * fridolin1 likes withe the pink color
14:25 oleonard    ...but that doesn't help stable.
14:25 cait        like you can't search for a lot of th fields in the patron account
14:25 oleonard    I was trying to do a bug fix and then realized converting to a modal would avoid the need for a bugfix
14:24 cait        ing eneral
14:24 cait        but our patron search could be better
14:24 Joubu       kidclamp: why?
14:24 kidclamp    fisticuffs!
14:24 cait        well i do :)
14:24 kidclamp    I said I didn't like it
14:24 cait        i like it
14:24 * cait      sends more icecream to oleonard
14:24 cait        what did you do?
14:24 oleonard    ;)
14:24 * kidclamp  was mean, it is true
14:24 Joubu       the changes would make sense, but not as a bugfix
14:24 oleonard    I started working on that but then kidclamp made me cry and I had to go out for ice cream and then I forgot.
14:23 * oleonard  doesn't want to think he's in his test system when he's really on the production site
14:23 Joubu       ;)
14:23 oleonard    Sorry that's my test system
14:22 Joubu       with the pink color?
14:22 oleonard    I'm considering this: http://zivotdesign.com/p/#1/14966687495978
14:22 fridolin1   Joubu: nope sorry
14:21 oleonard    I started to but didn't settle on a solution
14:21 Joubu       fridolin1: same? ^
14:20 Joubu       oleonard: did you take a look at the floating toolbar issue when editing patron's detail?
14:20 oleonard    https://wiki.evergreen-ils.org/doku.php?id=community:using-pinesol_green
14:19 oleonard    Boo
14:19 huginn      oleonard: An error has occurred and has been logged. Please contact this bot's administrator for more information.
14:19 oleonard    @coffee
14:19 oleonard    It's no big deal, I just noticed because I was going to test that bug too and noticed mtompsett comment about it
14:19 LeeJ        oleonard: whoops! I'll take care of that in a few minutes after I fix something here at work!
14:17 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 normal, P5 - low, ---, jonathan.druart, Signed Off , Some tests are noisy
14:17 oleonard    You signed off on one of multiple patches on Bug 18762
14:15 LeeJ        oleonard: did I not sign something off right somewhere? :O
14:15 oleonard    LeeJ: https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off_2 There is a custom command in there for signing off multiple patches at once if you're interested.
14:14 LeeJ        that is a very tempting bundle...
14:12 LeeJ        nengard: shhh...just wanted a reason to convince myself I need another bookshelf ;)
14:12 oleonard    LeeJ's Kindle is already too heavy
14:11 nengard     i think they're ebooks .... :)
14:11 LeeJ        nengard: you're going to force me into buying another bookshelf...
14:08 vegasjoe    https://www.humblebundle.com/books/linux-book-bundle
14:08 vegasjoe    https://www.humblebundle.com/books/linux-book-bundle
14:08 huginn      Hmm... cait... Let me see now... HUFFLEPUFF!
14:08 cait        @sortinghat
14:06 nengard     this might be of interest to folks here: https://www.humblebundle.com/books/linux-book-bundle
14:02 huginn      Hmm... oleonard... Let me see now... GRYFFINDOR!
14:02 oleonard    @sortinghat
13:55 vegasjoe    I was wondering if anybody is using percona?
13:19 magnuse     s/scc/acc/
13:19 magnuse     cait: +25C, sccording to my sources
13:19 atheia      'ello 'ello :-)
13:19 magnuse     kia ora atheia
13:17 huginn      magnuse: I've exhausted my database of quotes
13:17 magnuse     @wundercait konstanz
13:08 * cait      is melting
12:58 magnuse     ¡hola Joubu!
12:56 Joubu       hi #koha
11:55 huginn      oleonard: LeeJ was last seen in #koha 2 days, 16 hours, 58 minutes, and 1 second ago: <LeeJ> oleonard: somehow I have strange characters as categorycode in here too..I didn't make them..guess I'll just spin up a new one!
11:55 oleonard    @seen LeeJ
11:44 eythian     hi oleopard
11:37 oleonard    Hi all
11:33 LRMC        when we input data under add patron it will not allow us to save or select submit
11:21 LRMC        Hello we are having problems adding new users so that they can check out equipment
10:41 fridolin1   magic syspref cant be saved ;)
10:41 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 major, P5 - low, ---, veron, Pushed to Stable , System preferences loose part of values because of double quotes
10:40 fridolin1   Bug 18727 ouch dirty
10:05 magnuse     let them! :-)
10:04 fridolin1   after I mean
10:04 fridolin1   people can indeed complain ;)
10:04 fridolin1   magnuse: oki thanks for you opinion
10:03 magnuse     cait, fridolin1: i think that works really nicely - the rmaints close the bugs that they do not push
09:33 fridolin1   ;)
09:33 fridolin1   gooooo
09:32 fridolin1   cait: oki I'll do the same
09:30 cait        people didn't complain openly :)
09:30 cait        and there was no more activity on it
09:30 cait        fridolin1: i set them to resolved when i decided not to push
09:26 fridolin1   Joubu: do y a have a sec ?
09:14 fridolin1   the ENH i can set them resolved ?
09:14 fridolin1   cait: indeed, I was wondering
09:12 cait        i sometimes got good feedback there from people aboutwhat they thought was important to have and it's cool to see if rmaint has already reviewed a patch
09:12 cait        fridolin1: was wondering, coud you mark the ones you decide not to push resolved or leave a note?
09:01 cait        np, just noticed because I was pushing too
08:33 eythian     hi
08:29 huginn      04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , C4::Items - Remove get_itemnumbers_of
08:29 fridolin1   cait: bonjour, thanks for Bug 18295
07:49 * cait      waves
07:46 oha         magnuse: hello :) ready for some testing?
07:37 miakela     Good day. I would like to ask some help on how to get unstuck on Web Installer> Step 1 page. The page stays as is when I click Next. The page just stops loading (Waiting for reply status). Thank you in advance. In the logs, I'm getting a lot of Table doesn't exists.
07:11 fridolin    hie there
06:56 * mveron    waves
06:45 wahanui     niihau, reiveune
06:45 reiveune    hello
06:45 * magnuse   waves
06:37 wahanui     bonjour, alex_a
06:37 alex_a      bonjour
06:33 mveron      Oh, missed her...
06:31 mveron      Hi cait :-)
05:37 oha         o/
05:17 mveron      Good morning / daytime #koha
05:15 miakela     Good day. I would like to ask some help on how to get unstuck on Web Installer> Step 1 page. The page stays as is when I click Next. The page just stops loading (Waiting for reply status). Thank you in advance