Time  Nick          Message
06:18 cait          16.11.08 is out!
06:32 fridolin1     hie there
06:34 alex_a        bonjour
06:45 reiveune      hello
06:58 oha           o/
07:19 josef_moravec morning #koha
07:20 josef_moravec !seen Joubu
07:27 gaetan_B      hello
08:02 marcelr       hi #koha
08:02 marcelr       anyone for an easy signoff on bug 18601 ?
08:02 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 normal, P5 - low, ---, m.de.rooy, Needs Signoff , OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios
08:18 eythian       hi
08:18 wahanui       hello, eythian
09:02 rangi         /names
09:02 rangi         heh
09:02 rangi         Joubu: are you are around?
09:03 marcelr       hi rangi; i think you need to wait a bit yet
09:04 rangi         thanks marcelr
09:06 ashimema      hi rangi. long time no overlap.. hows things?
09:06 rangi         not too bad, how are things with you?
09:14 cait          good morning #koha
09:14 ashimema      not bad, not bad.
09:14 ashimema      busy as every
09:14 ashimema      happy birthday.. though likely timezone wise I'm a day out?
09:15 ashimema      mornin' cait
09:15 cait          morning ashimema
09:16 rangi         yep, was yesterday :)
09:17 cait          happy belated birthday rangi
09:21 magnuse       gratulerer med vel overst├ątt, rangi
09:23 eythian       ashimema: you're just copying my excuse!
09:34 rangi         https://hea.koha-community.org/libraries/582
09:34 rangi         that looks to be working
09:34 rangi         https://hea.koha-community.org/libraries-on-a-map  <-- not yet
09:46 rangi         ok, all our libraries on 16.11.08 are reporting coordinates now. Time for bed
09:48 magnuse       rangi++
09:51 ashimema      nice
10:04 cait          hm no khall
10:04 wahanui       well, no khall is not, either way is really fine with me
12:26 Joubu         hi #koha
12:30 LibraryClaire hi Joubu
12:40 Joubu         marcelr: around?
12:52 Joubu         khall: please take a look at bug 18647
12:52 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 blocker, P5 - low, ---, kyle, Failed QA , Internal server error on moremember.pl
12:52 khall         will do!
12:53 cait          khall: the sql conversion is not marked as pushe
12:53 cait          d
12:53 khall         cait: which bug number is that? I'll fix that now
12:53 cait          was on top of master
12:53 cait          the last commit
12:54 cait          bug 17898
12:54 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Add a way to automatically convert SQL reports
12:54 cait          i think mveron also found a bug and commented
12:54 Joubu         and QA is missing
12:55 cait          yep
12:55 cait          it's signed off
12:55 khall         Joubu: I took it on mysql to pqa it, I had meant to re-attach my signed patches
12:55 cait          so not sure, maybe a bug number typo, but hard to track down then
13:01 LibraryClaire @later tell kidclamp *dolphin noise*
13:01 huginn_       LibraryClaire: The operation succeeded.
13:03 rsantellan    good morning #koha
13:06 khall         Joubu: Marc veron wrote the patch for 18647. do you want him to address it? not sure what you are asking for
13:07 Joubu         khall: the patch is totally wrong, see my note
13:07 Joubu         it comes from the patron club ft
13:07 Joubu         you should not have modified the value of the borrower value passed to the template
13:08 Joubu         this variable is not supposed to be a Koha::Patron
13:08 Joubu         I fixed all of that in bug 17829, but we need to wait a bit to enjoy it
13:08 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move GetMember to Koha::Patron
13:09 Joubu         patron-title.inc should not be modified and the pl should not send a borrower variable if it is a Koha::Patron
13:10 khall         Joubu: does Marc's patch not work in all cases? That would be my assumption
13:11 Joubu         patch is wrong because the include is called from other templates
13:11 Joubu         khall: from template:
13:11 Joubu         +        [% SET enrollments = borrower.get_club_enrollments.size || 0 %]
13:11 Joubu         +        [% SET enrollable  = borrower.get_enrollable_clubs.size || 0 %]
13:11 Joubu         from pl:
13:11 Joubu         345     patron          => $patron,
13:11 Joubu         346     borrower        => $patron, # TODO Still needed by includes,
13:11 Joubu         the only thing to do is to remove the borrower from pl and s/borrower/patron in tt
13:12 Joubu         khall: I'll write the patch
13:12 Joubu         and actually the template has already been modified
13:13 khall         Joubu: ok. ping me and I'll take a look at it!
13:25 mtj           ping khall, are y'all running on bz-18512 on production yet?
13:25 khall         mtj: I believe so, kidclamp could confirm
13:26 mtj           ..cheers for that.. it looks good to me, but i just thought i'd ask anyway :0)
13:27 kidclamp      indeed on a god number of sites at this poinrt
13:35 magnuse       bug 18512
13:35 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 major, P5 - low, ---, nick, Pushed to Master , GetAuthorisedValues.GetByCode Template plugin should return code (not empty string) if value not found
13:45 mtj           ^ ..yep thats the one
13:45 mtj           awesome, thanks kidclamp!
13:46 tcohen        morning!
13:46 kidclamp      morning tcohen
13:47 tcohen        hi kidclamp :-D
15:08 tcohen        @later tell drojf ping
15:08 huginn_       tcohen: The operation succeeded.
15:56 Joubu         khall: do you know a situation where accountlines.issue_id can be set before the item is returned?
15:57 khall         Joubu: it should be set as soon as the item is overdue and the fine begins accruing
16:07 Joubu         khall: why? :)
16:07 khall         so we always no which issue caused a fine
16:07 Joubu         Do not we need it set as soon as there is a fine?
16:08 Joubu         hum ok, code is very weird between C4::Overdues and C4::Circ
16:09 Joubu         lunch time, will see later
17:29 bag           @seen cait
17:29 huginn_       bag: cait was last seen in #koha 4 hours, 33 minutes, and 44 seconds ago: <cait> so not sure, maybe a bug number typo, but hard to track down then
17:30 tcohen        #koha, if you are going to launch a fresh kohadevbox, please make sure you pull the latest source, because we have a tiny deps issue on the master packages and it is causing headaches otherwise
17:44 Joubu         khall, kidclamp: I have attached patches on bug 18651
17:44 huginn_       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 major, P5 - low, ---, jonathan.druart, Needs Signoff , Move of checkouts is still not correctly handled
17:45 khall         Joubu: thanks! I'll test and sign, then tomas can qa
17:49 reiveune      bye
17:49 Joubu         khall: See the last patches please, there are 4 accountlines entries, sounds like too many
17:50 Joubu         last patch
17:51 khall         will do
17:53 khall         Joubu: the two rental charges make sense, still looking at the other two
17:55 Joubu         I had trouble to create a test to get an accountlines.issud_id != NULL before the AddReturn call
18:03 khall         Joubu: the 2 fines make sense to me, the first is from a renewal, the 2nd is from the final return
18:11 Joubu         khall: ok thanks!
18:11 khall         np! never hurts to double check things : )