Time Nick Message 00:05 dcook Hmmm looks like this client doesn't do UTF-8... that's annoying 00:06 * dcook has encountered a UTF8 character that MARC::Record::new_from_xml really doesn't seem to like.. 00:10 dcook Hmm and maybe I see why.. 00:10 dcook It shows up like a funny little g on my terminal... but I can't find it in the UTF-8 table 00:10 dcook The hex looks like f09d 94a4 00:10 dcook But I only see... 00:10 dcook f0 9d 93 bf 00:10 dcook to 00:10 dcook f0 9e a0 80 00:11 dcook 𔤠00:11 dcook 𝔤 00:12 dcook Well that entity doesn't seem real.. 00:13 dcook Well technically it's not necessarily MARC::Record... so much as the XML parser 00:13 dcook But I was able to use XML::LibXML::Reader to parse it... 00:17 dcook I guess XML::LibXML::Reader uses libxml directly.. 00:20 dcook I guess I am failing the sax_parser_print.pl test... 00:21 dcook So it says I have XML::SAX::PurePerl... but I definitely have XML::LibXML::SAX::Parser on my system.. 00:28 dcook I wonder what the DOM parser uses... 00:29 dcook Ahh actually... maybe that's not it at all.. 00:29 dcook I have the full record, but somehow a partial record has wound up in Koha.. 00:30 dcook Ah yes this error is retrieving it from Koha and that's just a case of it being a bad record in there... but how did it get there.. 01:00 dcook Making a MARC::Record object just fine before C4::Biblio::AddBiblio... 01:00 dcook But AddBiblio isn't getting all the data into the db.. 01:01 * dcook better rebase before going too much farther 01:03 dcook Blahhh dependencies.. 01:03 * wizzyrea watches this monologue with amusement 01:03 dcook It's worse after rebasing :p 01:04 dcook Koha wants Mojo::JSON installd, but it's not listed by koha_perl_deps.pl... 01:04 dcook Bloody Koha/Object.pm...\ 01:04 dcook Looks like Mojo is now accidentally a dependency? 01:05 dcook Looks like a core module of Mojolicious as well.. 01:05 dcook Bug 17932 01:05 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Koha::Object should provide a TO_JSON method 01:06 wizzyrea https://video.twimg.com/tweet_video/C7oNEd_X0AE6QKF.mp4 01:07 wizzyrea seems appropriate for your current situation. 01:07 dcook hehe 01:07 * dcook shrugs 01:07 dcook If I recall correctly, installing Mojolicious is easy 01:07 dcook So I'm not too fussed. 01:07 dcook I mean... I'm still like that but about other things :p 01:09 dcook I also managed to download and import 10000 records in less than 5 minutes, so I'm not too fussed about 1 record not importing correctly. 01:09 dcook I mean... a little fussed. 01:19 dcook Ok with that out of the way.. 01:20 dcook Nope. Still screwed. Well at least this way I get to torubleshoot the fix without finding out someone has alrady fixed it... 01:22 dcook In the defense of Koha, it is some nasty bit of data 01:22 dcook Still shouldn't be croaking on it though.. 01:22 dcook Hurray for people who copy and paste html into notes fields... 01:22 dcook Although this is properly escaped.. 01:22 dcook H'okay.. 01:22 wizzyrea maybe just catch records with bs data and note them as exceptions? 01:23 dcook Well, I don't think this is bs data really 01:23 dcook MARC::Record has no problem with it either 01:23 dcook It's Koha for some reason... and I shall have an answer soon I think 01:24 dcook Something tells me TransformMarcToKoha is doing something bad... especially as biblio.notes is farked 01:25 dcook Hmm the record object survives that.. 01:25 dcook Or... no it doesn't? wtf.. 01:26 dcook Oh no it does.. 01:28 dcook The data is OK going into _koha_add_biblio()... maybe that one is a length limit thing.. 01:28 dcook Hmm probably not.. 01:29 dcook Maybe it's a database thing then.. 01:29 dcook That probably makes the most snse at this point 01:29 dcook utf8 columns in the db.. 01:30 dcook Has to be the database... 01:30 dcook The data is fine before the insert 01:31 dcook Well I'll take it out of Koha then and see what I can se.. 01:33 dcook Well that's special... 01:33 dcook If I take the same string and update biblio.abstract manually, it works fine 01:33 dcook But it doesn't via Koha 01:34 * dcook twitches just the slightest bit to wizzyrea's amusement 01:34 dcook Although it doesn't handle the utf8 correctly.. 01:34 dcook So let's see... 01:35 dcook Ok... my text file appears to contain utf8 encoded bytes.. 01:35 dcook But MySQL isn't interpretting it as UTF8.. 01:36 dcook If I double-check my latin 1 table I'll probably se it's reading it as latin 1.. 01:37 dcook Hmm... 01:42 dcook Really curious how "f0 9d 94 a4" is getting turned into "c3ad c2a0 c2b5 c3ad c2b4 c2a4" 01:43 dcook I suppose it's a longer string than just that so.. 01:45 dcook MySQL does not like this.. 01:45 dcook Shows one thing in the abstract, one thing in the Field Viewer.. 01:45 dcook I guess Koha is off the hook :p 01:46 * Francesca waves 01:46 wizzyrea hi Francesca 01:46 Francesca hello! 01:46 Francesca how are things going? 01:47 wizzyrea about the same really 01:47 wizzyrea how aabout you? 01:47 * dcook waves 01:47 dcook Wow, mysql command line client shows nothing at all.. 01:47 dcook But it's not null.. 01:47 dcook Huh... it thinks it's empty though.. 01:47 Francesca busy busy 01:47 * Francesca waves back at dcook 01:48 dcook So the mysql client and the MySQL GUI client are sending the data differently it seems.. 01:48 dcook Not surprising that DBI would have yt another behaviour.. 01:48 dcook And that none of them are errors... 01:48 dcook Because that would just be helpful.. 01:50 dcook Oh well. Too hard basket. 01:50 * dcook peaces out 01:50 dcook Or is it pieces.. 04:48 dcook Hey wizzyrea, I think I might have figured it out 04:48 dcook Well... not really 04:48 dcook But I think it has to do with mixed encodings... 04:51 dcook I'd say maybe I botched the encoding handling except for those 10,000 UTF8 encoded records which are fine 04:54 dcook So DBI should be using a UTF8 connection.. 04:54 dcook And mostly UTF8 data.. 05:23 dcook Huh... 05:23 dcook Apparently utf8 in MySQL only goes up to 3 bytes 05:23 dcook https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8.html 05:25 dcook Apparently utf8mb4 can let you use 4 bytes 05:25 dcook Which is needd for some CKJ ideographs 05:26 dcook https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8mb4.html 05:26 dcook TIL 05:30 dcook Huh... that was totally it 05:31 dcook Changed the column from utf8 to utf8mb4 and it worked 05:31 dcook Well kind of 05:31 dcook Stored the string, but the clients can't figure it out 05:31 dcook I wonder if.. 05:33 dcook Aha... yes it's because Koha was set to utf8 for the connection 05:33 dcook Bloody hell that's interesting 05:33 dcook Probably a waste of my afternoon figuring that one out but maybe this will impact Asian users of Koha.. 05:39 dcook @later tell wizzyrea The problem was that MySQL 'utf8' settings only support up to 3 bytes whereas my string had that 4 byte character. Apparently you have to use 'utf8mb4' to send/store 4 byte charactrs... 05:39 huginn` dcook: The operation succeeded. 06:54 kivilahtio matts_away: We have been using the API key system in production for two years or so with the REST API. 06:54 kivilahtio matts_away: code is here: https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/members/apikeys.pl 06:55 kivilahtio matts_away: we also need a proper OAuth2 implementation, but I am waiting for Tcohen and Ashimema since no pointfor me to reinvent the wheel thrice 06:56 kivilahtio no idea how long we can wait 06:56 kivilahtio problem is not very acute for us since we have our own authentication system and can easily extend it to whatever we need 06:57 kivilahtio in a hacky way 06:57 kivilahtio OAuth2 would be very nice 07:01 ashimema Lee has the OAuth2 library fixes schedules for 'The Perl Toolchain Summit' in early may: http://blogs.perl.org/users/book/2017/01/perl-toolchain-summit-2017.html 07:01 ashimema I aim to start back up on it for koha around the same time so I can catch bugs whilst he's in the zone with it. 07:45 marcelr hi #koha, #marseille 07:49 reiveune hello 07:53 bag morning 08:07 marcelr hi bag and reiveune 08:08 reiveune \o_ 08:27 fridolin hie tehre 08:27 fridolin I'm safe at home, its raining cats and dogs ;) 08:27 cait poor animals 08:28 LibraryClaire absolutely chucked it down last night 08:31 sophie_m hello #koha 08:32 cait @wunder Marseille 08:32 huginn` cait: Error: No such location could be found. 08:32 cait @wunder Konstanz 08:32 huginn` cait: The current temperature in Mainaustraße, Konstanz, Germany is 10.2°C (9:19 AM CET on March 24, 2017). Conditions: Mostly Cloudy. Humidity: 84%. Dew Point: 8.0°C. Pressure: 30.15 in 1021 hPa (Steady). 08:33 matts hi #koha ! 08:34 cait hi matts! 08:34 cait :) 08:35 matts cait, we had some drinks for people that weren't attending the hackfest, and we sure had one for you ! :) 08:37 atheia There were even some spare ones that stood amongst us (for a while at least)! 08:39 ashimema lol 08:39 gaetan_B hello 08:39 wahanui privet, gaetan_B 08:42 cait :) 08:58 ashimema mercelr I've added the tests to 12026 now.. thanks for the pointer they'd just slipped my mind with the amount of water under the bridge on that one.. felt it pertinent to add them though so I wrote them last night in the hope's I caught the bug before it was pushed.. feel free to check them but I've left the bug in 'Passed QA' state and added the test as a QA Followup patch. 09:07 marcelr hey ashimema dont use mercelr; might not catch it :) 09:10 marcelr pass with me, one without test description ok 11 09:14 ashimema poop.. sorry 09:16 ashimema and thanks.. I missed that ok.. was a late night ;) 09:19 ashimema fixed.. thanks for spotting it :0 09:20 marcelr ashimema: i will leave 17600 for you today and have a look later 09:20 ashimema sure thing 09:30 kidclamp . 10:47 fridolin bag: c'est pas faut ? :):):) 10:49 ashimema how's the hackfesters this morning.. all very queir 10:49 ashimema s/queir/quite 10:50 matts quiet ? 10:50 ashimema grr, I can't type today 10:51 cait hung over? 10:53 matts over the rainbow ? :) 10:54 marcelr eat too much pizzas? 10:59 LibraryClaire most are gone 10:59 LibraryClaire well, a lot 10:59 cait hm no manual for the advanced catalouging editor? 10:59 matts like in a lounge bar ? 10:59 matts ;) 11:00 cait bag: do you know if you have some instructions for 'rancor'? 11:01 LibraryClaire cait bag is gone 11:01 cait ah ok 11:01 cait well not ok... but :) 11:18 gaetan_B i have a question on modification template 11:18 gaetan_B i made a rule that says "Update field 942$a with value B if 942$a matches A" 11:18 gaetan_B i expected it to change 942$a A to B 11:18 gaetan_B which it did mostly 11:18 gaetan_B except when i have to $a in my 942, the first one with a value of C and the second with a value of A 11:19 gaetan_B in that case, the first one (C) was updated to B 11:19 gaetan_B sounds like a bug to me 11:19 matts gaetan_B, developpers http://68.media.tumblr.com/8a23ecb4a29f2219bd61cbfced3bfea4/tumblr_o1j55oez4H1udh5n8o1_400.gif 11:24 eythian hi 11:24 eythian @wunder ams 11:24 huginn` eythian: The current temperature in Schiphol, Badhoevedorp, Netherlands is 10.5°C (12:20 PM CET on March 24, 2017). Conditions: Partly Cloudy. Humidity: 69%. Dew Point: 5.0°C. Pressure: 30.45 in 1031 hPa (Rising). 11:29 * magnuse waves belatedly 11:45 * cait has a problem with translted csv exports.. AGAIN :( 11:46 cait could anyone check in their installation maybe? item search > csv in non english 11:46 cait it if't broken your csv has only 2 lines, header and the rest in one line 11:50 eythian cait: I don't think that last sentence is a sentence :) 11:52 cait maybe not 11:52 cait 2 lines, header line and all other 'lines/items' in the other line 11:53 cait the odd thing is that there is no visible difference in the translated templates :( 12:00 fridolin Joubu: FYI found Bug 18329 12:00 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 normal, P5 - low, ---, fridolin.somers, NEW , Batch record deletion broken 12:02 marcelr fridolin: Joubu is still sleeping? 12:12 fridolin maybe :) 12:19 vanic Hey Folks! New Koha user here from a small K-12 . Had a few questions if anyone didn't mind lending some advice. 12:21 eythian vanic: you're best off asking the questions, otherwise no one will know if they can help. 12:22 blou :) 12:23 vanic Ok sure. We just reciently upgraded our Library. Before We were using Athena, and we used it for years. Used to run on Windows 3.11 and then I moved it into a 98 SE Vm where it lived since. I just reciently researched Koha and set it up using Debian Jessie following. https://wiki.koha-community.org/wiki/Koha_on_Debian guidelines 12:24 vanic Everything went ok! . I then took on the task of getting data migrated. I managed to export the MARC data ok to a file and the patrons to a dbase file that I wrote a script to convert to CSV 12:24 vanic All good. then I realize the issue 12:24 vanic Athena was using 852$p for the barcode system. and koha now uses 952$p 12:25 vanic I tried to setup a mapping to the old field. and It said I had to run a script manually to make the changes. *one moment I'll get the output from it. but it has failed* 12:26 eythian you probably don't want to do that 12:26 eythian you would be better off changing the MARC records 12:26 vanic Thats what I'm told 12:26 vanic at least from googling all eveing yesterday 12:27 vanic so i'm wondering what my best option is 12:27 vanic if I go back and re-export the data. can I change all 8XX fields to 9XX fields on the Import? 12:28 vanic or is there a way I ran run something against the current data to change it 12:28 eythian I don't think koha can do that. 12:28 eythian (last I looked, this may have changed.) 12:29 eythian you're best talking to someone who has done a migration recently, I used to have scripts to do all this for me 12:29 eythian however, many of them are probably in Marseille, or in the process of going from there to their home 12:29 fridolin vanic: you may have a look at our Marc Transform scrvipt : https://git.biblibre.com/biblibre/tools/tree/master/migrations/transformiso2709 12:30 matts bye ! 12:31 eythian https://gitlab.com/catalyst-koha-migration-toolbox/koha-migration-toolbox/ there's more tools here, but they're not particularly tidy 12:31 vanic awesome! I'll review alot of this 12:33 eythian there's a huge monster script in there called 'csvtomarc.pl' which allows you to take a csv and produce marc from it. 12:33 eythian with some transformations along the way. 12:34 eythian If you read that script, I apologise in advance. It grew beyond a healthy size over the years :) 12:36 eythian (if I had cause to write it again, I think I'd make it its own language, rather than a huge command-line thing.) 12:38 magnuse vanic: there is also a popular tool valled MarcEdit, which is free to use, but not free software, that could do the shifting around of marc fields for you 12:39 marcelr magnuse: was there a marseille scoreboard somewhere? 12:40 magnuse marcelr: not that i have seen 12:40 marcelr ok 12:40 magnuse looks like http://scoreboard.koha-community.org/ still has the catalyst students on it 12:41 marcelr yes 12:41 marcelr chris was not in marseille 12:41 magnuse nope 12:41 magnuse if he was i would have gone too :-) 12:43 magnuse hm, i have a customer that has setup SMS and it works. they want to let user choose how they recieve messages, bit they do not want them to be able to turn on sms messages for checkouts and returns. is it possible to influence that at all, once sms is enabled? 12:43 magnuse i don't think it is 12:43 eythian @quote get 123 12:43 wahanui http://xkcd.com/1172/ 12:43 huginn` eythian: Quote #123: "rangi: #thingsihavelearnt if there is a mad scheme a library somewhere will be doing it ... except madder" (added by wizzyrea at 09:20 PM, March 30, 2011) 12:43 magnuse best option might be to use jquery to disable those checkboxes 12:43 magnuse the koha mantra :-) 12:52 marcelr bye #koha 12:52 cait it looks like the csv is still broken if the file actually gets translated 13:00 cait Joubu: the csv exports are broken again :( just commented on bug 16914 13:00 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 major, P5 - low, ---, josef.moravec, Pushed to Stable , Export csv in item search, exports all items in one line 13:08 francharb Good morning #koha 13:22 * cait waves 13:23 * magnuse waves 13:30 * oleonard waves, but feels bad because he waved later than everyone else and it looked awkward. 13:30 cait :) 13:32 Joubu hi 13:45 magnuse ¡hola Joubu y tcohen! 13:45 tcohen hola magnuse 13:46 tcohen Joubu++ 14:16 cait barton: not sure if the bug is there for CJK - I have seen marc records with all of those displayed ok in Koha 14:18 cait the utf8 one on the mailing list 14:18 barton right... 14:18 cait just irritated by that , i believe the bug is there for 4bit 14:20 cait *shrugs* 14:21 cait I might have to reread dcook's email first 14:21 barton Yeah, it's definitely not CJK specific; I think david's point was simply that CJK is probbly more likedly to have 4 byte characters. As long as there's an open bug for that, we're cool. 14:21 cait it seems he ran into it with math things 14:22 cait would be intereting to see a list of the characters that are affected, but can't figure it out right now 14:22 barton ok, that makes sense. 14:22 cait maybe it's onyl a few characters - i only know we once had a test set with chinese and korean and that looked ok - probably not using those 14:23 cait sorry, didn't want to confuse 14:23 * andreashm waves 14:25 barton presumably it's only un-common CJK characters in the 4-byte range. 14:25 barton hi andreashm! 14:25 barton morning jac! 14:25 tcohen ashimema already proposed this a couple years ago, shifting to utf8m4 14:26 jac morning barton 14:26 tcohen hi jac 14:26 jac hi tcohen 14:27 andreashm hi barton! 14:28 * andreashm is looking at screencast for the new calendar. 14:29 barton does the new calendar show the dawning of the age of aquarias? oh, wait. that would be 50 years old... 14:30 andreashm ...and reinstalling koahdevbox. as per usual. 14:30 paul_p liliputech SELECT issues1.borrowernumber, biblioitems1.isbn isbn1 ,biblioitems2.isbn isbn2 FROM issues issues2 14:30 paul_p LEFT JOIN issues issues1 ON issues2.borrowernumber=issues1.borrowernumber 14:30 paul_p LEFT JOIN items items1 ON issues1.itemnumber=items1.itemnumber 14:30 paul_p LEFT JOIN biblioitems biblioitems1 ON items1.biblionumber=biblioitems1.biblionumber 14:30 paul_p LEFT JOIN items items2 ON issues2.itemnumber=items2.itemnumber 14:30 paul_p LEFT JOIN biblioitems biblioitems2 ON items2.biblionumber=biblioitems2.biblionumber 14:30 paul_p WHERE issues1.issuedate LIKE '2017-03-22%' AND biblioitems1.isbn<>biblioitems2.isbn 14:30 liliputech thanks! 14:32 tcohen new calendar?? 14:32 andreashm bug 17015 14:32 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , New Koha Calendar 14:34 francharb tcohen, to get in, I'll suggest you read this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015#c46 ;) 14:34 huginn` 04Bug 17015: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , New Koha Calendar 14:34 andreashm ok, wtf just happened? why did my vagrant destory apparently also take out my synced repo? cause that folder is now empty too.... gaaaaaah! 14:34 tcohen inlibro++ 14:34 francharb :) 14:34 francharb thanks 14:35 tcohen close hours! 14:35 andreashm new calendar looks good. just wished it was even faster calculating fines! (yes, the grass is always greener somehwere else...) 14:37 blou andreashm: Hey, I could find a few more cpu cycles to cut if that's what it takes to get approval :) 14:37 andreashm blou: cut cut! =) 14:37 * andreashm was going to test. now I need to figure out what happened to my git repo instead. sigh. 14:38 tcohen can we get rid of the plural Koha::Objects? 14:51 ashimema hello 15:07 ashimema I'm gonna assume atheia just ran for a bus or somthing as h dissapeared 15:08 ashimema was there someone still playing with bug 18322 that wanted some input. 15:08 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add facets for ccode to zebra 15:09 mveron-away Hi again #koha 16:04 reiveune bye 17:26 edveal Hello 17:52 mveron Bye #koha 18:22 nuentoter is there a way to run an sql report to find items that are not in location "x, y, z" for example? 18:25 cait very close 18:25 cait location not in ("location a","location B") etc. 18:28 nuentoter ok i'm still learning proper syntax uugghhh TY Cait 18:28 cait np 18:46 huginn` New commit(s) kohagit: Bug 17792: Add opac_editable and opac_display methods <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b5c8cbf079725381341cea5494717d58735ca9b> / Bug 17792: Introduce Koha::Patron::Attribute(s) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9812c8b26e9886f0a7a79bbcefba1ac91ec7ed79> / Bug 17755: (followup) Override ->search to allow filtering by branchcode <http://git.koha-community.org/gi 18:50 Joubu Is PQA a LIFO ?! 18:57 huginn` New commit(s) kohagit: Bug 13757 - DBRev 16.12.00.016 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3db855b872ccbf133e238ddc537b6f0b818c931e> / Bug 13757: (QA followup) Filter out non-editable params before storing <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e06c1931872f2a54e2a12cf2b8468480e613ce5c> / Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable <http://git.koha-communit 18:58 jenkins Project Koha_Master_D8 build #136: STILL FAILING in 31 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/136/ 18:58 jenkins * kyle: Bug 17755: Introduce Koha::Object::Limit::Library 18:58 jenkins * kyle: Bug 17755: Unit tests 18:58 jenkins * kyle: Bug 17755: Introduce Koha::Patron::Attribute::Type(s) 18:58 jenkins * kyle: Bug 17755: (QA followup) Return $self when appropriate 18:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Introduce Koha::Patron::Attribute::Type(s) 18:58 jenkins * kyle: Bug 17755: (followup) Override ->search to allow filtering by branchcode 18:58 jenkins * kyle: Bug 17792: Introduce Koha::Patron::Attribute(s) 18:58 jenkins * kyle: Bug 17792: Add opac_editable and opac_display methods 18:58 jenkins * kyle: Bug 13757: Add the option to set patron attributes editable in the OPAC 18:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Introduce Koha::Patron::Attribute(s) 18:58 jenkins * kyle: Bug 13757: DB update 18:58 jenkins * kyle: Bug 13757: OPAC changes 18:58 jenkins * kyle: Bug 13757: DBIC update 18:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Make patron attributes editable in the opac if set to 'editable in OPAC' 18:58 jenkins * kyle: Bug 13757: Add extended attributes to the patron modification 18:58 jenkins * kyle: Bug 13757: (followup) Remove warnings 18:58 jenkins * kyle: Bug 13757: (followup) Staff interface changes 18:58 jenkins * kyle: Bug 13757: (followup) Only touch opac_editable attributes 18:58 jenkins * kyle: Bug 13757: (followup) Regression tests for ->approve changes 18:58 jenkins * kyle: Bug 13757: (followup) Fix authorized value display when opac_display & 18:58 jenkins * kyle: Bug 13757: (QA followup) Check DB structure before altering table 18:58 jenkins * kyle: Bug 13757: (regression tests) Empty attributes should delete existing 18:58 jenkins * kyle: Bug 13757: Make Koha::Patron::Modification->store del empty attrs 18:58 jenkins * kyle: Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion 18:58 jenkins * kyle: Bug 13757: (QA followup) Fix non-editable attrs on failed save 18:58 jenkins * kyle: Bug 13757: Make K::P::Modifications->pending return K::P::Attribute 18:58 jenkins * kyle: Bug 13757: Better display for attr changes in members-update.pl 18:58 jenkins * kyle: Bug 13757: (regression test) Attribute with value 0 should be stored 18:59 jenkins * kyle: Bug 13757: Attribute with value 0 should be stored 18:59 jenkins * kyle: Bug 13757: (QA followup) Exclude empty attributes from rendering if 18:59 jenkins * kyle: Bug 13757: (QA followup) Filter out non-editable params before storing 18:59 jenkins * kyle: Bug 13757 - DBRev 16.12.00.016