Time Nick Message
22:40 kchris Bye
22:39 cait bye kchris
22:39 * kchris appreciates the helpful koha community including cait, eythian, oleonard. going home now. Later.
22:11 dac You can take the person out of Koha, but you can't take Koha out of the person?
22:11 dac Looks like I just missed eythian
22:10 cait eythian++
22:10 kchris eythian++
22:10 kchris eythyian++
22:10 * eythian is going offline now, early morning. later
22:07 eythian yes, it's taking the value from $input with the name $field, and setting that in the db object
22:07 kchris Does this update the database object?
22:07 eythian yeah
22:06 kchris b: to get it out of the template, the script seems to handle this here:$library->$field( scalar $input->param($field) );
22:05 eythian probably yes
22:05 kchris eythian: to get it in the template, I can use a directive, eg. [% library.branchname %]
22:01 eythian if you want to have it save on op eq 'add_validate', then adding to that list of fields is probably what you want
21:59 eythian if you're looking at op eq 'list', it's probably there already
21:59 eythian b) get it from the template
21:59 eythian a) get it in to the template
21:58 eythian look at it in two steps because that's how the code is.
21:58 eythian where the ops are "add_form", "list", "delete_confirm", and so on
21:58 kchris well I want to access the database table in branches.tt so that I can read and write to it.
21:58 eythian i.e., what operation(s) do you need it to apply to?
21:58 eythian can you define "accessible" for me?
21:57 kchris simply adding the field I want to add to the list of fields in branches.pl is enough to make it accessible in branches.ttt?
21:57 kchris Once I have updated the table with my new field
21:55 eythian yeah, just from skimming it I'm 99% sure that's the case
21:55 eythian most likely they're database fields, and what it's doing is setting them
21:54 eythian oh, and $field comes from that list of fields right above
21:54 eythian (which may well be the same thing, really)
21:53 eythian so, it's either a database object, or a Koha::Libraries object, most likely.
21:53 eythian that makes it an object
21:53 eythian my $library = Koha::Libraries->find($branchcode);
21:52 kchris okay.
21:52 cait i think maybe you should look at koha:Library/Libraries
21:52 eythian well, I'd expect it to be more than a branchcode.
21:52 kchris is that right?
21:52 kchris so I need to see where the branchcode object is defined.
21:51 kchris oh. okay.
21:51 kchris it's a branchcode...
21:51 eythian you need to find the type of $library, and it'll be in whereever that is
21:51 kchris and then where is the method declared?
21:51 kchris okay.
21:50 eythian and inside that there is hopefully a method that has the same name as whatever '$field' contains
21:50 eythian $library is presumably an object
21:50 kchris I am trying to understand how to update the branches.tt template and how it works with the branches.pl script.
21:49 kchris And if so, where is the method declared?
21:49 eythian yeah, I think that's right. I try to avoid that sort of thing myself because it's not very nice.
21:49 kchris Is that right?
21:48 kchris Dynamically defined based on the value of the $field.
21:48 kchris It looks like a method call.
21:48 kchris in branches.pl, there is $library->$field()
21:47 eythian kchris: you should just ask
21:47 kchris Any Perl experts willing to field syntax question?
21:43 * cait waves
21:35 * kchris_away waves
21:32 Newbie_Koha Hi everyone,
20:09 kchris For those using kohadevbox, do people manage branches on their host or inside the virtualbox?
19:49 kchris To use git on the virtualbox, I guess I need to first reset the master branch?
19:48 kchris the master branch on the guest has many modified files.
19:47 kchris the master branch on the host and the master branch on the guest are different
19:47 kchris On Kohadevbox, when one brings a repo into a virtualbox for the first time...
18:25 kchris I need a better perl foundation too.
18:25 kchris Thanks for taking the feedback.
18:22 oleonard My Perl's pretty weak though so I can't say in detail.
18:21 oleonard Looks like it's taking the POSTed branchcode parameter and looking up the branch information based on that.
18:21 kchris Which I thought retrieves the value of the field from the template.
18:20 kchris It is followed by a list ( scalar $input->param($field))
18:20 kchris what exactly is $library->$field in the code snippet I submitted?
18:18 kchris exactly.
18:18 oleonard Add a column to the branches table?
18:18 kchris And make the purchase_suggestion enabled set on branches.tt
18:17 kchris Actually, I was going to drop the idea of a systempreference.
18:17 oleonard so you want the checkbox on the branch entry page to save data to the SuggestionLibraryList system pref
18:16 kchris Although the initial description of bug 12219 is a little different from what I had in mind.
18:15 kchris Yes.
18:14 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 enhancement, P5 - low, ---, koha-bugs, NEW , Purchase Suggestions branch level permissions
18:14 oleonard Bug 12219?
18:13 kchris oleonard: What I wanted to add a checkbox to the branches.tt file for enabling/disabling purchase suggestions.
18:13 oleonard Maybe that's why you're asking about the snippet you pasted?
18:12 oleonard You can backtrack from there to see where the variables are defined in the script.
18:12 oleonard kchris: If you're trying to understand how templates work, look for the part of the Perl script which starts "$template->param(". That is where the variables created in the script get passed to the template.
18:10 oleonard What are you hoping to do kchris ?
17:55 kchris On a positive note, I can now "bring" a Koha clone into my virtualbox :-)
17:53 pastebot "kchris" at 127.0.0.1 pasted "branches.pl" (4 lines) at http://paste.koha-community.org/331
17:53 kchris The following code in branches.pl doesn't fully make sense to me.
17:53 kchris Part of what I am missing is some basic perl understanding.
17:48 kchris I guess what I need is an introduction to cgi for koha.
17:47 kchris Are the basics documented somewhere?
17:47 kchris Hey #koha: I'm trying to wrap my head around how the template files (such as branches.tt) interact with the perl files (such as branches.pl) .
17:01 LibraryClaire laters #koha
16:27 reiveune bye
16:24 huginn` oleonard: The current temperature in Longview Hts, Athens, Ohio is 5.3°C (11:24 AM EST on February 27, 2017). Conditions: Rain. Humidity: 99%. Dew Point: 5.0°C. Windchill: 5.0°C. Pressure: 30.32 in 1027 hPa (Steady).
16:24 oleonard @wunder 45701
16:23 drojf bye #koha
16:12 huginn` drojf: The current temperature in Lotissement le Pitalugue, Vitrolles, France is 12.7°C (5:05 PM CET on February 27, 2017). Conditions: Light Rain. Humidity: 83%. Dew Point: 10.0°C. Pressure: 29.92 in 1013 hPa (Falling).
16:12 drojf @wunder marseille, france
16:07 LibraryClaire soon...
16:07 LibraryClaire gosh, I can only dream of 20
16:01 talljoy i must be thin skinned!
16:00 talljoy i'm freezing today and it is 20C here in Texas
16:00 talljoy brrrrr
15:53 LibraryClaire 12 feels positively tropical
15:53 LibraryClaire it was -2 when i cycled to work this morning
15:51 * talljoy reaches for a coat at 12 C
15:43 * LibraryClaire sunbathes
15:42 huginn` LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is 12.4°C (4:34 PM CET on February 27, 2017). Conditions: Clear. Humidity: 52%. Dew Point: 3.0°C. Pressure: 29.65 in 1004 hPa (Steady).
15:42 LibraryClaire @wunder konstanz
15:34 huginn` drojf: The current temperature in Berlin Schoenefeld, Germany is 12.0°C (4:20 PM CET on February 27, 2017). Conditions: Mostly Cloudy. Humidity: 54%. Dew Point: 3.0°C. Pressure: 29.56 in 1001 hPa (Steady).
15:34 drojf @wunder sxf
15:31 cait some divs are not closed... there are 63 open divs and 61 clsoed... but ... but... how?
15:31 * cait grumps at html validate
15:27 kholt Hi LibraryClaire!
15:26 LibraryClaire hi kholt
15:17 kholt good morning!
14:20 Joubu Is Authorities search broken again with ES?
14:01 huginn` gmcharlt: Quote #315: "Pianohacker: crazy around a bunch of people that are the center of the venn-diagram of programmers and librarians is always a bit relative." (added by wizzyrea at 03:26 AM, July 21, 2015)
14:01 gmcharlt @quote random
13:44 oleonard Hi druthb
13:36 druthb Good morning, #koha.
13:09 LibraryClaire that grue got him good, huh
13:08 LibraryClaire :D
13:08 wahanui hi oleopard
13:08 LibraryClaire hi oleonard
12:56 oleonard Hi all
12:52 marcelr fine
12:52 khall heh, can do!
12:52 marcelr ^^
12:51 khall marcelr: sure! which ones?
12:51 marcelr these are 17736 and 17737; still apply, in SO queue
12:51 marcelr khall: could you qa two hold bugs from joubu that i signed off ?
12:49 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add a new table to store authorized value categories
12:49 Guest1381 kyle: Bug 17216: Fix SQL statement to setting
12:49 Guest1381 Project Koha_Master_D8 build #121: STILL UNSTABLE in 1 hr 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/121/
12:33 drojf do we know what the "rdf day" at the hackfest is supposed to be, aside from bywater putting work into it?
12:32 drojf :D
12:32 marcelr we need a ++ with ironic meaning
12:32 marcelr :)
12:32 drojf marcelr: for being unlocatable?
12:30 marcelr OverDrive++
12:30 marcelr Can't locate WebService/ILS/OverDrive/Patron.pm in @INC
12:06 francharb Good morning #koha
11:52 magnuse ok sru explain documents, here i come
11:46 huginn` drojf: The operation succeeded.
11:46 drojf @later tell khall master packages are failing http://paste.koha-community.org/330
11:45 pastebot "drojf" at 127.0.0.1 pasted "Failed test 'use Koha::ExternalContent::OverDrive;'" (18 lines) at http://paste.koha-community.org/330
11:13 huginn` New commit(s) kohagit: Bug 17216: Fix SQL statement to setting marc_subfield_structure.authorised_value... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=11bae489bc85a9463712c9caafd2caf7b63155d9>
11:06 Joubu yep
11:06 marcelr Joubu: added the fail, and removed the can call, but parsing $@ should be another report
11:05 rsantellan good morning
11:04 marcelr hi tcohen
11:04 drojf hi tcohen
11:04 tcohen morning
11:03 huginn` drojf: The operation succeeded.
11:03 drojf @later tell mtj please push 17111 and 18018, i can't build the 16.05.10 package without them
11:02 khall I'll take care of that right now
11:01 Joubu the patch I quote in comment 105
11:01 khall which patch?
11:00 Joubu and 16.11 as well actually
11:00 Joubu one patch is missing in master
11:00 khall I don't think so
11:00 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add a new table to store authorized value categories
11:00 Joubu It was about bug 17216, last comment
11:00 Joubu Hi khall! Did you get my later last week?
10:56 Joubu use eval, and if it fails we parse $@ and raise the appropriate exception
10:56 Joubu I faced this problem few weeks ago, thought I fixed it but did not find the patch
10:56 marcelr what do you mean
10:55 Joubu marcelr: maybe it would be better to parse the error
10:55 marcelr it said there was no method, while we had an error from the method
10:55 marcelr but the error message was obscure
10:55 marcelr is it not needed
10:54 Joubu +is
10:54 Joubu That why we used eval actually
10:54 Joubu I am also wondering if the fact to call ->can every time would not introduce perf issue
10:53 marcelr ok :)
10:53 Joubu so fail instead of ok
10:52 marcelr yeah but this is more clear
10:52 Joubu we should not need it, the tests will fail because the number of tests is wrong
10:51 marcelr normally i should not come there, but i wanted to match the tests
10:51 marcelr or does it quit
10:51 marcelr is fail doing the same?
10:50 Joubu marcelr: ok(0) should be fail() ;)
10:44 marcelr gsm?
10:43 marcelr thx Joubu: adjusted the patchgsm
10:10 Joubu the data has not been updated in the DB if the update has failed
10:09 Joubu marcelr: You need to refetch the object from the DB
10:07 Joubu marcelr: I would expect no data updated at all
09:59 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 enhancement, P5 - low, ---, m.de.rooy, ASSIGNED , Add update to Koha::Object
09:59 marcelr Joubu: the test on bug 18174 fails most often, but may pass too with me
09:53 marcelr ok
09:53 Joubu not related, but there are 2 methods
09:52 Joubu marcelr: "Note that update_all will run DBIC defined triggers, while "update" will not."
09:51 marcelr will put it on a new report, so you can see the test
09:50 marcelr the same will hold for update in Koha Objects already
09:50 Joubu but if it does not, we can do it
09:50 Joubu I would have expected DBIx::Class to care about that actually
09:50 marcelr and was amazed about the results
09:50 marcelr i added it in a unit test
09:50 Joubu in that case we could call it in a transaction
09:50 Joubu why do you want to update a wrong column? :)
09:49 marcelr sometimes good_column gets updated, sometimes not (just depends on the order executed; at random?)
09:49 marcelr update is quite unreliable in this case: update({ good_column =>1, wrong_column => 2 })
09:48 marcelr Joubu: about adding update to Koha::Object ?
09:44 magnuse Joubu++
09:44 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Remove issues.return
09:44 Joubu magnuse: bug 18173
08:36 AndrewIsh Goooood morning #koha! Has anyone who's done stuff with the REST API ever encountered a "Method not allowed" on PUT? We're seeing it. Google suggests it's Apache config related, but the config looks fine. Wondering if anyone is aware of anything else that could cause it?
08:10 marcelr hi fridolin
08:10 LibraryClaire hi ashimema
08:10 LibraryClaire salut fridolin
08:10 marcelr morning ashimema
08:10 ashimema morning
08:10 * magnuse congratulates fridolin on the new haircut
08:09 magnuse kia ora ashimema and fridolin
08:09 fridolin hie there
08:06 magnuse Joubu: i'll sign off
08:06 drojf ha
08:06 magnuse it's also a reserved name in mysql so "select return from issues" gives an error
08:06 drojf thecolumnformerlyknownasreturn
08:06 drojf tcfkar
08:05 Joubu drojf: Let's rename it 'useless' and use it, 'return' is too generic
08:04 Joubu I can open a bug report to remove it :)
08:04 Joubu And nobody knows what the point of this field
08:04 drojf hi Joubu
08:04 drojf let's use it now :P
08:04 Joubu and it was not used at that time (2001)
08:04 Joubu where this field first came up
08:03 Joubu magnuse: I dug up to commit number 47 of Koha repo
08:00 marcelr yeah return should never be the name of a column
07:59 magnuse hard to prove that it is not used anywhere though, what with "return" being a perl thing
07:58 marcelr hi Joubu
07:58 magnuse just one of those "nice to have" things, then :-)
07:58 LibraryClaire bonjour Joubu
07:58 magnuse nice! :-)
07:57 Joubu issues.return even
07:57 Joubu magnuse: issue.return has never been used apparently
07:57 Joubu hi #koha
07:56 marcelr o/
07:56 reiveune \o_
07:56 magnuse hiya reiveune and marcelr
07:48 reiveune hello
07:47 marcelr morning LibraryClaire
07:46 LibraryClaire hi marcelr
07:46 LibraryClaire salut alex_a
07:42 drojf :)
07:42 marcelr gute morgen droif
07:42 drojf hi alex_a and marcelr
07:42 marcelr hi #koha
07:42 alex_a bonjour
07:41 magnuse where's rangi when you need him ;-)
07:41 magnuse or maybe how issues were marked as returned before there was old_issues? just a thought
07:38 drojf it might be an old version of a due_date
07:38 drojf magnuse: don't know either. never used it
07:37 cait bbiab
07:37 cait bbia
07:37 cait ithink probably unused
07:37 * magnuse wonders if he will be able to figure out how to add modifiers to the zebra sru config
07:36 magnuse moin drojf
07:36 drojf hei magnuse
07:36 magnuse i have a hunch it is not used anymore
07:36 LibraryClaire magnuse: I saw that too but don't know either - would liek to know :D
07:35 LibraryClaire hei magnuse
07:32 huginn magnuse: The current temperature in Bodo, Norway is -3.0°C (8:20 AM CET on February 27, 2017). Conditions: Scattered Clouds. Humidity: 64%. Dew Point: -9.0°C. Windchill: -11.0°C. Pressure: 29.30 in 992 hPa (Steady).
07:32 magnuse @wunder enbo
07:32 huginn magnuse: Error: No such location could be found.
07:32 magnuse @wunder boo
07:30 magnuse brinxmat and i are still wondering what issues.return is for: https://twitter.com/brinxmat/status/834689646131105794
07:30 * magnuse waves
07:28 drojf server down, vpn not working, yay monday
07:20 drojf hi LibraryClaire
07:20 LibraryClaire moin drojf
07:14 huginn drojf: The current temperature in Berlin Schoenefeld, Germany is 7.0°C (7:50 AM CET on February 27, 2017). Conditions: Mostly Cloudy. Humidity: 71%. Dew Point: 2.0°C. Windchill: 4.0°C. Pressure: 29.77 in 1008 hPa (Steady).
07:14 drojf @wunder sxf
07:13 drojf hi #koha
07:06 LibraryClaire morning #koha
03:19 Guest1381 kyle: Revert "Bug 12461 - Add patron clubs feature"
03:19 Guest1381 Project Koha_Master_D8 build #120: STILL UNSTABLE in 1 hr 35 min: https://jenkins.koha-community.org/job/Koha_Master_D8/120/
02:43 wizzyrea :)
02:43 aleisha AH
02:43 wizzyrea just for example
02:43 wizzyrea https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
02:42 aleisha o
02:42 wizzyrea yeah
02:42 aleisha is that why i cant apply bugs
02:42 wizzyrea yeah it's out of space or something
02:42 aleisha bugzilla is mad?
02:30 wizzyrea ooo bugzilla is really mad now
01:42 wizzyrea yay thank you
01:42 wizzyrea heh
01:42 huginn New commit(s) kohagit: Revert "Bug 12461 - Add patron clubs feature" <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8255344215e79a5274b05033cae4bcad8d441391>
01:09 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 new feature, P5 - low, ---, kyle, Needs Signoff , Add patron clubs feature
01:09 wizzyrea bug 12461
01:09 wizzyrea I'm not even sure 12461 was supposed to be pushed to master.
00:50 wizzyrea hm, bugzilla seems to have an out of space kind of problem.
00:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18171 blocker, P5 - low, ---, oleonard, NEW , Patron Clubs feature breaks logging in/display of logged in users
00:15 wizzyrea bug 18171
00:11 wizzyrea which of course is the default state.,
00:11 wizzyrea - The method get_club_enrollments_count is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. if no clubs are defined
00:09 wizzyrea the error is different if you don't have any clubs defined
00:09 wizzyrea Template process failed: undef error - The method size is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
00:08 wizzyrea hi, the patron clubs feature seems to break logged in users.