Time Nick Message
21:49 wizzycray er, hi
21:49 wizzycray hui
21:23 huginn cait: The operation succeeded.
21:23 cait @later tell Joubu - please take a look at Bug 17988 - Select2 prevents correct tag expand/minimize functionality thx!
20:19 huginn magnuse: The current temperature in Bodo, Norway is 4.0°C (8:50 PM CET on February 14, 2017). Conditions: Mostly Cloudy. Humidity: 100%. Dew Point: 4.0°C. Windchill: 0.0°C. Pressure: 30.42 in 1030 hPa (Falling).
20:19 magnuse @wunder enbo
19:47 huginn cait: The current temperature in Jungerhalde, Konstanz, Germany is 2.1°C (8:24 PM CET on February 14, 2017). Conditions: Mist. Humidity: 83%. Dew Point: -0.0°C. Windchill: 2.0°C. Pressure: 30.48 in 1032 hPa (Steady).
19:47 cait and somewhat shiveringly
19:47 cait @wunder Konstanz
19:47 * cait waves eveningly back
19:47 * magnuse waves eveningly
19:18 cait aleisha++
19:15 CrispyBran Got to do lunch and meeting. Will be back...
19:14 huginn 04Bug 14962: enhancement, P5 - low, ---, gmcharlt, NEW , Temp Shelving Location
19:14 CrispyBran Also wondering if the hiding of columns actually removes the columns for perfomance. The reason I am wondering this is because of some information that it takes away, even though it is not displayed. It is loosely tied in with another idea I have been tinkering with and discussing here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962
19:10 huginn 04Bug 15441: enhancement, P5 - low, ---, koha-bugs, NEW , columns_settings.pl: Circulation issues-table - cannot toggle checkin column
19:10 CrispyBran oleonard - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441
19:08 CrispyBran I've been tinkering with some ideas.
19:08 CrispyBran What am I NOT trying to do ;)
19:07 oleonard CrispyBran: What are you trying to do?
17:56 CrispyBran It looks like the column visibility feature actually removes the column. It isn't just hiding it. If removing the column causes issues, then what if this particular option just turned the display of the column on and off? Do you know if this preference removes the column altogether for performance?
17:53 CrispyBran Actually, we are using css with a setting of display:none on that column. It has not had any adverse effects to my knowledge, and we've had it that way from the beginning.
17:51 kidclamp it would be very nice if you could just switch it on/off in the config
17:51 kidclamp the trick with that one is the buttons - need to adjust them based on that column, or make them part of them column
17:51 CrispyBran That's no fun
17:50 kidclamp no, it lists all columns but some aren't available
17:50 CrispyBran okay. Like the checkin on the issue-table. We don't use it. I have it hidden through jQuery, but since it is showing here, I thought it would be an option.
17:49 kidclamp which specifically? some columns cannot be editied via this tool
17:47 CrispyBran kidclamp, ideas on why the configuration would be greyed out?
17:46 CrispyBran Wait, thought you meant Administration as in Administration tab. Got it. Found it.
17:40 CrispyBran Must be in a newer version? Not seeing it in 3.22
17:38 kidclamp Adminsitration->Additional parameters -?Configure columns
17:37 CrispyBran kidclamp, where is the admin setting for the column visibility?
17:15 jenkins * kyle: Bug 15503 (QA Followup)
17:15 jenkins * kyle: Bug 15503 - Populate the order prices
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 enhancement, P5 - low, ---, matthias.meusburger, Pushed to Master , Grab Item Information from Order Files
17:15 jenkins * kyle: Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch
17:15 jenkins * kyle: Bug 15503 [QA Followup] - Set itype and ccode properly
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 trivial, P5 - low, ---, veron, Pushed to Master , Batch item modification: Better message if no item is modified
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 trivial, P5 - low, ---, m.de.rooy, Pushed to Master , Adjust some POD lines, fix a few typos
17:15 jenkins * kyle: Bug 15503 - DBRev 16.12.00.008
17:15 jenkins * kyle: Bug 15503 [QA Followup] - Display "uneven number of fields" error only
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 minor, P5 - low, ---, chloealabaster, Pushed to Master , Staff client list errors are incorrectly styled
17:15 jenkins * kyle: Bug 15503 [Followup] - Add replacementprice and itemcallnumber
17:15 jenkins * kyle: Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 minor, P5 - low, ---, nick, Pushed to Master , JavaScript error on item search form unless LOC defined
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 minor, P5 - low, ---, adrien.saurat, Pushed to Master , Patron stats, patron activity : no active doesn't work
17:15 jenkins * kyle: Bug 15503 - Fix adding multiple items in multiple biblios.
17:15 jenkins * kyle: Bug 15503: Grab Item Information from Order Files
17:15 jenkins * kyle: Bug 18095: Batch item modification: Better message if no item is
17:15 jenkins * kyle: Bug 17935: Follow up for C4::Plugin...
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 minor, P5 - low, ---, m.de.rooy, Pushed to Master , Fix the use of uniq in sub themelanguage
17:15 jenkins * kyle: Bug 17935: Adjust some POD lines, fix a few typos
17:15 jenkins * kyle: Bug 15584 - Staff client list errors are incorrectly styled
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 normal, P5 - low, ---, kyle, Pushed to Master , All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 normal, P5 - low, ---, crazy.mental.onion, Pushed to Master , Availability limit broken until an item has been checked out
17:15 jenkins * kyle: Bug 18047 - JavaScript error on item search form unless LOC defined
17:15 jenkins * kyle: Bug 8306: Patrons statistics, fix for patron activity choice
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 normal, P5 - low, ---, m.de.rooy, Pushed to Master , AddAuthority should respect AUTO_INCREMENT
17:15 jenkins * kyle: Bug 17982: Fix the use of uniq in sub themelanguage
17:15 jenkins * kyle: Bug 17982: Expose wrong use of uniq
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 normal, P5 - low, ---, magnus, Pushed to Master , bulkmarcimport.pl allows -b and -a to be specified simultaneously
17:15 jenkins * kyle: Bug 18089: Remove warnings from tests using DBIx::Class fixtures
17:15 jenkins * kyle: Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 normal, P5 - low, ---, mtj, Pushed to Master , IssueSlip.t test fails if launched between 00:00 and 00:59
17:15 jenkins * kyle: Bug 18089 - Unit test
17:15 jenkins * kyle: Bug 17838 Availability limit broken until an item has been checked out.
17:15 jenkins * kyle: Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison
17:15 jenkins * kyle: Bug 18014: AddAuthority should respect AUTO_INCREMENT
17:15 jenkins * kyle: Bug 18014: Add test to AuthoritiesMarc.t to expose problem in
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 normal, P5 - low, ---, tomascohen, Pushed to Master , (MARC21) $9 fields not indexed in authority-linked fields
17:15 jenkins * kyle: Bug 18014: General update of AuthoritiesMarc.t
17:15 jenkins * kyle: Bug 4126 - Exit bulkmarcimport if -a and -b given
17:15 jenkins * kyle: Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59
17:15 jenkins * kyle: Bug 17788: (MARC21) Add $9 fields to Koha-Auth-Number:w index
17:15 jenkins Project Koha_Master_D8 build #108: STILL UNSTABLE in 1 hr 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/108/
17:06 oleonard-away tcohen: Finally had time to finish setting up kohadevbox on my Mac at home and yay for kohadevbox!
16:58 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 enhancement, P5 - low, ---, tomascohen, Needs Signoff , koha-create should create the template cache dir and configure it in koha-conf.xml
16:58 tcohen bug 17951
16:57 tcohen marcelr Joubu please review the template_cache_dir for packages
16:51 reiveune bye
16:13 alex_a yes i did
16:13 Joubu alex_a suggested to store the values in the DB
16:12 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 enhancement, P5 - low, ---, alex.arnaud, Needs Signoff , Apply KohaTable and ColVis plugin on MARCdetail's items table
16:12 Joubu see bug 16881
16:08 tcohen we could definitely save it on the session cookie
16:07 cait yep
16:06 kidclamp changing it on the fly resets I believe - changing in admin will make permanent changes
16:03 CrispyBran Question for the room: does column visibility not retain settings? Do you have to change it with every screen change?
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 normal, P5 - low, ---, m.de.rooy, Pushed to Master , Improve handling dates in C4::Items
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 normal, P5 - low, ---, synapse.ova, Pushed to Master , Select2 prevents correct tag expand/minimize functionality
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 normal, P5 - low, ---, gmcharlt, Pushed to Master , Facet's area shows itemtypes' code instead of item's description
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Standing orders - when ordering a JS error is raised
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 critical, P5 - low, ---, jonathan.druart, Pushed to Master , Holds not going to waiting state after having been transferred
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Error when placing a hold and holds per record is set to 999
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079 normal, P5 - low, ---, josef.moravec, Pushed to Master , Cleanup of holds to pull page
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073 enhancement, P5 - low, ---, josef.moravec, Pushed to Master , Holds to pull UI improvements
15:38 jenkins * kyle: Bug 17512: Improve handling dates in C4::Items
15:38 jenkins * kyle: Bug 17988: Add a comment to explain the line
15:38 jenkins * kyle: Bug 17988 - Select2 prevents correct tag expand/minimize functionality
15:38 jenkins * kyle: Bug 17134: Replace item types codes with category in facets (opac)
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 normal, P5 - low, ---, jonathan.druart, Pushed to Master , JavaScript error on item search form unless NOT_LOAN defined
15:38 jenkins * kyle: Bug 16984: Do not clone the item block for standing orders
15:38 jenkins * kyle: Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer
15:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 normal, P5 - low, ---, luke.honiss, Pushed to Master , Hold Request Confirm Deletion
15:38 jenkins * kyle: Bug 18076: Replace holds_to_place_count with an input type=text
15:38 jenkins * kyle: Bug 18079: Holds to pull cleanup
15:38 jenkins * kyle: Bug 18073: Followup - don't use CONCAT_WS
15:38 jenkins * kyle: Bug 18073: Holds to pull table enhancement
15:38 jenkins * kyle: Bug 16115: Remove JS error on item search if NOT_LOAN values do not
15:38 jenkins * kyle: Bug 11450: Hold Request Confirm Deletion
15:38 jenkins Project Koha_Master_D8 build #107: STILL UNSTABLE in 1 hr 40 min: https://jenkins.koha-community.org/job/Koha_Master_D8/107/
15:36 tcohen (i mean, subfields)
15:36 tcohen do people tend to change 952?
15:20 huginn New commit(s) kohagit: Bug 15503 (QA Followup) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2d427b25aa778c7eafbc67af066f849c32b7cf06> / Bug 15503 - Populate the order prices <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=aa2ecb58d5a298a705d8b783bfa8b57834296048> / Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch notforloan values. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=
15:10 huginn New commit(s) kohagit: Bug 15503 - DBRev 16.12.00.008 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1d2001803cd0f2851bbd37b9664f2ed9569760dd>
15:00 huginn New commit(s) kohagit: Bug 15503 [QA Followup] - Display "uneven number of fields" error only in relevant... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=261747e477fa19c8cff3c689685f37a45bcc9e66> / Bug 15503 [Followup] - Add replacementprice and itemcallnumber <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=35076653a4c8161da981150b4f8d74111a2a87e3> / Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
14:39 huginn New commit(s) kohagit: Bug 18095: Batch item modification: Better message if no item is modified <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=adca73545e75c31198e3d094512da7961460ed02>
14:19 huginn New commit(s) kohagit: Bug 17935: Follow up for C4::Plugin... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7704478836c42088519bb4a91833720d921bc890> / Bug 17935: Adjust some POD lines, fix a few typos <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b4c66d5cc4be5ca555799a719ff07ffae5b2f45f> / Bug 15584 - Staff client list errors are incorrectly styled <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdi
14:16 cait khall++
14:09 huginn New commit(s) kohagit: Bug 17982: Fix the use of uniq in sub themelanguage <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5c1daf010ec97ed405bf7825eaa8143c225252b1> / Bug 17982: Expose wrong use of uniq <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=460c9b1b1594b8beebedbc28809fe47bc8d3313c> / Bug 18089: Remove warnings from tests using DBIx::Class fixtures <http://git.koha-community.org/gitweb/?p=koha.git;a=comm
13:59 huginn New commit(s) kohagit: Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=add15799229df7a1910d759f487c0006bf3f30ae> / Bug 17788: (MARC21) Add $9 fields to Koha-Auth-Number:w index <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=21d63c8fb0c2ae3a8ca7caaf0d4041b7189213c3> / Bug 17512: Improve handling dates in C4::Items <http://git.koha-community.or
13:49 huginn New commit(s) kohagit: Bug 18079: Holds to pull cleanup <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=95873bfa88d3f18350acdd3fea3d421083a59950> / Bug 18073: Followup - don't use CONCAT_WS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a1f348fe5cbdcc00194f4e0f4410ad71c57ad7b0> / Bug 18073: Holds to pull table enhancement <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3732e8dcb2899ff446aa9ec4e4
13:18 francharb hi LibraryClaire
13:18 LibraryClaire hi francharb
13:18 francharb depressing
13:17 wahanui the only good morning is a dead one
13:17 francharb Good morning
13:15 cait matts: thx for trying!
13:14 cait both of them
13:14 cait it's on the string bugs push fast wish list
13:14 cait talked to kyle ealrier
13:14 cait ooh yep
13:14 huginn drojf: The current temperature in Berlin, Berlin, Germany is -0.4°C (1:44 PM CET on February 14, 2017). Conditions: Clear. Humidity: 90%. Dew Point: -2.0°C. Windchill: -2.0°C. Pressure: 30.57 in 1035 hPa (Falling).
13:14 drojf @wunder berlin, germany
13:14 matts hi cait. Tried to setup a test CAS server myself, didn't succeed. Still waiting for our sysops to work on it.
13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 minor, P5 - low, ---, nick, Passed QA , JavaScript error on item search form unless LOC defined
13:14 cait bug 18047
13:14 kidclamp probably want 18047 too with 16115 cait
13:13 cait kidclamp++
13:12 cait nice :)
13:12 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 normal, P5 - low, ---, jonathan.druart, Passed QA , JavaScript error on item search form unless NOT_LOAN defined
13:12 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 normal, P5 - low, ---, jonathan.druart, Passed QA , Error when placing a hold and holds per record is set to 999
13:12 cait bug 18076, bug 16115
13:12 cait you don't have permission to access / on this server *sigh*
13:11 cait because it's still not working :(
13:11 cait yeah but obviously my notes for dev installation are wrong
13:11 drojf 2.2 was the bad one :P
13:11 drojf new apache is good apache
13:11 cait and now it's the new apache all over again
13:11 cait updated debian
13:11 drojf hi jcamins!
13:10 LibraryClaire das
13:10 jcamins Apache hates everyone. Don't take it personally.
13:10 * LibraryClaire hates German grammar
13:10 drojf poor apache
13:10 cait her...
13:09 * cait hates apache and apache hates me
13:00 cait great thx!
13:00 kidclamp got it, 16115 is PQA but looking at 18076
13:00 cait kidclamp: left yo a later ;)
12:59 cait matts: any news about the cas issue?
12:58 kidclamp hi cait
12:58 cait hi matts
12:58 wahanui hmmm... kidclamp is rockin the stache
12:58 cait hey kidclamp
12:49 wahanui LibraryClaire: sorry...
12:49 LibraryClaire wahanui got mean :O
12:49 wahanui hi dear loon
12:49 LibraryClaire hi oleonard
12:46 oleonard Hi all
12:28 cait they shoudl both not be hard
12:27 cait Joubu is out,... who else. tcohen? :)
12:23 cait kidclamp_away maybe?
12:22 cait woudl like to have them in before string freeze tomorrow.... ideallly
12:22 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 normal, P5 - low, ---, jonathan.druart, Passed QA , JavaScript error on item search form unless NOT_LOAN defined
12:22 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 normal, P5 - low, ---, jonathan.druart, Signed Off , Error when placing a hold and holds per record is set to 999
12:22 cait bug 18076, bug 16115
12:22 cait looking for a qa person
12:21 cait drojf: hm i think not, 16.05 is my guess
12:20 oha Joubu: thanks for the help!
12:20 oha or at least, i want it to NOT change anything from the functional point of view
12:20 * cait waves
12:20 oha Joubu: i don't. I think someone that understand the code have a look at it, since it's more refactoring than functional changes
12:14 huginn tcohen: The operation succeeded.
12:14 tcohen @later tell dcook take AddReturn for instance, you will notice it calls ModItem, which certaintly calls ModZebra
12:12 tcohen mornin
11:39 drojf i closed a few file upload related bugs. upload is not in 3.22, right?
11:38 rsantellan good morning #koha
11:34 Joubu Have to run, lunch time! See you later
11:34 Joubu if you have a step by step non-regression plan, you can get someone that is not a developper testing it
11:33 Joubu oha: next step is to find someone to test it, but without test plan you will only get guys that can read the code, understand it and know how to test it
11:33 Joubu feel free to let it as it, just an advice
11:32 Joubu oha: ok but better the commit message is and explain what the patch does, easier you will get testers and QAers looking at it ;)
11:31 oha easier to understand it nesting the booking instead of the members
11:30 Joubu yes indeed, but that's make more sense like that.
11:30 oha the point is avoid to check the same book several time after the first match
11:30 oha Joubu: the don't have to. i refactor it to be more readable
11:29 Joubu oha: then explain why the 2 loops must be inversed
11:29 oha Joubu: I dumped our staging db for that :(
11:28 Joubu oha: A way to recreate the perf issue would be good. That way a test plan would be "1. recreate the conditions 2. confirm it's slow 3. then apply your patches and 4. confirm that it is quicker"
11:26 oha you all probably know better how to test it?
11:26 oha regarding the test plan, i'm not really sure what to say. I believe it will work the same way since the type of changes i did
11:24 oha yup agreed
11:23 Joubu Yes I think it would be better to discuss it on another bug report
11:23 oha sorry, i meant you told me to do, not you want me to do
11:23 oha yes, it shouldn't be there
11:22 Joubu oha: I understood that you would move the "pure" part to another report, am I wrong?
11:22 Joubu oha: commit message should be better, explain what you do, etc. + a test plan
11:22 Joubu oha: it's not what *I* want, but the community's guidelines ;)
11:19 oha should be as you want Joubu
11:19 oha great
11:16 oha lets see if it works
11:15 Joubu -e will allow you to edit some fields of the bug report
11:15 Joubu then obsolete the existing patches uncommenting the lines
11:15 oha ok
11:14 Joubu oha: you can do it with `git bz attach -e 17941 HEAD~$c^.." with $c = number of patch-1 you want to attach
11:13 oha Joubu: should i deprecate the other patches and send the new ones again in the proper order?
11:09 oha yes
11:08 Joubu $_ is wrong, should be $b
11:08 Joubu oha: + my $borr = $borrowers{$b}//= C4::Members::GetMember(borrowernumber => $_);
11:08 Joubu o
11:07 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 major, P5 - low, ---, oha, Needs Signoff , CanBookBeRenewed is very inefficient/slow
11:07 Joubu and commit message must start with "Bug 17941: ", not "BZ"
11:07 Joubu oha: you should also obsolete the 2 first patch (Details > edit details > obsolete > submit)
11:07 oha oh
11:06 Joubu the first one "typo" seems to be the last one
11:06 Joubu oha: the patches should be in the correct order, otherwise they will not apply
11:04 oha Joubu: should be ok
10:52 oha I also finished putting together a proper module with documentation for the memoization too, but it has become less relevant here
10:52 oha I think it should work as it is, it is just a transformation of the same logic. but would be nice to have another pair of eyes on it
10:51 ashimema indeed, makes sense
10:51 oha mostly, the ground is: if you checked the book and it can be reserved, then there is no point checking it again for other members
10:51 ashimema :)
10:51 oha ashimema: yup. but easy to fix
10:50 ashimema that's just madness :(..
10:50 oha in my worst case, that looped 14399 times
10:50 * ashimema has been watching this bug with interest.. some clever code in the memoization stuff
10:50 oha ashimema: thanks :)
10:50 oha the biggest issue is the cartesian product around C4::Circulation line 2686
10:50 ashimema welcome to koha oha ;)
10:49 oha i have one case which is tremendously slow. I think it is > 3 minutes with the original code. memoization lower it to ~ 60s, then this fix on top of memoization bring it down to 1/2 seconds
10:45 oha Joubu: nope. i was working against few real cases i have recreated on my box
10:45 Joubu oha: did you find why I do not recreate the perf issue with the script I attached to the bug report?
10:43 oha Joubu: ok! thanks
10:42 Joubu https://wiki.koha-community.org/wiki/Submitting_A_Patch
10:42 Joubu and add a commit message with a test plan
10:41 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 normal, P2, ---, chris, CLOSED FIXED, Need appropriate graphic for admin scripts
10:41 Joubu oha: several things to improve: 1. Assign you the bug 2. Switch the bug's status to "Needs signoff" 3. attach patches using git-bz (or patches generated with git format-patch) 4. Prefix commit message with "Bug XXXXX: "
10:38 oha especially since it's the first time :) i'm not really sure i'm doing it right
10:33 oha if anyone can have a look and tell me if I did anything wrong, or any other kind of feedback
10:33 huginn 04Bug 17941: major, P5 - low, ---, koha-bugs, NEW , CanBookBeRenewed is very inefficient/slow
10:33 oha hey all, just uploaded a patch for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941
09:32 magnuse i'll fiddle with the sysprefs first of all
09:32 magnuse yeah, lots of pain
09:32 magnuse hehe
09:31 ashimema we decided to just do the work instead and understand email.. then go to the pains of explaining it to customers that don't ;)
09:30 ashimema We looked at doing that with DynDNS.. but basically all it meant was them talking to our customers to get things added to domains instead of us talking to them and DynDNS taking a massive cut for the privilege
09:29 ashimema I would be confident the mail would get through.. but with what headers and from addresses etc I don't know
09:29 ashimema I'm afraid I have no idea how those services work
09:28 magnuse any thoughts on my second suggestion, going through a paid email service of some kind?
09:28 magnuse ok, thanks
09:28 cait judging from ours
09:28 ashimema I think the latter should be ok
09:28 cait i think libriotech.no is probably ok
09:27 cait hm
09:27 magnuse ashimema, cait: if my koha server is koha.libriotech.no, should the email be library@koha.libriotech.no, or is library@libriotech.no ok?
09:27 ashimema as people are saying, rdns is a very important first step unfortunately.
09:26 magnuse ashimema: cool, i'll keep that in mind
09:25 ashimema magnuse, i've now handed off responsibility for that side to our infrastructure guy.. if anything has changed, he'll know. I'd be happy to put you in touch with him.
09:24 ashimema my conclusion was the minimum to get it through everything was in that note I stuck on the wiki... with certificates, returnpaths etc all setup in that manner
09:23 ashimema I spent many hours getting our mail setup to go through pretty much any service provider.. gmail is one of the strictest but they all seem to have their own rules
09:21 cait here is the email thread: http://lists.koha-community.org/pipermail/koha-devel/2017-February/043467.html
09:20 ashimema haha
09:20 cait and the evil hold notices? ;)
09:20 ashimema email is a mess.. I blame all those evil libraries spamming everyone with overdues ;)
09:20 reiveune )
09:20 ashimema indeed
09:20 cait the library has to :)
09:20 cait yeah, but if the email address is invalid i don't want to deal with it
09:19 ashimema replyto is for users to reply to
09:19 ashimema returnpath is for mail servers to send errors to
09:19 cait we now finally have an automatic forwarding for those... so they do end up at the library in the end, but it took a while to get it working
09:19 * cait nods
09:18 ashimema returnpath as ou say must be 'in domain'..
09:18 cait true
09:18 ashimema mail is hard these days
09:18 cait and morning :)
09:18 cait ashimema: discussion about how not to get your email refused when sending email for others
09:17 * ashimema perks up
09:16 cait ashimema wrote something about it on the wiki: https://wiki.koha-community.org/wiki/MRenvoize/Email
09:16 cait only replyto can be another
09:16 cait magnuse: have to answer to the mailing list yet, but i think returnpath also has to be within your domain
09:10 magnuse guten tag cait
09:00 cait good morning #koha
08:37 Joubu Other opinions are welcome too :)
08:36 huginn Joubu: The operation succeeded.
08:36 Joubu @later tell oleonard could you confirm you agree about the use of btn-primary on bug 18042 and 18041?
08:36 huginn Joubu: downloading the Perl source
08:36 Joubu @later oleonard could you confirm you agree about the use of btn-primary on bug 18042 and 18041?
08:31 drojf hi paul_p
08:31 LibraryClaire bonjour paul_p
08:31 paul_p 'morning ladies & gentlemen
08:30 magnuse bonojur paul_p
08:30 magnuse bonjour baptiste - greetings from norway!
08:29 LibraryClaire hi baptiste
08:26 baptiste hi all ;)
08:26 drojf bonjour baptiste
08:25 Joubu Hi baptiste, good to see you around :)
08:25 alex_a Joubu: ^
08:24 alex_a baptiste is a new intern from Biblibre.
08:23 alex_a hello baptiste
08:04 drojf i'm cold
08:04 LibraryClaire I'm ok with not winning
08:04 drojf i win!
08:02 magnuse mohahahaha
08:02 huginn magnuse: The current temperature in Bodo, Norway is 5.0°C (8:20 AM CET on February 14, 2017). Conditions: Light Rain. Humidity: 100%. Dew Point: 5.0°C. Windchill: 0.0°C. Pressure: 30.39 in 1029 hPa (Steady).
08:02 magnuse @wunder enbo
07:59 * drojf builds cozy igloo
07:59 fridolin ah better
07:59 huginn fridolin: The current temperature in Montpellier, France is 13.0°C (8:30 AM CET on February 14, 2017). Conditions: Mostly Cloudy. Humidity: 72%. Dew Point: 8.0°C. Pressure: 30.21 in 1023 hPa (Steady).
07:59 fridolin @wunder montpellier, france
07:58 fridolin drojf: hi, whouuuu cold
07:58 huginn drojf: The current temperature in Berlin Schoenefeld, Germany is -8.0°C (8:50 AM CET on February 14, 2017). Conditions: Mostly Cloudy. Humidity: 100%. Dew Point: -8.0°C. Windchill: -12.0°C. Pressure: 30.60 in 1036 hPa (Steady).
07:58 drojf @wunder sxf
07:58 huginn drojf: The current temperature in Berlin, Berlin, Germany is -6.5°C (8:48 AM CET on February 14, 2017). Conditions: Mostly Cloudy. Humidity: 97%. Dew Point: -7.0°C. Windchill: -7.0°C. Pressure: 30.60 in 1036 hPa (Steady).
07:58 drojf @wunder berlin, germany
07:58 fridolin LibraryClaire: I moved in the nearby village
07:58 drojf hi LibraryClaire
07:58 LibraryClaire moin drojf
07:58 LibraryClaire nice
07:58 drojf hi #koha
07:57 fridolin with a room for work, pretty good
07:57 LibraryClaire oh you moved?
07:57 wahanui new house is pretty?
07:57 * fridolin new house
07:57 fridolin LibraryClaire: hie watsup ?
07:57 LibraryClaire hi fridolin
07:56 fridolin et bonjour
07:52 huginn LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is 1.1°C (8:47 AM CET on February 14, 2017). Conditions: Overcast. Humidity: 88%. Dew Point: -1.0°C. Windchill: 1.0°C. Pressure: 30.39 in 1029 hPa (Rising).
07:52 LibraryClaire @wunder konstanz
07:52 reiveune \o_
07:52 LibraryClaire and hi reiveune
07:51 LibraryClaire bonjour Joubu
07:48 reiveune hello
07:47 Joubu good morning everybody
07:44 magnuse string freeze AGAIN?!? ;-)
07:43 alex_a hello LibraryClaire
07:43 LibraryClaire salut alex_a
07:39 alex_a bonjour
07:13 huginn cait: The operation succeeded.
07:13 cait @later tell kidclamp could you take a look at bug 18076 and 16115 in light of pending string freeze?
07:12 * cait waves
07:01 LibraryClaire morning #koha
06:26 magnuse dcook!
06:25 * magnuse waves
05:07 huginn dcook: The operation succeeded.
05:07 dcook @later tell tcohen Yeah I saw 18098. I'm not sure what I think yet. If we used that approach, we'd have to update Zebra after every checkin/checkout and that doesn't seem that feasible to me
05:06 huginn dcook: The operation succeeded.
05:06 dcook @later tell ashimema Hey, I'd love to chat about Mojolicious if you have some time. Still not understanding how the REST API is being implemented in Koha atm...
03:06 kathryn er, that was ideally in our other channel, but no worries! hi all :) and bYE!
03:05 kathryn hey wizzyrea, just to mention that once I'm gone shortly, no one is here!