Time  Nick            Message
00:03 tmcmahon        I didn't see any reason to keep it open if it's fixed and pushed to stable.  Keep people from taking their time on it when there are other things to deal with.
00:04 rangi           yep
00:05 tmcmahon        Thanks rangi
00:07 tmcmahon        CrispyBran: I just added my comment confirming that hold limits didn't work for me either.
00:09 tmcmahon        But I got to the limit by placing multiple holds at once.  It seems to work if I add them one at a time.  I need to double-check that.
00:10 tmcmahon        I need to re-edit my comment.  It works for one at a time.  At least for me.
00:11 tmcmahon        I guess add a new comment.  I can't change what I already have there.
00:13 CrispyBran      Hmmm...perhaps I am just missing something.  Would you have any time tomorrow to look over my setup with me?
00:14 CrispyBran      "But I got to the limit by placing multiple holds at once.  It seems to work if I add them one at a time. "  I'm confused.  Did it only work with multiple holds at once, or did it work if you placed holds one at a time?
00:16 tmcmahon        I had the limit set to 5 and already had one hold, so I just selected 5 more from a search and reserved all at once.  It let me do that.
00:17 tmcmahon        Then I deleted two and added reserved one at a time.  It let me reserve the first (actually fifth), but not the next.
00:17 tmcmahon        So it works for one at a time (for me at least), but seems to ignore the limit if I add multiple reserves.
00:20 CrispyBran      I have to run.  tmcmahon, thanks for the info.  I was doing 1 at at time, and it wasn't stopping it.  If you have a few minutes, would you mind looking at the #1 ByWater sandbox and see if you see something off about my rules?
00:20 CrispyBran      If not, I will take a look again myself, tomorrow.
00:23 tmcmahon        A quick look and I don't see what could be wrong.  I'll keep looking.
00:24 CrispyBran      Thanks.  Catch you later.
02:11 dcook           LibraryClaire is totally killing January sign offs :D
02:20 dcook           Coworker with cait? That's cool :D
04:05 mtompset        Greetings, #koha.
04:21 dcook           Oh wow... just found quite the bug
04:25 mtompset        Do tell.
04:25 dcook           Go to /cgi-bin/koha/cataloguing/addbooks.pl
04:25 dcook           and type "1st to die" into the Cataloging search
04:25 dcook           You should get a SQL error
04:25 dcook           Because of some... very interesting code
04:26 dcook           I'm typing up the bug report now
04:26 mtompset        Does it try to treat the 1 as a biblionumber or something?
04:27 dcook           Even better
04:27 wahanui         Even better is what oleopard said just after that
04:27 dcook           It thinks it's an ISBN because the string is 10 characters long and it contains a number
04:27 mtompset        Oh wow. That's awesomely awful.
04:27 dcook           But when you try to normalize the ISBN, it turns the string into a blank, which means you don't get any where clause in your SQL select which causes the error
04:27 dcook           Yeah!
04:28 dcook           Of course, if the SQL select was done better, you wouldn't see the error, and it would be harder to troubleshoot..
04:28 dcook           The code is from 2009 but still..
04:28 mtompset        true, but wow.
04:29 mtompset        Anyone want an easy sign off? bug 17935
04:29 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 trivial, P5 - low, ---, m.de.rooy, Needs Signoff , Adjust some POD lines, fix a few typos
04:30 mtompset        I could only sign half of it, because he missed some, and I put the rest up. :)
04:30 dcook           That does look like an easy sign off
04:30 dcook           I'll take a gander
04:30 dcook           bug 17979
04:30 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 minor, P5 - low, ---, gmcharlt, NEW , Fatal error when searching from addbooks.pl due to ISBN flaw
04:38 dcook           mtompset: that should be done now
04:39 mtompset        dcook++ # thanks for the sign off. :)
04:41 dcook           np one of those multitasking days
04:41 mtompset        Well, tomorrow is going to be a long day.
04:41 mtompset        Have a great day (24 hour period), #koha dcook
06:52 drojf           morning #koha
06:55 drojf           @later tell rangi i think you filtered the security patches from the dashboard. is it possible to get the signoffs counted nonetheless?
06:55 huginn          drojf: The operation succeeded.
07:08 LibraryClaire   morning #koha
07:09 drojf           guten morgen BüchereiKlara
07:12 LibraryClaire   moin drojf
07:44 reiveune        hello
07:48 LibraryClaire   hey reiveune
07:48 wahanui         reiveune is working for biblibre
07:48 LibraryClaire   wahanui likes this fact :)
07:48 wahanui         LibraryClaire: excuse me?
07:54 alex_a          bonjour
07:54 wahanui         que tal, alex_a
07:58 LibraryClaire   hey alex_a
07:58 alex_a          salut LibraryClaire
08:06 fridolin        hie ther
08:16 * magnuse       waves
08:17 LibraryClaire   hi magnuse
08:17 LibraryClaire   salut fridolin
08:17 magnuse         guten morgen BüchereiKlara
08:17 fridolin        salutations tout le monde
08:17 magnuse         bonjour fridolin
08:34 Joubu           que tal, wahanui
08:34 wahanui         bidet, Joubu
08:37 Joubu           bidet, wahanui
08:37 wahanui         Joubu: i'm not following you...
08:37 LibraryClaire   are you teasing the bot?
08:38 Joubu           just confirming it was stupid
08:39 LibraryClaire   poor wahanui
08:39 wahanui         Will he ever win?
09:09 eythian         hi
09:17 drojf           hi eythian
09:21 magnuse         moin drojf eythian
09:21 drojf           hei magnuse
09:23 eythian         hi drojf, magnuse
09:29 * cait          waves
09:32 sunnie          hi koha friends
09:32 sunnie          hope u r all having a good day
09:34 sunnie          can the number of records in the items table differ from that in biblio table and biblioitems tables
09:35 eythian         sunnie: yes, it's very normal for the items table count to be different.
09:36 sunnie          is it because there are multiple items for the same record?
09:36 eythian         yep
09:36 eythian         (or, more rarely, zero items for a record.)
09:37 sunnie          thanks bro
09:37 sunnie          bye
10:28 eythian         It's sunny _and_ foggy outside. That's a weird looking mix.
10:28 eythian         @wunder ams
10:28 huginn          eythian: The current temperature in Amsterdam, Netherlands is 1.0°C (11:25 AM CET on January 24, 2017). Conditions: Scattered Clouds. Humidity: 100%. Dew Point: 1.0°C. Windchill: -1.0°C. Pressure: 30.36 in 1028 hPa (Steady).
10:29 eythian         100% humidity, that'll do it.
10:53 tcohen          morning
10:54 tcohen          @wunder cordoba, argentina
10:54 huginn          tcohen: The current temperature in Cordoba, Argentina is 18.0°C (7:00 AM ART on January 24, 2017). Conditions: Clear. Humidity: 83%. Dew Point: 15.0°C. Pressure: 29.80 in 1009 hPa (Steady).
10:55 LibraryClaire   hola tcohen
10:55 eythian         oh, now the whole city out the window has vanished.
10:55 * kidclamp      waves
10:56 tcohen          hola LibraryClaire
10:57 LibraryClaire   hey kidclamp
10:57 wahanui         kidclamp is rockin the stache
11:12 LibraryClaire   gosh, the weather deities weren't happy with those requests
11:12 LibraryClaire   @wunder konstanz
11:12 huginn          LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is -2.0°C (12:08 PM CET on January 24, 2017). Conditions: Overcast. Humidity: 80%. Dew Point: -5.0°C. Windchill: -2.0°C. Pressure: 30.27 in 1025 hPa (Falling).
11:16 magnuse         @wunder enbo
11:16 huginn          magnuse: The current temperature in Bodo, Norway is 1.0°C (11:50 AM CET on January 24, 2017). Conditions: Mostly Cloudy. Humidity: 65%. Dew Point: -5.0°C. Windchill: -6.0°C. Pressure: 29.92 in 1013 hPa (Steady).
11:29 kidclamp        @wunder 05001
11:29 huginn          kidclamp: The current temperature in Wilder Street, Hartford, Vermont is -0.7°C (6:29 AM EST on January 24, 2017). Conditions: Light Rain. Humidity: 93%. Dew Point: -2.0°C. Windchill: -1.0°C. Pressure: 29.67 in 1005 hPa (Falling).  Winter Weather Advisory in effect until 10 PM EST this evening... 
11:48 * tcohen        unhides
11:49 tcohen          Joubu: I don't understand comment 10
11:50 Joubu           tcohen: Hi Tomas! What's the # again?
11:50 tcohen          https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749#c10
11:50 huginn          04Bug 16749: enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Follow-up for bug 16733: changes for koha-translate
11:52 Joubu           marcelr was suggesting to add a new entry to koha-conf, to know if the install was a dev install or not
11:52 Joubu           so he added a <dev_install> tag with the path of the (gitified) install
11:53 Joubu           but it seems that dev_install will always be == to intranetdir (if filled)
11:53 Joubu           so I suggested to move it to a boolean (I know you love boolean ;)) instead of repeating the same path
11:54 Joubu           unless there is a case where dev_install could be != intranetdir
11:54 Joubu           (but I do not think so)
12:02 tcohen          Joubu: I prefer the boolean
12:02 Joubu           so please comment ;)
12:02 tcohen          and if needed, nested options
12:02 tcohen          like special path or whatever
12:02 tcohen          ok i will
12:14 marcelr         hi #koha
12:19 eythian         marcelr: what's happening, Amsterdam isn't rendering more than a few 10s of metres away. Is this normal?
12:19 eythian         I think the video card needs to be upgraded.
12:20 marcelr         not sure if i understand you
12:20 marcelr         mistig
12:20 Joubu           The audio card as well :)
12:47 oleonard        Hi all
12:52 LibraryClaire   hi oleonard
12:52 wahanui         hi olé onard
12:52 LibraryClaire   :(
12:52 * LibraryClaire pokes wahanui
12:52 wahanui         I'm reporting you to HR!
13:06 tcohen          hi marcelr
13:06 marcelr         hi tcohen
13:40 * LibraryClaire falls asleep
13:41 * oleonard      draws the Koha logo on LibraryClaire's forehead
13:41 eythian         could be worse.
13:41 LibraryClaire   aaw man
13:41 LibraryClaire   yeah eythian I was thinking that
13:42 eythian         could have been the SirsiDynix logo.
13:51 * ashimema      giggles
13:52 edveal          Hello
13:52 wahanui         salut, edveal
13:52 tcohen1         hi ashimema
13:53 * LibraryClaire waves at ashimema
13:57 ashimema        h
13:57 ashimema        :)
13:58 * ashimema      goes to make :tea:
13:58 * ashimema      realises this isn't slack and so emoji like that don't work
13:58 ashimema        ☕works though :)
13:59 * tcohen        was trying to find them
13:59 ashimema        find what... a tea emoji ;)
14:01 tcohen          a way to tell my irc client to render emojis better
14:01 kidclamp        ☕
14:02 ashimema        hehe
14:02 ashimema        what client do you use tcohen?
14:04 tcohen          ashimema: i guess bugzilla spammed you about bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932
14:04 tcohen          if you have the chance to take a look, I would appreciate it
14:04 huginn          04Bug 17932: enhancement, P5 - low, ---, tomascohen, Needs Signoff , Koha::Object should provide a TO_JSON method
14:04 LibraryClaire   I just get a bunch of squares with dots in :(
14:04 tcohen          adium
14:05 tcohen          I see the cup of coffee
14:05 tcohen          but I think I need to choose a better font
14:07 oleonard        I like that a search for ☕ in DuckDuckGo returns results for "coffee" and Google just returns results for ☕
14:08 ashimema        tcohen.. patch looks good to me
14:08 oleonard        ...although I guess that doesn't make any sense if by "☕" you mean hot chocolate, tea, or generic hot beverage.
14:08 oleonard        Mmmm.... generic hot beverage.
14:09 LibraryClaire   mmm, dice
14:09 ashimema        indeed.. in theory thay emoji is classified as 'hot beverage'.. though I always use it for tea..
14:09 ashimema        there is actually an emoji for coffee too
14:09 LibraryClaire   does it look... the same...?
14:09 ashimema        nope
14:09 oleonard        It looks the same but it tastes very different
14:10 ashimema        🍵
14:10 ashimema        coffee :)
14:10 LibraryClaire   square with dots in
14:10 ashimema        lol
14:10 LibraryClaire   looks the same to me
14:10 ashimema        http://www.fileformat.info/info/unicode/char/2615/index.htm tea
14:10 ashimema        http://www.fileformat.info/info/unicode/char/1f375/index.htm coffee
14:11 ashimema        though actually.. the difference there in terms of classificaiton is far from clear ;)
14:11 LibraryClaire   but it says teacup without handle
14:12 ashimema        yeah.. I was sure there was one which was actually defined as 'coffee'
14:12 ashimema        mwah
14:13 oleonard        What's your IRC client LibraryClaire ?
14:13 LibraryClaire   pidgin when at the office
14:13 LibraryClaire   hexchat at home
14:14 magnuse         LibraryClaire: you might want to have a look at your settings
14:14 magnuse         i had to do some trickery in xchat to make unicode work properly
14:15 * ashimema      uses smuxi but is getting more and more tempted to move irc to the cloud and either get irccloud or host convos somewhere
14:15 LibraryClaire   i think my desktop at home has smuxi still
14:15 * LibraryClaire is trying everything
14:15 ashimema        https://convos.by/ looks nice
14:15 ashimema        but it's web based and you'll need to host it somewhere
14:15 * magnuse       saw irssi on tv the other day
14:16 ashimema        hehe
14:16 * oleonard      still likes standalone Chatzilla
14:17 * tcohen        likes smuxi
14:18 * LibraryClaire thinks they are all teh same and likes pretty things
14:18 LibraryClaire   actually that's not strictly true but I have yet to discover an advantage of one over another
14:19 oleonard        LibraryClaire: Pretty things like squares with dots?
14:19 magnuse         https://xkcd.com/1782/
14:20 ashimema        :D
14:20 * ashimema      only anoyance with smuxi is I've never been able to work out how to get it to run headless and then connect to it from multiple front ends..
14:21 ashimema        and thus.. I loose track when I switch from desktop to laptop or mobile
14:21 ashimema        and my logs fall out of sync.. hense why I'm tempted by a hosted solution
14:26 LibraryClaire   oleonard: I also like variety
14:29 oleonard        Bug 17979 is amusing to me.
14:29 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 minor, P5 - low, ---, gmcharlt, NEW , Fatal error when searching from addbooks.pl due to ISBN flaw
14:29 oleonard        '"1st to die"  is 10 characters long and contains a digit, so
14:29 oleonard        Koha thinks it's an ISBN.'
14:33 Joubu           oleonard: I guess the regex should be m|^[\d-]*$|;
14:34 Joubu           0-9 + -
14:34 Joubu           instead of "at least 1 \d"
14:50 tcohen          liw: is there any known restriction on the use of /var/cache/ for debian packages?
15:25 liw             tcohen1, only what it says in the FHS
15:30 LibraryClaire   laters #koha
15:30 oleonard        Bye LibraryClaire
15:38 Joubu           oleonard: I'd like to get your opinions on this idea: bug 17981
15:38 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Add the ability to preview generated notice templates
15:38 Joubu           I am not sure about the use of the modal window
15:39 oleonard        Okay I'll take a look
15:39 Joubu           and how display things correctly to make the comparaison easier
15:40 Joubu           Thanks oleonard! As I said on the last comment, checkout the remote branch, the tree of deps is huge..
15:40 Joubu           khall: ^ for you as well ;)
15:40 khall           I will too
15:47 khall           Joubu: what bugs does this acutally depend on? Do you have a branch pushed out to anywhere?
15:48 Joubu           khall: yes, see last comment of the bug
15:48 khall           ah, thanks!
15:50 oleonard        Joubu: When I test it with the checkin template, the modal shows me "Converted version" and "Rendered message" but the rendered message box is empty, and I get a "generated notices are different!" warning.
15:50 oleonard        I'm confused.
15:51 Joubu           oleonard: did you execute the updateDB + restart plack?
15:52 oleonard        Yes
15:52 Joubu           ha yes, same for me
15:53 Joubu           oleonard: I finished with HOLD_SLIP and did not retest CHECKIN/CHECKOUT at the end
15:53 Joubu           so I guess I broke something
15:53 Joubu           you can test HOLD_SLIP
15:53 oleonard        Okay
15:55 Joubu           oleonard: Ha no actually CHECKIN work, you need to fill the "data for preview" with the barcode of an item that is currently checked out
15:56 Joubu           (the error is not correctly handled in case the item is not checked out)
15:57 khall           Joubu: I love it!
15:57 khall           this is exactly the kind of preview we've needed for years, I love the way it uses real data
15:58 Joubu           the problem is that we cannot generate data that does not exist.
15:58 khall           it might be tricky for html notices though, are iframes still a thing?
15:58 khall           Joubu: true, but I think that's a worthwhile tradeoff
15:58 Joubu           For instance for CHECKIN, we will not checkin the item to get a correct "issues" entry in the DB
15:59 khall           Joubu: you do have a point, I hadn't thought of such a limitation
15:59 Joubu           khall: html notices are displayed with the html tags
15:59 khall           Joubu: ah, makes sense
15:59 oleonard        Joubu: Initial comments: I think the modal window works well for this purpose but I didn't notice the "data for preview" field. Could we incorporate the add data step into the modal?
16:00 Joubu           oleonard: ha yes indeed, that would make sense
16:00 Joubu           unless we want to test the different "transports"
16:00 Joubu           we will have to fill the data N times
16:00 bag             love it
16:01 oleonard        Joubu: What if the "data for preview" entry in the modal updates hidden form fields in the body of the page?
16:01 oleonard        we'd need to add a way to update the data for preview
16:02 Joubu           oleonard: yes, but.. I am really bad at JS things and it takes me hours for that kind of stuffs :p
16:03 Joubu           but I can try
16:03 oleonard        Let me know if I can help
16:04 Joubu           oleonard: ha yes, one thing
16:04 Joubu           with CHECKIN, a message is displayed
16:05 Joubu           something like "do not forget that the item is not checked in yet"
16:05 Joubu           it must be displayed at the top of the modal
16:05 * LibraryClaire waves
16:05 Joubu           if you look at tools/preview_letter.tt, you will see the loop on the messages (to display the "div dialog alert")
16:05 Joubu           but they actually displayes at the bottom of the modal
16:06 Joubu           it seems to happen to any div element
16:06 Joubu           it's very weird
16:06 * Joubu         did not read the bootstrap3 doc for modals...
16:07 Joubu           oleonard: I also thing we should display the screen in 2: one block per syntax
16:07 Joubu           and having the 2 versions side-by-side would help to find the changes
16:09 magnuse         bag: HI
16:09 wahanui         niihau, magnuse
16:14 Joubu           oleonard: just pushed a "better error handling" patch that should display better warning message in case the data field not correctly filled
16:14 Joubu           is*
16:15 oleonard        About this line Joubu: $("#preview_template .modal-body").load(page + " div");
16:17 oleonard        Wait, maybe I'm misunderstanding what's going on...
16:17 Joubu           I c/p all the modal stuffs from bug 17898
16:17 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Add a way to automatically convert SQL reports
16:17 Joubu           with Josef's followup
16:18 Joubu           and I think I already copy/pasted from somewhere else
16:18 Joubu           oleonard: page is the url, so I guess it's the place the ajax request is done
16:19 oleonard        It's not incorrect, I'm just looking at the message being displayed at the bottom rather than the top
16:20 oleonard        Okay, yeah. The + " div" part of that is loading the contents of all <div> tags in preview_letter.tt in the order that they appear
16:21 oleonard        Oh sorry it's not that simple.
16:21 oleonard        maybe it's because the did is nested...
16:22 Joubu           it works if I remove it
16:23 Joubu           and I think I should move the "exactly the same" div to the top as well
16:25 oleonard        I don't think there are negative consequences of taking out the + "<div>" in this case.
16:56 oleonard        Joubu: I'm tinkering with that modal template
16:57 Joubu           oleonard: I have pushed another patch few minutes ago about the + " div" thing
16:57 Joubu           feel free to submit follow-up :)
16:59 oleonard        That's my plan
17:09 tmcmahon        CrispyBran: I checked the sandbox you mentioned yesterday and hold limits worked fine for me.
18:10 reiveune        bye
18:28 oleonard        Joubu: Is this the kind of layout you were thinking of? http://zivotdesign.com/p/#1/14852824195004
18:33 Joubu           oleonard: awesome, it is exactly what I had in mind indeed :)
18:33 bag             awesome
18:33 wahanui         That'll be $1 for the awesome jar, bag
18:33 Joubu           well, it was more left and right instead of up and down
18:33 cait            Joubu++ oleonard++
18:34 Joubu           I don't think it matters a lot
18:34 oleonard        Oh I see, comparing the template, then comparing the output
18:34 Joubu           yep
18:36 Joubu           I was thinking about highlighting the lines that differ between the 2 versions, so that would make more sense to have them side-by-side
18:36 Joubu           if side-by-side means "left-right only" :p
18:37 bag             @wunder pdx
18:37 huginn          bag: The current temperature in Portland, Oregon is 1.0°C (9:53 AM PST on January 24, 2017). Conditions: Overcast. Humidity: 96%. Dew Point: 0.0°C. Pressure: 30.17 in 1022 hPa (Rising).  Winter Weather Advisory in effect until 1 PM PST Wednesday... 
18:37 oleonard        Uh oh. Does anyone know how to drive in winter weather in Portland bag?
18:37 bag             nobody does :)
18:38 bag             stay home :)
19:07 nuentoter       hello koha world!
21:54 magnuse         @wunder enbo
21:54 huginn          magnuse: The current temperature in Bodo, Norway is 6.0°C (10:20 PM CET on January 24, 2017). Conditions: Mostly Cloudy. Humidity: 70%. Dew Point: 1.0°C. Windchill: 1.0°C. Pressure: 29.71 in 1006 hPa (Steady).
22:03 martian523      hi! kinda need some urgent help. using koha 16.05.07.  this error came up when i tried to look up vendors in acquisitions: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054
22:03 cait            are you logged in with a normal staff user?
22:04 cait            nto the db one?
22:08 martian523      <cait> logged in as superuser
22:08 cait            superuser or superlibrarian?
22:09 cait            you shouldn't work in Koha with the db user
22:09 martian523      superlibrarian
22:09 wahanui         superlibrarian is one of the permissions
22:09 martian523      sorry
22:09 cait            ok, just wanted to be clear :)
22:09 martian523      has no trouble before upgrade
22:09 cait            I haven't seen an error like this in 16.11 or on 3.22 - haven't used 16.05 much
22:09 cait            maybe try on th emailing list - bit quiet here this time of day
22:10 martian523      upgraded from 3.18
22:20 * liz           repeats that the onboarding tool avoids this "i logged in with the superuser" problem
22:26 dcook           liz: I wonder if there's ever a time when a person should be able to log in as the superuser... I suppose in the case of lockouts..
22:26 liz             of course there is
22:26 liz             but there is never a reason for a first time user to.
22:31 eythian         @later tell drojf http://feedproxy.google.com/~r/FutilityCloset/~3/kBZG9OfB3EM/
22:31 huginn          eythian: The operation succeeded.
22:39 mtj             hi #koha
22:39 mtj             martian523, i cant reproduce your error on 16.5.7 :(
22:40 mtj             ..curious, whats your search string?
22:42 bag             hey mtj
22:42 mtj             hiya bag
22:43 mtj             great to hear the about superuser issue, getting fixed(er)
22:46 mtj             martian523: do you get that error searching a blank string, or  '%' ?
22:55 dcook           Hey, cait. Are you still there?
22:57 dcook           Damn. Oh wll.
22:57 dcook           Sticky e key >_>
23:03 dcook           rangi: Are you around?
23:03 dcook           Or anyone who has been a RM or QA person?
23:03 dcook           wizzyrea?
23:03 wahanui         wizzyrea is probably here to help. And sometimes hinder. But mostly help.
23:10 bag             what’s up dcook
23:10 dcook           bag: My fix for bug 17880 actually created a new bug >_>
23:10 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 normal, P5 - low, ---, dcook, Pushed to Stable , C4::Installer::PerlModules lexicographical comparison is incorrect
23:10 dcook           I have a new patch which I've uploaded to that bug report
23:10 dcook           But not sure of the protocol of what to do now
23:11 dcook           Should I open a new bug report, or...?
23:11 dcook           It's in 16.11.02 and master :/
23:11 dcook           Silly copy/paste error on my part. One line fix.
23:11 bag             hmm good question - I’d open a new bug and mark it critical
23:12 bag             it’s a 1 line patch that should get in pretty quickly
23:13 bag             as for 16.11.02 it maybe too late to revert that - so we’ll just apply the patch and have it fixed for .03
23:13 bag             but anyways nice catch dcook
23:15 dcook           Sounds like a plan. I'll do that.
23:16 dcook           I thought that I'd chcked that script before uploading but oh well. Embarassing. People with packages shouldn't notice it much i think
23:18 dcook           unless they go to /cgi-bin/koha/about.pl...
23:23 CrispyBran      @bag: who do I talk to about the ByWater sandboxes?
23:23 huginn          CrispyBran: I'll give you the answer just as soon as RDA is ready
23:24 CrispyBran      bag: who do I talk to about the ByWater sandboxes?
23:27 dcook           bag: Patch posted on bug 17986
23:27 huginn          04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 critical, P5 - low, ---, gmcharlt, Needs Signoff , Perl dependency evaluation incorrect
23:36 dcook           I was looking this morning if Business::ISBN was a required module and then wondered why Koha said I should upgrade all my modules...
23:55 bag             ah sorry CrispyBran I went to the store to get some icecream - it’s my dogs birthday tonight
23:55 bag             he gets it once a year ;)
23:55 CrispyBran      its okay.  I got my answer
23:55 CrispyBran      thanks.
23:55 bag             but for the sandboxes - khall set them up
23:56 CrispyBran      Maybe you can answer this....isn't there a setting that prevents a patron from placing a hold on items if it is available and on the shelf?  I can't seem to find it.
23:57 bag             there is a setting
23:57 bag             it’s called onshelfholds iirc
23:58 liz             it's in the circ rules now
23:59 jac             bag I sent the ticket to khall for CrispyBran :-)
23:59 liz             you can do it per itype/patron category
23:59 bag             ah
23:59 bag             sweet
23:59 CrispyBran      got it. Darn these upgrades.
23:59 CrispyBran      :)
23:59 liz             it's the column "on shelf holds allowed"
23:59 liz             it has several options