Time Nick Message
00:02 martian523 hi, i just upgraded to 16.05 in my test server. as i was testing, i got the following error when trying to look up a record. "Can't use an undefined value as an ARRAY reference at /usr/share/koha/lib/C4/Acquisition.pm line 1125."
00:03 martian523 is it possible to get some help on this?
00:07 rangi martian523: is it all records or just one particular one?
00:07 martian523 all records
00:08 martian523 the book shows up, but when i click in, the error comes up
00:08 rangi staff and public interface?
00:08 martian523 staff
00:09 martian523 didn't try public yet
00:10 rangi lemme just check one of my 16.05
00:11 martian523 opac seems fine
00:11 rangi hmm ok there, is it 16.05.07 ?
00:11 rangi ill go look at the code
00:12 martian523 16.05.07.000
00:12 rangi sweet we are running the same, i dont get the error, which means its a data thing, which is good, those are easier to fix
00:12 martian523 ok. good
00:13 rangi ah ha
00:13 martian523 i will pass along whatever you say to my IT
00:13 rangi so its the subroutine GetOrdersByBiblionuber
00:13 rangi on that page it is trying to get any orders attached to that record, so it can display them
00:14 rangi ok here we go
00:15 rangi line 1125 of /usr/share/koha/lib/C4/Acquisition.pm
00:15 martian523 ok. i'm ready to copy and paste
00:15 rangi return @{$result_set};
00:15 rangi needs to become
00:15 rangi return @{$result_set} if $result_set;
00:16 rangi ie, dont try to return the results, if there are none
00:16 rangi that should fix it
00:16 martian523 that looks easy. but i'm not the expert. lol. if doesn't work, i'll return tomorrow. =)
00:16 martian523 thanks!
00:17 rangi no worries
00:25 martian523 @rangi works now. thanks!
00:25 huginn` martian523: downloading the Perl source
00:28 rangi sweet
00:28 rangi you might like to file a bug at bugs.koha-community.org
00:28 rangi because that will catch other people too
00:34 dcook Oh my, I've eaten all of my cookies...
00:34 dcook Well, that packet at least. There is still another half packet over there... >_>
01:06 mtompset alexbuckley alexbuckley_ Very Close... one more pass, I think.
01:06 mtompset alexbuckley++ # awesome effort and for putting up with me.
01:12 alexbuckley thanks mtompset. for your first suggestion do you mean I should write main page->Administration->Libraries and groups?
01:12 alexbuckley or to remove it?
01:13 mtompset If you run Koha, the top part almost always have a top menu with More at the end, and you click More and there are all the options which includes Administration.
01:13 mtompset Regardless of page.
01:14 mtompset So, I don't see why any other references are needed.
01:14 alexbuckley ah ok I see what you mean I will remove that unnecessary reference
01:14 mtompset So OR and the next line are not needed.
01:14 mtompset Right.
01:18 mtompset ping me, when you have something up.
01:35 alexbuckley mtompset: I have attached the new commit to the bug
01:37 mtompset YAY! All issues addressed by eyeball.
01:37 mtompset Now for the fun. :)
01:53 mtompset Oh, you renamed and moved things, that's why I was confused. :)
02:03 mtompset alexbuckley: not that the Koha community is going to care about higher than perlcritic -5, but given that summary.pl is almost clean, I thought I'd point out a couple things that DO NOT need changing, but would be coding style improvements.
02:03 mtompset my $query = new CGI; # is valid code
02:03 mtompset my $query = CGI->new(); # is better code
02:04 mtompset And while...
02:04 mtompset template_name => "summary.tt",
02:04 mtompset is valid code.
02:05 mtompset If you are aiming for a higher perlcritic level, use of single quotes on something like this that has no interpolation is better.
02:05 mtompset You might want to read up on q, qq, qw, and the like too.
02:06 mtompset But... no code changes are needed.
02:07 alexbuckley alright, thanks for that I am making a note for future reference of those coding style improvements
02:08 mtompset Another useful page to read is the Coding Guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines
02:09 mtompset BTW, I like the install ... as a button vs. the link change.
02:10 alexbuckley thanks
02:13 mtompset Okay... just tested basic/unimarc.
02:13 mtompset two suggestions.
02:14 mtompset The button that says it will take you to onboarding doesn't jump to onboarding right away. Is there a reason for that? I haven't looked at the code to see if there is one.
02:14 mtompset Next, the buttons that say "Add a ..."
02:15 mtompset If I have selected all the sample data, it tells me I don't need to, but I just pressed a button to "Add a ..."
02:16 mtompset Perhaps "Add a ..." is the wrong phrase? Perhaps "Setup minimal ..."
02:16 mtompset Then the message that you don't need to, makes sense.
02:17 mtompset Now to try advanced/unimarc to see if there are any other suggestions.
02:22 mtompset alexbuckley: So the only difference between basic and advanced is whether the mandatory files are uncheckable? Is there a reason to allow that?
02:23 mtompset BTW, love the superlibrarian creation and circ rule creation. Though, what about non-circulating libraries? Would they need a circulation rule?
02:26 alexbuckley Yes the basic setup displays all mandatory files as bulletpoints instead of checkboxes so that the user cant accidently or unknowingly untick a data value that is needed for a fully functioning koha. whereas advanced setup recommended for more experienced users lets them have compete control over what is installed in their koha instance
02:28 mtompset Yes, I like basic. I'm just trying to think of a use case for advanced.
02:28 mtompset I won't fail qa this, if there isn't, but be prepared if some QA person asks. :)
02:29 rangi advanced is the current behaviour mtompset
02:29 mtompset I just realized that.
02:29 mtompset sounds like a good enough reason to me. :)
02:29 rangi im thinking lots of places like bywater/catalyst/bsz etc
02:30 rangi will want to do that, i know some places load customised frameworks in etc
02:30 mtompset Okay, cool. :)
02:32 mtompset Now, I'll check out my first suggestion if it makes sense, or if there is some code running that is just left best untouched.
02:35 mtompset AH! Okay, there is.
02:36 mtompset So, perhaps just some phrasing change.
02:37 alexbuckley Yup I am just fixing up the button phrases in onboarding tool to 'Setup minimal patron category' and 'Setup minimal item type' but will leave 'Add a patron' and "Add a circulation rule' as users will always have to add these
02:39 mtompset Mmmm.... are you sure about patron? I installed default patrons.
02:40 mtompset ^default^sample^
02:40 mtompset Oh wait.. that's the superlibrarian one.
02:40 alexbuckley yeah but you have to create a patron account in onboarding tool so you have a username and password to login
02:40 mtompset No, you're likely right.
02:40 mtompset Exactly.
02:41 mtompset Oh this is going to be beautiful when it gets into Koha.
02:41 mtompset Thank you for working on this.
02:42 rangi the best thing is, no one should need to ever log into koha with the database user
02:42 mtompset Exactly.
02:42 rangi which stops all sorts of weirdness accidentally occuring
02:43 mtompset It's a pain to reset the DB, and then log in with the database user to set up the "Koha Admin" user the way I want. :)
02:44 aleisha just a small thing from me, 'setup' should be 'set up' (two words) if you're using it as a verb
02:44 aleisha :)
02:44 mtompset Now, why is it called onboarding?
02:44 aleisha i think
02:44 mtompset aleisha is correct.
02:44 * aleisha feels useful
02:44 mtompset unless it was "Minimal ... setup" ;)
02:45 mtompset Then the button isn't using a verb, but describing where you are going.
02:45 aleisha exactly
02:46 mtompset alexbuckley++ # for putting up with pedantic folks. :)
02:46 alexbuckley Yeah I am writing it as Minimal ...setup. And how does 'Finish installation' for the rephrasing of that other button sound?
02:47 mtompset The problem is the word installation.
02:47 mtompset as a user...
02:47 aleisha what about 'Complete setup'?
02:47 mtompset they would think that means, give me a log in, so I can go.
02:47 aleisha or finish
02:48 * mtompset is thinking.
02:49 aleisha or maybe 'continue to Koha'?
02:49 mtompset But you aren't continuing to Koha.
02:49 aleisha o
02:50 mtompset You are setting the version number, so that base installation is completed before the onboarding can start.
02:50 aleisha oic
02:51 mtompset Maybe that should be it "Set Koha verson system preference"
02:52 alexbuckley yeah I'll implement that
02:52 mtompset And the click here on the next page...
02:52 mtompset probably be something about starting the onboarding process.
02:53 mtompset "here" is always a bad link description.
02:53 mtompset Also, what is "onboarding"?
02:54 * dcook isn't a huge fan of the term "onboarding" in this case
02:54 dcook As I think about it in terms of: "the action or process of integrating a new employee into an organization or familiarizing a new customer or client with one's products or services."
02:54 dcook Maybe I don't understand how it works in Koha though..
02:55 alexbuckley I see it as a process of taking the user through setting up their system so once they have finished the onboarding process they can get straight to work using Koha as intended
02:55 mtompset What is implemented is some preliminary basic configuration which we current have yellow screens of doom warning us about.
02:56 mtompset Right, without a superlibrarian, you end up logging in as the system user.
02:56 mtompset Without a circulation rule, you can't circulate out of the box.
02:57 mtompset That sort of stuff. Any suggestions for a better word, dcook?
02:57 alexbuckley yeah by using the onboarding tool the user wont be faced with the warning messages associated with logging in as database admin account. Also they have library, patron category etc. set up so they dont have to spend time setting that up on staff interface after logging in
02:58 mtompset Though, I have an enhancement idea, alex. :)
02:58 mtompset Advanced would let you have a skip setup step button. ;)
02:59 mtompset But don't do that on this bug, please.
02:59 mtompset Make that your next one. ;)
03:00 alexbuckley ah right, yeah I can implement that in future one. For that button do you mean to skip onboarding tool?
03:00 dcook mtompset: Not really. I suppose onboarding might make sense in that point, if it's organised well.
03:01 dcook TFW you're wondering how someone thought of something... then you realize they're linking to an old email you wrote
03:01 mtompset TFW?
03:03 mtompset and/or steps in the onboarding tool, alexbuckley. :)
03:03 alexbuckley ah yup I see what you mean
03:04 mtompset I'm just waiting on a bunch of labels tweaked patch now.
03:04 mtompset This is exciting! It's very close.
03:06 dcook TFW = that feeling when
03:06 dcook I was going to say "all the kids are saying it", but I think it's out of fashion now :p
03:07 mtompset this
03:07 mtompset It
03:08 mtompset At least wahanui is smart enough to know this and it are to be ignored. :)
03:29 alexbuckley mtompset: New commit is in the bug
03:45 alexbuckley *attached to the bug
03:58 mtompset Sorry for the slow reply. Chauffeur duty.
04:09 mtompset alexbuckley: Silly me decided to enter bad data on the super-librarian creation page. Let me run through that again... I think there might be a tweak needed.
04:12 mtompset Okay. Last suggestion, I think.
04:14 mtompset alexbuckley: if you type mismatching passwords, it submits and goes to a page that tells me my mistake, that's fine. The problem is "Try Again" takes me back to a blank form.
04:14 mtompset It would be nice to remember the values, so I only have to fix the passwords.
04:15 mtompset Or... you already have validation on the password required, extend the password validation to also force the two values to match before submission?
04:19 alexbuckley right I'll try having a look into your latter suggestion as I think that will be the most straight forward to implement
04:32 mtompset I concur. It's nearing midnight here (11:31pm). Impressive how far along this has come. You are doing a great job. Hope you feel like you are learning, and I'm not too much of a wet blanket.
04:33 alexbuckley I am learning a lot thanks for testing it, I will work more on it tommorow
04:34 mtompset Have a great day (24 hour period), #koha alexbuckley aleisha rangi dcook
07:00 LibraryClaire morning #koha
07:04 fridolin hie
07:04 LibraryClaire salut fridolin
07:05 bag morning LibraryClaire
07:07 LibraryClaire good morning bag :)
07:16 drojf hi #koha
07:16 LibraryClaire moin drojf
07:16 drojf hi LibraryClaire
07:33 marcelr hi #koha
07:33 drojf hi marcelr
07:33 marcelr hi drojf
07:33 LibraryClaire hey marcelr
07:33 marcelr and LibraryClaire !
07:33 LibraryClaire :)
07:35 bag magnuse: HI
07:35 wahanui bonjour, bag
07:35 marcelr hi bag early or late?
07:35 bag early for marcelr late for bag
07:36 marcelr :)
07:36 bag late for marcelr early for bag :)
07:36 drojf hi bag
07:36 bag heya drojf how you doing?
07:36 drojf bag: tired ;)
07:36 drojf #teamearly
07:36 bag #teamlate
07:36 drojf :D
07:37 bag err #teamlater
07:37 LibraryClaire #teamsnooze
07:37 * drojf gets second coffee
07:37 * bag gets nyquil
07:37 LibraryClaire I need to not drink 2 teas within 30 mins of each other
07:37 marcelr #teamcoffee
07:37 LibraryClaire #teamcaffeine
07:37 bag I am totally a tea drinker lately
07:37 LibraryClaire tea is the best
07:38 bag I found a great scottish loose tea
07:38 LibraryClaire black or herbal?
07:38 bag and it’s changed my mornings lately
07:38 bag BLACK
07:38 LibraryClaire with milk?
07:38 bag some days yes - most days no
07:38 marcelr dont do it
07:38 bag never with sugar
07:39 LibraryClaire no, no sugar
07:39 marcelr milk is for cows
07:39 LibraryClaire I like to upset the locals by putting milk in my tea
07:39 bag HA!!!
07:39 bag my father is from london - he puts milk in his tea
07:39 LibraryClaire all brits do
07:40 LibraryClaire you can upset the brits by starting the conversation "milk before or after tea"
07:40 drojf ew
07:40 drojf i tried to learn how the mil thing in tea works but it was kept a secret
07:40 drojf *milk
07:41 bag huh how does this work "milk before or after tea" ?
07:41 LibraryClaire well, if tea is made in a pot
07:41 bag do you mean brewing the tea?
07:41 bag ahh ok I get it
07:41 LibraryClaire then there is a debate about whether or not you put milk in the cup first, then pour the tea in
07:41 reiveune hello
07:41 LibraryClaire or vice versa
07:41 LibraryClaire hi reiveune
07:42 LibraryClaire I admittedly mostly make tea in a mug directly so milk goes after
07:42 bag oh!!! hmmm…. my dad does milk after - I am totally going to mess with him and put the milk in first
07:42 LibraryClaire my dad does too
07:42 LibraryClaire but my nan did milk first
07:42 bag LibraryClaire++
07:42 bag ftw
07:42 LibraryClaire ;)
07:43 bag I may be kicked out of my family soon - but I will enjoy messing with my dad ;)
07:43 bag I hope Ginny never reads that sentence ;)
07:43 LibraryClaire :))
07:44 drojf it's just in the logs forever
07:44 LibraryClaire what's the magic scottish tea?
07:44 bag once she’s older - she’s going to mess with me soo much - I can’t wait
07:45 bag hmm… I’d have to go upstairs to get the box of tea to read the label… it’s nothing magical - it’s just magical to me ;)
07:45 drojf can't wait to hear you complaining about her messing with you :)
07:46 bag I’m such an easy target - she’ll have fun :)
07:46 * LibraryClaire goes to make another cup of tea
07:47 bag and what do you think marcelr and drojf - does she put the milk A ) in first B ) in after C ) not at all
07:48 marcelr she should not do it :)
07:48 drojf she will
07:48 bag oh man if we voted c — we’d have to do c++
07:48 bag and that’s totally my bad
07:48 drojf lol
07:48 marcelr or milk--
07:48 magnuse bag: HI
07:48 bag oh nice ;)
07:49 * magnuse waves
07:49 drojf maybe a if she does not do a whole pot
07:49 bag magnuse: do you put milk in your tea?
07:49 marcelr hi magnuse
07:49 magnuse bag: i don't drink tea...
07:49 magnuse hiya marcelr
07:49 bag what!
07:49 magnuse nor coffee
07:49 drojf heh
07:49 marcelr oops
07:49 drojf do you drink milk?
07:49 marcelr only water?
07:49 bag what does a magnuse drink?
07:49 magnuse lots of milk!
07:49 drojf ok, you're out :P
07:49 * LibraryClaire has returned
07:50 bag with milk after her tea
07:50 bag ?
07:50 LibraryClaire ofc ;)
07:50 marcelr no milk today
07:50 * magnuse is drinking milk as we speak
07:50 bag magnuse: drinks whatever he wants to drink and he loves it
07:50 LibraryClaire I can't drink milk just like that
07:50 magnuse bag++ bywater++ for the podcast
07:50 LibraryClaire 'neat' as it were
07:51 drojf warm, directly from the cow
07:51 bag ewww
07:51 * LibraryClaire shudders
07:51 drojf a friend gave me that once when i was little
07:51 * magnuse never tried that
07:51 drojf almost threw up
07:51 drojf sorry
07:51 drojf tmi :D
07:52 bag thanks magnuse we’ve got one coming in the next few days that is really awesome http://libraryisopen.com/
07:52 LibraryClaire I can only put milk on cereal if it is really fresh, half fat and Icy cold
07:53 magnuse bag: cool! looking forward to that!
07:54 bag it’s with the everylibrary folk
07:54 bag everylibrary.org
07:54 bag great organization
07:55 magnuse cool!
07:58 alex_a hello
08:00 LibraryClaire hi alex_a
08:00 alex_a hi LibraryClaire
08:00 bag heya alex_a
08:01 alex_a hello bag
08:03 magnuse bonjour alex_a
08:03 magnuse @wunder enbo
08:03 huginn` magnuse: The current temperature in Bodo, Norway is 3.0°C (8:50 AM CET on January 12, 2017). Conditions: Mostly Cloudy. Humidity: 60%. Dew Point: -4.0°C. Windchill: -3.0°C. Pressure: 28.68 in 971 hPa (Steady).
08:04 magnuse @wunder marseille
08:04 huginn` magnuse: Error: No such location could be found.
08:04 magnuse @wunder marseille, france
08:04 huginn` magnuse: The current temperature in Lotissement le Pitalugue, Vitrolles, France is 4.1°C (9:00 AM CET on January 12, 2017). Conditions: Clear. Humidity: 88%. Dew Point: 2.0°C. Windchill: 4.0°C. Pressure: 30.09 in 1019 hPa (Steady).
08:04 bag @wunder pdx
08:04 huginn` bag: The current temperature in Mikeshouse Cully, Portland, Oregon is -3.3°C (12:04 AM PST on January 12, 2017). Conditions: Mostly Cloudy. Humidity: 79%. Dew Point: -7.0°C. Windchill: -7.0°C. Pressure: 30.06 in 1018 hPa (Steady). Winter Weather Advisory in effect until 1 PM PST Wednesday...
08:05 LibraryClaire @wunder konstanz
08:05 huginn` LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is 6.1°C (9:00 AM CET on January 12, 2017). Conditions: Overcast. Humidity: 85%. Dew Point: 4.0°C. Windchill: 6.0°C. Pressure: 30.04 in 1017 hPa (Steady).
08:05 magnuse @wunder pharo
08:05 huginn` magnuse: The current temperature in Quetta Sheikh Manda, Pakistan is 1.0°C (8:00 AM PKT on December 27, 2016). Conditions: Haze. Humidity: 56%. Dew Point: -4.0°C.
08:05 LibraryClaire toasty warm today
08:05 magnuse @wunder pharo, france
08:05 huginn` magnuse: The current temperature in Quetta Sheikh Manda, Pakistan is 1.0°C (8:00 AM PKT on December 27, 2016). Conditions: Haze. Humidity: 56%. Dew Point: -4.0°C.
08:05 drojf @wunder berlin, germany
08:05 huginn` drojf: The current temperature in Aprikosensteig, Berlin, Germany is 3.4°C (8:58 AM CET on January 12, 2017). Conditions: Mostly Cloudy. Humidity: 91%. Dew Point: 2.0°C. Windchill: 3.0°C. Pressure: 29.65 in 1004 hPa (Rising).
08:05 drojf springtime
08:05 drojf all my crunchy snow is gone :(
08:05 LibraryClaire mine too :(
08:06 bag @seen paul_p
08:06 huginn` bag: paul_p was last seen in #koha 1 day, 22 hours, 7 minutes, and 10 seconds ago: <paul_p> cait vielen danke Katrin. And happy new year !
08:06 drojf it was really lovely last night
08:06 magnuse anyone want some of my ice?
08:06 LibraryClaire last night was ice rain and wind, lots of wind
08:06 drojf no thanks
08:06 bag we got tons of snow!
08:06 drojf crunchy snow or sun
08:07 bag close to 30cm of snow
08:07 drojf < -5° or > 15°
08:07 drojf who needs the stuff in between
08:07 drojf bag: nice, i'd take some
08:07 bag Ginny had THE fun
08:07 bag but that much snow is very odd for portland
08:08 drojf there is no climate change, trust your president
08:08 drojf it has always been like this, you just forgot :P
08:08 bag O M G
08:08 bag hehe
08:08 bag what an asshat that guy is
08:10 bag alright time for me to go to bed
08:10 bag night night all
08:10 drojf night bag
08:10 LibraryClaire night bag! sleep tight
08:10 magnuse night bag!
08:30 Joubu @later tell tcohen could you give your opinion on bug 4126?
08:30 huginn` Joubu: The operation succeeded.
08:30 Joubu Hi #koha!
08:35 marcelr hi Joubu
08:39 LibraryClaire bonjour Joubu
08:51 magnuse bug 4126
08:51 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 normal, P5 - low, ---, magnus, Signed Off , bulkmarcimport.pl allows -b and -a to be specified simultaneously
08:54 Joubu dcook, mtompset: around?
08:55 Joubu @later tell dcook just to let you know that you should read the "what's on in koha-devel" I send almost every month. I announce useful stuffs for devs, like my git-bz improvement
08:55 huginn` Joubu: The operation succeeded.
08:56 Joubu @later tell mtompset just to let you know that you should read the "what's on in koha-devel" I send almost every month. I announce useful stuffs for devs, like a script to reset easily the DB, or a script to create a superlibrarian user from the cmd line, see koha-misc4dev
08:56 huginn` Joubu: The operation succeeded.
08:56 LibraryClaire Joubu++
08:57 Joubu @later tell koha-developers you should read koha-devel emails...
08:57 huginn` Joubu: The operation succeeded.
09:03 magnuse Joubu++
09:03 * magnuse is behind on reading koha emails...
09:05 Joubu magnuse: It's exactly the goal of the monthly email: you just need to read this one if you want to know what was going on and how you can help.
09:09 faisal hello
09:09 faisal an;yone can help me out with koha
09:10 faisal anyone there
09:13 Joubu yes...
09:21 magnuse Joubu: not quick enough :-)
09:36 eythian @wunder jordaan,ams
09:36 huginn` eythian: The current temperature in Geuzenbuurt Amsterdam, Amsterdam, Netherlands is 7.1°C (10:36 AM CET on January 12, 2017). Conditions: Partly Cloudy. Humidity: 78%. Dew Point: 3.0°C. Windchill: 7.0°C. Pressure: 29.74 in 1007 hPa (Steady).
09:36 eythian https://www.instagram.com/p/BPJ82kdFUpL/ <-- meanwhile in Germany
09:52 Joubu @later tell khall I have just added a followup on bug 17234
09:52 huginn` Joubu: The operation succeeded.
09:53 Joubu @later tell khall I think we should push it quickly and we cannot wait for people to SO+QA (as it takes ages currently). But I'd like to get a review from someone else anyway
09:53 huginn` Joubu: The operation succeeded.
09:55 magnuse so for oai-pmh we can use the extended mode to manipulate the output with xslt. is there anything similar for the sru provided by zebra?
10:00 marcelr magnuse: look for things like <retrieve name="dc"><xslt stylesheet="MARC21slim2DC.xsl"/></retrieve>
10:08 magnuse marcelr: ah, i think i sort of got it, thanks!
10:09 Joubu could someone prove t/Prices.t ?
10:09 Joubu and `pmvers Test::DBIx::Class`
10:09 Joubu pass for me with 0.47 and fail on Jenkins with 0.43
10:10 Joubu I'd like to confirm it's a matter of versions
10:15 Joubu reallly, nobody? It takes 2min guys
10:16 Joubu @later tell tcohen do not know why but t/db_dependent/DecreaseLoanHighHolds.t failed on the last 16.11 build, it pass locally and pass on the node manually. Any ideas?
10:16 huginn` Joubu: The operation succeeded.
10:21 magnuse Joubu: i can give t/Prices.t a try once i spin up the devbox
10:21 Joubu thanks magnuse
10:33 marcelr Joubu: Prices.t passes with me
10:34 Joubu marcelr: which version of Test::DBIx::Class?
10:34 marcelr 0.49
10:34 magnuse -bash: pmvers: command not found?
10:35 pastebot "magnuse" at 127.0.0.1 pasted "prove t/Prices.t" (19 lines) at http://paste.koha-community.org/258
10:35 magnuse failed for me
10:35 magnuse on up to date master
10:35 magnuse in kohadevbox
10:36 Joubu magnuse: sudo apt install pm-utils
10:36 Joubu or pmtools, I never know...
10:36 Joubu it's pmtools
10:37 magnuse pmvers is found in pmtools
10:37 magnuse pmvers?
10:37 wahanui well, pmvers is found in pmtools
10:37 magnuse i have 0.47
10:38 magnuse and the test fails
10:45 Joubu ho, strane, I have 0.47 and they pass :-(
10:45 Joubu strange
10:45 Joubu pfff
10:45 Joubu thanks!
10:45 Joubu ha no
10:45 Joubu magnuse: ! It's not the error I was expecting for :)
10:46 Joubu your DB is not updated
10:46 magnuse hm, i can log in without getting the webinstaller...
10:47 magnuse weird
10:56 Joubu magnuse: /usr/share/koha/lib/Koha/Acquisition/Bookseller.pm
10:56 Joubu in a kohadevbox, /home/vagrant/kohaclone/Koha/Acquisition/Bookseller.pm should be used
11:02 khall mornin!
11:04 Joubu hi khall
11:04 khall Joubu: so there's a followup on 17234 that needs checked and pushed?
11:04 Joubu khall: could you give me the return of `prove t/Prices.t` (just if it passes or not) and `pmvers Test::DBIx::Class`?
11:04 Joubu khall: yes
11:05 khall Parse errors: Bad plan. You planned 16 tests but ran 5.
11:05 khall 0.52
11:05 Joubu error on listincgst?
11:06 khall Can't call method "listincgst" on an undefined value at /home/vagrant/kohaclone/C4/Acquisition.pm line 2880.
11:07 Joubu thanks, so it does not seem related to the version of Test::DBIx::Class
11:07 khall np! brb!
11:07 Joubu but it's not data related, very weird
11:08 Joubu it passes for me and marcel with 0.47 and does not on Jenkins with 0.43 and not for you with 0.52
11:20 LibraryClaire Joubu you still need testing? was in a meeting.
11:21 Joubu LibraryClaire: yes I think it can help. I have no other idea apart from the version of Test::DBIx::Class
11:31 khall Joubu: I've been thinking about the TT notices move, and it seems that it would be best to split each notice into two bug reports, one for adding any new need methods ( or other perl code ) and one for changing the notice text itself. That way the code can be put in place ahead of time. what do you think?
11:32 fridolin a dirty typo in master
11:32 fridolin Bug 17891
11:32 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 trivial, P5 - low, ---, fridolin.somers, Needs Signoff , typo in housebound.tt div tag
11:42 khall Joubu: was able to upgrade from fresh 3.20 to master with your patch, no errors. I'll go ahead and push it then
11:47 khall Joubu: I think I'm mistaken based on your test plan
11:52 drojf @wunder berlin, germany
11:52 huginn` drojf: The current temperature in Aprikosensteig, Berlin, Germany is 4.6°C (12:48 PM CET on January 12, 2017). Conditions: Mostly Cloudy. Humidity: 86%. Dew Point: 2.0°C. Windchill: 5.0°C. Pressure: 29.65 in 1004 hPa (Steady).
11:55 drojf feels really warm outside when you are dressed for <10°
11:55 drojf < -10° that is
11:56 Joubu khall: What's wrong?
11:56 wahanui wrong is :(
12:00 drojf hi cait
12:18 drojf druthb!
12:18 druthb drojf!
12:19 drojf :)
12:38 tcohen morning
12:39 LibraryClaire hola tcohen
12:39 tcohen hi LibraryClaire
12:41 khall Joubu: nm, it looks good. I misread the test plan
12:41 oleonard Hi #koha
12:42 LibraryClaire guten nachmittag oleonard
12:42 oleonard Settling in to the language LibraryClaire?
12:43 LibraryClaire I am well practised in the art of mashing words together :D
12:43 oleonard That sounds doubleplusgood
12:44 Joubu khall: sorry did not see your msg about the TT syntax. Yes that sounds a good plan. First I think we need to indentify what's is missing to make all the notices using TT
12:45 huginn` New commit(s) kohagit: Bug 17234: Need to separate KEY and FOREIGN KEY checks <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05fdd855c8da85d3be27d42721f6a544b0145e57>
12:45 Joubu getting an overview of all the missing things will give us an idea on how big the job is
12:45 khall Joubu: yeah, I think that's something we'll find as we go along. I imagine many if not most won't need additional methods, but I bet a few well
12:45 Joubu heh, I think we are saying the contrary
12:45 Joubu but yes, as you say I don't think there is much to do
12:50 * cait waves
12:54 tcohen Joubu, khall: will we provide a checkbox to choose between syntaes?
12:55 tcohen hi Joubu, BTW
12:55 tcohen :-D
12:55 pastebot "LibraryClaire" at 127.0.0.1 pasted "Prove output" (195 lines) at http://paste.koha-community.org/259
12:55 Joubu hi tcohen !
12:56 khall tcohen: nope, you can use them both at the same time actually!
12:56 khall each notice is processed for both syntaxes
12:56 tcohen >.>
12:56 eythian @wunder jordaan, ams
12:56 huginn` eythian: The current temperature in Ten Kateplein, Amsterdam, Netherlands is 8.9°C (1:51 PM CET on January 12, 2017). Conditions: Scattered Clouds. Humidity: 71%. Dew Point: 4.0°C. Windchill: 7.0°C. Pressure: 29.68 in 1005 hPa (Steady).
12:56 tcohen crazy bastards
12:56 wahanui crazy bastards are playing rugby
12:57 khall : )
12:58 Joubu tcohen: the checkbox is not necessary. We started with it but, since we can guess, we guess :)
12:59 Joubu tcohen: did you backlog?
12:59 Joubu about Prices.t
13:03 oleonard Bug 17890
13:03 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17890 enhancement, P5 - low, ---, gmcharlt, NEW , quickbooks techsupport number 18(884)364-111
13:05 LibraryClaire tasty spam
13:11 Joubu move to security
13:11 Joubu @later tell rangi please remove 17890
13:11 huginn` Joubu: The operation succeeded.
13:12 Joubu move*d*
13:12 tcohen Joubu: do u want me to bisect it?
13:12 Joubu tcohen: yes please
13:17 tcohen Joubu: does this sound familiar? "Can't call method "listincgst" on an undefined value at /srv/jenkins/workspace/Koha_Master_D8_MariaDB/C4/Acquisition.pm line 2880.
13:17 tcohen "
13:17 tcohen maybe an upgrade issue
13:17 oleonard I'm thinking seriously of ditching the JavaScript which triggers "no cover image" for Amazon in the staff client. Would I get in trouble?
13:19 magnuse Joubu: sorry was afk, no time to investigate right now
13:20 tcohen Joubu: it passes if I unset KOHA_CONF
13:22 magnuse huh, i thought the different <retrieval> elements belonging to publicserver in koha-conf.xml were supposed to define what can be used for recordSchema in SRU?
13:23 tcohen indeed
13:26 magnuse i get "Unknown schema for retrieval" for anything other than marcxml
13:29 magnuse on the other hand, recordSchema=index works, without it being defined in koha-conf.xml
13:49 huginn` New commit(s) kohagit: Bug 15905 - Remove use of makepayment <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f59c22b72baaee66b59390d2491b80115ebc2862> / Bug 15905 - Update unit tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c439fc8f68dbb83f71e30e216cbd056b7d5c7049> / Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdi
13:49 cait oleonard: not from me - i think empty looks better
13:50 oleonard Actually cait I remembered a fairly good reason not to :(
13:50 * oleonard will keep tinkering.
13:51 oleonard FYI I'm trying to consolidate JavaScript from across all related catalogue pages (detail, ISBDdetail, etc) into one external script
13:52 oleonard ...so I'm trying to make a more unified function which will handle amazon images. Right now it's duplicated across a couple of templates
13:52 oleonard This is all part of the work to move JS to the footer.
13:52 magnuse oleonard++
13:53 kidclamp could the page just build those 'No image available' links at load and replace them when amazon found instead of the other way around? Don't know if that would help oleonard
13:54 oleonard That's a pretty good idea kidclamp I'll have to think about that
13:54 oleonard Hey kidclamp by the way, it was you asking about split buttons in the header wasn't it?
13:55 kidclamp I was
13:55 * kidclamp doesn't like clicking twice
13:56 LibraryClaire oleonard++
13:56 oleonard I came up with a potential solution and then found an example where someone else implemented it: http://www.bootply.com/66464
13:56 jenkins Yippee, build fixed!
13:56 wahanui o/ '`'`'`'`'`'`'`'`'`
13:56 jenkins Project Koha_Master_D8 build #86: FIXED in 1 hr 12 min: https://jenkins.koha-community.org/job/Koha_Master_D8/86/
13:56 jenkins kyle: Bug 17234: Need to separate KEY and FOREIGN KEY checks
13:56 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 major, P5 - low, ---, philippe.blouin, Pushed to Master , ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
13:57 oleonard Don't know if you tried that already kidclamp
13:58 kidclamp no, I mostly complained to you and waited patiently :-)
13:58 oleonard :D
13:58 Joubu tcohen: no failure??
13:58 oleonard Turns out that's a pretty good strategy
13:59 magnuse oh wow, the zebra config stuff changed a lot since last time i looked at it. all my configs are way out of date... and so is any out of the box package installation
13:59 huginn` New commit(s) kohagit: Bug 15905 [QA Followup] - Fix bad syntax in pay() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7638a33aafacf006d2547724e9e172b8c6d8f9b8>
14:00 kidclamp bootply hates my browser at half screen width, just shows blank until I maximize
14:01 oleonard bootply doesn't understand why you would want to look at anything else
14:01 tcohen magnuse: it got simplified, right?
14:01 magnuse yup
14:02 magnuse i'm adding a comment on bug 12584
14:02 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 normal, P5 - low, ---, koha-bugs, NEW , koha-conf.xml for package installations get out of sync
14:05 magnuse there: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584#c8
14:05 huginn` 04Bug 12584: normal, P5 - low, ---, koha-bugs, NEW , koha-conf.xml for package installations get out of sync
14:06 magnuse i'll have to look at this some more later
14:09 drojf magnuse: what changed/is out of date regarding zebra?
14:09 drojf ah sorry, just saw the link
14:09 drojf nevermind
14:14 tcohen magnuse: lately, it's been happening the other way around
14:15 tcohen I think we should close that omnibus bug and create one for each divergence, making it dependent on the bug that introduced the divergence
14:15 tcohen otherwise it is difficult to spot
14:49 marcelr tcohen: you pulled the trigger :)
14:50 tcohen ah?
14:50 wahanui ah is, like,
14:51 * oleonard waits for wahanui to finish that sentence
14:51 Joubu ah is, like, ha
14:54 cait nice, build fixed!
14:57 Joubu fixed but we did not do anything...
14:58 Joubu 1 has been fixed by a follow up on bug 17234, but not the Prices.t
14:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 major, P5 - low, ---, philippe.blouin, Pushed to Master , ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
14:58 kidclamp Koha elves? they build unit tests instead of shoes
14:58 marcelr have to go
15:04 * tcohen loves writing tests
15:05 * tcohen feels weird
15:05 * Joubu loves that too
15:06 Joubu just because I know I am saving my time
15:06 Joubu (and keeping my back safe)
15:34 jenkins Project Koha_Master_D8 build #87: UNSTABLE in 1 hr 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/87/
15:34 jenkins * kyle: Bug 15907 - Remove use of makepayment in
15:34 jenkins * kyle: Bug 15905 - Update unit tests
15:34 jenkins * kyle: Bug 15905 - Remove use of makepayment
15:34 jenkins * kyle: Bug 15905 [QA Followup] - Fix bad syntax in pay()
15:34 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
15:34 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Remove use of makepayment
15:42 LibraryClaire laters #koha
16:02 reiveune bye
16:53 oleonard Aw, it's HAL 9000's birthday. wahanui did you get him a present?
16:57 oleonard Now I have to read all of https://en.wikipedia.org/wiki/List_of_fictional_computers
17:34 kidclamp I enjoy this fictional computer: https://youtu.be/Ek08KvgqFGM
17:34 kidclamp and it's a great song
17:35 oleonard Agreed
17:37 LibraryClaire what did I just watch
17:38 oleonard LibraryClaire: You just had a very concentrated dose of 80's and you may need to lie down for a while.
17:39 LibraryClaire lying down sounds like a fantastic idea
17:40 * LibraryClaire pretends she didn't enjoy the dose of 80s
17:43 martian523 hello! morning!
17:47 martian523 i have just upgraded to 16.05.07 in the test server. have 2 questions/problems i want to ask. 1. Seems like when retrieving records from Z39.50 servers, foreign characters (Chinese) are not shown correctly. 2. Can tag 264 $a$b$c be imported to Koha when marc records are imported?
18:02 kidclamp Hi martian523
18:02 kidclamp Do you have the correct setting UTF8/MARC8 for the different sources?
18:02 martian523 yeah. it worked in previous koha versions
18:02 kidclamp You should be able import 264 fields, do you want to add them when missing? That would be a marc modification template
18:05 martian523 that would mean adding a tag to marc structure in marc frameworks, correct?
18:06 kidclamp yes. that field would need to be included in the imported framework - I think 264 is by default
18:06 kidclamp though if upgraded maybe not
18:09 martian523 thanks. what about the foreign characters?
18:16 kidclamp I am not sure, that would need some investigation in the logs or someone who knows more about zebra
18:24 martian523 i see. should i file a bug report?
18:26 kidclamp yeah, I would either do that or email the lists
18:27 martian523 thanks!
18:28 francharb Hello #koha
18:28 francharb Happy new year
18:29 francharb Hope everyone is doing great1
18:29 francharb 1
18:29 francharb !
18:29 francharb :)
18:29 francharb Has anyone documented how to translate koha documentation from the po files in pootle ?
18:30 francharb I'm googling, looking into the wiki but haven't find anything yet...
18:31 oleonard I don't know the answer to your question francharb, but... Hi!
18:32 francharb thanks oleonard !
18:32 francharb I found something : https://wiki.koha-community.org/wiki/Koha_Manual#Generating_the_translated_manual.xml
18:32 francharb \0/
18:49 francharb ahah, great, we moved from manual.xml to some rst extension! I have no idea what these are...
18:50 francharb rst = reStructuredText
18:50 francharb sounds nice
18:50 rangi its sphinx francharb
18:50 rangi and its only for 17.05
18:50 francharb hi range!
18:50 francharb hi rangi!
18:50 rangi existing manuals are still docxml
18:50 francharb sounds good to me
18:50 rangi https://gitlab.com/koha-community-devs-users/kohadocs
18:51 rangi (is a mirror of git.koha-community.org but ill accept pull request there are merge them back)
18:51 rangi if you want to work on 17.05
18:51 rangi make gettext
18:51 rangi will create .po files for you
18:51 francharb first, you answered my question before i even asked it
18:51 rangi http://www.sphinx-doc.org/en/1.5.1/intl.html
18:52 rangi we havent fully worked out how we are going to do it for koha yet, but it does allow us to do different images etc as well a lot easier
18:53 rangi and you can edit the .rst files with anything (including your webbrowser on gitlab) without needing a special editor, so hopefully lowering the barrier to participation a lot
18:53 francharb I'm going to read all this! thanks! For now, I need to work on 16.05 manual. That's the version we use with our client
18:53 francharb but hopefully I'll be able to do a bit more this year!!
18:53 rangi sweet
18:54 francharb sounds promising!
18:54 francharb thanks for all the info!
18:54 rangi no worries
18:55 rangi https://koha-community.org/manual/installation/html/ <-- generated with sphinx too, it makes nice docs :)
18:55 francharb you obviously read my mind
18:55 francharb I was about to ask
18:55 francharb ahah
19:08 * oleonard hopes he makes it through writing this commit message today
19:13 * LibraryClaire cheers oleonard on
19:16 oleonard It keeps going, because as I write the test plan I discover more things which need to be fixed
19:20 LibraryClaire i'm relatively convinced i've broken my brain today
19:21 oleonard That's what exercise will do to you. And that's why I never touch the stuff.
19:22 LibraryClaire I went for a run and now I can't move
19:22 kidclamp oleopard gets enough exercise chasing down oantelopes
19:22 LibraryClaire I also foolishly thought a salad might replenish used energy
19:23 oleonard Maybe a meat salad.
19:23 LibraryClaire it had fish fingers in it... there should have been more.
19:23 * LibraryClaire eyes up unsuspecting haribo
19:25 * oleonard changes down an obug
19:25 oleonard ...which he o'caused.
19:25 LibraryClaire o deer?
19:25 kidclamp LibraryClaire++
19:43 CrispyBran A fishfinger salad? :/
19:43 LibraryClaire salad with fishfingers on the side
19:43 CrispyBran I didn't know fish had fingers.
19:43 LibraryClaire I didn't mush them into it or anything
19:44 oleonard Next time just a bowl full of fishfighers with croutons and dressing on top.
19:44 CrispyBran :)
19:44 LibraryClaire croutons are excellent
19:45 CrispyBran Fishfingers and custard!
19:45 LibraryClaire oh no. not custard.
19:45 * oleonard wonders if he has any fishfingers at home to feed his children tonight...
19:45 CrispyBran Maybe a side of Jelly Babies
19:46 LibraryClaire I would kill for jelly babies right now
19:46 cait ...
19:46 cait what did I stumble into here?
19:46 oleonard Just the regular topic in #koha, cait. Food.
19:46 cait ah
19:47 * LibraryClaire likes food
19:47 cait does it have to be so fishy? :)
19:47 * oleonard proclaims that it does
19:47 CrispyBran only with custard
19:47 LibraryClaire ick ick ick
19:48 CrispyBran apparently not enough enlightened folk to catch the reference
19:49 LibraryClaire the doctor
19:49 wahanui aliens are coming to take over our world!!
19:49 CrispyBran did you google it?
19:50 LibraryClaire not this time. I liked that series
19:50 CrispyBran :)
19:50 LibraryClaire but i really dislike custard
19:50 LibraryClaire wahanui botsnack custard
19:50 wahanui :)
19:59 oleonard Bye all
20:18 eythian https://www.youtube.com/watch?v=RXJKdh1KZ0w <-- huh, that's some interesting tech.
20:32 LibraryClaire g'night #koha
22:30 dcook Damn timezones...
22:30 dcook Always slightly too late to catch oleonard!
22:31 dcook Slightly evidently meaning hours in this case >_>
22:34 eythian * oleopard
22:35 dcook @later tell Joubu Cheers. I do read your "what's on" emails, but I must've missed that line about git-bz. September was a very busy month for me, and I no longer work on Koha as much as I used to.
22:35 huginn` dcook: The operation succeeded.
22:39 dcook But eythian is still awake :D
22:39 dcook How's things?
22:40 eythian not bad, trying to get a docker swarm up and running on a cluster of tiny ARM boards i have. Looking forward to the weekend. The usual.
22:43 dcook Sounds about right
22:43 dcook Oh, the weekend is coming. That's nice.
22:44 eythian yeah. and next week we have the work christmas party. Which is two days long.
22:47 wizzyrea eythian: luckyyyy
22:48 eythian wizzyrea: I think the luckier people are those who are flown in from all over the world for it.
22:50 wizzyrea hm true.
22:52 dcook Daaang
22:52 * dcook misses work christmas parties a bit
22:53 dcook Well, when I was working in law, it was mostly tables of alcohol in every corner of every floor...
22:53 dcook I suppose we did go to the horseraces too, although I wasn't so into that
22:53 dcook No, that couldn't have been Christmas... I don't have any idea what I'm talking about
22:53 dcook Except the alcohol. That was memorable.
22:54 wizzyrea you probably killed the brain cells that held the info about the horseraces
22:55 dcook Well, I wasn't drinking. I was super busy working :p.
22:55 dcook I was reclassifying all the library's materials from a homegrown classification system to KF Modified
22:55 dcook Wasn't a huge library, but it was a lot of work.
22:57 dcook But I think the horseraces must've been earlier in the year...as it was warm out
22:57 dcook Maybe I missed the Christmas party because I went back to visit my family in SK
22:57 dcook This seems realistic
23:17 mtompset Greetings,#koha
23:18 mtompset @seen Joubu
23:18 huginn` mtompset: Joubu was last seen in #koha 8 hours, 11 minutes, and 59 seconds ago: <Joubu> (and keeping my back safe)
23:19 mtompset @later tell Joubu I noticed the scripts and stuff, but learning takes time that I don't always have right then and there.
23:19 huginn` mtompset: The operation succeeded.
23:19 mtompset Greetings, alexbuckley
23:19 mtompset No need to change anything. I'm planning on running testing, and hopefully it will pass, and I will sign off.
23:20 mtompset That's the plan.
23:21 rangi @wunder nzwn
23:21 huginn` rangi: The current temperature in Wellington, New Zealand is 20.0°C (12:00 PM NZDT on January 13, 2017). Conditions: Clear. Humidity: 43%. Dew Point: 7.0°C. Pressure: 29.62 in 1003 hPa (Steady).
23:26 mtompset YAY!
23:27 mtompset alexbuckley++ # We have success. I am signing this all off now!
23:28 mtompset oh shoot!
23:29 mtompset I just ran the koha qa test tool.
23:31 pastebot "mtompset" at 127.0.0.1 pasted "Please review this, alex" (187 lines) at http://paste.koha-community.org/260
23:31 mtompset That's the output from the koha QA test tool.
23:31 mtompset While I'm not worried about the adding/deleting messages, the others need to be dealt with.
23:34 mtompset Are you familiar with the koha test tool, alexbuckley?
23:34 alexbuckley No I'm not
23:34 alexbuckley No I'm not
23:39 mtompset Are you using the kohadevbox for development?
23:40 mtompset It's nicely set up as an alias, if I recall: qa :)
23:42 mtompset Yep. qa -v 2 -c #, where -v 2 is max verbosity, and -c # is the number of commits to check.
23:42 mtompset On this bug you have 8.
23:43 alexbuckley_ I am using kohadevbox
23:44 mtompset great, so you can run the alias qa -v 2 -c 8, and see the issues, and then attempt a fix, commit it, change it to -c 9
23:44 mtompset and if there are still problems fix, commit, and then git rebase -i, and merge the last two by changing the last one to squash instead of pick. :)
23:45 mtompset or commit --amend to skip the git rebase -i confusion. :)
23:46 mtompset ping me if you have problems.
23:46 mtompset ping me if you fix them.