Time  Nick          Message
22:11 dac           hehe
20:28 * cait        thinks so
20:27 wizzyrea      hehe
20:27 rangi         just volunteered for 3.18.x rmaint .. maybe im still drunk
20:25 * cait        is jealous
20:23 rangi         *nod*
20:23 wizzyrea      (to me)
20:22 wizzyrea      hawkes bay, surprising.
20:22 wizzyrea      rangi: omgosh.
20:21 huginn        rangi: The operation succeeded.
20:21 rangi         @later tell tcohen look what i found http://alfajores.co.nz/
19:07 catalystpeter rangi: thanks
19:06 rangi         *nod*
19:06 catalystpeter cool, will do. less risky that way in the short term for this training-wheels committer.
19:06 rangi         true, in that case probably best to just do '12'
19:06 catalystpeter so that it uses placeholders it will then look different from all around it
19:05 catalystpeter $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('minPasswordLength',12,'Specify the minimum length of a patron/staff password',NULL,'free')");
19:05 catalystpeter rangi: so, for a trivial patch, if i change
19:05 rangi         hm yeah we should fix it to use placeholders, at least for any new ones for a start
19:04 rangi         the dbi module does the appropriate thing, it goes, oh thats a text column and quotes it
19:04 catalystpeter rangi: thanks - in the case of updatedatabase.pl it is all hard-coded.  maybe the whole script is deprecated - hard to know from here.
19:04 rangi         $sth->execute($someinteger)
19:03 rangi         eg update blah set column = ?
19:03 rangi         catalystpeter: it does seem sane .. if you use placeholders in sql, it does this for you
19:02 huginn        04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 enhancement, P5 - low, ---, koha-bugs, NEW , Set minPasswordLength to a higher value by default
19:02 rangi         bug 9920
18:59 catalystpeter ^ wrt bz9920
18:59 catalystpeter systempreferences's "value" field is text.  But installer/data/mysql/updatedatabase.pl likes to write integers to it (e.g. lines 745-746.)  Maybe this works OK for Perlish or Mysqlish reasons, but it seems like it has the potential to go horribly wrong.  I surmise that if changing a line that writes an integer value in an INSERT or UPDATE statement it should change to a text value (ie stick quotes around it.)  Does that seem sane?
11:36 cait          bgkriegel++ :)
09:49 cait          have a nice sunday :)
09:48 magnuse       sorry, gotta run
09:48 cait          i am trying to make some subjects a bit more specific -hopefully not making it worse :)
09:47 cait          i amstill looking at the long list of enh right now
09:47 cait          yep true
09:45 magnuse       but a lot of the open ones are enh
09:45 magnuse       we report more bugs than we fix
09:45 magnuse       but i was looking at the numbers a couple of weeks back or so
09:45 magnuse       nah, doesn't work
09:43 cait          not sureif this link works: http://bugs.koha-community.org/bugzilla3/report.cgi?x_axis_field=bug_status&y_axis_field=bug_severity&z_axis_field=&no_redirect=1&query_format=report-table&short_desc_type=allwordssubstr&short_desc=&bug_status=NEW&bug_status=REOPENED&bug_status=ASSIGNED&bug_status=In+Discussion&bug_status=Needs+Signoff&bug_status=Signed+Off&bug_status=Passed+QA&bug_status=Failed+QA&bug_status=Patch+doesn%27t+apply&longdesc_type=allwo
09:42 cait          190 in assigned
09:42 cait          in NEW
09:42 cait          wegot almost 2000 bug reports open currently
09:42 magnuse       cait++
09:17 cait          reading through old bugs a bit and closing some:)
09:15 cait          hi magnuse :)
09:15 magnuse       kia ora cait
06:10 mtj           hey rangi, about tonite?