Time  Nick           Message
00:22 eythian        http://www.avclub.com/video/gwar-covers-pet-shop-boys-211000 <-- music for today
00:36 * ibeardslee   goes back to Andy Williams after that
01:57 oleonard       Anyone awake?
01:59 jcamins        oleonard: regretfully, yes.
01:59 dcook          I think so?
01:59 * dcook        pokes himself a bit
02:00 oleonard       So I will inflict my question up on you jcamins: On a package install, when I run a test I get an error about not being able to open XML/SAX/Expat.pm
02:00 oleonard       Hey dcook, congratulations!
02:01 jcamins        oleonard: what test?
02:01 * wahanui      does a testing dance
02:01 oleonard       t/db_dependent/ReportsGuided.t
02:01 jcamins        Oh, right.
02:01 jcamins        An actual test.
02:01 jcamins        Sorry...
02:01 * jcamins      was thinking "when I try to create a user" or "when I catalog a new record and then delete it immediately."
02:02 jcamins        Did you use koha-shell to switch to the correct user?
02:02 dcook          Thanks, oleonard :)
02:02 oleonard       jcamins: No, I don't know about that.
02:02 eythian        do you have XML::SAX::Expat installed?
02:02 jcamins        oleonard: what user are you running the test as?
02:03 oleonard       Myself
02:03 * oleonard     pokes himself a bit
02:03 jcamins        oleonard: did you set the PERL5LIB and KOHA_CONF environment variables manually?
02:05 oleonard       I have them set in .bashrc but I'm not sure they're correct for a gitified package installation
02:07 jcamins        Did you install any XML things using CPAN?
02:07 oleonard       No
02:08 eythian        does locate Expat.pm return something sane?
02:08 jcamins        eythian: I'm a bit unclear about why Expat should be loaded at all.
02:09 oleonard       /usr/lib/perl5/XML/Parser/Expat.pm
02:09 oleonard       /usr/share/perl5/XML/SAX/Expat.pm
02:09 eythian        I'm not sure, I don't know a lot about the XML parsing modules
02:09 jcamins        eythian: (I mean, if it's not there)
02:09 eythian        that looks sane
02:09 jcamins        That matches mine.
02:13 wizzyrea       oleonard - i have a serious jquery question for you :/
02:13 wizzyrea       well serious.
02:13 wizzyrea       I'm stumped.
02:13 * oleonard     puts on his serious face
02:14 eythian        oh no! the serios face!
02:15 wizzyrea       http://i.imgur.com/aIubvW6.png how can I select that text
02:15 wizzyrea       to change it
02:15 wizzyrea       because I've tried everything I can think of
02:15 wizzyrea       and most things the internet can think of.
02:16 oleonard       Oh no the internet can think of so much stuff
02:16 wizzyrea       the problem I mostly have, is that trying to change it removes the checkbox.
02:17 jcamins        wizzyrea: it's kind of icky... I think you need to not use jQuery, and instead just get the text node.
02:18 wizzyrea       hrm.
02:18 mtj            cheers for the awesome gwar eythian
02:18 wizzyrea       oh hi jcamins :)
02:19 jcamins        wizzyrea: $('.confirm_label').contents().filter(function () { return this.nodeType === 3 }).text('My new awesome text yay');
02:20 jcamins        ^^ now with more jQuery
02:20 wizzyrea       hah
02:22 wizzyrea       hm no. The version I'm using doesn't have a class on that label.
02:22 jcamins        You can replace this.nodeType === 3 with something more appropriate like this.textContent === 'Place a hold on ' ... if that's more appropriate.
02:23 jcamins        It doesn't?
02:23 wizzyrea       no
02:23 jcamins        Well, how were you doing it that removed the checkbox?
02:23 jcamins        We can modify that to use my strategy.
02:23 wizzyrea       yeah I was looking at that
02:23 wizzyrea       :)
02:30 mtj            hey wizzyrea, can you get/use the xpath of that element?
02:31 mtj            ...thats often the approach i use
02:31 oleonard       $('.confirmjs_hold label').filter( function () { return this.textContent === ' Place a hold on ' }).text('My new awesome text yay');
02:31 oleonard       Oh no, never mind. Checkbox removed.
02:32 jcamins        oleonard: oh, you're right. You need it to be this.nodeType === 3 && this.textContent...
02:32 jcamins        Sorry, didn't test.
02:33 * jcamins      still can't remember why he sat down at his computer.
02:36 jcamins        oleonard: oh, no, it would work, you're missing .children()
02:36 jcamins        Or contents()
02:37 jcamins        contents()
02:37 jcamins        Not children()
02:37 * oleonard     runs off to count children
02:37 wizzyrea       lol
02:37 jcamins        oleonard: isn't it a bit late for you/
02:37 jcamins        *?
02:37 wizzyrea       thank you both :)
02:38 oleonard       jcamins: It is.
02:43 wizzyrea       yeah both of those still nuke the checkbox
02:43 jcamins        Really?
02:43 jcamins        Hm.
02:43 wizzyrea       I'm glad it's not just me, and that this one actually is tricky.
02:43 jcamins        Maybe I'll try running some code.
02:44 wizzyrea       up to you :)
02:44 jcamins        Now I'm curious.
02:44 wizzyrea       I can see one back in my many go's at this that looks extremely similar to what we've just come up with.
02:46 jcamins        Ohh!
02:46 jcamins        This works for me: $('.confirmjs_hold label').contents().filter(function () { return this.nodeType === 3; }).replaceWith(' My awesome text')
02:46 wizzyrea       I could hug you.
02:47 * dcook        thinks there might be a lot of water and land in the way.
02:47 wizzyrea       hehe there is.
02:47 wizzyrea       well it works in the console
02:47 wizzyrea       but not from opacuserjs hmm.
02:48 wizzyrea       everything else in there works.
02:48 jcamins        How are you running it in opacuserjs?
02:49 wizzyrea       as is, inside $(document).ready(function(){
02:49 jcamins        Yeah, that won't work.
02:49 jcamins        That's getting generated in $(document).ready(...) after opacuserjs is already run.
02:50 jcamins        Where that = the labels
02:50 wizzyrea       oh that's rather a problem.
02:50 * wizzyrea     should have noticed that <facepalm>
02:50 wizzyrea       my noticer has been broken this week.
02:51 jcamins        There are a variety of increasingly crazy ways to deal with it. I suggest trying to append a script element to the end of the page, 'cause that seems just crazy enough it might work.
02:51 jcamins        That is, in $(document).ready(...) append a <script> element with the code we just wrong.
02:51 wizzyrea       we just wrong.
02:51 wizzyrea       keke.
02:51 jcamins        lol
02:51 jcamins        *wrote
02:52 jcamins        It's possible that may have been a Freudian slip revealing my true feelings about doing things that crazy.
02:53 wizzyrea       >.>
02:53 wizzyrea       I suspected so.
02:53 jcamins        That said, do it!
02:53 jcamins        I want to know what happens!
02:53 * wizzyrea     chucks it in the credits.
02:54 jcamins        $('body').append("<script>$(document).ready(function () { $('.confirmjs_hold label').contents().filter(function () { return this.nodeType === 3; }).replaceWith(' My awesome text'); });</script>");
02:54 jcamins        :D
02:55 wizzyrea       that doesn't seem like it would be necessary lol.
02:55 jcamins        I'm not really sure what will happen.
02:55 jcamins        Maybe we will reach the singularity!
02:55 wizzyrea       it totally works. Though I just stuck it in the credits in a script tag :P
02:56 wizzyrea       instead of the body append
02:56 jcamins        Oh.
02:56 jcamins        Heh.
02:56 jcamins        Yeah, that's better.
02:56 jcamins        Though not nearly as crazy.
02:56 wizzyrea       no, not as crazy :)
02:56 jcamins        That option didn't occur to me.
02:56 wizzyrea       two heads are way better than one :)
02:57 wizzyrea       thank you very very very much.
02:57 wizzyrea       I think I'll add that one to the wiki.
02:58 wizzyrea       that label. we hates it, precious.
02:58 jcamins        Hehe.
02:58 jcamins        It's pretty evil.
02:59 wizzyrea       can I have a gratuitous former-kansan moment - the Royals are up 10-0 in a giants led 3-2 series... madness.
03:00 wizzyrea       I was very small when the royals last won the world series.
03:03 jcamins        But they won in your lifetime!
03:03 wizzyrea       yep, and were terrible for 30 years after.
03:04 jcamins        I understand there was a baseball team in this area that until they won somewhere around 2006 hadn't won a world series since my parents were tiny.
03:04 jcamins        I think.
03:04 jcamins        It now strikes me that the person who was so excited was actually more of a hockey fan, so maybe it was a hockey team.
03:04 dcook          It would be exciting if a hockey team won the world series...
03:05 jcamins        I'm sure they won the hockey equivalent if it was a hockey team.
03:05 dcook          Apparently the Carolina Hurricanes won the 2006 stanley cup?
03:06 jcamins        It might've been 2005.
03:08 * jcamins      obviously wasn't paying *that much* attention.
03:08 dcook          I think 2005 was during the NHL lockout?
03:08 * jcamins      believes you.
03:09 * dcook        is just Googling
03:09 jcamins        More than I'm doing.
03:09 dcook          Once upon a time, I could've told you all sorts of stats about soccer teams though.
04:11 kathryn        hi everyone, does anyone know where the discussion got to about which versions of IE are supported in Koha?
04:12 kathryn        I haven't been in this channel for about a month, sorry to drop a clanger ;)
04:25 kathryn        will perhaps try oleonard about this later. seeyas!
04:31 mtompset       Greetings, #koha.
04:34 pastebot       "mtompset" at 127.0.0.1 pasted "Coding Guidelines Question" (6 lines) at http://paste.koha-community.org/252
04:50 mtompset       Anyone have a comment on the paste?
05:36 mtj            hmm, a good question mtompset...
05:37 mtompset       That's why I asked it. :)
05:38 mtompset       Because doesn't that second version just look sexy? :)
05:38 mtj            i guess if we could prove that pootle handled the file correctly, then it might be ok
05:39 mtj            and yes, it does :)
05:39 mtompset       Okay, then how would I prove/disprove that?
05:39 mtompset       Thanks for checking. :)
05:40 mtj            hmm, i cant quite remember, right now... :/
05:43 mtompset       Oh... you were talking about it looking sexy. :)
05:43 mtj            yeah
05:44 mtj            i reckon theres a good chance pootle might handle that syntax ok
05:45 mtj            i didnt much, grepping for pootle/poedit in the repo :/
05:47 mtj            its an area i dont know much about
05:48 mtj            the pootle magic happens on this box  -> http://translate.koha-community.org
05:52 mtj            wow, it would be so great if we managed to get pootle to handle TT files better...
05:54 rangi          pootle will never handle tt files
05:54 rangi          it handles .po files
05:55 rangi          we have scripts that make .po files and then make new tt files from translate po files
05:55 rangi          but thats all outside of pootle, pootle is for translating
05:56 mtj            hiya rangi
05:57 rangi          heya mtj
05:57 mtj            so give me a slap here... which part of koha has a problem with 'complex' TT files ?
05:58 rangi          the scripts to generate po files
05:58 rangi          and the needs of the translators outweigh the needs of the developers about 100 million times :)
05:59 * mtompset     nods.
05:59 rangi          but its all in misc/translator if anyone wants to have a go at making them be able to handle constructs they dont now
05:59 * rangi        has to go put kids to bed
05:59 mtompset       So, if I applied a patch with a tweaked TT file, and then installed a new language for koha, that would show me if the sexy version works?
06:00 rangi          nope
06:00 rangi          you would have to create the .po file
06:00 rangi          bbl
06:01 mtompset       I'm going to bed. This is crazy early.
06:01 mtj            heres what i cant help but wonder... is it somehow possible to substitute TT [% %] blocks in template files, before generating .po files?
06:01 cait           perl translate update lang - translate the new string - then install
06:02 mtj            substitute problematic TT blocks with a unique placeholder string, before translation
06:03 mtj            ..then replace strings with correct TT blocks after
06:04 cait           sounds a bit overly complicated to avoid writing a few more lines
06:05 mtj            think about the bigger picture here cait
06:05 cait           i see bugs in the bigger picture  :)
06:05 * mtompset     grins.
06:05 mtompset       Have a great day, #koha cait mtj rangi
06:06 mtj            i'm not suggesting that anything i have described above woud actually work...
06:07 cait           hheh
06:07 cait           i think i'd try the || idea
06:07 cait           you just have to show that the translated template with a po file that hs the string translated is correct
06:08 mtj            yep
06:09 mtj            ..but cait - what i am suggesting... is for us to consider a solution, that would allow koha templates to have any type of TT expression
06:09 mtj            which would be a pretty big deal
06:12 mtj            anyhoo... it might not actually be technically possible? - so i keep quiet now :)
06:13 mtj            aah, i just saw rangi's misc/translator msg ^
06:40 cait           it would be nice if someone could take a look at but 12505 and bug 12851
06:40 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 normal, P5 - low, ---, jonathan.druart, Needs Signoff , order tags are not removed on claiming serials/orders
06:41 magnuse        bug 12505
06:41 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 normal, P5 - low, ---, simith.doliveira, Needs Signoff , Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
06:41 * magnuse      waves
06:41 cait           morning magnuse :)
06:43 paxed          mtj: something along the lines of bug 12221 perhaps?
06:43 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12221 enhancement, P5 - low, ---, pasi.kallinen, NEW , Remove TT statement placeholders from translatable strings
06:46 mtj            nice paxed, it seems you have the same idea as me
06:48 mtj            i have always be aware of this translation limitation/problem with koha -  but i have never really looked closely at it
06:51 mtj            i wonder why TT blocks cannot just be removed completlely,  when building the .po files
06:52 mtj            it seems the TT blocks are not needed in the .po files, for translation
06:53 mtj            and the TT blocks cause problems, for translation in pootle
06:59 magnuse        cait: i was so sure i had the tests working without the modules this time... looking at tit now
07:00 cait           sorry about that
07:00 cait           hope it was not my mistake
07:00 cait           i feel we are close once we resolve that
07:00 cait           some regression testing and then ready to go
07:01 magnuse        yay
07:04 mtj            hi magnuse, cait - i keep quiet while i do more .po reading... :)
07:06 magnuse        have fum mtj
07:06 magnuse        or fun, your choice
07:12 magnuse        cait: i just ran qa-test-tools on the two commits on bug 11401 on a fresh debian box (yay kohadevbox) - and got everything green and ok
07:12 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 enhancement, P5 - low, ---, magnus, Failed QA , Add support for Norwegian national library card
07:12 magnuse        that is weird
07:16 magnuse        are you sure you ran it on the latest version of the patch?
07:18 cait           hm pretty usre
07:18 cait           but i can try again righ tnow
07:18 cait           updating master
07:19 magnuse        yay
07:19 cait           tests are running now
07:19 * magnuse      keeps his fingers crossed
07:23 cait           hm we got a failing test
07:23 cait           xt/yaml_valid.t
07:23 cait           not ok 11 - patrons.pref is YAML
07:23 cait           #   Failed test 'patrons.pref is YAML'
07:23 cait           #   at xt/yaml_valid.t line 39.
07:23 cait           but you are right, overall it looks better
07:24 cait           can you check the yaml one on your computer?
07:25 magnuse        yup
07:25 magnuse        fails for me too
07:25 magnuse        i'll look at it
07:25 cait           probably just a tiny typo somewhere
07:25 magnuse        right now
07:25 wahanui        right now is testing just somebody seeing if it works?
07:25 cait           i don't see the other problems any more :)
07:25 cait           so when the pref one is fixed, switch back to signed off?
07:27 cait           oh hm
07:27 cait           magnuse: the qa script fails
07:27 cait           do you have that installed?
07:29 cait           magnuse: http://paste.koha-community.org/253
07:29 pastebot       "magnuse" at 127.0.0.1 pasted "koha-qa.pl -c 2 -v 2" (129 lines) at http://paste.koha-community.org/254
07:30 cait           i think i see it  - it's in the files that you would only use if you are using the feature
07:30 cait           but there are some about numeric eq and a POD one too
07:30 magnuse        for me, qa-test-tools/koha-qa.pl is all green
07:30 cait           hm interesting
07:30 wahanui        interesting is sometimes good and sometimes bad
07:30 cait           could you try uninstalling the dependencies added for a test?
07:31 magnuse        i'm on a fresh box, without the NL deps
07:31 cait           hmpf
07:31 cait           i am not sure what's going on :(
07:31 magnuse        $ perl -e "use Crypt::GCrypt" gives me: Can't locate Crypt/GCrypt.pm in @INC
07:31 * magnuse      neither
07:32 cait           but this look slike a valid one
07:32 cait           FAIL	  pod
07:32 cait           *** ERROR: empty =head2  in file misc/cronjobs/nl-sync-from-koha.pl
07:32 magnuse        you do have "Update 2014-10-21" in the big patch?
07:32 cait           it is empty
07:33 cait           hm no
07:33 cait           i have 18
07:33 magnuse        ah!
07:33 cait           ah no, yes, i got it
07:33 cait           21 - below the 18 entry
07:33 magnuse        gah!
07:33 magnuse        yeah
07:34 magnuse        could you paste your misc/cronjobs/nl-sync-from-koha.pl?
07:34 cait           http://paste.koha-community.org/255
07:34 cait           i think it complains about those
07:34 cait           =head2 Check sysprefs  =cut
07:35 magnuse        probably
07:35 magnuse        but why for you and not for me?
07:36 magnuse        did i mess up some perlcritic config file?
07:36 cait           dunno
07:36 cait           not sure why mine is more strict
07:36 pastebot       "magnuse" at 127.0.0.1 pasted ".perlcriticrc" (14 lines) at http://paste.koha-community.org/256
07:37 cait           i have the perlcriticrc copied to my home directory
07:37 magnuse        i have a link from the git repo
07:37 cait           hm i am missing the last line
07:37 cait           and the link is a good idea
07:38 kivilahtio     days
07:38 cait           hi kivilahtio
07:38 magnuse        i have $ perl -MPerl::Critic -e 'print "$Perl::Critic::VERSION\n"' = 1.122
07:39 cait           the pod one seems gone onw
07:39 cait           the others remain
07:39 cait           ah no
07:39 magnuse        about the missing module?
07:39 cait           pod is still there too
07:39 cait           everything like before after updating the file
07:39 magnuse        gah!
07:39 cait           maybe we need someone else to run it
07:40 magnuse        worth a try ;-)
07:40 cait           someone more clever than me... if they say it's ok maybe the script is dumb :)
07:40 reiveune       hello
07:40 wahanui        privet, reiveune
07:41 cait           wonder what those mean
07:41 cait           Use of uninitialized value in numeric eq (==
07:41 * magnuse      thinks he will have to wait a long time if he has to find someone more clever than cait
07:42 cait           pf
07:42 cait           yaml and back to signed off?
07:43 cait           then we can see if we can catch someone to repeat the tests
07:43 cait           ihave to go to work :(
07:46 magnuse        thanks for investigating cait
07:46 magnuse        cait: you ran the tests on ubuntu?
07:46 cait           yes
07:47 magnuse        ok
07:47 magnuse        now, off you go! :-)
07:47 cait           i go :)
07:48 alex_a         bonjour
07:49 magnuse        hiya alex_a
08:14 magnuse        @later tell cait i think my .perlcriticrc does not get picked up, because i run the tests through koha-shell, which means they get run as the koha user, which does not have the .perlcriticrc
08:14 huginn         magnuse: The operation succeeded.
08:18 cait           jajm: around?
08:19 * cait         waves to #koha
08:19 kivilahtio     bye cait
08:20 gaetan_B       hello
08:38 mtj            magnuse:  would be a good tweak to have the qa-tool show what perlcritic file/options its using
08:39 magnuse        yeah
08:41 mtj            perhaps warn if it cant find one, or the md5 doesnt match what it expects
08:43 pastebot       "magnuse" at 127.0.0.1 pasted "pod fail" (10 lines) at http://paste.koha-community.org/257
08:43 magnuse        mtj: when i get a pod fail like that, what is it that is finding the failure?
08:44 magnuse        is that perlcritic or something else?
08:45 mtj            its saying the =head2 section is empty, i think
08:46 mtj            its not perlcriric
08:46 magnuse        yup, but is that affected by the .perlcriticrc config file?
08:46 magnuse        cait and i are getting some different results
08:47 magnuse        mtj: oh, could i bother you to run the qa script on the two patches from bug 11401?
08:47 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 enhancement, P5 - low, ---, magnus, Failed QA , Add support for Norwegian national library card
08:48 magnuse        "The default configuration file is called .perlcriticrc. perlcritic will look for this file in the current directory first, and then in your home directory. Alternatively, you can set the PERLCRITIC environment variable to explicitly point to a different file in another location." from https://metacpan.org/pod/perlcritic#CONFIGURATION
08:48 magnuse        shouldn't this work, then? $ sudo koha-shell -c "PERLCRITIC=/home/vagrant/.perlcriticrc perl -I/home/vagrant/qa-test-tools/ /home/vagrant/qa-test-tools/koha-qa.pl -c 2 -v 2" kohadev
08:49 magnuse        hm, the koha_kohadev user might not be able to read a file in /home/vagrant...
08:50 magnuse        s/koha_kohadev/kohadev-koha/
08:51 magnuse        nah, looks like it can read it
08:53 mtj            lookng now...
09:00 mtj            oops fone..
09:20 magnuse        mtj: np
09:42 pastebot       "mtj" at 127.0.0.1 pasted "testing 2 commit(s) (applied to 3541fc3 'Bug 13088: (RM followup) add missing ')" (131 lines) at http://paste.koha-community.org/258
09:42 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Allow the user to specify a max amount of facets to show.
09:42 mtj            magnuse:  there you go... ^
09:43 magnuse        mtj: thanks a bunch
09:44 magnuse        lots of fails on "valid" - that's... interesting...
09:44 magnuse        hei akafred
09:44 akafred        hola amigo :-)
09:44 mtj            yeah, im not sure what that means... 'valid'
09:44 akafred        magnuse: perlcritic tripped you up?
09:45 cait           so only failing ofr me?
09:45 cait           boo
09:46 * Oak          waves
09:46 Oak            magnuse
09:46 magnuse        Oak
09:46 Oak            :)
09:46 Oak            Guten tag cait
09:46 magnuse        cait: mtj got one fail for pod too, so i'll fix that
09:47 magnuse        mtj: perl -c tells me the syntax should be ok
09:47 magnuse        not sure what "valid" means, though
09:48 cait           sadly me neither
09:48 cait           i think best to look at the code and verify it's ok
09:48 cait           it also seems to only appear in the nl specific files?
09:48 magnuse        nah, C4/Members.pm too
09:49 magnuse        akafred: nah, perlcritic seems to be happy
09:54 magnuse        cait: the qa tool complains about a couple of pod problems in C4/Members that was not caused by me. should i do a qa followup to fix that, or report it as a separate bug or ignore it?
09:56 cait           hm you can fix or point out it was not you
09:56 cait           if it's just syntax and you already found it... a follow up would be accepted :)
09:57 magnuse        cool
10:01 pastebot       "magnuse" at 127.0.0.1 pasted "Different results from koha-qa.pl" (29 lines) at http://paste.koha-community.org/259
10:01 magnuse        yay, now koha-qa.pl is giving me different results every time i run it
10:02 magnuse        two different ways of saying "Spurious =cut command  in file C4/Members.pm", then no mention of it
10:03 mtj            weird
10:03 mtj            i wonder if its not tiding-up after itself, after each run
10:04 magnuse        it does seem to leace some *.pc files in /tmp
10:04 magnuse        s/leace/leave/
10:04 pastebot       "mtj" at 127.0.0.1 pasted "testing 2 commit(s) (applied to 3541fc3 'Bug 13088: (RM followup) add missing ')" (153 lines) at http://paste.koha-community.org/260
10:04 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Allow the user to specify a max amount of facets to show.
10:05 mtj            FAIL   valid
10:05 mtj            Use of uninitialized value in numeric eq (==)
10:05 mtj            meh, pity there is no line number :/
10:06 magnuse        yup
10:06 cait           yeah :(
10:07 mtj            Use of uninitialized value in numeric eq (==) at /home/mason/git/head/C4/Members.pm line 47.
10:07 magnuse        ah, at least that explains the FAIL for valid earlier
10:08 mtj            qa-tool seems to remove the line number...
10:08 magnuse        ah, that line is: if ( C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
10:09 mtj            ah, ok..
10:09 magnuse        'NorwegianPatronDBEnable' would be initialized if you ran updatedatabase.pl, methinks
10:10 magnuse        that is very similar to what cait reported on the bug, akshuly
10:11 mtj            i might try that now..
10:11 magnuse        cait: do you remember if you ran updatedatabase before the qa script?
10:11 mtj            magnuse:  fyi, i get that error from running ...
10:11 mtj            $ perl -w C4/Members.pm
10:12 mtj            ...which is not a real test of the syspref value, (i think)
10:13 magnuse        kia ora khall
10:13 mtj            its just some basic warning error from running 'perl -w'
10:13 khall          mornin!
10:13 mtj            so, very probably an annoying false warning?
10:13 mtj            hiya khall
10:13 khall          hi!
10:14 mtj            i guess what perl wants to make it happy is...
10:14 mtj            if ( C4::Context->preference('NorwegianPatronDBEnable')   and  C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {}
10:14 mtj            something like that?
10:14 magnuse        yeah, i can always do that, if it makes perl happy :-)
10:15 mtj            looks fcking horrible tho
10:15 magnuse        hehe, yeah
10:15 mtj            timmytoady
10:17 mtj            hey magnuse, that did fix the warning ^
10:19 mtj            would be a nice tweak for qa-tool to say 'FAIL valid perl'
10:20 mtj            or 'invalid perl'  even
10:21 magnuse        yeah
10:21 magnuse        just to be clear, the "C4::Context->preference('NorwegianPatronDBEnable')   and ..." fixed it?
10:22 cait           ooh
10:22 cait           maybe hte problem is that i don't have the pref in the db!
10:22 cait           forgot to run the db updates
10:22 cait           could that be the difference?
10:23 magnuse        cait: i *think* it could
10:24 magnuse        that would explain the "Use of uninitialized value in numeric eq (==)" at least
10:24 magnuse        not sure if it explains the complaints about missing modules too
10:25 mtj            magnuse:  yep - it fixed it
10:27 mtj            that warning is a common perl quirk
10:28 mtj            "Use of uninitialized value in numeric eq (==)"
10:29 magnuse        kewl
10:30 mtj            i think the gotcha here, is that when koha is running properly that syspref value *is* defined ok
10:31 magnuse        yup, a fresh install or running updatedatabase.pl sets it to 0, and the test is ok
10:31 mtj            ..but when the file is tested with a basic 'perl -w ./foo.pm' the value is not defined - so we get a warning
10:32 mtj            cool
10:33 mtj            the qa-tool sometimes gives false warnings, on stuff like that
10:34 mtj            ...it seems to be doing just a basic syntax check, rather than actually executing the code properly
10:34 magnuse        something like "perl -c", perhaps?
10:35 mveron         Hi #koha
10:35 magnuse        hiya mveron
10:35 mveron         hi magnuse :-)
10:38 mveron         @wunder Allschwil
10:38 huginn         mveron: The current temperature in Wetter Allschwil, Allschwil, Switzerland is 15.1°C (11:38 AM CET on October 29, 2014). Conditions: Overcast. Humidity: 73%. Dew Point: 10.0°C. Pressure: 30.15 in 1021 hPa (Steady).
10:40 magnuse        @wunder boo
10:40 huginn         magnuse: The current temperature in Bodo, Norway is 5.0°C (11:20 AM CET on October 29, 2014). Conditions: Light Rain Showers. Humidity: 87%. Dew Point: 3.0°C. Windchill: 0.0°C. Pressure: 29.30 in 992 hPa (Steady).
10:40 mtj            oops magnuse, 'perl -c' is the syntax check...  not perl -w
10:42 magnuse        ah :-)
10:43 mtj            perl -w does actually execute, with 'use warnings' forced?
10:45 magnuse        dunno
10:45 mtj            https://stackoverflow.com/questions/6302025/perl-flags-pe-pi-p-w-d-i-t
10:46 mtj            -w: Activates some warnings.
10:46 mtj            i shut up now... :)
10:47 magnuse        thanks for your input, mtj. much appreciated!
10:48 mtj            im giving advice about stuff i dont really understand
10:54 magnuse        don't we all? ;-)
11:12 magnuse        cait: two qa followups attached and status reset to Signed Off on bug 11401
11:12 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 enhancement, P5 - low, ---, magnus, Signed Off , Add support for Norwegian national library card
11:24 magnuse        ah, then there was the yaml file
11:29 cait           thx magnuse
11:31 magnuse        got it, i'll add that to one of the followups
11:32 magnuse        hola tcohen
11:32 tcohen         hi magnuse
11:38 magnuse        cait: the yaml issue should be fixed now
11:41 cait           cool :)
11:43 magnuse        i had "    -" when it should be "     -" ;-)
11:51 cait           magnuse: yay for the tests :)
11:51 oleonard       Hi everyone
11:54 * akafred      can now log in to our internal work-in-progress koha-installation with my OPL user from the old library system ... yay
11:57 * akafred      our installation setup is here https://github.com/digibib/ls.ext which uses our koha in docker setup from https://registry.hub.docker.com/u/digibib/koha/
12:11 magnuse        cait: that yaml test must be stricter than koha, but yeah
12:30 cait           paul_p: around?
12:30 paul_p         cait yep
12:30 cait           feature freeze is friday :)
12:31 paul_p         a lot of F ...
12:31 cait           yes ):
12:31 druthb         Fun Friday for Feature Freeze!
12:31 paul_p         So it mean there are some patches I should sign-off between today and friday...
12:31 druthb         wahanui:  feature freeze?
12:31 wahanui        feature freeze is, like, 3 October 2013
12:31 cait           could you take another look at the database update work?
12:31 druthb         no, feature freeze is friday :)
12:31 cait           andalso, is julian around?
12:31 paul_p         cait yep, that's in my list...
12:32 druthb         wahanui:  feature freeze?
12:32 wahanui        well, feature freeze is 3 October 2013
12:32 paul_p         jajm = are you around ?
12:32 druthb         forget feature freeze
12:32 wahanui        druthb: I forgot feature freeze
12:32 druthb         feature freeze is friday :)
12:32 paul_p         (cait: i'm in Paris, while jajm must be at home. Yes, he's around, but not on koha this week. Maybe the feature freeze can make an exception...)
12:32 paul_p         cait = do you have a specific question for jajm ?
12:32 cait           paul_p: it woudl be awesome if he could rebase his work on order cancellation  - bug 7162
12:33 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 enhancement, P3, ---, julian.maurice, Patch doesn't apply , Factorize code for order cancellation
12:33 cait           paul_p: when will he be back?
12:34 paul_p         cait = probably afk for lunch
12:34 paul_p         I asked him on #koha channel
12:34 paul_p         s/#koha/#biblibre/
12:34 cait           thx
12:34 cait           I'd really like to see the 7xxx gone - and it's a nice feature too
12:35 cait           just acq tends to have conflicts more than every other area it hink
12:38 * magnuse      would like to see a nice grid of the bugs in bz, with different colours for different statuses
12:38 magnuse        must. not. tinker. with. that.
12:39 fridolin       hie community
12:40 cait           heh, i was trying not to say it :)
12:40 cait           hi fridolin
12:43 oleonard       Is <span style="block"> actually valid, or just not flagged as invalid by the validator? Looks wrong to me.
12:44 jcamins        oleonard: looks wrong to me.
12:44 jcamins        Should be <span style="display: block;"> or <span class="block">
12:44 oleonard       Yup. Flies right past the validator on both HTML5 and XHTML strict settings.
12:45 oleonard       I'm guessing the validator doesn't parse CSS so it ignores whatever is in a style attribute
12:46 jcamins        That would make sense.
12:47 jajm           cait, here! :) i'll rebase 7162 immediately
12:51 magnuse        jajm++
12:58 cait           jajm: thx!
13:04 jajm           cait, done. any other bug you want me to rebase ?
13:12 cait           jajm: hm maybe check your patches? I am not sure right now but I worked through a pile of patches the last 2 weeks
13:18 jajm           ok
13:19 cait           and jajm++ :)
13:23 marcelr        paul_p: around?
13:24 cait           marcelr: he is in paris :)
13:24 marcelr        ok
13:24 cait           marcelr: i think travelling - but i asked him earlier abut the database update patch
13:25 cait           it's in the logs :)
13:25 marcelr        i will update the report
13:25 marcelr        probaly he won't mind
13:25 marcelr        bly
13:45 jenkins_koha   Project Koha_Docs build #561: FAILURE in 11 min: http://jenkins.koha-community.org/job/Koha_Docs/561/
13:50 tcohen         morning!
13:51 jenkins_koha   Starting build #562 for job Koha_Docs (previous build: FAILURE -- last SUCCESS #560 25 days ago)
13:51 jenkins_koha   Yippee, build fixed!
13:51 wahanui        o/ '`'`'`'`'`'`'`'`'`
13:51 jenkins_koha   Project Koha_Docs build #562: FIXED in 1 min 58 sec: http://jenkins.koha-community.org/job/Koha_Docs/562/
13:51 jenkins_koha   * Nicole C. Engard: add note about closing basket to receive
13:51 jenkins_koha   * Nicole C. Engard: rename  AuthoritySeparator pref
13:53 * oleonard     cheers nengard_manual
13:55 nengard_manual :)
13:55 nengard_manual not sure I can finish it in time ... but I'll do my best
13:59 tcohen         hi magnuse
14:00 magnuse        o/
14:00 tcohen         \o
14:01 oleonard       Do we have a rule about adding Perl dependencies which are not packaged?
14:01 oleonard       And is there a Debian or Ubuntu version cutoff?
14:01 tcohen         oleonard: negotiate with eythian
14:01 tcohen         those dependencies need to be maintained
14:01 tcohen         and packaged
14:02 oleonard       I'm wondering because I'm testing Bug 11425, which introduces a dependency not available on Ubuntu <= 12.04.
14:02 tcohen         so it'd depend on how difficult is to do it
14:02 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 new feature, P5 - low, ---, julian.maurice, Passed QA , Search form for items
14:02 oleonard       I'm wondering whether the Passed QA status is premature because of that issue.
14:03 tcohen         which dependency?
14:03 oleonard       Template::Plugin::JSON::Escape
14:03 tcohen         ah
14:03 tcohen         it is on 14.04
14:03 tcohen         i think it shouldn't be hard to backport
14:06 jenkins_koha   Starting build #563 for job Koha_Docs (previous build: FIXED)
14:06 jenkins_koha   Project Koha_Docs build #563: SUCCESS in 1 min 45 sec: http://jenkins.koha-community.org/job/Koha_Docs/563/
14:06 jenkins_koha   * Nicole C. Engard: add 'force' to OPACItemHolds
14:06 jenkins_koha   * Nicole C. Engard: update hold section with new OPACItemHolds info
14:06 jenkins_koha   * Nicole C. Engard: update implementation checklist with OPACItemHolds
14:06 jenkins_koha   * Nicole C. Engard: add updateNotforLoanStatusOnCheckin
14:07 oleonard       Is a backport required before pushing the patch?
14:08 tcohen         we need eythian to evaluate
14:11 tcohen         oleonard: i'll try to pack it right now, on 12.04
14:11 tcohen         to see how difficult it would be
14:11 oleonard       http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425#c53
14:11 huginn         04Bug 11425: new feature, P5 - low, ---, julian.maurice, Passed QA , Search form for items
14:12 tcohen         ah :-D
14:13 oleonard       Sorry, but what does that comment mean?
14:14 tcohen         squeeze is really old right now, and we could think of shifting to wheeze
14:14 tcohen         regardless of that, i have successfully build the .deb on 12.04
14:15 tcohen         without unmet dependencies that should also be packaged
14:16 tcohen         oleonard: do i make any sense?
14:18 oleonard       Yes, thank you.
14:30 jenkins_koha   Project Koha_Docs build #564: FAILURE in 10 min: http://jenkins.koha-community.org/job/Koha_Docs/564/
14:37 nengard_manual WHAT???!!! No failures
14:38 jenkins_koha   Starting build #565 for job Koha_Docs (previous build: FAILURE -- last SUCCESS #563 34 min ago)
14:38 jenkins_koha   Yippee, build fixed!
14:38 wahanui        o/ '`'`'`'`'`'`'`'`'`
14:38 jenkins_koha   Project Koha_Docs build #565: FIXED in 4 min 4 sec: http://jenkins.koha-community.org/job/Koha_Docs/565/
14:38 jenkins_koha   * Nicole C. Engard: remove UseTablesortForCirc
14:39 jenkins_koha   * Nicole C. Engard: remove references to opacsmallimage
14:39 jenkins_koha   * Nicole C. Engard: remove OpacShowFiltersPulldownMobile
14:39 jenkins_koha   * Nicole C. Engard: remove SearchEngine
14:39 jenkins_koha   * Nicole C. Engard: add OverdueNoticeCalendar
14:39 jenkins_koha   * Nicole C. Engard: add OverdueNoticeCalendar info to notices tool
14:39 jenkins_koha   * Nicole C. Engard: add HoldsInNoissuesCharge
14:39 jenkins_koha   * Nicole C. Engard: add AcqItemSetSubfieldsWhenReceiptIsCancelled
14:40 oleonard       I submitted a template follow-up for Bug 11425 (which was previously Passed QA) I hope someone can take a look.
14:40 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 new feature, P5 - low, ---, julian.maurice, Needs Signoff , Search form for items
14:53 jenkins_koha   Starting build #566 for job Koha_Docs (previous build: FIXED)
14:54 jenkins_koha   Project Koha_Docs build #566: SUCCESS in 4 min 7 sec: http://jenkins.koha-community.org/job/Koha_Docs/566/
14:54 jenkins_koha   * Nicole C. Engard: add usage stats preferences
14:54 jenkins_koha   * Nicole C. Engard: update schema link in appendix
14:54 jenkins_koha   * Nicole C. Engard: add HEA link to appendix
14:54 jenkins_koha   * Nicole C. Engard: update kyle's koha tools link
14:54 jenkins_koha   * Nicole C. Engard: add html & css library link
14:54 jenkins_koha   * Nicole C. Engard: add usage stats to implementation checklist
14:54 jenkins_koha   * Nicole C. Engard: update about perl modules image
14:58 nengard_manual who manages jenkins? gmcharlt?
14:59 nengard_manual The 3.16 manual isn't listed: http://jenkins.koha-community.org/
14:59 jenkins_koha   Starting build #85 for job Koha_Docs_3.14.x (previous build: SUCCESS)
14:59 jenkins_koha   Project Koha_Docs_3.14.x build #85: SUCCESS in 13 sec: http://jenkins.koha-community.org/job/Koha_Docs_3.14.x/85/
14:59 jenkins_koha   * Nicole C. Engard: update schema link in appendix
14:59 jenkins_koha   * Nicole C. Engard: update kyle's koha tools link
14:59 jenkins_koha   * Nicole C. Engard: add html & css library link
15:00 cait           tcohen: i thought eythian had packed it already - the JSON one
15:00 oleonard       Sorry to un-QA another one, but Bug 12944 needed a very minor follow-up
15:00 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 normal, P5 - low, ---, jonathan.druart, Needs Signoff , There is no way to search orders by creator
15:00 cait           oleonard: you are killing me :P
15:01 cait           well actually writing this abstract for the third time is killing me...
15:01 cait           :(
15:09 nengard_manual @later tell gmcharlt the 3.16 manual isn't listed on jenkins
15:09 huginn         nengard_manual: The operation succeeded.
15:19 tcohen         cait: didn't know, that's great
15:19 tcohen         nengard_afk: need something on jenkins?
15:19 cait           tcohen: that it's killing me??
15:20 cait           tcohen: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425#c53
15:20 huginn         04Bug 11425: new feature, P5 - low, ---, julian.maurice, Needs Signoff , Search form for items
15:20 tcohen         what is killing you?
15:20 nengard        tcohen the 3.16 manual isn't on jenkins
15:20 cait           writing abstracts
15:20 tcohen         a
15:20 tcohen         h
15:21 tcohen         so you're not qaing?
15:21 * tcohen       messing with cait's guilty-ness
15:24 cait           grrrrrr
15:27 oleonard       My follow-up for Bug 643 is so minor that I hesitate to even mark it 'needs signoff'
15:27 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 enhancement, P2, ---, pasi.kallinen, Passed QA , Allow override of 'debarred' status
15:27 oleonard       I don't want to keep the feature from going in because of a minor follow-up
15:28 cait           mark it signed off i will test
15:28 oleonard       Okay
16:11 jenkins_koha   Starting build #567 for job Koha_Docs (previous build: SUCCESS)
16:11 jenkins_koha   Project Koha_Docs build #567: SUCCESS in 6 min 54 sec: http://jenkins.koha-community.org/job/Koha_Docs/567/
16:11 jenkins_koha   * Nicole C. Engard: add new patron privacy
16:11 jenkins_koha   * Nicole C. Engard: add new images
16:11 jenkins_koha   * Nicole C. Engard: add missing image label
16:22 reiveune       bye
16:26 fridolin       bye
16:38 jenkins_koha   Starting build #568 for job Koha_Docs (previous build: SUCCESS)
16:38 jenkins_koha   Project Koha_Docs build #568: SUCCESS in 3 min 42 sec: http://jenkins.koha-community.org/job/Koha_Docs/568/
16:38 jenkins_koha   * Nicole C. Engard: update opacprivacy
16:38 jenkins_koha   * Nicole C. Engard: add OpacCustomSearch
16:39 oleonard       Thanks mveron!
16:39 oleonard       mveron++
16:39 mveron         It is a great feature!
16:46 cait           mveron: 3.18 will be awesome :)
16:46 mveron         ...for libraries using Koha... :-)
16:46 cait           ... and now i am walking home to do QA :)
16:48 * mveron       ...has to run, not walk...
16:51 jenkins_koha   Starting build #569 for job Koha_Docs (previous build: SUCCESS)
16:51 jenkins_koha   Project Koha_Docs build #569: SUCCESS in 1 min 54 sec: http://jenkins.koha-community.org/job/Koha_Docs/569/
16:51 jenkins_koha   Nicole C. Engard: update reports image
17:43 * oleonard     chastises oleonard for adding to the 'Needs signoff' queue again!
17:50 tcohen         #koha: is anyone aware if hiding from OPAC a subfield in the framework works at all?
17:51 tcohen         i don't see how the XSLT's are doing that
17:51 oleonard       I don't think it does now, but isn't there a pending patch for that?
17:51 tcohen         not sure?
17:51 tcohen         pointer?
17:51 oleonard       Bug 11592
17:51 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 normal, P5 - low, ---, mtompset, Needs Signoff , opac detail scripts do not respect MARC tag visibility
17:54 oleonard       (beware monster test plan!)
17:58 wnickc         oleonard: it's tricky to test reports when javascript is off, all the dropdown buttons stopped working
17:58 oleonard       I'm assuming excuse number 2 is "Running tests" https://xkcd.com/303/
18:00 oleonard       wnickc: It's not a big deal since we don't actually support no-js in the staff client, but if you want to confirm that the HTML5 required attributes are correct you can navigate to the edit page and then disable js
18:00 tcohen         OMFG
18:00 oleonard       wnickc: And thanks for testing :)
18:01 wnickc         I figured it out after a bit of clicking+monkey face+head scratching :)
18:03 tcohen         magnuse
18:04 oleonard       When I run t/db_dependent/ReportsGuided.t I get messages like "ok 3 # skip DBD::Mock is too old"
18:06 jenkins_koha   Starting build #570 for job Koha_Docs (previous build: SUCCESS)
18:06 jenkins_koha   Project Koha_Docs build #570: SUCCESS in 1 min 47 sec: http://jenkins.koha-community.org/job/Koha_Docs/570/
18:06 jenkins_koha   * Nicole C. Engard: add ReplytoDefault
18:06 jenkins_koha   * Nicole C. Engard: add ReturnpathDefault
18:06 jenkins_koha   * Nicole C. Engard: add id to ReturnpathDefault
18:06 jenkins_koha   * Nicole C. Engard: add FacetMaxCount
18:07 tcohen         oleonard: what OS version?
18:07 tcohen         debian 6?
18:07 oleonard       ubuntu 12.04 LTS
18:08 tcohen         i'm not sure
18:08 tcohen         maybe you have it installed by habd?
18:08 tcohen         hand?
18:08 wahanui        hand is asleep again, can't type properly
18:12 nengard        LOL
18:13 tcohen         nengard: you filled bug 12829
18:13 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 minor, P5 - low, ---, tomascohen, Needs Signoff , 020z not showing
18:14 tcohen         i'm about to post a correct version for the patch
18:14 tcohen         have you noticed that the same problem happens for ISSN?
18:15 tcohen         but I think I miss-understood the problem
18:15 tcohen         should we show invalid isbns at all?
18:28 magnuse        tcohen?
18:28 wahanui        tcohen is obsessed with packages' scripts
18:28 magnuse        awesome, wahanui
18:28 wahanui        That'll be $1 for the awesome jar, magnuse
18:28 tcohen         and now zebra
18:35 nengard        tcohen, on the phone - will look shortly
19:06 nengard        tcohen signed off
19:07 tcohen         nengard: i'm redoing for the ISSN field
19:07 tcohen         and I noticed the comment from the user
19:07 tcohen         saying that we could consider including $z with an (INVALID) flag
19:08 tcohen         and he added that ($q) could be shown too
19:08 tcohen         what do u think?
19:08 wahanui        do u think is, like, ok to set a cookie name marcdocs_borrowernumber true or false
19:12 nengard        I don't think we want to include it at all
19:12 nengard        it's invalid ...
19:15 tcohen         i had the same feeling, but am not a cataloguer
19:15 tcohen         i'm happy if i can search for it (if i see it on the back on the book)
19:15 tcohen         and what about the $q?
19:17 rangi          i think that things like this is why we built it so people could use their own xslt :)
19:17 rangi          maybe a better thing to do is make a good video/tutorial about how to use a custom xslt
19:18 rangi          :)
19:18 tcohen         he said the $q is new to MARC21, so something we could consider
19:18 tcohen         i just said alsmot the same you're saying rangi
19:18 rangi          then people who want invalid $z can have it, we could also let htem upload their xslt to the wiki (or to controbs.koha-community.org)
19:18 rangi          contribs even (when we set it up)
19:19 rangi          so that others could grab them .. like reports, and frameworks etc
19:19 tcohen         ah
19:19 * rangi        goes off on a tangent
19:19 tcohen         i like the idea rangi
19:20 tcohen         rangi: do u think marc visibility should be handled at export-for-indexing time? I think doing that after we retrieve the record from zebra is too much overhead
19:21 tcohen         ah, nevermind, opac vs. staff
19:25 rangi          yeah its a bit tricky
19:25 rangi          did i ever show you my mental idea for doing MARC display?
19:26 nengard        tcohen or rangi who adds stuff to jenkins? it's missing the 3.16 manual
19:26 * tcohen       hides
19:26 rangi          either of us can
19:27 rangi          ill do it now
19:27 rangi          tcohen: http://www.workbuffer.org/presentations/kohacon_hackfest/html/slide004.html
19:28 rangi          http://www.workbuffer.org/presentations/kohacon_hackfest/html/slide006.html  <-- also we should do this more
19:28 tcohen         interensting
19:28 rangi          http://www.workbuffer.org/presentations/kohacon_hackfest/html/index.html  its from 2012 .. we are doing the plugins and filters now
19:29 tcohen         i was thinking that we do too much on the XML that the indexer returns (no point creating MARC::Record objects
19:30 tcohen         to create XML again and then pass to the XSLT
19:30 tcohen         one thing i did for a customer
19:30 tcohen         was writing an OO TT:Plugin
19:31 rangi          that was a great email from olugbenga
19:31 tcohen         that initializes all his stuff once, and reused
19:31 tcohen         it was
19:35 tcohen         bye
19:35 tcohen         have a nice day #koha
19:35 rangi          yeah, i think you are right, we do double handling
19:35 rangi          cya tcohen
19:36 nengard        rangi that's horrible!!!
19:37 rangi          hehe not my kids
19:37 rangi          but babies will put anything they get in their mouth
19:37 rangi          if their is dog poop .. and they grab it .. thats where it will go
19:37 nengard        oh my
19:38 rangi          snails
19:38 rangi          dirt
19:38 rangi          fluff off the end of the broom
19:38 rangi          you name it, they'll try to eat it
19:38 rangi          tcohen should read back :)
19:41 nengard        hehe
19:53 magnuse        tcohen++ community++
19:55 mtompset       Greetings, #koha.
19:56 rangi          nengard: koha docs 3.16.x is doing its first run now
19:56 rangi          http://jenkins.koha-community.org/job/Koha%20Docs%203.16.x/1/console
19:56 nengard        cool
19:57 jenkins_koha   Starting build #1 for job Koha Docs 3.16.x
19:57 jenkins_koha   Project Koha Docs 3.16.x build #1: SUCCESS in 1 min 16 sec: http://jenkins.koha-community.org/job/Koha%20Docs%203.16.x/1/
19:59 jcamins        I think I missed some context... why are babies putting T::T plugins in their mouth?
20:00 rangi          they put everything in their mouth
20:00 rangi          TT plugins
20:00 wahanui        TT plugins are awesome
20:00 rangi          marc records
20:00 rangi          someones show
20:00 rangi          shoe even
20:01 rangi          babies dont care for your 020$z invalid isbns
20:09 nengard        jcamins https://www.facebook.com/nengard/posts/10101110134473516
20:12 jcamins        lol
20:12 nengard        :)
20:14 jenkins_koha   Starting build #2 for job Koha Docs 3.16.x (previous build: SUCCESS)
20:14 jenkins_koha   Project Koha Docs 3.16.x build #2: SUCCESS in 13 sec: http://jenkins.koha-community.org/job/Koha%20Docs%203.16.x/2/
20:14 jenkins_koha   Nicole C. Engard: remove firefox addon note
20:22 jenkins_koha   Starting build #571 for job Koha_Docs (previous build: SUCCESS)
20:22 jenkins_koha   Project Koha_Docs build #571: SUCCESS in 2 min 46 sec: http://jenkins.koha-community.org/job/Koha_Docs/571/
20:22 jenkins_koha   Nicole C. Engard: remove firefox addon note
20:27 jenkins_koha   Starting build #86 for job Koha_Docs_3.14.x (previous build: SUCCESS)
20:27 jenkins_koha   Project Koha_Docs_3.14.x build #86: SUCCESS in 11 sec: http://jenkins.koha-community.org/job/Koha_Docs_3.14.x/86/
20:27 jenkins_koha   Nicole C. Engard: remove firefox addon note
20:28 cait           tcohen++
20:31 mtj            morning all
20:33 mtj            i was thinking a bit more about the TT/translation/pootle problem last nite...
20:33 mtj            i think i have working solution
20:33 mtj            a
20:34 mtj            rangi, perhaps i could run thru my idea with you, after EOB sometime?
20:35 rangi          yep, if im about
20:36 mtj            cool, no hurry
21:23 rangi          @later tell tcohen MM-OPAC/theme_dep is rebased, should be ready for merge and testing
21:23 huginn         rangi: The operation succeeded.
21:24 cait           rangi++
21:25 rangi          seems to work ok here .. but would like some more people to try the opac with it installed
21:28 wizzyrea       @quote add rangi: babies dont care for your 020$z invalid isbns
21:28 huginn         wizzyrea: The operation succeeded.  Quote #312 added.
21:29 wizzyrea       @quote random
21:29 huginn         wizzyrea: Quote #34: "<chris> oh except that time .. when katipo decided to write an ils just for fun, then forced HLT to use it" (added by gmcharlt at 06:23 PM, September 16, 2009)
21:29 eythian        hi
21:29 wizzyrea       *snerk*
21:29 wizzyrea       hi
21:29 cait           :)
21:30 eythian        also, Template::JSON::Escape is in the k-c debian repo.
21:30 eythian        to clarify my slightly ambiguous comments on bug 11425
21:30 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 new feature, P5 - low, ---, julian.maurice, Signed Off , Search form for items
21:32 mtompset       wizzyrea: That kind of fit. Weird!
21:35 cait           just saying... cusotm xslt are fine when you are not i a multi language environment... then they get somewhat more painful
21:35 wizzyrea       oh yes that does sound really painful.
21:35 rangi          cait: thats fixable too
21:35 mtompset       this is the fun that doesn't end... it goes on and on my friend. ;)
21:36 * mtompset     starts humming Lambchop and friends. :)
21:36 cait           rangi: if we had a separate po file we could easily generate, it hink that could help
21:36 rangi          yep
21:36 cait           so you don' thave to do it manually or alter the standard ones
21:36 rangi          bernardo was working on something like that
21:36 rangi          smaller po files
21:36 cait           yep
21:36 rangi          breaking it up
21:36 cait           also bernardo has a patch waiting for sign off to break the marc dialects into separate po files *hint* :)
21:37 rangi          yep
21:37 barton_away    I'm having issues adding zebra indexes... the same config files will work for one site, but not another, even after a rull rebuild.
21:39 barton_away    s/rull/full/
21:39 rangi          different versions of koha and/or perl modules and/or zebra ?
21:40 eythian        and what does "not work" mean?
21:40 barton_away    heh.
21:41 barton_away    when I run a search after the rebuild, the search doesn't return any results from the marc fields that I've indexed.
21:43 barton_away    I'm on 3.16.x ... some of the builds are git, others are package with zebra files updated.
21:43 eythian        does it return results from the fields you haven't indexed?
21:43 barton_away    yes. search on previous indexes works.
21:43 barton_away    => returns expected results.
21:44 eythian        oh, so either a) it's not recognising your additions to the index definitions, or b) it's not rebuilding correctly.
21:44 barton_away    right.
21:45 cait           ... when i went to work this morning
21:45 cait           the queue was around 25 or so
21:45 cait           now it's 36...
21:45 eythian        well you can test b) easily: move your current indexes out of the way and try a rebuild and see what happens.
21:45 cait           how do you spell the name of that man with the hill and the stone again?
21:46 eythian        huh?
21:46 cait           had to roll it up again and again...
21:46 eythian        Sisyphus
21:46 wahanui        it has been said that Sisyphus is spelt neither druthb nor cait.
21:46 cait           heh
21:47 cait           not sure about that wahanui!
21:47 barton_away    Sisyphus was a driven damned oscelator <= physics pun.
21:54 barton_away    I'm not sure that I follow your logic about rolling back the config changes and rebuilding agian eythian ... if the rebuild failed in such a way that existing indexes were working, a roll-back and rebuild would give me exaclty the same results, right?
21:55 eythian        I didn't mean config, I meant the actual generated indexes.
21:56 eythian        so you know your rebuild is working.
21:56 barton_away    ah.
21:57 barton_away    good thought, that.
21:57 mtompset       Have you started the zebra daemon? :)
21:57 barton_away    yeah.
21:57 barton_away    ... if only it were that easy.
21:58 dcook          I'm a fan of using yaz-client to query Zebra more directly in case it's a Koha thing
21:58 dcook          Or a case of an error not making its way back to Koha
21:59 dcook          You can also see what's being stored in the indexes if you have Zebra configured just so
21:59 barton_away    I've been meaning to ask #koha if that was possible...
21:59 cait           coudl someone sign off on 12851 and 12505?
22:00 barton_away    dcook -- how do I query yaz-client to list indexes?
22:00 dcook          barton_away: I'm double-checking as we speak ;)
22:00 barton_away    or at least, where do I look in the documentation.
22:01 dcook          Documentation... now that's a very good question :p
22:01 dcook          Are you using DOM?
22:02 barton_away    yep.
22:02 dcook          K, look in your "zebradb/retrieval-info-bib-dom.xml" file
22:03 pastebot       "dcook" at 127.0.0.1 pasted "zebradb/retrieval-info-bib-dom.xml" (22 lines) at http://paste.koha-community.org/263
22:03 cait           hm no oleonard
22:03 cait           should current location be holding branch?
22:03 dcook          iirc, the line about "<retrieval syntax="xml" name="index"/> <!-- allow viewing index entries -->" should show you the indexes
22:03 cait           hm holding library?
22:03 wahanui        holding library is just the 'place it is currently'
22:04 dcook          barton_away: Once you've added that... you might need to restart Zebra or rebuild your indexes, but I can't remember for certain
22:04 dcook          It might even already be there so you might not need to worry
22:05 barton_away    looks like it's already there.
22:05 dcook          Sweet as
22:06 dcook          So now you go into koha-conf.xml and look up the socket for the server in the "listen" element
22:06 dcook          something like "unix:/dcook/koha-dev/var/run/zebradb/bibliosocket"
22:06 dcook          yaz-client unix:/dcook/koha-dev/var/run/zebradb/bibliosocket
22:06 dcook          base biblios
22:06 dcook          f test
22:07 dcook          format xml
22:07 wahanui        i heard format xml was a client side transformation of whatever comes back from the server.
22:07 dcook          show
22:08 cait           eythian: how do I install that JSON dependency?
22:08 barton_away    sweet!
22:08 cait           iam tryin to test owen's follow up
22:08 barton_away    that worked!
22:08 eythian        cait: sudo apt-get install libtemplate-json-escape-perl
22:08 cait           hmmm
22:09 eythian        make sure you do apt-get update first
22:09 cait           i will try again
22:09 cait           thx
22:10 eythian        and also make sure you have the k-c repo enabled.
22:11 cait           yeah thought it was
22:11 cait           waitin gfor another package to finish installing
22:12 cait           then i can try again
22:12 Mexiboy        hola
22:12 cait           hola
22:12 wahanui        what's up, cait
22:13 Mexiboy        Alguien me puede ayudar, quiero personalizar la parte administrativa de Koha
22:13 Mexiboy        ¿Alguna referencia?
22:13 cait           you need help to customize.... a part of administration?
22:13 Mexiboy        Yes, cait!
22:13 cait           mostly english speakers this time of the day :)
22:13 cait           what is your problem?
22:14 Mexiboy        I want to customize, change logo, link colors
22:15 Mexiboy        etc.
22:16 cait           owen's blog?
22:16 wahanui        rumour has it owen's blog is http://www.myacpl.org/koha/
22:16 cait           some hints about custmizing koha can be found there
22:16 cait           also there are preferneces whre you can put custom css and javascript
22:16 cait           intranetuserjs and intranetusercss i think
22:17 cait           and there is a spanish speaker :)
22:17 * magnuse      checks up on the status of bug 11944 before falling asleep
22:17 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 major, P5 - low, ---, jonathan.druart, Passed QA , Cleanup Koha UTF-8
22:17 Mexiboy        than good, excellent
22:17 cait           packages
22:17 wahanui        i heard packages was at http://wiki.koha-community.org/wiki/Debian
22:18 dcook          I was wondering why no one was saying anything... then realized that I had accidentally closed hexchat :p
22:18 tcohen         hicait
22:18 barton_away    dcook++
22:18 dcook          :)
22:18 Mexiboy        I'm really new to Koha, it is new to me, but very interesting
22:18 dcook          If you want to see marcxml, you can also try "elements marcxml"
22:18 tcohen         rangi: awesome news!
22:19 barton_away    cool...
22:19 tcohen         dcook?
22:19 wahanui        somebody said dcook was the designated masochist
22:19 dcook          barton_away: Iirc, the reason why it shows you "z:index" when using "format xml" is because "index" is the first element set defined in the Zebra config
22:19 tcohen         someone is playing with yaz?
22:20 barton_away    tcohen: dcook was showing me how  to list existing indexes via yaz.
22:20 cait           Mexiboy: welcome - and don't let them confuse you :)
22:20 tcohen         magnuse: as of me, it is failing-qa because the t/Charset.t tests fail
22:20 tcohen         barton_away: nice :-D
22:21 tcohen         hi Mexiboy
22:21 barton_away    yeah.... that will definitely make life easier for me.
22:21 tcohen         so you are from Costa Rica?
22:21 dcook          barton_away: Glad ot help :)
22:21 dcook          to*
22:22 Mexiboy        Thanks, cait're very good person
22:22 Mexiboy        hi tcohen
22:22 barton_away    yeah, that's definitely going into my notes, and will be shared far and wide.
22:22 dcook          :D
22:22 cait           eythian: it doesn't work :(
22:23 tcohen         Mexiboy: hablo español si necesitas
22:23 magnuse        tcohen: oh noes! hope it can be fixed in time for 3.18
22:24 Mexiboy        ok tcohen
22:24 eythian        cait: what do you mean by "doesn't work"?
22:24 cait           that i added  deb http://debian.koha-community.org/koha squeeze-dev main
22:24 tcohen         hanoi towers
22:24 cait           and it still won't install
22:24 Mexiboy        gracias tcohen
22:26 eythian        cait: you know to report with more detail than that :)
22:27 cait           yes...
22:27 cait           ok, i noticed the repo was not there
22:27 cait           so i created a file koha.list and put that line in
22:27 cait           wget -O- http://debian.koha-community.org/koha/gpg.asc | sudo apt-key add -
22:27 cait           seems ok
22:28 tcohen         magnuse: i don't understand the expected semantics of the C4::Charset::IsStringUTF8ish function, that's why I don't know how to patch it
22:28 tcohen         it seems that if we stick with the loose utf8 interpretation, (i.e. utf8::decode) tests pass
22:28 tcohen         but they don't if you use the 'strict' decoding from Encode
22:29 tcohen         so, because of the "ish" thing, I guess is ok to just leave the utf::decode call
22:29 tcohen         but, need information to be sure of the consecquences
22:29 tcohen         need gmcharlt basically
22:29 eythian        cait: so so far everything's working then?
22:29 cait           i think so
22:30 cait           then i ran sudo apt-get update
22:30 cait           OK   http://debian.koha-community.org squeeze-dev/main amd64 Packages
22:31 cait           sudo apt-get install libtemplate-json-escape-perl
22:31 cait           not found
22:32 cait           so... what's wrong?
22:32 rangi          you missed plugin
22:33 rangi          http://debian.koha-community.org/koha/pool/main/libt/
22:33 rangi          libtemplate-plugin-json-escape-perl
22:33 eythian        oldstable|main|source: libtemplate-plugin-json-escape-perl 0.2-1kohaoldstable1
22:33 * cait         blames eythian :)
22:34 cait           installing now
22:35 eythian        cait: you quoted the correct name in the bug yourself :)
22:36 cait           that was days ago :)
22:37 tcohen         gmcharlt: could you help me understand how C4::Charset::IsStringUTF8ish is supposed to work?
22:38 gmcharlt       tcohen: IIRC, the general idea is to see if the scalar is either a utf8 string (with the utf8 flag set) or contains a sequence of bytes that is valid UTF-8
22:41 tcohen         gmcharlt: what confuses me is the "appears"
22:41 tcohen         "appears to be valid UTF-8"
22:43 tcohen         the only broken stuff from the UTF8 patches is that function's unit tests
22:44 gmcharlt       "appears" in the sense that a string of octets that can encode a UTF8 string, are actually in a different character set
22:44 gmcharlt       which can happen in malformed MARC records, albeit rarely
22:45 gmcharlt       the "ish" is basically just an expression of that possibility existing
22:46 tcohen         i wrongly interpreted it in the 'loose UTF8 interpretation' the utf8:: namespace tools do
22:48 gmcharlt       what can I say? the POD for that function explicitly includes a section explaining why it's called IsStringUTF8ish rather than IsStringUTF8
22:49 tcohen         thanks for the explanation gmcharlt
22:50 gmcharlt       you're welcome
22:50 cait           ... so why do the tests fail now? :(
22:53 tcohen         i think it is because utf8::decode and Encode::decode('UTF-8'  do different things with stuff that is not UTF
22:54 tcohen         i think we should sitck with utf8::decode until someone has a regression test for a bug introduced by using it
22:58 dcook          Hmm, I guess when a spec says "non-normative", they really mean it...
22:58 * dcook        says in an unrelated comment
23:03 barton_away    dcook -- Ok, I've been playing with `formatxml` and `elements marcxml` -- it's clear to me that `elements marcxml` returns indexed marc xml entities, and using `show` with `format xml` shows the index names ... but does it display all possible index names, or only those for which marc fields exist?
23:04 tcohen         i bet the latter
23:04 barton_away    yeah, I'm thinking so, as well.
23:05 barton_away    that's still a huge leap forward for me...
23:05 tcohen         because you are querying the internal zebra data structure
23:05 tcohen         happened to me with the facets
23:05 tcohen         what are you trying to do?
23:06 barton_away    tcohen - I'm trying to add indexes... after a re-index, search on the new indexes doesn't return any results. I'm trying to trouble-shoot that.
23:07 dcook          Yeah, it'll just be the indexes that have been filled I think
23:07 tcohen         in DOM, right?
23:07 dcook          Or rather..
23:07 barton_away    yeah, dom.
23:07 dcook          You might have empty indexes but that's probably because the field/subfield in the record was empty
23:07 tcohen         so you have the biblio-koha-indexdefs.xml file, with the new indexes
23:07 dcook          But if a certain field/subfield tied to an index doesn't exist in the record, it won't appear there
23:07 tcohen         and generated the koha-zebra-indexdefs.xsl file
23:08 dcook          ^
23:08 tcohen         if that's the case, you could try
23:08 barton_away    tcohen yes on both.
23:08 dcook          What tcohen said tripped me up a few times with DOM at first. I was changing the XML but not the XSL
23:08 tcohen         running xsltproc .../biblio-zebra-indexdefs.xsl marc_record
23:08 tcohen         and see
23:08 dcook          Ooo
23:08 tcohen         if the desired new index shows
23:09 dcook          tcohen++
23:09 tcohen         because, after all, that's what zebraidx will to to index your record
23:09 tcohen         *do
23:09 barton_away    indeed!
23:09 barton_away    tcohen++
23:10 rangi          and put this all on the wiki barton_away :-)
23:10 tcohen         so much reading should always serve someone
23:10 tcohen         rangi++
23:11 * dcook        really needs to write up some Zebra wiki pages sometime...
23:11 tcohen         martin's is a good one
23:11 wizzyrea       yes you do because we can't keep that knowledge locked up in only your brain.
23:11 dcook          ^
23:12 barton_away    yeah, I used martin's as my bible for quite a while.
23:12 dcook          I wonder if I'd have more time if I had a TARDIS...
23:12 tcohen         now we deprecated grs1, maybe we should start a DOM-only page
23:12 dcook          :D
23:12 tcohen         maybe a clone?
23:12 barton_away    yeah.
23:13 tcohen         or two?
23:13 dcook          Nah, it wouldn't be that efficient in terms of sharing knowledge probably
23:13 dcook          Unless we had a hive mind O_O
23:13 dcook          And... that was the start of the apocalypse
23:14 barton_away    koha community <= first movers.
23:14 tcohen         dcook: you could write a script to generate an SRU explain file from our configuration files
23:15 barton_away    actually ... I have a perl file that reads yaml and spits out various pieces of zebra config.
23:15 barton_away    ... keep me from going any crazier than I am already.
23:15 tcohen         http://bmayor.biblio.unc.edu.ar:7090/
23:15 cait           but now seriously... i need some sign offs! :) bug 7673 - string corrections from owen?
23:15 huginn         04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , New patron permissions to manage items (edit, batchmod, delete all)
23:16 * tcohen       runs away
23:17 barton_away    oh, that's right tcohen ... I did run across something similar somewhere in the guts of koha...
23:18 tcohen         barton_away: that's the default explain file i'm sure we all have :-D
23:20 barton_away    so why aren't we using that to generate the rest of the zebra configs agian?
23:21 dcook          cait: Wish I could but I'm fixing stuff due to "flexible" standards
23:22 barton_away    isn't apple having similar issues with the iphone6?
23:23 dcook          While I don't know anything about the iphone6, I'm going to giggle anyway :)
23:25 tcohen         yay! my replacement phone has been delivered!
23:25 tcohen         to BArcelona! :-(
23:25 dcook          :(
23:25 cait           :/
23:25 dcook          D:
23:25 barton_away    dcook: http://i.imgur.com/JY1yUWyl.jpg
23:26 dcook          O_o
23:26 tcohen         is any of you coming to argentina soon?
23:26 tcohen         by barcelona?
23:26 dcook          hehe
23:26 dcook          I wish!
23:27 * dcook        anticipates never leaving Australia again
23:27 tcohen         hey, you will get the permanent residence
23:29 dcook          http://www.smh.com.au/digital-life/mobiles/apple-responds-to-bending-iphone-6-reports-20140925-10m9z9.html
23:29 dcook          ^awesome
23:29 dcook          tcohen: Hope so. Once I send in the application and all the monies.
23:32 barton_away    Ok, I've bookmarked the our conversation starting when dcook started showing me how to view zebra indexes in yaz-client: http://irc.koha-community.org/koha/2014-10-29#i_1588267
23:32 tcohen         aren't you bringing them a new australian?
23:32 tcohen         isn't it worth all the money you could give them!
23:32 tcohen         ??
23:32 barton_away    someday, there will be a wiki article that comes out of this.
23:33 barton_away    thanks for the edjumacation dcook, tcohen.
23:34 dcook          no worries, barton_away
23:34 dcook          tcohen: :p
23:35 dcook          Also need to have my PR before I can get any paid parental leave
23:35 tcohen         barton++ # we love documented stuff
23:35 * dcook        is really glad that his wife is a citizen
23:35 dcook          Documentation ftw!
23:40 cait           what is the general opinion to sysprefs with spaces?
23:41 barton_away    -1
23:41 eythian        yeah, there's already about three conventions, we don't need a fourth
23:42 cait           *sigh*
23:42 cait           i agree
23:45 tcohen         are you ready?
23:45 cait           hm?
23:46 cait           gah.
23:46 cait           it also touches prog instead of bootstrap templates :(
23:47 tcohen         don't worry, it is 2 minutes from not applying anymore
23:47 rangi          well in a minute it will no longer apply
23:47 rangi          *snap*
23:47 cait           but... I don't want to fail stuff
23:48 rangi          its going to have to
23:48 rangi          it wont apply
23:48 cait           ... but it keeps coming back if i fail it
23:48 rangi          you can set it to patch doesnt apply
23:48 rangi          and note fix the syspref while fixing that
23:51 cait           i know