Time  Nick       Message
00:00 dcook      eythian: cool. good to know :)
00:00 dcook      Honestly, I had totally forgot
00:08 tcohen     hi dcook
00:08 tcohen     dcook: can I trust your IE patches do their job? I don't have one for testing
00:10 dcook      tcohen: That's a tricky question :p
00:10 dcook      I think that they do the job :p
00:10 dcook      If you want to test, there are VMs that you can use
00:10 dcook      https://www.modern.ie/en-gb/virtualization-tools
00:10 dcook      That might be the wrong link...
00:10 dcook      Right website though
00:11 dcook      Yeah, that's the right link
00:11 dcook      tcohen: Is there a particular patch you're curious about?
00:11 tcohen     bug 12325
00:11 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 normal, P5 - low, ---, dcook, Passed QA , Marc and Card view in Z39.50 Results doesn't work properly in IE 8
00:12 tcohen     i tested they don't introduce regressions for chromium and firefox
00:15 dcook      Mmm, I think that one is pretty trustworthy ;)
00:17 * dcook    glares at vimdiff
00:24 tcohen     heh
00:24 tcohen     dcook: will u be able to give the facet patches a ride?
00:24 dcook      Possibly later in the day. I have a bunch of DSpace work I need to get done today first :/
00:28 tcohen     ok
00:28 tcohen     thanks!
00:29 dcook      What's the bug number again, tcohen?
00:29 dcook      I think I forgot to send myself that reminder email the other day
00:29 tcohen     bug 12788
00:29 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12788 normal, P5 - low, ---, tomascohen, Needs Signoff , Refine search displays 4xx fields from authority records
00:30 tcohen     it has a weird name, but belive me heh
00:31 tcohen     its easy to test
00:31 tcohen     :-P
00:32 dcook      Bloody vimdiff...
00:32 dcook      Totally busted my templates..
00:34 * tcohen   uses kdiff3
00:35 dcook      I'm thinking I might give that a whirl
00:35 dcook      Yay for "undo"
00:37 dcook      Then again maybe it wasn't vimdiff, and it's just that tomcat sucks..
00:37 dcook      Or neither. I have no idea...
00:39 dcook      Hmm, perhaps it's coincidence and it's a third-party website that is letting me down..
00:39 tcohen     dcook: do u use git for maintaining your templates? and re-compile the war to deploy the updated one?
00:46 tcohen     night #koha
00:47 tcohen     am i online?
01:07 dcook      yikes, a very unstable third-party website...
01:11 irma_      G'day mtj ^^
01:13 mtj        hi irma_, #koha
01:15 petter     hi #koha
01:15 rangi      hi petter
01:15 petter     hi chris!
01:18 indradg    hi
01:18 wahanui    kia ora, indradg
01:20 indradg    I'm planning to add a syspref that will allow the koha admin to toggle whether an js-based multi-lingual keyboard is supported or not... this will be available to both lib and opac interfaces.
01:21 indradg    I should add it under - I18N/L10N preferences
01:21 indradg    right?
01:22 indradg    rangi: ^^^
01:23 rangi      yep
01:23 indradg    :)
02:52 dcook      My bad for bashing vimdiff
02:52 dcook      Folding just occurs somewhat unexpectedly...
04:24 dcook      "zr", you're my friend
04:24 dcook      Not that I'm actually still using vimdiff. But I just remembered, in case anyone else feels like using vimdiff for the first time.
04:32 wizzyrea   ...question, why can we not have a custom XSLT for the list view?
04:32 wizzyrea   as distinguished from the regular result view
04:33 wizzyrea   an acceptable answer would be "because no one has made it do that"
04:33 dcook      I think that's probably the answer
04:33 * dcook    isn't sure though
04:33 dcook      I think using XSLT in list view was a fairly recent addition as well
04:34 dcook      Actually, I might be wrong there...
04:34 wizzyrea   it needs a pref like the one for results and detail
04:34 wizzyrea   default, or any custom one
04:34 dcook      The only downside of that is maintaining another XSLT :/
04:34 wizzyrea   or it can use the result one, unless you tell it otherwise
04:34 wizzyrea   then you still only maintain the regular ones.
04:34 dcook      I'm thinking that's the way to go
04:35 dcook      I'm usually good using the results, but yeah...I think sometimes it could be handy to have a custom list view
04:35 wizzyrea   well for example
04:35 wizzyrea   I have a library who wants to see the abstract on the result view
04:35 wizzyrea   for lists.
04:35 wizzyrea   but not on the results
04:35 dcook      Exactly
04:35 dcook      I think it's a reasonable change :)
04:36 dcook      I wonder what the state of the XSLTs is...
04:36 dcook      I remember suggesting deprecating the non-XSLT display...
04:36 wizzyrea   sad as, i think
04:36 dcook      Oh?
04:36 wizzyrea   desperately needs someone to put the RDA fields on
04:36 dcook      Mmm, yeah, I've done that locally. It's on the "to do" list
04:37 dcook      for upstreaming
04:37 wizzyrea   we lack funding for this work.
04:37 dcook      Of course, if they don't have up-to-date frameworks, they won't have RDA fields anyway :p
04:37 dcook      yo cait
04:37 eythian    surely it's only a few days work to implement in the first place
04:37 eythian    hi cait
04:37 eythian    wahanui: cait?
04:37 wahanui    cait is probably from germany. Ask me about germany.
04:37 dcook      eythian: Which?
04:37 wahanui    i guess Which is why it is strange that it BROKE... after upgrading like that.
04:38 eythian    dcook: RDA
04:38 cait       hi all
04:39 wizzyrea   putting the fields on is really no big deal.
04:40 dcook      Yeah, it would be pretty trivial
04:40 wizzyrea   though... I suspect we'd probably change our koha->marc mappings to prefer the RDA publisher fields over the old ones
04:40 dcook      The 264 is a bit tougher than the 336,337,338
04:40 wizzyrea   well yeah.
04:40 dcook      Yeah, we've done that for some of our libraries
04:40 wizzyrea   actually... could you just do that?
04:40 dcook      Hmm?
04:41 dcook      In terms of display?
04:41 dcook      Only if you're not using the XSLTs
04:41 wizzyrea   ah right
04:41 wizzyrea   wish there were a way to reconcile the visibility features of the frameworks with XSLT.
04:41 dcook      The thing about RDA that I find interesting...besides the 264...I don't necessarily see the utility
04:41 wizzyrea   there probably is.
04:41 dcook      mtompset was working on that
04:41 wizzyrea   nobody has told us how to display it
04:41 dcook      exactly
04:42 dcook      I've had a few libraries want the 336, 337, 338, but I'm not sure why
04:42 dcook      Other than, perhaps, that the LoC does it
04:42 eythian    wizzyrea: mtompset has done that, not sure if it's in master yet
04:42 wizzyrea   "because the natlib is giving us records that have it"
04:42 wizzyrea   oo
04:42 eythian    I recall it not being far away from being in
04:42 wizzyrea   \o/ that is happy making
04:42 dcook      eythian: I don't think so. I wasn't too keen on some of the code.
04:42 wizzyrea   that is unhappymaking <o>
04:42 dcook      Although I just commented. I didn't fail QA or anything like that
04:43 dcook      I think he might've addressed some of my comments. But that was a while ago
04:43 wizzyrea   he hasn't been around much lately
04:43 wizzyrea   ok well I have to run to get the sprog.
04:43 dcook      bug 11592
04:43 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 normal, P5 - low, ---, mtompset, Needs Signoff , opac detail scripts do not respect MARC tag visibility
04:43 dcook      Hmm
04:44 dcook      ciao wizzyrea
04:44 dcook      It would be pretty rad if the displays respected the visibility settings
04:44 * dcook    needs to grab a late lunch...
04:47 eythian    hmm, why is my dev koha confused as to whether it should be trying to use prog or bootstrap?
04:47 eythian    and so ends up using a bit of each that causes explosion
04:48 dcook      Eeep
04:52 eythian    this is totally weird
04:52 eythian    also, I'm making a new law against modules that don't stacktrace when they fail
05:03 * dcook    doesn't have anything to add about Koha. Just complaints about DSpace :p.
05:06 dcook      I'm thinking it's scriptaculous or prototype magic that I'm not seeing...
05:13 eythian    ah
05:13 eythian    I had opaclanguage set to en-NZ but hadn't generated bootstrap templates for most of it.
05:13 eythian    so it was falling back to prog except sometimes.
05:13 eythian    that was an annoying mystery
05:15 dcook      Well solved :)
05:15 eythian    it came from tracing through the script with the perl debugger.
05:15 eythian    It's never fun at that level
05:16 dcook      Yeah, I'm trying to trace a Javascript event for adding a DOM node..
05:17 dcook      Looks like I've tracked it down to an anonymous function in jquery 1.10? :S
05:17 dcook      Hmm, I don't think I've got it quite right
05:17 dcook      I think that's the Javascript that is doing the work... but not what started it..
05:43 dcook      Hmm, it's not Javascript...that's why I can't find it.
05:43 dcook      They reload the whole page :S
05:44 dcook      Hmm, but there has to be some JS to prompt the submission..
05:55 cait       bye all
06:15 dcook      Ahhhhh
06:15 dcook      I should've saw it before...
06:16 dcook      No Javascript. Just IE7 treating buttons within an html form differently than every other browser ever.
06:24 indradg    anyone around?
06:25 * indradg  scratching head over http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference
06:26 indradg    did not exactly get "The release manager will be the one that assigns the correct DB version number. <<YOURINSERT>> should match the insert line you provided in installer/data/mysql/sysprefs.sql and <<YOURPREF>>, well, your new preference"
06:26 cait       hi indradg
06:26 indradg    hi cait
06:26 cait       do you need help with adding a system preference?
06:26 indradg    yep
06:27 cait       in updatedatabase you add a new instance and put the version in as XXX
06:27 cait       and you don't submit kohaversion.pl
06:27 * magnuse  waves
06:27 cait       and in sysprefs.sql (which is sorted alphabetically!) you also add the sql from the updatedatabase
06:27 cait       hi magnuse
06:28 indradg    cait: the last syspref insert was from tomas
06:28 indradg    $DBversion = '3.17.00.014';
06:28 indradg    if ( CheckVersion($DBversion) ) {
06:28 indradg    $dbh->do("
06:28 indradg    INSERT INTO systempreferences (variable,value,explanation,type) VALUES
06:28 indradg    ('OverdueNoticeCalendar',0,'Take calendar into consideration when working out sending overdue notices','YesNo')
06:28 indradg    ");
06:28 indradg    print "Upgrade to $DBversion done (Bug 12529 - Adding a syspref to allow the overdue notices to consider the calendar when generating notices)\n";
06:28 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 normal, P5 - low, ---, koha-bugs, Pushed to Master , Overdue notices do not respect holidays
06:28 indradg    SetVersion($DBversion);
06:28 indradg    }
06:28 cait       yes, tomas set the 3.17.00.014
06:28 magnuse    it should be covered here, not sure if it is up to date: http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference
06:28 cait       the patch was submitted with XXX there
06:28 cait       that is for easier testing - if you have XXX you can run the database update without your version number being updated
06:29 cait       it's a little gimmick
06:39 indradg    cait: I'm trying to submit two sysprefs, so does this do the job? http://pastebin.com/Z3CwHW9m
06:40 cait       looking good afaikt :)
06:40 cait       what is jquery ime?
06:40 indradg    yay! thanks a bunch!
06:40 indradg    it is a jquery based input method (editor)
06:41 indradg    Bug 12815
06:41 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12815 enhancement, P3, ---, koha-bugs, NEW , Adding support of jquery.ime to Koha
06:41 indradg    cait: ^
06:42 indradg    it drives Wikipedia's browser based multi-lingual input methods
06:43 indradg    I'm writing the patch to address bug 5621
06:43 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5621 enhancement, PATCH-Sent (DO NOT USE), ---, kohapatch, Failed QA , Google Translation for indian languages.
06:46 reiveune   hello
06:46 wahanui    hello, reiveune
06:47 indradg    hi reiveune
06:48 cait       indradg: cool
06:48 reiveune   hi indradg magnuse cait dcook and everybody
06:48 cait       hi reiveune :)
06:49 cait       indradg: maybe include some explanation about what ime is in the pref description in .pref?
06:49 cait       @later tcohen - just found the photo - such a sad face!
06:49 huginn     cait: I've exhausted my database of quotes
06:49 indradg    cait: i'm listening
06:50 cait       @later tell tcohen - just found the photo - such a sad face!
06:50 huginn     cait: The operation succeeded.
06:50 indradg    I should be a little more verbose?
06:50 cait       the sql is not shown anywhere
06:50 cait       I think maybe in the .pref would be good
06:50 indradg    can do that!
06:53 cait       good morning marcelr :)
06:53 marcelr    hi #koha
06:53 marcelr    and cait
06:53 indradg    hi marcelr
06:54 marcelr    and indradg
06:54 wahanui    well, indradg is the one who told me.
07:20 cait       marcelr: hope the comment made sense ... it's an even bigger mess than i thought
07:20 cait       with the paidfor
07:20 marcelr    too bad
07:20 marcelr    i am still thinking about a dbrev for those fields too
07:21 marcelr    at least a warning?
07:24 indradg    cait: i'm going to file a bug a "sub-classification" in the i18n-l10n.pref YAML file i.e. "Date and Time", "Language Support" sub-sections
07:24 indradg    so I place it under i18n/l10n or System Admin as the component?
07:39 dcook      @later tell tcohen Sorry, been busy with DSpace all day. Still haven't gotten to the facet code yet :(
07:39 huginn     dcook: The operation succeeded.
07:40 dcook      night all
07:40 wahanui    goodnight dcook. You'll be back.
08:06 Joubu      Hello #koha
08:16 marcelr    hi Joubu
08:25 magnuse    bonjour Joubu
08:25 magnuse    @wunder marseille
08:25 huginn     magnuse: The current temperature in Realtor, CABRIES, France is 17.5°C (10:25 AM CEST on August 25, 2014). Conditions: Partly Cloudy. Humidity: 25%. Dew Point: -3.0°C. Pressure: 30.05 in 1018 hPa (Rising).
08:25 magnuse    @wunder boo
08:25 huginn     magnuse: The current temperature in Bodo, Norway is 15.0°C (10:20 AM CEST on August 25, 2014). Conditions: Clear. Humidity: 59%. Dew Point: 7.0°C. Pressure: 29.83 in 1010 hPa (Steady).
08:26 magnuse    not too bad! :-)
08:27 Joubu      @wunder Liverpool, uk
08:27 huginn     Joubu: The current temperature in Liverpool, United Kingdom is 13.0°C (9:20 AM BST on August 25, 2014). Conditions: Light Drizzle. Humidity: 94%. Dew Point: 12.0°C. Pressure: 29.74 in 1007 hPa (Falling).
08:27 Joubu      erk
08:45 indradg    @wunder Kolkata
08:45 huginn     indradg: The current temperature in Kolkata, India is 34.0°C (1:50 PM IST on August 25, 2014). Conditions: Haze. Humidity: 63%. Dew Point: 26.0°C. Pressure: 29.65 in 1004 hPa (Steady).
08:51 magnuse    we set a new heat record this summer in Bodø, with 29.1°C :-)
09:23 indradg    magnuse: thats hot! for you! :)
09:44 magnuse    it sure is
09:44 magnuse    :-)
10:05 quocuy     Hi all
10:09 quocuy     Anyone here?
12:15 dpavlin    can somebody check if keyboard shortcuts are working in current master? For me they seem to select wrong tabs, and looking in the code I have no idea why
12:17 dpavlin    alt+r (checkout does work) but alt+u (checkin) and alt+q (catalouge search) are... all over the place, depending on page
12:18 * dpavlin  suspect local problem, so need confirmation before opening bug
12:24 cait       hi dpavlin :)
12:24 cait       hm can't check on master
12:24 cait       would be 3.16.2 ok?
12:26 dpavlin    I can see that after commit 9fe36e0c705b958859babe565517554b722c66cd (on which our production is on) and on current master, I don't really know about 3.16.2, but it would be nice to know if it works there...
12:27 magnuse    dpavlin: works for me
12:28 magnuse    gitified setup. git says i'm up to date with master, but "about koha" says 3.15.00.052?!?
12:29 dpavlin    for me, even 3.16.x on home pages selects search patrons for q, and search catalogue for u, so local problem, I guess...
12:30 * dpavlin  wonders about aliens and cosmic rays -- I see it both in Firefox and Chrome...
12:31 magnuse    :-)
12:31 * magnuse  wonders why about koha says 3.15 when the value in the syspref table is 3.1700011
12:33 Joubu      dpavlin: here I got: alt+r: checkin, alt+u: checkout, alt+q: search
12:33 Joubu      catalog search
12:33 tcohen     morning!
12:33 wahanui    hmmm... morning is a state of cat
12:33 tcohen     hi Joubu
12:34 tcohen     magnuse: around?
12:34 dpavlin    thanks everyone, I'm going back to my dungeon to figure this out
12:34 Joubu      magnuse: it seems that about.pl displayes the version in kohaversion.pl
12:34 Joubu      Hi tcohen!
12:45 magnuse    sorry, i gotta run (picking up from kindergarten :-)
13:32 datadoctor Good morning. Here at Stow-Munroe Falls Public Library we are looking to update to Koha v3.16.
13:33 datadoctor But we are concerned about print notifications.
13:34 datadoctor So far, I can't find a bug report, but the suggestion is that print notices do not generate properly after the addition of multiple notice per message_transport_type.
13:38 Joubu      datadoctor: there are 2 bug reports
13:38 Joubu      bug 12717
13:38 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 critical, P5 - low, ---, jonathan.druart, Signed Off , Library no longer receiving Overdue email for patrons without email address
13:38 Joubu      and bug 12810
13:38 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12810 normal, P5 - low, ---, koha-bugs, NEW , After MTT gather_print_notices includes overdues
13:39 Joubu      datadoctor: could you detail? When the print notices are not generated properly?
13:41 kivilahtio Have you ever had a cronjob failure? Where no cronjobs run for 3 days?
13:41 Joubu      kivilahtio: all cronjobs??
13:41 kivilahtio Joubu: yes
13:42 Joubu      kivilahtio: nothing in logs?
13:42 kivilahtio I am looking in my logs and see that advance_notices.pl, overdue_notices.pl , fines.pl cancel_expired_holds.pl have not ran
13:43 kivilahtio I created a custom wrapper to log all my cronjobs to their respective log-entries to monitor the runtimes and verbose outputs
13:43 Joubu      and others run?
13:43 kivilahtio have nt really peeked at the syslog
13:43 kivilahtio I am just wondering how is it possible for cronjobs not to run for 3 days
13:43 Joubu      kivilahtio: you should see the job launched in syslog (or daemon) I think
13:43 kivilahtio then just happen to continue running
13:45 kivilahtio too bad syslogs are only for the past 7 days
13:45 kivilahtio this event happened on 15-17.8
13:46 kivilahtio I was also busy with some migration stuff, doing screen scraping to bring a small library to Koha
13:46 kivilahtio based on the enormous amount of errors reports I am getting I prolly should run those scripts that MUST be ran every day now
13:47 kivilahtio too bad most of the koha-scripts dont support other dates than NOW()
13:47 kivilahtio I guess I need to submit patches :)
13:48 kivilahtio anyway just asking if you have had issues with cronjobs not running
13:49 Joubu      kivilahtio: bug 11120 fixed the --date for overdue_notices
13:49 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 normal, P5 - low, ---, jonathan.druart, Needs Signoff , The date option for the overdue_notices cronjob is broken
13:49 Joubu      but the patch does not apply anymore (too bad)
13:49 kivilahtio I had it fixed as well, but somehow didnt have time to submit a patch
13:49 kivilahtio we have some custom modifications regarding holds and they are going awol
13:50 kivilahtio also our trainee working with those things has been pushed to holidays :)
13:50 Joubu      kivilahtio: Did you fix --date for overdue_notices on master?
13:50 kivilahtio I didn't publish a patch for it
13:50 kivilahtio i think i made an internal patch but then forgot about the thing because there was this and that problem
13:51 Joubu      kivilahtio: yes I understood :) But you have a code working?
13:51 kivilahtio yes
13:51 kivilahtio for some old master version we are using
13:51 Joubu      great
13:51 Joubu      ha :)
13:51 Joubu      so bug 11120 did that :)
13:51 kivilahtio we were about to upgrade to 3.16.2 but then "something" hapeneed and that is on ice
13:52 kivilahtio ah yeah schedule pressure about the small library migration
13:52 kivilahtio anyway
14:01 mtompset   Greetings, #koha.
14:02 tcohen     hi
14:14 quocuy     HI all
14:15 quocuy     Is  there anyone here?
14:33 datadoctor Hi quocuy.
15:05 reiveune   bye
16:20 quocuy     Hello all!
16:21 quocuy     I have a question, how i can add some tabs in to "menu-top" div, beside login tab
16:21 quocuy     i'm playing around with kohs as cms, and want create some pages on the top-menu of Koha
16:27 quocuy     hi
16:27 jcamins    jquery library?
16:27 wahanui    jquery library is found at http://wiki.koha-community.org/wiki/JQuery_Library
16:27 jcamins    quocuy: ^^ you might find some examples there
16:28 quocuy     here is one
16:28 quocuy     http://koha.vn/
16:28 jcamins    I'm not sure, but it seems worth a try.
16:28 jcamins    I mean examples of how to do it.
16:28 jcamins    Not example catalogs.
16:28 quocuy     just want to create top menu like that, i created some pages with koha as CMS, now i want to add them to top menu
16:30 quocuy     Jcamins: Thanks, doing some search
16:34 quocuy     didn't find anything :(
16:57 nengard    anyone know why this :   $("option[value='LANSING']").hide();    would work in firefox but not chrome?
17:39 mtompset   datadoctor: you missed quocuy by 18 minutes. ;)
17:39 mtompset   Oops... was scrolled up. :)
17:40 mtompset   Anyone familiar with converting SQL into DBIx stuffs?
17:40 cait       khall? :)
17:40 cait       but apart from t hat, maybe look at some of yohann's patches?
17:40 * mtompset cringes.
17:40 cait       hm?
17:41 mtompset   No, please no more abstractions!
17:41 mtompset   :)
17:41 cait       sorry long day, you got me confused
17:42 jcamins    I agree. More bit twiddling is what Koha needs!
17:42 mtompset   I looked at one of yohann's patches and my brain melted, because of the layers of abstractions.
17:42 cait       jcamins: you ar enot helping
17:43 cait       mtompset: i didn't mean thte test builder
17:43 cait       i think that's what you meant?
17:43 * mtompset laughs.
17:43 mtompset   Yes, that's the scariness.
17:43 * cait     goes to sit in a corner and be quiet now
17:46 mtompset   It's okay. I do appreciate the suggestion, cait. Can you point me at a non-test-builder patch?
17:46 jcamins    grep the codebase for DBIx stuff?
17:47 tcohen     whatsup?
17:49 cait       hmalso that
17:49 cait       tcohen: mtompset is looking for patches converting sql to dbix
17:49 mtompset   As tcohen is aware, the GetNewsToDisplay function is currently running an SQL query directly against dbi.
17:49 mtompset   As per tcohen's suggestion, I was thinking of refactoring that one function to be DBIx.
17:50 mtompset   The problem is timestamp and date manipulations.
17:50 mtompset   In the where clause there has been four versions of an ugly date constraint.
17:50 mtompset   DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY)
17:50 mtompset   CAST( opac_news.timestamp AS DATE ) <= CURRENT_DATE
17:50 mtompset   `timestamp` < CURRENT_DATE()+1
17:50 mtompset   `timestamp` <= CURRENT_DATE()
17:51 mtompset   (in no particular order)
17:51 mtompset   How do I do those as a DBIx where?
17:51 mtompset   the last two, I think I might be able to manage.
17:51 mtompset   The first two look harder, because they contain functions on the left side.
17:52 mtompset   and perhaps there is a DBIx way of doing it.
17:53 tcohen     we need khall
17:53 khall      what's up?
17:54 mtompset   Is there a nice DBIx way of doing a timestamp to date truncation and comparison to another date? ;)
17:55 mtompset   By the way, it was bug 12507 which conflicted with 12167, tcohen.
17:55 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 normal, P5 - low, ---, kyle, Pushed to Master , News does not always display in staff or OPAC
17:55 khall      well, with the right configuration DBIx::Class can automatically turn the timestamps in the db into DateTime objects
17:55 khall      don't think that helps here though
17:56 mtompset   No, I don't think so, because this is about building a WHERE clause. :)
17:56 khall      yep, however, you can also call mysql functions from dbic
17:57 mtompset   take either of the first two examples from about 6 minutes ago, and demonstrate?
17:58 cait       khall: i am starting to feel a little bit worried - everytime i say your name you don't make a sound... but whenever soeone else does you show up :)
17:58 khall      lol, must've been lost in thought ; )
17:59 mtompset   http://youtu.be/HDi7qOhECW8 -- You've lost that lovin' feelin'. :)
18:01 khall      mtompset: we can calculate tomorrow using a DateTime object, and pass that in
18:03 mtompset   example?
18:03 wahanui    it has been said that example is probably a status change
18:03 khall      mtompset: working on it
18:07 cait       mtompset: not available here in germany - your link :(
18:08 mtompset   Sorry cait.
18:14 cait       mtompset: it's ok :)
18:14 cait       i think i need to have dinner, then everything will be better :)
18:14 mtompset   you at least know the song I was referencing. :)
18:20 indradg    good evening #koha
18:22 indradg    i have a question. Suppose I wish to add something like doc-head-close.inc that gets added to every template file under intranet-tmpl, what would be the easiest way to go about it?
18:23 indradg    in my case, i planning to add two lines of code in each of the the .pl files that load up a .tt
18:23 jcamins    indradg: first question?
18:23 wahanui    "What are you trying to do?" or "What is the goal?"
18:25 indradg    jcamins: trying to add an if statement in *all* the perl scripts that load a .tt template referencing a [% INCLUDE doc-head-close.in %]
18:25 jcamins    indradg: right, but why are you trying to do that?
18:26 indradg    so that i can pass a template param - a syspref condition
18:26 indradg    if syspref then do this
18:26 jcamins    My initial response is that this is a horrible idea, because you're making an identical change in dozens of files.
18:26 jcamins    But I'm not sure what your actual goal is.
18:26 indradg    yes... which is why I stopped and asked
18:27 indradg    jcamins: the objective is bug 12815
18:27 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12815 enhancement, P3, ---, koha-bugs, NEW , Adding browser based multi-lingual jquery.ime input method support to Koha
18:27 jcamins    So why do you need to change the Perl files?
18:28 indradg    http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31130
18:28 jcamins    My initial response is that you could just stick your new code in doc-head-close.
18:29 indradg    I have those two new sysprefs working
18:29 tcohen     indradg: Koha.Preference('SysPref') on the template
18:29 indradg    aaaaaaaargh!
18:29 tcohen     :=D
18:29 * indradg  in a major facepalm moment!
18:29 indradg    :-P
18:30 indradg    thanks jcamins, tcohen
18:30 jcamins    Yeah, I agree with tcohen.
18:30 mtompset   tcohen++ # Koha.Preference('SysPref') for the win
18:30 tcohen     you need to [%- USE Koha -%] first
18:30 mtompset   The -'s prevent accidentally adding spacing. :)
18:31 tcohen     amen
18:31 indradg    tcohen: I got it know... some how the idea of adding an IF to dozens of .pl files looked like something way obscene
18:31 indradg    s/know/now
18:31 * tcohen   in blasfemous mode, sorry for that
18:31 tcohen     indradg: :-D
18:32 khall      mtompset: something like:
18:32 khall      my $dt       = DateTime->now()->subtract(days => 1);
18:32 khall      my $parser   = $schema->storage->datetime_parser;
18:32 khall      my @results = $schema->resultset('OpacNews')->search(
18:32 khall      {
18:32 khall      -and => ]
18:32 khall      -or => [
18:32 mtompset   Sorry, but Amen is totally applicable and NOT blasphemous. You weren't calling Koha.Preference() a deity. ;)
18:32 khall      lang => '',
18:32 khall      lang => $lang,
18:32 khall      ],
18:32 khall      -or => [
18:32 khall      branchcode => undef,
18:32 khall      branchcode => $branch
18:32 khall      ],
18:32 khall      -or => [
18:32 khall      expirationdate => \'>= CURRENT_DATE()',
18:32 khall      expirationdate => undef,
18:32 khall      expirationdate => '00-00-0000'
18:32 khall      ],
18:32 khall      \[ 'DATE(timestamp) < ?', $parser->format_datetime($dt) ]
18:32 khall      ],
18:32 tcohen     indradg: that's what khall thought when writing that Template plugin
18:32 khall      },
18:32 khall      {
18:32 khall      order_by => [ 'number' ],
18:32 khall      }
18:32 khall      );
18:33 mtompset   khall, a paste.koha-community.org would have been better. :P
18:33 khall      http://paste.koha-community.org/170
18:34 mtompset   got the wrong square bracket at the top, but I had something similar.
18:34 khall      no guarantees I got it right, not tested ; )
18:35 mtompset   Thanks for the example of passing a parameter.
18:35 khall      yeah, it's better to avoid that when possible, but sometimes we must
18:41 mtompset   khall: Can I ask about an amendment to that?
18:41 mtompset   You grab the date at the top.
18:41 mtompset   But then get DBIx to doa CURRENT_DATE()
18:42 mtompset   could that line be changed to something like the parameter part below?
18:48 khall      mtompset: we could just use another DateTime object for the current date, that would simplify things a bit
18:55 indradg    just one quick question: does encountering more than one [% USE Koha %] directive via the .inc files create any performance / memory impact?
18:55 indradg    jcamins, tcohen
18:55 tcohen     i'm not sure indradg
18:56 tcohen     it is probably on one of the global headers anyway
18:56 tcohen     bye!
18:59 jcamins    indradg: I think [% USE %] is file-scoped, but I'm not sure.
19:02 indradg    based on what you guys told me, this is what I'm planning to do -> INCLUDE directive in doc-head-close.inc pointing to xyz.css.inc xyz.js.inc; inside these latter .inc file using [% USE Koha %]  to check for Koha.Preference('syspref')
19:02 mtompset   khall: Okay, I think I have something, but I'm having difficulty.
19:02 indradg    jcamins ^
19:03 indradg    that looks minimally invasive and keeping things clean. but was worrying over the two USE Koha calls
19:03 * indradg  knows zilch about these things so far
19:04 pastebot   "mtompset" at 127.0.0.1 pasted "My ugly test code." (48 lines) at http://paste.koha-community.org/171
19:05 cait       indradg: what else goes into the inc?
19:05 cait       and i think you migh tnot need to add use koha - maybe check if it's there before, it only has to be on a page once
19:06 indradg    cait: basically if syspref ON, then include the CSS and JS *and* jquery document.ready hook
19:07 cait       hm ok:)
19:13 indradg    cait: only 15 .tt files include the [% USE Koha %] declaration so far - http://pastebin.com/yeWDAz0Q
19:17 cait       ah
19:17 cait       i thnk the boostrap opac has a few more
19:17 cait       those seem all to be intranet?
20:55 mtompset   Well, this is lousy! I am positive I have good DBIx, but the SQL generated is bad.
20:55 mtompset   Where is my where clause?!
21:41 eythian    coffee is <reply>http://www.workbuffer.org/presentations/pizza/images/coffee.jpg
21:41 eythian    wahanui: coffee is <reply>http://www.workbuffer.org/presentations/pizza/images/coffee.jpg
21:41 wahanui    ...but coffee is mostly not Brooke's medicine...
21:41 eythian    no wahanui, coffee is <reply>http://www.workbuffer.org/presentations/pizza/images/coffee.jpg
21:41 wahanui    okay, eythian.
21:44 cait       tsk and no contribution?
21:45 * cait     thinks her photo is art :P
21:47 indradg    hi.. /me is back again :-)
21:47 cait       hi indradg
21:47 cait       i guess i need to go to sleep - good night #koha :)
21:48 indradg    is I have to place a commonly accessed .js library for the OPAC, should I place it in [% interface %]/[% theme %] or simply under [% interface %] ?
21:49 indradg    the former would of course restrict it to the specified opac theme... but are there any other gotchas to be aware of?
21:49 eythian    different themes may require different versions?
21:49 eythian    there's already a lib/ directory for that kind of stuff
21:50 eythian    note that unless it's a thing for upstreaming, we've found it generally better to put it external to koha entirely.
21:50 indradg    eythian: "external to koha entirely"?
21:50 eythian    not in the koha file tree
21:51 indradg    ok
21:51 eythian    that way you keep your koha as close to stock as you can, which is a good thing.
21:53 indradg    eythian: what I'm doing at the moment is a replacement for GoogleTransliteration syspref that used to dot the templates, but has since been removed as the submitted patch failed QA - bug 5621
21:53 huginn     04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5621 enhancement, PATCH-Sent (DO NOT USE), ---, kohapatch, Failed QA , Google Translation for indian languages.
21:54 eythian    ah k
21:55 indradg    the proposed patch calls for a mini-fied https://github.com/wikimedia/jquery.ime library
21:55 indradg    eythian ^
21:56 eythian    OK. In that case, I'd probably put it whereever the other libs go.
21:56 indradg    so [%interface%]/libs
21:57 indradg    :) eythian++
21:57 eythian    sounds good :)
22:00 indradg    @wunder kolkata
22:00 huginn     indradg: The current temperature in Kolkata, India is 28.0°C (3:20 AM IST on August 26, 2014). Conditions: Haze. Humidity: 89%. Dew Point: 26.0°C. Pressure: 29.65 in 1004 hPa (Steady).
22:00 eythian    @wunder nzwn
22:00 huginn     eythian: The current temperature in Wellington, New Zealand is 7.0°C (9:30 AM NZST on August 26, 2014). Conditions: Light Rain Showers. Humidity: 93%. Dew Point: 6.0°C. Windchill: 6.0°C. Pressure: 30.48 in 1032 hPa (Falling).
22:00 eythian    hmm. meet in the middle?
22:01 indradg    insane! its 3:30 am here :)
22:02 eythian    oh those oddball half-hour timezones
22:18 bag        @wunder 93102
22:18 huginn     bag: The current temperature in Westside (Gillespie), Santa Barbara, California is 22.4°C (3:18 PM PDT on August 25, 2014). Conditions: Clear. Humidity: 60%. Dew Point: 14.0°C. Pressure: 29.92 in 1013 hPa (Falling).  High surf advisory in effect from 6 PM Tuesday to 3 am PDT Thursday...
22:19 wizzyrea   hm do you have weather rolling in bag?
22:19 bag        @more
22:19 huginn     bag: Error: You haven't asked me a command; perhaps you want to see someone else's more.  To do so, call this command with that person's nick.
22:20 bag        wizzyrea: nope just partly cloudly for the rest of the week
22:20 bag        but high surf that sounds fun
22:29 wizzyrea   here that usually means there's some kind of weather system coming.
23:29 tcohen     hi
23:30 dpk        Hello.  I have been building and installing Koha from source since 3.4 or so and an thinking about moving over to the koha-common Debian packages.  One thing we have found very useful is to test new *major* releases before we move to that track, and we have found some bugs that caused us to move after a .1 or .2 release.  How do you suggest I do this in the future?  Keep using a built from source for "beta testing"?  Who controls
23:31 tcohen     dpk: why would you still build from sources?
23:32 tcohen     packages is a way of deploying Koha in your infrastructure
23:32 tcohen     we usually build our own packages for deploy
23:33 tcohen     with the branch we're using + some patches that are not yet included
23:33 tcohen     but there's usually no hurry and we might have installed stock packages
23:33 tcohen     if we convinced the release maintainer to include some tiny patches ;)
23:34 eythian    that release maintainer is a terrible person.
23:35 tcohen     heh
23:35 * dcook    notices offhand that a remarkable percentage of Koha is actually made up of fractions of percents.
23:35 eythian    I don't know what that means.
23:35 tcohen     tautology?
23:36 eythian    could be
23:36 dcook      According to the GitStats, the top 10 committers are responsible for...
23:36 dcook      53.67% of Koha
23:36 tcohen     gitstats?
23:37 dpk        I am very familiar with packages and their advantages.  (I am a long time Unix/Linux SA and SW developer)  We have found that occasionally the major release have bugs that prevent us moving over on the .0 release.  Sometimes we need to wait a minor release or 2, to move from one major release to another.  Elaine Bradtke, the librarian half of this team, has found several and that is in part because we are a research library (efds
23:37 dcook      The remaining 46.33% is made up of contributions that are no larger than 1% of the total of Koha
23:37 dcook      Oh, I lie
23:37 dcook      After the top 20, it gets down to under 1% of the total contributions
23:37 dcook      tcohen: http://git.koha-community.org/stats/koha-master/authors.html
23:38 rangi      dpk: yep, im not sure what that has to do with the packages tho?
23:38 rangi      you can wait for a .x package if you want
23:38 eythian    dpk: you can have a few different degrees of control over what version you're running quite happily
23:39 eythian    dpk: from making your own, to tracking the current releases, to tracking the older releases, or just not upgrading for a few months on a new release.
23:39 dpk        The packages are updated periodically.  Is there an easy way to stop apt-get update/upgrade from upgrading koha-common unless I want it to?  (even though a new package is available?)
23:40 eythian    sure
23:41 tcohen     dpk, you can put it on hold
23:41 eythian    yeah, that
23:41 wahanui    somebody said yeah, that was cool - a way to enhance the OPAC without bloating Koha...
23:41 eythian    we do that for things
23:41 eythian    you can manually override it quite happily, but if you don't, it won't autoupgrade
23:41 rangi      pin
23:42 tcohen     dpk: for example echo "koha-common hold" | dpkg --set-selections
23:42 dpk        OK.  got it.
23:42 eythian    tcohen: that's not the best way
23:42 tcohen     the only way you'd upgrade Koha is by doing it explicitly
23:43 pastebot   "eythian" at 127.0.0.1 pasted "pinning packages" (4 lines) at http://paste.koha-community.org/172
23:43 dpk        Then I can set up a test system (on a separate machine) to test the new version and unhold when I am happy to move forward.
23:43 tcohen     eythian: that was my first googlesearch result
23:43 eythian    that's how I do it, and it means that you can do "apt-get install koha-common=3.16.01" whenever you want.
23:43 eythian    otherwise nothing will get upgraded
23:43 eythian    (well, by nothing, I mean that koha-common won't get upgraded)
23:44 dpk        Sounds good.