IRC Logs

Time Nick Message
23:23 dcook hey ya mtompset
23:23 mtompset Greetings, dcook.
23:20 dcook morning #koha
22:36 mtompset Greetings, eythian.
22:34 wahanui bidet, eythian
22:34 eythian hi
22:34 mtompset Though I don't think a consensus was reached... wasn't there a discussion on the channel about OO classing styles, and moose friendly was positively considered, so as to be portable across various frameworks that exist for doing OO in Perl.
22:22 pianohacker very cool
22:22 libsysguy a lot of that comes from the Types
22:21 libsysguy seems like 66% of moose about about 33% of the costs
22:21 libsysguy yeah, I went to a talk mst gave about it
22:21 pianohacker Moo seems nice though, like Moose without the lumbering size and deathly slowness
22:21 libsysguy heh
22:21 pianohacker among other sins
22:20 libsysguy the existing code, If I recall was doing manual date calculations before sekjal and I got ahold of it
22:20 libsysguy that code could benefit tremendously from moo
22:19 pianohacker the existing code being... a bit of a mess
22:19 pianohacker One thing I never checked was what you did with the admin interface
22:19 pianohacker Oh, haha, no worries. Thanks for leaving your code up, it was helpful
22:19 libsysguy I started that when I was more naive about Kohaâ€¦and ambitious
22:19 libsysguy I apologize in advance
22:19 libsysguy I didn't know if I could delete my branches on github
22:19 pianohacker yes...
22:18 pianohacker <shiver>
22:18 libsysguy pianohacker were you the one taking over the calendar code?
22:18 pianohacker haha
22:18 trea gratz buddy
22:17 libsysguy I finally figured out how to not autojoin #bywaterâ€¦silly nickserv
22:17 wahanui I HATE XML
22:17 libsysguy hey pianohacker
22:17 wahanui libsysguy is, like, missing us again.. :)
22:17 pianohacker hey libsysguy
22:15 mtompset Ah there... wiki pages.
22:09 mtompset Looks like magnuse is the goto person to bug about this. ;)
22:05 mtompset I guess if I submit the patch, I should attempt from earlier and clean up more. What version should I jump back from?
22:05 * mtompset grins, "Nice. I just patched the upgrade process from 3.8.6 to dev to be more smooth."
21:58 mtompset Greetings again, cait. :)
21:48 pianohacker I believe so mtompset
21:44 mtompset Or is this like kohastructure.sql and updatedatabase.pl, where the kohastructure.sql is called on a fresh install, so it may need to be in both places?
21:43 mtompset You shouldn't insert the same thing in both places, correct?
21:43 mtompset but so is updatedatabase.pl, right?
21:43 wahanui i guess installer is for updating too.
21:43 cait installer
21:41 mtompset Hmmm... when is sysprefs.sql called?
21:11 mtompset I hope that wasn't NSA punishing tcohen for his views. ;)
21:09 tcohen i guess at the US there will be people that favours medicare, and people that blames it
21:08 tcohen there's also priorities, ideology
21:07 tcohen corruption is not the only issue
21:07 mtompset Sadly, corruption knows no geographical boundary.
21:01 tcohen sometimes they are used to fix monetary fluctuations too
21:01 tcohen oh, that's for sure mtompset
21:00 mtompset taxes are only good, if they are spent on what we expect them to be spent on (education, infrastructure, etc.)
21:00 pianohacker :)
20:59 tcohen s/tac/tax/
20:58 pianohacker tacos? I love tacos
20:57 * tcohen thinks taces are good
20:57 mtompset New topic: http://youtu.be/YxlXn97rZMY (awesome pringles commercial)
20:54 mtompset World Wars kind of are at fault for it. :)
20:54 mtompset druthb: Taxes are certainly something which sucks in general.
20:54 mtompset So, I assume (not confirmed) WBT US can sort of work the same. :)
20:54 mtompset I mean $25/year.
20:53 mtompset I have had donors give ~$3.00/month in the past and because they gave more than $25/month WBTC issued a receipt. You can donate to WBT US for my project. ;)
20:52 pianohacker Heh. Probably not, mtompset
20:52 mtompset Just pointing out there are ways to help me stay in the Koha community. ;)
20:51 mtompset I know that money is tight for students, but do you think you'd miss $0.10/day (~$3/month)? ;)
20:51 druthb You have to make a pretty significant amount of donation and other deductible things before you overcome the standard I-am-a-person deduction.
20:50 druthb mtompset: yes, a tax credit is available for charitable donations in the US.
20:48 pianohacker uhhh, I think so, though I'm not sure of the exact legal requirements. Why do you ask?
20:48 mtompset Does the US give a tax credit for charitable donations?
20:47 pianohacker United States. Colorado specifically. I'm a college student working for ByWater over the summer
20:47 mtompset (I try not to assume, since frequently I could be wrong)
20:46 mtompset What country are you in again, pianohacker?
20:46 pianohacker heh, gotcha
20:45 mtompset [off] I say this with [off], because WBT and SIL in the same sentence is a PR no-no. Due to high security country issues ... kind of related to the questions I was asking earlier.
20:45 pianohacker very cool.
20:44 mtompset [off] I work with Wycliffe Bible Translators of Canada. I was seconded to SIL Asia Area while I was working the Philippines, and am currently on remote assignment to SIL Asia Area continuing the Koha work that I helped start.
20:43 pianohacker where do you work for, out of curiosity?
20:43 mtompset That is the down side of working for a charitable organization. :(
20:43 pianohacker 'tis the minor detail of money :P
20:42 mtompset If someone will pay for the flight and the stay and the meals, I'll come, but until then... I can't come.
20:42 pianohacker aww
20:42 mtompset No.
20:42 pianohacker are you coming to KohaCon? That would be entertaining to see in person
20:41 mtompset Nah, I like to say everything all at once and just keep rambling until I pass out from lack of oxygen, pianohacker. :P
20:41 pianohacker hello world
20:41 wizzyrea hi everybody
20:41 pianohacker take a breath there pardner
20:41 kathryn morrrrning :) cait mtompset and all
20:41 mtompset Greetings kathryn
20:40 mtompset Greetings, magnuse jcamins wizzyrea pianohacker tcohen cait.
20:40 cait good morning kathryn ;)
20:40 mtompset Wow... picking up in the afternoon, it would seem. :)
20:39 huginn tcohen: The current temperature in Cordoba, Argentina is 24.0Â°C (5:00 PM ART on June 27, 2013). Conditions: Clear. Humidity: 19%. Dew Point: -1.0Â°C. Pressure: 29.74 in 1007 hPa (Falling).
20:39 tcohen @wunder cordoba, argentina
20:35 wizzyrea oy that's warm
20:30 jcamins Of course, when we really needed the fan was yesterday.
20:30 huginn jcamins: The current temperature in Glendale, Glendale, New York is 26.3Â°C (4:13 PM EDT on June 27, 2013). Conditions: Mostly Cloudy. Humidity: 77%. Dew Point: 22.0Â°C. Pressure: 29.72 in 1006 hPa (Falling). Flash Flood Watch in effect through Friday afternoon...
20:30 jcamins @wunder 11375
20:27 pianohacker amen to that, I just got one too jcamins
20:26 jcamins Well, any floor fan is a huge improvement.
20:26 jcamins We got an oscillating fan!
20:26 magnuse w00t!
20:26 huginn magnuse: The current temperature in Bodo, Norway is 18.0Â°C (10:20 PM CEST on June 27, 2013). Conditions: Clear. Humidity: 64%. Dew Point: 11.0Â°C. Pressure: 30.04 in 1017 hPa (Steady).
20:26 magnuse @wunder boo
20:24 cait bye oleonard
20:24 pianohacker bye oleonard
20:24 oleonard Ah well, more tomorrow. Bye #koha.
20:24 huginn pianohacker: The current temperature in Lookout Pointe, Golden, Colorado is 33.3Â°C (2:24 PM MDT on June 27, 2013). Conditions: Partly Cloudy. Humidity: 17%. Dew Point: 5.0Â°C. Pressure: 30.28 in 1025 hPa (Falling).
20:24 pianohacker @wunder 80401
20:24 * pianohacker is jealous
20:23 cait chilly :(
20:23 huginn cait: The current temperature in Konstanz, Germany is 11.0Â°C (10:00 PM CEST on June 27, 2013). Conditions: Rain. Humidity: 89%. Dew Point: 10.0Â°C. Pressure: 30.24 in 1024 hPa (Rising).
20:23 cait @wunder Konstanz
20:23 huginn cait: The current temperature in Frankfurt / M-Flughafen, Germany is 13.0Â°C (10:00 PM CEST on June 27, 2013). Conditions: Partly Cloudy. Humidity: 85%. Dew Point: 11.0Â°C. Pressure: 30.22 in 1023 hPa (Rising).
20:23 cait @wunder frankfurt
20:15 oleonard FWIW, here's the problem with the fixFloat plugin's behavior: http://screencast.com/t/ebbxwVBe
20:07 * oleonard grumbles
20:07 oleonard And if the clever folks at Twitter haven't figured this one out...
20:05 jcamins Oh. :(
20:05 oleonard Static works, but that doesn't help in this case.
20:04 jcamins Does static work?
20:04 oleonard That stinks. :(
20:04 oleonard "Fixed on mobile isn't consistently possible, nor does it behave wellâ€”not even on iOS5. You're free to override that if you wish, but we won't be re-enabling until support is improved."
20:02 oleonard Weird.
20:02 oleonard Oh... the fixed navbar is disabled by default for smaller viewports
19:59 pianohacker *sinatra
19:59 pianohacker Express seems nice though, if it has much in common with sinatara
19:59 pianohacker bleh, yeah. My old job was ancient PHP interfacing with ancient Java, reading data files written by Fortran. Perl is puppies, kittens and daisies in comparison
19:58 jcamins Express.
19:58 pianohacker very cool. What web framework are you using?
19:58 jcamins PHP was PHP once too often.
19:58 jcamins Biblionarrator.
19:58 pianohacker nice! What are you writing in node?
19:57 jcamins pianohacker: I'm switching to node. Hence the unit tests in JS.
19:57 pianohacker oh! okay then. Lemme put away the anti-pedantry wiffle bat and get out the PHP self-flagellation device
19:57 jcamins Sorry.
19:56 jcamins Actually, I meant navbar-static-top.
19:55 jcamins For code written in PHP.
19:55 jcamins In Javascript.
19:55 * oleonard can't get the fixed navbar to work for some reason
19:55 * jcamins has been writing unit tests.
19:55 jcamins Let me find it.
19:55 jcamins oleonard: sorry, yes.
19:55 oleonard jcamins: Do you mean the fixed navbar? Or something else?
19:51 cait back
19:50 mtompset oleonard: Well, even if you bite my head off sometimes, we still love you here. :) Not all days are sucky. :)
19:48 cait ew :)
19:48 cait .. booting into windows
19:48 cait brb
19:48 oleonard Which one is that? The fixed navbar?
19:47 jcamins oleonard: you may have already tried this, but what about the Bootstrap control that does the same? Is that easier?
19:46 cait oleonard: bad plugin
19:44 oleonard My attempts to refine it were not successful.
19:44 druthb oleonardsnack cookie
19:44 oleonard I was hoping to use the fixFloat plugin for the search results controls in the OPAC but for some reason it doesn't work there as well as it does in the cataloging interface
19:43 wahanui Cookies are delicious delicacies
19:43 cait cookies?
19:43 cait oh :(
19:43 oleonard This day has involved a lot of me banging my head against the wall...
19:36 * cait waves
19:36 jcamins pianohacker_sustenance: thanks!
19:24 pianohacker jcamins: btw, asked on fb, and from what I can tell, no CO barcode prefix registry
19:20 * oleonard slaps some lipstick on this pig and calls it done
19:20 oleonard Well congratulations Koha, the bar has been set very low!
19:18 jcamins Queens Library does not.
19:18 jenkins_koha Project Koha_master build #1273: STILL UNSTABLE in 1 hr 17 min: http://jenkins.koha-community.org/job/Koha_master/1273/
19:17 jcamins NYPL does not.
19:14 oleonard All I seem to find are III OPACs
19:12 mtompset That, I do not know.
19:09 oleonard ^ no judgement required
19:09 oleonard What libraries have a mobile OPAC?
19:09 mtompset I thought that would have been obvious with my comment about the possibility of ignoring my ideas that I spewed.
19:08 * pianohacker gets out the anti-pedantry wiffle bat
19:07 mtompset No, it is an admission of my limitations, not a claim to being above it.
19:07 oleonard mtompset: You say that as if you would not express an opinion because of that subjectivity
18:59 wahanui somebody said Good was the furthest you go back, bad is the furthest you go forward (if those directions make sense)
18:59 mtompset Good?
18:59 wahanui good is the furthest you go back, bad is the furthest you go forward (if those directions make sense)
18:59 mtompset good?
18:59 mtompset Good is a subjective term based on the user.
18:53 oleonard Oh I see they have a "beta version" that you have to explicitly choose
18:51 oleonard I would have expected WorldCat at least to have attempted a mobile version
18:47 oleonard Does *any* ILS have a good mobile OPAC?
18:43 mtompset because when i use smaller screens, I hate scrolling. But if I want functionality, I hate having to switch screen and click different things to get it.
18:42 mtompset Feel free to ignore the ideas if they are crazy. :)
18:42 mtompset Similarly the 'place hold', etc. could be squeezed up into a 'expand for more options'?
18:40 mtompset How about a tiny button that expands to show the bar, but otherwise is squeezed up just before highlight?
18:38 oleonard I wish I new of similar mobile interfaces where someone had come up with solutions for these types of controls (good or bad solutions)
18:37 mtompset Isn't it always?
18:37 oleonard Too bad... It would be so much easier to just hide it all ;)
18:36 mtompset ^badf^bad^
18:35 mtompset Plus, there is vertical scroll, so it isn't too badf.
18:35 mtompset I agree with you. It would be nice to actually keep the functionality while using a smaller screen.
18:35 oleonard I tend to believe that we shouldn't hide functionality just because it's a smaller screen, but I thought I'd get more opinions
18:34 oleonard The question is: Is it worth it to try to adapt those controls to a smaller viewport, or can we follow the assumption made by the CCSR template that mobile users don't care about that stuff?
18:33 mtompset The save button seems big to me.
18:32 mtompset DUH... I see it now.
18:32 oleonard I'm not talking about the dropdowns at the top at all.
18:32 mtompset makes sense.
18:32 oleonard (meaning "place hold," "add tag," etc.)
18:31 oleonard mtompset: Those controls are vertical because if they were horizontal they would either not fit or re-flow badly, not to mention being hard to tap on a small device.
18:31 mtompset I mean second drop down from the top in that main search area?
18:30 mtompset You mean the third drop down?
18:30 mtompset Hmm... I was wondering if the 'Place Hold' 'Add tag' etc. could be horizontal, so as to save vertical space, and make more of the second entry visible?
18:28 oleonard And "unhighlight" and sorting controls too for that matter.
18:28 oleonard mtompset: No, I mean the "select titles to..." controls you can see in that screenshot right above the first search result
18:27 chris_n oleonard: making brownies by chance?
18:26 mtompset you mean the filters and stuff on the left, oleonard?
18:26 mtompset oleonard: All you had to do was say my name (flashback: http://youtu.be/sQgd6MccwZc).
18:25 pianohacker oleonard: seems like it would make sense to make the buttons in the table smaller/only appear on click, but aside from that, it looks good
18:24 * pianohacker wakes up
18:19 * oleonard bangs some pots and pans in the kitchen
18:19 oleonard Sorry, did that come out too loud?
18:19 oleonard I'll ask again when you're not ALL SLEEPING
18:17 oleonard I haven't edited anything out yet, wondering what should be on the table: http://screencast.com/t/motJsRcbFJ
18:15 oleonard I wonder if anyone misses the search results tools which are hidden in the CCSR mobile view (selecting results and performing bulk actions)
18:01 jenkins_koha Starting build #1273 for job Koha_master (previous build: UNSTABLE -- last SUCCESS #1271 2 hr 34 min ago)
18:00 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 trivial, P5 - low, ---, m.de.rooy, Pushed to Master , General staff client typo omnibus
18:00 jenkins_koha Marcel de Rooy: Bug 7368: Followup for columns names in userflags.sql
18:00 jenkins_koha Project Koha_master build #1272: UNSTABLE in 1 hr 14 min: http://jenkins.koha-community.org/job/Koha_master/1272/
17:45 tcohen slash = /
17:45 tcohen backslash = \
17:44 mtompset which slash is which? Is '/' forward or backward? Is '\' backward or forward?
17:36 tcohen i mean, branch
17:36 tcohen i'll do it with our university's fork anyway
17:36 tcohen i want to play with pockets
17:34 tcohen ooooooooh
17:34 druthb only until October, tcohen.
17:34 mtompset Why? Is not the squeeze repo 3.12?
17:34 tcohen i assigned the bug to myself now, but have half of planet earth as shield from druthb's attack
17:33 mtompset There just happens to be an attachment on the bug put up by him. :P
17:33 * tcohen wants to create a koha-3.12 repo on koha's ppa
17:32 mtompset druthb: tcohen's patch is assigned, just not to him explicitly. :P
17:31 mtompset Mad, indeed.
17:30 pianohacker nothing can stop her!
17:30 pianohacker she's a madwoman with rubber-band guns
17:29 mtompset It's for the greater good of Koha. :P
17:28 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 enhancement, P5 - low, ---, gmcharlt, NEW , Do we need a sequential number generator?
17:28 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 enhancement, P5 - low, ---, nunyo, Needs Signoff , Make it possible to force 001 = biblionumber
17:28 mtompset Hey, nothing wrong with patch pimping... My patch could help with bug 9921 and bug 10478. :P
17:28 tcohen bug 8773 :-P
17:27 * druthb takes aim at tcohen, but misses, since his patch is unassigned.
17:27 * tcohen hides
17:27 tcohen oops
17:27 * druthb zaps mtompset and pianohacker.
17:26 * druthb gets out her double-barrel rubberband guns.
17:25 pianohacker wtf assignee
17:23 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add per-instance koha-index-daemon in .deb setup
17:23 tcohen bug 8773
17:23 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 enhancement, P5 - low, ---, jweaver, Signed Off , Allow external Z39.50 targets to be searched from the OPAC
17:23 pianohacker bug 10486
17:23 pianohacker wait, it's patch pimping time?
17:22 tcohen both druthb!
17:20 druthb hm. Patch-pimping. Should it be an offense punishable by the pointy stick, or an offense punishable by the rubberband gun?
17:16 * tcohen feels demakers empathy as he wakes just in time
17:15 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 major, P5 - low, ---, mtompset, Needs Signoff , Duplicate card numbers may be generated
17:15 mtompset tcohen: If you are waiting, does that mean you could look at bug 10454? ;)
17:10 tcohen heh
17:10 * tcohen is waiting for debmaker.unc to wake up
17:08 druthb tcohen++
17:08 tcohen we've had a massive power outage
17:07 tcohen translate.k-c.org is back!
16:59 mtompset DOH! serves me right for answering before reading the entire scroll back.
16:58 mtompset Sorry, tcohen. No dput experience. I have yet to set up a local repo, which would be a nice, next learning curve to leap.
16:45 jenkins_koha Starting build #1272 for job Koha_master (previous build: SUCCESS)
16:44 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 normal, P5 - low, ---, jonathan.druart, Pushed to Master , UT: HoldsQueue.t needs to create its own data
16:44 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495 minor, P5 - low, ---, gmcharlt, Pushed to Master , t/db_dependent/HoldsQueue.t can fail unnecessarily
16:44 jenkins_koha * Jonathan Druart: Bug 10336: HoldsQueue.t needs to create its own data
16:44 jenkins_koha * Galen Charlton: bug 10495: set precondition for HoldsQueue test
16:44 jenkins_koha Project Koha_master build #1271: SUCCESS in 1 hr 17 min: http://jenkins.koha-community.org/job/Koha_master/1271/
16:39 tcohen oh
16:38 jcamins tcohen: just copy it into incoming.
16:38 tcohen bye cait!
16:36 tcohen how do I push the resulting .deb?
16:36 tcohen suppose I do cpan2deb Koha::Contrib::Tamil
16:36 tcohen thanks jcamins, my problem is dependencies, perl deps
16:36 cait back later
16:36 cait leaving again shortly
16:36 cait hi :)
16:36 druthb :D
16:36 druthb Hi, cait!
16:36 * pianohacker waves caitly
16:35 * cait waves tiredly
16:33 jcamins tcohen: http://git.koha-community.org/gitweb/?p=release-tools.git;a=blob;f=release-tool.pl;h=82545cf7d1c130b9f02488095e031a7db41b4896;hb=master#l1173
16:32 tcohen thanks pianohacker
16:32 tcohen :-D
16:32 pianohacker tcohen: given that nz is still asleep, I don't know if you'll have much luck here
16:29 tcohen has anyone used dput to push cpan2deb generated packages into a local repo?
16:20 tcohen anyone with dput experience?
15:59 druthb Now, if he fits into this loony bin of an office...
15:58 druthb I'm on the in-person interview group for him. His resume looks promising.
15:58 mtompset YAY! cheering with you, druthb. :)
15:58 druthb yes. There are supposed to be *four* of us.
15:57 mtompset Reduced work load?
15:57 druthb Huzzah! My bosses have a candidate for a second Integrations person! Yayez!
15:54 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 major, P5 - low, ---, mtompset, In Discussion , Duplicate card numbers may be generated
15:54 mtompset So, did I do it correctly for bug 10454?
15:52 huginn New commit(s) kohagit: Bug 7368: Followup for columns names in userflags.sql <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2bcec70262ce8127e3755327d4d5261e0e964844>
15:52 mtompset Yes.
15:51 oleonard mtompset: And you know of the practice of including an XXX dbrev in updatedatabase.pl?
15:51 mtompset If I submit a patch without a kohaversion.pl change, then how will upgradedatabase.pl get triggered? -- Ah.
15:50 oleonard Testers will update it by hand for testing purposes.
15:50 oleonard You don't include a change to kohaversion.pl. The RM does that.
15:50 mtompset what to do with kohaversion.pl
15:49 oleonard Do you have a specific question about it mtompset?
15:48 chris_n too long probably
15:48 mtompset It's my first series of attempts.
15:48 chris_n mtompset: its been a while since I've submitted a patch requiring a db change
15:47 mtompset Oh, were we split?
15:47 mtompset chris_n: Do you know anything about including a database change and how the patch is supposed to be done?
15:46 mtompset gmcharlt mentioned in a comment on bugzilla that I shouldn't have kohaversion.pl in my patch, if I recall.
15:45 chris_n heh
15:45 mtompset Thankfully it was only 2-3 lines of code.
15:45 mtompset git was pretty smart... I just edited the file back to what it was, and it got removed from my patch.
15:45 chris_n assuming only that file was touched by that patch
15:44 chris_n mtompset: try an interactive rebase and remove the line for the patch you committed
15:42 mtompset http://wiki.koha-community.org/wiki/Git_bz_configuration -- should it be "git checkout -b fishy origin/fishsoup"?
15:32 mtompset gmcharlt: Okay, so if I don't change kohaversion.pl, then how is my patch supposed to work?
15:32 huginn New commit(s) kohagit: Bug 10336: HoldsQueue.t needs to create its own data <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bfbc646fdd9ca4b90a0bc2751d0faa95d9e93ba1> / bug 10495: set precondition for HoldsQueue test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4e51ec5aae50c878bbdca6994361b12d7ba20d0a>
15:28 mtompset anyone familiar with cherry picking? I'd like to reset a file I modified and committed. Would cherry picking solve this?
15:27 jenkins_koha Starting build #1271 for job Koha_master (previous build: SUCCESS)
15:21 gmcharlt mtompset: oh, it can be a librarian's perspective too -- e.g., a lot of library directors I know would just want it to work without having to worry about weird bugs if patrons get registered at the same time at two different branches
15:19 mtompset It's just testing output thus far.
15:19 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 enhancement, P5 - low, ---, nunyo, Needs Signoff , Make it possible to force 001 = biblionumber
15:19 mtompset did you see the sample stuff I posted on bug 9921?
15:18 mtompset That sounds more of a programmer perspective than a librarian's. :)
15:17 gmcharlt yes -- uniqueness in the face of concurrency matters more; if somebody really cares about getting sequentially assigned barcodes, they can preprint them ;)
15:16 mtompset So, you think submitting the sequence patch, even though it will create skips if someone willy-nilly refreshes, as-is is okay?
15:16 gmcharlt (I'm not proposing any universal guidelines here ;-)
15:15 gmcharlt except when it doesn't
15:15 gmcharlt in fact, trying to do so can cause more problems
15:15 gmcharlt don't have to fix everything all at once
15:15 mtompset And though I'd really like to take Marcel's suggestion to fix up the patron entry screen... this is starting to look uglier than I want to deal with.
15:13 reiveune bye
15:13 mtompset first enhancement. first time using perlcritic. first time using qa-tool. first time fixing busted git repo. and now... first time delving into javascript code in Koha.
15:12 gmcharlt hi druthb
15:12 druthb hi, gmcharlt! :D
15:12 mtompset I'm doing quite a bit of firsts lately.
15:12 mtompset That's deep, liw
15:11 huginn gmcharlt: Quote #264: "<druthb> Grokking someone else's code is still trying to reverse-engineer someone else's brain." (added by wizzyrea at 11:50 PM, June 26, 2013)
15:11 gmcharlt @quote random
15:05 liw in some projects, the first 10% takes about 900% and the remaining 90% never gets done
15:04 mtompset Sounds about right. Though I would say 90% say 10% and the last 10% takes 90%
14:49 phred The first 90% of the job takes the first 90% of the time, the last 10% of the job takes the other 90% of the time.
14:48 mtompset Just a little bit more to go with my patch. Why is there always just a little bit more?
14:47 BigRig Greetings all
14:47 mtompset Oops. Forgive the typo. :)
14:47 mtompset Ggreetings, BigRig.
14:46 mtompset Greetings, druthb.
14:39 mtompset A space?! A single space triggered the error?!
14:36 mtompset Anyone familiar with how to correct the verbatim paragraph problem?
14:31 pastebot "mtompset" at 127.0.0.1 pasted "Output of qa tool" (38 lines) at http://paste.koha-community.org/102
14:30 mtompset So, any idea on how to correct this qa unfriendly problem, tcohen? (paste to follow)
14:28 mtompset The shortening makes sense. :)
14:27 tcohen del Potro actually
14:27 tcohen argentine tennis player
14:27 tcohen its a tennis player
14:27 mtompset What is delPo, tcohen?
14:23 mtompset does anyone know how to fix verbatim paragraph issues in POD?
14:20 mtompset Good thing, because I had just done a lot of work, documenting, and modify for sequences.
14:17 mtompset After yet another git repo corruption, I figured out how to recover nicely! :)
14:17 mtompset Greetings, #koha.
14:04 tcohen go delPo!
13:57 libsysguy we are pretty chatty around here
13:57 tcohen you're just too active for us heh
13:57 libsysguy and there are just two of us
13:56 tcohen :-P
13:56 tcohen the cpanel guys have overtaken this channel
13:51 druthb brave lad. back in a bit.
13:51 libsysguy will do
13:51 libsysguy heh
13:51 druthb I gotta go down to HRâ€¦if you've not heard from me in a few hours, mount a rescue mission?
13:51 libsysguy si?
13:50 wahanui i think libsysguy is missing us again.. :)
13:50 druthb libsysguy?
13:46 libsysguy I was thinking: Texas, its the closest you'll get to hell and still get burned
13:46 jcamins lol
13:46 oleonard New tourism motto: "Texas! It's not terrible."
13:46 libsysguy but then again I like hot weather
13:45 libsysguy everybody talks bad about Texasâ€¦and while it certainly has its faults in the two areas I dare not talk about, I don't think its terrible
13:44 druthb I get along fine without one of mine...
13:44 druthb lol
13:44 oleonard My family would break my legs if I told them we were moving to Texas.
13:42 druthb libsysguy: I know, right? And with Hungry's always being *later*â€”well, except that one timeâ€”it's a torture.
13:41 * druthb suggests http://job.listings.cpanel.net/ to oleonard, if he wants the buffet. Tell 'em I sent ya; there are *fat* bounties on some of those seats.
13:40 libsysguy druthb by the time lunch gets here it could be the most disgusting thing in the world and I would eat it
13:39 * oleonard asks the other folks in his department why we don't have that.
13:39 oleonard Mmmmm... free-for-all-employees lunch buffet.
13:35 druthb Yes, it's a first-world problem that the free-for-all-employees lunch buffet is from a place I don't like much. This *particular* Cajun joint does not impress me much.
13:34 libsysguy hehe
13:34 * druthb waves her pointy stick at libsysguy.
13:34 * libsysguy is not going to touch that one
13:34 oleonard Snarf that possum.
13:33 druthb First Rule of Louisiana Cooking: If it moves on its own power, it is food.
13:33 libsysguy :p
13:33 libsysguy ALL THE FRIED THINGS!!
13:33 libsysguy YUM!
13:32 druthb libsysguy: did you see the lunchish email that just went out. Cajun. >.<
13:32 * druthb groans.
13:28 libsysguy oleonard is like me, myself, and I
13:27 oleonard In my department we're all crazy *and* pissed off. Luckily it's just me, so the damage is minimal.
13:26 libsysguy writes a translation script
13:25 * druthb hands libsysguy his en_US template files.
13:24 libsysguy note: mad in the British meaning
13:24 magnuse ah, but if you know you are mad...
13:24 libsysguy we're all mad up here
13:23 libsysguy its true
13:23 druthb Those internal dev guys just *love* self-inflicted pain and suffering. I'm gonna start calling them the masochism department.
13:22 jcamins Websockets. For when the DOM API just isn't painful enough.
13:22 libsysguy [off] this off thing is frustrating :p
13:21 druthb [off] Some days, you're just in *less* trouble than others. Have fun with the websockets.
13:21 libsysguy [off] goes back down the websocket
13:21 druthb [off] you think you're *not*?
13:21 libsysguy [off] I thought I was in trouble
13:21 libsysguy [off] okay *phew*
13:20 libsysguy :p
13:20 libsysguy [off] now I have to read back
13:19 jcamins [off] libsysguy should have obeyed the dictum "do not meddle in the affairs of druthb when she is carrying a big stick and walking softly"
13:19 druthb [off] Hush, you; he's as tall as I am, and too cute to beat up on. Much. It'd be like abusing a puppy.
13:18 jcamins [off] Oh, is _that_ why libsysguy is limping and keeps looking up furtively like he feels someone very very tall towering over him?
13:18 druthb If you can't understand someone's accent, that's fineâ€”I get it. Depending on where you're from, the calibration of your ears might be incompatible with their language, even if it's all in English. But don't say crap like that where they can hear you! Geez.
13:17 magnuse ah, i suspcted there was some deeper meaning :-)
13:17 druthb It was tempting, yes.
13:17 oleonard And by "schooled" she means "beat with a stick" for you non-native speakers.
13:15 magnuse druthb++
13:15 druthb Needless to say, the partner understood this just fine, and was (understandably) deeply offended. But we had a nice conversation, and I later *schooled* my teammate on his bad manners.
13:14 druthb During HostingCon last week, one of my teammates brought someone to me, the owner of a partner NOC in Indiaâ€”and said, "I can't understand him; you've been there, maybe you can help."
13:13 oleonard (which is the only way I know how to speak any foreign languages)
13:13 oleonard That should be a lesson to me when I worry about speaking a foreign language badly.
13:13 druthb ^^ Yes, This!
13:13 oleonard Even if someone's English is imperfect I never care as long as I want to talk to them.
13:12 druthb (In retrospect, I acknowledge that she did me a major disservice. But that university won't even acknowledge my existence any more, so I'm not too worried about what they think, these days.)
13:12 jcamins lol
13:12 magnuse wow
13:11 druthb Oh, I *know* I don't speak English well. When I was in college, my advisor actively discouraged me from taking a foreign language; her precise words were "you just barely speak English."
13:11 jcamins 'Cause I'm sure I would've told druthb that she was unintelligable. :P
13:10 druthb :P
13:10 * jcamins has never had this conversation with druthb, apparently.
13:09 druthb For the record, I end up in this same conversation with cait a lot. She doubts her English, too, yet I understand her just fine.
13:06 tcohen heh
13:06 druthb The barometer for me is "can I understand you?" Given that I occasionaly have more trouble understanding slef and the kiwis than I do youâ€¦.your English is quite good.
13:06 tcohen heheh
13:05 magnuse hehe, good question :-)
13:05 tcohen how can u tell?
13:04 tcohen hmmm
13:04 druthb bah! Your English is just fine, tcohen; I've never had any trouble understanding you.
13:03 tcohen magnuse does better in spanish than me in english
13:03 magnuse yay!
13:03 * druthb hugs magnuse
13:03 druthb \o/
13:02 magnuse \o
13:00 druthb o/
13:00 tcohen heh
13:00 magnuse oops, sorry :-)
12:58 tcohen Â¡*buenos* dÃas magnuse!
12:48 magnuse Â¡buenas dias tcohen!
12:43 tcohen morning #koha
12:38 magnuse thanks oleonard
12:36 Viktor yes sir
12:35 oleonard Well then, you can all get to work now. Carry on.
12:34 magnuse we were just waiting for you oleonard ;-)
12:31 Viktor Glad to hear oleonard :)
12:28 oleonard I'm back, #koha!
11:51 huginn libsysguy: The operation succeeded.
11:51 libsysguy @later tell nengard HAPPY BIRTHDAY
11:43 samueld i try to add an option in advanced search (date of creation of the record, based on 940$a (in Unimarc).When i test, i've this error "Can't call method "sort" on an undefined value at /home/koha/kohaclone/C4/Search.pm line 426. "
11:42 samueld hi everybody :-)
11:25 Viktor We plan to use an item type to keep track of ILLs and that is the last pice of the puzzle so the librarians don't shelve an ILL-book in their own library.
11:24 Viktor Is it possible to light up a message in the circulation module when returning items of a specific item type?
09:47 * magnuse takes notes
09:46 ribasushi but anyway - Niederrhein is an awesome region, but the weather sucks - would not recommend ;)
09:46 magnuse yup, that is a proper mountain :-)
09:46 ribasushi right, it is the highest within germany itself
09:45 magnuse i was confusing dutch and deutsch or something...
09:45 ribasushi Zugspitze is a proper mountain in the alps however: https://en.wikipedia.org/wiki/Zugspitze
09:44 magnuse aaahhh...
09:44 ribasushi there is a dutch island in the carribean however, which has a proper mountain (the island was not part of the ,nl until 2000...something)
09:44 ribasushi highest in their continental part
09:43 ribasushi this is the dutch "mountain peak"
09:43 ribasushi https://en.wikipedia.org/wiki/Vaalserberg
09:43 * magnuse remembers that name from having german in school
09:43 ribasushi it's a joke, let me get the actual link
09:43 ribasushi hehe, no that's a diff. country
09:42 magnuse zugspitze?
09:41 magnuse the peak?
09:39 ribasushi in fact the peak is a bus ride away
09:39 ribasushi it has to do with being high in the dutch mountain region I've heard
09:38 ribasushi I love this place, but the weather... ugh
09:38 ribasushi yes
09:37 magnuse it's warmer noth of the arctic circle than in aachen, then :-)
09:35 ribasushi fml
09:35 huginn ribasushi: The current temperature in Aachen, Germany is 11.4Â°C (11:32 AM CEST on June 27, 2013). Conditions: Partly Cloudy. Humidity: 96%. Dew Point: 11.0Â°C. Pressure: 30.24 in 1024 hPa (Steady).
09:35 ribasushi @wunder aachen, de
09:34 * Oak is learning Ruby these days
09:34 ribasushi oh wait...
09:34 ribasushi magnuse: jailbait!
09:34 magnuse huh s/:-=/:-)/
09:34 Oak heh
09:34 magnuse and i prefer 17 over 31, so everyone is happy , it seems :-=
09:33 magnuse :-)
09:28 Oak 31 is much better than 42. so, good :)
09:20 huginn magnuse: The current temperature in Bodo, Norway is 17.0Â°C (10:50 AM CEST on June 27, 2013). Conditions: Clear. Humidity: 63%. Dew Point: 10.0Â°C. Pressure: 30.15 in 1021 hPa (Steady).
09:20 magnuse @wunder boo
09:20 huginn magnuse: The current temperature in Islamabad, Pakistan is 31.0Â°C (2:00 PM PKT on June 27, 2013). Conditions: Scattered Clouds. Humidity: 62%. Dew Point: 23.0Â°C. Pressure: 29.53 in 1000 hPa (Falling).
09:20 magnuse @wunder islamabad
09:20 magnuse :-)
09:20 Oak :)
09:20 Oak magnuse
09:18 magnuse Oak
08:54 magnuse i can't see you identifying
08:53 magnuse for me it looks like you just quit and came back
08:53 Viktor Curious: Just came back to the computer and ran identify on nickserv to get my nick. How do I look to others before identifying?
08:52 Viktor Thanks :)
08:51 magnuse :-)
08:51 magnuse welcome back Viktor
08:46 magnuse ribasushi: a bit too early for gmcharlt to be awake, i think
08:35 ribasushi gmcharlt: I saw your latest exchange, wanted to throw in some ideas you guys don't seem to have considered yet
08:34 ribasushi o/
08:21 Viktor You too drojf
08:21 drojf have a nice day #koha
08:21 * drojf heads to the library
08:15 Viktor Hi drojf!
08:15 drojf hi Viktor
08:15 drojf it is "optimized" ;)
08:14 drojf there is an old ad saying "die bahn kommt" with a german train going through some winter landscape. it's ridiculous what happens nowadays. if a snow flake is in sight there is chaos because of "the worst winter ever!" and everything breaks down. if it's hot, air condition dies and everything breaks down. and so on
08:13 Viktor Hi magnuse!
08:12 magnuse hej Viktor
08:12 magnuse ouch
08:12 drojf magnuse: it was killed by greed
08:08 magnuse huh, what happened to german efficiency and punctuality?!?
08:07 drojf paul_p: you obviously do not often use the german train system. 3:30 is nothing ;)
08:06 drojf magnuse: i got a tiny carrel in my university library. a brain laying battery ;)
08:01 magnuse paul_p++ for pursuing the DBIC issues
08:01 magnuse bonjour paul_p
08:01 magnuse laying battery?
08:01 paul_p yesterday my train was 3H30 late. it's probably my latest train ever ...
08:00 paul_p hello #koha
07:53 * drojf prepares for the laying battery
07:50 drojf that would be great
07:47 magnuse i hope more signoffers can be educated during the hackfest in reno...
07:46 magnuse and yes that "needs signoff" queue needs some attention
07:46 * magnuse too!
07:38 drojf not fair. want to play with koha :/
07:38 drojf needs signoff: 159. ouch. yes i have that "being busy" problem too
07:36 magnuse everyone is really busy, i think?
07:35 drojf or it's just me coming in at bad times
07:35 drojf #koha seems really quiet lately
07:27 magnuse moin drojf
07:27 drojf hei magnuse
07:27 drojf hehe
07:27 magnuse :-)
07:27 magnuse hah!
07:27 huginn magnuse: The current temperature in Bodo, Norway is 17.0Â°C (9:20 AM CEST on June 27, 2013). Conditions: Clear. Humidity: 63%. Dew Point: 10.0Â°C. Pressure: 30.18 in 1022 hPa (Steady).
07:27 magnuse @wunder boo
07:27 huginn drojf: The current temperature in Prenzlauer Berg, Berlin, Germany is 16.1Â°C (9:13 AM CEST on June 27, 2013). Conditions: Partly Cloudy. Humidity: 53%. Dew Point: 7.0Â°C. Pressure: 30.18 in 1022 hPa (Steady).
07:27 drojf @wunder berlin, germany
07:13 christophe_c hello #koha
06:57 drojf good morning #koha
06:44 magnuse nice
06:44 huginn magnuse: The current temperature in Marseille, France is 18.0Â°C (8:30 AM CEST on June 27, 2013). Conditions: Clear. Humidity: 52%. Dew Point: 8.0Â°C. Pressure: 30.12 in 1020 hPa (Steady).
06:44 magnuse @wunder marseille
06:44 huginn magnuse: The current temperature in Bodo, Norway is 15.0Â°C (8:20 AM CEST on June 27, 2013). Conditions: Clear. Humidity: 67%. Dew Point: 9.0Â°C. Pressure: 30.18 in 1022 hPa (Steady).
06:44 magnuse @wunder boo
06:44 magnuse bonjour!
06:44 dcook salut reiveune, gaetan_B
06:43 reiveune hello
06:32 magnuse hiya dcook
06:32 * dcook waves to magnuse
06:30 * dcook hopes that cPanel is better than whatever garbage he's currently using...
06:26 * magnuse waves
06:22 mtompset Have a great day, #koha.
06:22 mtompset Well, I should sleep.
06:21 dcook Oh well. Fewer patches to port across.
06:20 dcook Looks like a lot of those changes I made yesterday aren't particularly relevant anymore in 3.10+ either...hmm
06:19 cait dcook: the usual :)
06:09 dcook cait: Only 4 lines of code ;)
06:07 dcook Or maybe that was my old install..
06:07 dcook I wonder if my git bz will work. I'm pretty sure that I'm using the fishsoup branch already anyway...
05:59 pastebot "mtompset" at 127.0.0.1 pasted "How do I make this into a t/Sequence.t?" (25 lines) at http://paste.koha-community.org/101
05:58 mtompset Okay... let's say I have some nice code that I used to test my class.
05:58 mtompset I need to fix my internal documentation, but that will be a later task.
05:57 mtompset perlcritics nice.
05:57 mtompset Okay... *whew* I think I have something -- again.
05:52 dcook Hmm, looks like master will take some re-writing..
05:45 dcook I should be able to do up a patch for the other one as well
05:45 dcook :)
05:45 cait yay
05:32 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 normal, P5 - low, ---, gmcharlt, NEW , location facet shows even if no locations
05:32 dcook Bug 9801, I do believe I have just busted you.
05:28 eythian > If there are no more rows or if an error occurs, then fetchrow_hashref returns an undef.
05:27 mtompset So, if the sequence table is empty, or there is no matching sequence name... what will sth->fetchrow_hashref return?
05:26 mtompset I'm not sure how freely, but it could become more likely, if we have this functionality.
05:25 eythian if it's expected that sequences will be freely created all over the place, I'd auto-create
05:25 mtompset In which case, I need to rename the function _add_sequence, since I don't need to export it.
05:25 eythian I'm not sure. Either that or bail out.
05:24 mtompset So, you suggest doing the add_sequence call for non-existent sequences?
05:23 eythian I'd also simplify the case: if this sequence doesn't exist, your constructor does one of two things: creates a new one, or fails to instantiate. Either is valid, but ending up with a sort of limbo object seems like the worst option.
05:23 mtompset let's say I my $seq = Koha::Sequence->new('thing_not_exist',42);
05:22 eythian if it's empty, you'll get an error about dereferencing an undefined value.
05:21 eythian that's what you want to be doing
05:21 eythian "If there are no more rows or if an error occurs, then fetchrow_hashref returns an undef. You should check $sth->err afterwards (or use the RaiseError attribute) to discover if the undef returned was due to an error."
05:20 eythian you're not testing that case correctly
05:20 mtompset don't know why it would be, but it could be.
05:20 mtompset sequence table could be empty.
05:19 eythian why are you checking the value on $data->{sequence_name} when it's explicitly what you asked for from the database?
05:18 eythian I misunderstood the first time I read your question.
05:18 mtompset Right.
05:18 mtompset no oh yes?
05:18 eythian then you do 'return bless $self, $class'
05:17 eythian yes
05:17 eythian oh
05:17 eythian no
05:17 mtompset Ah, okay. So $self is my'd in the new().
05:16 eythian also, your problem is that you don't get $self in to new, you get $class
05:16 eythian but won't that break if something calls add_sequence on another copy of the object?
05:16 mtompset But you have a valid point on the dbh.
05:15 mtompset the cache of the value is for if an add_sequence call is made.
05:15 mtompset I grab the fresh value for get_next_value
05:15 eythian I also wouldn't cache your data, if it can change in the database.
05:14 eythian mtompset: never cache a database handle
05:14 mtompset Can't use string ("Koha::Sequence") as a HASH ref while "strict refs" in use at /home/mtompset/kohaclone/Koha/Sequence.pm line 100.
05:14 mtompset I'm getting an warning.
05:14 dcook Note to self: When debugging, make sure you're on the right site. Tabarnac...
05:12 pastebot "mtompset" at 127.0.0.1 pasted "constructor rework attempt;" (38 lines) at http://paste.koha-community.org/100
05:12 eythian yeah sure
05:11 mtompset could you look at my constructor?
05:11 mtompset am relatively new to OO...
05:11 eythian heh
05:11 wahanui rumour has it Seeing as mtompset is not at #kohacon12, no questions. :P
05:11 mtompset eythian: Seeing as I
05:00 eythian *drive
05:00 * eythian has hourly and nightly syncs to a backup dribe.
04:59 wizzyrea but i'd be less productive for a day or so :P
04:59 * wizzyrea wouldn't be heartbroken if the stuff on here went away - I don't have a lot local.
04:58 eythian I'd run a disk test overnight, and some other time boot it into a memory test overnight.
04:57 wizzyrea not it's normal self. so yea, disk checks and so on are probably warranted
04:57 wizzyrea actually my computer has been unusually irritating today
04:57 eythian that's where I was going with that :)
04:57 wizzyrea these things are probably all related.
04:56 wizzyrea hmm.
04:56 eythian e.g. a corrupt and rewritten config
04:56 eythian or rather, resets your changes.
04:56 eythian wizzyrea: that happens when something resets your defaults I think.
04:56 cait morning eythian and wizzyrea
04:56 wizzyrea I'd expect that kind of thing from microsoft.
04:56 wizzyrea hm at some point ubuntu put the U-one and software center back on my launcher. That's annoying.
04:55 dcook So it wasn't magic, I guess ;)
04:54 eythian dcook: I've been slowly manually tweaking a database schema to support timezones today, it's not the most engrossing of things, so it's probably the cause.
04:54 wizzyrea eythian is extremely sensible :)
04:54 dcook usually*
04:54 eythian wizzyrea: shouldn't.
04:54 wizzyrea he is always full of sense.
04:54 dcook Not that you usally speak nonsense, but you seem especially on point
04:54 dcook eythian: Is it just me or are you talking more sense than usual today?
04:53 wizzyrea would other mozilla apps being in a state of needing restart have messed it up? that's a bit of a long shot I suppose.
04:53 eythian mtompset: use Carp;
04:53 * eythian is never a fan of relying on magic for having things work right.
04:53 mtompset Okay, I'm back at fixing up my code... do I have to include something to make croak work?
04:53 eythian I'd run disk and ram tests if I were you.
04:53 wizzyrea and after that, it worked again
04:53 eythian hmm.
04:52 wizzyrea so I would have had to reinstall it to run it from the terminal :P
04:52 wizzyrea sadly I hadn't done that, because when you suggested it I had just removed it
04:52 wizzyrea but yay! daft punk! just in time to go home!
04:52 eythian what'd it do when run from terminal?
04:51 wizzyrea hm. then I got nuthin. Something was angry.
04:51 eythian yeah, but uninstalling it doesn't touch your config at all
04:51 wizzyrea well I think I must have borked something in the config when I was piddling around in the preferences
04:50 wizzyrea ikr.
04:50 eythian if it does, it might be a sign of hardware malfunction.
04:50 eythian that's not supposed to work as this isn't windows.
04:49 wizzyrea uninstalling and reinstalling for the win!
04:48 wizzyrea ya, that's next
04:48 eythian if you're lucky
04:48 eythian then if you run it from a terminal it might tell you something useful
04:48 wizzyrea no, it's not running. It's busted. :(
04:44 wizzyrea hm
04:42 eythian it's probably already running but that process has frozen.
04:42 wizzyrea idk what the deal is :( but I miss my daft punk.
04:42 wizzyrea my rhythmbox decided to just not start
04:39 dcook Made it to 2:40pm before needing headphones. I must not have been thinking hard enough this morning...
04:33 dcook quotes!
04:32 wizzyrea it's a quoty day
04:32 huginn wizzyrea: The operation succeeded. Quote #265 added.
04:32 wizzyrea @quote add <gmcharlt> #koha ... once you join, you need never sleep again!
04:31 gmcharlt #koha ... once you join, you need never sleep again!
04:30 wizzyrea BEEP BEEP BEEP
04:30 wizzyrea morning cait :)
04:30 eythian go to bed, cait.
04:29 dcook wb cait
02:50 eythian it's more or less the same
02:50 eythian ah right
02:50 mtompset I get it backwards sometimes. :)
02:50 mtompset I use what-is-it? Tiny::Try?
02:49 eythian it's just like die, but with a stack trace.
02:49 eythian yes
02:49 eythian eval { } if ($@) { } you mean
02:48 mtompset is croak try{}catch{}-able?
02:48 eythian I'd probably croak, but I like exceptions.
02:47 mtompset true.... all in the constructor.
02:47 eythian Whether you return undef or croak is up to you.
02:47 eythian you'll also have to handle the sequence not existing.
02:47 eythian croak is good actually
02:47 mtompset perlcritic will probably mention something about croak.
02:46 eythian I'd recommend die
02:46 eythian Or die.
02:46 mtompset Then the new needs to return undef if they don't pass a sequence name.
02:46 eythian you don't need/want to be able to change the name of a sequence.
02:46 eythian Probably also have a static function to create a new one.
02:45 eythian Not set
02:45 eythian yeah, in the new put it as $self->{seq_name}, and later access it like that.
02:45 mtompset give them set and gets for the sequence name.
02:45 mtompset Basically, if they pass a sequence name in the new, store it as the state.
02:45 eythian np
02:45 eythian you just store values in $self (what you're calling $class) and access them. That's all there is to it
02:45 mtompset I do appreciate the code review, eythian.
02:44 mtompset true enough...
02:44 eythian If you want, but it's a very short step from what you've got to make it work properly as it is.
02:44 mtompset sounds like a Class:Accessor might be handy.
02:43 eythian You'll have to hit the db for every request anyway, but if someone needs a function that provides the last value that this object provided, it's possible to do that with the state handled properly.
02:42 eythian basically, the object you get from new should represent a sequence more than being an interface to the sequence database.
02:41 mtompset Be gentle. I don't code OO normally. :P
02:41 eythian as then you can pass that to things that don't need to know the sequence name.
02:41 eythian that's how OO is supposed to work
02:41 mtompset I suppose I could have.
02:41 eythian you then get back an object associated with that sequence
02:41 eythian ?
02:41 eythian why would you not give sequence_name to the new()
02:40 eythian to start with, the object passed in in all cases except new() isn't a class, so shouldn't be called $class, it should be called $self.
02:40 mtompset I only care about do something with this sequence.
02:40 mtompset Does it really need to have one?
02:39 eythian it doesn't seem to actually have any state
02:39 eythian *though
02:39 eythian err, it's odd thought
02:39 mtompset I thought the USAGE parts above each function would have demonstrated that. :P
02:38 eythian oh, it is OO. I missed that.
02:37 mtompset Well, since gmcharlt suggested a class, that's why I coded it this way. I think I got it okay. :)
02:37 eythian New code ought to be OO, too, but I don't know how much that's enforced yet.
02:36 eythian that's where we're putting new stuff unless it depends on preexisting code other than C4::Context.
02:36 mtompset Is there a wiki page explaining how to decide?
02:36 mtompset Why the Koha name space?
02:33 mtompset Okay, good suggestion. Tweaking. :)
02:33 eythian at the moment there totally no context.
02:32 eythian sure. So someone looking at it sees that it's useful for generating a sequence of barcodes, and a sequence of borrower card number, and what kinds of rules these sequences have, and so on.
02:32 mtompset so that should be in the modules DESCRIPTION?
02:31 eythian but I don't know that
02:31 eythian yep
02:31 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 enhancement, P5 - low, ---, gmcharlt, NEW , Do we need a sequential number generator?
02:31 mtompset bug 10478
02:31 mtompset And ....
02:31 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 major, P5 - low, ---, mtompset, In Discussion , Duplicate card numbers may be generated
02:31 mtompset bug 10454
02:31 mtompset sequences.
02:31 eythian or rather, it's written from the point of view of someone who knows the context already.
02:30 eythian also, you don't say in the description what it does.
02:30 eythian your file should be in the Koha:: namespace, rather than C4::
02:30 eythian but for simple stuff it is.
02:30 eythian it's not always the same, as sometimes there are conversions needed
02:29 eythian yes
02:29 mtompset As long as it isn't "rm -rf /", wizzyrea. ;)
02:28 mtompset So, let me see if I got this straight. kohastructure.sql may have duplicate code in updatedatabase.pl?
02:27 mtompset Shrinks the code a tad. :)
02:24 eythian fair enough
02:24 mtompset Okay. Actually, I think I'll just DELETE FROM sequence, rather than truncate. the former is friendlier across SQLs.
02:23 * wizzyrea wants to come up with something to make git do when you tell it to "git ridiculous situation"
02:19 eythian *quite
02:19 eythian yep, otherwise you end up with git ridiculous situations
02:17 wizzyrea kind of beyond what you should be expected to cope with, imo
02:17 wizzyrea and, if they do that... they shouldn't have.
02:17 wizzyrea yea, that should be an extremely rare case
02:16 eythian only when setting up a fresh install
02:16 mtompset does the webinstaller upgrade process ever call kohastructure.sql?
02:16 eythian they shouldn't do that.
02:16 eythian you don't.
02:15 mtompset What if the table does not exist? --- let's say person who should know better drops that table without thinking. How do you recover from that state?
02:14 mtompset okay... so a truncate and insert the two records is what you would expect for reset_everything?
02:11 eythian http://wiki.koha-community.org/wiki/Database_updates <-- see this
02:11 eythian arbitrary code shouldn't go round messing with the schema, ever.
02:11 eythian as well as in the schema file
02:11 eythian right, so it gets added there.
02:11 mtompset yes, I am thinking of updatedatabase.pl
02:10 mtompset I have 3.8.6 ... when this gets into Koha (assuming I've cleaned it up appropriately), sequence wont exist yet.
02:10 eythian are you thinking of what updatedatabase.pl does?
02:10 eythian that's not a sentence that makes sense
02:09 mtompset upgrade for the first time.
02:09 eythian why would it not exist?
02:09 mtompset well, table doesn't exist?
02:09 mtompset And if the tables don't exist?
02:08 eythian truncate
02:08 mtompset But what if I want to reset everything without triggering other things in kohastructure.sql?
02:07 eythian installer/data/mysql/kohastructure.sql
02:07 mtompset point me in the right direction, and I'll fix it.
02:07 mtompset schema file?
02:07 eythian in fact, it definitely should.
02:07 eythian I think it should be in the schema file
02:06 eythian creating a db from code seems odd
02:05 mtompset I was just as surprised as you. :)
02:05 mtompset Not the default install that I got working. :)
02:05 eythian although I would have expected it to know better.
02:04 eythian If you really want, I'd put a perlcritic exception in there.
02:04 eythian use Modern::Perl means you don't need use strict, use warnings.
02:03 mtompset Oops... HOW ugly. :)
02:02 pastebot "mtompset" at 127.0.0.1 pasted "Okay, so ugly do you think this is? (LONG CODE)" (480 lines) at http://paste.koha-community.org/99
01:57 mtompset However, that example is just plain small, and the function is small.
01:56 mtompset my ( $dbh, $sql, $sth, $rv );
01:56 mtompset Well, in the case of my wrapping my, that seems like a good way to deal with it.
01:55 eythian yeah, there's no reason not to. It minimises the scope of each thing, which I think is desirable, all other things being equal.
01:54 mtompset (first occurence or scope of use)
01:54 mtompset You are suggesting my on the fly?
01:53 eythian declaring at the top is a strange thing to do.
01:52 mtompset the order in the routine is generally grouped by behaviour of sorts.
01:50 dcook eythian++
01:50 eythian Or declare them when you need them
01:50 eythian group them by behaviour at least.
01:50 eythian erg.
01:50 eythian this isn't C or Pascal, you don't have to pre-declare everything
01:50 mtompset I'm strange... the list is ordered by use in the routine.
01:49 eythian to be honest, I tend to a) avoid big declarations like that, and b) group them.
01:49 mtompset Oh wait... you're right... 80 wide.
01:48 eythian no it's not.
01:48 mtompset It's excluding the initial whitespace in the character count.
01:48 eythian then there's no problem.
01:48 eythian oh right
01:47 mtompset but the $trv variable is wrapping on my screen.
01:47 * dcook nods
01:46 eythian vertical space is cheap.
01:46 eythian That's the right thing to do.
01:46 eythian mtompset: it's probably because the line is >80 characters, so it's making it shorter.
01:45 mtompset mashing them up onto one line.
01:45 dcook If that's what perltidy does, that's fine by me
01:44 dcook I don't really care either way though :p
01:44 dcook Right...but I don't see how mashing them up would save vertical space. Stretching them out would save vertical space. In this case, in my mind, mashing up would be taking up more vertical space (while saving horizontal space)
01:43 mtompset Of course, this was back in the days of 80x24. ;)
01:42 mtompset listing your variables vertically meant less function code space for him.
01:41 mtompset I recall a long time ago, I was told by someone that the standard he was required to code to was that no function would be longer than a screen height.
01:40 dcook Mashed up to save vertical space? O_o
01:40 mtompset as do I, but I can live with them mashed up to save vertical space.
01:40 dcook But recently, I've been thinking I like them all in the same area on the screen, especially when developing on smaller screens
01:40 dcook I used to prefer having all my variables on one line
01:39 dcook Ugly seems pretty subjective there
01:38 pastebot "mtompset" at 127.0.0.1 pasted "Any ideas on how to not wrap my variable list?" (6 lines) at http://paste.koha-community.org/97
01:37 mtompset I agreed with most of the perltidy tweaks, but it still wants to wrap my variables ugly in one case.
01:35 dcook nice one, wizzyrea!
01:35 * dcook dislikes table-based layouts...
01:33 eythian I'd exclude that in your .perlcriticrc, it's a useless test these days.
01:30 pastebot "mtompset" at 127.0.0.1 pasted "Oops... missed the Code is not tidy." (6 lines) at http://paste.koha-community.org/96
01:29 eythian what's the message about the CVS tags?
01:28 mtompset And my perldoc is pretty.
01:28 wizzyrea oooo one of my genetic cars got to 191
01:28 mtompset -3 through -5... OK. :)
01:28 mtompset -2 is just the CVS tags.
01:28 mtompset the CVS tags, and some POD before ____END____ thing.
01:27 mtompset 5
01:27 mtompset $ perlcritic -1 Sequence.pm | wc -l
01:27 eythian although the level 5 ones might be good to look at one day.
01:26 mtompset My code is pretty-ish.
01:26 eythian I might not try to clean that up.
01:26 eythian 810
01:26 eythian $ perlcritic -1 csvtomarc.pl | wc -l
01:24 mtompset I ignored those, and moved up to perlcritic -1. :)
01:24 mtompset perlcritic -2
01:24 eythian mtompset: yes, primary keys are unique
01:24 eythian mtompset: ah, so it's expecting CVS tags?
01:19 mtompset DOH! She left just when I was going to greet her.
01:11 dcook Reasons not to maintain a local fork as well :p
01:11 dcook Man...reasons to keep more current than 3.8...all the bugs
01:11 * dcook waves to cait
01:09 mtompset What is the POD before ___END___ all about?
01:07 mtompset There ... a single space on the front of the line, and perldoc takes my formatting. :)
00:56 mtompset Hmmm... why does perldoc change my whitespacing?
00:48 mtompset Making the perldoc prettier now.
00:34 mtompset if I make a field a primary key, it becomes distinct, correct?
00:34 mtompset Shoot... just thought of a case i didn't think of before.
00:31 mtompset Yes, but perlcritic (by default) is looking for some of them.
00:30 eythian we don't use CVS, they could be dropped
00:28 mtompset koha says we don't care about the CVS tags, so I ignore those warnings in the perlcritic.
00:28 mtompset This Sequence.pm is going to be beautiful.
00:25 eythian there are corner cases it gets a bit weird, but mostly good.
00:25 eythian perltidy is quite good
00:24 dcook As for perltidy, I haven't used it yet but...http://search.cpan.org/~shancock/Perl-Tidy-20121207/lib/Perl/Tidy.pm ?
00:23 mtompset dcook++
00:23 mtompset Yep. Thanks, dcook!
00:22 dcook I do believe
00:22 dcook perldoc
00:22 mtompset How do I view it?
00:22 mtompset Okay... I have a whole bunch of pod stuff in my Sequence.pm
00:20 mtompset code is not tidy... will perltidy fix that?
00:18 dcook Usually at the normal Europe time
00:18 dcook marcelr*
00:18 dcook marclr
00:18 dcook Yep
00:18 mtompset M. de Rooy... does he come on IRC at all?
00:13 dcook I like it when a dark horse emerges from the back and breaks a record :)
00:12 wizzyrea I like it when they tumble
00:11 dcook I think the wheel density might actually affect the weight which can help with climbing some of those little hills
00:11 dcook 157...new champ
00:10 dcook I know there's one for wheel density but I'm not sure how much of an effect that has
00:09 dcook That could be handy
00:09 wizzyrea they need to have a random mutation for stickier wheels
00:08 wizzyrea http://img571.imageshack.us/img571/6024/mv5.png < was the best one
00:07 dcook Looks bad ass, wizzyrea
00:07 dcook Oh...yay...finally a better mutation
00:07 wizzyrea http://img10.imageshack.us/img10/9830/44d.png < my current elite
00:07 dcook 7
00:07 dcook Generation 3 and the best is only 59.
00:07 dcook Well yesterday's lot seem like geniuses in comparison to this one
00:06 dcook Today's generation are a bunch of...
00:06 dcook I think the best was around 180/190
00:06 dcook I would've been interested to see how mine did yesterday
00:06 eythian (I forgot to leave it in the foreground when I left, so it ran slowly)
00:05 eythian I still have a giant mountain that they've only crossed 6 times out of 55 generations
00:05 wizzyrea generation 1705
00:05 tcohen hi wizzyrea
00:05 wizzyrea hm best was 159.7
00:05 * dcook starts his cars back up
00:04 wizzyrea it was on generation 20xx something
00:04 wizzyrea OH i need to check them
00:04 dcook Speaking of computers...how are your cars doing this morning, wizzyrea?
00:04 tcohen hi dcook, #koha
00:04 * dcook waves to tcohen
00:04 dcook Mmm, very true
00:03 wizzyrea (substitute your mobile app of choice... facebook is just an example)
00:03 wizzyrea and it's done
00:03 wizzyrea click done
00:02 wizzyrea take picture
00:02 wizzyrea click post picture
00:02 wizzyrea open facebook
00:02 wizzyrea on a phone it's
00:02 wizzyrea and so on
00:02 wizzyrea upload picture
00:02 wizzyrea try to find picture
00:02 wizzyrea open facebook
00:02 wizzyrea transfer it to computer
00:02 wizzyrea take a picture
00:02 wizzyrea on a computer... it's
00:02 wizzyrea on a phone that's really easy
00:02 wizzyrea well things like posting a picture to facebook
00:01 wizzyrea hehehehe
00:01 dcook I remember hearing a conversation in a restaurant about this retired old man who was playing an online game on Facebook, and how he befriended someone in Texas because they guarded each other's castles
00:01 dcook hehe
00:00 wizzyrea well, it is now :P
00:00 wizzyrea ^ do note, that may not really be a thing.
00:00 wizzyrea instagrannies crack me up ;)