Time  Nick         Message
00:00 jcamins      Good morning, dcook. Operation Mango Chocolate Chip Cookie is a go.
00:00 dcook        Morning, jcamins. That sounds amazing!
00:01 dcook        How far along in the mission are you?
00:02 jcamins      dcook: I have combined mango, butter, and sugar.
00:02 jcamins      Ooh, I wonder what the pH of mango is...
00:03 jcamins      3.4-4.6.
00:03 jcamins      That's pretty acidic.
00:04 dcook        Interesting fact or potential problem?
00:05 dcook        In either case...mango, butter, sugar...*drool*
00:05 dcook        We may have sat in bed last night with a bowl of Anzac biscuit mixture and a laptop with BSG season 1
00:06 jcamins      dcook: actually, good news.
00:06 jcamins      It'll offset the fact that I'm going to use more baking soda than I generally would because baking soda will help the cookies bind.
00:07 jcamins      I didn't like BSG.
00:07 jcamins      However, sitting in bed with cookie dough sounds like a *great* idea.
00:10 cjh          I found BSG really hard to get into.
00:14 jcamins      I found it to be overly conservative, politically, a la Starship Troopers (the book).
00:15 jcamins      Interestingly, I am the only person who has been troubled by this, ever.
00:15 dcook        jcamins: I have a limited knowledge of baking, but I figured that might be the case
00:15 dcook        Surely, you're not the only one to be troubled by this :p
00:15 jcamins      Okay, maybe not ever. I was never interested enough to see if anyone agreed with me.
00:16 rangi        heinlein was a fruitloop
00:16 dcook        I find it interesting although the plot is spotty especially at the end
00:17 jcamins      dcook: since you are surely going to want to make them, the recipe is: 1 ripe mango, chopped; 1 stick butter, softened; 2 eggs; 1 tsp. vanilla extract; 2 c. flour; 3/4 tsp. baking soda; 1/4 tsp. salt; 2 Tbsp. unsweetened shredded coconut; 1 c. chocolate chips.
00:17 dcook        hehe
00:17 jcamins      Bake at 350 degrees Fahrenheit, I think.
00:17 jcamins      Right now I'm chilling them because the dough is... a bit soft.
00:18 dcook        Hmm, I don't know if our oven has Fahrenheit
00:18 * jcamins    contemplates what else to bake.
00:18 dcook        In Canada, we have both Celsius and Fahrenheit, but Australia is serious about its metric system
00:18 dcook        Of course, I could just look it up...
00:18 dcook        But I wanted to point out that Australia is weird...in their adherence to a single standard...
00:21 dcook        What else to bake...
00:21 dcook        rangi: What makes you say that? Not that I've ever read any Heinlein, but I'm curious.
00:21 dcook        Saw Larry Niven at a con once. Odd fellow...
00:21 dcook        Never read any of his stuff either
00:24 jcamins      I enjoyed some of Niven's books quite a lot.
00:24 rangi        space cadet
00:25 rangi        starship troopers
00:25 jcamins      Yeah, I was not such a fan of Heinlein.
00:26 rangi        good writer, dont like his idea of the future tho :)
00:27 dcook        I don't know if I like any writer's idea of the future :p
00:27 dcook        jcamins: You always do an excellent job of making me hungry before lunch..
00:27 jcamins      dcook: you're welcome.
00:28 jcamins      Chewy chocolate cookies?
00:28 jcamins      Those are always good.
00:29 dcook        Mmm chewy...
00:31 jcamins      Nah, better make up something new.
00:33 jcamins      But what?
00:33 jcamins      I already did rosemary the other day.
00:34 jcamins      Green tea.
00:34 dcook        Oh right...I forgot about the rosemary ones. I think you sent me the recipe for that as well.
00:34 * dcook      really needs to start baking this winter
00:35 jcamins      Okay, let's see...
00:52 dcook        bgkriegel: Are you around?
00:53 dcook        @later tell bgkriegel Any case of getting bug 9458 into 3.10.x?
00:53 huginn       dcook: The operation succeeded.
00:53 dcook        Err
00:54 dcook        @later tell bgkriegel case = chance
00:54 huginn       dcook: The operation succeeded.
00:55 bgkriegel    Hi dcook, let me look
00:55 dcook        Cool. Thanks :).
01:01 jcamins      And, for those of you wanting the green tea chocolate cookie recipe: 2 sticks butter, softened; 2 c. sugar; 2 eggs; 2 tsp vanilla extract; 3/4 c. cocoa; 2 Tbsp fine sencha; 2 c. flour; 3/4 tsp. baking soda.
01:03 bgkriegel    dcook, does not apply cleanly, I need to look deeper.Anyway I normally wait for 3.12 branch first, and we are in string freeze right now. So it must wait to 3.10.8
01:03 jcamins      bug 9458
01:03 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Add sorting to lists
01:05 dcook        bgkriegel: Sounds good :). Thanks for looking into it for me.
01:41 huginn       New commit(s) kohagit: Bug 10464: Patron search on placing a hold now supports autocomplete <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dc94a9bef79dc6d186fe93d82dac10cab0468d24>
02:05 huginn       New commit(s) kohagit: Bug 10439: fix bug preventing the library for a notice from being changed <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=77a5e3e365a50b02c9f224d731e05de90fc667c9>
02:56 * jcamins    wanders through humming For I Hold That On The Sea.
03:02 dcook        Members::Search...what?
03:02 jcamins      C4::Members::Search?
03:02 dcook        Errmm Maybe I meant Members(Search)
03:02 dcook        The Search sub in Members.pm :p
03:03 jcamins      Yeah, C4::Members::Search.
03:03 dcook        This example makes no sense to me : $borrowers = Search({''=>'abcd', category_type=>'I'}, 'surname');
03:03 * jcamins    wanders in the opposite direction singing about gentlemanly tones.
03:03 dcook        Or how it's implemented in guarantor_search.pl
03:03 dcook        hehe
03:03 dcook        Good call, jcamins. Good call ;).
03:04 jcamins      The fact that that make perfect sense to me frightens me beyond all measure.
03:04 eythian      what about it makes no sense to you?
03:04 jcamins      I've never looked at the code. :(
03:04 dcook        I don't see any way that the category_type is ever searched
03:04 eythian      oh, right. I don't know.
03:04 jcamins      But that's a keyword search for abcd, limited by category_type, probably ordered by surname.
03:05 dcook        In theory
03:05 dcook        Except category_type is a column in categories
03:05 dcook        Not borrowers..
03:05 dcook        I see no joins
03:06 dcook        I see no reference to category_type (unless it's referenced without its name)
03:06 jcamins      SearchInTable.
03:06 dcook        Yeah, that's what I'm looking at now
03:07 jcamins      What are you trying to do?
03:07 jcamins      I try to avoid C4::SQLHelper.
03:07 dcook        With good reason..
03:07 dcook        Well...we're upgrading another 3.2 client
03:07 dcook        Who wants professionals to be able to guarantee other professionals
03:07 jcamins      [off] It's an example of hyperflation of technical debt.
03:07 jcamins      And this worked in 3.2?
03:08 dcook        With a modification we made, apparently
03:08 jcamins      The same modification should work.
03:08 dcook        But the thing is...I think it's working in 3.8 without modification
03:08 jcamins      Oh, excellent!
03:08 dcook        Except...according to the code...it shouldn't
03:08 dcook        I think O_o
03:08 dcook        Guarantors should only be adults or institutions
03:09 dcook        Search should only be bringing up borrowers with a category_type of "A" or "I"
03:10 dcook        But everyone seems to be coming up which leads me to think that this "filter" doesn't work
03:10 jcamins      Could well be.
03:10 jcamins      [off] See the above [off]
03:10 dcook        [off] I didn't understand the first off, but I think I might follow now
03:13 dcook        I think part of the reason it worked in 3.2 is because it used a totally different sub
03:13 dcook        Which actually made sense
03:15 * dcook      shrugs
03:16 jcamins      Oh, yeah, the great patron search unification.
03:16 jcamins      I did that for 3.4ish or 3.6ish.
03:16 jcamins      *Ian
03:16 jcamins      Not me.
03:18 jcamins      There's probably an RFC on the wiki explaining how it was supposed to work.
03:18 dcook        Yeah...definitely has some issues...but I don't know if I particularly care. Me thinks it would involve quite a bit of rewriting to get it back to a state which doesn't necessarily make a ton of sense anyway
03:20 jcamins      Oh, I wasn't proposing any major refactoring.
03:20 jcamins      I thought you might like an explanation of what it was supposed to be doing, so you could confirm that it had the behavior you wanted.
03:20 jcamins      However, I don't see an RFC.
03:20 jcamins      bag can probably provide you with the spec, though.
03:27 dcook        Hmm
03:28 dcook        I think they might have a note that it doesn't do anything..
03:28 dcook        "NOTE: Current implementation may remove parts of the iinput hashrefs. If that is a problem
03:28 dcook        a copy needs to be created in _filter_fields() below"
03:28 eythian      that's bad programming right there
03:28 eythian      at least it's documented, but still.
03:28 eythian      And not that I haven't done it...
03:29 jcamins      Hehe.
03:29 jcamins      Good night, #koha.
03:29 dcook        night, jcamins
03:29 dcook        eythian: Is that based on what I've said or a look at the files?
03:29 eythian      based on what you said
03:29 dcook        Mmm
03:29 eythian      modifying your input is generally frowned upon
03:30 dcook        That note doesn't actually cover this case either..
03:30 dcook        modifying your input?
03:30 eythian      oh, am I misreading.
03:30 eythian      it sounds like a function is getting a hashref and modifying it
03:31 dcook        I don't think so.
03:31 dcook        I think it takes a hashref and splits it out into an SQL where
03:32 eythian      if it's its own hashref, that's OK
03:33 * dcook      shrugs
03:34 dcook        All I know is that it isn't doing what it says it's doing
03:34 dcook        And it sure looks liike ugly code to me
03:34 dcook        Plus, just found one of these notes: "# An act of desperation"
03:34 dcook        Although like you said...not that I haven't done that either..
03:35 eythian      heh
03:50 dcook        Mmm, I think I'm following this "guarantor" thing a lot more now...
03:50 dcook        Still broken though :p
03:59 dcook        Bug report written up. Time for lunch.h
04:00 dcook        The second h is for hungry...
04:18 dcook        All the bugs...
04:25 dcook        Random question while I remember...does anyone have/know about a "Koha Installation Checklist"?
04:26 eythian      wahanui: koha installation checklist
04:26 wahanui      eythian: huh?
04:26 dcook        While the package install takes care of most things, there are still a few things that a person needs to configure outside of it
04:26 dcook        Such as setting up email
04:26 eythian      we have one for clients, but that's more internal to Koha
04:27 dcook        Internal to Koha?
04:27 dcook        or Catalyst?
04:27 wahanui      Catalyst is a monster, lots of moving parts
04:27 dcook        lol
04:27 eythian      the sort of thing that clients would need.
04:27 dcook        Right, that makes sense
04:27 eythian      we don't have one for systems stuff as that gets set up according to our standard methods anyway.
04:27 dcook        I've just been pondering lately what all I'm missing from my Koha install
04:28 dcook        Makes sense
04:28 dcook        I was thinking that people probably wouldn't have checklists for that reason
04:28 eythian      wouldn't hurt to make one really.
04:28 dcook        I suppose I could be a pioneer in that
04:28 dcook        I just wonder if I'm missing anything
04:28 dcook        I had to re-install Debian yesterday as I somehow managed to totally screw up my network connection
04:28 dcook        No idea how..
04:29 dcook        So I'm going over my notes again...trying to streamline it
04:29 eythian      you probably just needed to edit /etc/network/interfaces
04:29 dcook        Did that
04:29 dcook        Many many times
04:29 dcook        It seemed like the router wasn't giving the server an IP address
04:29 eythian      in that case, a reinstall isn't likely to help
04:29 dcook        If I gave it a static one, it could connect to itself but couldn't ping the router or anything else
04:30 dcook        It seemed to
04:30 dcook        After the re-install, no problems with internet connectivity
04:30 dcook        Mind you...
04:30 dcook        When I was using GParted, I did run the network config utility that's packaged with it
04:30 eythian      that's kinda odd really
04:30 dcook        Since I couldn't connect to the internet through the Gparted dvd either
04:30 dcook        Although I could after I ran that utility
04:30 dcook        :S
04:31 dcook        (I wonder a bit if I had run the utility in Gparted then gone back into my Debian install if it would've worked...)
04:31 dcook        eythian: Really odd. I combed through forums and tried everything, but nothing worked.
04:31 dcook        Reset the router a few times..
04:31 dcook        I had installed VirtualBox, Google Chrome, and a flash plugin for Chromium on Saturday night...
04:32 dcook        Internet worked fine
04:32 dcook        It wasn't until the next morning, when I went to install an SSH server (so I could work from the comfort of bed), that I found no connectivity
04:32 dcook        I half wonder if somehow VirtualBox buggered something up...
04:33 dcook        And I didn't notice until it came time to boot the next morning..
04:33 eythian      well, you can manage vbox's dhcp server, maybe its networking config had gone a bit off.
04:33 eythian      *odd
04:34 dcook        That's about the only thing that I can think that could possibly maybe do it
04:34 dcook        Although I was a bit surprised that VirtualBox would interfere with the connection between the server and the router :S
04:35 eythian      I wouldn't be, virtualbox is providing the networking.
04:35 dcook        Even when no VMs are running?
04:36 eythian      oh, was this the host server?
04:36 dcook        Yep
04:36 eythian      ah
05:00 AmitG        heya mtj around
05:00 dcook        hey ya cait, AmitG
05:00 AmitG        cait
05:00 AmitG        heya dcook
05:15 eythian      http://open.salon.com/blog/jlsathre/2013/05/16/25_things_im_learning_from_closing_a_bookstore
05:16 * cait       waves
05:16 eythian      hello cait
05:16 wahanui      hello cait are you here?
05:26 * magnuse    waves
05:26 magnuse      http://translate.koha-community.org/ down?
05:28 eythian      http://www.downforeveryoneorjustme.com/translate.koha-community.org <-- yep
05:28 dcook        eythian: #16
05:30 dcook        Comic books and graphic novels are totes different..
05:31 dcook        Also, I love how eythian always has a link for that
05:32 eythian      dcook: it's like the old saying goes: give a man a fire, and he's warm for a day. Set a man on fire and he's warm for the rest of his life.
05:33 dcook        lol
05:33 dcook        It wasn't very loud, but that laugh was audible
05:51 drojf        good morning #koha
05:53 dcook        morning drojf
05:56 drojf        hi dcook
06:11 cait         hi drojf
06:13 drojf        hi cait
06:16 sophie_m     hello #koha
06:25 * magnuse    waves again
06:28 marcelr      good morning #koha
06:28 marcelr      cait++ #qa
06:36 reiveune     hello
06:37 AmitG        heya laurence
06:37 laurence     hi AmitG
07:05 Joubu        hello #koha
07:12 magnuse      @wunder marseille
07:12 huginn       magnuse: The current temperature in Marseille, France is 26.0°C (9:00 AM CEST on June 17, 2013). Conditions: Clear. Humidity: 54%. Dew Point: 16.0°C. Pressure: 29.95 in 1014 hPa (Steady).
07:12 magnuse      wow!
07:12 paul_p       hello #koha
07:12 magnuse      @wunder boo
07:12 huginn       magnuse: The current temperature in Bodo, Norway is 10.0°C (8:50 AM CEST on June 17, 2013). Conditions: Scattered Clouds. Humidity: 71%. Dew Point: 5.0°C. Pressure: 29.83 in 1010 hPa (Steady).
07:13 magnuse      that's better
07:13 magnuse      bonjour paul_p
07:13 paul_p       mmm... translate.koha-community.org is down ?
07:18 marcelr      hi france & magnuse
07:19 magnuse      paul_p: looks like it
07:19 magnuse      hiya marcelr
07:25 paul_p       hi marcelr
07:25 paul_p       @wunder amsterdam
07:25 huginn       paul_p: Error: No such location could be found.
07:25 marcelr      :)
07:25 marcelr      i cannot be found
07:25 paul_p       marcelr = bad news, you live in the limbo...
07:26 paul_p       marcelr what about moving to Marseille ? Nice place, beach, a lot of Koha activity, and it exists :D :D
07:26 marcelr      @wunder Netherlands
07:26 huginn       marcelr: Error: No such location could be found.
07:26 marcelr      idem
07:26 paul_p       marcelr lol...
07:26 marcelr      scary
07:26 drojf        @wunder amsterdam, netherlands
07:26 huginn       drojf: The current temperature in Amsterdam, Netherlands is 16.0°C (8:55 AM CEST on June 17, 2013). Conditions: Clear. Humidity: 63%. Dew Point: 9.0°C. Pressure: 30.01 in 1016 hPa (Steady).
07:26 drojf        :)
07:26 marcelr      just 10 degrees lower
07:27 drojf        @wunder berlin, germany
07:27 huginn       drojf: The current temperature in Berlin Tegel, Germany is 19.0°C (9:20 AM CEST on June 17, 2013). Conditions: Clear. Humidity: 56%. Dew Point: 10.0°C. Pressure: 30.09 in 1019 hPa (Steady).
07:27 marcelr      ok
07:27 drojf        not sure if i need 26°C at 9pm on a work day ;)
07:28 christophe_c hello #koha
07:28 drojf        9am
07:32 * magnuse    agrees with drojf :-)
07:32 magnuse      bonjour christophe_c
07:33 AmitG        hyea magnuse
07:34 magnuse      hiya AmitG
07:38 kf           good morning #koha
07:38 christophe_c bonjour magnuse ;-)
07:40 magnuse      wb kf
07:56 kf           hi magnuse and christophe_c
08:06 cjh          found some time to catch up on my rmaint-ing :)
08:07 magnuse      cjh++
08:22 kf           cjh++ :)
08:23 cjh          I dont really deserve the +s, only have to catch up because I got behind :)
08:36 kf           cjh: hm yeah... release soon? :P
08:38 cjh          22nd-ish :p
08:48 Shalom       anyone know how to stop authorities creation from acquisition? i don't want to create the author authorities when i enter an order to the system
11:37 christophe_c hello kf :-[ in late ... I was afk ;-)
11:39 kf           christophe_c: np, i was afk too :)
11:39 christophe_c ;-)
12:03 kf           @later tell bgkriegel I have problems with searching in pootle, could you take a look?
12:03 huginn       kf: The operation succeeded.
12:06 kf           @later tell bgkriegel - it seems to happen only for german? i tested basque and that seemed to work alright :(
12:06 huginn       kf: The operation succeeded.
12:19 nengard      kf i was trying to test bug 9948 again ..but i can't receive anything in today's master
12:19 nengard      can you?
12:19 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 critical, P5 - low, ---, koha-bugs, NEW , acq data going on first item even if not received
12:19 nengard      is there a bug or a data problem on my end?
12:19 kf           hm i coudl receive normally yesterday
12:19 kf           testing master from yesterday, not sure anything related to receiving went in today
12:20 kf           you placed the order with acqcreateitem set to 'on order'?
12:20 nengard      yes
12:20 nengard      there is nothing to receive
12:20 kf           same vendor?
12:20 nengard      but i have 102 bibs waiting to be received
12:20 nengard      i tried 2 vendors
12:20 kf           just trying to think about the mistakes i normally make :)
12:20 kf           oh
12:20 kf           did you close the basket?
12:20 nengard      yes
12:20 kf           hm
12:20 nengard      and no
12:20 nengard      i tried both ways
12:21 nengard      you didn't always have to close a basket
12:21 kf           i can only say that it did work yesterdy
12:21 kf           i think it's more strict now
12:21 nengard      i even created a new order today and tried that and tried and old order
12:21 kf           better to close it when you want to look for late orders and the like
12:21 nengard      of course
12:21 kf           it just shows no order lines?
12:21 nengard      no order lines to receive
12:21 nengard      i see them when i do a search and view the basket
12:21 kf           we used tot tell the libraries not to close...
12:22 kf           i haven't had that happenign
12:22 kf           i used an older order and a new order
12:24 nengard      hmm
12:24 nengard      k
12:25 kf           not sure, can't test here :(
12:26 kf           can you test maybe to go back a little?
12:27 kf           like crate a new branch and do a git reset --hard HEAD~5 or so?
12:28 kf           but it should not make a difference I think... there is not really something acq related in the patches gone in yesterday. hm.
12:28 nengard      omg i figured it out
12:28 nengard      it remembered a search of mine for 'chris' in the acq search
12:28 nengard      i think i might report that as a bug cause i had to have done that weeks ago!!!
12:30 jcamins      nengard: if you mean the web browser auto-remembered, what I do is delete the items with search terms from my history when it starts autocompleting a search and not just the search page.
12:30 kf           jcamins: i couldn't follow you
12:30 nengard      oh good
12:30 nengard      me either
12:31 nengard      thought it was my monday morning brain
12:31 kf           might have a similar brain then
12:31 kf           but i am happy receiving is not broken :)
12:31 nengard      me too!
12:32 jcamins      I have no idea what you mean by "it remembered a search," but assuming you mean "my web browser automatically took me to a page that had prefilled a search for the term 'chris,'" the solution is to delete that URL from your web browser's history.
12:32 nengard      no
12:32 nengard      :)
12:32 jcamins      Okay.
12:32 nengard      so what I did was i clicked 'receive' and the tiny search box to the right of the list of titles you can recieve - the datatable - had a search i had typed in there ages and ages ago
12:32 jcamins      Chrome starts autocompleting URLs that include search strings about once every other week for me.
12:32 nengard      so it wasn't in the url
12:33 kf           oh chrome
12:33 jcamins      Got it.
12:33 nengard      and i'm in FF
12:40 AmitG        heya nengard
12:41 nengard      hello and goodbye ...
12:41 jcamins      He wanted you to know he was thinking of you.
12:41 Viktor       :)
12:42 Viktor       And - Hello all :)
12:42 jcamins      Myshkin managed to cover me with blue ink.
12:42 kf           jcamins: oooh he thinks the color suits you :)
12:42 jcamins      Actually, he just likes blue ink.
12:43 Viktor       Expecting drojf to show up today? (Got the start of a sort of dictionary that we talked about a while back)
12:43 jcamins      The first time I flew to Europe after we moved to NYC, an hour and a half before I was due to leave to catch my plane he managed to dye himself blue from nose to toes.
12:46 kf           jcamins: lol
12:46 kf           do you have photos?
12:47 kf           Viktor: he was here this morning, not sure where he is now - maybe studying in the library :)
12:47 jcamins      No, I was too upset about it to think of that.
12:47 jcamins      I had been owned by a cat for only a few months, and Shari was of course out all day.
12:47 kf           jcamins: !!
12:47 kf           there he went to that lengths to be pretty to say goodbye to you and you don't take a photo
12:47 Viktor       kf Hm - so people here are actually _using_ libraries too? not shure how to feel about that ;)
12:48 jcamins      Viktor: don't worry, it's just drojf.
12:48 kf           i always used to sit in the library with my laptop... good wifi... nice quiet atmosphere... :)
12:48 Viktor       jcamins ;D
12:48 kf           he has reasons :P
12:49 Viktor       I do like the libraries too - it's one of the few places you can sit for a while without opening the wallet.
12:49 kf           i wish i could find scores in pootle... someone translated it to 'points' instead of 'written music'
12:49 Viktor       I'll talk to him about the file later then.
12:50 kf           I know he is working on some dictionary project... samian?
12:50 Viktor       And I hope you lovely people are here later too because my coworkers is taking a coffebreak :)
12:50 kf           he miht show up if we keep talking about him :)
12:50 kf           we probably are..
12:50 * kf         is coloring opacs today
12:51 jcamins      kf: fun!
12:51 Viktor_away  kf - Coloring is fun. We stared last week and had real fun.
12:51 kf           i have one in orange and one in green so far hehe
13:02 jcamins      kf: how many OPACs are you coloring?
13:15 tcohen       morning #koha
13:16 tcohen       hi jcamins
13:26 jcamins      Good morning.
13:30 tcohen       gmcharlt: do u agree we could have parametrizable javascript code to inject the autocomplete code on a per--syspref basis?
13:31 kf           jcamins: 2? :)
13:31 kf           for now
13:35 kf           good morning tcohen
13:35 tcohen       hi kf
13:37 kf           tcohen: maybe you can help... i have problems with searching the german po files :(
13:37 tcohen       problems with pootle?
13:37 kf           yeah
13:37 kf           i am looking for score
13:38 kf           because i have a wrong translation in german, but it gives me no results
13:38 kf           it works in Danish
13:38 kf           hi oak
13:39 Oak          kello kf
13:39 Oak          uh oh
13:39 tcohen       the filters are set to incomplete by default
13:42 tcohen       works for spanish
13:42 tcohen       email bgkriegel please
13:45 kf           tcohen: i will thx
13:45 kf           tcohen: could you do me a favor and try it in german too?
13:45 kf           just to make sure I am not doig it wrong?
13:45 kf           today is a werid monday...
13:45 tcohen       you're right, is not working
13:46 kf           ok, not good, but at least not doing it wrong :)
13:49 kf           tcohen: i am writing him, thx for checking :)
13:50 tcohen       he's not answering on talk, i'll give him a phone call
13:50 kf           i just wrote him - I think it has a bit of time, but thx :)
13:51 kf           I don't want to stress him about ti
13:55 tcohen       he was just walking
13:56 tcohen       said he'll re-run the indexing scripts
14:01 Oak          kf, who among us is the database design expert?
14:02 jcamins      Oak: as a general rule, rangi is the expert in everything.
14:06 Oak          :)
14:06 Oak          but he is the most busy one as well.
14:06 Oak          but you all are.
14:11 gmcharlt     tcohen: probably
14:12 gmcharlt     could you expand a bit on what you're proposing?
14:13 tcohen       its just having a single js function with formid and inputid as parameters, and does everything to set the autocomplete feature
14:14 tcohen       and on a per-syspref basis, call ir on document,ready where applicable
14:14 kf           bgkriegel++ tcohen++ thx!
14:14 tcohen       the refactoring *might* include rewriting the method that creates the list of values
14:14 kf           Oak: it probably depends on your question :)
14:15 gmcharlt     tcohen: yep, sounds reasonable
14:15 tcohen       as the jquery.autocopmlete API expects a JSON to do all the job, and we are building the list on our own...
14:15 tcohen       haven't digged deeper on that (not an jqueryui expert)
14:15 tcohen       but looks like we don't need that
14:16 tcohen       processing on the browser
14:16 Oak          kf: yes i am thinking how to formulate my question.
14:44 tcohen       bug 10471
14:44 huginn       New commit(s) kohagit: Bug 10396: remove unnecessary date-picker widgets from Catalog statistics form <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d7bfba8a106fbb00331e16dbc0943226bad24668>
14:44 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10471 minor, P5 - low, ---, oleonard, Needs Signoff , Global search input box and button geometry not always consistent (browsers, translations)
14:45 kf           Oak: still thinking? :)
14:48 tcohen       kf: does master look like this on chrome for you? http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19024
14:48 kf           tcohen: hm no chrome at work
14:48 kf           what am i looking for there?
14:49 tcohen       the search box
14:50 tcohen       is shorter than the line
14:50 tcohen       should look like this http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19023
14:51 kf           oh
14:51 kf           i didn't notice that so far
14:51 Oak          kf emailing a friend about something different :)
14:55 gmcharlt     tcohen: hmm -- looks OK to me http://librarypolice.com/~gmc/koha-global-search.png
14:55 gmcharlt     Version 27.0.1453.110 m
14:56 tcohen       hmm
14:58 tcohen       that's an unpatched master checkout gmcharlt, right?
14:58 gmcharlt     tcohen: yes
15:08 tcohen       kohacon13?
15:08 wahanui      well, kohacon13 is http://wiki.koha-community.org/wiki/KohaCon13_Summary
15:09 gmcharlt     tcohen: re 10471, what members/members-home.pl does to the global search box is especially egregious
15:11 * tcohen     loves learning new words
15:12 tcohen       should I look how does my patch behave with members-home.pl?
15:13 tcohen       oh, it breaks it
15:14 * gmcharlt   readies rope to rescue tcohen
15:14 gmcharlt     ;)
15:14 tcohen       i shouldn't have looked at circulation and mainpage only
15:15 tcohen       at least the bug is confirmed, what a relief :-P
15:15 Rotkiv       Hi! Does anyone know if the "Tiny CMS"-function will work well with the new theme? (it's branded as for 3.4 and later on the wiki)
15:17 Rotkiv       And does this provide wysiwyg editing?
15:17 Rotkiv       And at best - the possibility to create a 2-dimensional navigation with both topbar and left hand nav.
15:17 Rotkiv       Or is it best to just try to integrate with a CMS?
15:19 gmcharlt     Rotkiv: the Koha-as-CMS workaround should continue to work just fine; however, it doesn't offer WYSIWYG editing
15:19 tcohen       is not that hard to fix gmcharlt
15:20 gmcharlt     tcohen: groovy
15:21 tcohen       is just much more boring than I thought :-P
15:22 gmcharlt     and about to get even more boring, considering the places in acqui, cataloguing, admin, etc. that also adjust the global search box
15:22 Rotkiv       Thanks! Sounds interesting (although not fun...)
15:23 tcohen       of course gmcharlt, the boring part was all the places that need to be touched
15:23 Rotkiv       Is there a bugzilla post for this?
15:23 gmcharlt     Rotkiv: bugzilla post for what?
15:24 Rotkiv       The editable areas of Koha will take care of most of the needs I come across. But many also need static pages in a 2D-grid.
15:25 Rotkiv       gmcharlt for adding wysiwyg that tcohen seems to at least have given some thought :)
15:26 gmcharlt     Rotkiv: ah -- I think tcohen was talking about something else, though
15:26 Rotkiv       Ah - too bad :)
15:26 gmcharlt     as far as a bug goes, bug 7840 might be a good place to add desiderata for the Koha-as-CMS hack
15:26 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 enhancement, P5 - low, ---, nengard, NEW , Remove from manual Koha as a CMS (or add it to master)
15:27 Rotkiv       Thanks!
15:28 Rotkiv       I'll be adding to the wishlist :)
15:29 gmcharlt     cool
15:29 Rotkiv       Is there any known ways to integrate cleanly with a CMS in the meantime? :)
15:30 Rotkiv       I'm thinking about things like keeping the login at the top active when moving to pages in a CMS etc.
15:30 gmcharlt     there have been several bits of work to integrate Koha with Drupal, e.g., https://drupal.org/sandbox/jajm/1833210
15:30 gmcharlt     and adding a catalog search box to a page managed by a CMS is easy, of course
15:32 Rotkiv       Thanks. Yes - integrating 90% is easy. It's the last bits like login and such things that makes it difficult.
15:33 gmcharlt     indeed
15:33 gmcharlt     do you have any particular CMS that you're targeting?
15:36 Rotkiv       To integrate fully in the web for the local community it's SiteVision.
15:36 Rotkiv       Otherwise any good one I guess :)
15:55 reiveune     bye
16:08 huginn       New commit(s) kohagit: Bug 10291: Clarify misleading variable name <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6c3a28b64032d0dcad57df222c42e163385d2e98>
16:18 huginn       New commit(s) kohagit: Bug 10256: Remove some unused subs from Overdues module <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8f20b248e7dd6e10b019b1ec27dfb04796e9b0a5>
16:26 Rotkiv       Thanks for the help and bye!
17:39 kf           bye all
17:57 tcohen       gmcharlt: the patch its getting bigger and bigger
17:58 gmcharlt     tcohen: I thought it might
17:59 jcamins      Which Frankenpatch is this?
18:01 tcohen       jcamins: gmcharlt made me notice my patch for bug 10471 broke several other places, which I'm trying to fix to see how this comes out
18:01 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10471 minor, P5 - low, ---, oleonard, Needs Signoff , Global search input box and button geometry not always consistent (browsers, translations)
18:02 jcamins      Ah.
18:02 magnuse      tcohen++ for not giving up :-)
18:10 pianohacker  Hmm. What's the story with Solr? Seems like it's in an odd halfway-zone of used but not
18:11 magnuse      kia ora cait
18:11 cait         kia ora magnus :)
18:11 magnuse      w00t!
18:12 magnuse      pianohacker: as far as i understand there are libraries using it in production
18:12 pianohacker  makes sense, the code seems ready. Are there things keeping Koha from eventually migrating to it?
18:14 jcamins      pianohacker: right now you have to choose between Solr and, for example, authority records.
18:15 jcamins      And it requires you to install dependencies from CPAN, I think.
18:17 pianohacker  ahhh, that kind of tradeoff :)
18:17 pianohacker  But the speed and search quality are good enough?
18:17 jcamins      I think possibly using Solr also entails deciding not to use serials or acquisitions, but I'm not sure about that.
18:17 jcamins      I have no idea.
18:17 magnuse      pianohacker: and there has been worries about the footprint of Solr for small libraries with small servers - so it's desirable to keep Zebra as an option
18:18 jcamins      I was never able to get it working.
18:18 pianohacker  Okay, cool. Thanks
18:18 magnuse      search rewrite?
18:18 wahanui      hmmm... search rewrite is http://wiki.koha-community.org/wiki/C_&_P_Search_Rewrite_RFC
18:18 pianohacker  Was curious, as that was just starting when I left
18:18 bag          interesting jcamins I hadn't thought along the lines of not using serials etc…  I just thought what you said above that some libraries are only in CPAN
18:19 jcamins      bag: I'm not sure about that. I know that authorities aren't supported, but now that I think about it, I'm not sure I saw any hooks for Solr in Acq or Serials.
18:19 cait         there seems also to be a lto of bugs right now
18:19 cait         a search for solr in bugzilla might bring them up
18:20 jcamins      magnuse: I don't think anyone is using it in production. Rennes switched to Zebra.
18:20 cait         i think it's not quite ready yet - clrh would know
18:20 magnuse      jcamins: oh, that might be, i'm definitely not up to date on it
18:21 pianohacker  It makes me so happy that having to install things from CPAN is now considered odd and a bit of a showstopper
18:21 magnuse      hehe
18:21 pianohacker  The only thing I've ever installed that was harder than Koha 2.2, for instance, was Request Tracker
18:21 bag          HA
18:21 bag          yeah 2.2 was a harder one…  I think dev-week was up there too
18:22 bag          I like the current install :D
18:22 magnuse      apt-get install koha-common?
18:22 pianohacker  yeah
18:23 pianohacker  even git installs are so much better
18:23 pianohacker  no undocumented requirements, etc.
18:23 pianohacker  adding zebra made things tougher, but, well, the alternative :)
18:34 huginn       New commit(s) kohagit: Bug 9665: QA follow up fixing tabs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0e0403372e608dc04d12ce5800a997dd3059e3df> / Bug 9665: add RIS and BIBTEXT bibliographic record export to staff interface <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4b9a6d803f7ad11a4e077140820bfeda0d4d196a>
19:29 nengard      anyone around who knows some jquery? If I want to hide an option from the privacy pull down in the opac what am i missing in this:
19:29 nengard      http://catalog.frenchcc.bywatersolutions.com/cgi-bin/koha/opac-privacy.pl
19:29 nengard      oops
19:29 nengard      $("#privacy option[value='0']").hide();
19:36 rangi        @later tell tcohen http://qunitjs.com/ <-- will help you refactor without causing regressions :)
19:36 huginn       rangi: The operation succeeded.
19:37 rangi        jcamins: that was mean! :)
19:37 cait         morning rangi :)
19:38 rangi        heya cait
19:38 gmcharlt     howdy rangi
19:41 rangi        heya gmcharlt
19:41 wahanui      gmcharlt is, like, an expert in all things library technology
19:41 rangi        see jcamins, not me!
19:43 * magnuse    waves
19:44 * cait       waves back
20:10 huginn       New commit(s) kohagit: Bug 10182: Stay on the same tab after saving a biblio <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=85d1e35b6c377618882a985662dcc7fb7e7aba48>
20:12 jcamins      rangi: but it's true! I consider you an expert in everything!
20:15 * cait       nods
20:15 jcamins      Hey, which university in Iraq has BibLibre been working with?
20:18 magnuse      possibly maybe "Koya University", based on this: http://comments.gmane.org/gmane.education.libraries.koha.devel/9004 ?
20:19 jcamins      magnuse: no, I'm pretty sure Koya is still self-hosted.
20:19 magnuse      okey, just a guess :-)
20:26 jcamins      Hey, do we have a list of security advisories?
20:27 cait         ?
20:28 jcamins      Something to point to when saying "seriously, you probably shouldn't be using 3.2.5 in production."
20:34 jcamins      Wow... I'd forgotten how many security releases we had in the 3.2.x line.
20:36 cait         yeah there were some...
20:36 jcamins      Three!
20:41 huginn       New commit(s) kohagit: Bug 9728: XISBN use bibliographic search instead of SQL to fetch related bibs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dd7fbbd70d5004c7fcf3b9d6a1b26c73d3fcebaa>
20:41 cait         jcamins: three is some.
20:45 magnuse      but it's less than 4!
21:38 eythian      hi
21:43 cait         hi eythian
21:43 eythian      hello cait
21:43 wahanui      hello cait are you here?
21:43 pianohacker  hello eythian
21:43 pianohacker  hmm
21:43 pianohacker  hello pianohacker are you there?
21:43 pianohacker  hello pianohacker
21:43 wahanui      hello pianohacker are you there?
21:44 eythian      heh
21:44 pianohacker  hah! very flexible with its conjugations of "to be"
21:44 eythian      no, just 'is' and 'are' :)
21:44 eythian      no "will be" for example :)
21:44 pianohacker  that's good! We don't need wahanui to be smart
21:44 pianohacker  it wouldn'd be half as entertaining otherwise
21:46 magnuse      kia ora eythian
21:47 eythian      hei magnuse
21:47 magnuse      :-)
21:47 * gmcharlt   firmly opposes anything that would lead to wahanui thinking it can do anything other than live in the moment; doing otherwise risks it singularity-ing its way up to having a time machine, and that's just no good
21:49 * cait       perks up at the mentioning of a time machine
21:51 * eythian    will accept patches to add conjugations such as "woil haven be"
21:51 gmcharlt     eythian++
21:52 rangi        bug 10482
21:52 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 enhancement, P5 - low, ---, fridolyn.somers, Needs Signoff , add items limit and sort to rebuild zebra
21:52 eythian      Not the future perfect tense, however, as it was discovered not to be.
21:52 rangi        is that needed now we use xml ?
21:52 gmcharlt     rangi: I rather suspect it is not needed, or can be made to be not needed
21:52 cait         rangi: was wondering the same
21:53 magnuse      i had some weirdness after i addded ~3000 items, but i did not get around to investigate
21:55 jcamins      I think one of the search routines forced binary MARC.
21:55 magnuse      see also bug 10473
21:55 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 major, P1 - high, ---, amitddng135, Needs Signoff , Max length should be 2 digit for adding multiple copies in add items page
21:55 jcamins      I think I fixed that, though.
21:55 rangi        ah right
21:59 jcamins      magnuse: I wondered about that bug as well.
22:00 magnuse      jcamins: i just disagreed with it and set it to "in discussion"
22:01 jcamins      magnuse++ # coming up with a response that wasn't "are you kidding me?"
22:01 jcamins      You know what I was thinking would be useful?
22:01 cait         magnuse++ yeah goo done
22:01 pianohacker  There is an argument to be made for the maximum amount roughly matching the size of the field, but I don't think that was the intended purpose of the patch
22:02 magnuse      heh, i was just hoping i wasn't too impolite/unfriendly/abrasive/what have you
22:02 cait         nope i don't think so
22:02 jcamins      I was thinking that building search analytics into Koha might be useful.
22:02 magnuse      jcamins: not quite sure what you mean, but it does sound good :-)
22:03 jcamins      magnuse: I'd be interested to know how complex the searches that people are doing in the OPAC are... how much boolean logic, what indexes, and how many records they look at.
22:03 magnuse      ah yes, very cool!
22:04 magnuse      i can sort of guess at the result, but anyway ;-)
22:04 jcamins      So, for example, "people doing title searches generally look at only one result" or "people doing complex boolean searches frequently look at dozens of records."
22:04 jcamins      Yeah, so can I.
22:04 pianohacker  would be a perfect use case for a plugin, though you would have to dive into that can of worms
22:04 jcamins      pianohacker: that wouldn't be suitable for a plugin at all.
22:04 jcamins      There are no hooks to support that functionality.
22:05 jcamins      Hooks to support that sort of thing might be cool, but that's definitely not something I'll be working on.
22:05 pianohacker  jcamins: What are the available hooks?
22:05 jcamins      pianohacker: you can add a link from the Tools screen or the Reports screen.
22:05 cait         if we would store the searches somewhere you could...
22:05 cait         hm not really
22:06 rangi        we do store them
22:06 rangi        for logged in users
22:06 pianohacker  jcamins: Ah, okay. So you could make the staff-side interface, but hooking it into the OPAC would be impossible
22:06 rangi        rangi--
22:06 huginn       rangi: Error: You're not allowed to adjust your own karma.
22:06 pianohacker  hey now
22:06 pianohacker  rangi++
22:06 cait         rangi: what are yo udoing?
22:06 pianohacker  none of that
22:06 wahanui      none of that is currently in Koha. If you want to use it, you'll be pretty much on my own.
22:06 rangi        (i couldnt resist a bad prism joke)
22:06 cait         rangi++
22:07 magnuse      rangi++
22:07 jcamins      The issue I have with using saved searches is that the useful analytics I'm envisioning would be anonymous, and those aren't.
22:09 jcamins      You could do log file analysis, but on the balance I suspect it would be less trouble to just patch Koha to track it for you.
22:17 jcamins      And I'm not really a huge fan of Piwik and JS-based tracking.
22:18 eythian      really, there's no reason to use it.
22:18 eythian      (in this context)
22:19 eythian      we have the data ourselves. Storing searches with a cumulative count and a day attached would let you build pretty graphs.
22:20 eythian      http://www.google.com/trends/ <-- then you could do stuff similar but different to this
22:20 jcamins      Exactly.
22:21 rangi        http://wiki.koha-community.org/wiki/Main_Page/es  <-- cool
22:21 jcamins      Preferably with slightly less emphasis on US pop culture. ;)
22:21 eythian      http://www.google.com/trends/explore?q=koha#q=koha%20software&cmpt=q <-- e.g.
22:21 jcamins      Nice!
22:21 eythian      jcamins: hey, it's the only culture you have ;)
22:22 eythian      (yogurt in the fridge doesn't count!)
22:22 eythian      I wonder what happened in september '08
22:22 jcamins      Hehe.
22:22 jcamins      They started tracking?
22:23 eythian      http://www.google.com/trends/explore?q=koha#q=space%20shuttle&cmpt=q <-- narp, not that.
22:24 jcamins      Oh.
22:24 jcamins      Huh.
22:24 jcamins      Interesting.
22:24 wahanui      interesting is sometimes good and sometimes bad
22:25 pianohacker  huh. check the region on "koha software"
22:26 eythian      yeah, that's slightly odd too
22:31 * jcamins    contemplates forward/next browsing in the staff client.
22:31 magnuse      jcamins++
22:37 jcamins      I would like to do it in a way that works well.
22:38 jcamins      And I'm on the fence about whether it should be JS-based or not.
22:38 * magnuse    is generally in favour of things that work well
22:43 * jcamins    ponders.
22:43 jcamins      Does anyone have any examples of previous/next browsing that are well-done?
22:44 pianohacker  jcamins: what exactly do you mean by that?
22:44 jcamins      pianohacker: elegant implementations in F/OSS software.
22:44 jcamins      I guess that was redundant.
22:44 jcamins      The last 'S' is Software.
22:45 eythian      jcamins: I think perhaps, what do you mean by "previous/next browsing"?
22:45 eythian      Like, history modification, or paging, or...?
22:46 jcamins      eythian: oh. Paging like we have on the OPAC where you can click on a link to go to the next item in the results list without returning to the list.
22:46 eythian      oh, I see.
22:48 pianohacker  oh! That makes sense
22:54 NateC        ok im out
23:03 magnuse      eythian++ for the suggestion on bug 10473
23:03 huginn       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 major, P1 - high, ---, amitddng135, In Discussion , Max length should be 2 digit for adding multiple copies in add items page
23:05 * magnuse    calls it a day (and the best part of a night)
23:05 magnuse      have fun #koha!
23:06 rangi        cya magnuse
23:06 cait         night all
23:06 wahanui      goodnight cait. You'll be back.
23:08 eythian      wahanui: candy is at http://candies.aniwey.net/
23:08 wahanui      OK, eythian.
23:09 cjh          awesome game, spent far too long playing it.
23:14 jcamins      Really? Does it get more interesting after the first ten seconds?
23:14 jcamins      It appears to just be a counter that goes up.
23:16 cjh          I have no idea what you are talking about...
23:16 jcamins      cjh: the link eythian shared?
23:16 cjh          :)
23:20 dcook        morning #koha
23:20 cjh          morning dcook
23:20 dcook        hey ya cjh :)
23:20 jcamins      So here's a question: is it necessary to plan for multiple simultaneous searches in a single session, or can I make the one-search-at-a-time assumption that the OPAC does?
23:22 eythian      jcamins: don't do the thing that means tabs break everything.
23:23 mtompset     Greetings, #koha.
23:23 dcook        hey mtompset
23:23 wahanui      i guess mtompset is disliking the silent warnings flooding his error logs.
23:23 jcamins      eythian: right, I planned not to do that.
23:23 mtompset     Could I get a second set of eyes, to make sure I'm not seeing things.
23:23 eythian      well, that sounds like what you're asking, or isn't it?
23:24 jcamins      eythian: oh, I see what you're sayin.
23:24 jcamins      *saying
23:24 mtompset     I'm looking at C4::Members.pm
23:24 jcamins      eythian: as it happens, tabs (i.e. \t) break the OPAC browser.
23:24 eythian      oh, no. I mean browser tabs
23:24 eythian      ah
23:24 dcook        mtompset: You poor soul
23:24 jcamins      Right, good point.
23:24 mtompset     There's a sub fixup_cardnumber.
23:25 mtompset     Just before the sub there is a @weightings declaration.
23:25 mtompset     There are 7 numbers in it, right?
23:26 mtompset     ~ line 889 in master.
23:27 mtompset     But in the fixup_cardnumber, there is a $i loop.
23:27 mtompset     ~924.
23:27 mtompset     It runs from 0-7.
23:27 mtompset     That's 8 numbers.
23:28 jcamins      That looks wrong to me. If you're using use vars, don't you not use my?
23:28 mtompset     I didn't write that code, so don't ask me. :)
23:28 jcamins      Actually, I was asking because I thought eythian probably knew.
23:29 eythian      use vars is like 'our'
23:29 mtompset     I'm just trying to make sense of it, because something is fishy about this function in general, and the more I work through it. The more I find ugly.
23:29 eythian      so I'd expect using 'my' to locally scope them, which probably isn't what you want.
23:30 jcamins      eythian: that's what I'd expect, too.
23:30 jcamins      Thanks.
23:30 mtompset     'our' or 'use vars' would be more Plak friendly?
23:30 eythian      I'd generally avoid using either
23:30 mtompset     (and more what is expected?)
23:30 eythian      It's rare to need them
23:30 eythian      (not that it doesn't happen, mind)
23:31 rangi        the only reason we need to use an our, is a hack around the fact we are running through plack with a cgi wrapper
23:31 rangi        it should be avoided at all opportunities
23:31 jcamins      Yeah, that should be a my inside the subroutine.
23:31 mtompset     Aaaaaa.... more ugly.
23:31 jcamins      And probably not hardcoded.
23:31 jcamins      mtompset: no, putting the variable inside the routine is less ugly.
23:32 mtompset     cd kohaclone;grep "weightings" `find .`
23:32 mtompset     C4::Input.pm
23:32 * eythian    points out grep -r
23:33 mtompset     AAAAAA.... more ugly.
23:33 jcamins      mtompset: `grep -R C4::Members::weightings *`
23:33 pianohacker  ag!
23:33 eythian      less ugly
23:33 mtompset     checkdigit looks awfully like fixup_cardnumber.
23:33 jcamins      Or -r. Whichever.
23:33 mtompset     I'm not reacting to your suggestion of grep -r, eythian.
23:33 eythian      oh, right
23:36 mtompset     should the validation and the generation functions for cardnumber be split like that?
23:39 mtompset     Okay, I over-reacted a little, but the latter does prove my point that there's a code issue with the former. :)
23:40 eythian      code issues aren't a terrible surprise :)
23:43 mtompset     Eeeww... though the parameter names seems to be a misnomer in the case of checkdigit. If you choose kapito checkdigits and nounique=0, then it really is unique, because it checks the checksum digit.
23:47 * dcook      points to what eythian said
23:47 dcook        As much as I might complain about some parts, the only solution is to write a fix :p
23:56 mtompset     I am working on a fix... it's just that the scope of my fix keeps creeping, it would seem.