Time  Nick             Message
01:26 mtj              tcohen[m]: hiya, trixie build is failing because gconf package has been removed
01:26 mtj              https://tracker.debian.org/pkg/gconf
01:28 mtj              tcohen[m]: any chance we can add an exp/experimental branch to ktd, so we can test stuff without risking breakage on master branch?
02:51 mtj              tcohen[m]: i guess we switch to dconf and dconf-editor, from gconf... hopefully this will work?
02:53 mtj              i confess that i dont know why ktd uses gconf, perhaps just general admin for gnome gui stuff?
02:53 mtj              https://askubuntu.com/questions/249887/gconf-dconf-gsettings-and-the-relationship-between-them
03:10 tcohen[m]        Selenium
06:08 ashimema         Last_seen tracks check-ins so yes, staff saw
06:09 ashimema         Please see the bug, it explains and clarifies and makes all this configurable
06:09 ashimema         The main bug got stuck behind people debating a silly dependency
06:26 marcelr          o/
06:34 ashimema         morning
06:34 dcook_           Thanks marcelr for bug 30843 :)
06:34 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 enhancement, P5 - low, ---, dcook, Signed Off , TOTP expiration delay should be configurable
06:34 marcelr          hi ashimema dcook_
06:34 * dcook_         WAVES
06:35 dcook_           lol capslock
06:35 dcook_           allo marcelr and ashimema
06:35 marcelr          dcook_: 34271
06:36 marcelr          you probably did not read that last comment?
06:36 dcook_           Huh... nope I definitely didn't see that
06:36 marcelr          we were removing those logger calls and you added a few ?
06:37 ashimema         bug 34271
06:37 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34271 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Remove a few Logger statements from REST API
06:38 dcook_           Did I?
06:38 marcelr          i thought so (OAuth client)
06:38 marcelr          but i used a question mark LOL
06:39 dcook_           Not sure about that one, but looks like I did on Koha/REST/V1.pm
06:39 marcelr          it is just peanuts but these patches tend to get stuck in NSO
06:40 * ashimema       grabs 30843 for QA
06:40 marcelr          ashimema++
06:40 ashimema         We've also had people complain, especially in the email context
06:40 dcook_           I'm close to wrapping up for the week and I'm not in much next week. Hmm...
06:40 dcook_           bug 30843
06:40 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 enhancement, P5 - low, ---, dcook, Signed Off , TOTP expiration delay should be configurable
06:40 dcook_           ashimema: Ah yeah we've had complaints on that one
06:41 marcelr          give it a last short dcook_
06:41 marcelr          shot
06:41 dcook_           Trying to sort out your test plan hehe
06:41 marcelr          architectural stuff and test plans..
06:41 ashimema         hard
06:41 dcook_           I've got an idea
06:41 marcelr          hit these endpoints and check your logs
06:41 dcook_           At least for the catches..
06:42 ashimema         i'm back from various holidays and events and things now so should start picking up the pace again
06:42 marcelr          great
06:42 dcook_           ashimema: Just in time for my school holidays and such hehe
06:42 ashimema         apologies for my lack of action of late.. I know you've done lots of security stuff of late dcook_ and I've just not had a moment to look yet ☚ī¸
06:42 dcook_           ashimema: you've been busy!
06:43 dcook_           It has felt sometimes like I'm shouting into the void about security stuff, but... I know a lot of people have had a lot on lately
06:43 dcook_           Anyway, let's see how fast I can do this...
06:44 marcelr          you can
06:45 marcelr          ashimema: i was thinking about backporting that one too
06:45 ashimema         🙂
06:45 ashimema         that void is big.. 😛
06:45 dcook_           Huh.. I put a die in the try and it didn't go to the catch... argh
06:45 dcook_           ashimema: I have an injured foot at the moment too so I'm extra sooky
06:45 marcelr          nice ;)
06:46 ashimema         sooky?
06:47 dcook_           (Australia, Newfoundland, New Zealand, slang) Complaining, whingeing, sad; jealous.
06:47 dcook_           Realized that might be a bit regional... hehe
06:47 ashimema         is that an austrailian or canadian slang?  Never heard that before
06:47 ashimema         haha.
06:47 ashimema         thans
06:47 dcook_           And then I throw in my American style "realized"
06:47 ashimema         thanks
06:47 ashimema         I like
06:47 ashimema         might use that with my cousin next time I talk to her.. haha
06:48 dcook_           Ooops. Looks like my "die" might've worked. marcelr: Where should this be logging to?
06:48 dcook_           The API log probably..
06:48 dcook_           I never think to look there
06:48 dcook_           ashimema: Yass haha
06:48 dcook_           Also Yass is a place here...
06:48 dcook_           Oh while I have you here..
06:49 dcook_           Woohoo, successfully tested one chunk of the patch
06:51 marcelr          thx
06:51 dcook_           I've been writing test reports all day, so I get how hard it is hehe
06:51 dcook_           9 minutes. I can do this..
06:51 dcook_           test all the things..
06:54 dcook_           Cheated a bit with the second half, but looks good to me. Signed off
06:54 * dcook_         buries his head in his other test report now
06:54 marcelr          dcook_: ++
06:54 marcelr          dcook_++
06:54 marcelr          that underscore..
06:54 dcook            hehe
06:55 dcook            I have so many different VPNs. My network is always getting a bit disrupted...
06:55 marcelr          better the network than ..
07:02 ashimema         hugs
07:07 dcook            Phew got it all done. Only went a little over time
07:07 dcook            Hope you all enjoy your Fridays!
07:11 marcelr          same dcook
08:00 * cait           waves
08:02 marcelr          hi cait
08:08 marcelr          ok the may ones in the SO queue are gone
08:08 marcelr          lets do June now people !
08:11 cait             I love your spirit marcelr :)
08:11 cait             catching up on email, hope to join you soon
08:13 cait             marcelr++
08:28 marcelr          any testers ready for bug 29390 btw ?
08:28 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Authorised values: Add a few missing foreign keys
08:29 ashimema         just the title of that one scares me
08:29 marcelr          you are the right candidate
08:29 ashimema         I'd love to see it happen, but I've been mocked for the idea in the past I'm sure
08:29 ashimema         lol
08:29 ashimema         I need to get some bits of my support queue ticked off this morning, but will try to take a look this afternoon for you @:)
08:29 marcelr          its just a "few"
08:31 ashimema         😂
08:32 cait             PedroAmorim[m]: get ready! heh
08:32 ashimema         🙂
08:32 PedroAmorim[m]   ready
08:34 cait             ... ok, I need 10 more minutes *hides*
08:35 cait             getting my dev env ready now
08:40 marcelr          ah nice i got a sip patch ;)
08:41 cait             sip is not really something I have palyed with much
08:42 marcelr          you should
08:42 cait             I have a 'date' with Pedro to poke one of the big thigns we have spent some weeks on already, hope to finish that first while the day is young
08:42 marcelr          it is getting warmer
08:42 marcelr          i should have started earlier ;)
08:42 cait             after the heatwave we had.. this still feels quite nice
08:51 marcelr          @later tell khall you owe me some QAs, just look in SO queue :)
08:51 huginn           marcelr: The operation succeeded.
09:16 cait             I have a bad acq one in SO I'll tackle next - bug 34736
09:16 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 major, P5 - low, ---, nick, Needs Signoff , Item checkboxes move to wrong order line in multi-receive, breaking partial receive
09:18 ashimema         is magnuse on one if his long vacations?
09:19 * ashimema       was hoping to get him to take a look at bug 34737
09:19 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Enhance SIP2SortBinMapping to support additional match conditions
09:19 ashimema         unless Michaela Sieber (BIB) fancied it 😜
09:25 cait             with magnuse you never know...
09:25 cait             ;)
09:31 cait             marcelr: you are toof ast to keep up with today :D
09:32 marcelr          toof
09:32 marcelr          and sooky
09:32 marcelr          picking up new English words
09:32 cait             i just can't type - too fast
09:33 marcelr          ashimema: it is a rich language
09:33 marcelr          too warm cait?
09:33 cait             nah, I am QA... I can break everything, language included
09:36 ashimema         Lol
09:40 cait             bug 34736 is ready for qa - bad bug, trivial fix, just how you like it!
09:40 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 major, P5 - low, ---, nick, Signed Off , Item checkboxes move to wrong order line in multi-receive, breaking partial receive
09:40 marcelr          ok ashimema your 28995 has my attention now
09:42 marcelr          nice fight about underscores
10:01 ashimema         lol
10:01 ashimema         I had entirely forgotten about that one
10:01 ashimema         2 years.. I suppose I can be forgiven for forgetting about it
10:02 ashimema         I was always surprised magnuse never revisited it.. it as a quick fix for him.. not something we've ever been asked for ourselves
10:02 ashimema         thanks for the QA though.. always nice to get another one ticked off the list
10:06 marcelr          np
10:06 cait             bug 28995
10:06 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 enhancement, P5 - low, ---, martin.renvoize, Passed QA , Add --added_after to writeoff_debts.pl
10:07 marcelr          vu #koha
10:07 marcelr          cu
10:08 cait             ... toof ast again ;)
10:08 puphaus[m]       Hello together, i wanted to ask if there is a possibility to send a welcome letter after a user/patron is added via the api? :)
10:09 cait             PedroAmorim[m] and ohters: at lunch, back soon
10:09 cait             bug 33690 - in failed QA currently :(
10:09 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 enhancement, P5 - low, ---, kyle, Failed QA , Add ability to send welcome notice when creating patrons using the REST API
10:09 cait             and hi puphaus[m] :)
10:10 cait             maybe you can strike a deal with ashimema for making this move?
10:11 ashimema         ?
10:12 puphaus[m]       Hi cait :) was not here for too long :D
10:15 puphaus[m]       Do you mean Kyle? He is listed there as assignee :)
10:15 ashimema         cait happens to know I did a whole bunch of the work around welcome emails in the recent past too.. so she probably just thought I might take a look and do it
10:15 * ashimema       is having a quick look now
10:18 ashimema         I'm not sure I agree with requiring a header
10:19 ashimema         perhaps the header should allow override of the preference
10:20 ashimema         but I'd say the preference should be generally adhered to.. so if no header is passed we use the preference
10:23 ashimema         I stand corrected... for csv import we trigger via a checkbox
10:24 puphaus[m]       Oh okay so if the patron is imported via csv a welcome mail is send? i didnt knew that
10:25 ashimema         there's a checkbox
10:25 oleonard         Hi #koha
10:25 ashimema         the majority of these use the value of 'AutoEmailNewUser' though
10:25 ashimema         so the csv import is sort of inconsistent
10:25 ashimema         I'd argue that the checkbox should default to the value of 'AutoEmailNewUser'
10:26 ashimema         which is basically what I'm arguing for the API
10:26 ashimema         I can code that
10:35 puphaus[m]       Maybe I could also help with that, sadly im not that experienced in developing in koha yet
10:40 ashimema         morning tcohen
10:41 tcohen[m]        People silently syncing users with external systems using the API should be able to override any syspref about welcome messages
10:41 ashimema         so having the header as an override makes sense
10:41 tcohen[m]        I mean, it doesn't hurt to allow them
10:41 ashimema         but I don't think we should require the header to get the functionality
10:42 ashimema         the preference is meant to catch all these days
10:42 tcohen[m]        x-koha-override: no-welcome
10:42 ashimema         at least, that's my opnion
10:42 tcohen[m]        The default should be the syspref
10:42 tcohen[m]        Of course
10:42 ashimema         I like the idea of x-koha-override
10:42 ashimema         that's nice
10:43 ashimema         x-koha-override: send-welcome
10:43 ashimema         or yes-welcome/no-welcome ?
10:44 tcohen[m]        Having both options seems useful
10:44 ashimema         agreed
10:45 ashimema         so I'd go with either send-welcome/prevent-welcome or no-welcome|yes-welcome ?
10:45 ashimema         as the pair
10:45 ashimema         we basically want a boolean
10:46 ashimema         whilst I like your idea of transport type.. it would be inconsistent with all the other welcome notice stuff at the moment.. I'd love to see other api's adopt a transport type header in the future maybe.. not sure how many of our API's actually trigger notices right now
10:49 cait             ashimema: it hink a switch would be good independently from the pref, like we have it on the patron import form
10:49 ashimema         so you agree with the current implimentation then
10:49 ashimema         require the header and never use the preference
10:50 cait             welcome-yes/welcome-no? :)
10:50 cait             i think so
10:50 ashimema         and explode the API if the header isn't passed
10:50 cait             the use case for api is different then when you add someone manually
10:50 cait             more flexibility there is good
10:50 ashimema         that's a breaking change in the API
10:51 ashimema         adding a required x-koha-welcome header
10:52 ashimema         my argument is we keep the header optional and default to the preference
10:52 ashimema         so I'm not saying get rid of the option to override it
10:52 ashimema         I'm saying that if you set the preference, in most cases it 'should just work'
10:54 tcohen[m]        +1 # syspref +override. Haven't read about the transport , will think about it for a bit
10:55 ashimema         didn't you write the comment about transport
11:02 ES[m]            Hi folks,... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/VBvktWQyqUKriUTmRWIchLiC>)
11:02 cait             what trransport?
11:03 cait             ashimema: i could live with that - and good docs
11:03 cait             optional that is
11:03 cait             someon going to comment on the bug to give it a nudge?
11:04 ashimema         I'm coding the follow-up
11:05 ashimema         what if email enqueue of send fails tcohen?
11:05 cait             even better :)
11:05 cait             puphaus[m]: maybe you could do the sign-off?
11:05 ashimema         kyle doesn't wrap in an eval like we do elsewhere
11:06 cait             oleonard++
11:09 puphaus[m]       cait: Sure i would be happy to help :)
11:10 cait             excellent :)
11:17 oleonard         ES[m]: That was a lot of questions at once. Perhaps you could do one at a time?
11:18 ES[m]            oleonard: 😀 Welll, I understand. I just wanted to provide as much relevant as possible.
11:18 ES[m]            I have been tackling this weird behaviour from one week
11:19 cait             is this a new instance/installation?
11:20 cait             I have an idea about your issues... but you might not be happy
11:20 cait             when you created teh instance, did you request it with UNIMARC as parameter
11:20 cait             ?
11:20 cait             note: not the web isntaller, you need to do it for both
11:22 ES[m]            cait: During the webinstaller Marc Format: UNIMARC
11:22 cait             yes, but when you created teh instance?
11:23 cait             have a look at your koha-conf.xml
11:23 cait             check if it says unimarc or marc21 in the zebra paths listed there
11:23 ES[m]            cait: Yes it is. It is my very first contact with Koha. I have a LAB with 2 or virtual machines and the situation is the same.
11:23 cait             when creating an instance Koha defaults to MARC21
11:24 cait             the fields in MARC21 and thus the indexing is very different to UNIMARC
11:24 cait             the web isntaller takes care of the data - frameworks etc. , but the instance parameter decides about how your indexing is set up
11:24 ES[m]            cait: You mean editing also the koha-conf.xml ?
11:24 cait             hm you could edit, but not sure if it will give you a perfect result
11:24 cait             but have you verified the koha-conf.xml says marc21?
11:25 cait             first need to prove if that is the issue
11:27 ES[m]            cait: I have installed Koha for at least ten times now, ir orde to tackle this issue. I rollback my virtual machine and run the web installer. I have noticed that the koha-conf.xml does not have the word UNIMARC, all the fields point to MARC21
11:27 cait             yes exactly
11:27 cait             the web installer is one half, the koha-create is the other half
11:27 cait             if you du koha-create -h
11:28 cait             there is a parameter marc-flavour
11:28 cait             --marcflavor flavor       Set the MARC flavor. Valid values are marc21 (default),
11:28 cait             and unimarc.
11:28 ES[m]            <cait> "when you created teh instance..." <- Can you explain this please?
11:28 cait             you need to create your instance with sudo koha-create --marcflavor unimarc if you are a UNIMARC user
11:28 cait             that's the step before running the web installer
11:29 cait             did you create the virtual machine yourself?
11:29 ES[m]            cait: They dont say this in the manual...😀
11:29 cait             which manual?
11:29 cait             then we can try an dfix it
11:30 cait             puphaus[m]: if you still want to sign off on bug 33690 pleasedo, then we can make ashimema do QA ;)
11:30 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 enhancement, P5 - low, ---, kyle, Signed Off , Add ability to send welcome notice when creating patrons using the REST API
11:31 puphaus[m]       Oh sorry didnt see that will do it right now :D
11:32 puphaus[m]       oh it says it is already signed off in bugzilla
11:32 puphaus[m]       :(
11:32 puphaus[m]       im too late sorry
11:33 ashimema         another signoff is never a bad thing 😜
11:33 ashimema         I just reverted the status from Failed QA to the previous Signed Off
11:33 ashimema         it would be good to have someone test the follow-ups I made and sign those
11:34 puphaus[m]       Ah okay but the testplan is still the same?
11:34 ES[m]            <cait> "which manual?" <- I have found a guide to install koha. And all the documentation i have read never mentioned this.
11:35 ES[m]            <cait> "then we can try an dfix it" <- Sure, I will rollback my dev virtuall machine and test it.
11:35 oleonard         ES[m]: If you tell us where you found the installation guide we may be able to correct it
11:36 oleonard         ES[m]: Was it official Koha documentation?
11:39 cait             most Koha users work with MARC21, that's why it's probably often not mentioned
11:41 ES[m]            <oleonard> "ES: If you tell us where you..." <- I have found most of the information in Youtube and an online guide at https://kohasupport.com/how-to-install-koha-library-system-on-ubuntu-server-20-04-lts/. Since there is no installation guide at the https://koha-community.org/ I will create one, seen that i have detailed all the steps of my lab environment.
11:41 oleonard         ES[m]: Did you see this page? https://koha-community.org/documentation/
11:41 cait             and also the official installation guides are always linked to from the releaswe notes
11:42 cait             koahsupport.com is unofficial - as are probabl all the youtube ones
11:42 cait             we can't stop people making up their own, you shoudl always refer to koha-community resources first
11:43 ES[m]            cait: They usually start from the Web Installer
11:43 cait             not true
11:43 cait             https://wiki.koha-community.org/wiki/Koha_on_Debian
11:43 cait             not the official documentation that is
11:47 cait             I have updated that documentation with a note on koha-create for Unimarc users now
11:49 ES[m]            cait: Thanks so much it will save a lot of newbies from unsleepless nights
11:50 ES[m]            <cait> "https://wiki.koha-community.org..." <- I have a detailed installation guide that am building for Ubuntu and I will share
11:51 cait             Ubuntu and Debian should be very similar
12:02 puphaus[m]       sorry i think im doing the testing wrong.. I do not see the notices.. could you help me/ tell me what i did wrong? ashimema  i did "git bz apply 33690" and my curl command is: "curl -v -u koha:koha --request POST 'http://127.0.0.1:8081/api/v1/patrons/' -H "Content-Type: application/json" -H "X-Koha-SendWelcomeEmail: 1" --data-raw '{"surname": "userexample2", "firstname": "userexample2", "address": "Address", "city": "some city", "library_id":
12:02 puphaus[m]       "CPL", "category_id": "S"}'"
12:03 cait             did you restart all teh things?
12:03 cait             restart_all
12:03 cait             just to make sure you are not seeing soemthing cached/old Plack worker
12:07 davidnind        puphaus: is RESTBasicAuth system preference enabled? (see comment #7)
12:10 puphaus[m]       davidnind: Yes, I enabled it. the user creation is successfull i only do Not See the notices
12:12 cait             does your user have an email?
12:13 cait             ok... because I am stuck... what was the api doc url for the opac again?
12:16 cait             ok, now I found it, I was missing the .html
12:24 cait             kidclamp: ping
12:24 cait             I am trying to test bug 33960
12:24 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 enhancement, P5 - low, ---, nick, Needs Signoff , Add ability to retrieve deleted biblios
12:24 cait             http://localhost:8081/api/v1/biblios?deleted=1 is my URL, but I get: Malformed query string
12:24 cait             where is the mistake?
12:24 puphaus[m]       <cait> "does your user have an email?" <- Oh yes I missed it. I only looked after the required fields in the api documentation for adding a patron... but after adding a new user with email its still not showing me a welcome notice :/
12:25 cait             i am not sure if you also need to set up smtp
12:25 cait             so the message can be generated
12:25 cait             or the kohadminuser etc.
12:25 cait             try adding an email to kohaadminemailaddress first
12:25 cait             or maybe see if the notice is generated if you add a user manually?
12:26 cait             with the pref turned on?
12:27 davidnind        I got it to work without the header + setting AutoEmailNewUser (didn't need to setup mail sending)
12:29 cait             for my api question: restart_all ...
12:29 davidnind        I think step 5 in the test plan wasn't updated - maybe this should now be x-koha-override = 1 ?
12:30 cait             ashimema: ?
12:32 cait             how do i tell the biblio endpoint which format I want?
12:32 cait             using postman
12:34 davidnind        puphaus: got it to work with AutoEmailNewUser set to don't send + x-koha-override = welcome_yes (if welcome_no doesn't send)
12:36 cait             i tried adding a header Content-type application/marc-in-json but no luck yet
12:36 davidnind        puphaus: conversely, if AutoEmailNewUser set to send + x-koha-override = welcome_no then no welcome message
12:36 kidclamp         cait: i will look when I can, KTD not working for me currently
12:36 cait             i think some general hints might alread help - trying to work on yoru deletedbiblio API
12:37 davidnind        kidclamp: I think KTD needs a git pull then a ktd pull
12:38 kidclamp         davidnind: will try that next - did a ktd pull, but not a git pull
12:39 puphaus[m]       davidnind: Oh yes now it works :) I should have read the code... So do you wanna sign off the patch? :)
12:39 ES[m]            <cait> "I have updated that documentatio..." <- Can you please correct the command option to --marcflavor instead of --marcflavour
12:40 davidnind        puphaus: mor than happy for you to add your signoff
12:42 kidclamp         hmm...KTD still dying
12:42 kidclamp         https://www.irccloud.com/pastebin/SdmHRR7n/
12:42 kidclamp         something updated in cypress?
12:46 ashimema         ktd pull
12:48 puphaus[m]       <davidnind> "puphaus: mor than happy for..." <- Okay thank you for your help! then i will sign off the patch in a few minutes :)
12:51 davidnind        puphaus++
12:57 kidclamp         Joubu^^
13:05 ashimema         davidnind++
13:05 ashimema         thank you so much for that test plan on bug 33690 🙂
13:05 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 enhancement, P5 - low, ---, kyle, Signed Off , Add ability to send welcome notice when creating patrons using the REST API
13:06 ashimema         kidclamp are you still having issues even after another ktd pull
13:06 kidclamp         yes
13:07 ashimema         try nuking your local node_modules dir
13:07 ashimema         that overrides the one inside ktd
13:07 ashimema         so you may find you've got an older version of cypress there
13:07 ashimema         or alternatively.. run yarn install on your host to update your local node_modules if you prefer
13:07 ashimema         it was causing me all sorts of pain begging of the week
13:14 kidclamp         ashimema++ that seemed to do it (clearing node_modules)
13:15 ashimema         phew
13:20 cait             ES[m]: fixed the typo
13:21 puphaus[m]       i dont rember the command to sign off a bug via ktd and cant find it it in the wiki too. can someone help me? 😅
13:21 cait             just: git so
13:21 cait             in the ktd shell
13:21 cait             requires that you have set up yoru name and emai int he .env file prior to starting ktd
13:22 cait             then next is: git bz attach -e bugnumber HEAD[~number of patches]
13:33 puphaus[m]       Ah thank you! I will try that :)
13:52 oleonard         ThingISBN integration not working?
13:53 cait             h2++
13:53 oleonard         "XISBN Failed Can't use string ("1") as a HASH ref while "strict refs" in use at /kohadevbox/koha/C4/XISBN.pm line 100"
13:54 cait             oh
13:58 caroline_catlady I thought we had removed that? Maybe I imagined it...
13:59 cait             I think you re thinking about something else... that I don#t remember right now :)
13:59 caroline_catlady I'm pretty sure either a Library Thing or an ISBN thing was removed a couple of years ago
13:59 caroline_catlady *Library Thing thing :D
13:59 oleonard         I think it was an OCLC version?
14:00 cait             I think that's it
14:00 ES[m]            Starting from version 23, it comes with error in the Marc Bibliographic Test (fields 410 to 488) use to tabs 3 and 4
14:01 ES[m]            Has anyone noticed this also?
14:01 caroline_catlady yes you're right bug 21226
14:01 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21226 normal, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Remove use of retired OCLC xISBN service
14:03 oleonard         I'm surprised the LibraryThing version has survived as long as it has. I wonder if it stays up to date.
14:04 caroline_catlady ES I don't have any errors in my 23.05, are you using MARC21 or UNIMARC?
14:06 cait             ES[m]: it's normal for UNIMARC right now I am afraid
14:06 cait             942?
14:06 ES[m]            caroline_catlady: UNIMARC. This is my 10th installation and wether you create the database to user MARC21 our UNIMARC it happens the same.
14:07 ES[m]            caroline_catlady: Do you have a fresh install or upgraded from another version?
14:07 caroline_catlady I know someone reported several UNIMARC bugs
14:08 caroline_catlady ES, I have a fresh install with MARC21, one on 23.05, one on 23.06 (development)
14:12 caroline_catlady ES bug 34663
14:12 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34663 normal, P5 - low, ---, koha-bugs, NEW , Errors in UNIMARC default framework
14:15 ES[m]            <caroline_catlady> "ES, I have a fresh install..." <- I was wrongly setting up my dev environment with MARC21 (creating the library without specifying the marcflavor). Now i have just made a new install (specifying the marcflavor to UNIMARC and configured UNIMARC in the web installer) and the situation is pretty much the ssame
14:16 cait             your indexing should work now
14:16 cait             the framework tests is a totally separate issue
14:17 caroline_catlady Yes, like cait said, it is a known bug for UNIMARC. I don't think having subfields in different tabs is a major issue
14:17 caroline_catlady It's just annoying because the test fails
14:17 oleonard         Oh... "URL Request Failed 403 Forbidden"
14:17 caroline_catlady In the mean time, you can change the framework manually in your installation
14:21 oleonard         LibraryThing blocking requests with the "libwww-perl/6.52" user agent
14:32 ES[m]            <cait> "your indexing should work now" <- 100%
14:32 ES[m]            Thanks cait for the guidance.
14:33 ashimema         grr
14:33 ashimema         tests fail after rebase
14:33 ashimema         I best actually look at the code then 😧
14:47 cait             caroline_catlady: still around?
14:47 caroline_catlady yes
14:48 aude_c[m]        caroline++ for explaining the automated screenshots to the mailing list! (and for all your work on this project)
14:48 cait             bug 28449
14:48 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 enhancement, P5 - low, ---, koha-bugs, NEW , Link from basket summary to invoice for an order line
14:48 cait             I am tring to fix it, but not sure how it shoud look like
14:48 cait             do you have a preference?
14:49 cait             column?
14:50 caroline_catlady hm, good question
14:52 cait             and if we do a column, where to place it?
14:52 cait             linking the received might be much easier
14:52 cait             well, at least saving space
14:52 caroline_catlady Yes I like the link in received, but I wonder if it's clear enough
14:53 cait             I think for the CSV export we'll definitely do a separate column
14:53 cait             no way around that
14:55 caroline_catlady I'm trying to find a basket that I have received items in... I have way too many baskets lol
14:56 caroline_catlady There is a column in the Acquisition details tab of the detailed record, that would be a precedent
14:56 caroline_catlady https://snipboard.io/1Qxdip.jpg
14:57 caroline_catlady I think since the CSV needs a column no matter what, and there is a column precedent, I would go with a column... what do you think?
14:57 cait             I'll try :)
14:58 cait             shoudl we put it at the beginning or end of table?
14:58 caroline_catlady The down side, imo, is that a column is there even if there is no content and takes up real estate, but I see that for received items, the Modify and Cancel order columns are empty too
14:59 caroline_catlady I would put it at the end? It's the end of the process so it makes sense in my head for it to be at the end
14:59 cait             we coudl only show it for closed/standing order
14:59 cait             but not sure if that wins us much
15:00 cait             hm not sure if I can check on existing of... I can try, but then it woud still show often
15:00 cait             trying to get it work at all now, will keep you updated if you want :)
15:03 caroline_catlady yeah you can cc me on the bug and I can test it once it's done, although I think you already have eager testers :)
15:03 cait             it looks like an old favourite yes :)
15:34 cait             hm CSV is a bit more difficult - but I got the table working
15:34 caroline_catlady cait++ you can do it!
15:34 cait             it's a method in C4 - requires unit tests, I'll probably file a separate bug
15:35 cait             and also youc an already change it using csv profiles I think
15:42 cait             bug 28449 is ready
15:42 huginn           04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Link from basket summary to invoice for an order line
15:43 cait             oh oops
15:43 cait             small corection needed
15:46 cait             now it's ready :)
15:46 caroline_catlady I'll try to get to it after lunch if no one beats me to it
15:51 cait             no rush, jut sharing my happiness :)
16:02 ashimema         LOL
16:02 ashimema         lovely to see things moving through today
16:03 ashimema         I feel bad, I've been rebasing and things so haven't actually done many QA/so
17:54 tcohen[m]        not only SO/QA count
17:54 tcohen[m]        great community work day
23:10 DIGITALBITS[m]   Hi I am new to Koha, have a simple question, is Elasticsearch working good with Koha? Are actually folks leaving Zebra and using Elasticsearch?
23:44 davidnind        DIGITALBITS: There are "many" libraries using Elasticsearch or OpenSearch, but "many" are still using Zebra as using ElasticSearch/OpenSearch adds another layer
23:45 davidnind        It's really hard to tell how many are using what search engine, but Elasticsearch/Opensearch are being successfully used
23:55 DIGITALBITS[m]   <davidnind> "DIGITALBITS: There are "many..." <- The switch to Elasticsearch is well advised.
23:57 DIGITALBITS[m]   I use Elasticsearch for a CRM and it works great. I think I will try in my koha lab environment. We havent a go live date, so we have room to try and test it.